Repository navigation
[backport cloud/1.49] fix(first-run-tour): fail a run the queue never accepted - #15686
Conversation
Closes #14619 — the one finding from release verification I said I'd hold the release for. It has been sitting fixed-but-unopened on a branch; this brings it onto current `main`. ## What breaks today A **paid** subscriber who is out of credits reaches the tour's Run step, clicks Run, and the tour advances to the Result step. The backend refuses the submission. The card then shows *"Hang tight — your result lands right here the moment it's ready"* **forever**: no error, no terminal state, no way forward except closing the tour. ## Why every existing guard misses it - A refused submission never gets a `prompt_id`, so **no workflow status ever appears** and none of the `running` / `completed` / `failed` branches can fire. - Account preconditions — sign-in, subscription, credits — are deliberately kept out of the error stores by `ComfyApp.queuePrompt`, so the `refused` term cannot see them either. - `canRunWorkflows` is `isActiveSubscription && (!isFreeTier || …)`, which is **true** for this user, so the paywall branch never postpones the tour. Three independent mechanisms, all structurally blind to the same case. ## The fix A deadline on **acceptance**, not on the run: ```ts const ACCEPT_DEADLINE_MS = 15_000 ``` Started when the click reports `generating`, and cleared by *any* status at all (`if (status !== undefined) stopAcceptDeadline()`). So a job that is merely slow is never cut short — only a submission the queue never acknowledged fails. ## Verification `pnpm vitest run src/renderer/extensions/firstRunTour/` — **189 passed (10 files)**. `typecheck` and `format:check` clean. Mutation-tested rather than asserted-green: | mutation | result | | --- | --- | | drop `startAcceptDeadline()` | **1 failed** / 51 passed | | drop the `status !== undefined` clear | **4 failed** / 48 passed | | unmutated | 52 passed | The second one matters: without it the deadline would fail *accepted* runs too, and four tests — including the offline-grace ones — catch that. Also fixes the `generatingRun` test helper, which never acknowledged its run and so was silently modelling a refusal; it now reports a status, matching what the queue actually does, and the unacknowledged case gets its own test. ## Scope This is the **engineering half** of #14619. Deep ruled that this population should be *skipped* — not shown a tour they cannot complete. That product decision is not implemented here and #14619's product half stays with @MaanilVerma. What this changes is that the failure is now terminal and legible instead of an indefinite promise. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: t <t@t.t> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Connor Byrne <c.byrne@comfy.org>
🎭 Playwright: ✅ 1791 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-23T06:01:49.881Z",
"gitSha": "0c01d2f08b9e963cd58003fa851e1a239a622565",
"branch": "backport-15091-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2070.9830000000125,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.957999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.379,
"heapDeltaBytes": 5386240,
"heapUsedBytes": 74342396,
"domNodes": 20,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 21.092999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2048.5569999999598,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.59700000000004,
"heapDeltaBytes": 5734064,
"heapUsedBytes": 74832864,
"domNodes": 20,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 16.343,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.334000000019,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.553,
"layouts": 12,
"layoutDurationMs": 3.807,
"taskDurationMs": 897.3389999999999,
"heapDeltaBytes": -70300,
"heapUsedBytes": 68699380,
"domNodes": 57,
"jsHeapTotalBytes": 21348352,
"scriptDurationMs": 120.79899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.3670000000657,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.402,
"layouts": 12,
"layoutDurationMs": 3.9119999999999995,
"taskDurationMs": 876.05,
"heapDeltaBytes": -21065428,
"heapUsedBytes": 48088464,
"domNodes": -283,
"jsHeapTotalBytes": 21213184,
"scriptDurationMs": 114.004,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.9169999999726,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.515000000000004,
"layouts": 6,
"layoutDurationMs": 0.629,
"taskDurationMs": 374.09099999999995,
"heapDeltaBytes": 8528844,
"heapUsedBytes": 77592448,
"domNodes": 77,
"jsHeapTotalBytes": 19513344,
"scriptDurationMs": 18.709,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1030000000237,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.492,
"layouts": 6,
"layoutDurationMs": 0.7519999999999999,
"taskDurationMs": 405.75899999999996,
"heapDeltaBytes": 8319720,
"heapUsedBytes": 77140632,
"domNodes": 77,
"jsHeapTotalBytes": 19775488,
"scriptDurationMs": 22.413000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 707.1020000000203,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.806999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.672,
"heapDeltaBytes": -10911688,
"heapUsedBytes": 58037788,
"domNodes": 20,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 64.55,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 625.8950000000141,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.738999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.915,
"heapDeltaBytes": -11253992,
"heapUsedBytes": 57551004,
"domNodes": 18,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 63.266000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.2819999999992,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.511,
"heapDeltaBytes": 1936808,
"heapUsedBytes": 64014164,
"domNodes": -280,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 93.46799999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.929,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.07,
"heapDeltaBytes": 7931384,
"heapUsedBytes": 67982240,
"domNodes": -281,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 104.442,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2173.249999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1300.594,
"heapDeltaBytes": 19440308,
"heapUsedBytes": 81043268,
"domNodes": -286,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 442.681,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2146.9509999999445,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1284.252,
"heapDeltaBytes": 5494156,
"heapUsedBytes": 66894704,
"domNodes": -285,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 442.19399999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3125.8000000000266,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.574,
"layouts": 60,
"layoutDurationMs": 7.901999999999999,
"taskDurationMs": 1435.871,
"heapDeltaBytes": 23322968,
"heapUsedBytes": 86037932,
"domNodes": 10,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 505.31800000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3163.1830000000036,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.696999999999996,
"layouts": 60,
"layoutDurationMs": 8.507,
"taskDurationMs": 1532.6209999999999,
"heapDeltaBytes": 23570180,
"heapUsedBytes": 86579700,
"domNodes": 10,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 537.407,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.5510000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.9100000000001,
"heapDeltaBytes": 8778868,
"heapUsedBytes": 70988312,
"domNodes": -285,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 95.727,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2057.555999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.099999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.725,
"heapDeltaBytes": 8382976,
"heapUsedBytes": 70650276,
"domNodes": -283,
"jsHeapTotalBytes": 5562368,
"scriptDurationMs": 113.85600000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.7389999999818,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.157,
"heapDeltaBytes": -11061940,
"heapUsedBytes": 57916448,
"domNodes": 22,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 122.44999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.9530000000323,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.83899999999994,
"heapDeltaBytes": -11228112,
"heapUsedBytes": 57688768,
"domNodes": 18,
"jsHeapTotalBytes": 21610496,
"scriptDurationMs": 129.116,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.6699999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.3610000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.295,
"heapDeltaBytes": 5202564,
"heapUsedBytes": 74307636,
"domNodes": 18,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 16.01,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.5720000000147,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.30600000000004,
"heapDeltaBytes": 5394364,
"heapUsedBytes": 74201148,
"domNodes": 20,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 13.716000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.0519999999842,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.175999999999995,
"layouts": 16,
"layoutDurationMs": 4.732,
"taskDurationMs": 726.733,
"heapDeltaBytes": -4015400,
"heapUsedBytes": 64947140,
"domNodes": 61,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 85.88,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.6669999999813,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.931,
"layouts": 16,
"layoutDurationMs": 4.473999999999999,
"taskDurationMs": 763.015,
"heapDeltaBytes": -3938792,
"heapUsedBytes": 65108464,
"domNodes": 63,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 90.694,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.6659999999247,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.753999999999994,
"layouts": 14,
"layoutDurationMs": 11.231000000000002,
"taskDurationMs": 930.2720000000002,
"heapDeltaBytes": 30630300,
"heapUsedBytes": 100092808,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 34.57500000000001,
"eventListeners": 2375,
"totalBlockingTimeMs": 117,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8250.638999999977,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.88399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4369.0599999999995,
"heapDeltaBytes": 11688172,
"heapUsedBytes": 72012284,
"domNodes": -285,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 1334.717,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.967000000019,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4445.451999999999,
"heapDeltaBytes": 11007644,
"heapUsedBytes": 71144400,
"domNodes": -281,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 1340.955,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17832.582000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17786.076999999997,
"heapDeltaBytes": -59576876,
"heapUsedBytes": 167386932,
"domNodes": -8312,
"jsHeapTotalBytes": -8065024,
"scriptDurationMs": 553.2750000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17901.25499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17885.79,
"heapDeltaBytes": -41731224,
"heapUsedBytes": 170941676,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 559.0659999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21415.211,
"styleRecalcs": 144,
"styleRecalcDurationMs": 19.598000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21370.319000000003,
"heapDeltaBytes": -53290096,
"heapUsedBytes": 154735220,
"domNodes": -8312,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 850.568,
"eventListeners": -16381,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21494.92600000008,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.482999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21470.317,
"heapDeltaBytes": -67660360,
"heapUsedBytes": 154763728,
"domNodes": -8312,
"jsHeapTotalBytes": -7802880,
"scriptDurationMs": 859.107,
"eventListeners": -16385,
"totalBlockingTimeMs": 382,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.96000000002823,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.038,
"layouts": 3,
"layoutDurationMs": 0.755,
"taskDurationMs": 128.542,
"heapDeltaBytes": -15551088,
"heapUsedBytes": 52204180,
"domNodes": 134,
"jsHeapTotalBytes": 7192576,
"scriptDurationMs": 9.497,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 466.94700000000466,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.931,
"layouts": 3,
"layoutDurationMs": 0.6539999999999998,
"taskDurationMs": 118.30199999999999,
"heapDeltaBytes": -15802264,
"heapUsedBytes": 52152552,
"domNodes": 123,
"jsHeapTotalBytes": 7192576,
"scriptDurationMs": 9.245000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #15686 +/- ##
=============================================
Coverage ? 71.93%
=============================================
Files ? 1767
Lines ? 92498
Branches ? 24901
=============================================
Hits ? 66536
Misses ? 25843
Partials ? 119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15091 to
cloud/1.49Automatically created by backport workflow.