Repository navigation
[backport core/1.49] fix(first-run-tour): fail a run the queue never accepted - #15685
Conversation
Closes #14619 — the one finding from release verification I said I'd hold the release for. It has been sitting fixed-but-unopened on a branch; this brings it onto current `main`. ## What breaks today A **paid** subscriber who is out of credits reaches the tour's Run step, clicks Run, and the tour advances to the Result step. The backend refuses the submission. The card then shows *"Hang tight — your result lands right here the moment it's ready"* **forever**: no error, no terminal state, no way forward except closing the tour. ## Why every existing guard misses it - A refused submission never gets a `prompt_id`, so **no workflow status ever appears** and none of the `running` / `completed` / `failed` branches can fire. - Account preconditions — sign-in, subscription, credits — are deliberately kept out of the error stores by `ComfyApp.queuePrompt`, so the `refused` term cannot see them either. - `canRunWorkflows` is `isActiveSubscription && (!isFreeTier || …)`, which is **true** for this user, so the paywall branch never postpones the tour. Three independent mechanisms, all structurally blind to the same case. ## The fix A deadline on **acceptance**, not on the run: ```ts const ACCEPT_DEADLINE_MS = 15_000 ``` Started when the click reports `generating`, and cleared by *any* status at all (`if (status !== undefined) stopAcceptDeadline()`). So a job that is merely slow is never cut short — only a submission the queue never acknowledged fails. ## Verification `pnpm vitest run src/renderer/extensions/firstRunTour/` — **189 passed (10 files)**. `typecheck` and `format:check` clean. Mutation-tested rather than asserted-green: | mutation | result | | --- | --- | | drop `startAcceptDeadline()` | **1 failed** / 51 passed | | drop the `status !== undefined` clear | **4 failed** / 48 passed | | unmutated | 52 passed | The second one matters: without it the deadline would fail *accepted* runs too, and four tests — including the offline-grace ones — catch that. Also fixes the `generatingRun` test helper, which never acknowledged its run and so was silently modelling a refusal; it now reports a status, matching what the queue actually does, and the unacknowledged case gets its own test. ## Scope This is the **engineering half** of #14619. Deep ruled that this population should be *skipped* — not shown a tour they cannot complete. That product decision is not implemented here and #14619's product half stays with @MaanilVerma. What this changes is that the failure is now terminal and legible instead of an indefinite promise. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: t <t@t.t> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Connor Byrne <c.byrne@comfy.org>
🎭 Playwright: ✅ 1788 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-23T06:01:45.135Z",
"gitSha": "0734fc9d3cfc6de2cf36ad06d12ec69da2543156",
"branch": "backport-15091-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2158.0830000000333,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.137999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.3589999999999,
"heapDeltaBytes": 5226760,
"heapUsedBytes": 73786284,
"domNodes": 16,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 17.761999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2037.0159999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6240000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.14599999999996,
"heapDeltaBytes": 5135652,
"heapUsedBytes": 73725644,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 19.413,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.1879999999674,
"styleRecalcs": 71,
"styleRecalcDurationMs": 33.699999999999996,
"layouts": 12,
"layoutDurationMs": 3.7619999999999996,
"taskDurationMs": 812.1400000000001,
"heapDeltaBytes": -66240,
"heapUsedBytes": 68543136,
"domNodes": 54,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 110.997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.4220000000269,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.812,
"layouts": 12,
"layoutDurationMs": 3.4019999999999997,
"taskDurationMs": 863.156,
"heapDeltaBytes": -185740,
"heapUsedBytes": 68207768,
"domNodes": 59,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 119.152,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.3559999999343,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.159,
"layouts": 6,
"layoutDurationMs": 0.7869999999999999,
"taskDurationMs": 388.55199999999996,
"heapDeltaBytes": 8329888,
"heapUsedBytes": 76787128,
"domNodes": 76,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 18.896000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.1380000000117,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.64,
"layouts": 6,
"layoutDurationMs": 0.66,
"taskDurationMs": 393.679,
"heapDeltaBytes": 8520712,
"heapUsedBytes": 77083852,
"domNodes": 77,
"jsHeapTotalBytes": 19255296,
"scriptDurationMs": 21.689,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.4500000000462,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.641000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.221,
"heapDeltaBytes": -11491184,
"heapUsedBytes": 57141664,
"domNodes": 18,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 54.425000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.3540000000612,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.382,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.259,
"heapDeltaBytes": -11263776,
"heapUsedBytes": 57176180,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 56.607,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.559999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.734999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.513,
"heapDeltaBytes": 7982832,
"heapUsedBytes": 67633176,
"domNodes": -283,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 91.433,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2045.8220000000438,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.1769999999999,
"heapDeltaBytes": 11184308,
"heapUsedBytes": 71253896,
"domNodes": -281,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 104.714,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2166.95900000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.387000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1210.8999999999999,
"heapDeltaBytes": 7537916,
"heapUsedBytes": 68354280,
"domNodes": -285,
"jsHeapTotalBytes": 4214784,
"scriptDurationMs": 399.21500000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2163.667000000032,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.349999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1257.43,
"heapDeltaBytes": 7309968,
"heapUsedBytes": 68373904,
"domNodes": -286,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 406.141,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3149.781999999959,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.315000000000001,
"layouts": 60,
"layoutDurationMs": 7.69,
"taskDurationMs": 1422.797,
"heapDeltaBytes": 23428668,
"heapUsedBytes": 86079196,
"domNodes": 12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 506.289,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3179.914999999937,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.453999999999995,
"layouts": 60,
"layoutDurationMs": 8.087,
"taskDurationMs": 1525.316,
"heapDeltaBytes": -1729340,
"heapUsedBytes": 60504860,
"domNodes": -285,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 525.149,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.8520000000626,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.173000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.224,
"heapDeltaBytes": 9418228,
"heapUsedBytes": 71071464,
"domNodes": -284,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 96.97900000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.8020000000943,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.9389999999999,
"heapDeltaBytes": 5097320,
"heapUsedBytes": 66717704,
"domNodes": -283,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 111.319,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.5769999999293,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.67,
"heapDeltaBytes": -11373116,
"heapUsedBytes": 57283660,
"domNodes": 18,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 121.254,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.5050000000547,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.603,
"heapDeltaBytes": -11216172,
"heapUsedBytes": 57345612,
"domNodes": 18,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 121.89099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.4969999999812,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.94500000000005,
"heapDeltaBytes": 5381656,
"heapUsedBytes": 73862064,
"domNodes": 22,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 12.209999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.8229999999548,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.428,
"heapDeltaBytes": 5099944,
"heapUsedBytes": 73841436,
"domNodes": 20,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 16.183,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.2729999999947,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.717999999999996,
"layouts": 16,
"layoutDurationMs": 4.307999999999999,
"taskDurationMs": 710.704,
"heapDeltaBytes": -3840308,
"heapUsedBytes": 64711728,
"domNodes": 60,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 80.813,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.5710000000918,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.536,
"layouts": 16,
"layoutDurationMs": 4.289000000000001,
"taskDurationMs": 776.1320000000001,
"heapDeltaBytes": -3894540,
"heapUsedBytes": 64694048,
"domNodes": 66,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 88.603,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1375.212999999917,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.77199999999999,
"layouts": 13,
"layoutDurationMs": 11.508999999999999,
"taskDurationMs": 983.0930000000002,
"heapDeltaBytes": 30955936,
"heapUsedBytes": 99594132,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 37.157999999999994,
"eventListeners": 2375,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8198.285000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.742999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4207.106000000001,
"heapDeltaBytes": 11468104,
"heapUsedBytes": 71529260,
"domNodes": -284,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1257.723,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8280.130999999983,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.501000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4438.2,
"heapDeltaBytes": 8903760,
"heapUsedBytes": 68461248,
"domNodes": -281,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 1330.729,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17772.538000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17734.028,
"heapDeltaBytes": -65383660,
"heapUsedBytes": 161262560,
"domNodes": -8316,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 592.506,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17760.176,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17737.104000000003,
"heapDeltaBytes": -46110572,
"heapUsedBytes": 166275764,
"domNodes": -8316,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 585.782,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21166.349999999966,
"styleRecalcs": 143,
"styleRecalcDurationMs": 19.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21128.778000000002,
"heapDeltaBytes": -54162344,
"heapUsedBytes": 154276356,
"domNodes": -8316,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 853.274,
"eventListeners": -16383,
"totalBlockingTimeMs": 261,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21588.799999999992,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.162999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21560.990999999998,
"heapDeltaBytes": -45974320,
"heapUsedBytes": 177136888,
"domNodes": -8312,
"jsHeapTotalBytes": -8396800,
"scriptDurationMs": 918.915,
"eventListeners": -16383,
"totalBlockingTimeMs": 288,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.68100000002323,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.408999999999999,
"layouts": 3,
"layoutDurationMs": 0.691,
"taskDurationMs": 79.771,
"heapDeltaBytes": 3293752,
"heapUsedBytes": 71234940,
"domNodes": 113,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.810999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 451.26299999992625,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.715999999999998,
"layouts": 2,
"layoutDurationMs": 0.4010000000000001,
"taskDurationMs": 107.99799999999998,
"heapDeltaBytes": -16040592,
"heapUsedBytes": 51566316,
"domNodes": 123,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 9.063,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #15685 +/- ##
===========================================
Coverage 79.20% 79.21%
===========================================
Files 1854 1854
Lines 108655 108675 +20
Branches 34095 33176 -919
===========================================
+ Hits 86062 86082 +20
Misses 22158 22158
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15091 to
core/1.49Automatically created by backport workflow.