Repository navigation
[backport cloud/1.51] fix(billing): make the Credits panel follow the active billing rail - #15599
Conversation
…15151) ## Summary Settings → Credits still assumed the legacy `/customers` rail, so its activity table never loaded when the balance came from anywhere else, and Invoice History opened the wrong Stripe customer. ## Changes - **What**: - `UsageLogsTable` owns its first load (`immediate` watch on the billing route). It previously started at `loading = true` and waited for a parent `refresh()`, which `CreditsPanel` only fired from `authStore.lastBalanceUpdateTime` — written solely by the legacy `/customers/balance` success path (`authStore.ts:374`). Any path that does not write it leaves the spinner up forever. - `CreditsPanel` refreshes activity off the balance it renders instead of that legacy-only timestamp, so a top-up refreshes the table on both rails. First hydration is skipped, since the table now loads itself. - Invoice History routes through `useBillingContext().manageSubscription()`, matching `SubscriptionFooterLinks`. The legacy `/customers` portal bills a different Stripe customer than the workspace on screen. ## Review Focus Two independent ways to reach the stuck spinner on `main`: 1. **Local/Desktop, new account** — `authStore.fetchBalance()` returns early on a `404` from `/customers/balance` (`authStore.ts:355-358`), so `lastBalanceUpdateTime` is never written. A user with no customer record yet gets a Credits tab that spins forever. 2. **Cloud, workspace rail** — with `billing_control_enabled` off the standalone Credits panel stays in the sidebar (`useSettingUI.ts:325`) while `useWorkspaceBilling.fetchBalance()` supplies the balance from `/billing/balance` and never touches the timestamp. This also becomes the default failure once the workspace switcher is exposed on Local/Desktop (#15051). Other notes: - `AutoRefreshWrapper` is gone from the `UsageLogsTable` tests; the component no longer needs a parent to drive its first fetch. Reverting the `immediate` flag alone fails 19 of the 21 tests. - Legacy `manageSubscription()` also starts the cancellation watcher, which the raw `accessBillingPortal()` call did not. `SubscriptionFooterLinks` already accepts that for the same action, and `browser_tests/tests/localCreditsNoSubscribeUi.spec.ts` (which asserts Invoice History issues `POST /customers/billing`) still passes. ## Screenshots Captured from the same local dev-server setup and viewport with a fully mocked Personal workspace on the workspace billing rail. `billing_control_enabled` is off so the standalone Settings → Credits panel is visible. AS-IS uses base `085c6ec51`; TO-BE uses this PR's head `e9fcd6adc`. | AS-IS | TO-BE | | --- | --- | | Activity stays on the loading indicator because no initial request is issued. | Activity loads from `/api/billing/events` on mount. | |  |  | Linear: [FE-1584](https://linear.app/comfyorg/issue/FE-1584/add-workspace-switcher-to-localdesktop-credits-only-no-settings) Prototype this supports: #15051
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1823 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-22T02:28:44.320Z",
"gitSha": "7401b529273bb238a6def995fcfcfc65aef7d6c2",
"branch": "backport-15151-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2045.0759999999946,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.888,
"heapDeltaBytes": 5176356,
"heapUsedBytes": 70536676,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 8.919999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.7009999999882,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.562000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.109,
"heapDeltaBytes": 4933540,
"heapUsedBytes": 70327696,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.959999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.5359999999982,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.900999999999996,
"layouts": 12,
"layoutDurationMs": 3.732,
"taskDurationMs": 858.03,
"heapDeltaBytes": -80676,
"heapUsedBytes": 65255856,
"domNodes": 56,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 103.805,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.215999999994,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.678000000000004,
"layouts": 12,
"layoutDurationMs": 3.6629999999999994,
"taskDurationMs": 919.162,
"heapDeltaBytes": -16917012,
"heapUsedBytes": 48502284,
"domNodes": -278,
"jsHeapTotalBytes": 23171072,
"scriptDurationMs": 107.335,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1840000000134,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.073000000000004,
"layouts": 6,
"layoutDurationMs": 0.6330000000000001,
"taskDurationMs": 388.943,
"heapDeltaBytes": 8239784,
"heapUsedBytes": 73588856,
"domNodes": 78,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 11.264,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.8759999999147,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.625000000000004,
"layouts": 6,
"layoutDurationMs": 0.7589999999999999,
"taskDurationMs": 419.49,
"heapDeltaBytes": 8007928,
"heapUsedBytes": 73561412,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 12.24,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 595.673000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.45200000000006,
"heapDeltaBytes": -11309740,
"heapUsedBytes": 53952672,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 55.271,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 574.6059999999602,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.386000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.23199999999997,
"heapDeltaBytes": -11660640,
"heapUsedBytes": 53623856,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 49.96000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.2600000000175,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.1220000000001,
"heapDeltaBytes": 12353860,
"heapUsedBytes": 72104128,
"domNodes": -282,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 15.038000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.9680000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.289999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.643,
"heapDeltaBytes": 12463312,
"heapUsedBytes": 72285940,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 16.261000000000006,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.6480000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.745999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.462,
"heapDeltaBytes": 7674912,
"heapUsedBytes": 69047008,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 329.36499999999995,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2167.560999999978,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1251.6640000000002,
"heapDeltaBytes": 1516376,
"heapUsedBytes": 62554748,
"domNodes": -283,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 327.571,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3199.8780000000124,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.357999999999999,
"layouts": 60,
"layoutDurationMs": 7.936999999999999,
"taskDurationMs": 1362.8400000000001,
"heapDeltaBytes": 17375060,
"heapUsedBytes": 79511816,
"domNodes": 10,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 373.68,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3216.5639999999485,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.293999999999999,
"layouts": 60,
"layoutDurationMs": 7.9830000000000005,
"taskDurationMs": 1432.835,
"heapDeltaBytes": -3445220,
"heapUsedBytes": 58501264,
"domNodes": -286,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 364.204,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2037.0849999999905,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.015000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.8829999999999,
"heapDeltaBytes": 13239280,
"heapUsedBytes": 73711632,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 15.598,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.7259999999733,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.141000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.561,
"heapDeltaBytes": 9728204,
"heapUsedBytes": 70791396,
"domNodes": -282,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 14.157000000000004,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.3000000000275,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.9819999999999,
"heapDeltaBytes": -10079084,
"heapUsedBytes": 55561716,
"domNodes": 14,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 116.85399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.885999999984,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.895,
"heapDeltaBytes": -10085500,
"heapUsedBytes": 55726736,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 117.69099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8069999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.495000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.886,
"heapDeltaBytes": 5531036,
"heapUsedBytes": 71157292,
"domNodes": 20,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 8.222,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.6799999999562,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.837000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.958,
"heapDeltaBytes": 5543348,
"heapUsedBytes": 71175148,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.308,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.9909999999873,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.735,
"layouts": 16,
"layoutDurationMs": 4.680999999999999,
"taskDurationMs": 807.154,
"heapDeltaBytes": -4666924,
"heapUsedBytes": 60273912,
"domNodes": 62,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 79.96900000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.034999999962,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.723,
"layouts": 16,
"layoutDurationMs": 4.6129999999999995,
"taskDurationMs": 793.815,
"heapDeltaBytes": -3786868,
"heapUsedBytes": 61913840,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 80.93299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5100000000011,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.191999999999993,
"layouts": 16,
"layoutDurationMs": 11.717000000000002,
"taskDurationMs": 928.7789999999998,
"heapDeltaBytes": -3997968,
"heapUsedBytes": 80372924,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 16.737999999999996,
"eventListeners": 2375,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8187.175999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.565000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4342.568,
"heapDeltaBytes": 4403604,
"heapUsedBytes": 64161672,
"domNodes": -281,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 1015.8100000000001,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8229.769999999917,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.61000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4356.395,
"heapDeltaBytes": 1288764,
"heapUsedBytes": 61951868,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1024.275,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16310.235000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15240.359999999999,
"heapDeltaBytes": -27857668,
"heapUsedBytes": 170587316,
"domNodes": -8312,
"jsHeapTotalBytes": -8589312,
"scriptDurationMs": 110.742,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16436.77200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15261.971000000001,
"heapDeltaBytes": -42748076,
"heapUsedBytes": 167960152,
"domNodes": -8312,
"jsHeapTotalBytes": -11735040,
"scriptDurationMs": 119.877,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18796.20299999999,
"styleRecalcs": 150,
"styleRecalcDurationMs": 18.165999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18258.573,
"heapDeltaBytes": -27642016,
"heapUsedBytes": 183006148,
"domNodes": -8312,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 413.765,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18807.561000000078,
"styleRecalcs": 158,
"styleRecalcDurationMs": 18.102000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18302.518,
"heapDeltaBytes": -26471160,
"heapUsedBytes": 184304024,
"domNodes": -8312,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 413.99600000000004,
"eventListeners": -16383,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 462.1799999999894,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.084999999999997,
"layouts": 3,
"layoutDurationMs": 1.224,
"taskDurationMs": 124.788,
"heapDeltaBytes": 5054176,
"heapUsedBytes": 69543092,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.265999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.3310000000256,
"styleRecalcs": 9,
"styleRecalcDurationMs": 21.384999999999998,
"layouts": 3,
"layoutDurationMs": 1.0419999999999998,
"taskDurationMs": 131.849,
"heapDeltaBytes": 4927724,
"heapUsedBytes": 69505348,
"domNodes": 117,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.419999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.51 #15599 +/- ##
=============================================
Coverage ? 81.55%
=============================================
Files ? 1884
Lines ? 117702
Branches ? 36769
=============================================
Hits ? 95986
Misses ? 21244
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15151 to
cloud/1.51Automatically created by backport workflow.