Repository navigation
[backport core/1.51] fix(billing): make the Credits panel follow the active billing rail - #15598
Conversation
…15151) ## Summary Settings → Credits still assumed the legacy `/customers` rail, so its activity table never loaded when the balance came from anywhere else, and Invoice History opened the wrong Stripe customer. ## Changes - **What**: - `UsageLogsTable` owns its first load (`immediate` watch on the billing route). It previously started at `loading = true` and waited for a parent `refresh()`, which `CreditsPanel` only fired from `authStore.lastBalanceUpdateTime` — written solely by the legacy `/customers/balance` success path (`authStore.ts:374`). Any path that does not write it leaves the spinner up forever. - `CreditsPanel` refreshes activity off the balance it renders instead of that legacy-only timestamp, so a top-up refreshes the table on both rails. First hydration is skipped, since the table now loads itself. - Invoice History routes through `useBillingContext().manageSubscription()`, matching `SubscriptionFooterLinks`. The legacy `/customers` portal bills a different Stripe customer than the workspace on screen. ## Review Focus Two independent ways to reach the stuck spinner on `main`: 1. **Local/Desktop, new account** — `authStore.fetchBalance()` returns early on a `404` from `/customers/balance` (`authStore.ts:355-358`), so `lastBalanceUpdateTime` is never written. A user with no customer record yet gets a Credits tab that spins forever. 2. **Cloud, workspace rail** — with `billing_control_enabled` off the standalone Credits panel stays in the sidebar (`useSettingUI.ts:325`) while `useWorkspaceBilling.fetchBalance()` supplies the balance from `/billing/balance` and never touches the timestamp. This also becomes the default failure once the workspace switcher is exposed on Local/Desktop (#15051). Other notes: - `AutoRefreshWrapper` is gone from the `UsageLogsTable` tests; the component no longer needs a parent to drive its first fetch. Reverting the `immediate` flag alone fails 19 of the 21 tests. - Legacy `manageSubscription()` also starts the cancellation watcher, which the raw `accessBillingPortal()` call did not. `SubscriptionFooterLinks` already accepts that for the same action, and `browser_tests/tests/localCreditsNoSubscribeUi.spec.ts` (which asserts Invoice History issues `POST /customers/billing`) still passes. ## Screenshots Captured from the same local dev-server setup and viewport with a fully mocked Personal workspace on the workspace billing rail. `billing_control_enabled` is off so the standalone Settings → Credits panel is visible. AS-IS uses base `085c6ec51`; TO-BE uses this PR's head `e9fcd6adc`. | AS-IS | TO-BE | | --- | --- | | Activity stays on the loading indicator because no initial request is issued. | Activity loads from `/api/billing/events` on mount. | |  |  | Linear: [FE-1584](https://linear.app/comfyorg/issue/FE-1584/add-workspace-switcher-to-localdesktop-credits-only-no-settings) Prototype this supports: #15051
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-22T02:29:18.529Z",
"gitSha": "32ac5a04d4a6f6b19d59b087dc8dffb68ccaeae9",
"branch": "backport-15151-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.660999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.725000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.5,
"heapDeltaBytes": 5020828,
"heapUsedBytes": 70480116,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.447999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.1940000000468,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.791,
"heapDeltaBytes": 5396336,
"heapUsedBytes": 70885760,
"domNodes": 16,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 9.711,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1917.5960000000032,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.267,
"layouts": 12,
"layoutDurationMs": 3.762,
"taskDurationMs": 936.1170000000001,
"heapDeltaBytes": -17362592,
"heapUsedBytes": 48021692,
"domNodes": -281,
"jsHeapTotalBytes": 24219648,
"scriptDurationMs": 116.65,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1888.3730000000014,
"styleRecalcs": 76,
"styleRecalcDurationMs": 43.099000000000004,
"layouts": 12,
"layoutDurationMs": 4.128000000000001,
"taskDurationMs": 955.575,
"heapDeltaBytes": -17811932,
"heapUsedBytes": 47463872,
"domNodes": -281,
"jsHeapTotalBytes": 23433216,
"scriptDurationMs": 120.87299999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.4100000000035,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.1,
"layouts": 6,
"layoutDurationMs": 0.539,
"taskDurationMs": 362.834,
"heapDeltaBytes": 7992188,
"heapUsedBytes": 73410656,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.769,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.8380000000107,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.252,
"layouts": 6,
"layoutDurationMs": 0.704,
"taskDurationMs": 367.298,
"heapDeltaBytes": 7664088,
"heapUsedBytes": 73066804,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 8.951999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 570.4599999999687,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.6899999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.80800000000005,
"heapDeltaBytes": -11762396,
"heapUsedBytes": 53649292,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 56.193,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 589.285000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.181,
"heapDeltaBytes": -11668704,
"heapUsedBytes": 53645704,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 62.406,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.290000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.309999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.9219999999999,
"heapDeltaBytes": 12312100,
"heapUsedBytes": 72103000,
"domNodes": -281,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 12.613000000000007,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.7789999999477,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.365999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.4599999999999,
"heapDeltaBytes": 12492524,
"heapUsedBytes": 72320612,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 12.601,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2172.8540000000294,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1180.228,
"heapDeltaBytes": 8321608,
"heapUsedBytes": 69033784,
"domNodes": -284,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 342.68899999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2314.8159999999507,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.029999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1305.557,
"heapDeltaBytes": 10445048,
"heapUsedBytes": 71180556,
"domNodes": -283,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 365.529,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3197.2450000000094,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.402,
"layouts": 60,
"layoutDurationMs": 7.16,
"taskDurationMs": 1382.6670000000001,
"heapDeltaBytes": -3785624,
"heapUsedBytes": 58547336,
"domNodes": -287,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 391.234,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3263.2289999999102,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.516000000000002,
"layouts": 60,
"layoutDurationMs": 8.075000000000001,
"taskDurationMs": 1487.247,
"heapDeltaBytes": 737792,
"heapUsedBytes": 62732708,
"domNodes": -287,
"jsHeapTotalBytes": 4554752,
"scriptDurationMs": 414.47299999999996,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.565999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.135000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.362,
"heapDeltaBytes": 5978316,
"heapUsedBytes": 67156964,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 16.175,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.8070000000007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.849,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.628,
"heapDeltaBytes": 13416488,
"heapUsedBytes": 74905044,
"domNodes": -285,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 15.219,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.1729999999739,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.02000000000004,
"heapDeltaBytes": -9880176,
"heapUsedBytes": 55578880,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 122.533,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.6660000000275,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.2,
"heapDeltaBytes": -11570832,
"heapUsedBytes": 53998832,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 127.34899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2009.7260000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.42199999999997,
"heapDeltaBytes": 5507680,
"heapUsedBytes": 71185056,
"domNodes": 20,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 5.434999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2038.5350000000244,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.4799999999999,
"heapDeltaBytes": 5525760,
"heapUsedBytes": 71076732,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.5169999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.3350000000014,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.526,
"layouts": 16,
"layoutDurationMs": 4.689,
"taskDurationMs": 770.432,
"heapDeltaBytes": -3741752,
"heapUsedBytes": 61912256,
"domNodes": 62,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 81.66499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.5869999999604,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.492,
"layouts": 16,
"layoutDurationMs": 4.532,
"taskDurationMs": 750.462,
"heapDeltaBytes": -3856408,
"heapUsedBytes": 61797404,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 84.702,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1432.4139999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.71800000000001,
"layouts": 15,
"layoutDurationMs": 12.846,
"taskDurationMs": 997.6320000000001,
"heapDeltaBytes": -9635148,
"heapUsedBytes": 74184776,
"domNodes": 13673,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 17.575,
"eventListeners": 2375,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.800999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.7,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4043.9110000000005,
"heapDeltaBytes": 8654200,
"heapUsedBytes": 71247176,
"domNodes": -281,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1032.113,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8217.047999999977,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.123000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4061.694,
"heapDeltaBytes": 14499756,
"heapUsedBytes": 74621512,
"domNodes": -282,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1019.377,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16947.091999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16079.810000000001,
"heapDeltaBytes": -26500656,
"heapUsedBytes": 171948660,
"domNodes": -8312,
"jsHeapTotalBytes": -7540736,
"scriptDurationMs": 125.03900000000002,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17393.223000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16446.645,
"heapDeltaBytes": -27025872,
"heapUsedBytes": 170344552,
"domNodes": -8312,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 123.532,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20505.119999999977,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.10900000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19943.292,
"heapDeltaBytes": -45903620,
"heapUsedBytes": 164545552,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 413.459,
"eventListeners": -16381,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21182.913999999982,
"styleRecalcs": 176,
"styleRecalcDurationMs": 23.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20460.557999999997,
"heapDeltaBytes": -22087444,
"heapUsedBytes": 175200148,
"domNodes": -8312,
"jsHeapTotalBytes": -14954496,
"scriptDurationMs": 453.631,
"eventListeners": -16383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 468.30400000010286,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.738,
"layouts": 3,
"layoutDurationMs": 1.2560000000000002,
"taskDurationMs": 120.18900000000001,
"heapDeltaBytes": 5070484,
"heapUsedBytes": 69502544,
"domNodes": 150,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.502999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.8630000001085,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.642999999999997,
"layouts": 3,
"layoutDurationMs": 1.5010000000000001,
"taskDurationMs": 123.282,
"heapDeltaBytes": 5066916,
"heapUsedBytes": 69689404,
"domNodes": 149,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.028,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 1827 passed, 0 failed · 1 flaky📊 Browser Reports
|
🎭 Playwright: ⏳ Running... |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15598 +/- ##
=============================================
+ Coverage 81.62% 81.64% +0.02%
=============================================
Files 1884 1884
Lines 107109 107107 -2
Branches 33108 33108
=============================================
+ Hits 87424 87449 +25
+ Misses 19351 19314 -37
- Partials 334 344 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15151 to
core/1.51Automatically created by backport workflow.