Repository navigation
[backport cloud/1.51] fix: reset workspace selector button styles (FE-1739) - #15574
Conversation
## Summary Fixes [FE-1739](https://linear.app/comfyorg/issue/FE-1739/): the workspace selector in the profile popover inherited native browser button styling after PR #15164 changed it from a `<div>` to a semantic `<button>`. ## Changes - **What**: Reset the selector's native appearance with `appearance-none`, `border-0`, `bg-transparent`, and `text-left` while preserving its button semantics and existing interactions. - **Regression coverage**: Add a focused Playwright screenshot for the selector's neutral menu-row appearance. - **Backports**: Required for `core/1.51` and `cloud/1.51`; staging is currently on the affected `cloud/v1.51.9` (`ad9f651`). ## Review Focus Confirm the selector remains a full-width semantic button without Chromium's native gray fill or border. ## Testing - `pnpm test:unit src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` (17/17 passed) - Focused Cloud Playwright screenshot test - `pnpm typecheck` - `pnpm typecheck:browser` - Lint, stylelint, oxlint, and oxfmt via the commit hook ## Screenshot  Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1821 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-21T20:12:59.966Z",
"gitSha": "727a6739e2938eb92fd76ca3bf817916ec7e4278",
"branch": "backport-15572-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2101.914000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.204,
"heapDeltaBytes": 5093012,
"heapUsedBytes": 70534256,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.132,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2071.62500000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.84599999999995,
"heapDeltaBytes": 5066536,
"heapUsedBytes": 70476188,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.835,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2042.6160000000095,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.18999999999999,
"layouts": 12,
"layoutDurationMs": 4.05,
"taskDurationMs": 1016.402,
"heapDeltaBytes": -16821956,
"heapUsedBytes": 48845200,
"domNodes": -281,
"jsHeapTotalBytes": 22646784,
"scriptDurationMs": 117.67699999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.5249999999623,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.446999999999996,
"layouts": 12,
"layoutDurationMs": 3.418999999999999,
"taskDurationMs": 900.938,
"heapDeltaBytes": -18615780,
"heapUsedBytes": 46810036,
"domNodes": 0,
"jsHeapTotalBytes": 23957504,
"scriptDurationMs": 108.94800000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2819999999933,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.212,
"layouts": 6,
"layoutDurationMs": 0.694,
"taskDurationMs": 404.39399999999995,
"heapDeltaBytes": 8102444,
"heapUsedBytes": 73426356,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 11.496,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.187000000068,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.771,
"layouts": 6,
"layoutDurationMs": 0.786,
"taskDurationMs": 381.78000000000003,
"heapDeltaBytes": 8449536,
"heapUsedBytes": 74223412,
"domNodes": 77,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 10.356,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 610.1659999999924,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.99,
"heapDeltaBytes": -11434316,
"heapUsedBytes": 53978704,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 54.321999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 621.8559999999798,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.585,
"heapDeltaBytes": -11647552,
"heapUsedBytes": 53846740,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 58.2,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.7989999999631,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.0059999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.471,
"heapDeltaBytes": 12652380,
"heapUsedBytes": 72722092,
"domNodes": -281,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 16.564000000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.438999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.0409999999999,
"heapDeltaBytes": 12207856,
"heapUsedBytes": 72797880,
"domNodes": -282,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 16.081,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2188.3189999999786,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1180.523,
"heapDeltaBytes": 5344100,
"heapUsedBytes": 66350636,
"domNodes": -285,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 304.29100000000005,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2179.4190000000526,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.592999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1141.6390000000001,
"heapDeltaBytes": 9661932,
"heapUsedBytes": 71179168,
"domNodes": -283,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 304.051,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3181.213000000014,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.92,
"layouts": 60,
"layoutDurationMs": 8.594000000000001,
"taskDurationMs": 1370.3319999999999,
"heapDeltaBytes": 16515380,
"heapUsedBytes": 79306148,
"domNodes": 12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 391.987,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3180.9240000000045,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.179000000000002,
"layouts": 60,
"layoutDurationMs": 8.104,
"taskDurationMs": 1384.056,
"heapDeltaBytes": -4242908,
"heapUsedBytes": 58237812,
"domNodes": -289,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 387.578,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.84800000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.178,
"heapDeltaBytes": 12717856,
"heapUsedBytes": 73782164,
"domNodes": -285,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 14.409999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.8560000000089,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.590999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.683,
"heapDeltaBytes": 12145032,
"heapUsedBytes": 72979740,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 14.032999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.8080000000064,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.09200000000004,
"heapDeltaBytes": -11041492,
"heapUsedBytes": 54348772,
"domNodes": 18,
"jsHeapTotalBytes": 27000832,
"scriptDurationMs": 121.44599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.819999999947,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.409,
"heapDeltaBytes": -11063388,
"heapUsedBytes": 54425628,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 119.332,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2005.9520000000362,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.60900000000004,
"heapDeltaBytes": 5347028,
"heapUsedBytes": 70942432,
"domNodes": 22,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.336999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.692999999951,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.184999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.59000000000003,
"heapDeltaBytes": 5098996,
"heapUsedBytes": 70545488,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.879999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.7190000000164,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.765,
"layouts": 16,
"layoutDurationMs": 4.727,
"taskDurationMs": 780.7819999999999,
"heapDeltaBytes": -3615920,
"heapUsedBytes": 61882536,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 85.39,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.3419999999824,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.874,
"layouts": 16,
"layoutDurationMs": 4.3149999999999995,
"taskDurationMs": 742.614,
"heapDeltaBytes": -3571804,
"heapUsedBytes": 61892680,
"domNodes": 61,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 83.12,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6459999999906,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.637999999999998,
"layouts": 14,
"layoutDurationMs": 11.26,
"taskDurationMs": 1000.1439999999999,
"heapDeltaBytes": -9818072,
"heapUsedBytes": 76163192,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 16.594000000000005,
"eventListeners": 2375,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.85199999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.059,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4110.16,
"heapDeltaBytes": 13722656,
"heapUsedBytes": 74338144,
"domNodes": -284,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1001.6470000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8196.043999999914,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3971.2070000000003,
"heapDeltaBytes": 14679888,
"heapUsedBytes": 74421892,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 927.934,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18472.233999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17461.694000000003,
"heapDeltaBytes": -27121660,
"heapUsedBytes": 171241596,
"domNodes": -8312,
"jsHeapTotalBytes": -7245824,
"scriptDurationMs": 131.34699999999998,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18357.27399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17424.422,
"heapDeltaBytes": -42052636,
"heapUsedBytes": 168314460,
"domNodes": -8312,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 145.617,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22120.89500000002,
"styleRecalcs": 176,
"styleRecalcDurationMs": 21.33400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21423.652000000002,
"heapDeltaBytes": -22266848,
"heapUsedBytes": 176398216,
"domNodes": -8316,
"jsHeapTotalBytes": -13901824,
"scriptDurationMs": 442.78499999999997,
"eventListeners": -16381,
"totalBlockingTimeMs": 148,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21811.51299999999,
"styleRecalcs": 177,
"styleRecalcDurationMs": 21.658999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21119.865,
"heapDeltaBytes": -12959480,
"heapUsedBytes": 185740204,
"domNodes": -8312,
"jsHeapTotalBytes": -15474688,
"scriptDurationMs": 414.65999999999997,
"eventListeners": -16385,
"totalBlockingTimeMs": 219,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 518.0890000000318,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.538999999999998,
"layouts": 3,
"layoutDurationMs": 0.717,
"taskDurationMs": 116.18199999999999,
"heapDeltaBytes": 4951588,
"heapUsedBytes": 69664540,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.573999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 118.0699999999888,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.681000000000001,
"layouts": 2,
"layoutDurationMs": 0.621,
"taskDurationMs": 80.788,
"heapDeltaBytes": 3103864,
"heapUsedBytes": 67934704,
"domNodes": 108,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.322999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #15574 +/- ##
=============================================
Coverage ? 81.53%
=============================================
Files ? 1884
Lines ? 117713
Branches ? 37248
=============================================
Hits ? 95973
Misses ? 21270
Partials ? 470
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15572 to
cloud/1.51Automatically created by backport workflow.