Repository navigation
[backport core/1.51] fix: reset workspace selector button styles (FE-1739) - #15573
Conversation
## Summary Fixes [FE-1739](https://linear.app/comfyorg/issue/FE-1739/): the workspace selector in the profile popover inherited native browser button styling after PR #15164 changed it from a `<div>` to a semantic `<button>`. ## Changes - **What**: Reset the selector's native appearance with `appearance-none`, `border-0`, `bg-transparent`, and `text-left` while preserving its button semantics and existing interactions. - **Regression coverage**: Add a focused Playwright screenshot for the selector's neutral menu-row appearance. - **Backports**: Required for `core/1.51` and `cloud/1.51`; staging is currently on the affected `cloud/v1.51.9` (`ad9f651`). ## Review Focus Confirm the selector remains a full-width semantic button without Chromium's native gray fill or border. ## Testing - `pnpm test:unit src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` (17/17 passed) - Focused Cloud Playwright screenshot test - `pnpm typecheck` - `pnpm typecheck:browser` - Lint, stylelint, oxlint, and oxfmt via the commit hook ## Screenshot  Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1825 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-21T20:12:38.777Z",
"gitSha": "8c57f174b5b594a207564e0284dbb21bfb083fed",
"branch": "backport-15572-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2110.683999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.096,
"heapDeltaBytes": 5344812,
"heapUsedBytes": 70825304,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 10.294,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.4629999999452,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.15099999999995,
"heapDeltaBytes": 5045092,
"heapUsedBytes": 70528188,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 8.11,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.0059999999899,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.637,
"layouts": 12,
"layoutDurationMs": 3.64,
"taskDurationMs": 748.262,
"heapDeltaBytes": 76936,
"heapUsedBytes": 65646232,
"domNodes": 56,
"jsHeapTotalBytes": 24121344,
"scriptDurationMs": 96.029,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1699.6900000000323,
"styleRecalcs": 71,
"styleRecalcDurationMs": 29.387000000000004,
"layouts": 12,
"layoutDurationMs": 2.9990000000000006,
"taskDurationMs": 704.66,
"heapDeltaBytes": 39852,
"heapUsedBytes": 65436944,
"domNodes": 55,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 90.92,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.7249999999776,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.572,
"layouts": 6,
"layoutDurationMs": 0.542,
"taskDurationMs": 380.73100000000005,
"heapDeltaBytes": 7673424,
"heapUsedBytes": 73114096,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.421999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.86199999994,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.362000000000002,
"layouts": 6,
"layoutDurationMs": 0.541,
"taskDurationMs": 293.623,
"heapDeltaBytes": 7658292,
"heapUsedBytes": 73145980,
"domNodes": 77,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.235999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 544.2739999999731,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.5760000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.764,
"heapDeltaBytes": -11709476,
"heapUsedBytes": 53622372,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 47.034,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 542.1059999999898,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.359999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.651,
"heapDeltaBytes": -11882224,
"heapUsedBytes": 53671976,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 44.726,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2101.111000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.003000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.355,
"heapDeltaBytes": 8705280,
"heapUsedBytes": 69978864,
"domNodes": -284,
"jsHeapTotalBytes": 1933312,
"scriptDurationMs": 20.464,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2017.0280000000957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.9399999999999,
"heapDeltaBytes": 12615084,
"heapUsedBytes": 73221396,
"domNodes": -281,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 13.943999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2347.568000000024,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.713999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1194.3539999999998,
"heapDeltaBytes": 2014660,
"heapUsedBytes": 63194124,
"domNodes": -286,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 306.192,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2110.828999999967,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.536000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 979.8720000000001,
"heapDeltaBytes": 22158600,
"heapUsedBytes": 83815864,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 259.855,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3182.687000000044,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.877,
"layouts": 60,
"layoutDurationMs": 7.772000000000001,
"taskDurationMs": 1276.24,
"heapDeltaBytes": -3481512,
"heapUsedBytes": 58588464,
"domNodes": -286,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 342.654,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3120.3819999999496,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.574000000000002,
"layouts": 60,
"layoutDurationMs": 7.4319999999999995,
"taskDurationMs": 1131.252,
"heapDeltaBytes": 15820684,
"heapUsedBytes": 80540676,
"domNodes": 16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 315.152,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.9980000000073,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.305999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.447,
"heapDeltaBytes": 11128664,
"heapUsedBytes": 72733412,
"domNodes": -285,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 21.169999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.31199999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.2890000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.0180000000001,
"heapDeltaBytes": 13234420,
"heapUsedBytes": 74741412,
"domNodes": -280,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 13.827000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.5940000000141,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.075000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.279,
"heapDeltaBytes": -9906312,
"heapUsedBytes": 55660900,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 101.85600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.6899999999605,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.687999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.46999999999997,
"heapDeltaBytes": -9983220,
"heapUsedBytes": 55611692,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 96.804,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1995.9259999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.813000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.717,
"heapDeltaBytes": 5544672,
"heapUsedBytes": 71153056,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.028999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1997.8860000001077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.856,
"heapDeltaBytes": 5381636,
"heapUsedBytes": 71054404,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.6190000000000015,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.7339999999726,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.917,
"layouts": 16,
"layoutDurationMs": 3.712,
"taskDurationMs": 665.181,
"heapDeltaBytes": -3742328,
"heapUsedBytes": 61948688,
"domNodes": 63,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 75.57,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1683.2900000000564,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.720000000000002,
"layouts": 16,
"layoutDurationMs": 3.4329999999999994,
"taskDurationMs": 651.586,
"heapDeltaBytes": -3817592,
"heapUsedBytes": 61961792,
"domNodes": 63,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 73.48599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1284.134999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.256,
"layouts": 15,
"layoutDurationMs": 9.249000000000002,
"taskDurationMs": 822.8289999999998,
"heapDeltaBytes": -5841828,
"heapUsedBytes": 76997716,
"domNodes": 13673,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 14.698999999999996,
"eventListeners": 2375,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8540.499999999953,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.05800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4076.898,
"heapDeltaBytes": 12865420,
"heapUsedBytes": 73387432,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 929.083,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8138.725000000022,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.181999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3460.991,
"heapDeltaBytes": 12909780,
"heapUsedBytes": 73140476,
"domNodes": -281,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 812.279,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16078.99100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15206.502,
"heapDeltaBytes": -42858068,
"heapUsedBytes": 168504260,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 132.249,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14850.603999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14312.468,
"heapDeltaBytes": -31684336,
"heapUsedBytes": 168828832,
"domNodes": -8312,
"jsHeapTotalBytes": -13836288,
"scriptDurationMs": 94.402,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18116.78900000004,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.150000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17612.684,
"heapDeltaBytes": -27763816,
"heapUsedBytes": 171020780,
"domNodes": -8312,
"jsHeapTotalBytes": -13901824,
"scriptDurationMs": 365.60200000000003,
"eventListeners": -16385,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17596.44800000001,
"styleRecalcs": 155,
"styleRecalcDurationMs": 15.831000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17083.296000000002,
"heapDeltaBytes": -20302332,
"heapUsedBytes": 191350208,
"domNodes": -8312,
"jsHeapTotalBytes": -9445376,
"scriptDurationMs": 352.314,
"eventListeners": -16387,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 472.58099999999104,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.964,
"layouts": 2,
"layoutDurationMs": 0.37699999999999995,
"taskDurationMs": 90.933,
"heapDeltaBytes": 4953528,
"heapUsedBytes": 69588084,
"domNodes": 126,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.269,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 460.8180000000175,
"styleRecalcs": 15,
"styleRecalcDurationMs": 18.698,
"layouts": 3,
"layoutDurationMs": 0.9600000000000001,
"taskDurationMs": 102.02999999999999,
"heapDeltaBytes": 4954260,
"heapUsedBytes": 69673528,
"domNodes": 125,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.781000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #15573 +/- ##
===========================================
Coverage 81.53% 81.53%
===========================================
Files 1884 1884
Lines 117713 117713
Branches 36774 37248 +474
===========================================
Hits 95973 95973
Misses 21270 21270
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15572 to
core/1.51Automatically created by backport workflow.