Repository navigation
refactor: centralize remaining ECS entity data #15544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e503f3d
refactor: centralize remaining ECS entity data
ampagent 8233c71
fix: address ECS migration review feedback
ampagent 5f8666f
fix: serialize missing node state as plain data
ampagent 07798f8
fix: preserve graph-scoped node identities
ampagent 3f93d2e
fix: keep runtime node IDs unique
ampagent c30a879
test: promote fixed ECS regressions
ampagent d556e50
fix: align ECS cleanup regression coverage
ampagent de6fdbb
refactor: reduce ECS compatibility complexity
ampagent ba0a8cb
fix: harden ECS compatibility boundaries
ampagent 3d40fe1
fix: harden ECS serialization boundaries
ampagent d61ef63
fix: preserve graph membership invariants
ampagent 6c4437e
[automated] Update test expectations
invalid-email-address 7944644
fix: make canvas render order deterministic
ampagent 4c29aa9
test: release graph id before configure store checks
ampagent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
318 changes: 318 additions & 0 deletions
318
docs/architecture/ecs/ecs-component-entity-data-audit.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHOULD FIX — this loses the property the deleted comment was specifically protecting.
The old code re-read
getBoundingClientRect()inside a computed overcursorPoint, and the comment said in as many words that this was deliberate "to keep the offset correct while the dialog is dragged or resized".useElementBoundingrecomputes on: ResizeObserver of the target, windowresize, windowscroll(capture), and a MutationObserver on the target's ownstyle/classattributes. Dragging the mask-editor dialog moves an ancestor —containerRefisMaskEditorContent's root, not the dialog root — so none of those fire.left/topgo stale and the brush cursor draws offset by the drag delta.Resize is covered; drag is not. Either observe the dialog root as well, or recompute on
pointermove(throttled) instead of per-cursor-point.Separately: this change and the
WorkflowTabs/SubgraphBreadcrumbones are unrelated lint cleanups riding along in an ECS refactor — they belong in their own PR where a mask-editor regression would actually be looked for.