Repository navigation
re-loosen asset schema - #15506
re-loosen asset schema#15506
Conversation
🎭 Playwright: ✅ 1838 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.12 MB gzip 🟢 -66 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • 🔴 +247 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 219 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-21T00:43:00.204Z",
"gitSha": "48876934f6b75d48c9181f4153e4c33b755a7397",
"branch": "austin/further-assets-schema",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2091.577000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.433,
"heapDeltaBytes": 19375044,
"heapUsedBytes": 80413388,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.438,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2079.9299999999903,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.255000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.016,
"heapDeltaBytes": 15490468,
"heapUsedBytes": 76804440,
"domNodes": -282,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 11.09,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2160.792000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.659000000000006,
"layouts": 12,
"layoutDurationMs": 3.6899999999999995,
"taskDurationMs": 1080.036,
"heapDeltaBytes": -6042920,
"heapUsedBytes": 56012268,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 128.447,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1911.0119999999142,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.214,
"layouts": 12,
"layoutDurationMs": 4.017,
"taskDurationMs": 964.968,
"heapDeltaBytes": 18030308,
"heapUsedBytes": 80150920,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 115.319,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0509999999845,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.58,
"layouts": 6,
"layoutDurationMs": 0.732,
"taskDurationMs": 369.50899999999996,
"heapDeltaBytes": 2800288,
"heapUsedBytes": 64201972,
"domNodes": 78,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.673,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.3339999999562,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.307000000000002,
"layouts": 6,
"layoutDurationMs": 0.5640000000000001,
"taskDurationMs": 352.88199999999995,
"heapDeltaBytes": 2559024,
"heapUsedBytes": 63772736,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.808000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 584.1530000000148,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.668,
"heapDeltaBytes": 10001616,
"heapUsedBytes": 72073388,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 54.446999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 627.3219999999355,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.1140000000001,
"heapDeltaBytes": 10347928,
"heapUsedBytes": 72468084,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 56.300000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2072.565999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.8330000000001,
"heapDeltaBytes": -1921984,
"heapUsedBytes": 73560040,
"domNodes": -268,
"jsHeapTotalBytes": -2625536,
"scriptDurationMs": 19.542,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2048.885000000041,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.8770000000001,
"heapDeltaBytes": -2401396,
"heapUsedBytes": 73303676,
"domNodes": -275,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 15.486,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2223.8399999999956,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.363000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1230.496,
"heapDeltaBytes": -5401188,
"heapUsedBytes": 71511304,
"domNodes": -279,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 318.525,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2140.498999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1171.5819999999999,
"heapDeltaBytes": -7350144,
"heapUsedBytes": 69298856,
"domNodes": -273,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 317.184,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3231.596999999965,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.129,
"layouts": 60,
"layoutDurationMs": 8.526,
"taskDurationMs": 1466.924,
"heapDeltaBytes": -9008012,
"heapUsedBytes": 68946908,
"domNodes": -287,
"jsHeapTotalBytes": 5500928,
"scriptDurationMs": 395.26,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3153.5239999999476,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.438000000000002,
"layouts": 60,
"layoutDurationMs": 8.195999999999998,
"taskDurationMs": 1362.525,
"heapDeltaBytes": -12395568,
"heapUsedBytes": 64495144,
"domNodes": -284,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 386.072,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2329.3630000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1476.1929999999998,
"heapDeltaBytes": 11799636,
"heapUsedBytes": 95657740,
"domNodes": 12,
"jsHeapTotalBytes": 8843264,
"scriptDurationMs": 462.13699999999994,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2243.2639999999537,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.979999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1406.472,
"heapDeltaBytes": 11752784,
"heapUsedBytes": 95668460,
"domNodes": 12,
"jsHeapTotalBytes": 8581120,
"scriptDurationMs": 454.456,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.9110000000123,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.909000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.1170000000001,
"heapDeltaBytes": -13615720,
"heapUsedBytes": 63188916,
"domNodes": -284,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 16.557000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.3559999999843,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.826,
"heapDeltaBytes": -12486144,
"heapUsedBytes": 71448580,
"domNodes": -282,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 14.489999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.9780000000078,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.419999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.979,
"heapDeltaBytes": 11781848,
"heapUsedBytes": 73656476,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 120.925,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.4419999999964,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.126,
"heapDeltaBytes": 11955596,
"heapUsedBytes": 73349248,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 120.28899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2014.2679999999586,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.8679999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.363,
"heapDeltaBytes": -6180984,
"heapUsedBytes": 55280856,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.008000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.1320000000705,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.469999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.082,
"heapDeltaBytes": 3898692,
"heapUsedBytes": 65445928,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.138,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.8890000000474,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.495,
"layouts": 16,
"layoutDurationMs": 4.76,
"taskDurationMs": 790.497,
"heapDeltaBytes": 18709508,
"heapUsedBytes": 80182068,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 85.93100000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.775999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.569,
"layouts": 16,
"layoutDurationMs": 5.3740000000000006,
"taskDurationMs": 883.2199999999999,
"heapDeltaBytes": 15566752,
"heapUsedBytes": 77130648,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 92.99400000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1429999999905,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.23300000000001,
"layouts": 13,
"layoutDurationMs": 13.956000000000003,
"taskDurationMs": 1025.0070000000003,
"heapDeltaBytes": -5941124,
"heapUsedBytes": 86250132,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 19.63999999999999,
"eventListeners": 2373,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8274.628999999948,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.748000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4182.457,
"heapDeltaBytes": 5328556,
"heapUsedBytes": 80748080,
"domNodes": -237,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 999.8330000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.308000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3978.676,
"heapDeltaBytes": -5164056,
"heapUsedBytes": 70486516,
"domNodes": -274,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 956.02,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18623.830999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17737.757999999998,
"heapDeltaBytes": -32105892,
"heapUsedBytes": 176613976,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 134.20700000000002,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18693.302000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17669.863,
"heapDeltaBytes": -29676184,
"heapUsedBytes": 179241808,
"domNodes": -8312,
"jsHeapTotalBytes": -11964416,
"scriptDurationMs": 137.629,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22267.785000000003,
"styleRecalcs": 170,
"styleRecalcDurationMs": 21.71200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21734.729000000003,
"heapDeltaBytes": -37068072,
"heapUsedBytes": 184908640,
"domNodes": -8312,
"jsHeapTotalBytes": -12853248,
"scriptDurationMs": 470.87499999999994,
"eventListeners": -16383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22292.417999999998,
"styleRecalcs": 176,
"styleRecalcDurationMs": 21.35100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21596.445000000003,
"heapDeltaBytes": -23848256,
"heapUsedBytes": 185075848,
"domNodes": -8312,
"jsHeapTotalBytes": -14393344,
"scriptDurationMs": 424.691,
"eventListeners": -16383,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 116.62699999999404,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.179,
"layouts": 6,
"layoutDurationMs": 1.6520000000000001,
"taskDurationMs": 84.721,
"heapDeltaBytes": 3056884,
"heapUsedBytes": 64630308,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.026999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.53800000000956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.877,
"layouts": 3,
"layoutDurationMs": 0.6869999999999999,
"taskDurationMs": 97.27700000000002,
"heapDeltaBytes": 4931556,
"heapUsedBytes": 66416148,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.5920000000000005,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe asset schema now validates required timestamps and optional metadata fields. A regression test verifies that ChangesAsset schema compatibility
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change broadens asset schema acceptance for known cloud-generated type inaccuracies and adds coverage for those cases; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15506 +/- ##
==========================================
+ Coverage 80.14% 82.38% +2.23%
==========================================
Files 2213 1886 -327
Lines 130976 126073 -4903
Branches 42302 41602 -700
==========================================
- Hits 104973 103864 -1109
+ Misses 25353 21657 -3696
+ Partials 650 552 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 335 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Is it raining, or am I weeping at needing to do this? |
| const zAsset = z.object({ | ||
| ...zIngestAsset.shape, | ||
| created_at: z.string().datetime({ local: true }), | ||
| hash: z.string().optional(), |
There was a problem hiding this comment.
Just a quick check, optional() or nullish()?
There was a problem hiding this comment.
Yep. The type being loosened is.
hash: z
.string()
.regex(/^blake3:[a-f0-9]{64}$/)
.optional(),
|
@AustinMroz Successfully backported to #15509 |
|
@AustinMroz Successfully backported to #15510 |
Backport of #15506 to `cloud/1.51` Automatically created by backport workflow. Co-authored-by: AustinMroz <austin@comfy.org>
Backport of #15506 to `core/1.51` Automatically created by backport workflow. Co-authored-by: AustinMroz <austin@comfy.org>
#14858 more closely aligned the asset schema to match the spec defined by cloud generated types. Since cloud doesn't satisfy it's own schema, this would result in assets being skipped on cloud. The schema is loosened for these inaccuracies. A test was added to verify that these specific inaccuracies be accepted.