Repository navigation
chore(deps): bump suzuki-shunsuke/pinact-action from 1.3.1 to 3.0.0 - #15495
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [suzuki-shunsuke/pinact-action](https://github.com/suzuki-shunsuke/pinact-action) from 1.3.1 to 3.0.0. - [Release notes](https://github.com/suzuki-shunsuke/pinact-action/releases) - [Commits](suzuki-shunsuke/pinact-action@3d49c64...896d595) --- updated-dependencies: - dependency-name: suzuki-shunsuke/pinact-action dependency-version: 3.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
🎭 Playwright: ✅ 1836 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.12 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 287 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T14:13:42.732Z",
"gitSha": "ad3028882d98c9f6c90c623dd33ef7264a052a6a",
"branch": "dependabot/github_actions/suzuki-shunsuke/pinact-action-3.0.0",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2132.2120000000095,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.702000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.514,
"heapDeltaBytes": -6940112,
"heapUsedBytes": 55174884,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.493999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.864000000056,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.72400000000005,
"heapDeltaBytes": 9581808,
"heapUsedBytes": 71617576,
"domNodes": -281,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.348999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1883.5090000000037,
"styleRecalcs": 71,
"styleRecalcDurationMs": 34.577,
"layouts": 12,
"layoutDurationMs": 3.6929999999999996,
"taskDurationMs": 865.221,
"heapDeltaBytes": 20195368,
"heapUsedBytes": 81533660,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 111.004,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1864.058,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.36000000000001,
"layouts": 12,
"layoutDurationMs": 3.982,
"taskDurationMs": 870.092,
"heapDeltaBytes": -4573136,
"heapUsedBytes": 56203808,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.491,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.7819999999997,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.719999999999997,
"layouts": 6,
"layoutDurationMs": 0.7410000000000001,
"taskDurationMs": 347.262,
"heapDeltaBytes": 2716104,
"heapUsedBytes": 64093908,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.518,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.986000000059,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.753999999999998,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 372.405,
"heapDeltaBytes": 2611564,
"heapUsedBytes": 64629180,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.746999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 588.1610000000137,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.866000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.32300000000004,
"heapDeltaBytes": 10461516,
"heapUsedBytes": 71508984,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 53.727999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 569.8690000000397,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.733000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.073,
"heapDeltaBytes": 10776608,
"heapUsedBytes": 71226828,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 54.17300000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.9460000000336,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.524000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.793,
"heapDeltaBytes": -6947512,
"heapUsedBytes": 69165768,
"domNodes": -277,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 13.784,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2074.985999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.930000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.186,
"heapDeltaBytes": -2419844,
"heapUsedBytes": 73320100,
"domNodes": -273,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 15.168999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.8510000000356,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.446999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.382,
"heapDeltaBytes": -6917048,
"heapUsedBytes": 69795000,
"domNodes": -277,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 317.18,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2140.953999999965,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.445000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1148.512,
"heapDeltaBytes": -7953704,
"heapUsedBytes": 69097680,
"domNodes": -275,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 313.002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3154.3550000000096,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.336000000000002,
"layouts": 60,
"layoutDurationMs": 8.032,
"taskDurationMs": 1391.724,
"heapDeltaBytes": -12841304,
"heapUsedBytes": 65149504,
"domNodes": -285,
"jsHeapTotalBytes": 5238784,
"scriptDurationMs": 387.457,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.778000000032,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.271,
"layouts": 60,
"layoutDurationMs": 8.318,
"taskDurationMs": 1435.404,
"heapDeltaBytes": -12022572,
"heapUsedBytes": 65778860,
"domNodes": -286,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 387.235,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2261.417999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.827000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1464.982,
"heapDeltaBytes": -14507000,
"heapUsedBytes": 69494372,
"domNodes": 14,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 458.38800000000003,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2455.6700000000546,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.205000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1461.8859999999997,
"heapDeltaBytes": 11766972,
"heapUsedBytes": 95618008,
"domNodes": 12,
"jsHeapTotalBytes": 8318976,
"scriptDurationMs": 467.23099999999994,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.1699999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.435000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.274,
"heapDeltaBytes": -12747112,
"heapUsedBytes": 71032864,
"domNodes": -277,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 14.583000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.3990000000267,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.1560000000001,
"heapDeltaBytes": -12980064,
"heapUsedBytes": 68934264,
"domNodes": -282,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 14.109,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.769000000033,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.551,
"heapDeltaBytes": 11297372,
"heapUsedBytes": 72873224,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 127.22200000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.7919999999694,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.203999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.319,
"heapDeltaBytes": 10974960,
"heapUsedBytes": 72713852,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 119.47099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.7280000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.072000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.021,
"heapDeltaBytes": 17900200,
"heapUsedBytes": 79603980,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.131999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2012.3899999999821,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.273000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.2850000000001,
"heapDeltaBytes": 1301156,
"heapUsedBytes": 62626496,
"domNodes": -280,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 6.662000000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.0790000000457,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.458999999999996,
"layouts": 16,
"layoutDurationMs": 4.3580000000000005,
"taskDurationMs": 771.444,
"heapDeltaBytes": 19275784,
"heapUsedBytes": 80804940,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 80.97200000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.5219999999554,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.27,
"layouts": 16,
"layoutDurationMs": 4.341,
"taskDurationMs": 765.608,
"heapDeltaBytes": 19925172,
"heapUsedBytes": 81295272,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 81.57300000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.671000000063,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.107000000000003,
"layouts": 15,
"layoutDurationMs": 13.392,
"taskDurationMs": 884.916,
"heapDeltaBytes": -7729968,
"heapUsedBytes": 86581748,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 15.519999999999992,
"eventListeners": 2375,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8266.974999999946,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4247.26,
"heapDeltaBytes": -11153180,
"heapUsedBytes": 64504368,
"domNodes": -279,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 1003.2280000000001,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8292.491999999926,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4190.433000000001,
"heapDeltaBytes": 4948636,
"heapUsedBytes": 80456436,
"domNodes": -240,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 1000.915,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18665.674999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17771.644,
"heapDeltaBytes": -31279640,
"heapUsedBytes": 177728168,
"domNodes": -8312,
"jsHeapTotalBytes": -11735040,
"scriptDurationMs": 133.34899999999996,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18271.541999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17296.684999999998,
"heapDeltaBytes": -43504396,
"heapUsedBytes": 178931172,
"domNodes": -8317,
"jsHeapTotalBytes": -7278592,
"scriptDurationMs": 123.95299999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22355.08699999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 21.841999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21673.926000000003,
"heapDeltaBytes": -49470880,
"heapUsedBytes": 173512800,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 402.95599999999996,
"eventListeners": -16381,
"totalBlockingTimeMs": 149,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22618.596000000027,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.25900000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21982.148,
"heapDeltaBytes": -48823804,
"heapUsedBytes": 172067132,
"domNodes": -8316,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 427.811,
"eventListeners": -16383,
"totalBlockingTimeMs": 102,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 119.36000000002878,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.242,
"layouts": 6,
"layoutDurationMs": 1.7400000000000002,
"taskDurationMs": 86.18199999999999,
"heapDeltaBytes": 3155844,
"heapUsedBytes": 64749744,
"domNodes": 134,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.603000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 481.6849999999704,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.920000000000005,
"layouts": 3,
"layoutDurationMs": 1.4429999999999998,
"taskDurationMs": 111.44599999999998,
"heapDeltaBytes": 5046460,
"heapUsedBytes": 66359712,
"domNodes": 143,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.472999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
There was a problem hiding this comment.
Verdict: changes requested. Under v3 this config passes unpinned actions, and pinact v4 fails on two pins already on main.
Pre-merge blockers
- P1,
ci-validate-action-pins.yaml:21: v3 defaultsfixto"true", soskip_push: 'true'now runspinact run --fix. That rewrites unpinned actions in the runner and exits 0, so the check stops enforcing pins. The suggestion replacesskip_pushwithfix: 'false'. - P1,
ci-validate-action-pins.yaml:19: pinact v4 requires a version comment on SHA pins and exits 2 on the twoComfy-Org/github-workflowspins commented# github-workflows main (…). The job turns red on main and on every workflow PR until.pinact.yamlgets a SHA-scoped ignore entry.
Dependabot can't apply either fix. Someone has to push both to this branch, or to a replacement PR, before merging. The branch is about 2,000 commits behind main and Dependabot has disabled auto-rebase, so the 2026-08-20 CI results on this head are stale. I ran the pinact checks myself against current main merged with this head.
Checked and cleared
.pinact.yamlversion: 3still works under pinact v4. The v4 schema accepts 2 and 3, and pinact 4.0.0 loads the repo config without warnings.ignore_actionsstill matches in v4. The ref is a full-string regex, and v4 prefersrulesonly for new configs.- The file set pinact scans hasn't changed. v1.3.1 passed
git ls-filesworkflows plus everyaction.y?ml. The.pinact.yamlpatterns cover the same files, and the only extra file under workflows isREADME.md. contents: readis still enough. The skip-push path never runs git, andfix: 'false'implies skip-push.- v2's Node 24 requirement holds on
ubuntu-latest. The action ran there in this PR's CI. - The trigger comment on main ("Not a required check") is still accurate. The main ruleset requires only
cla-assistant,test,lint-and-format,e2e-status, andwebsite-e2e. - The new
# v3.0.0comment stays. pinact v4 requires a version comment on SHA pins. - The
actions/cacheref: v5ignore entry matches nouses:in.github, but it was dead before this PR, so it isn't part of this review.
Coverage
Standard depth, with correctness and maintainability lanes over .github/workflows/ci-validate-action-pins.yaml, its .pinact.yaml, and the workflow files pinact scans. I skipped idiomaticity because the diff has no TypeScript, Vue, Tailwind, or lint config. I skipped tests because no test changed and this workflow has no test harness. I skipped documentation because the PR body is upstream release notes and makes no claim about this repo. Evidence came from pinact-action source at 896d595f and 3d49c641, pinact v4.0.0 source, and the pinact 4.0.0 binary run against origin/main ef9481a merged with 03b0952. That covered --fix vs --fix=false with a planted unpinned action, and the two ignore-rule variants with a planted @main ref. I also read the main ruleset and scanned open PRs that touch these files; #20598 is the only one with a related policy. No other reviews or comments were on the PR.
| - uses: actions/checkout@v7 | ||
|
|
||
| - uses: suzuki-shunsuke/pinact-action@3d49c6412901042473ffa78becddab1aea46bbea # v1.3.1 | ||
| - uses: suzuki-shunsuke/pinact-action@896d595f299e71d65b9d28349d6956abe144390a # v3.0.0 |
There was a problem hiding this comment.
P1. pinact v4, which ships with this action version, rejects two pins already on main, so this job goes red on main and on every PR that touches workflows.
pinact v4 adds a rule that a SHA-pinned uses: needs a version comment. Two lines carry branch comments instead:
.github/workflows/pr-cursor-review.yaml:32:cursor-review.yml@06f835f… # github-workflows main (06f835f).github/workflows/ci-pr-risk.yml:67:pr-risk.yml@ba2e67b… # github-workflows main (ba2e67b)
pinact run --fix=false on main merged with this head exits 2 with SHA-pinned action requires a version comment for verifiability on both lines. The failure is the same under --fix. The validate-pins run on this head failed for the same reason, though that run is from 2026-08-20 and the branch is about 2,000 commits behind main. The workflow's push trigger on main also covers .github/workflows/**, so the merge commit itself would go red. The job isn't a required check, so it won't block merges. It will stay red until someone fixes it, and people will learn to ignore it.
The two SHAs come from Comfy-Org/github-workflows main. That repo's only tag is v1, which doesn't point at them, so a # v1 comment would be wrong. pinact v4 has no flag to turn the rule off; docs/codes/005.md points to an ignore rule. This needs a .pinact.yaml edit, which is outside this diff, so there's no suggestion block. Something like this should do it:
- name: Comfy-Org/github-workflows/.*
ref: '[0-9a-f]{40}'Keep the SHA regex rather than ref: .*. I checked both. Each makes the tree pass (exit 0). With pr-cursor-review.yaml:32 switched to @main, .* still exits 0 and the SHA regex exits 2, so only the SHA regex still blocks a floating ref to a reusable workflow that receives CURSOR_API_KEY. Open PR #20598 bumps the cursor-review pin with the same # github-workflows main (26e2c00) comment format. Rewriting the comments would only last until the next bot bump; the ignore entry covers both.
| - uses: suzuki-shunsuke/pinact-action@3d49c6412901042473ffa78becddab1aea46bbea # v1.3.1 | ||
| - uses: suzuki-shunsuke/pinact-action@896d595f299e71d65b9d28349d6956abe144390a # v3.0.0 | ||
| with: | ||
| skip_push: 'true' |
There was a problem hiding this comment.
P1. In v3, skip_push: 'true' no longer means check-only, so this job stops enforcing SHA pins.
v1.3.1 ran pinact run --diff --check for skip_push. v3 adds a fix input that defaults to "true" (action.yaml at 896d595f), and the skip-push path now runs pinact run --fix (src/run.ts:161). pinact v4 returns exit 1 for a fixable unpinned action only when Fix is false (pkg/controller/run/run.go, processLine). With --fix it rewrites the file in the runner and exits 0. This PR's own CI log shows [command]… pinact run --fix.
I reproduced it with pinact 4.0.0 on main merged with this head. I planted peter-evans/create-pull-request@v7 and ignored the two lines from the other comment so only the planted line counted. pinact run --fix exited 0. pinact run --fix=false exited 1.
fix: 'false' restores the old behavior. It also implies skip-push (src/run.ts:73: skipPush = skip_push || !fix), so skip_push becomes dead and should go. Upstream's README says the same thing ("This implies skip_push: "true" … you don't need to set both").
| skip_push: 'true' | |
| fix: 'false' |
Applies #17362, #17928, #15495 and #15493 to every workflow and composite action, so each action stays on one version: - actions/cache, restore and save: v5 -> v6.1.0 - actions/setup-node: v6 -> v7 - pnpm/action-setup v6.1.0, codecov/codecov-action v7.1.1, fallow-rs/fallow v3.31.0, anthropics/claude-code-action v1.0.242 - suzuki-shunsuke/pinact-action v1.3.1 -> v3.0.0 with fix: 'false'. In v3, skip_push alone no longer runs a check. pinact v4 requires a version comment on every SHA pin, so .pinact.yaml exempts the SHA-pinned Comfy-Org/github-workflows reusables, which track a main commit. Amp-Thread-ID: https://ampcode.com/threads/T-01a11dd3-b484-71d8-a407-de7492f7a64e
|
Rolled into #20599, which applies this update to every workflow and composite action, and adds a CI check that keeps each action on one version. Closing in favor of that PR. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps suzuki-shunsuke/pinact-action from 1.3.1 to 3.0.0.
Release notes
Sourced from suzuki-shunsuke/pinact-action's releases.
... (truncated)
Commits
896d595chore: prepare release v3.0.08d2d695feat!: update pinact to v4.0.0, expose new run options, honor fix in skip_pus...bd33019chore(deps): lock file maintenance (#1068)9117f4dchore(deps): update node.js to v24.16.0 (#1067)378a2b3chore(deps): update dependency aquaproj/aqua-registry to v4.516.0 (#1066)5c74c8fchore(deps): update dependency aquaproj/aqua-registry to v4.515.0 (#1064)62745e9chore(deps): update dependency typescript-eslint to v8.59.4 (#1063)1d5e6d9chore(deps): update dependency aquaproj/aqua-registry to v4.514.0 (#1062)064e7f1chore(deps): update dependency aquaproj/aqua-registry to v4.513.1 (#1061)3891c77chore(deps): update dependency aquaproj/aqua-renovate-config to v2.12.1 (#1060)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)