Repository navigation
[backport cloud/1.51] fix: reset native button styles on Manage plan (FE-1668) - #15477
Conversation
## Summary Fixes [FE-1668](https://linear.app/comfyorg/issue/FE-1668/): the **Manage plan** item in the profile popover inherited native browser `<button>` styling after #15266 changed it from a `<div>` to a `<button>` for accessibility. ## Root cause #15266 (`307c66ab5d`) added the correct keyboard and accessibility semantics, but the button did not reset its native appearance. The browser UA stylesheet therefore rendered a gray background, border, and shrink-wrapped width that made this row visually inconsistent with the neighboring menu items. ## Fix Reset the native button appearance with `appearance-none`, `border-0`, `bg-transparent`, `w-full`, and `text-left`. Preserve the existing hover state and add an equivalent focus-visible state for keyboard users. ## AS IS  ## TO BE  ## Testing - `pnpm exec vitest run src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` (16/16 passed) - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/currentUserPopoverCredits.spec.ts --project=cloud --grep "plain full-width" --update-snapshots` - `pnpm typecheck:browser` - `pnpm typecheck` - `pnpm exec oxfmt --check browser_tests/tests/currentUserPopoverCredits.spec.ts src/platform/workspace/components/CurrentUserPopoverWorkspace.vue` --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1820 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-20T06:30:53.222Z",
"gitSha": "090cc99ba4eb1ec7be00194b16e9c684f919f84c",
"branch": "backport-15419-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.3690000000215,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.392,
"heapDeltaBytes": 5044604,
"heapUsedBytes": 70568304,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.076000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2018.0319999999483,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.677,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.98900000000003,
"heapDeltaBytes": 5039220,
"heapUsedBytes": 70507436,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.187000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2091.0030000000006,
"styleRecalcs": 74,
"styleRecalcDurationMs": 49.541,
"layouts": 12,
"layoutDurationMs": 3.999,
"taskDurationMs": 1057.149,
"heapDeltaBytes": -19013988,
"heapUsedBytes": 46683172,
"domNodes": 56,
"jsHeapTotalBytes": 23957504,
"scriptDurationMs": 130.034,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.8300000000218,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.268,
"layouts": 12,
"layoutDurationMs": 3.5170000000000003,
"taskDurationMs": 853.172,
"heapDeltaBytes": -54816,
"heapUsedBytes": 65254056,
"domNodes": 61,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 114.642,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.381000000003,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.708,
"layouts": 6,
"layoutDurationMs": 0.606,
"taskDurationMs": 361.79299999999995,
"heapDeltaBytes": 8160188,
"heapUsedBytes": 73516576,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 9.274000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.2029999999377,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.662000000000003,
"layouts": 6,
"layoutDurationMs": 0.642,
"taskDurationMs": 376.747,
"heapDeltaBytes": 7968596,
"heapUsedBytes": 73535760,
"domNodes": 77,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 9.799000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 610.7330000000388,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.55,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.523,
"heapDeltaBytes": -11369684,
"heapUsedBytes": 53950012,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 61.343999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 560.577999999964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.415,
"heapDeltaBytes": -11229724,
"heapUsedBytes": 53973328,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 55.211999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.2659999999833,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5040000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.5169999999999,
"heapDeltaBytes": 13063572,
"heapUsedBytes": 73158984,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 14.159999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.7270000000508,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.233000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.0849999999999,
"heapDeltaBytes": 13009576,
"heapUsedBytes": 72807060,
"domNodes": -282,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 16.585,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2264.6270000000186,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.252000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.002,
"heapDeltaBytes": 10958544,
"heapUsedBytes": 71656096,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 380.961,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2167.9840000000468,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1192.866,
"heapDeltaBytes": 7998608,
"heapUsedBytes": 69088216,
"domNodes": -286,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 334.41200000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3147.2269999999867,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.743999999999996,
"layouts": 60,
"layoutDurationMs": 7.2749999999999995,
"taskDurationMs": 1315.625,
"heapDeltaBytes": 16505748,
"heapUsedBytes": 79220816,
"domNodes": 10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 385.39,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3181.4319999999725,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.997,
"layouts": 60,
"layoutDurationMs": 7.349999999999999,
"taskDurationMs": 1381.208,
"heapDeltaBytes": -4175624,
"heapUsedBytes": 58207680,
"domNodes": -287,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 389.337,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.1650000000295,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.089000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.2629999999999,
"heapDeltaBytes": 8143552,
"heapUsedBytes": 69253732,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 13.777999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.9050000000234,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.1209999999999,
"heapDeltaBytes": 12943020,
"heapUsedBytes": 74530180,
"domNodes": -284,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 14.807,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.8710000000206,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.566,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.93700000000007,
"heapDeltaBytes": -9935984,
"heapUsedBytes": 55671512,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 117.129,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.4339999999602,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.534000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.15900000000005,
"heapDeltaBytes": -11369480,
"heapUsedBytes": 54033292,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 119,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2029.8730000000091,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.849,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.87300000000005,
"heapDeltaBytes": 5234356,
"heapUsedBytes": 70877232,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.336999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.242999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.937000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.188,
"heapDeltaBytes": 5507796,
"heapUsedBytes": 71055348,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.388,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.55800000001,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.903,
"layouts": 16,
"layoutDurationMs": 4.99,
"taskDurationMs": 757.857,
"heapDeltaBytes": -3651668,
"heapUsedBytes": 61742832,
"domNodes": 63,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 86.97,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.7409999999518,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.480999999999995,
"layouts": 16,
"layoutDurationMs": 4.1659999999999995,
"taskDurationMs": 788.886,
"heapDeltaBytes": -3767416,
"heapUsedBytes": 61786612,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 90.712,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.8629999999876,
"styleRecalcs": 20,
"styleRecalcDurationMs": 34.044000000000004,
"layouts": 15,
"layoutDurationMs": 14.193000000000001,
"taskDurationMs": 1010.786,
"heapDeltaBytes": -5911116,
"heapUsedBytes": 79641800,
"domNodes": 13673,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 18.073000000000008,
"eventListeners": 2375,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.834000000026,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.498999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4226.755,
"heapDeltaBytes": 13526332,
"heapUsedBytes": 74100032,
"domNodes": -281,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1042.125,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8242.189000000053,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4079.8740000000003,
"heapDeltaBytes": 8436432,
"heapUsedBytes": 68597716,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 1014.8969999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17520.406999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16729.052000000003,
"heapDeltaBytes": -29388588,
"heapUsedBytes": 167726392,
"domNodes": -8312,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 123.44999999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17607.481000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16737.313000000002,
"heapDeltaBytes": -27512916,
"heapUsedBytes": 170715740,
"domNodes": -8312,
"jsHeapTotalBytes": -14585856,
"scriptDurationMs": 125.68300000000002,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21385.017000000003,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.283999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20731.249,
"heapDeltaBytes": -13417640,
"heapUsedBytes": 182839468,
"domNodes": -8312,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 442.494,
"eventListeners": -16385,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21273.810000000027,
"styleRecalcs": 174,
"styleRecalcDurationMs": 18.52699999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20618.083,
"heapDeltaBytes": -34075444,
"heapUsedBytes": 176362056,
"domNodes": -8312,
"jsHeapTotalBytes": -13377536,
"scriptDurationMs": 419.25300000000004,
"eventListeners": -16385,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.74200000001474,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.126,
"layouts": 3,
"layoutDurationMs": 0.57,
"taskDurationMs": 110.342,
"heapDeltaBytes": 4944232,
"heapUsedBytes": 69314576,
"domNodes": 122,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.644,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 146.3340000000244,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.725000000000005,
"layouts": 2,
"layoutDurationMs": 1.1440000000000001,
"taskDurationMs": 84.5,
"heapDeltaBytes": 2946068,
"heapUsedBytes": 67330416,
"domNodes": 132,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4.874000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #15477 +/- ##
=============================================
Coverage ? 81.48%
=============================================
Files ? 1883
Lines ? 117534
Branches ? 36717
=============================================
Hits ? 95769
Misses ? 21289
Partials ? 476
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15419 to
cloud/1.51Automatically created by backport workflow.