Repository navigation
[backport core/1.51] fix: reset native button styles on Manage plan (FE-1668) - #15476
Conversation
## Summary Fixes [FE-1668](https://linear.app/comfyorg/issue/FE-1668/): the **Manage plan** item in the profile popover inherited native browser `<button>` styling after #15266 changed it from a `<div>` to a `<button>` for accessibility. ## Root cause #15266 (`307c66ab5d`) added the correct keyboard and accessibility semantics, but the button did not reset its native appearance. The browser UA stylesheet therefore rendered a gray background, border, and shrink-wrapped width that made this row visually inconsistent with the neighboring menu items. ## Fix Reset the native button appearance with `appearance-none`, `border-0`, `bg-transparent`, `w-full`, and `text-left`. Preserve the existing hover state and add an equivalent focus-visible state for keyboard users. ## AS IS  ## TO BE  ## Testing - `pnpm exec vitest run src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` (16/16 passed) - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/currentUserPopoverCredits.spec.ts --project=cloud --grep "plain full-width" --update-snapshots` - `pnpm typecheck:browser` - `pnpm typecheck` - `pnpm exec oxfmt --check browser_tests/tests/currentUserPopoverCredits.spec.ts src/platform/workspace/components/CurrentUserPopoverWorkspace.vue` --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
🎭 Playwright: ✅ 1822 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T06:30:40.384Z",
"gitSha": "dc762110e0681cddaf75b4f52bc1892c0ec36479",
"branch": "backport-15419-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.7430000000295,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.559,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.851,
"heapDeltaBytes": 5126104,
"heapUsedBytes": 70564324,
"domNodes": 14,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.887999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.368000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.874999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.0779999999999,
"heapDeltaBytes": 4966820,
"heapUsedBytes": 70459604,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.285,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1862.1479999999337,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.347,
"layouts": 12,
"layoutDurationMs": 3.5049999999999994,
"taskDurationMs": 901.886,
"heapDeltaBytes": -18318872,
"heapUsedBytes": 47226884,
"domNodes": -279,
"jsHeapTotalBytes": 23171072,
"scriptDurationMs": 108.27000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.1970000000574,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.961999999999996,
"layouts": 12,
"layoutDurationMs": 3.7810000000000006,
"taskDurationMs": 848.3259999999999,
"heapDeltaBytes": 338616,
"heapUsedBytes": 65845832,
"domNodes": 60,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 107.09100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.308999999982,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.78,
"layouts": 6,
"layoutDurationMs": 0.6689999999999999,
"taskDurationMs": 374.06500000000005,
"heapDeltaBytes": 7656552,
"heapUsedBytes": 73035128,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 10.091000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.1630000000423,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.134,
"layouts": 6,
"layoutDurationMs": 0.714,
"taskDurationMs": 395.71900000000005,
"heapDeltaBytes": 7959424,
"heapUsedBytes": 73420456,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 11.6,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 606.632999999988,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.828,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.173,
"heapDeltaBytes": -11539936,
"heapUsedBytes": 53965780,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 58.403,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 572.6640000000316,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.655000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.942,
"heapDeltaBytes": -11784768,
"heapUsedBytes": 53626168,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 54.714000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.371000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.187000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.803,
"heapDeltaBytes": 14970084,
"heapUsedBytes": 75020264,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 17.25,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2020.3700000000708,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.5689999999998,
"heapDeltaBytes": 12168684,
"heapUsedBytes": 72803580,
"domNodes": -285,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 18.029,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2151.914999999917,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.436000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1135.692,
"heapDeltaBytes": 10406168,
"heapUsedBytes": 71425228,
"domNodes": -284,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 302.838,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2210.902000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1177.038,
"heapDeltaBytes": 9504092,
"heapUsedBytes": 70876260,
"domNodes": -284,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 307.689,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3183.8399999999183,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.955000000000004,
"layouts": 60,
"layoutDurationMs": 7.89,
"taskDurationMs": 1349.1019999999999,
"heapDeltaBytes": -4220964,
"heapUsedBytes": 58538084,
"domNodes": -287,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 373.15500000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3165.5719999999974,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.804000000000002,
"layouts": 60,
"layoutDurationMs": 8.233,
"taskDurationMs": 1351.7820000000002,
"heapDeltaBytes": 16420876,
"heapUsedBytes": 79212964,
"domNodes": 12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 385.97900000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.4040000000523,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.558,
"heapDeltaBytes": 13350248,
"heapUsedBytes": 74724752,
"domNodes": -285,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 14.844999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2039.2460000000483,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.499999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.652,
"heapDeltaBytes": 13275324,
"heapUsedBytes": 74743156,
"domNodes": -283,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 15.862000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.0200000000041,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.21199999999993,
"heapDeltaBytes": -9846316,
"heapUsedBytes": 55710464,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 116.895,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.4140000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.488,
"heapDeltaBytes": -9914004,
"heapUsedBytes": 55608688,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 119.646,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.3409999999303,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.845999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.51599999999996,
"heapDeltaBytes": 5410176,
"heapUsedBytes": 70825736,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.672000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.0329999999312,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.998,
"heapDeltaBytes": 5549384,
"heapUsedBytes": 71085012,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.099000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.2950000000164,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.495,
"layouts": 16,
"layoutDurationMs": 4.089,
"taskDurationMs": 789.952,
"heapDeltaBytes": -3850308,
"heapUsedBytes": 61685628,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 91.438,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.4029999999657,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.773,
"layouts": 16,
"layoutDurationMs": 4.243,
"taskDurationMs": 756.2030000000001,
"heapDeltaBytes": -3588236,
"heapUsedBytes": 61851528,
"domNodes": 64,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 84.032,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0949999999411,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.95600000000001,
"layouts": 15,
"layoutDurationMs": 11.236000000000002,
"taskDurationMs": 892.6590000000001,
"heapDeltaBytes": 22276884,
"heapUsedBytes": 99764748,
"domNodes": 13673,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 17.404999999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.70599999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3918.2890000000007,
"heapDeltaBytes": 13001072,
"heapUsedBytes": 73057844,
"domNodes": -281,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 922.384,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8223.54699999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4027.9349999999995,
"heapDeltaBytes": 13872948,
"heapUsedBytes": 74364904,
"domNodes": -283,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 950.311,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18207.544000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17171.327,
"heapDeltaBytes": -43398956,
"heapUsedBytes": 167536000,
"domNodes": -8312,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 117.432,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18295.37700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17331.406000000003,
"heapDeltaBytes": -28242064,
"heapUsedBytes": 170716328,
"domNodes": -8312,
"jsHeapTotalBytes": -4657152,
"scriptDurationMs": 133.683,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22001.03200000001,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.871000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21267.904000000002,
"heapDeltaBytes": -25970864,
"heapUsedBytes": 184122312,
"domNodes": -8312,
"jsHeapTotalBytes": -12328960,
"scriptDurationMs": 410.76199999999994,
"eventListeners": -16381,
"totalBlockingTimeMs": 102,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22009.347999999816,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.299999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21300.058,
"heapDeltaBytes": -25856700,
"heapUsedBytes": 185127664,
"domNodes": -8312,
"jsHeapTotalBytes": -12853248,
"scriptDurationMs": 411.17099999999994,
"eventListeners": -16381,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 469.3489999999656,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.335,
"layouts": 3,
"layoutDurationMs": 1.3359999999999999,
"taskDurationMs": 111.767,
"heapDeltaBytes": 5068484,
"heapUsedBytes": 69600744,
"domNodes": 148,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.569000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 116.35300000011739,
"styleRecalcs": 10,
"styleRecalcDurationMs": 15.869000000000002,
"layouts": 3,
"layoutDurationMs": 1.15,
"taskDurationMs": 82.407,
"heapDeltaBytes": 3044588,
"heapUsedBytes": 67688212,
"domNodes": 128,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 5.826,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #15476 +/- ##
===========================================
Coverage 81.48% 81.48%
===========================================
Files 1883 1883
Lines 117534 117534
Branches 36717 37188 +471
===========================================
Hits 95769 95769
Misses 21289 21289
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15419 to
core/1.51Automatically created by backport workflow.