Repository navigation
[backport cloud/1.51] fix(telemetry): route every error report through one reporter that reaches both sinks - #15465
Conversation
…aches both sinks (#15346) ## Summary `captureException` reaches Sentry only. That is how `workspace_auth_gate_initialization_failure` — one of the two `error_type` values IR-105 is tracked by — fired in production while reading as **zero** on every Datadog dashboard. Only `bootstrap_auth_wait_timeout` dual-wrote, and it did so by hand at the call site. Adds `reportError(cause, { errorType, tags, context, level })` and migrates all seven call sites onto it. `error_type` lands as a Sentry tag and a RUM context field under the same name, so one query works against either console. ## Two further ways a report could go nowhere **Build-time flag defeated the runtime DSN.** `Sentry.init({ enabled: __SENTRY_ENABLED__ })` baked the flag from the *build machine's* `SENTRY_DSN`, but cloud resolves its DSN at runtime from remote config (`sentry_dsn`). A cloud build without the env var left every capture in the app inert no matter how valid the runtime DSN turned out to be. `enabled` now derives from the resolved DSN; the dead define is removed rather than left to rot. **Early-boot reports were dropped.** Datadog RUM initializes behind `initDatadogRum()`'s fire-and-forget dynamic import in `bootstrap.ts` while Sentry initializes in `main.ts`, so a failure raised before either sink existed went nowhere — precisely the failures that leave a user on the splash screen. Reports raised before a sink is live are now buffered (bounded at 25) and flushed once one comes up. `reportError` never throws: a failing error reporter must not become a second failure. ## Verification - `src/platform/telemetry/reportError.test.ts` — 8 cases: both-sink fan-out, degraded single-sink, buffer-then-flush, no double-replay, bounded buffer, non-`Error` normalization, `undefined` tag stripping, sink-throws containment. - Existing suites migrated off the `@sentry/vue` mock onto the `reportError` mock: `bootstrapStore`, `WorkspaceAuthGate`, `useWorkspaceBilling`. - `pnpm vitest run src/platform/telemetry/ src/platform/cloud/onboarding/auth.test.ts` — 391 passed. - `pnpm lint`, `pnpm typecheck`, `pnpm knip` clean. ## Regression risk Low-to-moderate. No behavior change at any call site beyond reaching a second sink. The `enabled` change means Sentry now activates in any non-dev build with a resolvable DSN — which is the intent, but it is the one line worth a close look. ## Follow-ups (not in this PR) - Boot chunks that 404 never execute JS at all, so no in-app reporter can see them. Needs an inline sentinel in `index.html`. - The `/` -> `/cloud/login` -> `/cloud/user-check` redirect loop emits neither `error_type` because auth succeeds on every lap. Needs its own instrumentation.
🎭 Playwright: ✅ 1824 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-20T04:13:13.934Z",
"gitSha": "1ba2e4e3f36cd6a00097b8608b557f3832b43566",
"branch": "backport-15346-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.7029999999822,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.047999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.75000000000006,
"heapDeltaBytes": 5111332,
"heapUsedBytes": 70628940,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 6.581000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1997.1919999999272,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.600999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.562,
"heapDeltaBytes": 5056552,
"heapUsedBytes": 70514980,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.6179999999999986,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.0489999999959,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.01,
"layouts": 12,
"layoutDurationMs": 3.009,
"taskDurationMs": 705.72,
"heapDeltaBytes": -374852,
"heapUsedBytes": 64863452,
"domNodes": 58,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 84.066,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.0729999999958,
"styleRecalcs": 73,
"styleRecalcDurationMs": 31.511999999999997,
"layouts": 12,
"layoutDurationMs": 3.427,
"taskDurationMs": 670.858,
"heapDeltaBytes": 39912,
"heapUsedBytes": 65424624,
"domNodes": 55,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 83.551,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.0259999999707,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.855,
"layouts": 6,
"layoutDurationMs": 0.6399999999999999,
"taskDurationMs": 322.627,
"heapDeltaBytes": 7960808,
"heapUsedBytes": 73364492,
"domNodes": 78,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 9.157,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.3479999999963,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.517999999999997,
"layouts": 6,
"layoutDurationMs": 0.619,
"taskDurationMs": 300.08299999999997,
"heapDeltaBytes": 7759516,
"heapUsedBytes": 73149612,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 8.675999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 541.4250000000038,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.682,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.033,
"heapDeltaBytes": -12770144,
"heapUsedBytes": 52480584,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 44.233000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 513.5510000000068,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.601999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.267,
"heapDeltaBytes": -11515380,
"heapUsedBytes": 53952956,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 42.59499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.744000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.28,
"heapDeltaBytes": 12690736,
"heapUsedBytes": 73257632,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 15.255999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.5079999999925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.4780000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.573,
"heapDeltaBytes": 12723196,
"heapUsedBytes": 72432484,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 11.468000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2087.7739999999676,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.581000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 950.3820000000001,
"heapDeltaBytes": -1876240,
"heapUsedBytes": 59150248,
"domNodes": -281,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 251.86399999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.7529999999406,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 959.814,
"heapDeltaBytes": 2034872,
"heapUsedBytes": 63076836,
"domNodes": -284,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 251.78599999999994,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3104.2889999999943,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.600999999999997,
"layouts": 60,
"layoutDurationMs": 8.296,
"taskDurationMs": 1146.4280000000003,
"heapDeltaBytes": -8038880,
"heapUsedBytes": 54229624,
"domNodes": 16,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 308.07300000000004,
"eventListeners": -97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3102.375000000052,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.427999999999999,
"layouts": 60,
"layoutDurationMs": 7.894,
"taskDurationMs": 1132.129,
"heapDeltaBytes": -8036624,
"heapUsedBytes": 54239160,
"domNodes": 12,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 300.38100000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.5220000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.089999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.885,
"heapDeltaBytes": 9879036,
"heapUsedBytes": 70913088,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 12.927000000000005,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.016999999948,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.6220000000001,
"heapDeltaBytes": 12485288,
"heapUsedBytes": 73821824,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 12.876999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.6300000000447,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.76899999999995,
"heapDeltaBytes": -11366928,
"heapUsedBytes": 54044264,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 95.40599999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.1049999999723,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.499000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.259,
"heapDeltaBytes": -10047264,
"heapUsedBytes": 55552560,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 88.49300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2017.844000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.186999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.747,
"heapDeltaBytes": 5232624,
"heapUsedBytes": 70741948,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.7589999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.109999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.484999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.514,
"heapDeltaBytes": 5538260,
"heapUsedBytes": 71098856,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.052999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1686.2439999999879,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.326000000000004,
"layouts": 16,
"layoutDurationMs": 3.8890000000000002,
"taskDurationMs": 627.632,
"heapDeltaBytes": -3811336,
"heapUsedBytes": 61897936,
"domNodes": 60,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 65.59700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.0179999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.997000000000003,
"layouts": 16,
"layoutDurationMs": 3.8890000000000002,
"taskDurationMs": 610.765,
"heapDeltaBytes": -3778084,
"heapUsedBytes": 61848624,
"domNodes": 61,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 62.144,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.0599999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.147000000000002,
"layouts": 15,
"layoutDurationMs": 8.652999999999999,
"taskDurationMs": 744.388,
"heapDeltaBytes": -5860820,
"heapUsedBytes": 77128312,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 13.557,
"eventListeners": 2373,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8102.079000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.939,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3432.351,
"heapDeltaBytes": 13606924,
"heapUsedBytes": 73662216,
"domNodes": -278,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 825.157,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8120.557000000076,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3295.031,
"heapDeltaBytes": 22948020,
"heapUsedBytes": 83574672,
"domNodes": -283,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 777.837,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13837.996000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12807.127,
"heapDeltaBytes": -45171716,
"heapUsedBytes": 165752060,
"domNodes": -8341,
"jsHeapTotalBytes": -22974464,
"scriptDurationMs": 105.042,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13229.701999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12493.113000000001,
"heapDeltaBytes": -43775856,
"heapUsedBytes": 165981796,
"domNodes": -8312,
"jsHeapTotalBytes": -15929344,
"scriptDurationMs": 84.25200000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16122.06100000003,
"styleRecalcs": 100,
"styleRecalcDurationMs": 15.78299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15385.644999999999,
"heapDeltaBytes": -34515828,
"heapUsedBytes": 176136836,
"domNodes": -8312,
"jsHeapTotalBytes": -13377536,
"scriptDurationMs": 392.172,
"eventListeners": -16387,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16251.838000000022,
"styleRecalcs": 112,
"styleRecalcDurationMs": 16.363000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15508.662999999999,
"heapDeltaBytes": -14728588,
"heapUsedBytes": 182637572,
"domNodes": -8312,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 394.98,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 420.87199999991753,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.823,
"layouts": 3,
"layoutDurationMs": 0.6689999999999999,
"taskDurationMs": 93.086,
"heapDeltaBytes": 4954044,
"heapUsedBytes": 69527692,
"domNodes": 126,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5.905,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 464.5690000000968,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.558999999999997,
"layouts": 3,
"layoutDurationMs": 0.629,
"taskDurationMs": 93.588,
"heapDeltaBytes": 4931472,
"heapUsedBytes": 69440948,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.534999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.51 #15465 +/- ##
==============================================
+ Coverage 79.11% 81.47% +2.36%
==============================================
Files 2209 1883 -326
Lines 122386 117510 -4876
Branches 38327 36708 -1619
==============================================
- Hits 96821 95743 -1078
+ Misses 24989 21291 -3698
+ Partials 576 476 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 335 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15346 to
cloud/1.51Automatically created by backport workflow.