Repository navigation
[backport core/1.51] fix(telemetry): route every error report through one reporter that reaches both sinks - #15464
Conversation
…aches both sinks (#15346) ## Summary `captureException` reaches Sentry only. That is how `workspace_auth_gate_initialization_failure` — one of the two `error_type` values IR-105 is tracked by — fired in production while reading as **zero** on every Datadog dashboard. Only `bootstrap_auth_wait_timeout` dual-wrote, and it did so by hand at the call site. Adds `reportError(cause, { errorType, tags, context, level })` and migrates all seven call sites onto it. `error_type` lands as a Sentry tag and a RUM context field under the same name, so one query works against either console. ## Two further ways a report could go nowhere **Build-time flag defeated the runtime DSN.** `Sentry.init({ enabled: __SENTRY_ENABLED__ })` baked the flag from the *build machine's* `SENTRY_DSN`, but cloud resolves its DSN at runtime from remote config (`sentry_dsn`). A cloud build without the env var left every capture in the app inert no matter how valid the runtime DSN turned out to be. `enabled` now derives from the resolved DSN; the dead define is removed rather than left to rot. **Early-boot reports were dropped.** Datadog RUM initializes behind `initDatadogRum()`'s fire-and-forget dynamic import in `bootstrap.ts` while Sentry initializes in `main.ts`, so a failure raised before either sink existed went nowhere — precisely the failures that leave a user on the splash screen. Reports raised before a sink is live are now buffered (bounded at 25) and flushed once one comes up. `reportError` never throws: a failing error reporter must not become a second failure. ## Verification - `src/platform/telemetry/reportError.test.ts` — 8 cases: both-sink fan-out, degraded single-sink, buffer-then-flush, no double-replay, bounded buffer, non-`Error` normalization, `undefined` tag stripping, sink-throws containment. - Existing suites migrated off the `@sentry/vue` mock onto the `reportError` mock: `bootstrapStore`, `WorkspaceAuthGate`, `useWorkspaceBilling`. - `pnpm vitest run src/platform/telemetry/ src/platform/cloud/onboarding/auth.test.ts` — 391 passed. - `pnpm lint`, `pnpm typecheck`, `pnpm knip` clean. ## Regression risk Low-to-moderate. No behavior change at any call site beyond reaching a second sink. The `enabled` change means Sentry now activates in any non-dev build with a resolvable DSN — which is the intent, but it is the one line worth a close look. ## Follow-ups (not in this PR) - Boot chunks that 404 never execute JS at all, so no in-app reporter can see them. Needs an inline sentinel in `index.html`. - The `/` -> `/cloud/login` -> `/cloud/user-check` redirect loop emits neither `error_type` because auth succeeds on every lap. Needs its own instrumentation.
🎭 Playwright: ✅ 1818 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T04:12:19.225Z",
"gitSha": "19f3ab605596be89999d45f3fb7ea8c03e7b4d1b",
"branch": "backport-15346-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2028.9250000000152,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.1739999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.776,
"heapDeltaBytes": 5108948,
"heapUsedBytes": 70306288,
"domNodes": 24,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.836,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1991.7090000000144,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.2860000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.818,
"heapDeltaBytes": 5059376,
"heapUsedBytes": 70434332,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.218,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1717.6340000000323,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.779,
"layouts": 12,
"layoutDurationMs": 2.885,
"taskDurationMs": 658.7320000000001,
"heapDeltaBytes": -457792,
"heapUsedBytes": 64901552,
"domNodes": 57,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 76.226,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1731.6020000000663,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.895,
"layouts": 12,
"layoutDurationMs": 2.608,
"taskDurationMs": 633.811,
"heapDeltaBytes": 62096,
"heapUsedBytes": 65505016,
"domNodes": 57,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 79.617,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.349000000022,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.124999999999998,
"layouts": 6,
"layoutDurationMs": 0.6439999999999998,
"taskDurationMs": 293.217,
"heapDeltaBytes": 7814920,
"heapUsedBytes": 73052328,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.743,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.1600000000335,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.129,
"layouts": 6,
"layoutDurationMs": 0.482,
"taskDurationMs": 298.49499999999995,
"heapDeltaBytes": 7963900,
"heapUsedBytes": 73455440,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.321000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.0820000000494,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.3919999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.757,
"heapDeltaBytes": -11728732,
"heapUsedBytes": 53592796,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 42.778999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 37,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 468.77100000006067,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.460000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.465,
"heapDeltaBytes": -11868632,
"heapUsedBytes": 53622440,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 36.106,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2015.1599999999803,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.33099999999996,
"heapDeltaBytes": 9670632,
"heapUsedBytes": 69971900,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 13.221,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.2330000000093,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.773999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.538,
"heapDeltaBytes": 12195856,
"heapUsedBytes": 72733564,
"domNodes": -284,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 12.835000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2094.923999999992,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 943.3249999999999,
"heapDeltaBytes": 22758748,
"heapUsedBytes": 83925172,
"domNodes": -284,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 247.49900000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2090.7410000000937,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.422000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 898.6659999999999,
"heapDeltaBytes": 9460728,
"heapUsedBytes": 70604820,
"domNodes": -283,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 242.74200000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3121.8889999999533,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.717,
"layouts": 60,
"layoutDurationMs": 7.952000000000001,
"taskDurationMs": 1128.037,
"heapDeltaBytes": -8335628,
"heapUsedBytes": 53964860,
"domNodes": -285,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 291.90299999999996,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3105.893999999921,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.761999999999999,
"layouts": 60,
"layoutDurationMs": 7.457,
"taskDurationMs": 1079.184,
"heapDeltaBytes": -7822288,
"heapUsedBytes": 54004960,
"domNodes": 12,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 273.00600000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.870999999971,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.106999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.999,
"heapDeltaBytes": 12798092,
"heapUsedBytes": 73896584,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 14.445,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.3530000000092,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.537999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.8539999999999,
"heapDeltaBytes": 9706804,
"heapUsedBytes": 70831692,
"domNodes": -282,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 11.478000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.3980000000288,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.775,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.493,
"heapDeltaBytes": -9989196,
"heapUsedBytes": 55566320,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 87.738,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.00000000001,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.319000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.76800000000003,
"heapDeltaBytes": -10087472,
"heapUsedBytes": 55584020,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 83.481,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.4149999999804,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.191000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.37100000000004,
"heapDeltaBytes": 5029008,
"heapUsedBytes": 70502004,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1995.7019999999375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.848999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.64399999999995,
"heapDeltaBytes": 5520400,
"heapUsedBytes": 71167240,
"domNodes": 20,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 5.759,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.9100000000308,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.930000000000003,
"layouts": 16,
"layoutDurationMs": 3.569,
"taskDurationMs": 676.499,
"heapDeltaBytes": -3826888,
"heapUsedBytes": 61731068,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 61.95100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.3860000000086,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.161,
"layouts": 16,
"layoutDurationMs": 3.539,
"taskDurationMs": 582.2339999999999,
"heapDeltaBytes": -3788056,
"heapUsedBytes": 61760548,
"domNodes": 62,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 57.252,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 898.7569999999323,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.003000000000004,
"layouts": 15,
"layoutDurationMs": 8.665000000000001,
"taskDurationMs": 698.2120000000001,
"heapDeltaBytes": -6053444,
"heapUsedBytes": 79820292,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 11.943000000000001,
"eventListeners": 2373,
"totalBlockingTimeMs": 103,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8091.4779999999955,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3369.926,
"heapDeltaBytes": 13224860,
"heapUsedBytes": 73412852,
"domNodes": -279,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 805.772,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8113.887999999974,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3114.001,
"heapDeltaBytes": 24800468,
"heapUsedBytes": 85012188,
"domNodes": -282,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 733.5,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12786.847000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11975.664999999999,
"heapDeltaBytes": -37256984,
"heapUsedBytes": 172525620,
"domNodes": -8312,
"jsHeapTotalBytes": -5443584,
"scriptDurationMs": 80.83599999999998,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12586.207000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11764.337,
"heapDeltaBytes": -51428624,
"heapUsedBytes": 159048380,
"domNodes": -8316,
"jsHeapTotalBytes": -6230016,
"scriptDurationMs": 86.09100000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15371.312999999987,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.597000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14683.498000000001,
"heapDeltaBytes": -47545552,
"heapUsedBytes": 163015804,
"domNodes": -8312,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 382.268,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15482.886000000008,
"styleRecalcs": 82,
"styleRecalcDurationMs": 14.419999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14908.822,
"heapDeltaBytes": -47693936,
"heapUsedBytes": 162965872,
"domNodes": -8312,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 386.142,
"eventListeners": -16387,
"totalBlockingTimeMs": 12,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 445.5040000000281,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.984,
"layouts": 2,
"layoutDurationMs": 0.44899999999999995,
"taskDurationMs": 90.545,
"heapDeltaBytes": 4961612,
"heapUsedBytes": 69513448,
"domNodes": 128,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 5.891,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.90200000001823,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.97,
"layouts": 2,
"layoutDurationMs": 0.3489999999999999,
"taskDurationMs": 93.837,
"heapDeltaBytes": 4930728,
"heapUsedBytes": 69711452,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.150999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15464 +/- ##
=============================================
+ Coverage 79.11% 81.47% +2.36%
=============================================
Files 2209 1883 -326
Lines 122386 117510 -4876
Branches 38327 36708 -1619
=============================================
- Hits 96821 95743 -1078
+ Misses 24989 21291 -3698
+ Partials 576 476 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 335 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15346 to
core/1.51Automatically created by backport workflow.