Skip to content

[backport cloud/1.51] fix(layout): keep a node layout ref alive until its last holder releases - #15459

Merged
comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15092-to-cloud-1.51
Aug 20, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15092-to-cloud-1.51

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15092 to cloud/1.51

Automatically created by backport workflow.

…ses (#15092)

## Summary

`layoutStore.getNodeLayoutRef` caches one ref per node id, and
`cleanupNodeRef` dropped it on the first unmount — silently cutting off
every other holder of that same ref.

## Changes

- **What**: `cleanupNodeRef` → `retainNodeLayoutRef(nodeId)`, returning
`{ layout, release }` and reference-counting holders; the ref and its
trigger survive until the last holder releases. Migrates the three
long-lived holders (`useNodeLayout`, `canvasCoachTarget`,
`useSlotElementTracking`). Transient `getNodeLayoutRef(id).value` reads
stay uncounted.
- **Breaking**: `layoutStore.cleanupNodeRef` is removed; callers that
hold a ref past the current tick use `retainNodeLayoutRef`.

## Review Focus

The obvious fix — `Map<NodeId, Set<() => void>>`, as the issue suggests
— does not work. The ref is cached per node id, so one id has exactly
one ref and one trigger; the Set would hold a single element and cleanup
would still drop it. The defect is lifetime, not fan-out, hence
reference counting.

Counting inside `getNodeLayoutRef` does not work either: ~15 call sites
read `.value` transiently and never release, so the count would never
reach zero. Hence the explicit retain/release split.

Regression coverage, both verified failing before the fix and passing
after:

- `src/renderer/core/layout/store/layoutStore.multiHolder.test.ts` — two
holders, one releases, the other must still be notified. The paired
control test (both holders alive) passes in both states, so the red is
the defect and not the harness. Note the store's getter reads Yjs live,
so a bare `.value` read still returns fresh data; the staleness is only
observable through a reactive dependency, which is what the test and the
coachmark both use.
- `browser_tests/tests/firstRunTourNodeTracking.spec.ts` — the
user-visible symptom. The tour spotlights a node, the node's component
unmounts and remounts, the user drags the node. Before the fix the
spotlight stays frozen (`Expected: not 533.625`) while the node moves
away; after, it tracks. The e2e picks a template whose pinned roles this
backend actually serves — an unresolvable pin starts no tour at all,
which is a silent skip otherwise.

Fixes #14385

The same defect exists on `feature/ecs-migration`, where
`getNodeLayoutRef` has been rewritten (scoped keys, `ComputedRef` over a
revision `ref`) but keeps the same single-trigger lifetime. Ported
separately in #15093,
since this patch does not apply there.

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 20, 2026
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner August 20, 2026 03:59
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 20, 2026 03:59
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/20/2026, 04:01:25 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 121ms TBT · 95.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 3ms TBT · 174.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 481ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.1 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 840ms
canvas-mouse-sweep: script duration 95ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 46.0 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 363ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 355ms
dom-widget-clipping: script duration 50ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.3 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 585ms
large-graph-idle: script duration 12ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.8 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1175ms
large-graph-pan: script duration 327ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 61.9 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1315ms
large-graph-zoom: script duration 364ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.7 MB
large-graph-zoom: DOM nodes -137
large-graph-zoom: event listeners -88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 582ms
minimap-idle: script duration 12ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.5 MB
minimap-idle: DOM nodes -285
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 394ms
subgraph-dom-widget-clipping: script duration 117ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 52.9 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 435ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.5 MB
subgraph-idle: DOM nodes 18
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 34ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 739ms
subgraph-mouse-sweep: script duration 73ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.8 MB
subgraph-mouse-sweep: DOM nodes 62
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 836ms
subgraph-transition-enter: script duration 15ms
subgraph-transition-enter: TBT 121ms
subgraph-transition-enter: heap used 95.0 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4002ms
viewport-pan-sweep: script duration 946ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 70.4 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14695ms
vue-large-graph-idle: script duration 93ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.0 MB
vue-large-graph-idle: DOM nodes -8315
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 162
vue-large-graph-pan: task duration 17970ms
vue-large-graph-pan: script duration 426ms
vue-large-graph-pan: TBT 3ms
vue-large-graph-pan: heap used 174.2 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 105ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 97
Raw data
{
  "timestamp": "2026-08-20T04:10:46.781Z",
  "gitSha": "e59102be5976f1c07453fdca5e7ed11fae7a86f1",
  "branch": "backport-15092-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2033.6869999999863,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.8309999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.29999999999995,
      "heapDeltaBytes": 3754376,
      "heapUsedBytes": 68473656,
      "domNodes": 14,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 6.352999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2015.1010000000724,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.103999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.47099999999995,
      "heapDeltaBytes": 4962568,
      "heapUsedBytes": 70138492,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 6.774000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1850.7769999999937,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.20400000000001,
      "layouts": 12,
      "layoutDurationMs": 3.603,
      "taskDurationMs": 853.135,
      "heapDeltaBytes": -17081064,
      "heapUsedBytes": 48247796,
      "domNodes": -282,
      "jsHeapTotalBytes": 23171072,
      "scriptDurationMs": 98.35199999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1779.3349999999464,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 33.416000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.6110000000000007,
      "taskDurationMs": 827.577,
      "heapDeltaBytes": -17248376,
      "heapUsedBytes": 48268372,
      "domNodes": -278,
      "jsHeapTotalBytes": 22908928,
      "scriptDurationMs": 92.477,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.8840000000082,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.802999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.6929999999999998,
      "taskDurationMs": 364.91200000000003,
      "heapDeltaBytes": 7916184,
      "heapUsedBytes": 73138388,
      "domNodes": 79,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 9.493,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1674.0280000000212,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.297999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.6179999999999999,
      "taskDurationMs": 361.195,
      "heapDeltaBytes": 8230160,
      "heapUsedBytes": 73385372,
      "domNodes": 77,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 9.623000000000001,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 570.3379999999925,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.809000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.251,
      "heapDeltaBytes": -11279348,
      "heapUsedBytes": 53996776,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 51.03,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 561.5750000000617,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.608999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.10699999999997,
      "heapDeltaBytes": -11682964,
      "heapUsedBytes": 53596936,
      "domNodes": 16,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 48.938,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.4440000000031,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.645,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.417,
      "heapDeltaBytes": 12774516,
      "heapUsedBytes": 73064884,
      "domNodes": -281,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 12.359000000000002,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2065.2810000000272,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.058999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.234,
      "heapDeltaBytes": 13099596,
      "heapUsedBytes": 73220128,
      "domNodes": -281,
      "jsHeapTotalBytes": 3506176,
      "scriptDurationMs": 12.293000000000001,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.758000000025,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.464000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1223.252,
      "heapDeltaBytes": 9554488,
      "heapUsedBytes": 70338504,
      "domNodes": -283,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 355.59999999999997,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2134.6119999999473,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.961000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1125.8750000000002,
      "heapDeltaBytes": -1687500,
      "heapUsedBytes": 59508708,
      "domNodes": -282,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 297.568,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3151.594999999986,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.545000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.325999999999999,
      "taskDurationMs": 1276.1250000000002,
      "heapDeltaBytes": 16495828,
      "heapUsedBytes": 79187292,
      "domNodes": 12,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 348.733,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3196.7769999999973,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.910000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.263,
      "taskDurationMs": 1354.7800000000002,
      "heapDeltaBytes": -3888516,
      "heapUsedBytes": 58596144,
      "domNodes": -286,
      "jsHeapTotalBytes": 4292608,
      "scriptDurationMs": 379.348,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.063999999948,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.926999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.7549999999999,
      "heapDeltaBytes": 12564948,
      "heapUsedBytes": 73693468,
      "domNodes": -283,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 10.780999999999999,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.3049999999985,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.785000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.204,
      "heapDeltaBytes": 12684436,
      "heapUsedBytes": 74062480,
      "domNodes": -286,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 12.381999999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.9570000000076,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.102999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.64099999999996,
      "heapDeltaBytes": -9955952,
      "heapUsedBytes": 55540916,
      "domNodes": 22,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 121.59900000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.0220000000945,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.05,
      "heapDeltaBytes": -10128960,
      "heapUsedBytes": 55356116,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 113.071,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.1930000000007,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.799000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.654,
      "heapDeltaBytes": 5337328,
      "heapUsedBytes": 70848976,
      "domNodes": 16,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 6.423000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.7470000000376,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.246,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.76200000000006,
      "heapDeltaBytes": 5218216,
      "heapUsedBytes": 70780464,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 6.194000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9159999999742,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.443,
      "layouts": 16,
      "layoutDurationMs": 4.132000000000001,
      "taskDurationMs": 748.022,
      "heapDeltaBytes": -3647528,
      "heapUsedBytes": 61752304,
      "domNodes": 63,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 72.718,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.101000000046,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 32.951,
      "layouts": 16,
      "layoutDurationMs": 4.441,
      "taskDurationMs": 730.915,
      "heapDeltaBytes": -3956740,
      "heapUsedBytes": 61467004,
      "domNodes": 61,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 73.237,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1366.8799999999806,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 26.444999999999997,
      "layouts": 15,
      "layoutDurationMs": 11.015999999999998,
      "taskDurationMs": 835.6339999999998,
      "heapDeltaBytes": 22188052,
      "heapUsedBytes": 99570016,
      "domNodes": 13673,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 14.533999999999999,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8185.7640000000065,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.318999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4052.116,
      "heapDeltaBytes": 13420548,
      "heapUsedBytes": 73882836,
      "domNodes": -282,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 953.8249999999999,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8183.569000000034,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.568000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3952.473,
      "heapDeltaBytes": 13665968,
      "heapUsedBytes": 73705896,
      "domNodes": -283,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 938.98,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15826.544000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14833.113,
      "heapDeltaBytes": -39244924,
      "heapUsedBytes": 171849060,
      "domNodes": -8312,
      "jsHeapTotalBytes": -4624384,
      "scriptDurationMs": 106.42999999999998,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15262.832000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14556.763,
      "heapDeltaBytes": -31565092,
      "heapUsedBytes": 165825756,
      "domNodes": -8317,
      "jsHeapTotalBytes": -20647936,
      "scriptDurationMs": 80.211,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18545.93300000005,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 17.767000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18092.291,
      "heapDeltaBytes": -14877692,
      "heapUsedBytes": 182668688,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12591104,
      "scriptDurationMs": 443.512,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18318.39500000001,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 17.841999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17846.984,
      "heapDeltaBytes": -13983620,
      "heapUsedBytes": 182626076,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10756096,
      "scriptDurationMs": 409.02599999999995,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.43200000006345,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.467,
      "layouts": 3,
      "layoutDurationMs": 1.1940000000000002,
      "taskDurationMs": 110.66500000000002,
      "heapDeltaBytes": 5067788,
      "heapUsedBytes": 69601196,
      "domNodes": 148,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.069000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.0420000000295,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 16.713,
      "layouts": 2,
      "layoutDurationMs": 0.34199999999999997,
      "taskDurationMs": 99.408,
      "heapDeltaBytes": 4924036,
      "heapUsedBytes": 69642868,
      "domNodes": 123,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 6.135,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🎭 Playwright: ✅ 1818 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1797 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 20, 2026
@github-actions
github-actions Bot requested a review from AustinMroz August 20, 2026 04:00
@comfy-pr-bot
comfy-pr-bot merged commit 6faac65 into cloud/1.51 Aug 20, 2026
82 of 84 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15092-to-cloud-1.51 branch August 20, 2026 04:14
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.51   #15459      +/-   ##
==============================================
+ Coverage       79.11%   81.47%   +2.36%     
==============================================
  Files            2209     1882     -327     
  Lines          122386   117496    -4890     
  Branches        38327    36707    -1620     
==============================================
- Hits            96821    95726    -1095     
+ Misses          24989    21294    -3695     
+ Partials          576      476     -100     
Flag Coverage Δ
unit 72.90% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/renderer/core/layout/store/layoutStore.ts 84.14% <100.00%> (+0.15%) ⬆️
src/renderer/core/layout/types.ts 100.00% <ø> (ø)
.../extensions/firstRunTour/tour/canvasCoachTarget.ts 100.00% <100.00%> (ø)
...ons/vueNodes/composables/useSlotElementTracking.ts 97.56% <100.00%> (+<0.01%) ⬆️
...nderer/extensions/vueNodes/layout/useNodeLayout.ts 81.25% <100.00%> (-1.11%) ⬇️

... and 335 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants