Repository navigation
chore(lint): enforce reportError() instead of raw Sentry/Datadog calls - #15444
Conversation
The convention regressed within a day of #15346 merging: useSubscriptionActions.ts landed a fresh `captureException` with a hand-written `error_type` tag, reaching Sentry only. A convention that lives in a PR description does not survive contact with the next PR, so this makes it mechanical. `no-restricted-imports` now bans `captureException` from '@sentry/vue' and `datadogRum` from '@datadog/browser-rum', with a message naming the replacement. It follows the `useVirtualListRestriction` idiom already in this config — spliced into the three existing blocks rather than added as a new one, because a fourth overlapping block would have replaced the src-wide `no-restricted-syntax` rules wholesale and silently dropped the DOM-in-computed warnings. The rule catches namespace imports too, so four files that only needed breadcrumbs and setUser were flagged. Narrowing them from `import * as Sentry` to named imports is better than blanket-disabling: a disable comment on the namespace import would let a future `Sentry.captureException` slip in underneath it, which is the exact regression being prevented. That leaves four legitimate importers, all in src/platform/telemetry/, each carrying an explicit disable comment with a reason. Also documents the convention where agents actually read it: a Common Pitfalls entry in AGENTS.md and the Error Handling section of src/AGENTS.md. Verified red-green: a probe file importing each banned symbol errors in both .ts and .vue; removing the probes returns lint to 0 errors, and the four pre-existing DOM-in-computed warnings are still reported, confirming nothing was clobbered.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 9 minutes Limit details: You’ve used all 3 included reviews currently available. Your 73 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1826 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 9.12 MB gzip 🟢 -93 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • 🔴 +6 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • 🟢 -75 BBundles that do not match a named category
Status: 68 added / 68 removed / 219 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T02:15:22.603Z",
"gitSha": "9775bfe1e0042ad5f5568d702b0d2494ff5e0c11",
"branch": "chore/enforce-report-error-convention",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2099.010000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.859999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.746,
"heapDeltaBytes": 16504904,
"heapUsedBytes": 77799132,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.457999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2049.558999999931,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.370999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.233,
"heapDeltaBytes": 15371856,
"heapUsedBytes": 77417664,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.335999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2138.2859999999937,
"styleRecalcs": 76,
"styleRecalcDurationMs": 43.208000000000006,
"layouts": 12,
"layoutDurationMs": 3.9909999999999997,
"taskDurationMs": 1070.313,
"heapDeltaBytes": 8982972,
"heapUsedBytes": 70198592,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 121.964,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1838.6500000000296,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.47,
"layouts": 12,
"layoutDurationMs": 3.4279999999999995,
"taskDurationMs": 850.547,
"heapDeltaBytes": 16118336,
"heapUsedBytes": 77463340,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.66199999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.8309999999801,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.005,
"layouts": 6,
"layoutDurationMs": 0.6900000000000001,
"taskDurationMs": 350.976,
"heapDeltaBytes": 2786920,
"heapUsedBytes": 63910668,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.065,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.6050000000441,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.407,
"layouts": 6,
"layoutDurationMs": 0.6449999999999999,
"taskDurationMs": 342.53099999999995,
"heapDeltaBytes": 2493724,
"heapUsedBytes": 63917996,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.866999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 567.5359999999614,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.98699999999997,
"heapDeltaBytes": 9688664,
"heapUsedBytes": 71684916,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 54.30799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 549.4540000000825,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.50899999999996,
"heapDeltaBytes": 10311340,
"heapUsedBytes": 72037820,
"domNodes": 14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 53.29099999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.0179999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.189999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.911,
"heapDeltaBytes": -5390024,
"heapUsedBytes": 70608180,
"domNodes": -278,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 18.748999999999995,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2068.3579999999893,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.797999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.721,
"heapDeltaBytes": 13043136,
"heapUsedBytes": 87972956,
"domNodes": -280,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 13.899999999999995,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.155999999986,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1211.355,
"heapDeltaBytes": -4756928,
"heapUsedBytes": 71824252,
"domNodes": -269,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 332.8,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2164.066000000048,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.905000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1185.69,
"heapDeltaBytes": 12998332,
"heapUsedBytes": 88443816,
"domNodes": -280,
"jsHeapTotalBytes": 3629056,
"scriptDurationMs": 333.478,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3177.8119999999603,
"styleRecalcs": 66,
"styleRecalcDurationMs": 19.012999999999998,
"layouts": 60,
"layoutDurationMs": 6.819000000000001,
"taskDurationMs": 1390.643,
"heapDeltaBytes": -1577748,
"heapUsedBytes": 76335668,
"domNodes": -271,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 380.03999999999996,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3183.8590000000977,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.318000000000005,
"layouts": 60,
"layoutDurationMs": 7.181,
"taskDurationMs": 1360.8210000000001,
"heapDeltaBytes": -11946644,
"heapUsedBytes": 65846600,
"domNodes": -285,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 381.777,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2228.7209999999504,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1410.428,
"heapDeltaBytes": 12307468,
"heapUsedBytes": 96398196,
"domNodes": 14,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 453.25399999999996,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2242.2020000000202,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.683000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1402.0439999999999,
"heapDeltaBytes": 10686144,
"heapUsedBytes": 90057116,
"domNodes": 14,
"jsHeapTotalBytes": 6746112,
"scriptDurationMs": 448.216,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2073.3090000000516,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.949000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.3580000000001,
"heapDeltaBytes": -13650076,
"heapUsedBytes": 62749184,
"domNodes": -283,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 14.286999999999997,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.9110000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.903000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.201,
"heapDeltaBytes": -12373492,
"heapUsedBytes": 71467636,
"domNodes": -278,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 13.121999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 552.8209999999945,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.040000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.108,
"heapDeltaBytes": 11450600,
"heapUsedBytes": 72631176,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.98499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 552.6509999999689,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.412000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.905,
"heapDeltaBytes": 11096992,
"heapUsedBytes": 72795540,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 113.953,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1994.1200000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.782000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.84499999999997,
"heapDeltaBytes": 17947972,
"heapUsedBytes": 79348992,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.974,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1997.1399999999448,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.745000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.42500000000007,
"heapDeltaBytes": -5507928,
"heapUsedBytes": 55916900,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.977000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.0440000000021,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.028,
"layouts": 16,
"layoutDurationMs": 4.282,
"taskDurationMs": 785.4259999999999,
"heapDeltaBytes": 16288316,
"heapUsedBytes": 78030236,
"domNodes": -279,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 84.432,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.5659999999434,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.058,
"layouts": 16,
"layoutDurationMs": 4.425,
"taskDurationMs": 766.771,
"heapDeltaBytes": 15878188,
"heapUsedBytes": 77569232,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 83.97200000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.703000000045,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.217000000000002,
"layouts": 13,
"layoutDurationMs": 14.340000000000002,
"taskDurationMs": 899.3339999999998,
"heapDeltaBytes": 22147512,
"heapUsedBytes": 104514212,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 16.038999999999998,
"eventListeners": 2373,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.826000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.888999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4140.021,
"heapDeltaBytes": 14586680,
"heapUsedBytes": 89156436,
"domNodes": -280,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 1028.738,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.015000000047,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.785,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4086.1410000000005,
"heapDeltaBytes": -714008,
"heapUsedBytes": 75199940,
"domNodes": -277,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1017.6750000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16870.777999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16248.867999999999,
"heapDeltaBytes": -47611572,
"heapUsedBytes": 174577068,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 109.803,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17142.129000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16528.671,
"heapDeltaBytes": -28379708,
"heapUsedBytes": 179266880,
"domNodes": -8312,
"jsHeapTotalBytes": -8032256,
"scriptDurationMs": 116.77299999999998,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20705.85399999999,
"styleRecalcs": 174,
"styleRecalcDurationMs": 17.593999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20130.642000000003,
"heapDeltaBytes": -12245604,
"heapUsedBytes": 194482296,
"domNodes": -8312,
"jsHeapTotalBytes": -13119488,
"scriptDurationMs": 398.31600000000003,
"eventListeners": -16383,
"totalBlockingTimeMs": 96,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20796.009000000027,
"styleRecalcs": 178,
"styleRecalcDurationMs": 17.525000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20103.61,
"heapDeltaBytes": -26562172,
"heapUsedBytes": 194308108,
"domNodes": -8312,
"jsHeapTotalBytes": -13901824,
"scriptDurationMs": 409.6500000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 104.55300000000989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 15.437000000000001,
"layouts": 2,
"layoutDurationMs": 0.36399999999999993,
"taskDurationMs": 78.56099999999999,
"heapDeltaBytes": 3159900,
"heapUsedBytes": 64861116,
"domNodes": 114,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.513000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.53599999999642,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.999999999999996,
"layouts": 2,
"layoutDurationMs": 1.1270000000000002,
"taskDurationMs": 82.44399999999999,
"heapDeltaBytes": 3157828,
"heapUsedBytes": 64873772,
"domNodes": 134,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.047000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
This comment has been minimized.
This comment has been minimized.
CI catch, and my miss: migrating the call site to reportError() broke its own test, which I did not run. The test mocked '@sentry/vue' with only captureException, so reportError's isEnabled() probe threw, reportError swallowed it as designed, and the report silently never happened — surfacing as "expected vi.fn() to be called" rather than as the missing mock export. That silent shape is the hazard: any test that mocks a sink module directly will now fail this way instead of pointing at the cause. Swept every test mocking '@sentry/vue' or '@datadog/browser-rum'; auth.test.ts was the only other file exposed, and it stubs without asserting, so it was passing while reporting nothing. Added the missing isEnabled export there with a comment naming the trap rather than waiting for someone to add an assertion and lose an afternoon. The non-Error normalization assertion moves down a layer: that is reportError's job now and is covered in reportError.test.ts. What this test should assert is that the raw cause reaches the reporter at all. Full suite run this time: 1189 files, 16388 passed.
|
CI caught a real miss of mine — pushed a fix. Migrating That silent shape is worth flagging for review, because it generalises: from now on, any test that mocks a sink module directly will fail this way instead of pointing at the cause. I swept every test mocking One assertion moved down a layer deliberately: the non-Error normalization check belonged to Full unit suite run this time rather than the affected subset: 1189 files, 16388 passed. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #15444 +/- ##
==========================================
+ Coverage 79.22% 81.77% +2.55%
==========================================
Files 2213 1886 -327
Lines 113476 108573 -4903
Branches 34896 34215 -681
==========================================
- Hits 89898 88789 -1109
+ Misses 23106 19422 -3684
+ Partials 472 362 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 327 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Answers @huang47's question on #15346: "maybe worth putting the guidance somewhere... There should be a way for AI agents to honor this convention."
Documentation alone would not have held. The convention regressed within a day of #15346 merging —
useSubscriptionActions.tslanded a freshcaptureExceptionwith a hand-writtenerror_typetag, reaching Sentry only. So this makes it mechanical, and documents it second.Enforcement
no-restricted-importsbanscaptureExceptionfrom@sentry/vueanddatadogRumfrom@datadog/browser-rum, with a message naming the replacement and why it matters.It is spliced into the three existing blocks via a shared
reportErrorRestrictionsconst, following theuseVirtualListRestrictionidiom already in this config. That is deliberate, not stylistic: a fourth overlapping config block would have replaced the src-wideno-restricted-syntaxrule wholesale and silently dropped the existing DOM-in-computed warnings. Flat config does not merge rule options.Why four files became named imports
The rule catches namespace imports too, so
import * as Sentryin four files that only needaddBreadcrumb/setUser/setContext/initwas flagged. Those are narrowed to named imports rather than blanket-disabled — a disable comment on the namespace import would let a futureSentry.captureExceptionslip in underneath it, which is exactly the regression being prevented.That leaves four legitimate importers, all under
src/platform/telemetry/, each with an expliciteslint-disable-next-line ... -- the telemetry layer owns the sinks that reportError() fans out to. One grep now finds every direct-sink user in the repo.Documentation, where agents read it
AGENTS.mdCommon Pitfalls entry (the list agents are steered by)src/AGENTS.mdError Handling section — usage, and how to pick anerrorTypeslugVerification
.tsand.vue; removing the probes returns lint to 0 errors.pnpm typecheckclean; 522 tests pass across the affected suites.Regression risk
Low. Lint config plus one behavioural call site (
useSubscriptionActions.ts, now dual-sink instead of Sentry-only) and four import-style changes with no call-site semantics changed.