Skip to content

test: add viewport KeepAlive pan/zoom benchmark - #15372

Open
claude[bot] wants to merge 29 commits into
benjcooley/vue-nodes-simple-keepalivefrom
test/viewport-culling-perf-benchmark
Open

claude[bot] wants to merge 29 commits into
benjcooley/vue-nodes-simple-keepalivefrom
test/viewport-culling-perf-benchmark

Conversation

@claude

@claude claude Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Alexander Brown · Slack thread

Summary

Adds @perf Playwright benchmarks comparing "keep every node mounted" vs. viewport retention (Comfy.VueNodes.ViewportKeepAlive) during pan + zoom on a 245-node graph.

Changes

  • What: browser_tests/tests/vueNodes/viewportKeepAliveBenchmark.spec.ts (moved alongside viewportKeepAlive.spec.ts) runs a scripted pan-sweep + zoom in/out sequence with retention on and off, each in its own test with a fresh page fixture, reusing the existing large-graph-workflow fixture (245 nodes, above the activation threshold in useViewportKeepAlive.ts). Reports CDP metrics (DOM node delta + absolute count, layouts, task duration, total blocking time) via the existing PerformanceHelper/perfReporter pattern, plus performance.mark/measure wall-clock timing, logged to console for comparison. Not a regression gate — numbers vary machine to machine; each test asserts only the deterministic per-variant attached-node invariant (on: below a viewport-derived bound; off: equal to the full node count).
  • Review round 2 (Ben Cooley): fixed a blocker where bespoke PerformanceObservers double-counted the first variant's longtask/paint/layout-shift entries into the second (deleted in favor of PerformanceHelper's existing per-measurement-reset longtask collection); added an absolute DOM node count alongside the existing delta; gated both variants on full node mount + settle before measuring; dropped the post-hoc frameDurationMs field, which measured idle time rather than the interaction; widened the pan/zoom sweep's dx/dy so it actually crosses viewport boundaries; split the merged on/off test into two independent tests (each with a fresh page) to remove shared-page ordering bias; sized each test's timeout off observed CI durations; and trimmed the file's comments/prose.

Review Focus

  • Firefox isn't added as a project for this spec: PerformanceHelper measures via a Chromium CDP session, and the repo's existing performance Playwright project (which all @perf tests run under) is Chromium-only for the same reason — matching that convention rather than forking a new one for this benchmark.

Screenshots (if applicable)

N/A — this is a Playwright perf benchmark, not a UI change.

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 4 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 626ms TBT · 71.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 239ms TBT · 64.1 MB heap
extension-clean-combined-draw: · 31.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1528ms TBT · 143.8 MB heap
extension-rgthree-prototype-draw: · 31.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1220ms TBT · 153.2 MB heap
keep-alive-off: · 20.4 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 17ms TBT · 244.2 MB heap
keep-alive-on: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 110.2 MB heap
large-combo-open: · 41.4 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 4ms TBT · 62.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
minimap-geometry-cadence: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
minimap-progress-execution-cadence: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
minimap-topology-cadence: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-transition-enter: · 50.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 166ms TBT · 86.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.8 MB heap
vue-large-graph-pan: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 112.6 MB heap
vue-zoom-out-idle: · 57.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 146.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 38.2 MB heap
agent-composer-long-conversation-typing: · 59.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 8
canvas-idle: style recalc count 9
canvas-idle: task duration 591ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.3 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 931ms
canvas-mouse-sweep: script duration 166ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.2 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 10
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 469ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.6 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 519ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 73.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 1062ms
dom-widget-order-dense-n200-w200-i120: script duration 85ms
dom-widget-order-dense-n200-w200-i120: TBT 626ms
dom-widget-order-dense-n200-w200-i120: heap used 71.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 598ms
dom-widget-order-sparse-n1000-w20-i120: script duration 176ms
dom-widget-order-sparse-n1000-w20-i120: TBT 239ms
dom-widget-order-sparse-n1000-w20-i120: heap used 64.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -191
dom-widget-order-sparse-n1000-w20-i120: event listeners -106
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 10591ms
extension-clean-combined-draw: script duration 8528ms
extension-clean-combined-draw: TBT 1528ms
extension-clean-combined-draw: heap used 143.8 MB
extension-clean-combined-draw: DOM nodes -257
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 58ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10387ms
extension-rgthree-prototype-draw: script duration 8401ms
extension-rgthree-prototype-draw: TBT 1220ms
extension-rgthree-prototype-draw: heap used 153.2 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -68
keep-alive-off: avg frame time 49ms
keep-alive-off: p95 frame time 100ms
keep-alive-off: layout duration 1ms
keep-alive-off: style recalc duration 17ms
keep-alive-off: layout count 10
keep-alive-off: style recalc count 152
keep-alive-off: task duration 25632ms
keep-alive-off: script duration 830ms
keep-alive-off: TBT 17ms
keep-alive-off: heap used 244.2 MB
keep-alive-off: DOM nodes 0
keep-alive-off: event listeners 2
keep-alive-on: avg frame time 17ms
keep-alive-on: p95 frame time 17ms
keep-alive-on: layout duration 22ms
keep-alive-on: style recalc duration 73ms
keep-alive-on: layout count 32
keep-alive-on: style recalc count 75
keep-alive-on: task duration 5216ms
keep-alive-on: script duration 727ms
keep-alive-on: TBT 0ms
keep-alive-on: heap used 110.2 MB
keep-alive-on: DOM nodes 280
keep-alive-on: event listeners 2
large-combo-open: avg frame time 24ms
large-combo-open: p95 frame time 92ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 10
large-combo-open: style recalc count 23
large-combo-open: task duration 202ms
large-combo-open: script duration 9ms
large-combo-open: TBT 4ms
large-combo-open: heap used 62.7 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 3ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 759ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.7 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1800ms
large-graph-pan: script duration 865ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 70.5 MB
large-graph-pan: DOM nodes -257
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1844ms
large-graph-zoom: script duration 806ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 80.0 MB
large-graph-zoom: DOM nodes -105
large-graph-zoom: event listeners -34
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 2143ms
legacy-node-drag: script duration 1044ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.3 MB
legacy-node-drag: DOM nodes -257
legacy-node-drag: event listeners -64
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 7
minimap-geometry-cadence: style recalc count 8
minimap-geometry-cadence: task duration 855ms
minimap-geometry-cadence: script duration 377ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 71.0 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -68
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 7
minimap-idle: style recalc count 7
minimap-idle: task duration 691ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 65.0 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -68
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 12ms
minimap-progress-execution-cadence: layout count 7
minimap-progress-execution-cadence: style recalc count 26
minimap-progress-execution-cadence: task duration 643ms
minimap-progress-execution-cadence: script duration 200ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 72.4 MB
minimap-progress-execution-cadence: DOM nodes -253
minimap-progress-execution-cadence: event listeners -68
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 6
minimap-topology-cadence: style recalc count 6
minimap-topology-cadence: task duration 1013ms
minimap-topology-cadence: script duration 391ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 68.5 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 458ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 58.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 611ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.6 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 879ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.4 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1168ms
subgraph-transition-enter: script duration 35ms
subgraph-transition-enter: TBT 166ms
subgraph-transition-enter: heap used 86.6 MB
subgraph-transition-enter: DOM nodes 16110
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 29ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 6215ms
viewport-pan-sweep: script duration 2785ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.7 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 4804ms
vue-large-graph-idle: script duration 111ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 107.8 MB
vue-large-graph-idle: DOM nodes 0
vue-large-graph-idle: event listeners 0
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 11ms
vue-large-graph-pan: layout count 1
vue-large-graph-pan: style recalc count 62
vue-large-graph-pan: task duration 5990ms
vue-large-graph-pan: script duration 754ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 112.6 MB
vue-large-graph-pan: DOM nodes 3
vue-large-graph-pan: event listeners 2
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 1
vue-zoom-out-idle: task duration 4716ms
vue-zoom-out-idle: script duration 113ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 146.4 MB
vue-zoom-out-idle: DOM nodes -141
vue-zoom-out-idle: event listeners -4
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 5ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 12
workflow-execution: style recalc count 19
workflow-execution: task duration 147ms
workflow-execution: script duration 14ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.0 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 7
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 17ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 511ms
agent-composer-empty-conversation-typing: script duration 247ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 38.2 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 17ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 593ms
agent-composer-long-conversation-typing: script duration 241ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 91.4 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 294
Raw data
{
  "timestamp": "2026-10-27T07:35:27.081Z",
  "gitSha": "99bd7061c5dbe27a63a4ff82b81e894ffede680e",
  "branch": "test/viewport-culling-perf-benchmark",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.9580000000074,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.8140000000000005,
      "layouts": 8,
      "layoutDurationMs": 2.825,
      "taskDurationMs": 555.6809999999999,
      "heapDeltaBytes": 2246732,
      "heapUsedBytes": 63732680,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 10.774,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.8460000000532,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.692,
      "layouts": 8,
      "layoutDurationMs": 2.756,
      "taskDurationMs": 627.263,
      "heapDeltaBytes": 3717892,
      "heapUsedBytes": 64897008,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 14.485000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1775.4059999999754,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 13.793,
      "layouts": 10,
      "layoutDurationMs": 2.891,
      "taskDurationMs": 907.229,
      "heapDeltaBytes": -1422540,
      "heapUsedBytes": 68707516,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 161.452,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1841.468999999961,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.145999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.801,
      "taskDurationMs": 955.0829999999999,
      "heapDeltaBytes": 23829168,
      "heapUsedBytes": 84810276,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 171.017,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665454545454544,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.5619999999958,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.9239999999999995,
      "layouts": 10,
      "layoutDurationMs": 3.527,
      "taskDurationMs": 474.29200000000003,
      "heapDeltaBytes": 24339004,
      "heapUsedBytes": 84865836,
      "domNodes": 56,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 15.953000000000001,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.8970000000554,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.316000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.3620000000000005,
      "taskDurationMs": 463.71999999999997,
      "heapDeltaBytes": 970532,
      "heapUsedBytes": 71624216,
      "domNodes": 56,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 14.052999999999999,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 743.1359999999927,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.9509999999999996,
      "layouts": 9,
      "layoutDurationMs": 2.6529999999999996,
      "taskDurationMs": 517.285,
      "heapDeltaBytes": 6801636,
      "heapUsedBytes": 77169156,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 172.696,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909086,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 744.6529999999711,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.2930000000000006,
      "layouts": 9,
      "layoutDurationMs": 2.8130000000000006,
      "taskDurationMs": 521.412,
      "heapDeltaBytes": 6617100,
      "heapUsedBytes": 77331308,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 170.73,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1263.2849999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 997.1830000000001,
      "heapDeltaBytes": -11590876,
      "heapUsedBytes": 75638648,
      "domNodes": -191,
      "jsHeapTotalBytes": 20979712,
      "scriptDurationMs": 82.52,
      "eventListeners": -106,
      "totalBlockingTimeMs": 583,
      "frameDurationMs": 34.229729729729726,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1375.3779999999551,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1126.3770000000002,
      "heapDeltaBytes": -12573308,
      "heapUsedBytes": 75214988,
      "domNodes": -191,
      "jsHeapTotalBytes": 21766144,
      "scriptDurationMs": 87.415,
      "eventListeners": -106,
      "totalBlockingTimeMs": 669,
      "frameDurationMs": 35.96315789473685,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 937.8700000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.7310000000004,
      "heapDeltaBytes": -28965212,
      "heapUsedBytes": 67171944,
      "domNodes": -191,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 172.539,
      "eventListeners": -106,
      "totalBlockingTimeMs": 245,
      "frameDurationMs": 25.224324324324304,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 919.7689999999739,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.8789999999997,
      "heapDeltaBytes": -16179444,
      "heapUsedBytes": 67182676,
      "domNodes": -191,
      "jsHeapTotalBytes": 1703936,
      "scriptDurationMs": 180.443,
      "eventListeners": -106,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 24.77297297297296,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11659.20299999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10897.842,
      "heapDeltaBytes": 79297716,
      "heapUsedBytes": 155032628,
      "domNodes": -257,
      "jsHeapTotalBytes": 74838016,
      "scriptDurationMs": 8780.541,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1722,
      "frameDurationMs": 32.4966573816156,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11100.099,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10284.78,
      "heapDeltaBytes": 71807948,
      "heapUsedBytes": 146633828,
      "domNodes": -257,
      "jsHeapTotalBytes": 67760128,
      "scriptDurationMs": 8276.105,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1334,
      "frameDurationMs": 31.443342776203966,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11068.045000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10281.072999999999,
      "heapDeltaBytes": 79929588,
      "heapUsedBytes": 162800392,
      "domNodes": -257,
      "jsHeapTotalBytes": 74838016,
      "scriptDurationMs": 8304.883,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1120,
      "frameDurationMs": 31.52792022792023,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11258.604999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10491.958,
      "heapDeltaBytes": 84072668,
      "heapUsedBytes": 158403336,
      "domNodes": -257,
      "jsHeapTotalBytes": 79818752,
      "scriptDurationMs": 8497.062,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1319,
      "frameDurationMs": 32.14142857142857,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "keep-alive-off",
      "durationMs": 26419.196,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 18.119999999999997,
      "layouts": 10,
      "layoutDurationMs": 1.1940000000000006,
      "taskDurationMs": 25657.82,
      "heapDeltaBytes": -21009484,
      "heapUsedBytes": 255395988,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 829.612,
      "eventListeners": 2,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 48.64751381215469,
      "p95FrameDurationMs": 100.09999999999854
    },
    {
      "name": "keep-alive-off",
      "durationMs": 26397.72800000003,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 16.872999999999998,
      "layouts": 10,
      "layoutDurationMs": 1.1750000000000094,
      "taskDurationMs": 25605.237,
      "heapDeltaBytes": 1586416,
      "heapUsedBytes": 256673640,
      "domNodes": 0,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 831.0600000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 49.22070895522387,
      "p95FrameDurationMs": 100.10000000000582
    },
    {
      "name": "keep-alive-on",
      "durationMs": 6451.35700000003,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 71.478,
      "layouts": 30,
      "layoutDurationMs": 21.661,
      "taskDurationMs": 5177.74,
      "heapDeltaBytes": -3356792,
      "heapUsedBytes": 113728060,
      "domNodes": 276,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 715.6519999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75272727272727,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "keep-alive-on",
      "durationMs": 6573.2490000000325,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 74.27799999999998,
      "layouts": 33,
      "layoutDurationMs": 22.839000000000006,
      "taskDurationMs": 5254.657,
      "heapDeltaBytes": 4685496,
      "heapUsedBytes": 117480516,
      "domNodes": 284,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 739.152,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.880205655526993,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-combo-open",
      "durationMs": 277.7369999999735,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 14.711,
      "layouts": 11,
      "layoutDurationMs": 3.3400000000000003,
      "taskDurationMs": 235.18200000000002,
      "heapDeltaBytes": -16449328,
      "heapUsedBytes": 58240876,
      "domNodes": 936,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 8.827,
      "eventListeners": 205,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 100.09999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 233.89099999997143,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 13.274000000000001,
      "layouts": 8,
      "layoutDurationMs": 2.4450000000000003,
      "taskDurationMs": 169.65000000000003,
      "heapDeltaBytes": 14632612,
      "heapUsedBytes": 73342448,
      "domNodes": 936,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.915000000000001,
      "eventListeners": 205,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 23.34000000000001,
      "p95FrameDurationMs": 83.29999999999973
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.1489999999812,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.503,
      "layouts": 7,
      "layoutDurationMs": 2.2429999999999994,
      "taskDurationMs": 732.4969999999998,
      "heapDeltaBytes": -3826884,
      "heapUsedBytes": 72052728,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 36.389,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.1730000000343,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.7419999999999995,
      "layouts": 8,
      "layoutDurationMs": 2.978,
      "taskDurationMs": 786.218,
      "heapDeltaBytes": -30068448,
      "heapUsedBytes": 61636844,
      "domNodes": -257,
      "jsHeapTotalBytes": 5144576,
      "scriptDurationMs": 38.88,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2744.3099999999845,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.284,
      "layouts": 7,
      "layoutDurationMs": 2.1020000000000003,
      "taskDurationMs": 1826.5330000000001,
      "heapDeltaBytes": -30310792,
      "heapUsedBytes": 62201272,
      "domNodes": -257,
      "jsHeapTotalBytes": 6979584,
      "scriptDurationMs": 879.965,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.768098159509208,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2640.6709999999975,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.916,
      "layouts": 7,
      "layoutDurationMs": 2.0340000000000003,
      "taskDurationMs": 1773.822,
      "heapDeltaBytes": 5756104,
      "heapUsedBytes": 85727824,
      "domNodes": -257,
      "jsHeapTotalBytes": 4546560,
      "scriptDurationMs": 849.7549999999999,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849056,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3837.503999999967,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.775,
      "layouts": 64,
      "layoutDurationMs": 11.046,
      "taskDurationMs": 1846.059,
      "heapDeltaBytes": 8318136,
      "heapUsedBytes": 85548848,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 806.274,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666086956521738,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3877.8780000000097,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.219999999999999,
      "layouts": 64,
      "layoutDurationMs": 11.035,
      "taskDurationMs": 1842.598,
      "heapDeltaBytes": 1008268,
      "heapUsedBytes": 82283636,
      "domNodes": -233,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 805.2940000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666523605150214,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3323.5689999999636,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.688,
      "layouts": 5,
      "layoutDurationMs": 1.529,
      "taskDurationMs": 2195.004,
      "heapDeltaBytes": 10284568,
      "heapUsedBytes": 83471460,
      "domNodes": -257,
      "jsHeapTotalBytes": 3952640,
      "scriptDurationMs": 1074.376,
      "eventListeners": -62,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.83502538071066,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3244.8499999999285,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.729000000000001,
      "layouts": 5,
      "layoutDurationMs": 1.4309999999999996,
      "taskDurationMs": 2090.7819999999997,
      "heapDeltaBytes": 6415240,
      "heapUsedBytes": 78691720,
      "domNodes": -257,
      "jsHeapTotalBytes": 3428352,
      "scriptDurationMs": 1013.372,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.840104166666666,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3142.0519999999783,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.8710000000000002,
      "layouts": 7,
      "layoutDurationMs": 1.554,
      "taskDurationMs": 856.364,
      "heapDeltaBytes": -8594600,
      "heapUsedBytes": 70711888,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 375.853,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665957446808513,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3115.8849999999347,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.9929999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.7560000000000002,
      "taskDurationMs": 853.302,
      "heapDeltaBytes": -277528,
      "heapUsedBytes": 78284916,
      "domNodes": -257,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 377.17900000000003,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665775401069517,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2055.3840000000037,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.8580000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.8090000000000004,
      "taskDurationMs": 688.701,
      "heapDeltaBytes": -8674360,
      "heapUsedBytes": 62901948,
      "domNodes": -257,
      "jsHeapTotalBytes": 2748416,
      "scriptDurationMs": 33.005,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665040650406503,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.8880000000809,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.3280000000000003,
      "layouts": 7,
      "layoutDurationMs": 2.2300000000000004,
      "taskDurationMs": 694.073,
      "heapDeltaBytes": -19693464,
      "heapUsedBytes": 73343176,
      "domNodes": -257,
      "jsHeapTotalBytes": 5144576,
      "scriptDurationMs": 35.684,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2868.418999999989,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 11.629,
      "layouts": 6,
      "layoutDurationMs": 1.6610000000000003,
      "taskDurationMs": 638.579,
      "heapDeltaBytes": -267576,
      "heapUsedBytes": 75946552,
      "domNodes": -253,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 203.088,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665697674418606,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2770.854999999983,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 12.269000000000002,
      "layouts": 7,
      "layoutDurationMs": 2.04,
      "taskDurationMs": 647.179,
      "heapDeltaBytes": -1641512,
      "heapUsedBytes": 75854312,
      "domNodes": -253,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 196.108,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66566265060241,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3353.2699999999804,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.0230000000000006,
      "layouts": 6,
      "layoutDurationMs": 1.425,
      "taskDurationMs": 996.313,
      "heapDeltaBytes": 3871744,
      "heapUsedBytes": 80747276,
      "domNodes": -257,
      "jsHeapTotalBytes": 5894144,
      "scriptDurationMs": 393.54100000000005,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7495,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3352.049000000079,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.7660000000000002,
      "layouts": 6,
      "layoutDurationMs": 2.1719999999999997,
      "taskDurationMs": 1029.691,
      "heapDeltaBytes": -8493340,
      "heapUsedBytes": 62849600,
      "domNodes": -257,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 389.18199999999996,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666169154228854,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 689.3950000000473,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.405,
      "layouts": 9,
      "layoutDurationMs": 3.009,
      "taskDurationMs": 462.47400000000005,
      "heapDeltaBytes": -862184,
      "heapUsedBytes": 60995792,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 148.49699999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 648.3279999999922,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.971999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.3029999999999995,
      "taskDurationMs": 453.38800000000003,
      "heapDeltaBytes": -55848,
      "heapUsedBytes": 62104036,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 144.347,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.0259999999726,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.040000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.0170000000000003,
      "taskDurationMs": 584.251,
      "heapDeltaBytes": 5635184,
      "heapUsedBytes": 77399132,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 10.639000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.1029999999919,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.6399999999999992,
      "layouts": 8,
      "layoutDurationMs": 2.667,
      "taskDurationMs": 637.5649999999999,
      "heapDeltaBytes": 1756468,
      "heapUsedBytes": 64405868,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 12.701,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.4459999999808,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 14.406000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.743,
      "taskDurationMs": 861.013,
      "heapDeltaBytes": 17558960,
      "heapUsedBytes": 78752076,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 112.156,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.2420000000275,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 14.88,
      "layouts": 9,
      "layoutDurationMs": 2.6370000000000005,
      "taskDurationMs": 896.79,
      "heapDeltaBytes": -5702128,
      "heapUsedBytes": 66713596,
      "domNodes": 0,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 113.542,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1470.7750000000033,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.997999999999998,
      "layouts": 5,
      "layoutDurationMs": 14.505999999999998,
      "taskDurationMs": 1168.0259999999998,
      "heapDeltaBytes": 12209424,
      "heapUsedBytes": 90759296,
      "domNodes": 16110,
      "jsHeapTotalBytes": 7999488,
      "scriptDurationMs": 35.448,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 166,
      "frameDurationMs": 19.777333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10656.502999999986,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 30.659999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.4499999999999997,
      "taskDurationMs": 6420.201000000001,
      "heapDeltaBytes": 5870364,
      "heapUsedBytes": 84879632,
      "domNodes": -257,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 2853.321,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666040688575897,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9595.988999999918,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 28.296,
      "layouts": 8,
      "layoutDurationMs": 1.9279999999999997,
      "taskDurationMs": 6009.706,
      "heapDeltaBytes": -15805712,
      "heapUsedBytes": 61374092,
      "domNodes": -257,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 2717.208,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69495652173913,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 6095.37499999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4615.159,
      "heapDeltaBytes": -15791144,
      "heapUsedBytes": 105803272,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 105.95,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666120218579234,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 6114.690999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4992.928,
      "heapDeltaBytes": 11994620,
      "heapUsedBytes": 120275916,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 116.55799999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665940054495913,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 7224.590999999975,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.690999999999999,
      "layouts": 1,
      "layoutDurationMs": 0.17399999999999707,
      "taskDurationMs": 5973.741999999999,
      "heapDeltaBytes": 2170440,
      "heapUsedBytes": 106852244,
      "domNodes": 3,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 744.4079999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.704618937644344,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 7266.186999999945,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.233999999999995,
      "layouts": 1,
      "layoutDurationMs": 0.16399999999999748,
      "taskDurationMs": 6005.471,
      "heapDeltaBytes": 24027064,
      "heapUsedBytes": 129336540,
      "domNodes": 3,
      "jsHeapTotalBytes": 2846720,
      "scriptDurationMs": 763.4430000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.742857142857144,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5196.354999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4624.3060000000005,
      "heapDeltaBytes": 10312156,
      "heapUsedBytes": 157648924,
      "domNodes": -141,
      "jsHeapTotalBytes": 14938112,
      "scriptDurationMs": 106.294,
      "eventListeners": -4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.104276315789477,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5379.421999999977,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.07799999999999474,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4807.629999999999,
      "heapDeltaBytes": 1472764,
      "heapUsedBytes": 149283196,
      "domNodes": -141,
      "jsHeapTotalBytes": 22540288,
      "scriptDurationMs": 119.78200000000005,
      "eventListeners": -4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.714238410596028,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 511.50100000000975,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 17.97,
      "layouts": 12,
      "layoutDurationMs": 4.937,
      "taskDurationMs": 155.215,
      "heapDeltaBytes": 7153132,
      "heapUsedBytes": 74736764,
      "domNodes": 138,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.598,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 502.7670000000626,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 11.606000000000002,
      "layouts": 11,
      "layoutDurationMs": 5.3950000000000005,
      "taskDurationMs": 138.395,
      "heapDeltaBytes": 6957664,
      "heapUsedBytes": 67930308,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.689999999999998,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 532.0520000000215,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6809999999999999,
      "layouts": 76,
      "layoutDurationMs": 16.558,
      "taskDurationMs": 485.389,
      "heapDeltaBytes": -3754508,
      "heapUsedBytes": 37991468,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 231.92399999999998,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662499999999994,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 583.3979999999883,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.736,
      "layouts": 76,
      "layoutDurationMs": 17.042,
      "taskDurationMs": 536.438,
      "heapDeltaBytes": -3176204,
      "heapUsedBytes": 42019704,
      "domNodes": 4,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 262.683,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 687.6689999999144,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.248,
      "layouts": 76,
      "layoutDurationMs": 17.511,
      "taskDurationMs": 643.43,
      "heapDeltaBytes": 2949508,
      "heapUsedBytes": 96483224,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 267.12,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.070731707317087,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 576.3309999999819,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.684,
      "layouts": 76,
      "layoutDurationMs": 15.961,
      "taskDurationMs": 542.062,
      "heapDeltaBytes": 1743416,
      "heapUsedBytes": 95279724,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 215.092,
      "eventListeners": 296,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66285714285714,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 60.4%

Coverage totals
Metric Covered Total Pct
Lines 60472 100057 60.4% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1177
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.1% 657
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 15.0% 640
src/workbench/extensions/agent/AgentPanelRoot.vue 27.9% 559
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 14.6% 497
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.3% 425
src/LGraphNode.ts 71.3% 379
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 26.2% 378
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/billing/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 314

🎭 Playwright: ✅ 3122 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2322 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 769 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/10/2026, 11:55:22 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 740211cd66a44120b9e0dca96df0577601a64448

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (210)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 160 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 17, 2026
@codecov

codecov Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                            @@
##           benjcooley/vue-nodes-simple-keepalive   #15372      +/-   ##
=========================================================================
- Coverage                                  87.63%   87.32%   -0.31%     
=========================================================================
  Files                                       2787     2948     +161     
  Lines                                     155021   156865    +1844     
  Branches                                   41923    41923              
=========================================================================
+ Hits                                      135848   136989    +1141     
- Misses                                     18499    19201     +702     
- Partials                                     674      675       +1     
Flag Coverage Δ
e2e 60.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 343 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added risk:R3 PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Aug 17, 2026
benjcooley and others added 11 commits August 18, 2026 21:35
Review against the branch this replaces found six regressions. All are
restored here; the seventh finding, unbounded activation at low zoom, is
owned by the LOD layer stacked above and is deliberately not duplicated.

Detached elements no longer measure into canonical layout. KeepAlive
deactivation detaches the subtree without unmounting it, and the shared
ResizeObserver kept watching. A detached element reports 0x0, which is not
equal to any real size and so passed every isBoundsEqual guard, reaching
layoutStore and from there node.serialize(). This was the hazard the
previous branch chose v-if over display:none to avoid, and the guard was
never carried across. The observer callback now skips disconnected targets
and marks them for a fresh measurement on reattach. The regression test was
committed and confirmed red in CI before this fix.

Selection is no longer a pin. Retention re-adds a node only while it is
pinned and already attached, but a retained node is attached on the next
refresh too, so retention feeds itself: select-all then pan accumulated
every node the viewport ever touched and silently disabled the feature. A
test reproduces exactly that at 150 of 150. Under KeepAlive a detached node
keeps both its component instance and its selection state, so selection
needs no attachment guarantee, and it is the one pin that can be graph-
sized. The remaining pins - focus, playing media, link-drag source - are
bounded by construction, and each can only exist on an attached node, so
retention is the correct direction and admission is never needed.

The extension opt-out is restored with the same contract as before:
extensionManager.vueNodes.registerCullingOptOut(nodeType), ref-counted,
returning a release. Under KeepAlive it is admission rather than retention -
a registered type stays attached wherever it is - because it exists for
state a detach destroys and a component cannot keep: canvas contexts,
uncontrolled editors, self-measuring widgets. Registration is reactive, so
an extension registering at load attaches its nodes without waiting for a
pan.

A support kill switch is added as Comfy.VueNodes.ViewportKeepAlive. It is a
new id: the previous setting had been redefined to choose between unmount
and keep-alive, and there is no unmount mode here to choose. Passed as a
getter so it is a reactive dependency - off attaches everything rather than
freezing the last computed set, and on recomputes at once.

The live-state subtree scan is throttled to the sibling composable's 100ms.
It ran on every mutation batch under the root, and every activate and
deactivate is such a batch, so it rescanned on exactly the churn it exists
to bound.

Membership is a length plus order-independent digest instead of a JSON
string over every id, which allocated proportional to graph size on the
path this feature exists to make cheap.

Each fix is pinned by a test that fails against its mutant: dropping the
detached guard, ignoring or un-watching the kill switch, not admitting or
not reacting to opt-out registration, turning pins into admission, and
breaking release idempotency in the registry.
@christian-byrne

Copy link
Copy Markdown
Contributor

@DrJKL — heads up before this goes further: the architecture underneath it was replaced on 2026-08-18, after this was opened.

#15030 is retired (retitled DO NOT SUBMIT, now draft). #15405 replaced it with a KeepAlive-only implementation, and #15031 was rebased onto that. Both are approved and CLEAN as of now.

Three concrete consequences for this branch:

  1. Comfy.VueNodes.ViewportCulling no longer exists. It is not on main and not on the replacement stack. It only ever existed on DO NOT SUBMIT - perf: virtualize Vue nodes outside the viewport #15030.
  2. This PR defines a competing setting id. It adds Comfy.VueNodes.ViewportCullingKeepAlive (plus a schema entry). perf: retain offscreen Vue nodes with KeepAlive #15405 ships Comfy.VueNodes.ViewportKeepAlive for the same feature. If both land we get two ids for one behaviour, and the one here points at an implementation that was deleted.
  3. useViewportCulling.ts is gone, along with the 250ms debounced unmount this benchmark clears and the mount-admission scheduler it settles against. The helpers here are written against a state machine that no longer exists.

So this cannot merge as-is, but the purpose is still worth having — arguably more now than before, because the ADR's performance evidence is a three-run smoke and, separately, CI perf baselines have not been written since March (#15409), so there is no automated corroboration for any of this.

Suggested retarget, if you still want it:

Not asking anyone to drop work; flagging it now so this does not get rebased into a conflict or land a duplicate setting. Happy to review the retarget.

…cture

#15030 (viewport culling) was retired and replaced by #15405, which ships
KeepAlive-only viewport retention (Comfy.VueNodes.ViewportKeepAlive, default
on) with no destructive-unmount mode. Rebase this benchmark onto #15405's
branch and drive it off that setting directly instead of the deleted
useViewportCulling.ts and the now-nonexistent
Comfy.VueNodes.ViewportCullingKeepAlive setting this PR had added.

- Drop the Comfy.VueNodes.ViewportCullingKeepAlive setting and the
  GraphCanvas.vue KeepAlive branch that pointed at it - #15405's GraphCanvas
  already renders through KeepAlive unconditionally, gated by
  Comfy.VueNodes.ViewportKeepAlive.
- Rewrite viewportCullingBenchmark.spec.ts as a two-way KeepAlive on/off
  comparison (no third "destroy" variant, since one no longer exists).
- Drop the mount-admission/departure debounce-settle helpers; KeepAlive
  activation is one throttled refresh (REFRESH_THROTTLE_MS = 100ms in
  useViewportKeepAlive.ts), so settling is a single idleFrames wait.
@claude
claude Bot force-pushed the test/viewport-culling-perf-benchmark branch from f7c1f7f to 76704b1 Compare August 21, 2026 03:08
@claude

claude Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Verified @christian-byrne's comment above independently before acting on it:

All checked out, so I retargeted this PR:

  • Reset test/viewport-culling-perf-benchmark onto benjcooley/vue-nodes-simple-keepalive at 554cd8c (perf: retain offscreen Vue nodes with KeepAlive #15405's current head) and force-pushed — commit 76704b1.
  • Dropped Comfy.VueNodes.ViewportCullingKeepAlive from coreSettings.ts/apiSchema.ts and the GraphCanvas.vue branch that read it — unnecessary now, since perf: retain offscreen Vue nodes with KeepAlive #15405's GraphCanvas.vue already always renders through <KeepAlive>, gated by Comfy.VueNodes.ViewportKeepAlive itself.
  • Rewrote viewportCullingBenchmark.spec.ts as a two-way Comfy.VueNodes.ViewportKeepAlive on/off comparison (there's no third "destroy" variant to compare against anymore — KeepAlive is the only mode). Dropped the debounce/mount-admission settle helpers; activation is now a single REFRESH_THROTTLE_MS (100ms) throttled refresh, so settling is one idleFrames wait after the pan/zoom sequence.
  • pnpm lint, pnpm typecheck, and playwright test --project=performance --list on the rewritten spec all pass clean (2 tests found, correctly routed to the performance project).

One thing I could not do: this session's GitHub write access explicitly excludes changing a PR's base branch, so the PR still shows base: benjcooley/vue-nodes-viewport-culling even though the branch content is now rebased onto benjcooley/vue-nodes-simple-keepalive. Until someone changes the base (GitHub UI, or gh pr edit 15372 --base benjcooley/vue-nodes-simple-keepalive), the diff above will show as a large, unreviewable, dirty-mergeable diff against the stale base — that's expected and will resolve as soon as the base is repointed.

Also worth flagging per your comment: the Chrome-specific KeepAlive perf gap and the dead perf-baseline pipeline (#15409) aren't addressed by this benchmark either way — this PR only measures relative on/off cost locally, with no CI baseline to compare against yet.


Generated by Claude Code

@DrJKL
DrJKL changed the base branch from benjcooley/vue-nodes-viewport-culling to benjcooley/vue-nodes-simple-keepalive August 21, 2026 03:22
Base branch was changed to benjcooley/vue-nodes-simple-keepalive via the
GitHub UI after this branch was already rebased onto it, which only fired
a pull_request "edited" event. CI workflows (ci-tests-e2e.yaml,
ci-tests-unit.yaml, ci-lint-format.yaml, etc.) trigger on default
pull_request types [opened, synchronize, reopened] and do not listen for
"edited", so no run was ever queued for this SHA. This empty commit fires
a real "synchronize" event to get CI running.
@github-actions github-actions Bot added risk:R2 PR risk grade (advisory shadow check; grader-owned) and removed risk:R3 PR risk grade (advisory shadow check; grader-owned) labels Aug 21, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the retarget since I prompted it. The rebase onto #15405 is correct and the verification you did before acting on my comment — checking that useViewportCulling.ts and Comfy.VueNodes.ViewportCulling still exist on #15030's branch, to confirm the deletion was specific to the replacement rather than upstream of both — is exactly the right check. Setting id, throttle constant and settle logic all match #15405 at 554cd8c2a8.

Two issues with the assertions, both the same root cause: the benchmark never actually compares.

Structurally this is instrumentation rather than a test — which is fine and probably intended, but the two expects read as though they guard the comparison, and they don't. Worth either strengthening them or dropping the pretence and saying in the file header that this emits numbers for a human to read. My preference is the former, because #15409 means there is no baseline pipeline to catch drift across runs either, so these assertions are the only automated signal this PR has.

Not blocking — it's a draft and the direction is right.

…d-count bound

Address review from christian-byrne on PR #15372:
- Merge the two separate keep-alive-on/keep-alive-off tests into a single
  test that runs both sequences back to back, so the on/off relationship
  can actually be asserted instead of each run only checking its own
  numbers. Assert both that attached-node counts differ materially and
  that retention's CDP task-duration comes in below the no-retention
  baseline, with slack for CI noise.
- Replace the toBeLessThan(TOTAL_NODE_COUNT) attached-count check (passed
  even with only one node detached) with a viewport-derived
  TOTAL_NODE_COUNT * 0.8 bound that would actually fail if retention
  regressed to near-zero benefit.
@benjcooley
benjcooley force-pushed the benjcooley/vue-nodes-simple-keepalive branch 2 times, most recently from 52a8648 to be4d7da Compare September 4, 2026 00:00
…rt-culling-perf-benchmark

Resolves conflicts from the base branch's ongoing refactor:
- browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png:
  took the base branch's updated screenshot baseline
- src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts:
  took the base branch's version, which is a superset already containing this
  PR's two added tests under the renamed syncSlotOffsets mock

Also fixes two now-flagged unnecessary type assertions in
browser_tests/tests/vueNodes/viewportKeepAlive.spec.ts surfaced by the base
branch's newly added no-unnecessary-type-assertion oxlint rule.
@vercel

vercel Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comfy-home-v1 Error Error Oct 10, 2026 11:53pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 10, 2026 11:53pm UTC
billing-web-test Ignored Ignored Oct 10, 2026 11:53pm UTC

Request Review

@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

The "Vercel – comfy-home-v1" deployment check is failing on the latest commit (9c731c82), but this is not caused by this PR.

Verified it's a pre-existing, repo-wide issue: the same check fails identically on several other recent, unrelated open PRs, including a pure version-bump PR (#16557) that touches only a version string. Two of those failures show a generic account/team-access-flavored error rather than a build log, suggesting a broken Vercel project config or permissions issue on comfy-home-v1 (the apps/website project) rather than a code problem.

This PR's diff doesn't touch apps/website, any of its workspace package dependencies (packages/*), or any root/shared build config (tsconfig.json, pnpm-workspace.yaml, package.json, turbo.json, vite.config.mts, pnpm-lock.yaml) — confirmed via git diff origin/main...HEAD --stat against those paths, which is empty.

I don't have the means to fix or re-run this check (no Vercel project access). Flagging for whoever owns comfy-home-v1's Vercel config — this shouldn't block review of this PR's actual changes.


Generated by Claude Code

@claude claude Bot added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Updating Playwright Expectations

| snapshot | status | changed pixels |
| --- | --- | --- |
| `tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png` | modified | 21190B -> 25499B |
| `tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png` | modified | 103422B -> 104244B |

Screenshot capture is not bit-deterministic; small pixel
deltas are usually text rasterization noise. Confirm each
rewrite corresponds to a test expected to change.
@github-actions github-actions Bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 4, 2026
The automated screenshot-regen commit (8c296df) rewrote the baseline
for vue-node-muted-state-chromium-linux.png, but that baseline was not
actually stale — it passes on the base branch with its prior version.
The regenerated image doesn't match CI's render grouping and now fails
mute.spec.ts consistently across retries. Restoring the pre-regen
baseline; the settings-dialog screenshot fix from the same commit is
kept as-is.
// count", which a single detached node would also satisfy.
expect(on.attachedNodeCount).toBeLessThan(
on.totalNodeCount * MAX_ATTACHED_RATIO_WITH_KEEP_ALIVE
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NON-BLOCKING (new this round, not a regression from my last pass) — both retention checks are one-sided, so a total retention failure passes green.

useViewportKeepAlive.ts:111 bails out without populating activeNodeIds when the viewport has not been measured yet:

if (viewport.width <= 0 || viewport.height <= 0) return

In that state activeNodeIds is empty and zero nodes are attached — a blank canvas. Both guards in this variant are satisfied by zero:

  • the settle gate at L100-102, expect.poll(...).toBeLessThan(totalNodeCount) → 0 < 245 resolves on the first tick, so it stops being a settle gate at all and measurement can start against a partially-populated (or empty) set
  • this assertion, toBeLessThan(245 * 0.8) → 0 < 196 passes

So the failure mode where retention detaches everything is scored as the best possible result. That is the same shape as @christian-byrne's original finding on this line (an assertion green in exactly the case it should catch), just at the other end of the range.

Cheap fix — bound it on both sides:

Suggested change
)
expect(on.attachedNodeCount).toBeGreaterThan(0)
expect(on.attachedNodeCount).toBeLessThan(
on.totalNodeCount * MAX_ATTACHED_RATIO_WITH_KEEP_ALIVE
)

and give the L100-102 poll a lower bound too, so it actually waits for a populated set.

Separately, now that CI gives real numbers — 48/245 = 19.6% attached, stable across both repeats — the 0.8 ceiling has ~4x of slack. Retention could regress to 70% attached, losing most of the benefit, and still pass. Something like 0.4 would still be far from node-density-coupled while catching an actual regression. Your call; I know the coarseness was deliberate in the earlier round, but that was decided without measurements in hand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and fixed in fe5d7ee.

Verified the bug independently against useViewportKeepAlive.ts: when getViewportSize() returns width/height <= 0, refresh() returns at line 111 before touching activeNodeIds, so the set stays at its initial empty Set() — zero nodes attached. Both checks here were indeed one-sided upper bounds, so that zero-attached state would read as a pass on both.

Changes:

  • The settle-gate poll (L100-102) now has a companion expect.poll(() => comfyPage.vueNodes.nodes.count()).toBeGreaterThan(0) right after the existing toBeLessThan(totalNodeCount) poll, so it actually waits for a populated set rather than just "not the full count."
  • Added expect(on.attachedNodeCount).toBeGreaterThan(0) alongside the existing ratio assertion, so a total-retention failure fails loudly instead of passing as the best possible result.
  • Tightened MAX_ATTACHED_RATIO_WITH_KEEP_ALIVE from 0.8 to 0.4, per your point: real CI measured 48/245 (~19.6%) attached, stable across repeats, so 0.4 still clears that comfortably while cutting the slack roughly in half from where it was.

Generated by Claude Code

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — round 3 (scoped to 78c60d4..80b4f0d9)

Approving. All 10 findings from my last pass are genuinely fixed, and the difference that matters this round is that there are finally real CI numbers behind the claims instead of estimates. perf-tests is green at 11m41s and prints:

attached DOM elements task wall clock
keep-alive-on 48/245 4,512 4,470ms 6,307ms
keep-alive-off 245/245 21,409 20,576ms 22,262ms

Stable across both --repeat-each runs. That is a 4.7x DOM reduction and a 4.6x task-duration reduction — this benchmark now demonstrably measures the thing it is named after, which was exactly what was in doubt last round.

Verification notes

  • BLOCKER (observer double-count) — fixed by deletion rather than by patching. installPerfObservers/readPerfObservers are gone; everything is sourced from PerformanceHelper, which resets per measurement. The test split makes cross-variant bleed structurally impossible on top of that.
  • Mount gate — the off variant polls to the full count before measuring. Credit where due: 78c60d4 over-fixed this by gating both variants on waitForNodes(totalNodeCount), which cannot resolve when retention is on; real CI hung on it and cde5dcf1 corrected it. Catching that in CI rather than declaring it fixed is the behaviour I want to see.
  • Sweep amplitude — 48/245 attached is the proof that dx: 48, dy: 18 actually crosses viewport boundaries. Previously there was no evidence either way.
  • Timeouts — 90s/120s against measured 6.3s/22.3s. ~5x headroom, tight variance, whole perf job at 11m41s against a 30min budget. Correctly sized.
  • I also verified independently that the benchmark's load-bearing assumptions hold against the implementation: KeepAlive deactivation genuinely detaches (Vue moves the subtree to an off-document container, so the [data-node-id] locator stops seeing it), and nothing else in the codebase can detach nodes when the setting is off — vueNodeCullingService is an opt-out registry that can only force nodes to stay attached, and there is no separate ViewportCulling setting. The off variant's exact-equality assert is sound.

Two things before merge

  1. CI is red on Check for AI agent co-author trailers, and it is correct to be. 78c60d4306 and cde5dcf125 carry Co-Authored-By: Claude Sonnet 5 and Claude-Session: trailers, which AGENTS.md prohibits ("Never mention Claude/AI in commits"). Needs a history rewrite or a clean squash message. Not a code objection — but it is a red check, so flagging it as the actual merge blocker.
  2. One new non-blocking finding, left inline: both retention checks on the on variant are one-sided, so the degenerate case where retention detaches everything (viewport not yet measured → activeNodeIds empty) passes green and is scored as the best possible result. A toBeGreaterThan(0) on both the settle poll and the final assert closes it. Same shape as @christian-byrne's original finding, at the other end of the range.

Also noted inline, informational: recordMeasurement only persists the PerfMeasurement shape, so the field that reaches the perf-report JSON is domNodes — the delta, which measured Δ-1354 vs Δ-1487 and does not discriminate between variants. The 4,512-vs-21,409 number that carries the whole signal is console.log-only. Fine for a benchmark that explicitly is not a regression gate; worth knowing if it is ever wired into the baseline.

Neither of these needs another review round from me — fix the trailers, take or leave the bounds suggestion.

The keep-alive-on settle-gate poll and its attached-ratio assertion
only enforced an upper bound (attached < total / attached < ratio *
total). A total-retention failure in useViewportKeepAlive (e.g.
bailing out with zero active nodes before the viewport is measured)
would satisfy both checks, masking the regression.

- Add a lower-bound poll requiring a non-empty attached set before
  measurement starts.
- Add a lower-bound assertion (attachedNodeCount > 0) alongside the
  existing ratio assertion.
- Tighten MAX_ATTACHED_RATIO_WITH_KEEP_ALIVE from 0.8 to 0.4: CI runs
  on this PR measured 48/245 (~19.6%) attached with keep-alive on,
  stable across repeats, so 0.4 still comfortably clears the real
  ratio while catching a real regression much sooner than 0.8 would.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne force-pushed the test/viewport-culling-perf-benchmark branch from fe5d7ee to 1bc2562 Compare October 10, 2026 23:53
…g-perf-benchmark

Resolve conflicts by taking the base branch's versions of the files the
PR does not own, and drop the benchmark's afterEach resetView call, which
the base removed from CanvasHelper.
@github-actions github-actions Bot added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Oct 26, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 27, 2026
@christian-byrne
christian-byrne marked this pull request as ready for review October 27, 2026 07:04

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 8 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 3
⚪ Nit 3

Panel: 6/6 reviewers contributed findings.


// Let the trailing edge of the throttled refresh (and any pending
// attach/detach) settle before reading final numbers.
await comfyPage.idleFrames(KEEP_ALIVE_SETTLE_FRAMES)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — idleFrames(10) is a frame count, but the throttle it waits for (REFRESH_THROTTLE_MS = 100) is measured in time. At anything faster than 100Hz, ten frames finish before 100ms (about 83ms at 120Hz), so the trailing refresh can fire after stopMeasuring(). The attachedNodeCount asserted at line 191 is also read only once, so a late refresh makes that 40% check flaky. Wait for elapsed time, or expect.poll the attached count until it is stable, rather than guessing a number of frames.

Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case, gpt-5.6-sol-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: ten frames is a count and REFRESH_THROTTLE_MS is time, so a high-refresh runner could finish the wait before the trailing refresh fires. Fixed in 30224d1. idleFrames(10) is replaced by waitForAttachedNodeCountToStabilize(), which polls (15s bound) until the attached count is unchanged across a 200ms rAF-timed idle window, and attachedNodeCount is read after that. Not yet run in CI.


Generated by Claude Code

// force real attach/detach churn.
await comfyPage.canvasOps.panSweep({ steps: 20, dx: 48, dy: 18 })
for (let z = 0; z < 5; z++) {
await comfyPage.canvasOps.zoom(-100)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — canvasOps.zoom() dispatches its wheel events at pointer position (10, 10). In this spec that point sits under the pointer-active Topbar workflow-tabs overlay, so the zoom steps may never reach the canvas. performance.spec.ts already documents this problem with the helper. If so, both variants measure a pan-only workload while it is labeled pan+zoom. Move the pointer onto the canvas before zooming, or use the workaround from performance.spec.ts, and check that the canvas scale actually changes.

Raised by 1 of 6 reviewers (gpt-5.6-sol-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: canvasOps.zoom() moves the pointer to (10, 10), and performance.spec.ts ("zoom out idle") documents that this point sits over an overlay and left the scale unchanged. Fixed in 30224d1: after panSweep the pointer moves to the canvas centre and the wheel events go through page.mouse.wheel, and the sequence now polls canvasOps.getScale() to confirm the zoom-in phase raised the scale. Not yet run in CI.


Generated by Claude Code

// units, and the default 8/3 amplitude only traverses a few hundred
// units round trip — far too small to cross viewport boundaries and
// force real attach/detach churn.
await comfyPage.canvasOps.panSweep({ steps: 20, dx: 48, dy: 18 })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Sweep distance is steps * dx, not dx alone. panSweep({ steps: 20, dx: 48, dy: 18 }) peaks at about 19×48 = 912px, slightly less than the default panSweep() (about 119×8 = 952px). So the "6x the defaults" reasoning here and at lines 22-25 is wrong, and the sweep does not create the extra attach/detach churn it claims. Increase steps or the per-step delta so the sweep really crosses viewport boundaries, and correct the comments.

Raised by 2 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partly verified. The arithmetic is right: reach is (steps-1)*dx, so 19*48 = 912px against about 952px for the defaults, and the "6x the defaults" comment was wrong. I removed those comments in 30224d1 but did not change steps/dx/dy. Modelling the asset (245 nodes, scale 0.5, 1280x720, keep-alive margin 50%) gives 48 attached at the start, which matches the CI figure of 48/245. At the sweep peak it gives 22 attached, so about 26 of those 48 detach and re-attach on the way back. That is real churn, so I left the sweep alone rather than retune it blind.


Generated by Claude Code

// gate: it only resolves once retention has caught up.
await expect
.poll(() => comfyPage.vueNodes.nodes.count())
.toBeLessThan(totalNodeCount)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The comment calls this poll a settle gate that resolves only once retention has caught up. In fact toBeLessThan(totalNodeCount) passes on the first read where a single node has detached. Nodes without layout bounds start attached and are detached later by the throttled refresh, so that detach and KeepAlive deactivation work can still land inside the "on" measurement window. Poll until the attached count stops changing before calling startMeasuring().

Raised by 2 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: toBeLessThan(totalNodeCount) passes on the first read below the total, and nodes without bounds yet can still detach on later throttled refreshes. Fixed in 30224d1. The same stabilize poll now runs for both variants before startMeasuring(), after the existing checks, which are kept because they resolve with retention on. It is bounded (15s) and always resolves once the graph is idle, so it avoids the earlier hang. Not yet run in CI.


Generated by Claude Code

comfyPage.page.evaluate(() => document.getElementsByTagName('*').length)
])

recordMeasurement(cdpMetrics)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — recordMeasurement(cdpMetrics) saves the sample inside benchmarkViewportKeepAlive, before the caller checks the attached-node invariants. A run that fails an invariant, including a retried attempt, has therefore already written its sample to perf-temp, where it can be aggregated into the results or the baseline. Return the metrics and record them only after the invariants pass.

Raised by 1 of 6 reviewers (gpt-5.6-sol-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: recordMeasurement() ran before the caller's invariant checks. Fixed in 30224d1: the benchmark returns the measurement, and each test calls recordMeasurement() only after its attached-node assertions pass, so failed or retried attempts no longer write samples.


Generated by Claude Code

): Promise<number> {
return comfyPage.page.evaluate((name) => {
const entry = performance.getEntriesByName(name, 'measure').at(0)
return entry?.duration ?? 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — If the measure entry is missing (marks cleared, or the names drift), entry?.duration ?? 0 makes the benchmark log a plausible-looking "0ms wall clock" instead of failing. Throw or assert when entry is undefined.

Raised by 4 of 6 reviewers (claude-opus-5-5-xhigh adversarial, kimi-k3-high adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. In 30224d1 measureMarkDurationMs is gone and the wall-clock is read from the return value of performance.measure(...) in the same evaluate that creates it. A missing mark now throws instead of logging "0ms". Not yet run in CI.


Generated by Claude Code

const markEnd = `${label}-end`
const measureName = `${label}-pan-zoom`

await comfyPage.page.evaluate((name) => performance.mark(name), markStart)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — The start mark is set before perf.startMeasuring() and the end mark after perf.stopMeasuring(). The logged wall-clock time therefore includes harness overhead (CDP getMetrics round trips, rAF handshakes, longtask collection) as well as the pan/zoom interaction. Place the marks immediately around runPanZoomSequence and the settle wait.

Raised by 2 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. The start mark now follows startMeasuring(), and the end mark plus measure is taken after the settle wait and before stopMeasuring(), so the wall-clock excludes the CDP and rAF handshakes. Fixed in 30224d1; not yet run in CI.


Generated by Claude Code

])

recordMeasurement(cdpMetrics)
// frameDurationMs is intentionally excluded: PerformanceHelper samples it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — The stated reason for leaving out frameDurationMs appears to be wrong. PerformanceHelper.startMeasuring() starts the rAF sampling loop and stopMeasuring() stops it, so frame durations are sampled during the pan/zoom, not during idle. This drops the per-frame metric that would best separate the two variants; consider adding it to the logged keys.

Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: PerformanceHelper.startMeasuring() starts the rAF sampler and stopMeasuring() stops it, so frameDurationMs covers the interaction and the omission comment was wrong. Removed the comment and added frameDurationMs to the logged keys in 30224d1. Left p95FrameDurationMs out because perfReporter has no formatter for it and it would print as a raw float.


Generated by Claude Code

Zoom over the canvas instead of the topbar overlay and assert the scale
changes, wait for the attached node count to stabilize on elapsed time
before and after the pan/zoom sequence, bracket the wall-clock marks
inside the measuring window, derive the wall-clock from the measure
itself, log frameDurationMs, and record samples only after the
attached-node invariants pass.
@christian-byrne

Copy link
Copy Markdown
Contributor

@benjcooley — this needs one fresh approval at head 30224d1751, and then it can land. Your approval is at 80b4f0d909, and the PR has changed enough since that I don't think the old stamp should carry it.

The main reason is scope, not drift. What you approved was 20 files, +1329 lines — the keep-alive implementation, its unit tests and the setting. Your own branch has since absorbed those commits (everything up to 740211cd66 is now an ancestor of benjcooley/vue-nodes-simple-keepalive), so all of it has left this PR. What is left is one file, +209 lines: browser_tests/tests/vueNodes/viewportKeepAliveBenchmark.spec.ts. No production code at all.

One commit has touched that spec since your approval — 30224d1751, "tighten viewport keep-alive benchmark measurement". It reworks how the benchmark measures, which is why I'd rather you looked than assume it's covered. Every change tightens:

  • the retention bound goes from < 0.8 × total to < 0.4 × total;
  • both variants now also assert attachedNodeCount > 0, which closes exactly the one-sidedness you flagged as non-blocking at line 192 — a total retention failure no longer passes green;
  • the fixed 10-frame settle is replaced by polling until the attached-node count stops moving, before and after the pan/zoom sequence;
  • zoom is driven by real mouse.wheel events at the canvas centre instead of canvasOps.zoom(), and the sequence now asserts the scale actually rose — previously a zoom that silently did nothing still passed;
  • the measurement window is reordered so CDP capture starts before the performance.mark.

Two things worth your eye rather than mine. frameDurationMs is added back to the logged metrics; the version you approved excluded it on purpose, with a comment saying PerformanceHelper samples it after stopMeasuring(), so it reflects idle frame cadence rather than the interaction. It is log-only, with no assertion on it, but the reason it was excluded hasn't obviously gone away. And the afterEach that called resetView() is removed — harmless if each test still gets a fresh page, which is how the two variants are deliberately split, but it is a change.

The commit also deletes a large block of explanatory comments about why dx/dy are 6× the panSweep defaults and why the variants are split. The code those comments described is unchanged. That removal is also what the two remaining low-severity bot threads are pointing at — both quote comment text this commit deleted.

All 67 checks pass at 30224d1751, nothing failing and nothing pending.

I have deliberately not dismissed your approval. Dismissing it would re-expose your earlier changes-requested at bb178b4e13, and only you could retire that — so a dismissal would make this harder to land, not easier. A fresh review is the cheap path.

This branch had an error being deployed

1 failed (outdated) deployment
Preview – comfy-home-v1 — 80b4f0d9 Deployed Sep 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants