Repository navigation
[backport cloud/1.50] fix(billing): open the billing portal on OUTSTANDING_PAYMENT_REQUIRED - #15368
Conversation
…#15267) The subscribe API now returns a distinct `OUTSTANDING_PAYMENT_REQUIRED` code when an unpaid invoice blocks a plan change. Previously that case came back as the generic `TRANSITION_NOT_ALLOWED`, so the client had to guess whether it was a payment problem by making a second call to `getBillingStatus()` and checking for `payment_failed`. That probe is unreliable — `billing_status` is not populated for every billing configuration, and when it isn't, the user is shown a bare error message with no way to act on it. ```mermaid flowchart LR subgraph after ["after"] A2[OUTSTANDING_<br/>PAYMENT_REQUIRED] --> B2[open billing portal] C2[TRANSITION_NOT_ALLOWED] --> D2{"probe<br/>billing_status"} --> E2[portal, or plain error] end subgraph before ["before"] A1[unpaid invoice<br/>blocks plan change] --> B1[TRANSITION_NOT_ALLOWED] B1 --> C1{"probe<br/>billing_status"} C1 -->|populated| D1[open billing portal] C1 -->|not populated| E1[plain error,<br/>no action offered] end ``` ### Change `recoverOutstandingPayment` treats the new code as a direct trigger, short-circuiting before the probe runs. ### Deliberately additive Both existing paths are untouched: - The `SUBSCRIPTION_PAYMENT_REQUIRED` check stays — it is referenced across many existing tests. - The `TRANSITION_NOT_ALLOWED` + `getBillingStatus()` fallback stays — it works correctly wherever `billing_status` *is* populated, and it covers the window while the backend change rolls out. Removing it would fix one set of accounts by breaking another. ### Test One row added to the existing table test. It asserts the portal opens **and** that `getBillingStatus()` is called zero times — skipping that probe is the point of the new code, so the test pins it. Reverting the source change fails this test. `npx vitest run --coverage src/platform/workspace/composables/useSubscriptionCheckout.test.ts` → 102 passed. Run with `--coverage` to match CI, since coverage instrumentation catches mock-hoisting failures a plain run does not.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1804 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-17T16:47:15.064Z",
"gitSha": "b5c308c420643637a5c0e8ca23caaf06ff03be3b",
"branch": "backport-15267-to-cloud-1.50",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.3540000000219,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.288,
"heapDeltaBytes": 5804928,
"heapUsedBytes": 70298892,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.683000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.643999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.369,
"heapDeltaBytes": 5800192,
"heapUsedBytes": 70495276,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 23.148000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.8459999999984,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.585,
"layouts": 12,
"layoutDurationMs": 3.125,
"taskDurationMs": 811.673,
"heapDeltaBytes": 176072,
"heapUsedBytes": 64627148,
"domNodes": 56,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 116.80699999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.3600000000356,
"styleRecalcs": 76,
"styleRecalcDurationMs": 49.4,
"layouts": 12,
"layoutDurationMs": 3.9709999999999996,
"taskDurationMs": 965.3459999999999,
"heapDeltaBytes": -16134996,
"heapUsedBytes": 48478560,
"domNodes": -282,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 132.332,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.756000000018,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.598000000000003,
"layouts": 6,
"layoutDurationMs": 0.7010000000000002,
"taskDurationMs": 388.51199999999994,
"heapDeltaBytes": 8845672,
"heapUsedBytes": 73526656,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 21.054999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.9569999999421,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.206,
"layouts": 6,
"layoutDurationMs": 0.546,
"taskDurationMs": 395.92100000000005,
"heapDeltaBytes": 8580644,
"heapUsedBytes": 73323884,
"domNodes": 76,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 21.104,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 581.9840000000056,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.8119999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.759,
"heapDeltaBytes": -11004060,
"heapUsedBytes": 53615724,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 60.602000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 585.5949999999552,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.504999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.25600000000003,
"heapDeltaBytes": -11218888,
"heapUsedBytes": 53455688,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.66199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.2919999999935,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.43,
"heapDeltaBytes": 6723096,
"heapUsedBytes": 66736876,
"domNodes": -284,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 100.36600000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.3019999999924,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.982000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.251,
"heapDeltaBytes": 7171372,
"heapUsedBytes": 67040856,
"domNodes": -284,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 123.744,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2174.549000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.237999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.283,
"heapDeltaBytes": 4969344,
"heapUsedBytes": 66082728,
"domNodes": -287,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 436.76300000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2222.3089999999956,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1372.4569999999999,
"heapDeltaBytes": 19953716,
"heapUsedBytes": 80819060,
"domNodes": -282,
"jsHeapTotalBytes": 2916352,
"scriptDurationMs": 455.339,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3231.0679999999934,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.595000000000002,
"layouts": 60,
"layoutDurationMs": 7.4,
"taskDurationMs": 1504.238,
"heapDeltaBytes": 22216128,
"heapUsedBytes": 84644412,
"domNodes": 12,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 552.354,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3311.046000000033,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.265,
"layouts": 60,
"layoutDurationMs": 7.582,
"taskDurationMs": 1583.546,
"heapDeltaBytes": 2451644,
"heapUsedBytes": 65440200,
"domNodes": -287,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 547.3299999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.601999999969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.294,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.009,
"heapDeltaBytes": 6839248,
"heapUsedBytes": 67448124,
"domNodes": -281,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 116.861,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.0720000001038,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.022999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.293,
"heapDeltaBytes": 4650892,
"heapUsedBytes": 65635548,
"domNodes": -283,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 103.50999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.983000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.834,
"heapDeltaBytes": -10601812,
"heapUsedBytes": 54120760,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 119.883,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.0940000000164,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.397999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.832,
"heapDeltaBytes": -11083636,
"heapUsedBytes": 53930428,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 122.2,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1995.1069999999902,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.117999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.10400000000004,
"heapDeltaBytes": 5871376,
"heapUsedBytes": 70729312,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.693000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.7189999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.996,
"heapDeltaBytes": 5941672,
"heapUsedBytes": 70673824,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 16.262,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.8459999999604,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.690000000000005,
"layouts": 16,
"layoutDurationMs": 3.611,
"taskDurationMs": 733.8389999999999,
"heapDeltaBytes": -3201164,
"heapUsedBytes": 61334764,
"domNodes": 64,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 86.61,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9379999999655,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.21,
"layouts": 16,
"layoutDurationMs": 5.0200000000000005,
"taskDurationMs": 809.211,
"heapDeltaBytes": -3253148,
"heapUsedBytes": 61326084,
"domNodes": 63,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 98.829,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1950000000256,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.076000000000008,
"layouts": 13,
"layoutDurationMs": 13.247999999999996,
"taskDurationMs": 991.1130000000002,
"heapDeltaBytes": 31089264,
"heapUsedBytes": 98254248,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 38.675000000000004,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8281.678999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4489.2029999999995,
"heapDeltaBytes": 11059488,
"heapUsedBytes": 71597168,
"domNodes": -282,
"jsHeapTotalBytes": 6586368,
"scriptDurationMs": 1383.047,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8582.412000000091,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4789.288,
"heapDeltaBytes": 15372136,
"heapUsedBytes": 75833480,
"domNodes": -281,
"jsHeapTotalBytes": 6324224,
"scriptDurationMs": 1510.9669999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17149.749000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17122.54,
"heapDeltaBytes": -50132220,
"heapUsedBytes": 167772960,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 608.299,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16517.34799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16495.313000000002,
"heapDeltaBytes": -32412028,
"heapUsedBytes": 167541084,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 558.746,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20170.12399999999,
"styleRecalcs": 134,
"styleRecalcDurationMs": 15.361999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20119.22,
"heapDeltaBytes": -59089972,
"heapUsedBytes": 167276176,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 906.57,
"eventListeners": -16383,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19793.872999999963,
"styleRecalcs": 132,
"styleRecalcDurationMs": 14.472000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19750.870999999996,
"heapDeltaBytes": -44348852,
"heapUsedBytes": 169498420,
"domNodes": -8312,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 882.295,
"eventListeners": -16389,
"totalBlockingTimeMs": 72,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.28900000001704,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.079,
"layouts": 2,
"layoutDurationMs": 0.418,
"taskDurationMs": 113.818,
"heapDeltaBytes": 5074184,
"heapUsedBytes": 68907308,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.534999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 485.1770000000215,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.051,
"layouts": 4,
"layoutDurationMs": 1.713,
"taskDurationMs": 128.40400000000002,
"heapDeltaBytes": 5169744,
"heapUsedBytes": 68926612,
"domNodes": 145,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.898,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.50 #15368 +/- ##
=============================================
Coverage ? 81.34%
=============================================
Files ? 1872
Lines ? 106313
Branches ? 32780
=============================================
Hits ? 86478
Misses ? 19480
Partials ? 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15267 to
cloud/1.50Automatically created by backport workflow.