Repository navigation
[backport core/1.50] fix(billing): open the billing portal on OUTSTANDING_PAYMENT_REQUIRED - #15367
Conversation
…#15267) The subscribe API now returns a distinct `OUTSTANDING_PAYMENT_REQUIRED` code when an unpaid invoice blocks a plan change. Previously that case came back as the generic `TRANSITION_NOT_ALLOWED`, so the client had to guess whether it was a payment problem by making a second call to `getBillingStatus()` and checking for `payment_failed`. That probe is unreliable — `billing_status` is not populated for every billing configuration, and when it isn't, the user is shown a bare error message with no way to act on it. ```mermaid flowchart LR subgraph after ["after"] A2[OUTSTANDING_<br/>PAYMENT_REQUIRED] --> B2[open billing portal] C2[TRANSITION_NOT_ALLOWED] --> D2{"probe<br/>billing_status"} --> E2[portal, or plain error] end subgraph before ["before"] A1[unpaid invoice<br/>blocks plan change] --> B1[TRANSITION_NOT_ALLOWED] B1 --> C1{"probe<br/>billing_status"} C1 -->|populated| D1[open billing portal] C1 -->|not populated| E1[plain error,<br/>no action offered] end ``` ### Change `recoverOutstandingPayment` treats the new code as a direct trigger, short-circuiting before the probe runs. ### Deliberately additive Both existing paths are untouched: - The `SUBSCRIPTION_PAYMENT_REQUIRED` check stays — it is referenced across many existing tests. - The `TRANSITION_NOT_ALLOWED` + `getBillingStatus()` fallback stays — it works correctly wherever `billing_status` *is* populated, and it covers the window while the backend change rolls out. Removing it would fix one set of accounts by breaking another. ### Test One row added to the existing table test. It asserts the portal opens **and** that `getBillingStatus()` is called zero times — skipping that probe is the point of the new code, so the test pins it. Reverting the source change fails this test. `npx vitest run --coverage src/platform/workspace/composables/useSubscriptionCheckout.test.ts` → 102 passed. Run with `--coverage` to match CI, since coverage instrumentation catches mock-hoisting failures a plain run does not.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1800 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T16:46:30.334Z",
"gitSha": "f7f06ceb82702678fb7c11831deba97a6fba782f",
"branch": "backport-15267-to-core-1.50",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.0730000000162,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.387999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.78400000000005,
"heapDeltaBytes": 5847116,
"heapUsedBytes": 70176076,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 17.395,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.8499999999576,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.429,
"heapDeltaBytes": 5664156,
"heapUsedBytes": 69896868,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 16.264,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.5980000000031,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.205,
"layouts": 12,
"layoutDurationMs": 3.227,
"taskDurationMs": 907.737,
"heapDeltaBytes": -11984708,
"heapUsedBytes": 52410480,
"domNodes": -282,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 113.94400000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.4769999999835,
"styleRecalcs": 72,
"styleRecalcDurationMs": 27.220000000000002,
"layouts": 12,
"layoutDurationMs": 2.803,
"taskDurationMs": 681.0529999999999,
"heapDeltaBytes": -13863536,
"heapUsedBytes": 50311076,
"domNodes": -280,
"jsHeapTotalBytes": 24092672,
"scriptDurationMs": 92.062,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.1989999999923,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.18,
"layouts": 6,
"layoutDurationMs": 0.525,
"taskDurationMs": 295.017,
"heapDeltaBytes": 8139340,
"heapUsedBytes": 72662108,
"domNodes": 77,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 14.655000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3699999999553,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.912,
"layouts": 6,
"layoutDurationMs": 0.6849999999999998,
"taskDurationMs": 361.82399999999996,
"heapDeltaBytes": 8588660,
"heapUsedBytes": 72865276,
"domNodes": 77,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 23.552,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.0519999999888,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.049000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.432,
"heapDeltaBytes": -11228816,
"heapUsedBytes": 53239800,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 48.376000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 512.1029999999109,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.752999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.318,
"heapDeltaBytes": -11564224,
"heapUsedBytes": 52848444,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 45.402,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2028.4449999999765,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.825999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.516,
"heapDeltaBytes": 7979524,
"heapUsedBytes": 67852092,
"domNodes": -281,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 105.875,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.1390000000674,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.591,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.5559999999999,
"heapDeltaBytes": 7562084,
"heapUsedBytes": 69213064,
"domNodes": -280,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 91.69200000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2129.283999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.329999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1130.235,
"heapDeltaBytes": 24318176,
"heapUsedBytes": 84909896,
"domNodes": -284,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 357.854,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2083.313999999973,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1039.8299999999997,
"heapDeltaBytes": 497104,
"heapUsedBytes": 60859912,
"domNodes": -282,
"jsHeapTotalBytes": 5013504,
"scriptDurationMs": 334.731,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3186.314999999979,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.168999999999999,
"layouts": 60,
"layoutDurationMs": 7.789,
"taskDurationMs": 1336.196,
"heapDeltaBytes": 23441432,
"heapUsedBytes": 86059204,
"domNodes": 14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 469.6640000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3134.0920000000096,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.279,
"layouts": 60,
"layoutDurationMs": 7.164999999999999,
"taskDurationMs": 1257.517,
"heapDeltaBytes": -7904984,
"heapUsedBytes": 56405036,
"domNodes": -286,
"jsHeapTotalBytes": 5083136,
"scriptDurationMs": 431.9309999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.4429999999716,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.5920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.51,
"heapDeltaBytes": 6621864,
"heapUsedBytes": 67146064,
"domNodes": -283,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 97.97499999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.0000000000146,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.8569999999999,
"heapDeltaBytes": 6455976,
"heapUsedBytes": 66854736,
"domNodes": -282,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 108.516,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.5729999999844,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.577,
"heapDeltaBytes": -10974932,
"heapUsedBytes": 53572720,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 95.328,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 537.0589999999993,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.310000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.57699999999994,
"heapDeltaBytes": -10770860,
"heapUsedBytes": 53682116,
"domNodes": 24,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 102.769,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.453999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.576999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.96700000000004,
"heapDeltaBytes": -18552240,
"heapUsedBytes": 45889292,
"domNodes": 1,
"jsHeapTotalBytes": 21995520,
"scriptDurationMs": 16.056,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.429999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.702000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.99100000000004,
"heapDeltaBytes": 5708004,
"heapUsedBytes": 70148320,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 10.75,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.1539999999854,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.039,
"layouts": 16,
"layoutDurationMs": 5.15,
"taskDurationMs": 735.776,
"heapDeltaBytes": -18232048,
"heapUsedBytes": 46197136,
"domNodes": -1,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 91.89999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.6199999999762,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.32,
"layouts": 16,
"layoutDurationMs": 3.8310000000000004,
"taskDurationMs": 640.4329999999999,
"heapDeltaBytes": -3602916,
"heapUsedBytes": 60696248,
"domNodes": 61,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 80.031,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1034.9670000000515,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.357999999999997,
"layouts": 15,
"layoutDurationMs": 9.441,
"taskDurationMs": 748.2649999999998,
"heapDeltaBytes": 3687416,
"heapUsedBytes": 74817448,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 25.523999999999997,
"eventListeners": 2373,
"totalBlockingTimeMs": 100,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.378999999984,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3920.5860000000002,
"heapDeltaBytes": 4737012,
"heapUsedBytes": 64215120,
"domNodes": -280,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 1148.9680000000003,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8138.863000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3774.465,
"heapDeltaBytes": 8089520,
"heapUsedBytes": 67688244,
"domNodes": -283,
"jsHeapTotalBytes": 6848512,
"scriptDurationMs": 1115.0880000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14791.395999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14780.094000000001,
"heapDeltaBytes": -35358744,
"heapUsedBytes": 167808744,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 453.94900000000007,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14856.779000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14843.591999999999,
"heapDeltaBytes": -35215140,
"heapUsedBytes": 167853284,
"domNodes": -8312,
"jsHeapTotalBytes": -8589312,
"scriptDurationMs": 458.53899999999993,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16929.988000000038,
"styleRecalcs": 118,
"styleRecalcDurationMs": 13.759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16908.875000000004,
"heapDeltaBytes": -43073616,
"heapUsedBytes": 176810932,
"domNodes": -8312,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 682.255,
"eventListeners": -16385,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16934.318000000076,
"styleRecalcs": 115,
"styleRecalcDurationMs": 14.545000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16914.607,
"heapDeltaBytes": -41702520,
"heapUsedBytes": 164422828,
"domNodes": -8312,
"jsHeapTotalBytes": -9113600,
"scriptDurationMs": 712.487,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 443.4790000000248,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.058,
"layouts": 4,
"layoutDurationMs": 1.218,
"taskDurationMs": 104.57,
"heapDeltaBytes": 5056288,
"heapUsedBytes": 68314040,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.267,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 444.0799999999854,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.774999999999997,
"layouts": 3,
"layoutDurationMs": 0.6509999999999999,
"taskDurationMs": 88.04599999999999,
"heapDeltaBytes": 5063112,
"heapUsedBytes": 68555972,
"domNodes": 125,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.771999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.50 #15367 +/- ##
===========================================
Coverage 81.34% 81.34%
===========================================
Files 1872 1872
Lines 106288 106289 +1
Branches 32773 32304 -469
===========================================
+ Hits 86455 86456 +1
Misses 19478 19478
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15267 to
core/1.50Automatically created by backport workflow.