Repository navigation
fix(tour): frame the spotlit node clear of the workflow tabs - #15350
Conversation
The canvas runs the full height of the window, underneath the workflow tabs, but the first-run tour's camera fit reserved room only across the width — for the card column. A node tall enough to bind the height axis was therefore fitted to the whole viewport, so its title bar landed behind the tabs: the tour spotlighted a header nothing could click, and the only handle the node can be dragged by was unreachable. Reserve the top bar's depth at both ends of the height, mirroring what the fit already does with the card column, so the centred node clears the chrome.
🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.66 MB gzip 🟢 -888 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🔴 +458 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.8 kB) • 🟢 -287 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 117 kB) • 🟢 -2 kBReusable component library chunks
Status: 9 added / 9 removed / 6 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🔴 +78 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • 🟢 -1 BHelpers, composables, and utility bundles
Status: 26 added / 26 removed / 10 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • 🟢 -2.85 kBExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 16.3 MB (baseline 16.3 MB) • 🟢 -127 BBundles that do not match a named category
Status: 90 added / 90 removed / 204 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T08:38:26.793Z",
"gitSha": "e6830a04627f3988587c904a0ebee41712534b51",
"branch": "glary/tour-coachmark-chrome-occlusion",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.2920000000126,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.463,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.3409999999999,
"heapDeltaBytes": 3618728,
"heapUsedBytes": 66960284,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.565999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.7320000000154,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.652000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.7600000000001,
"heapDeltaBytes": 148192,
"heapUsedBytes": 69175484,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.358000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2081.413999999995,
"styleRecalcs": 79,
"styleRecalcDurationMs": 50.011,
"layouts": 14,
"layoutDurationMs": 5.297000000000001,
"taskDurationMs": 1034.737,
"heapDeltaBytes": -8278748,
"heapUsedBytes": 61917344,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 171.76999999999998,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.5279999999275,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.236999999999995,
"layouts": 14,
"layoutDurationMs": 5.032,
"taskDurationMs": 909.4019999999999,
"heapDeltaBytes": -7447968,
"heapUsedBytes": 62444216,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 149.533,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3289999999784,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.193,
"layouts": 6,
"layoutDurationMs": 1.1119999999999999,
"taskDurationMs": 357.55499999999995,
"heapDeltaBytes": 4355040,
"heapUsedBytes": 74281268,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.623000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.1729999999834,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.807,
"layouts": 6,
"layoutDurationMs": 1.0659999999999998,
"taskDurationMs": 356.188,
"heapDeltaBytes": 4461384,
"heapUsedBytes": 74209324,
"domNodes": 80,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.914,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 707.4410000000171,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.314,
"heapDeltaBytes": 18725052,
"heapUsedBytes": 87744148,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.356,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 702.1819999999934,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.067,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.96799999999996,
"heapDeltaBytes": 18047292,
"heapUsedBytes": 87923596,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.495,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.0409999999547,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.334,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.545,
"heapDeltaBytes": -13710988,
"heapUsedBytes": 86337636,
"domNodes": -273,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 36.849,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.2890000000243,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4810000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.009,
"heapDeltaBytes": -12787916,
"heapUsedBytes": 87152732,
"domNodes": -271,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 32.314,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2274.592000000041,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.941000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1659.1689999999999,
"heapDeltaBytes": 6473880,
"heapUsedBytes": 81059724,
"domNodes": -246,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 782.449,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2183.5239999999203,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.963000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.227,
"heapDeltaBytes": 21980896,
"heapUsedBytes": 87701660,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 751.625,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3500.940000000014,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.894,
"layouts": 60,
"layoutDurationMs": 13.109,
"taskDurationMs": 1668.1059999999998,
"heapDeltaBytes": 11767952,
"heapUsedBytes": 79514356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 756.9010000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3545.7959999999957,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.35,
"layouts": 60,
"layoutDurationMs": 13.116000000000003,
"taskDurationMs": 1693.553,
"heapDeltaBytes": 8159108,
"heapUsedBytes": 75746288,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.517,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3061.1509999999953,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.122999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1868.7769999999998,
"heapDeltaBytes": 20018580,
"heapUsedBytes": 86584792,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 926.307,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3155.856999999969,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.067000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1927.8280000000002,
"heapDeltaBytes": 26113304,
"heapUsedBytes": 93860396,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 967.9389999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2066.2940000000276,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.182999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.2950000000001,
"heapDeltaBytes": -14590760,
"heapUsedBytes": 87244460,
"domNodes": -271,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 38.309000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.1030000000346,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.369999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.2389999999999,
"heapDeltaBytes": -14727304,
"heapUsedBytes": 87483740,
"domNodes": -268,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.885000000000012,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.0079999999834,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.171999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.139,
"heapDeltaBytes": 13928580,
"heapUsedBytes": 85982408,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.50500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.1200000000181,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.198,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.338,
"heapDeltaBytes": 14248184,
"heapUsedBytes": 86420164,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.708,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.3959999999765,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.882000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.433,
"heapDeltaBytes": 3415496,
"heapUsedBytes": 75458144,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.505000000000003,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.1919999999518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.184000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.173,
"heapDeltaBytes": -10232384,
"heapUsedBytes": 61719340,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.858999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.1259999999652,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.636,
"layouts": 18,
"layoutDurationMs": 5.558000000000001,
"taskDurationMs": 813.6229999999999,
"heapDeltaBytes": 2323592,
"heapUsedBytes": 74375992,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.053,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.296000000033,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.759,
"layouts": 18,
"layoutDurationMs": 5.198,
"taskDurationMs": 823.4630000000001,
"heapDeltaBytes": 76532,
"heapUsedBytes": 72183932,
"domNodes": -297,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 104.697,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.2200000000194,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.365999999999993,
"layouts": 15,
"layoutDurationMs": 15.247000000000003,
"taskDurationMs": 977.841,
"heapDeltaBytes": 213008,
"heapUsedBytes": 97236236,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.348,
"eventListeners": 2381,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.076000000037,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.711999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5643.461,
"heapDeltaBytes": -14445280,
"heapUsedBytes": 85127040,
"domNodes": -269,
"jsHeapTotalBytes": -606208,
"scriptDurationMs": 2551.165,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8350.013999999988,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.748000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5674.413,
"heapDeltaBytes": -15683584,
"heapUsedBytes": 84457124,
"domNodes": -269,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2595.1649999999995,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18367.853000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17966.670000000002,
"heapDeltaBytes": -26588532,
"heapUsedBytes": 176367376,
"domNodes": -6548,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 314.594,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18041.774000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17495.934999999998,
"heapDeltaBytes": -35833856,
"heapUsedBytes": 174087620,
"domNodes": -6548,
"jsHeapTotalBytes": -4321280,
"scriptDurationMs": 367.847,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22890.214000000014,
"styleRecalcs": 169,
"styleRecalcDurationMs": 23.38299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22685.655,
"heapDeltaBytes": -25061292,
"heapUsedBytes": 184881532,
"domNodes": -6548,
"jsHeapTotalBytes": -5771264,
"scriptDurationMs": 965.859,
"eventListeners": -7469,
"totalBlockingTimeMs": 121,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21904.179,
"styleRecalcs": 163,
"styleRecalcDurationMs": 20.939000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21716.231,
"heapDeltaBytes": -26465092,
"heapUsedBytes": 176289588,
"domNodes": -6548,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 933.918,
"eventListeners": -7469,
"totalBlockingTimeMs": 256,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6621.116999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.15699999999998,
"layouts": 20,
"layoutDurationMs": 27.123999999999995,
"taskDurationMs": 6536.839000000001,
"heapDeltaBytes": -26218080,
"heapUsedBytes": 180174484,
"domNodes": -6548,
"jsHeapTotalBytes": 7573504,
"scriptDurationMs": 128.175,
"eventListeners": -7471,
"totalBlockingTimeMs": 501,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6433.310000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.30799999999999,
"layouts": 20,
"layoutDurationMs": 25.187,
"taskDurationMs": 6350.437,
"heapDeltaBytes": -25991104,
"heapUsedBytes": 176962800,
"domNodes": -6548,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 122.264,
"eventListeners": -7471,
"totalBlockingTimeMs": 510,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 477.07500000001346,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.833000000000002,
"layouts": 3,
"layoutDurationMs": 0.9529999999999998,
"taskDurationMs": 103.02000000000001,
"heapDeltaBytes": 5073808,
"heapUsedBytes": 72717472,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.546,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.09500000000116,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.12,
"layouts": 2,
"layoutDurationMs": 1.664,
"taskDurationMs": 83.45200000000001,
"heapDeltaBytes": 3116788,
"heapUsedBytes": 71152604,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.755,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughThe change updates first-run tour camera framing to reserve the top safe inset. It adds tests for constrained viewports and tall nodes. Browser tests verify spotlight placement before each tour step advances. ChangesFirst-run tour viewport safety
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change locally adjusts tour framing and adds safeguards for keeping the spotlight clear of workflow tabs. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15350 +/- ##
==========================================
+ Coverage 78.97% 82.98% +4.01%
==========================================
Files 2209 2059 -150
Lines 111780 118394 +6614
Branches 33649 35882 +2233
==========================================
+ Hits 88275 98253 +9978
+ Misses 23057 19785 -3272
+ Partials 448 356 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 937 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benjcooley
left a comment
There was a problem hiding this comment.
The production framing change is internally consistent: the bounds include the node title, LiteGraph centers those bounds, and the 40 px top-bar token safely clears the 38 px workflow tabs. The new unit regression passes at the exact head revision, and the affected cloud E2E cases passed CI without retries. Two E2E guard issues remain inline.
| BLOCKER | SHOULD FIX | TRIVIAL |
|---|---|---|
| 0 | 2 | 0 |
Verdict: non-blocking comment; production fix looks sound, but the browser assertion should prove the actual target and use a real readiness boundary.
## Summary Replace the timing-dependent spotlight reachability helper with a direct locator-based geometry assertion. ## Changes - **What**: Poll the spotlight and workflow-tab bounding boxes and assert they do not overlap. ## Review Focus Confirm the settled step text remains the correct readiness boundary for camera framing. Co-authored-by: Amp <amp@ampcode.com>
0b2caa5
benjcooley
left a comment
There was a problem hiding this comment.
Scoped re-review of commits after 61ff2e0a.
The replacement removes the arbitrary delay and page.evaluate, and it narrows the assertion to the actual tabs-overlap regression. I resolved that prior thread. One timing concern remains inline: later step text is visible during entering, before camera framing settles, so the geometry poll can pass on pre-flight coordinates. Please use a settled boundary or show this replacement still goes red when the production fix is reverted.
| BLOCKER | SHOULD FIX | TRIVIAL |
|---|---|---|
| 0 | 1 | 0 |
Verdict: still has a non-blocking test-validity concern; not approving this round.
Addresses review feedback: #15350 (comment)
benjcooley
left a comment
There was a problem hiding this comment.
Scoped re-review of a4ba563. The spotlight dialog now remains aria-busy until the tour state reaches showing, and the E2E waits on that settled-state boundary before asserting geometry. This addresses the previous timing race. The affected cloud tests passed without retries, and all PR checks are green.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
Summary
The first-run tour framed a tall node against the full canvas viewport, which runs underneath the workflow tabs — so the step spotlighted a node title bar the tabs were painted over, and the user could neither click nor drag it.
Changes
focusFillnow reserves the top bar's depth at both ends of the height axis, mirroring what it already does across the width for the card column. The fit centres the node, so an even reservation is what puts the node's top below the chrome.cameraFraming.test.ts: a tall node must leave at least the top bar's height free at each end.gettingStartedTour.spec.ts: at every spotlight step, the topmost element at the spotlight's top edge must not be inside.workflow-tabs-container— i.e. a pointer aimed at the spotlight reaches the target, not chrome.Review Focus
Evidence, on the pinned template
image_krea2_turbo_t2i(1280x720, cloud build, node 30):Before — the tour's own spotlight sits under the tabs bar:
After:
Both guards were verified red before the change and green after (the three tour-walk e2e tests fail with
a pointer aimed at the spotlight lands on this instead).Deliberately unchanged:
clampSpotlightRectstill clamps the hole to the viewport rather than to the chrome, so a target driven under the top bar by something other than the tour's own fit is still drawn there. The tour never pans on its own after framing, so this fix covers the path the tour controls.