Repository navigation
feat(settings): hoist the workspace header into the dialog bar - #15271
comfydesigner wants to merge 4 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ffdc1-4c9f-7326-b121-80041ba8a10d Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ❌ 1798 passed, 8 failed · 2 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-14T21:23:16.911Z",
"gitSha": "ed1b7f54ea43aedaaf2d0506ac5e69a575a26827",
"branch": "comfydesigner/settings-header-polish",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.1000000000097,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.458,
"heapDeltaBytes": 4861596,
"heapUsedBytes": 69490908,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 9.935999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.3119999999763,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.16,
"heapDeltaBytes": 4914460,
"heapUsedBytes": 69431780,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 9.221999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2051.6360000000022,
"styleRecalcs": 80,
"styleRecalcDurationMs": 54.400000000000006,
"layouts": 12,
"layoutDurationMs": 4.1,
"taskDurationMs": 1022.913,
"heapDeltaBytes": -565980,
"heapUsedBytes": 63510864,
"domNodes": 64,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 122.812,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.2609999999804,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.931,
"layouts": 12,
"layoutDurationMs": 3.5909999999999997,
"taskDurationMs": 934.544,
"heapDeltaBytes": -690724,
"heapUsedBytes": 63735208,
"domNodes": 61,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 118.161,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.459999999956,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.467000000000002,
"layouts": 6,
"layoutDurationMs": 0.699,
"taskDurationMs": 405.1,
"heapDeltaBytes": 8045252,
"heapUsedBytes": 72561484,
"domNodes": 75,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 12.058,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.773000000071,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.117,
"layouts": 6,
"layoutDurationMs": 0.6510000000000001,
"taskDurationMs": 418.30999999999995,
"heapDeltaBytes": 8074796,
"heapUsedBytes": 72626032,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.217999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.5459999999898,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.155000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.527,
"heapDeltaBytes": -11302324,
"heapUsedBytes": 53303736,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 58.571999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.8049999999484,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.59299999999996,
"heapDeltaBytes": -11274192,
"heapUsedBytes": 53219728,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 59.720000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2038.0700000000047,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.6659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.746,
"heapDeltaBytes": 10932196,
"heapUsedBytes": 71279988,
"domNodes": -284,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 17.503999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.0329999999412,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.591,
"heapDeltaBytes": 12492336,
"heapUsedBytes": 71963396,
"domNodes": -281,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 16.692999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2159.766999999988,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.006999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1262.412,
"heapDeltaBytes": 10437396,
"heapUsedBytes": 71258196,
"domNodes": -285,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 313.368,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2199.4079999999485,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.582999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1272.066,
"heapDeltaBytes": 10018468,
"heapUsedBytes": 70845384,
"domNodes": -284,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 323.169,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3165.9460000000195,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.236,
"layouts": 60,
"layoutDurationMs": 8.715,
"taskDurationMs": 1420.684,
"heapDeltaBytes": 16911260,
"heapUsedBytes": 79131496,
"domNodes": 10,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 395.48,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3230.4280000000745,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.181000000000004,
"layouts": 60,
"layoutDurationMs": 8.790000000000001,
"taskDurationMs": 1494.5400000000002,
"heapDeltaBytes": -1974592,
"heapUsedBytes": 59707036,
"domNodes": -290,
"jsHeapTotalBytes": 4292608,
"scriptDurationMs": 405.277,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.2150000000174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.593999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.5869999999999,
"heapDeltaBytes": 12901152,
"heapUsedBytes": 73871200,
"domNodes": -286,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 17.163999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.810000000054,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.7010000000001,
"heapDeltaBytes": 11991388,
"heapUsedBytes": 73471448,
"domNodes": -286,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 16.551999999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 649.7539999999731,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.23900000000003,
"heapDeltaBytes": -10788296,
"heapUsedBytes": 53898736,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 133.905,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.5089999999609,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.7,
"heapDeltaBytes": -10518124,
"heapUsedBytes": 54255744,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 120.72099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.3860000000109,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.1600000000001,
"heapDeltaBytes": 5067720,
"heapUsedBytes": 69669340,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 8.409,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2035.1399999999558,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.68,
"heapDeltaBytes": 5195380,
"heapUsedBytes": 70086144,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 9.084999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.3449999999953,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.937000000000005,
"layouts": 16,
"layoutDurationMs": 4.949999999999999,
"taskDurationMs": 810.014,
"heapDeltaBytes": -3692952,
"heapUsedBytes": 60921252,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 89.118,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.4609999999138,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.919,
"layouts": 16,
"layoutDurationMs": 4.7090000000000005,
"taskDurationMs": 810.592,
"heapDeltaBytes": -4366516,
"heapUsedBytes": 60365036,
"domNodes": 60,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 91.086,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.02899999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.759999999999994,
"layouts": 15,
"layoutDurationMs": 12.151000000000002,
"taskDurationMs": 1022.6170000000001,
"heapDeltaBytes": -9720636,
"heapUsedBytes": 78311936,
"domNodes": 13673,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 19.774999999999995,
"eventListeners": 2375,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8405.576000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.147000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4536.965999999999,
"heapDeltaBytes": 13795640,
"heapUsedBytes": 73840364,
"domNodes": -285,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1023.9200000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8378.828999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.19000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4420.526,
"heapDeltaBytes": 15550268,
"heapUsedBytes": 75978624,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 989.5229999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18772.79699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17722.558,
"heapDeltaBytes": -27120844,
"heapUsedBytes": 170058820,
"domNodes": -8312,
"jsHeapTotalBytes": -13312000,
"scriptDurationMs": 132.388,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18616.128000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17688.52,
"heapDeltaBytes": -40118072,
"heapUsedBytes": 157285700,
"domNodes": -8312,
"jsHeapTotalBytes": -5967872,
"scriptDurationMs": 132.38099999999997,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22913.208999999995,
"styleRecalcs": 180,
"styleRecalcDurationMs": 24.020000000000042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22155.706000000002,
"heapDeltaBytes": -33605696,
"heapUsedBytes": 164041728,
"domNodes": -8322,
"jsHeapTotalBytes": -12001280,
"scriptDurationMs": 421.862,
"eventListeners": -16383,
"totalBlockingTimeMs": 179,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22588.448999999968,
"styleRecalcs": 172,
"styleRecalcDurationMs": 25.090999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21988.406000000003,
"heapDeltaBytes": -46979708,
"heapUsedBytes": 163741488,
"domNodes": -8312,
"jsHeapTotalBytes": -12001280,
"scriptDurationMs": 443.04999999999995,
"eventListeners": -16383,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.6510000000135,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.342999999999996,
"layouts": 3,
"layoutDurationMs": 1.452,
"taskDurationMs": 121.92199999999998,
"heapDeltaBytes": 5068536,
"heapUsedBytes": 68729304,
"domNodes": 150,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.737000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.2750000000333,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.314999999999998,
"layouts": 3,
"layoutDurationMs": 0.5519999999999999,
"taskDurationMs": 107.322,
"heapDeltaBytes": 4921336,
"heapUsedBytes": 68701736,
"domNodes": 121,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.863000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## dante/fe-1609-align-settings #15271 +/- ##
================================================================
- Coverage 80.98% 80.98% -0.01%
================================================================
Files 1884 1884
Lines 112047 112054 +7
Branches 31832 32311 +479
================================================================
+ Hits 90743 90744 +1
- Misses 20921 20927 +6
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Superseded by #16438, which does the same header hoist plus collapse-on-scroll on a branch built from current main. Closing in favour of that. |
…omfy-Org#18319) **Final shape per the Slack agreement (2026-09-23):** stacked on Comfy-Org#18328 (headerPadding prop). The dead `contentScroll` emit is deleted — collapse runs entirely through a capture-phase listener on the settings content wrapper, replacing the per-panel wiring that silently broke when a panel swapped its scroller. Comfy-Org#15235 and Comfy-Org#18329 are closed as absorbed/unnecessary; this PR is the single vehicle for the members-table + header work. Still to fix before review completes (from dante01yoon's pass): fallow template-complexity finding on SettingDialog, mobile-chrome playwright failure, and the two CodeRabbit findings (paginated member total; allSettled swallowing fetch errors). --- Clean restart of Comfy-Org#16438 — same tree, squashed to one commit off current main. That PR accumulated three merge commits and a stale merge-base that made GitHub render a 5k-file diff; the actual change is 28 files. All review history lives on Comfy-Org#16438: Jaewon's early rounds (addressed), CodeRabbit's rounds (addressed), and CodeJuggernaut's padding-seam finding — resolved here as `content-padding` per category (workspace categories 'none' with the hoisted wrapper supplying gutters; every other category keeps the layout default). ## Summary Reclaims the settings dialog's vertical space for workspace panels: the workspace header moves into the dialog's own header bar, and once a panel scrolls it gives way so the panel's controls take that row. Supersedes Comfy-Org#15271, which was stacked on the since-merged Comfy-Org#15239 and could not be rebased cleanly. Based on Comfy-Org#15235 — the scroll-away teleports the controls row that PR introduces. ## Changes - **Header hoist**: the workspace avatar and name move onto the close-button row; `WorkspaceSettingsPanelContent` drops its duplicate header. Recovers ~200px on every workspace section. Matches [Figma 4157-27354](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Team-Plan---Workspaces?node-id=4157-27354). - **`headerPadding` prop** on `BaseModalLayout`, defaulting to today's `h-18 px-6`. Settings opts into `symmetric`, which makes the close button's top gap equal its right gap. - **Scroll-away**: `useSettingsHeaderCollapse` — panels report their scroller's `scrollTop`; past 24px the avatar and name give way, restoring below 4px (a deadband — collapsing changes the scroller’s own overflow, so a single threshold oscillates) and the controls row is teleported into the header beside the close button. Tabs on Plan & Credits; tabs, search and Invite on Members, all left of the close button. - **Breaking**: none. ## Review Focus **The padding is opt-in for a reason.** Applied unconditionally it cost the other five full-size modals — ComfyHubPublishDialog, AssetBrowserModal, SampleModelSelector, WorkflowTemplateSelectorDialog, ManagerDialog — 20px of header height (72px → 92px, measured at 1440×900) for no benefit, since none has a duplicate header to remove. `BaseModalLayout.stories.ts` exposes the prop so both variants are inspectable. **Why panels report scroll instead of the dialog owning it.** An earlier attempt hoisted scrolling to the dialog and overlaid the close button. That undid Comfy-Org#15235's bounded members table, drew a frame around a table whose header had detached, and floated the close button over unrelated settings pages. Reacting to each panel's existing scroller leaves those alone, and the teleport target only exists inside `isWorkspaceCategoryActive`, so no other category can see the behaviour. `Teleport` moves the controls rather than rendering a second copy, so tab state, search text and the invite handler are preserved across the transition. **Not yet done**: no transition on the swap — it is instant rather than animated. ## Screenshots <img width="1278" height="783" alt="image" src="https://github.com/user-attachments/assets/a12cc08d-aabf-46a8-b759-e9d684df453e" /> <img width="1512" height="620" alt="image" src="https://github.com/user-attachments/assets/46b9d187-2abd-4e41-870c-4b9c52d6490f" /> <img width="1512" height="982" alt="image" src="https://github.com/user-attachments/assets/1c0fdf0c-1f25-40b5-8dae-129b2d7e1dcf" /> --------- Co-authored-by: github-actions <github-actions@github.com>
Behavior: the workspace's avatar and name sit in the settings dialog's own header bar, on the close-button row — no duplicate in-panel header, no wasted space above the tabs. Behavioral source of truth for local V1: the Plan & Credits decision log.
Stacked on #15239. Matches the settings dialog header to the design of record (4157-27354): the workspace avatar + name move up into the dialog's header bar, on the same row as the close button, and the panel's own large header is removed — recovering ~200px of content space on every workspace section.
SettingDialogrenders the workspace header in the#headerslot for workspace categories (same per-panel mechanism keybinding already uses);WorkspaceSettingsPanelContentdrops its duplicate header.BaseModalLayout: the header bar goes from fixedh-18to symmetricp-6with amin-h-11content line — the close button's top gap now equals its right gap, and the bar height no longer shifts between panels with and without header content. Note: this applies to every full-size modal's header, not just settings.Settings opts out of the shell's content padding and owns
px-6itself, removing the permanent 40px dead band under self-scrolling panels. Note: all settings panels now end flush at the dialog edge; terminal footers carry their own bottom padding.Verified: unit tests; live passes on cloud (testcloud) and local dev builds across Plan & Credits / Members / User tab switches.