Repository navigation
Conversation
Regenerated @comfyorg/ingest-types from the current cloud ingest spec, via the same pipeline as the post-merge automation: openapi-project -fe (strips x-internal / M2M surface) then pnpm generate, plus oxfmt. The governance change is documentation only. Comfy-Org/cloud#6312 adds node_errors to the /api/prompt 403 body, but PromptErrorResponse is an open object (additionalProperties: true), so only the 403's description moves -- no type or schema change. The rest is drift the package had accumulated against merged cloud specs, all additive and optional: - previewable_outputs_count on JobEntry / JobDetailResponse - tags_all / tags_any / tags_none on /api/assets and the tag histogram, with include_tags / exclude_tags now marked deprecated aliases - pending_billing_op_type on BillingStatusResponse - include_revoked on the workspace API keys list - reworded cancel_at and SCA/3DS descriptions Verified: pnpm typecheck, lint, format:check all clean; app / executionErrorUtil / errorCatalog suites pass (169 tests).
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1800 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 8.71 MB gzip 🟢 -17 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🟢 -102 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 284 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T16:36:24.246Z",
"gitSha": "a8f336a343d698e4b27705bd12cfde7b77a0bc93",
"branch": "glary/update-ingest-types-governance-403",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.8949999999918,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.247,
"heapDeltaBytes": 5889640,
"heapUsedBytes": 70218296,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 24.053000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.980000000046,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.870000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.0350000000001,
"heapDeltaBytes": 5880256,
"heapUsedBytes": 70345532,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.154,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1931.7589999999996,
"styleRecalcs": 77,
"styleRecalcDurationMs": 43.291000000000004,
"layouts": 12,
"layoutDurationMs": 4.0089999999999995,
"taskDurationMs": 967.9110000000001,
"heapDeltaBytes": 269248,
"heapUsedBytes": 64644512,
"domNodes": 60,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 138.36599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1895.3849999999193,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.32900000000001,
"layouts": 12,
"layoutDurationMs": 3.604,
"taskDurationMs": 963.816,
"heapDeltaBytes": -13077164,
"heapUsedBytes": 51574772,
"domNodes": -279,
"jsHeapTotalBytes": 24879104,
"scriptDurationMs": 132.281,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.4859999999903,
"styleRecalcs": 33,
"styleRecalcDurationMs": 22.621000000000002,
"layouts": 6,
"layoutDurationMs": 0.6980000000000001,
"taskDurationMs": 498.68600000000004,
"heapDeltaBytes": 8783376,
"heapUsedBytes": 73297432,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 30.311,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.5299999999452,
"styleRecalcs": 33,
"styleRecalcDurationMs": 20.034,
"layouts": 6,
"layoutDurationMs": 0.6309999999999998,
"taskDurationMs": 449.252,
"heapDeltaBytes": 8743952,
"heapUsedBytes": 73323896,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 27.963,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 759.5699999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.916,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.2620000000001,
"heapDeltaBytes": -10956536,
"heapUsedBytes": 53629404,
"domNodes": 16,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 74.268,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 619.9740000000702,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.407,
"heapDeltaBytes": -10895012,
"heapUsedBytes": 53255928,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 63.01,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2061.279000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.8299999999999,
"heapDeltaBytes": 7093544,
"heapUsedBytes": 66680792,
"domNodes": -284,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 134.03600000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2047.6690000000417,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.612000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.297,
"heapDeltaBytes": 7602504,
"heapUsedBytes": 67715484,
"domNodes": -282,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 129.07399999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2455.8679999999526,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.164000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1508.372,
"heapDeltaBytes": -5518228,
"heapUsedBytes": 55891540,
"domNodes": -288,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 509.82800000000003,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2368.067999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1420.404,
"heapDeltaBytes": 7533992,
"heapUsedBytes": 68367352,
"domNodes": -286,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 471.22400000000005,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3565.1299999999537,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.399000000000003,
"layouts": 60,
"layoutDurationMs": 7.918000000000001,
"taskDurationMs": 1794.5760000000002,
"heapDeltaBytes": 15200488,
"heapUsedBytes": 77472324,
"domNodes": -290,
"jsHeapTotalBytes": 5083136,
"scriptDurationMs": 636.6089999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3363.96400000001,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.528999999999998,
"layouts": 60,
"layoutDurationMs": 8.093,
"taskDurationMs": 1681.7269999999999,
"heapDeltaBytes": 6486400,
"heapUsedBytes": 68785824,
"domNodes": -290,
"jsHeapTotalBytes": 6918144,
"scriptDurationMs": 587.1560000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.3729999999646,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 862.583,
"heapDeltaBytes": 6898788,
"heapUsedBytes": 67598644,
"domNodes": -282,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 135.456,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.7319999999863,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.389,
"heapDeltaBytes": 5336776,
"heapUsedBytes": 65928236,
"domNodes": -285,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 127.5,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 655.7260000000156,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.585999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.79599999999994,
"heapDeltaBytes": -10771152,
"heapUsedBytes": 53937616,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 123.41000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.9479999999094,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.253000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.168,
"heapDeltaBytes": -10681664,
"heapUsedBytes": 53905516,
"domNodes": 22,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 126.35,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.9399999999678,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.299,
"heapDeltaBytes": 6002320,
"heapUsedBytes": 70585916,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 25.954,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.0019999999577,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.2149999999999,
"heapDeltaBytes": -18377096,
"heapUsedBytes": 46200552,
"domNodes": 3,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 22.173,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3150000000137,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.37,
"layouts": 16,
"layoutDurationMs": 5.233,
"taskDurationMs": 894.5419999999999,
"heapDeltaBytes": -3302960,
"heapUsedBytes": 61464288,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 105.104,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.9369999999626,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.158,
"layouts": 16,
"layoutDurationMs": 4.7139999999999995,
"taskDurationMs": 841.73,
"heapDeltaBytes": -3488376,
"heapUsedBytes": 61203340,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 101.13,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.44200000008,
"styleRecalcs": 18,
"styleRecalcDurationMs": 37.038000000000004,
"layouts": 14,
"layoutDurationMs": 16.267,
"taskDurationMs": 1046.774,
"heapDeltaBytes": 31032652,
"heapUsedBytes": 99060020,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 41.69299999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9230.794000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.596000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5361.681,
"heapDeltaBytes": -4913064,
"heapUsedBytes": 76959376,
"domNodes": -264,
"jsHeapTotalBytes": 6430720,
"scriptDurationMs": 1679.132,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9035.345000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.285000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5084.942,
"heapDeltaBytes": 14944268,
"heapUsedBytes": 74531968,
"domNodes": -280,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1537.16,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18018.079999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17971.544,
"heapDeltaBytes": -35046968,
"heapUsedBytes": 167257464,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 612.6750000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17847.997000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17817.698,
"heapDeltaBytes": -39130576,
"heapUsedBytes": 165884316,
"domNodes": -8312,
"jsHeapTotalBytes": -13762560,
"scriptDurationMs": 637.0100000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21651.350999999977,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.752999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21604.112,
"heapDeltaBytes": -48916468,
"heapUsedBytes": 156546268,
"domNodes": -8316,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 969.0750000000002,
"eventListeners": -16385,
"totalBlockingTimeMs": 384,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21806.204999999976,
"styleRecalcs": 151,
"styleRecalcDurationMs": 21.106999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21763.588,
"heapDeltaBytes": -41587188,
"heapUsedBytes": 164587512,
"domNodes": -8316,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 985.2700000000001,
"eventListeners": -16379,
"totalBlockingTimeMs": 345,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 468.4949999999617,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.400999999999996,
"layouts": 3,
"layoutDurationMs": 0.6509999999999999,
"taskDurationMs": 121.415,
"heapDeltaBytes": 5074852,
"heapUsedBytes": 68472828,
"domNodes": 124,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.616999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 468.7650000000758,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.034,
"layouts": 4,
"layoutDurationMs": 1.722,
"taskDurationMs": 129.798,
"heapDeltaBytes": 5161672,
"heapUsedBytes": 68714220,
"domNodes": 143,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.201,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGenerated ingest API types and Zod schemas add previewable output counts, billing operation metadata, asset tag filters, and revoked-key filtering. They also update billing, cancellation, and provider-governance documentation. ChangesIngest API contract updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌐 Website E2ETip All tests passed.
|
|
No changes pushed — this is CodeRabbit's "review in progress" placeholder, so there are no findings to act on yet. Flagging two things for whoever picks up the real pass. Declining both Finishing Touches offers, deliberately:
For the line-by-line pass: there is no hand-written code here. Every line is Substantively this PR is one JSDoc line (the |
|
Thanks for the approval. The comment bodies didn't reach me — I received the approval event with no comment text or IDs attached. That's the second time in this stack (same thing happened with @synap5e's approval on cloud#6312), and I have no GitHub API access to go read them myself. So I've changed nothing rather than guess or treat the approval as "nothing to do". If anything in there needs action, please re-post it and I'll pick it up. One thing I can say without seeing them: if the comments point at anything in the diff itself, the fix almost certainly isn't in this repo. Both files are generated ( State of what was approved: PR head Both PRs in this pair are now approved and both are still drafts, so neither can merge:
I don't have the ability to flip draft status. Could someone mark them ready, or say if they should stay draft pending something? The only other open item I'm aware of is that |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15143 +/- ##
==========================================
- Coverage 79.73% 79.69% -0.04%
==========================================
Files 1804 1880 +76
Lines 125725 132569 +6844
Branches 38065 41348 +3283
==========================================
+ Hits 100241 105652 +5411
- Misses 24807 26178 +1371
- Partials 677 739 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 545 files with indirect coverage changes 🚀 New features to boost your workflow:
|
PR Created by the Glary-Bot Agent
Requested by @synap5e on Comfy-Org/cloud#6312 ("update ingest types").
Regenerated
@comfyorg/ingest-typesfrom the current cloud ingest spec using the same pipeline as the post-merge automation (push-ingest-types-to-frontend.yml):openapi-project -feto strip cloud'sx-internal/ M2M surface, thenpnpm generate, then oxfmt.The governance change is documentation only
cloud#6312 adds
node_errorsto the/api/prompt403 body so a partner-provider policy denial routes to the Errors panel instead of the legacy "Access Restricted" modal. ButPromptErrorResponseis an open object (additionalProperties: true), so the only generated change is the 403's description:No type or schema change, and nothing in
src/needs to change — the consuming code (app.ts,executionErrorUtil.ts, thePARTNER_NODE_DISABLEDcatalog entry) already handles this shape.The rest is accumulated drift
The package had fallen behind several merged cloud specs. All additive and optional:
previewable_outputs_countonJobEntry/JobDetailResponsetags_all/tags_any/tags_noneon/api/assetsand the tag histogram;include_tags/exclude_tagsnow carry@deprecatedas permanent aliasespending_billing_op_type('subscription' | 'topup') onBillingStatusResponseinclude_revokedon the workspace API keys list querycancel_at(delinquent Stripe cancellation) and SCA/3DS descriptionsI included these rather than hand-editing a generated file down to just my one line — a partial regen would leave the package inconsistent with its own spec, and this is the same output the automation produces.
Verification
pnpm typecheck,pnpm lint,pnpm format:checkall exit 0.app.test.ts,executionErrorUtil.test.tsand theerrorCatalogsuite pass (169 tests). Pre-commit hooks (oxfmt / oxlint / eslint / typecheck) ran clean on both files.Note on ordering
This can merge before or after cloud#6312 — the change is a doc comment on an open object, so it's inert either way.
Worth flagging separately: the drift above suggests
push-ingest-types-to-frontend.ymlhasn't been landing its chore PRs. Also, a plainpnpm generatein this package produces ~11k lines of formatting churn because the workflow commits raw generator output withHUSKY: '0'while the committed files are oxfmt-formatted; running oxfmt afterwards collapses it. Might be worth adding the format step to the workflow.