Skip to content

chore: update Ingest API types from cloud - #15143

Closed
huang47 wants to merge 1 commit into
mainfrom
glary/update-ingest-types-governance-403
Closed

huang47 wants to merge 1 commit into
mainfrom
glary/update-ingest-types-governance-403

Conversation

@huang47

@huang47 huang47 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Requested by @synap5e on Comfy-Org/cloud#6312 ("update ingest types").

Regenerated @comfyorg/ingest-types from the current cloud ingest spec using the same pipeline as the post-merge automation (push-ingest-types-to-frontend.yml): openapi-project -fe to strip cloud's x-internal / M2M surface, then pnpm generate, then oxfmt.

The governance change is documentation only

cloud#6312 adds node_errors to the /api/prompt 403 body so a partner-provider policy denial routes to the Errors panel instead of the legacy "Access Restricted" modal. But PromptErrorResponse is an open object (additionalProperties: true), so the only generated change is the 403's description:

-  * ... (error.type PARTNER_NODE_DISABLED; error.class_types lists the offending nodes, error.providers the disabled providers)
+  * ... (error.type PARTNER_NODE_DISABLED; node_errors identifies each denied prompt node, capped at 100 occurrences; error.class_types and error.providers summarize the denied node types and providers)

No type or schema change, and nothing in src/ needs to change — the consuming code (app.ts, executionErrorUtil.ts, the PARTNER_NODE_DISABLED catalog entry) already handles this shape.

The rest is accumulated drift

The package had fallen behind several merged cloud specs. All additive and optional:

  • previewable_outputs_count on JobEntry / JobDetailResponse
  • tags_all / tags_any / tags_none on /api/assets and the tag histogram; include_tags / exclude_tags now carry @deprecated as permanent aliases
  • pending_billing_op_type ('subscription' | 'topup') on BillingStatusResponse
  • include_revoked on the workspace API keys list query
  • reworded cancel_at (delinquent Stripe cancellation) and SCA/3DS descriptions

I included these rather than hand-editing a generated file down to just my one line — a partial regen would leave the package inconsistent with its own spec, and this is the same output the automation produces.

Verification

pnpm typecheck, pnpm lint, pnpm format:check all exit 0. app.test.ts, executionErrorUtil.test.ts and the errorCatalog suite pass (169 tests). Pre-commit hooks (oxfmt / oxlint / eslint / typecheck) ran clean on both files.

Note on ordering

This can merge before or after cloud#6312 — the change is a doc comment on an open object, so it's inert either way.

Worth flagging separately: the drift above suggests push-ingest-types-to-frontend.yml hasn't been landing its chore PRs. Also, a plain pnpm generate in this package produces ~11k lines of formatting churn because the workflow commits raw generator output with HUSKY: '0' while the committed files are oxfmt-formatted; running oxfmt afterwards collapses it. Might be worth adding the format step to the workflow.

Regenerated @comfyorg/ingest-types from the current cloud ingest spec, via
the same pipeline as the post-merge automation: openapi-project -fe (strips
x-internal / M2M surface) then pnpm generate, plus oxfmt.

The governance change is documentation only. Comfy-Org/cloud#6312 adds
node_errors to the /api/prompt 403 body, but PromptErrorResponse is an open
object (additionalProperties: true), so only the 403's description moves --
no type or schema change.

The rest is drift the package had accumulated against merged cloud specs,
all additive and optional:

- previewable_outputs_count on JobEntry / JobDetailResponse
- tags_all / tags_any / tags_none on /api/assets and the tag histogram,
  with include_tags / exclude_tags now marked deprecated aliases
- pending_billing_op_type on BillingStatusResponse
- include_revoked on the workspace API keys list
- reworded cancel_at and SCA/3DS descriptions

Verified: pnpm typecheck, lint, format:check all clean; app / executionErrorUtil
/ errorCatalog suites pass (169 tests).
@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 04:25:37 PM UTC

Links

🎭 Playwright: ✅ 1800 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1779 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.71 MB gzip 🟢 -17 B

Details

Summary

  • Raw size: 36.8 MB baseline 36.8 MB — 🟢 -102 B
  • Gzip: 8.71 MB baseline 8.71 MB — 🟢 -17 B
  • Brotli: 6.07 MB baseline 6.07 MB — 🟢 -55 B
  • Bundles: 436 current • 436 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🟢 -102 B (1.36 MB) · Vendor & Third-Party ⚪ 0 B (16.3 MB) · Other ⚪ 0 B (14.1 MB) · Data & Services ⚪ 0 B (3.51 MB) · Panels & Settings ⚪ 0 B (565 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CVCoyCEg.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.83 kB 🟢 -1.59 kB
assets/index-DTc3U5kl.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.83 kB 🔴 +1.59 kB

Status: 1 added / 1 removed

Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🟢 -102 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DY95StYd.js (removed) 1.36 MB — 🟢 -1.36 MB 🟢 -295 kB 🟢 -222 kB
assets/GraphView-Djos_JvP.js (new) — 1.36 MB 🔴 +1.36 MB 🔴 +295 kB 🔴 +222 kB

Status: 1 added / 1 removed / 2 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-B1H4YWAw.js (removed) 45.1 kB — 🟢 -45.1 kB 🟢 -13.1 kB 🟢 -11.4 kB
assets/main-uUtEr-5I.js (new) — 45.1 kB 🔴 +45.1 kB 🔴 +13.1 kB 🔴 +11.4 kB

Status: 1 added / 1 removed / 284 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 94.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.9 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 365ms TBT · 153.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap

⚠️ 11 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 494ms 565ms +14% ⚠️ z=5.5
canvas-zoom-sweep: task duration 398ms 474ms +19% ⚠️ z=6.4
dom-widget-clipping: task duration 371ms 452ms +22% ⚠️ z=5.3
large-graph-idle: task duration 694ms 863ms +24% ⚠️ z=5.9
large-graph-idle: script duration 112ms 132ms +18% ⚠️ z=2.8
large-graph-pan: task duration 1314ms 1464ms +11% ⚠️ z=8.9
large-graph-pan: script duration 428ms 491ms +15% ⚠️ z=4.2
minimap-idle: task duration 672ms 837ms +24% ⚠️ z=6.5
minimap-idle: script duration 107ms 131ms +23% ⚠️ z=3.4
subgraph-dom-widget-clipping: task duration 401ms 434ms +8% ⚠️ z=3.0
subgraph-idle: task duration 533ms 634ms +19% ⚠️ z=8.4
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 10ms +16% z=-1.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +6% z=-2.9
canvas-idle: task duration 494ms 565ms +14% ⚠️ z=5.5
canvas-idle: script duration 19ms 24ms +27% z=-0.5
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.1 MB 67.0 MB -0% —
canvas-idle: DOM nodes 18 19 +6% z=-2.8
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.2
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% —
canvas-mouse-sweep: layout duration 4ms 4ms +3% z=1.0
canvas-mouse-sweep: style recalc duration 42ms 42ms +2% z=-0.1
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 77 76 -1% z=-1.1
canvas-mouse-sweep: task duration 920ms 966ms +5% z=1.7
canvas-mouse-sweep: script duration 129ms 135ms +5% z=-0.0
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 50.1 MB 55.4 MB +11% —
canvas-mouse-sweep: DOM nodes -278 -110 -61% z=-66.4
canvas-mouse-sweep: event listeners -151 -74 -51% z=-19.7
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms +16% z=0.5
canvas-zoom-sweep: style recalc duration 20ms 21ms +6% z=1.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 33 +6% z=3.8
canvas-zoom-sweep: task duration 398ms 474ms +19% ⚠️ z=6.4
canvas-zoom-sweep: script duration 21ms 29ms +36% z=0.7
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.2 MB 69.9 MB +1% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 8ms -1% z=-2.3
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 10 -17% z=-6.2
dom-widget-clipping: task duration 371ms 452ms +22% ⚠️ z=5.3
dom-widget-clipping: script duration 60ms 69ms +15% z=0.3
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.7 MB 51.0 MB +0% —
dom-widget-clipping: DOM nodes 20 16 -20% z=-4.3
dom-widget-clipping: event listeners 0 2 — variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 8ms -7% z=-3.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 8 -11% z=-11.5
large-graph-idle: task duration 694ms 863ms +24% ⚠️ z=5.9
large-graph-idle: script duration 112ms 132ms +18% ⚠️ z=2.8
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.2 MB 64.1 MB +1% —
large-graph-idle: DOM nodes -284 -283 -0% z=-340.4
large-graph-idle: event listeners -149 -164 +10% z=-31.2
large-graph-pan: avg frame time 17ms 17ms -0% z=-0.2
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 15ms +5% z=-2.9
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 69 -1% z=-1.7
large-graph-pan: task duration 1314ms 1464ms +11% ⚠️ z=8.9
large-graph-pan: script duration 428ms 491ms +15% ⚠️ z=4.2
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 53.2 MB 59.3 MB +11% —
large-graph-pan: DOM nodes -283 -287 +1% z=-185.5
large-graph-pan: event listeners -179 -165 -8% z=-205.2
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 8ms 8ms +3% —
large-graph-zoom: style recalc duration 15ms 15ms +6% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 64 +0% —
large-graph-zoom: task duration 1598ms 1738ms +9% —
large-graph-zoom: script duration 557ms 612ms +10% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 62.5 MB 69.7 MB +12% —
large-graph-zoom: DOM nodes -285 -290 +2% —
large-graph-zoom: event listeners -153 -151 -1% —
minimap-idle: avg frame time 17ms 17ms +0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 8ms +2% z=-1.8
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 8 +0% z=-2.3
minimap-idle: task duration 672ms 837ms +24% ⚠️ z=6.5
minimap-idle: script duration 107ms 131ms +23% ⚠️ z=3.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 65.1 MB 63.7 MB -2% —
minimap-idle: DOM nodes -283 -284 +0% z=-221.3
minimap-idle: event listeners -147 -165 +12% z=-256.8
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 10ms 11ms +12% z=-1.4
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 +0% z=-1.6
subgraph-dom-widget-clipping: task duration 401ms 434ms +8% ⚠️ z=3.0
subgraph-dom-widget-clipping: script duration 119ms 125ms +5% z=-0.5
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.4 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 20 20 +0% z=-1.9
subgraph-dom-widget-clipping: event listeners 6 8 +33% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 10ms 9ms -5% z=-1.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 9 -10% z=-2.9
subgraph-idle: task duration 533ms 634ms +19% ⚠️ z=8.4
subgraph-idle: script duration 17ms 24ms +41% z=1.4
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 67.1 MB 55.7 MB -17% —
subgraph-idle: DOM nodes 20 10 -53% z=-8.2
subgraph-idle: event listeners 4 -73 -1913% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 4ms 5ms +25% z=0.9
subgraph-mouse-sweep: style recalc duration 36ms 40ms +10% z=-0.7
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 77 -1% z=-1.9
subgraph-mouse-sweep: task duration 813ms 868ms +7% z=1.5
subgraph-mouse-sweep: script duration 96ms 103ms +8% z=0.4
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.9 MB 58.5 MB +1% —
subgraph-mouse-sweep: DOM nodes 63 62 -2% z=-2.2
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +1% —
subgraph-transition-enter: layout duration 13ms 16ms +25% —
subgraph-transition-enter: style recalc duration 30ms 37ms +22% —
subgraph-transition-enter: layout count 13 14 +8% —
subgraph-transition-enter: style recalc count 17 18 +6% —
subgraph-transition-enter: task duration 1007ms 1047ms +4% —
subgraph-transition-enter: script duration 40ms 42ms +5% —
subgraph-transition-enter: TBT 137ms 149ms +9% —
subgraph-transition-enter: heap used 95.1 MB 94.5 MB -1% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2375 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 38ms 40ms +7% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 250 +0% —
viewport-pan-sweep: task duration 4582ms 5223ms +14% —
viewport-pan-sweep: script duration 1401ms 1608ms +15% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 64.4 MB 72.2 MB +12% —
viewport-pan-sweep: DOM nodes -282 -272 -4% —
viewport-pan-sweep: event listeners -163 -131 -20% —
vue-large-graph-idle: avg frame time 18ms 18ms +2% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17632ms 17895ms +1% —
vue-large-graph-idle: script duration 593ms 625ms +5% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.3 MB 158.9 MB -0% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16389 -16389 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 18ms 21ms +14% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 144 150 +4% —
vue-large-graph-pan: task duration 21235ms 21684ms +2% —
vue-large-graph-pan: script duration 918ms 977ms +6% —
vue-large-graph-pan: TBT 326ms 365ms +12% —
vue-large-graph-pan: heap used 160.5 MB 153.1 MB -5% —
vue-large-graph-pan: DOM nodes -8312 -8316 +0% —
vue-large-graph-pan: event listeners -16383 -16382 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms +74% z=-2.5
workflow-execution: style recalc duration 18ms 22ms +20% z=-0.9
workflow-execution: layout count 3 4 +17% z=-2.7
workflow-execution: style recalc count 12 15 +21% z=-1.6
workflow-execution: task duration 113ms 126ms +11% z=0.3
workflow-execution: script duration 10ms 12ms +19% z=-5.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.5 MB 65.4 MB -0% —
workflow-execution: DOM nodes 121 134 +10% z=-3.8
workflow-execution: event listeners 97 98 +1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-12T16:36:24.246Z",
  "gitSha": "a8f336a343d698e4b27705bd12cfde7b77a0bc93",
  "branch": "glary/update-ingest-types-governance-403",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2037.8949999999918,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.253,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.247,
      "heapDeltaBytes": 5889640,
      "heapUsedBytes": 70218296,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 24.053000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2004.980000000046,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.870000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.0350000000001,
      "heapDeltaBytes": 5880256,
      "heapUsedBytes": 70345532,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 24.154,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1931.7589999999996,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 43.291000000000004,
      "layouts": 12,
      "layoutDurationMs": 4.0089999999999995,
      "taskDurationMs": 967.9110000000001,
      "heapDeltaBytes": 269248,
      "heapUsedBytes": 64644512,
      "domNodes": 60,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 138.36599999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1895.3849999999193,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 41.32900000000001,
      "layouts": 12,
      "layoutDurationMs": 3.604,
      "taskDurationMs": 963.816,
      "heapDeltaBytes": -13077164,
      "heapUsedBytes": 51574772,
      "domNodes": -279,
      "jsHeapTotalBytes": 24879104,
      "scriptDurationMs": 132.281,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1749.4859999999903,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 22.621000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.6980000000000001,
      "taskDurationMs": 498.68600000000004,
      "heapDeltaBytes": 8783376,
      "heapUsedBytes": 73297432,
      "domNodes": 77,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 30.311,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.5299999999452,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 20.034,
      "layouts": 6,
      "layoutDurationMs": 0.6309999999999998,
      "taskDurationMs": 449.252,
      "heapDeltaBytes": 8743952,
      "heapUsedBytes": 73323896,
      "domNodes": 79,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 27.963,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 759.5699999999965,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.916,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.2620000000001,
      "heapDeltaBytes": -10956536,
      "heapUsedBytes": 53629404,
      "domNodes": 16,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 74.268,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 619.9740000000702,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.147,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.407,
      "heapDeltaBytes": -10895012,
      "heapUsedBytes": 53255928,
      "domNodes": 16,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 63.01,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2061.279000000013,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.951,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 887.8299999999999,
      "heapDeltaBytes": 7093544,
      "heapUsedBytes": 66680792,
      "domNodes": -284,
      "jsHeapTotalBytes": 2723840,
      "scriptDurationMs": 134.03600000000003,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.6690000000417,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.612000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 838.297,
      "heapDeltaBytes": 7602504,
      "heapUsedBytes": 67715484,
      "domNodes": -282,
      "jsHeapTotalBytes": 3248128,
      "scriptDurationMs": 129.07399999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2455.8679999999526,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.164000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1508.372,
      "heapDeltaBytes": -5518228,
      "heapUsedBytes": 55891540,
      "domNodes": -288,
      "jsHeapTotalBytes": 6131712,
      "scriptDurationMs": 509.82800000000003,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2368.067999999994,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.757,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1420.404,
      "heapDeltaBytes": 7533992,
      "heapUsedBytes": 68367352,
      "domNodes": -286,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 471.22400000000005,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3565.1299999999537,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.399000000000003,
      "layouts": 60,
      "layoutDurationMs": 7.918000000000001,
      "taskDurationMs": 1794.5760000000002,
      "heapDeltaBytes": 15200488,
      "heapUsedBytes": 77472324,
      "domNodes": -290,
      "jsHeapTotalBytes": 5083136,
      "scriptDurationMs": 636.6089999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3363.96400000001,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.528999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.093,
      "taskDurationMs": 1681.7269999999999,
      "heapDeltaBytes": 6486400,
      "heapUsedBytes": 68785824,
      "domNodes": -290,
      "jsHeapTotalBytes": 6918144,
      "scriptDurationMs": 587.1560000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.3729999999646,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.748000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 862.583,
      "heapDeltaBytes": 6898788,
      "heapUsedBytes": 67598644,
      "domNodes": -282,
      "jsHeapTotalBytes": 4296704,
      "scriptDurationMs": 135.456,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.7319999999863,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.405,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 811.389,
      "heapDeltaBytes": 5336776,
      "heapUsedBytes": 65928236,
      "domNodes": -285,
      "jsHeapTotalBytes": 3772416,
      "scriptDurationMs": 127.5,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 655.7260000000156,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.585999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.79599999999994,
      "heapDeltaBytes": -10771152,
      "heapUsedBytes": 53937616,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 123.41000000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 643.9479999999094,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.253000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.168,
      "heapDeltaBytes": -10681664,
      "heapUsedBytes": 53905516,
      "domNodes": 22,
      "jsHeapTotalBytes": 26476544,
      "scriptDurationMs": 126.35,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.9399999999678,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.208,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.299,
      "heapDeltaBytes": 6002320,
      "heapUsedBytes": 70585916,
      "domNodes": 16,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 25.954,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.0019999999577,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.048,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.2149999999999,
      "heapDeltaBytes": -18377096,
      "heapUsedBytes": 46200552,
      "domNodes": 3,
      "jsHeapTotalBytes": 22519808,
      "scriptDurationMs": 22.173,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.3150000000137,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.37,
      "layouts": 16,
      "layoutDurationMs": 5.233,
      "taskDurationMs": 894.5419999999999,
      "heapDeltaBytes": -3302960,
      "heapUsedBytes": 61464288,
      "domNodes": 62,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 105.104,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.9369999999626,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.158,
      "layouts": 16,
      "layoutDurationMs": 4.7139999999999995,
      "taskDurationMs": 841.73,
      "heapDeltaBytes": -3488376,
      "heapUsedBytes": 61203340,
      "domNodes": 62,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 101.13,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1435.44200000008,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 37.038000000000004,
      "layouts": 14,
      "layoutDurationMs": 16.267,
      "taskDurationMs": 1046.774,
      "heapDeltaBytes": 31032652,
      "heapUsedBytes": 99060020,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 41.69299999999999,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9230.794000000004,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.596000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5361.681,
      "heapDeltaBytes": -4913064,
      "heapUsedBytes": 76959376,
      "domNodes": -264,
      "jsHeapTotalBytes": 6430720,
      "scriptDurationMs": 1679.132,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9035.345000000007,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.285000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5084.942,
      "heapDeltaBytes": 14944268,
      "heapUsedBytes": 74531968,
      "domNodes": -280,
      "jsHeapTotalBytes": 5799936,
      "scriptDurationMs": 1537.16,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18018.079999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17971.544,
      "heapDeltaBytes": -35046968,
      "heapUsedBytes": 167257464,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8593408,
      "scriptDurationMs": 612.6750000000001,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17847.997000000076,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17817.698,
      "heapDeltaBytes": -39130576,
      "heapUsedBytes": 165884316,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13762560,
      "scriptDurationMs": 637.0100000000001,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21651.350999999977,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 20.752999999999965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21604.112,
      "heapDeltaBytes": -48916468,
      "heapUsedBytes": 156546268,
      "domNodes": -8316,
      "jsHeapTotalBytes": -7806976,
      "scriptDurationMs": 969.0750000000002,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21806.204999999976,
      "styleRecalcs": 151,
      "styleRecalcDurationMs": 21.106999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21763.588,
      "heapDeltaBytes": -41587188,
      "heapUsedBytes": 164587512,
      "domNodes": -8316,
      "jsHeapTotalBytes": -8331264,
      "scriptDurationMs": 985.2700000000001,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 345,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.4949999999617,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 20.400999999999996,
      "layouts": 3,
      "layoutDurationMs": 0.6509999999999999,
      "taskDurationMs": 121.415,
      "heapDeltaBytes": 5074852,
      "heapUsedBytes": 68472828,
      "domNodes": 124,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.616999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.7650000000758,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 24.034,
      "layouts": 4,
      "layoutDurationMs": 1.722,
      "taskDurationMs": 129.798,
      "heapDeltaBytes": 5161672,
      "heapUsedBytes": 68714220,
      "domNodes": 143,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.201,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 141bca44-5c09-4a9d-9cf8-e606a04e1b14

📥 Commits

Reviewing files that changed from the base of the PR and between 2026348 and 3119a8f.

📒 Files selected for processing (2)
  • packages/ingest-types/src/types.gen.ts
  • packages/ingest-types/src/zod.gen.ts

📝 Walkthrough

Walkthrough

Generated ingest API types and Zod schemas add previewable output counts, billing operation metadata, asset tag filters, and revoked-key filtering. They also update billing, cancellation, and provider-governance documentation.

Changes

Ingest API contract updates

Layer / File(s) Summary
Job and billing response contracts
packages/ingest-types/src/types.gen.ts, packages/ingest-types/src/zod.gen.ts
Job responses expose optional previewable output counts. Billing status exposes the pending operation type. Billing and cancellation documentation is updated.
Asset tag filter contracts
packages/ingest-types/src/types.gen.ts, packages/ingest-types/src/zod.gen.ts
Asset listing and tag histogram queries support tags_all, tags_any, and tags_none, with deprecated aliases and documented validation rules.
API-key and governance contracts
packages/ingest-types/src/types.gen.ts, packages/ingest-types/src/zod.gen.ts
Workspace API-key listing accepts include_revoked, defaulting to false. Provider-governance errors document per-denied-node details.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: mobeenabdullah


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed files are listed, but the PR title and commit subjects are unavailable, so the required bug-fix signal cannot be verified. Provide the PR title and all commit subjects, then reassess whether bug-fix language is present.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: updating Ingest API types from the cloud specification.
Description check ✅ Passed The description clearly explains the regeneration process, key changes, scope, and verification, although it does not use the template headings.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are under packages/ingest-types/src and do not include src/lib/litegraph/, src/ecs/, or graph-entity files.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/update-ingest-types-governance-403

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@glary-bot

glary-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

No changes pushed — this is CodeRabbit's "review in progress" placeholder, so there are no findings to act on yet. Flagging two things for whoever picks up the real pass.

Declining both Finishing Touches offers, deliberately:

  • Generate docstrings — both files in this diff are generated artifacts. They carry // This file is auto-generated by @hey-api/openapi-ts and are declared linguist-generated=true in .gitattributes:6-7. Any hand-written docstring here is destroyed by the next pnpm generate and, worse, would make the committed package disagree with the spec it's supposed to mirror. Doc changes belong in services/ingest/openapi.yaml in the cloud repo, which is where every comment in this diff actually comes from.
  • Generate unit tests — the diff is type declarations and Zod schema definitions with no behaviour to exercise. Tests asserting that previewable_outputs_count is z.number().int().optional() would just restate the generator's output. The consuming behaviour is already covered in src/ (app.test.ts, executionErrorUtil.test.ts, the errorCatalog suite — 169 passing), and those are the tests that would catch a real contract break.

For the line-by-line pass: there is no hand-written code here. Every line is openapi-ts output from the cloud ingest spec, produced via the same pipeline as push-ingest-types-to-frontend.yml (openapi-project -fe → pnpm generate → oxfmt). So anything that looks wrong in this diff is a finding about the spec in Comfy-Org/cloud#6312 or an already-merged cloud change, not something fixable in this repo — the fix would be in openapi.yaml followed by a regen.

Substantively this PR is one JSDoc line (the /api/prompt 403 description). Everything else is drift the package had accumulated against merged cloud specs — all additive and optional, itemised in the description.

@glary-bot

glary-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Thanks for the approval. The comment bodies didn't reach me — I received the approval event with no comment text or IDs attached. That's the second time in this stack (same thing happened with @synap5e's approval on cloud#6312), and I have no GitHub API access to go read them myself.

So I've changed nothing rather than guess or treat the approval as "nothing to do". If anything in there needs action, please re-post it and I'll pick it up.

One thing I can say without seeing them: if the comments point at anything in the diff itself, the fix almost certainly isn't in this repo. Both files are generated (linguist-generated=true, @hey-api/openapi-ts headers) — every line is openapi-ts output from cloud's ingest spec. A real issue here means editing services/ingest/openapi.yaml in cloud and regenerating; patching the .gen.ts files directly would be reverted by the next pnpm generate.

State of what was approved: PR head 3119a8f is byte-for-byte my local HEAD, tree clean, merge ref resolves. pnpm typecheck / lint / format:check all exit 0, and the pre-commit hooks (oxfmt, oxlint, eslint, typecheck) ran clean on both files at this commit. Substantively it's one JSDoc line for the /api/prompt 403; the rest is itemised drift against already-merged cloud specs.

Both PRs in this pair are now approved and both are still drafts, so neither can merge:

I don't have the ability to flip draft status. Could someone mark them ready, or say if they should stay draft pending something? The only other open item I'm aware of is that TestExecutePromptGovernanceGate in cloud#6312 has never actually executed — it's testcontainers-gated and there's no Docker in my sandbox, so it needs a CI run.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15143      +/-   ##
==========================================
- Coverage   79.73%   79.69%   -0.04%     
==========================================
  Files        1804     1880      +76     
  Lines      125725   132569    +6844     
  Branches    38065    41348    +3283     
==========================================
+ Hits       100241   105652    +5411     
- Misses      24807    26178    +1371     
- Partials      677      739      +62     
Flag Coverage Δ
unit 72.55% <100.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)

... and 545 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

huang47 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by later generated Ingest API updates, including #15425 and #15802.

@huang47 huang47 closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants