Repository navigation
fix(featureFlags): resolve nodeLibraryEssentialsEnabled through resolveFlag - #15125
Conversation
…veFlag The getter hand-rolled its resolution and read remoteConfig before the override layers, so a ?ff= session override and the ff: dev override were both ignored once remote config served a value, and dev builds could never turn the Essentials tab off. Route it through resolveFlag with the nightly/dev default-on moved below the override lookup.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1808 passed, 0 failed📊 Browser Reports
📦 Bundle: 8.71 MB gzip 🔴 +31 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • 🟢 -11 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T06:25:01.602Z",
"gitSha": "cf01d2c808ae0df491e3ff7e620a4830f5709395",
"branch": "matt/fe-1599-node-library-essentials-resolve-flag",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.7620000000152,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.626,
"heapDeltaBytes": 5764888,
"heapUsedBytes": 70163440,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 21.641,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.7819999999401,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.819,
"heapDeltaBytes": 5984152,
"heapUsedBytes": 70543676,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 25.382,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.4860000000372,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.968999999999994,
"layouts": 12,
"layoutDurationMs": 3.7779999999999996,
"taskDurationMs": 905.118,
"heapDeltaBytes": 651060,
"heapUsedBytes": 64872584,
"domNodes": 60,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 136.153,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.7250000000113,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.801,
"layouts": 12,
"layoutDurationMs": 3.3009999999999997,
"taskDurationMs": 1015.5619999999999,
"heapDeltaBytes": -10587968,
"heapUsedBytes": 53860196,
"domNodes": -280,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 134.728,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.051999999982,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.943999999999996,
"layouts": 6,
"layoutDurationMs": 0.6610000000000001,
"taskDurationMs": 438.00300000000004,
"heapDeltaBytes": 8844620,
"heapUsedBytes": 73203616,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 25.77,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.604999999915,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.410999999999998,
"layouts": 6,
"layoutDurationMs": 0.7459999999999999,
"taskDurationMs": 425.26099999999997,
"heapDeltaBytes": 8184192,
"heapUsedBytes": 72556660,
"domNodes": 79,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 24.816000000000006,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 633.7330000000065,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.442000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.323,
"heapDeltaBytes": -10784952,
"heapUsedBytes": 53512024,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 63.113,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 622.8979999999638,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.893000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.433,
"heapDeltaBytes": -11200072,
"heapUsedBytes": 53185804,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 64.38199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.1870000000076,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.306999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.827,
"heapDeltaBytes": 6583516,
"heapUsedBytes": 66030200,
"domNodes": -284,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 127.09799999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2035.991000000081,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.906999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.3430000000001,
"heapDeltaBytes": 4132100,
"heapUsedBytes": 63606936,
"domNodes": -283,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 124.76700000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2233.616999999981,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.275000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1403.5570000000002,
"heapDeltaBytes": 5067700,
"heapUsedBytes": 65740716,
"domNodes": -286,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 467.73099999999994,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2268.4169999999995,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.481000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1358.62,
"heapDeltaBytes": 4081200,
"heapUsedBytes": 64630212,
"domNodes": -285,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 441.121,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3293.0970000000457,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.198000000000002,
"layouts": 60,
"layoutDurationMs": 7.753000000000001,
"taskDurationMs": 1616.3740000000003,
"heapDeltaBytes": 965004,
"heapUsedBytes": 63289548,
"domNodes": -288,
"jsHeapTotalBytes": 6393856,
"scriptDurationMs": 560.142,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3327.658999999926,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.235,
"layouts": 60,
"layoutDurationMs": 7.549,
"taskDurationMs": 1627.258,
"heapDeltaBytes": 3051248,
"heapUsedBytes": 65317896,
"domNodes": -288,
"jsHeapTotalBytes": 6918144,
"scriptDurationMs": 562.9309999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.3599999999828,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.765000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.1960000000001,
"heapDeltaBytes": 6550996,
"heapUsedBytes": 67243552,
"domNodes": -287,
"jsHeapTotalBytes": 4820992,
"scriptDurationMs": 130.663,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.1550000000698,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.063999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.1739999999999,
"heapDeltaBytes": 7569280,
"heapUsedBytes": 68241992,
"domNodes": -285,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 121.367,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.5399999999909,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.86899999999997,
"heapDeltaBytes": -10663476,
"heapUsedBytes": 53786312,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 122.962,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.8100000000104,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.240999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.8,
"heapDeltaBytes": -10727936,
"heapUsedBytes": 53828292,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 121.54199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.0749999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.3299999999999,
"heapDeltaBytes": 5865140,
"heapUsedBytes": 70507480,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.897999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.8340000000353,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.063,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.0070000000001,
"heapDeltaBytes": 5929864,
"heapUsedBytes": 70457788,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 20.51,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1768.5669999999618,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.859,
"layouts": 16,
"layoutDurationMs": 4.995,
"taskDurationMs": 905.718,
"heapDeltaBytes": -18338256,
"heapUsedBytes": 46129084,
"domNodes": 0,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 101.73899999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.8309999999674,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.103,
"layouts": 16,
"layoutDurationMs": 5.3,
"taskDurationMs": 883.7400000000001,
"heapDeltaBytes": -18491644,
"heapUsedBytes": 46123212,
"domNodes": -279,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 103.30600000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1414.4909999999982,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.909000000000006,
"layouts": 14,
"layoutDurationMs": 12.601,
"taskDurationMs": 1012.961,
"heapDeltaBytes": 3968816,
"heapUsedBytes": 76624928,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 38.14299999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8877.606999999954,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5004.94,
"heapDeltaBytes": 20218960,
"heapUsedBytes": 79854980,
"domNodes": -284,
"jsHeapTotalBytes": 6586368,
"scriptDurationMs": 1592.503,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8432.355000000029,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4788.258,
"heapDeltaBytes": 11684332,
"heapUsedBytes": 71547796,
"domNodes": -281,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1446.8719999999998,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17191.186000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17173.126999999997,
"heapDeltaBytes": -58262216,
"heapUsedBytes": 167350956,
"domNodes": -8312,
"jsHeapTotalBytes": -7544832,
"scriptDurationMs": 510.896,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17420.89199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17391.531,
"heapDeltaBytes": -60487404,
"heapUsedBytes": 165695280,
"domNodes": -8313,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 599.379,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20819.199999999968,
"styleRecalcs": 144,
"styleRecalcDurationMs": 19.513999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20792.252999999997,
"heapDeltaBytes": -49468760,
"heapUsedBytes": 164393380,
"domNodes": -8312,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 882.29,
"eventListeners": -16385,
"totalBlockingTimeMs": 278,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20764.30300000004,
"styleRecalcs": 142,
"styleRecalcDurationMs": 18.56199999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20725.328999999998,
"heapDeltaBytes": -29242140,
"heapUsedBytes": 176811764,
"domNodes": -8312,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 908.079,
"eventListeners": -16383,
"totalBlockingTimeMs": 280,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 469.98599999994894,
"styleRecalcs": 17,
"styleRecalcDurationMs": 17.237000000000002,
"layouts": 3,
"layoutDurationMs": 1.183,
"taskDurationMs": 117.42699999999999,
"heapDeltaBytes": 5183820,
"heapUsedBytes": 68553696,
"domNodes": 146,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.4080000000631,
"styleRecalcs": 11,
"styleRecalcDurationMs": 17.325,
"layouts": 3,
"layoutDurationMs": 0.5599999999999999,
"taskDurationMs": 111.47200000000001,
"heapDeltaBytes": 5045560,
"heapUsedBytes": 68551672,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.54,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15125 +/- ##
=======================================
Coverage 81.41% 81.41%
=======================================
Files 1882 1882
Lines 106683 106681 -2
Branches 33293 33199 -94
=======================================
- Hits 86860 86859 -1
+ Misses 19481 19470 -11
- Partials 342 352 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Pins the precedence the resolveFlag switch introduces for nodeLibraryEssentialsEnabled: the nightly/dev default still turns the tab on when nothing is served, and an explicit remote-config or server false now turns it off.
|
🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:
The following carry
|
Summary
nodeLibraryEssentialsEnabledhand-rolled its own resolution and read remote config before the override layers, so?ff=node_library_essentials_enabled:falseand theff:localStorage dev override were both silently ignored — this getter now goes through the sharedresolveFlaghelper like every other remote-config-backed flag.Changes
nodeLibraryEssentialsEnablednow callsresolveFlag(...), so precedence is session override → dev override → remote config → server value, matching every other flag inuseFeatureFlags. The nightly/dev default-on moves below the override lookup:isNightly || import.meta.env.DEVbecomesresolveFlag'sdefaultValueinstead of an unconditional earlyreturn true.isNightly || DEVisfalsethere, which is the default the old code already passed). Two deltas, both intentional: (1) an employee?ff=link or anff:dev override now actually changes the Essentials tab, and (2) on nightly and local dev builds an explicitly-served value (/featuresremote config or the server feature flag) now wins over the built-in on — previously nothing could turn the Essentials tab off locally, which is half of the reported bug.session override precedenceblock asserting afalsesession override beats atrueremote-config value, plus anodeLibraryEssentialsEnabledblock covering the nightly axis — nightly + nothing served → on, nightly + remote-configfalse→ off, nightly + served serverfalse→ off. All threefalsecases are red onmain(it returnstrue) and green with the fix.Review Focus
git log -Lshows the getter arrived in feat: add feature flag to disable Essentials tab in node library #9067, whose description states the intent as "Defaults totruein dev/nightly builds,falsein production. Overridable via remote config or server feature flags" — i.e. dev/nightly was always meant as a default, and the early return only reads as a hard override because the?ff=session layer (feat(featureFlags): employee-gated session feature flag overrides via ?ff= #15033) landed ~6 months later and this getter never opted in. Making itresolveFlag'sdefaultValueis the shape that commit describes.false(item 2 above). Flagging it explicitly rather than burying it: it is the intended semantics, but it is a behavior change for anyone on nightly whose/featuresendpoint serves this flag. The cursor-review panel raised this; it is now pinned by thenodeLibraryEssentialsEnabledtest block.linearToggleEnabledhas the sameif (isNightly) return trueshort-circuit above itsresolveFlagcall and is un-overridable on nightly for the same reason. Deliberately left alone here to keep this diff to one getter; worth a separate change.Test Plan
pnpm exec vitest run src/composables/useFeatureFlags.test.ts src/components/sidebar/tabs/NodeLibrarySidebarTabV2.test.ts src/components/searchbox/v2/NodeSearchContent.test.ts— 79 passed (the two component specs are the flag's consumers).pnpm typecheck— clean.oxfmt --checkandeslinton both changed files — clean.