Skip to content

[backport cloud/1.49] fix(onboarding): pick the first-run nudge's copy from how the tour ended - #15098

Merged
comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14677-to-cloud-1.49
Aug 12, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14677-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14677 to cloud/1.49

Automatically created by backport workflow.

…ded (#14677)

## Summary

The first-run nudge picked its copy from whether a tour _started_, so a
user who skipped on step 1 — or one whose tour was torn down by a target
that never mounted — was congratulated for a first result they never
made. This makes the copy follow how the tour actually ended. **The
nudge's visibility is unchanged: every ending still shows it.**

## The defect

`FirstRunTourNudge.vue` chose its copy with `` `…nudge.${tourWasShown ?
'ran' : 'noTour'}` ``, and `tourWasShown` was assigned from `started` —
the return of `engine.startTour()` in `useFirstRunTourController.ts` —
which means _a tour began_, not _the user completed one_:

| ending | copy before | copy now |
| -------------------------------- |
------------------------------------------------ | -------- |
| completed | `ran` | `ran` |
| never appeared | `noTour` ✓ | `noTour` |
| **skipped on step 1** | **`ran`** — "You just made your first" |
`noTour` |
| **abandoned (`target_timeout`)** | **`ran`**, shown alongside the
`loadError` toast | `noTour` |
| postponed (paywall) | `ran` | `noTour` |
| `trigger_lost` | `ran` | `noTour` |

The abandoned case is the sharp one: the same event raises an error
toast and a congratulation.

## Changes

- **What**: `finish()` in `onboardingTourStore.ts` already computes
`outcome` and `skipReason`; the store now hands that on as `lastEnding`
(a discriminated union, cleared when a new run is requested so the
previous ending cannot speak for it). `useFirstRunTourController`
derives `tourWasCompleted` from it in place of `tourWasShown`, and the
nudge reserves the `ran` copy for `completed`. Every other ending gets
`noTour`, which reads as "here's where to go next" for a skipper or an
abandoner.
- **Breaking**: none. `lastEnding` is additive; `tourWasShown` had
exactly one consumer (the nudge).

## Visibility is deliberately unchanged

Every ending still arms the nudge, including the ones that now read as
`noTour`. That is @MaanilVerma's product decision in #14144: _"a user
who saw no tour is the one who most needs somewhere to go next, so
suppressing it there removes the way forward."_ #14672 tried to suppress
the nudge on the abandoned ending and was closed for exactly this reason
— this PR treats the copy, not the visibility, as the defect.

The regression guard for that is `still offers the nudge after a tour
$named` in `useFirstRunTourController.test.ts`, which asserts
`nudgeArmed` for all five endings, plus a sixth test for the
never-started case and a component-level check that the nudge renders
whether or not the tour finished.

## Tests

New coverage, 19 tests:

- `onboardingTourStore.test.ts` (6) — the ending recorded for a user
skip, a `target_timeout` teardown, a `trigger_lost` teardown, a
walked-to-the-end tour; that a running tour has no ending; that a new
run drops the last one.
- `useFirstRunTourController.test.ts` (10, plus an existing
never-started test extended to assert visibility) — `completed` →
congratulation; `user` / `target_timeout` / `postponed` / `trigger_lost`
→ none; **all five endings still arm the nudge**; never-started arms it
too, with no congratulation.
- `FirstRunTourNudge.test.ts` (3) — completed → `ran`, unfinished →
`noTour`, and the nudge appears either way.

### Mutation evidence

- Revert the rule to the old semantics (`tourWasCompleted = ending?.tour
=== 'firstRun'`, i.e. "a tour ran"): **4 failed | 45 passed**. The four
are the skipped/abandoned/postponed/lost-context copy cases. The five
visibility tests stayed green, confirming they are not coupled to the
copy rule.
- Pin the component's copy key to `ran`: **1 failed | 10 passed**. Pin
it to `noTour`: **1 failed | 10 passed**.
- Restored: **374 passed (23 files)** across
`src/renderer/extensions/firstRunTour` and `src/platform/onboarding`.

`pnpm install --frozen-lockfile`, `format:check`, `lint`, `typecheck`
and `knip` all clean.

## Review Focus

- `lastEnding` carries `skipReason` although no production code reads it
today — the tests name each ending, so the reason has to be observable,
and it is the shape `finish()` already computes. Say the word if you
would rather it be trimmed to `{ tour, outcome }`.
- The controller latches `tourWasCompleted` when the nudge arms rather
than deriving it live, so a later tour ending cannot rewrite the copy of
a nudge already on screen.
- Not verified: no e2e run. `gettingStartedTour.spec.ts` → "leaves the
nudge until the upgrade dialog closes" asserts visibility only
(postponed still arms), and no e2e or unit test elsewhere asserts the
nudge's copy strings — checked by grep, not by running Playwright.
- Telemetry is untouched: `nudge_shown` and `explore_templates_clicked`
still report only `{ tour: 'firstRun' }`, so the funnel still cannot
tell a toured user from a tour-less one. That is a real gap, and
deliberately out of scope here.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 12, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 12, 2026 00:58
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1788 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1767 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 01:00:22 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 136ms TBT · 69.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.2 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 412ms TBT · 161.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 515ms
canvas-idle: script duration 19ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.5 MB
canvas-idle: DOM nodes 15
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 880ms
canvas-mouse-sweep: script duration 126ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.4 MB
canvas-mouse-sweep: DOM nodes -112
canvas-mouse-sweep: event listeners -75
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 378ms
canvas-zoom-sweep: script duration 19ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 384ms
dom-widget-clipping: script duration 59ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.9 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 675ms
large-graph-idle: script duration 107ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.7 MB
large-graph-idle: DOM nodes -284
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1290ms
large-graph-pan: script duration 435ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 58.0 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -165
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1493ms
large-graph-zoom: script duration 522ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 58.0 MB
large-graph-zoom: DOM nodes -289
large-graph-zoom: event listeners -153
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 669ms
minimap-idle: script duration 104ms
minimap-idle: TBT 0ms
minimap-idle: heap used 63.1 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 416ms
subgraph-dom-widget-clipping: script duration 123ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 54.7 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 463ms
subgraph-idle: script duration 15ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.5 MB
subgraph-idle: DOM nodes 21
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 34ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 786ms
subgraph-mouse-sweep: script duration 91ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 53.3 MB
subgraph-mouse-sweep: DOM nodes -109
subgraph-mouse-sweep: event listeners -75
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 904ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 136ms
subgraph-transition-enter: heap used 69.6 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4498ms
viewport-pan-sweep: script duration 1403ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 63.4 MB
viewport-pan-sweep: DOM nodes -285
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17261ms
vue-large-graph-idle: script duration 587ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.2 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16389
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 149
vue-large-graph-pan: task duration 21335ms
vue-large-graph-pan: script duration 964ms
vue-large-graph-pan: TBT 412ms
vue-large-graph-pan: heap used 161.2 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 129ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 49.3 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-12T01:10:43.106Z",
  "gitSha": "bb994c3a303b722cdc8bc7a0298989ad22abff48",
  "branch": "backport-14677-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2153.1479999999874,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.595,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.298,
      "heapDeltaBytes": 5418912,
      "heapUsedBytes": 74107004,
      "domNodes": 12,
      "jsHeapTotalBytes": 19775488,
      "scriptDurationMs": 24.204000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.0330000000222,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.316999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.57399999999996,
      "heapDeltaBytes": 5328952,
      "heapUsedBytes": 73706632,
      "domNodes": 18,
      "jsHeapTotalBytes": 19775488,
      "scriptDurationMs": 14.613000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1887.9519999999843,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.54600000000001,
      "layouts": 12,
      "layoutDurationMs": 3.7390000000000003,
      "taskDurationMs": 905.2640000000001,
      "heapDeltaBytes": -16593300,
      "heapUsedBytes": 51978024,
      "domNodes": -284,
      "jsHeapTotalBytes": 21737472,
      "scriptDurationMs": 126.11900000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.20099999995,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.599,
      "layouts": 12,
      "layoutDurationMs": 3.5999999999999996,
      "taskDurationMs": 854.5319999999999,
      "heapDeltaBytes": -268228,
      "heapUsedBytes": 68307220,
      "domNodes": 60,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 125.39200000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1751.2309999999616,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.342999999999996,
      "layouts": 6,
      "layoutDurationMs": 0.598,
      "taskDurationMs": 389.07800000000003,
      "heapDeltaBytes": 7971420,
      "heapUsedBytes": 76435180,
      "domNodes": 76,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 19.264,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.4450000000033,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.507,
      "layouts": 6,
      "layoutDurationMs": 0.712,
      "taskDurationMs": 366.36199999999997,
      "heapDeltaBytes": 8361368,
      "heapUsedBytes": 76827384,
      "domNodes": 75,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 17.992,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 629.2970000000082,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.568000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.25199999999995,
      "heapDeltaBytes": -11270848,
      "heapUsedBytes": 57344792,
      "domNodes": 20,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 61.60699999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 554.224999999974,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.263999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.487,
      "heapDeltaBytes": -12751368,
      "heapUsedBytes": 55686272,
      "domNodes": 18,
      "jsHeapTotalBytes": 21610496,
      "scriptDurationMs": 57.001999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.7170000000192,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.0749999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 694.1149999999999,
      "heapDeltaBytes": 7931960,
      "heapUsedBytes": 67813784,
      "domNodes": -284,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 113.05999999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.141000000047,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.581,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.9650000000001,
      "heapDeltaBytes": 3842992,
      "heapUsedBytes": 63640084,
      "domNodes": -284,
      "jsHeapTotalBytes": 5562368,
      "scriptDurationMs": 100.67200000000001,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2197.407999999996,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.825999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1321.0649999999998,
      "heapDeltaBytes": -5384992,
      "heapUsedBytes": 55451844,
      "domNodes": -283,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 441.418,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2141.6659999999865,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.991000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1258.125,
      "heapDeltaBytes": 5204276,
      "heapUsedBytes": 66106024,
      "domNodes": -286,
      "jsHeapTotalBytes": 4739072,
      "scriptDurationMs": 428.95,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3197.2039999999993,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.612,
      "layouts": 60,
      "layoutDurationMs": 7.645,
      "taskDurationMs": 1523.602,
      "heapDeltaBytes": -1649292,
      "heapUsedBytes": 60782716,
      "domNodes": -290,
      "jsHeapTotalBytes": 7921664,
      "scriptDurationMs": 527.9019999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3210.5849999999236,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.607999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.07,
      "taskDurationMs": 1462.269,
      "heapDeltaBytes": -1104648,
      "heapUsedBytes": 60930560,
      "domNodes": -287,
      "jsHeapTotalBytes": 8183808,
      "scriptDurationMs": 515.664,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.870999999962,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.517000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 679.2060000000001,
      "heapDeltaBytes": 2115284,
      "heapUsedBytes": 64056676,
      "domNodes": -284,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 107.386,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.8460000000532,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.992999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.0250000000001,
      "heapDeltaBytes": 6491708,
      "heapUsedBytes": 68271808,
      "domNodes": -282,
      "jsHeapTotalBytes": 4775936,
      "scriptDurationMs": 101.03,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 623.3889999999747,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.694999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.408,
      "heapDeltaBytes": -11205368,
      "heapUsedBytes": 57338488,
      "domNodes": 20,
      "jsHeapTotalBytes": 21872640,
      "scriptDurationMs": 126.68099999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.6519999999437,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.826,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.61400000000003,
      "heapDeltaBytes": -11369844,
      "heapUsedBytes": 57339756,
      "domNodes": 20,
      "jsHeapTotalBytes": 20824064,
      "scriptDurationMs": 119.93900000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.5459999999675,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.202,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.45899999999995,
      "heapDeltaBytes": 5285660,
      "heapUsedBytes": 73919256,
      "domNodes": 20,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 16.214,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.9599999999973,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.278,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.635,
      "heapDeltaBytes": 5294912,
      "heapUsedBytes": 73907784,
      "domNodes": 22,
      "jsHeapTotalBytes": 20824064,
      "scriptDurationMs": 12.986999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.6919999999513,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.309,
      "layouts": 16,
      "layoutDurationMs": 4.352,
      "taskDurationMs": 832.4540000000001,
      "heapDeltaBytes": -21556248,
      "heapUsedBytes": 47194368,
      "domNodes": -280,
      "jsHeapTotalBytes": 19902464,
      "scriptDurationMs": 97.36399999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1682.7670000000126,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 32.150999999999996,
      "layouts": 16,
      "layoutDurationMs": 3.5440000000000005,
      "taskDurationMs": 738.844,
      "heapDeltaBytes": -3968624,
      "heapUsedBytes": 64639136,
      "domNodes": 63,
      "jsHeapTotalBytes": 20824064,
      "scriptDurationMs": 84.488,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.685000000014,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.240999999999996,
      "layouts": 14,
      "layoutDurationMs": 12.186000000000002,
      "taskDurationMs": 904.263,
      "heapDeltaBytes": 1462692,
      "heapUsedBytes": 72959604,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 30.990999999999993,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8477.430000000026,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.203,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4668.691,
      "heapDeltaBytes": 13355176,
      "heapUsedBytes": 72991956,
      "domNodes": -285,
      "jsHeapTotalBytes": 6803456,
      "scriptDurationMs": 1440.1950000000002,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8189.962000000037,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.467,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4326.879,
      "heapDeltaBytes": 11728,
      "heapUsedBytes": 60053104,
      "domNodes": -284,
      "jsHeapTotalBytes": 6873088,
      "scriptDurationMs": 1366.546,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17311.396,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17282.787,
      "heapDeltaBytes": -40794216,
      "heapUsedBytes": 172804732,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11739136,
      "scriptDurationMs": 597.858,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17285.779999999933,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17239.224,
      "heapDeltaBytes": -46863580,
      "heapUsedBytes": 167443860,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10690560,
      "scriptDurationMs": 576.9870000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21270.470000000045,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 19.22499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21240.577999999998,
      "heapDeltaBytes": -55073040,
      "heapUsedBytes": 168549196,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11214848,
      "scriptDurationMs": 993.587,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 370,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21469.187000000034,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 19.513,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21429.417,
      "heapDeltaBytes": -53626928,
      "heapUsedBytes": 169597724,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10428416,
      "scriptDurationMs": 934.7449999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 453,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.50899999999183,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 19.855,
      "layouts": 2,
      "layoutDurationMs": 0.423,
      "taskDurationMs": 123.187,
      "heapDeltaBytes": -16059636,
      "heapUsedBytes": 51795676,
      "domNodes": 132,
      "jsHeapTotalBytes": 7454720,
      "scriptDurationMs": 11.986,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 489.04300000003786,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 18.43,
      "layouts": 2,
      "layoutDurationMs": 0.317,
      "taskDurationMs": 135.322,
      "heapDeltaBytes": -15869100,
      "heapUsedBytes": 51556208,
      "domNodes": 119,
      "jsHeapTotalBytes": 7192576,
      "scriptDurationMs": 10.270999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.49   #15098   +/-   ##
=============================================
  Coverage              ?   71.91%           
=============================================
  Files                 ?     1767           
  Lines                 ?    92438           
  Branches              ?    24883           
=============================================
  Hits                  ?    66475           
  Misses                ?    25844           
  Partials              ?      119           
Flag Coverage Δ
unit 71.91% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/onboarding/onboardingTourStore.ts 99.49% <100.00%> (ø)
...xtensions/firstRunTour/nudge/FirstRunTourNudge.vue 97.43% <100.00%> (ø)
...ons/firstRunTour/tour/useFirstRunTourController.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 7f025d8 into cloud/1.49 Aug 12, 2026
76 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14677-to-cloud-1.49 branch August 12, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants