Skip to content

refactor: preserve subgraph topology during unpack - #15018

Merged
DrJKL merged 2 commits into
feature/ecs-migrationfrom
drjkl/split-link-replacement
Aug 15, 2026
Merged

DrJKL merged 2 commits into
feature/ecs-migrationfrom
drjkl/split-link-replacement

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Split 3/6 of #14480. Stacked on #15009.

The original version replaced every rewired link with a fresh ID. #15009 now addresses that root cause more simply: endpoint changes are validated and applied atomically at the link-store mutation boundary while preserving link identity. This PR has therefore been reduced to the remaining independent cleanup.

LGraph._unpackSubgraphImpl() previously rewrote the registered links in the shared subgraph definition while calculating their parent-graph endpoints. Unpacking one instance could transiently reindex or partially mutate topology still used by another instance.

This change computes mapped origin/target endpoints in local variables, leaving the source definition and its store registration untouched. The behavioral test keeps another instance of the definition alive, unpacks one instance, and verifies both the original topology and copied parent link.

Deliberately omitted:

  • no linkReplacement.ts
  • no fresh IDs for endpoint changes
  • no immutable/warn-and-ignore endpoint setters
  • no second topology mutation boundary outside linkStore

Test plan:

  • pnpm test:unit src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts
  • typecheck, changed-file lint/format, and diff checks

@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c091fba-1738-4378-bc9b-c076b614c9db

📥 Commits

Reviewing files that changed from the base of the PR and between a3ec313 and 35ceb95.

📒 Files selected for processing (2)
  • src/lib/litegraph/src/LGraph.ts
  • src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts

📝 Walkthrough

Walkthrough

Subgraph unpacking now resolves external input links directly from link objects, preserves serialized link definitions, and remaps internal targets without mutating link data. A regression test covers shared link definitions and parent-node remapping.

Changes

Subgraph link reconstruction

Layer / File(s) Summary
Resolve subgraph links
src/lib/litegraph/src/LGraph.ts
Subgraph unpacking derives external origins, slots, reroutes, and internal targets without mutating serialized links.
Validate shared link definitions
src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts
The regression test verifies preserved link-store topology and remapped parent links between copied nodes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 35ceb

This localized refactor preserves subgraph topology during unpack without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested reviewers: benjcooley, austinmroz, christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The review context lists changed files and a description, but it does not provide the PR title or commit subjects required to check for bug-fix language. Provide the PR title and commit subjects, then reassess the browser_tests and end-to-end regression-test conditions.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: preserving subgraph topology during unpacking.
Description check ✅ Passed The description explains the problem, solution, scope, exclusions, and test plan, although it does not use the template headings.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are under litegraph, but the metadata shows only local link-endpoint mapping and a regression test; it adds no listed ADR 0003 or ADR 0008 pattern.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drjkl/split-link-replacement

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/15/2026, 12:33:07 AM UTC

Links

🎭 Playwright: ✅ 1813 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1792 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 88.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 1ms TBT · 82.3 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.2 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 742ms TBT · 156.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 532ms
canvas-idle: script duration 31ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.5 MB
canvas-idle: DOM nodes 14
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 1364ms
canvas-mouse-sweep: script duration 186ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 402ms
canvas-zoom-sweep: script duration 30ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 50.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 475ms
dom-widget-clipping: script duration 41ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.5 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 843ms
large-graph-idle: script duration 319ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.1 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2913ms
large-graph-pan: script duration 1374ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.5 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -150
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 3035ms
large-graph-zoom: script duration 1456ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 59.8 MB
large-graph-zoom: DOM nodes -120
large-graph-zoom: event listeners -71
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 2846ms
legacy-node-drag: script duration 756ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 56.9 MB
legacy-node-drag: DOM nodes -287
legacy-node-drag: event listeners -108
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 861ms
minimap-idle: script duration 327ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.0 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -170
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 545ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.4 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 549ms
subgraph-idle: script duration 23ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 47.8 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -203
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 1138ms
subgraph-mouse-sweep: script duration 121ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 49.7 MB
subgraph-mouse-sweep: DOM nodes -139
subgraph-mouse-sweep: event listeners -218
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 999ms
subgraph-transition-enter: script duration 51ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 88.4 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 10421ms
viewport-pan-sweep: script duration 4847ms
viewport-pan-sweep: TBT 1ms
viewport-pan-sweep: heap used 82.3 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -124
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18114ms
vue-large-graph-idle: script duration 1270ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7469
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 22605ms
vue-large-graph-pan: script duration 1837ms
vue-large-graph-pan: TBT 742ms
vue-large-graph-pan: heap used 156.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7466
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 25ms
workflow-execution: layout count 4
workflow-execution: style recalc count 17
workflow-execution: task duration 143ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 50.1 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 97
Raw data
{
  "timestamp": "2026-08-15T00:44:32.940Z",
  "gitSha": "a4be732853676fa75d682e29c923ae6affa14716",
  "branch": "drjkl/split-link-replacement",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2050.4569999999944,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.402999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.596,
      "heapDeltaBytes": 8519744,
      "heapUsedBytes": 77203752,
      "domNodes": 12,
      "jsHeapTotalBytes": 20971520,
      "scriptDurationMs": 34.613,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.689000000053,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.375,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.63800000000003,
      "heapDeltaBytes": 8116368,
      "heapUsedBytes": 76970332,
      "domNodes": 16,
      "jsHeapTotalBytes": 20971520,
      "scriptDurationMs": 28.122,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2461.4199999999755,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 45.715,
      "layouts": 12,
      "layoutDurationMs": 3.913,
      "taskDurationMs": 1478.517,
      "heapDeltaBytes": -16241008,
      "heapUsedBytes": 52464196,
      "domNodes": -282,
      "jsHeapTotalBytes": 21336064,
      "scriptDurationMs": 196.73000000000002,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2224.164000000087,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 42.612,
      "layouts": 12,
      "layoutDurationMs": 3.6100000000000003,
      "taskDurationMs": 1249.617,
      "heapDeltaBytes": 891300,
      "heapUsedBytes": 69439900,
      "domNodes": -280,
      "jsHeapTotalBytes": 21073920,
      "scriptDurationMs": 175.25099999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.3900000000049,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.759,
      "layouts": 6,
      "layoutDurationMs": 0.5929999999999999,
      "taskDurationMs": 407.117,
      "heapDeltaBytes": -15942092,
      "heapUsedBytes": 52846472,
      "domNodes": 76,
      "jsHeapTotalBytes": 20709376,
      "scriptDurationMs": 30.694000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.7219999999425,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.488999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.7129999999999999,
      "taskDurationMs": 396.65000000000003,
      "heapDeltaBytes": -16095676,
      "heapUsedBytes": 52517060,
      "domNodes": 76,
      "jsHeapTotalBytes": 20709376,
      "scriptDurationMs": 29.57,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 787.5239999999621,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.549000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.32200000000006,
      "heapDeltaBytes": -2136940,
      "heapUsedBytes": 66563772,
      "domNodes": 16,
      "jsHeapTotalBytes": 21233664,
      "scriptDurationMs": 41.598000000000006,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 756.4959999999701,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.0969999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.55500000000006,
      "heapDeltaBytes": -2189084,
      "heapUsedBytes": 66517348,
      "domNodes": 16,
      "jsHeapTotalBytes": 21495808,
      "scriptDurationMs": 39.791,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.3420000000197,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.665000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 879.972,
      "heapDeltaBytes": 4956396,
      "heapUsedBytes": 68614892,
      "domNodes": -280,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 330.356,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.05400000005,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.905000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 806.662,
      "heapDeltaBytes": 4790168,
      "heapUsedBytes": 70081816,
      "domNodes": -284,
      "jsHeapTotalBytes": 1933312,
      "scriptDurationMs": 308.196,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3863.4159999999724,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.100999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3006.442,
      "heapDeltaBytes": 21494876,
      "heapUsedBytes": 87924784,
      "domNodes": -284,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 1434.36,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3506.389000000013,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.441,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2819.381,
      "heapDeltaBytes": 22824800,
      "heapUsedBytes": 87245396,
      "domNodes": -285,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 1313.0739999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 5166.567999999984,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.424000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.4110000000000005,
      "taskDurationMs": 3176.5080000000003,
      "heapDeltaBytes": -13280040,
      "heapUsedBytes": 58454892,
      "domNodes": -264,
      "jsHeapTotalBytes": 4030464,
      "scriptDurationMs": 1522.818,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4925.613999999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.824,
      "layouts": 60,
      "layoutDurationMs": 7.254,
      "taskDurationMs": 2893.366,
      "heapDeltaBytes": -5382388,
      "heapUsedBytes": 67056676,
      "domNodes": 24,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 1389.5610000000001,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4187.787000000015,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.329,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2889.6949999999997,
      "heapDeltaBytes": -12137400,
      "heapUsedBytes": 59788440,
      "domNodes": -288,
      "jsHeapTotalBytes": 9797632,
      "scriptDurationMs": 773.499,
      "eventListeners": -108,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4195.549000000028,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.716000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2801.362,
      "heapDeltaBytes": -11606648,
      "heapUsedBytes": 59619752,
      "domNodes": -285,
      "jsHeapTotalBytes": 9797632,
      "scriptDurationMs": 738.051,
      "eventListeners": -108,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2054.079999999999,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.944999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 899.1310000000001,
      "heapDeltaBytes": -1667164,
      "heapUsedBytes": 65330800,
      "domNodes": -282,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 336.79,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.5519999999815,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.3330000000000009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 822.202,
      "heapDeltaBytes": 6071352,
      "heapUsedBytes": 73006752,
      "domNodes": -284,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 316.29799999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 756.0339999999997,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.663,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.8409999999999,
      "heapDeltaBytes": -4821508,
      "heapUsedBytes": 64372192,
      "domNodes": 16,
      "jsHeapTotalBytes": 21757952,
      "scriptDurationMs": 145.009,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 743.0679999999938,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.465,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.182,
      "heapDeltaBytes": -4885224,
      "heapUsedBytes": 64300048,
      "domNodes": 16,
      "jsHeapTotalBytes": 22282240,
      "scriptDurationMs": 137.54,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.5180000000105,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.093,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.75,
      "heapDeltaBytes": -17676508,
      "heapUsedBytes": 51552208,
      "domNodes": -297,
      "jsHeapTotalBytes": 19894272,
      "scriptDurationMs": 25.645999999999997,
      "eventListeners": -203,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2239999999374,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.507000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.504,
      "heapDeltaBytes": -20669844,
      "heapUsedBytes": 48631068,
      "domNodes": -296,
      "jsHeapTotalBytes": 19369984,
      "scriptDurationMs": 19.939,
      "eventListeners": -203,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1922.050000000013,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 42.035000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.699,
      "taskDurationMs": 1180.472,
      "heapDeltaBytes": -11789132,
      "heapUsedBytes": 57491392,
      "domNodes": -296,
      "jsHeapTotalBytes": 20418560,
      "scriptDurationMs": 126.45100000000001,
      "eventListeners": -203,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1805.9799999999768,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.111000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.008,
      "taskDurationMs": 1095.966,
      "heapDeltaBytes": -22571396,
      "heapUsedBytes": 46712800,
      "domNodes": 18,
      "jsHeapTotalBytes": 19107840,
      "scriptDurationMs": 116.513,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.1879999999337,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.191999999999997,
      "layouts": 15,
      "layoutDurationMs": 12.536999999999999,
      "taskDurationMs": 998.5239999999998,
      "heapDeltaBytes": 28365988,
      "heapUsedBytes": 92669960,
      "domNodes": 13671,
      "jsHeapTotalBytes": 12058624,
      "scriptDurationMs": 50.861000000000004,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 14668.611999999996,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 36.36000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10912.98,
      "heapDeltaBytes": 17312936,
      "heapUsedBytes": 81908076,
      "domNodes": -281,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 5069.445,
      "eventListeners": -123,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 13425.815000000057,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.296,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9928.511999999999,
      "heapDeltaBytes": 27714448,
      "heapUsedBytes": 90685560,
      "domNodes": -280,
      "jsHeapTotalBytes": 5271552,
      "scriptDurationMs": 4623.695,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18005.496999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17982.873000000003,
      "heapDeltaBytes": -26497892,
      "heapUsedBytes": 164903184,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2678784,
      "scriptDurationMs": 1256.331,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18268.103999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18245.664999999997,
      "heapDeltaBytes": -39244636,
      "heapUsedBytes": 166788200,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3203072,
      "scriptDurationMs": 1284.108,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22530.819000000007,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 23.554999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22507.097999999998,
      "heapDeltaBytes": -32663040,
      "heapUsedBytes": 159784476,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3465216,
      "scriptDurationMs": 1841.811,
      "eventListeners": -7465,
      "totalBlockingTimeMs": 740,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22723.094999999943,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 25.10899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22702.559,
      "heapDeltaBytes": -21796256,
      "heapUsedBytes": 167598780,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2940928,
      "scriptDurationMs": 1831.473,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 744,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.60099999994054,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24.958000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.4950000000000003,
      "taskDurationMs": 147.84099999999998,
      "heapDeltaBytes": -13817524,
      "heapUsedBytes": 52899580,
      "domNodes": 150,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 10.947999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 475.0649999999723,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 25.384999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.741,
      "taskDurationMs": 137.60699999999997,
      "heapDeltaBytes": -14138652,
      "heapUsedBytes": 52236144,
      "domNodes": 123,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 11.454,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                   Coverage Diff                    @@
##             feature/ecs-migration   #15018   +/-   ##
========================================================
  Coverage                         ?   81.08%           
========================================================
  Files                            ?     1898           
  Lines                            ?   109769           
  Branches                         ?    34122           
========================================================
  Hits                             ?    89007           
  Misses                           ?    20373           
  Partials                         ?      389           
Flag Coverage Δ
unit 72.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraph.ts 78.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL force-pushed the drjkl/split-graph-scoped-topology branch from 7fc5aa4 to d1fc17a Compare August 10, 2026 23:40
@DrJKL DrJKL added the refactor label Aug 10, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Reviewed as part of triaging the cloud subgraph reports. One verified defect, plus a delivery-path question.

Removing _addLink turns a hard failure into a silent link drop

In _convertToSubgraphImpl, the link.target_id === SUBGRAPH_OUTPUT_ID branch previously did this._addLink(link) before delegating to subgraphOutput.connect(...). This PR removes it, so the boundary output link now exists only if connect succeeds — but the return value is discarded, and SubgraphOutput.connect returns undefined on two paths:

  • if (!LiteGraph.isValidConnection(slot.type, this.type)) return
  • if (node.onConnectOutput?.(...) === false) return

onConnectOutput is an extension hook, so any custom node that vetoes the connection now silently loses the user's wire during Convert to Subgraph, with no warning. Before this PR the mutated link was still registered. Same shape on the input side with SubgraphInput.connect.

The slot lookup feeding those calls can be -1

subgraphNode.findOutputSlotByType(link.type, true, true) is typed as returning INodeOutputSlot, but _findSlotByType returns -1 when nothing matches (src/lib/litegraph/src/LGraphNode.ts:2643, and the doc comment at :2633 says so). SubgraphOutput.connect then does node.outputs.indexOf(slot) and throws 'Slot is not an output of the given node', aborting the conversion partway through — after nodes have already been removed from the parent graph. This is pre-existing on main, not introduced here, but this PR is the one rewriting these call sites. Worth a guard while you are in here.

Both are reachable from Convert to Subgraph, which is the operation being reported as "disconnects random wires".

Delivery path

Separately, and not a code comment: this PR is based on drjkl/split-graph-scoped-topology (#15009), which is based on feature/ecs-migration. That branch is currently 270 commits behind origin/main, and the files this stack centres on — src/stores/linkStore.ts, src/stores/rerouteStore.ts, src/stores/nodeDataStore.ts, src/lib/litegraph/src/node/slotLinks.ts, src/lib/litegraph/src/LinkMap.ts — do not exist on main and never have. So the cross-definition topology contamination #15009 fixes is not currently reaching users, and neither PR can land as the p0 patch that was committed to in #comfy-creatives without merging the whole ECS branch first.

Is the intent to retarget a minimal slice at main, or is this stack purely ECS-branch work? Asking because the p0 expectation is currently pointed at this stack, and #15002 (unpack, FE-1539) is the only piece of it that applies to main.

@DrJKL

DrJKL commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@christian-byrne I think some of your concerns are addressed in the parent PR. I'll mark these downstream ones as drafts for now.

@DrJKL
DrJKL marked this pull request as draft August 11, 2026 23:08
@DrJKL
DrJKL force-pushed the drjkl/split-link-replacement branch from 8f7ebed to fba1037 Compare August 12, 2026 07:11
@DrJKL DrJKL changed the title refactor: replace link endpoints instead of mutating identity refactor: preserve subgraph topology during unpack Aug 12, 2026
@DrJKL
DrJKL force-pushed the drjkl/split-link-replacement branch from fba1037 to c0474f9 Compare August 12, 2026 21:51
@DrJKL
DrJKL force-pushed the drjkl/split-graph-scoped-topology branch from f5da9ff to 588402b Compare August 12, 2026 21:51
@DrJKL
DrJKL force-pushed the drjkl/split-link-replacement branch 2 times, most recently from 72983e1 to 0e008c9 Compare August 13, 2026 02:37
Base automatically changed from drjkl/split-graph-scoped-topology to feature/ecs-migration August 13, 2026 18:36
@DrJKL
DrJKL force-pushed the drjkl/split-link-replacement branch from 0e008c9 to b9d4cc6 Compare August 13, 2026 18:44
@DrJKL
DrJKL force-pushed the drjkl/split-link-replacement branch from b9d4cc6 to 234ecb9 Compare August 14, 2026 02:19
@DrJKL
DrJKL marked this pull request as ready for review August 15, 2026 00:33
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 15, 2026
@DrJKL
DrJKL requested review from AustinMroz and christian-byrne and removed request for christian-byrne August 15, 2026 00:34

@AustinMroz AustinMroz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this code still scare me on a fundamental level, but I do not see any specific issue here.

@DrJKL
DrJKL merged commit b530583 into feature/ecs-migration Aug 15, 2026
74 of 75 checks passed
@DrJKL
DrJKL deleted the drjkl/split-link-replacement branch August 15, 2026 02:21
christian-byrne added a commit that referenced this pull request Aug 23, 2026
Adds e2e coverage for `Convert to Subgraph` with a **partial**
selection.

## The gap

`browser_tests/tests/subgraph/subgraphCrud.spec.ts:68` is the only e2e
test of subgraph creation. It calls `comfyPage.keyboard.selectAll()`
first, so every node is inside the selection, **there are zero boundary
links**, and the entire rewiring block in `_convertToSubgraphImpl`
(`src/lib/litegraph/src/LGraph.ts:1861-1939`) never executes. It then
asserts node counts, never link topology.

Partial selection — what users actually do — had no e2e coverage at all.
That block reconnects boundary links by positional index
(`subgraphNode.inputs[i - 1]`, `subgraphNode.outputs[i - 1]`) against a
slot array built independently in `mapSubgraphInputsAndLinks`, so a
drift there is silent.

## What it does

Packs `KSampler` + `VAE Decode` out of the default workflow and asserts:

- the exact post-conversion link table, with the new subgraph node
rendered as `HOST` (five boundary inputs rewired onto it, one boundary
output to SaveImage, and the two `CheckpointLoaderSimple → CLIP` links
that lie entirely outside the selection left untouched)
- every rewired link lands on a type-compatible slot
- the result survives a serialize/reload round trip

## Status — currently red, cause not yet established

Please do not read the red as a confirmed product bug yet; I do not want
to overstate it.

The first run failed, but **my expected link count was wrong** (I
asserted six root links and forgot the two external-only CLIP links; the
correct total is eight). That error is fixed in `0566c82c5a`, which now
asserts the full topology rather than a count.

What the first run reported that is *not* explained by my arithmetic
error, and is still open:

- the `4:2` VAE boundary link was absent from the links targeting the
host
- one host input slot was left unconnected
- SaveImage's input was not fed by the host
- nine root links, where the corrected expectation is eight

Against that, a faithful unit-level reduction of the same graph shape
(same node/slot/type layout, same selection) **passes**: all five host
inputs connect, SaveImage is fed by the host, and the link count is
eight. So either the trigger is something the reduction lacks (real node
defs, widget-backed inputs, the app's `SubgraphNode` registration path),
or the browser selection was not the two nodes I assumed. The corrected
assertion prints the actual table on failure, which should settle it on
the next run.

I have deliberately **not** written a fix. Test-only PR.

## Related

- Does **not** overlap
#15002 (subgraph
**unpack**, FE-1539 — different action, different code path
`_unpackSubgraphImpl`).
- Does **not** overlap
#15009 /
#15018, which are
based on `feature/ecs-migration` and change `src/stores/linkStore.ts` /
`rerouteStore.ts` — files that do not exist on `main`.
- Does **not** overlap
#14569 (preview/output
display only).

---------

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: DrJKL <DrJKL0424@gmail.com>
Co-authored-by: Amp <amp@ampcode.com>
balpreetgrowthnatives pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 24, 2026
## Summary

Still-draft feature branch for migrating entity state from LiteGraph
objects and runtime mirrors into dedicated stores with derived, reactive
views.

This consolidates the reviewed ECS migration slices, strengthens their
coverage, incorporates the layout-state follow-up, and documents the
current migration status and remaining work.

## Changes

- Move widget values and node shell state into dedicated stores.
- Make link topology the source of truth for connectivity.
- Store reroute chains while deriving membership and floating-link
state.
- Derive widgeted input connectivity, badges, and promoted widget rows
from store-backed state.
- Remove the input and output runtime link mirrors.
- Keep DOM measurements separate from persisted node layout state.
- Add migration coverage, extension guidance, and architecture/status
documentation.

Reviewed PRs merged into this feature branch:

- [Comfy-Org#13322 — Move widgets out of node
data](Comfy-Org#13322)
- [Comfy-Org#13434 — Host-scoped promoted widget
rows](Comfy-Org#13434)
- [Comfy-Org#13436 — Link topology
store](Comfy-Org#13436)
- [Comfy-Org#13449 — Reroute chain
store](Comfy-Org#13449)
- [Comfy-Org#13451 — Derived floating links and reroute
cleanup](Comfy-Org#13451)
- [Comfy-Org#13455 — Store-backed widgeted input
connectivity](Comfy-Org#13455)
- [Comfy-Org#13458 — Badge store and
system](Comfy-Org#13458)
- [Comfy-Org#13479 — Remove the output-link runtime
mirror](Comfy-Org#13479)
- [Comfy-Org#13498 — Remove the input-link runtime
mirror](Comfy-Org#13498)
- [Comfy-Org#13528 — Cross-stack migration audit
fixes](Comfy-Org#13528)
- [Comfy-Org#13686 — Derive badges on
read](Comfy-Org#13686)
- [Comfy-Org#13963 — Node data
store](Comfy-Org#13963)
- [Comfy-Org#14110 — Centralize node, group, and reroute
geometry](Comfy-Org#14110)
- [Comfy-Org#14128 — Register node geometry at
attach](Comfy-Org#14128)
- [Comfy-Org#14133 — Read node geometry from the
store](Comfy-Org#14133)
- [Comfy-Org#14758 — Keep DOM measurements out of saved node
sizes](Comfy-Org#14758)
- [Comfy-Org#15001 — Extract entity ID
allocation](Comfy-Org#15001)
- [Comfy-Org#15009 — Scope link and reroute topology by owning
graph](Comfy-Org#15009)
- [Comfy-Org#15017 — Centralize layout ownership and command
submission](Comfy-Org#15017)
- [Comfy-Org#15018 — Preserve subgraph topology during
unpack](Comfy-Org#15018)
- [Comfy-Org#15019 — Transfer node ownership during
replacement](Comfy-Org#15019)
- [Comfy-Org#15330 — Map migration status and remaining
work](Comfy-Org#15330)

## Review Focus

- Store ownership and synchronization boundaries.
- Serialization, undo/redo, subgraph, and extension compatibility.
- Whether remaining direct entity state should migrate before this
feature leaves draft.

## Status

Still draft. The branch is rebased onto `main`; CI is running against
the rebased history.

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Matt Miller <mattmiller@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants