Repository navigation
fix(missing-model): restrict localhost downloads - #14983
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1804 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.69 MB gzip 🟢 -98 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • 🔴 +274 BBundles that do not match a named category
Status: 68 added / 68 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-11T04:32:59.908Z",
"gitSha": "f5f5577c212202acc29180a834ec313cf791c4dc",
"branch": "jaeone94/fix-14350-localhost-probing",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2119.5209999999634,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.789,
"heapDeltaBytes": 5889768,
"heapUsedBytes": 70189036,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 24.822,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2031.878000000006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2730000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.185,
"heapDeltaBytes": 5910680,
"heapUsedBytes": 70297340,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 26.022999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1984.1490000000022,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.45,
"layouts": 12,
"layoutDurationMs": 3.945,
"taskDurationMs": 1019.679,
"heapDeltaBytes": 566616,
"heapUsedBytes": 65036080,
"domNodes": 57,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 135.443,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.813999999993,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.215,
"layouts": 12,
"layoutDurationMs": 4.014,
"taskDurationMs": 917.16,
"heapDeltaBytes": 232940,
"heapUsedBytes": 64574080,
"domNodes": 57,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 131.445,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.9539999999743,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.938000000000002,
"layouts": 6,
"layoutDurationMs": 0.722,
"taskDurationMs": 413.78800000000007,
"heapDeltaBytes": 8816356,
"heapUsedBytes": 73262320,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 23.419000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.4790000000548,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.569000000000003,
"layouts": 6,
"layoutDurationMs": 0.6779999999999998,
"taskDurationMs": 441.816,
"heapDeltaBytes": 8782308,
"heapUsedBytes": 73181344,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 26.517000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 590.9130000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.314,
"heapDeltaBytes": -10858628,
"heapUsedBytes": 53429632,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.699000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 609.3930000000682,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.841999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.882,
"heapDeltaBytes": -10976040,
"heapUsedBytes": 53139332,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 64.743,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.781000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.165000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 820.002,
"heapDeltaBytes": 6899368,
"heapUsedBytes": 66312552,
"domNodes": -284,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 129.495,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.0390000000352,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.288,
"heapDeltaBytes": 7159632,
"heapUsedBytes": 66775620,
"domNodes": -283,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 133.64100000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2278.132000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1375.05,
"heapDeltaBytes": 5004208,
"heapUsedBytes": 65846500,
"domNodes": -286,
"jsHeapTotalBytes": 3440640,
"scriptDurationMs": 457.687,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2249.863000000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.374000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1398.677,
"heapDeltaBytes": 4772052,
"heapUsedBytes": 65418592,
"domNodes": -285,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 457.949,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3198.835000000031,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.865,
"layouts": 60,
"layoutDurationMs": 7.528,
"taskDurationMs": 1533.403,
"heapDeltaBytes": -1983020,
"heapUsedBytes": 60168820,
"domNodes": -288,
"jsHeapTotalBytes": 6656000,
"scriptDurationMs": 542.71,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3412.90099999992,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.741999999999997,
"layouts": 60,
"layoutDurationMs": 7.875,
"taskDurationMs": 1644.364,
"heapDeltaBytes": 395200,
"heapUsedBytes": 62780444,
"domNodes": 10,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 596.11,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.2009999999777,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.695000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.555,
"heapDeltaBytes": 10047204,
"heapUsedBytes": 70838356,
"domNodes": -284,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 127.49199999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.0879999999743,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.5100000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.922,
"heapDeltaBytes": 6945592,
"heapUsedBytes": 68231336,
"domNodes": -284,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 136.553,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.7919999999926,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.428,
"heapDeltaBytes": -10754184,
"heapUsedBytes": 53658864,
"domNodes": 18,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 119.45199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.7529999999742,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.029,
"heapDeltaBytes": -10290324,
"heapUsedBytes": 54070020,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 126.56700000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2025.63200000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.0450000000001,
"heapDeltaBytes": 5674660,
"heapUsedBytes": 70047020,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 21.587999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.8029999999817,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.008000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.4540000000001,
"heapDeltaBytes": -18260192,
"heapUsedBytes": 46078440,
"domNodes": -279,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 22.441000000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.8080000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.34799999999999,
"layouts": 16,
"layoutDurationMs": 4.196,
"taskDurationMs": 864.568,
"heapDeltaBytes": -17617096,
"heapUsedBytes": 46734568,
"domNodes": -278,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 102.351,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.9100000000326,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.231,
"layouts": 16,
"layoutDurationMs": 4.676,
"taskDurationMs": 881.94,
"heapDeltaBytes": -18221492,
"heapUsedBytes": 46121332,
"domNodes": -280,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 102.622,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.1000000000186,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.116000000000003,
"layouts": 14,
"layoutDurationMs": 13.027000000000001,
"taskDurationMs": 1034.328,
"heapDeltaBytes": 6677332,
"heapUsedBytes": 98689020,
"domNodes": 13673,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 40.548999999999985,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.791999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4685.16,
"heapDeltaBytes": 5088476,
"heapUsedBytes": 64715728,
"domNodes": -281,
"jsHeapTotalBytes": 4489216,
"scriptDurationMs": 1424.418,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8955.494000000044,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.181000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5030.913,
"heapDeltaBytes": 11930376,
"heapUsedBytes": 71383860,
"domNodes": -281,
"jsHeapTotalBytes": 5013504,
"scriptDurationMs": 1519.9989999999998,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17443.283000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17415.844,
"heapDeltaBytes": -43255136,
"heapUsedBytes": 177756712,
"domNodes": -8320,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 605.162,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17743.167000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17722.609,
"heapDeltaBytes": -34495988,
"heapUsedBytes": 170970120,
"domNodes": -8312,
"jsHeapTotalBytes": -2039808,
"scriptDurationMs": 631.923,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21381.099000000064,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21325.036999999997,
"heapDeltaBytes": -70217308,
"heapUsedBytes": 155873704,
"domNodes": -8311,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 969.6600000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 356,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21734.992000000035,
"styleRecalcs": 151,
"styleRecalcDurationMs": 20.604999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21672.518,
"heapDeltaBytes": -60854004,
"heapUsedBytes": 153980608,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 937.622,
"eventListeners": -16379,
"totalBlockingTimeMs": 384,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 111.7619999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.569,
"layouts": 2,
"layoutDurationMs": 0.549,
"taskDurationMs": 83.89900000000002,
"heapDeltaBytes": 3077072,
"heapUsedBytes": 66573376,
"domNodes": 109,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.231999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 473.03099999999176,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.584,
"layouts": 2,
"layoutDurationMs": 0.34400000000000014,
"taskDurationMs": 115.544,
"heapDeltaBytes": 5047204,
"heapUsedBytes": 68451360,
"domNodes": 123,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.813,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change removes broad localhost URL matching, adds explicit model URL allowlisting, blocks disallowed metadata and download requests, and updates component, browser, and platform tests. ChangesMissing model URL security
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14983 +/- ##
==========================================
- Coverage 80.88% 80.31% -0.58%
==========================================
Files 1872 1872
Lines 123407 117399 -6008
Branches 37867 35692 -2175
==========================================
- Hits 99823 94289 -5534
+ Misses 23025 22614 -411
+ Partials 559 496 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 228 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
|
|
|
ELI5
A workflow can suggest model download locations, but the browser should not treat every door on a local machine as safe. This PR narrows the localhost exception to the exact devtools fixture URL and checks the address before any metadata probe or download handoff.
Motivation
Missing-model URLs come from workflow data. The previous
startsWithallowance accepted any URL beginning withhttp://localhost:, which could cause browser-side HEAD requests to arbitrary local ports when evaluating an untrusted workflow. The same boundary feeds native download branches, so validation needs to happen before browser, Desktop2, or Electron dispatch. The devtools workflow fixture still needs one narrow localhost exception, while established public model providers must continue to work.Provenance
pnpm test:unit src/platform/missingModel/missingModelDownload.test.ts src/platform/missingModel/components/MissingModelRow.test.ts(79 passed);pnpm test:browser:local browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts(11 passed);pnpm typecheck;pnpm typecheck:browser;pnpm lint;pnpm knip;pnpm format:check;git diff origin/main...HEAD --check(all passed)Reviewer context
Summary
http://localhost:8188/api/devtools/fake_model.safetensors.Changes
Review Focus
Review the exact URL boundary, guard placement before every metadata and download sink, and preservation of existing provider flows.
Test plan
Fixes #14350