Repository navigation
ci: unbreak validate-action-pins - #14963
christian-byrne wants to merge 1 commit into
Conversation
`.pinact.yaml` allowlists `actions/download-artifact` at `v8` only, so an unpinned `@v7` fails the check: ##[error] uses: actions/download-artifact@37930b1... # v7.0.0 .github/workflows/ci-tests-e2e.yaml:263 ##[error]GitHub Actions aren't pinned. Dependabot #14000 bumped 7 -> 8 across the workflows and moved the allowlist with it; #14560 then added a new step still on `@v7`. `validate-pins` only runs when workflow files change, so `main` stayed green and the breakage surfaced one PR at a time - four unrelated branches failed it in a two-hour window. `@v8` is what every other `download-artifact` step in the repo already uses, so this restores consistency rather than introducing a new version.
🎭 Playwright: ✅ 1788 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 8.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 570 kB (baseline 570 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • ⚪ 0 BBundles that do not match a named category Status: 286 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-09T04:09:45.831Z",
"gitSha": "eeb33e9d7d169509e3bea914babb5d6b50b47574",
"branch": "fix/unbreak-validate-action-pins",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2169.4439999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.726,
"heapDeltaBytes": -18609676,
"heapUsedBytes": 45550672,
"domNodes": -283,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 22.917,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.8170000000318,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.16400000000004,
"heapDeltaBytes": 6039108,
"heapUsedBytes": 70270860,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 17.352,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2093.166999999994,
"styleRecalcs": 80,
"styleRecalcDurationMs": 47.692,
"layouts": 12,
"layoutDurationMs": 3.8409999999999997,
"taskDurationMs": 1075.2769999999998,
"heapDeltaBytes": -12766660,
"heapUsedBytes": 51549264,
"domNodes": -279,
"jsHeapTotalBytes": 24092672,
"scriptDurationMs": 140.853,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.5229999999856,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.499,
"layouts": 12,
"layoutDurationMs": 3.662,
"taskDurationMs": 823.057,
"heapDeltaBytes": 436640,
"heapUsedBytes": 64851292,
"domNodes": 58,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 123.08400000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.6390000000638,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.493000000000002,
"layouts": 6,
"layoutDurationMs": 0.5739999999999998,
"taskDurationMs": 398.89,
"heapDeltaBytes": 8579940,
"heapUsedBytes": 72836448,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 22.793,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.7890000000734,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.286999999999995,
"layouts": 6,
"layoutDurationMs": 0.6809999999999999,
"taskDurationMs": 391.881,
"heapDeltaBytes": 8568644,
"heapUsedBytes": 72828564,
"domNodes": 78,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 20.775000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 573.0419999999867,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.2570000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.20500000000004,
"heapDeltaBytes": -11410320,
"heapUsedBytes": 53224132,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 62.695,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 574.5969999999261,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.662,
"heapDeltaBytes": -11258380,
"heapUsedBytes": 53186372,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 59.81499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2009.2019999999593,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.874999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.4459999999999,
"heapDeltaBytes": 3746080,
"heapUsedBytes": 64206328,
"domNodes": -284,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 117.703,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.5000000000182,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.814000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.0699999999999,
"heapDeltaBytes": 7794640,
"heapUsedBytes": 67909056,
"domNodes": -282,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 110.522,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2205.703999999969,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1338.741,
"heapDeltaBytes": -5863344,
"heapUsedBytes": 55242256,
"domNodes": -284,
"jsHeapTotalBytes": 5607424,
"scriptDurationMs": 436.121,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.9630000000616,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.652999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1315.199,
"heapDeltaBytes": 1654460,
"heapUsedBytes": 62183448,
"domNodes": -286,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 431.664,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3246.9730000000254,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.383999999999997,
"layouts": 60,
"layoutDurationMs": 8.271,
"taskDurationMs": 1542.781,
"heapDeltaBytes": 1507316,
"heapUsedBytes": 63611112,
"domNodes": -288,
"jsHeapTotalBytes": 6656000,
"scriptDurationMs": 540.9200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3195.9190000000035,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.431999999999997,
"layouts": 60,
"layoutDurationMs": 7.622999999999999,
"taskDurationMs": 1515.7019999999998,
"heapDeltaBytes": 23468648,
"heapUsedBytes": 85773260,
"domNodes": 10,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 542.404,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0700000000088,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.043000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 737.565,
"heapDeltaBytes": 6754456,
"heapUsedBytes": 67143724,
"domNodes": -281,
"jsHeapTotalBytes": 2723840,
"scriptDurationMs": 119.65800000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.1999999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.789000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.3470000000001,
"heapDeltaBytes": 6295720,
"heapUsedBytes": 66804032,
"domNodes": -284,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 117.18,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.6079999999665,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.716999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.54,
"heapDeltaBytes": -10707084,
"heapUsedBytes": 53508028,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 124.091,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.7149999999037,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.53799999999995,
"heapDeltaBytes": -10737460,
"heapUsedBytes": 53894208,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 122.38700000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.931999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.148000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.08099999999996,
"heapDeltaBytes": 5832936,
"heapUsedBytes": 70054652,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.130999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1999.2879999999786,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.483000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.27599999999995,
"heapDeltaBytes": 5933868,
"heapUsedBytes": 70080164,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 15.161000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.7590000000573,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.02100000000001,
"layouts": 16,
"layoutDurationMs": 4.4879999999999995,
"taskDurationMs": 799.9069999999999,
"heapDeltaBytes": -3892140,
"heapUsedBytes": 60581000,
"domNodes": 60,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 94.833,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.8509999999915,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.365,
"layouts": 16,
"layoutDurationMs": 4.511,
"taskDurationMs": 776.762,
"heapDeltaBytes": -3357724,
"heapUsedBytes": 61048672,
"domNodes": 63,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 94.09600000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1421.7409999999973,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.203999999999997,
"layouts": 14,
"layoutDurationMs": 12.632000000000001,
"taskDurationMs": 950.1650000000002,
"heapDeltaBytes": 3949240,
"heapUsedBytes": 76571020,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 37.64099999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.163999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.055,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4585.715999999999,
"heapDeltaBytes": 5536212,
"heapUsedBytes": 65448612,
"domNodes": -283,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1402.96,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8283.777999999984,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.029999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4535.264,
"heapDeltaBytes": 11475076,
"heapUsedBytes": 70851368,
"domNodes": -282,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1400.723,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17357.734999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17321.670000000002,
"heapDeltaBytes": -59311000,
"heapUsedBytes": 167169360,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 595.7940000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17510.022000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17475.114,
"heapDeltaBytes": -46622680,
"heapUsedBytes": 183372988,
"domNodes": -8312,
"jsHeapTotalBytes": -7282688,
"scriptDurationMs": 591.7,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20834.810000000063,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.200999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20770.472,
"heapDeltaBytes": -65733096,
"heapUsedBytes": 158786816,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 904.382,
"eventListeners": -16381,
"totalBlockingTimeMs": 147,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21167.338000000087,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.708000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21095.341999999997,
"heapDeltaBytes": -23427272,
"heapUsedBytes": 176767176,
"domNodes": -8316,
"jsHeapTotalBytes": -9973760,
"scriptDurationMs": 945.2360000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 320,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.7249999999585,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.238,
"layouts": 4,
"layoutDurationMs": 1.42,
"taskDurationMs": 120.456,
"heapDeltaBytes": 5181744,
"heapUsedBytes": 68746488,
"domNodes": 126,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.994,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 506.21699999999237,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.970999999999997,
"layouts": 3,
"layoutDurationMs": 0.6950000000000001,
"taskDurationMs": 123.11999999999999,
"heapDeltaBytes": 5053180,
"heapUsedBytes": 68495148,
"domNodes": 119,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.815,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe end-to-end test workflow updates the frontend artifact download action from ChangesCI workflow update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14963 +/- ##
========================================
Coverage 80.78% 80.78%
========================================
Files 1871 1871
Lines 121234 121234
Branches 36326 35866 -460
========================================
Hits 97937 97937
Misses 22745 22745
Partials 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Looks superseded by #14950 — can we close this? |
|
Redundant — closing.
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1so Every |
validate-pinsis failing for anyone who touches a workflow file.pinact.yamlallowlistsactions/download-artifactatv8only:so the lone
@v7step is neither allowlisted nor SHA-pinned, and fails.How it got in
download-artifact7 → 8 across the workflowsand moved the
.pinact.yamlallowlist tov8.@v7.validate-pinsonly runs when workflow files change, somainstayed green andthis surfaced one PR at a time instead of once. Four unrelated branches failed
it inside a two-hour window (
ci__harden-core-release,cb__release-stranded-guard,fix/e2e-coverage-sourcemap-url,glary/design-system-brand-yellow-f2ff59), plus #14682.The change
One line,
@v7→@v8. Every otherdownload-artifactstep in the repo isalready on
v8— after this, all 12 usages agree:So this restores consistency rather than introducing a version.
Relationship to #14950
#14950 contains this same one-line fix, but alongside the E2E coverage
source-mapping work, and its approval has since been dismissed — so it is not
close to landing. Extracting the fix so the repo-wide breakage isn't gated on
that review. Whichever lands first, the other's hunk drops out.
Same pattern as #14959, which fixed the sibling
mainbreakage that wasejecting every PR from the merge queue.