Repository navigation
fix: gate billing recovery banners on payment recovery - #14909
dante01yoon wants to merge 63 commits into
Conversation
## Summary Pin the node display names that Playwright goldens capture, so screenshots stop tracking whatever ComfyUI build the CI container happens to ship — and make the failure mode legible when a pinned node type goes missing. ## Changes - **What**: - New `setNodeDisplayName(objectInfo, nodeType, displayName)` mutator in `browser_tests/fixtures/utils/objectInfo.ts`, alongside `setStringInputTooltip` / `setComboInputOptions`. - `imageCompare.spec.ts` pins `ImageCompare` -> `Image Compare`; `nodeBadge.spec.ts` pins `ImageBatch` -> `Batch Images`. - Both install the stub by extending the `page` fixture, so the route is live before `comfyPage.setup()` boots the node-definition store. That is the same pattern as `propertiesPanel/errorsTabModeAware.spec.ts` and avoids the extra `reloadAndWaitForApp()` that `widgetTooltip.spec.ts` needs when routing mid-test. - **Pre-existing bug fix:** `routeObjectInfoFromSetupApi` only wrapped the fetch and JSON parse in a `try`. A throwing `customize` callback rejected the route handler, so `route.fulfill` never ran and the request hung — the test then died on an opaque Playwright timeout rather than reporting the cause. The mutators throw precisely when a node type is missing from `/object_info`, which is what a container bump triggers, so shipping the pins without this would turn "node was renamed upstream" into a mystery hang. `customize` is now guarded and fulfills a 500 naming the failure, with the message logged to test output. No baselines were regenerated. The pinned strings are the ones the committed PNGs already encode, so the images are byte-identical to `main`. ## Review Focus Since #14541, English node titles resolve from the backend `/object_info` rather than from a bundled file. That makes every golden containing a node header a function of the CI container image, which is pinned to `ghcr.io/comfy-org/comfyui-ci-container:0.0.21` (ComfyUI v0.19.3) in four workflows: `ci-tests-e2e.yaml:57` and `:115`, `pr-update-playwright-expectations.yaml:84`, `ci-perf-report.yaml:34`. `0.0.22` (ComfyUI v0.30.0) already exists in the registry, and whoever bumps the pin currently gets unrelated node-title screenshot diffs with nothing in-repo explaining them. This makes that bump safe. The chosen strings are not guesses. #14541 itself re-baselined these goldens, so they encode the container's names, and the rename is visible in the diff of that commit: in `image-compare-default-50`, the title descenders move from `p` at x=60 / `g` at x=112 (bundled `Compare Images`) to `g` at x=56 / `p` at x=98 (container `Image Compare`). `Batch Images` is legible directly in `node-lifecycle-*`. No unit test covers the hang fix: `browser_tests/**` is outside vitest's `include` globs (`src/`, `packages/`, `scripts/`), and widening them would sweep the Playwright `.spec.ts` files into `pnpm test:unit`. Exercising the path for real needs a running ComfyUI backend. Still coupled to the container, deliberately out of scope here: the `api-pricing-*` goldens (title `Flux 1.1 [pro] Ultra Image`, from `FluxProUltraImageNode`) and `node-badge-*` (titles from the `nodes/execution_error` workflow). Same fix applies if we want them covered. Fixes #14630 --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org>
> **Stacked PR 4 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w. ## Changes - **What**: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge. - Moves the terms copy — previously duplicated verbatim in both auth views — into `CloudTermsNotice`, shown via a `showTermsNotice` route meta. Other cloud routes keep the existing link footer. ## Review Focus `route.meta.showTermsNotice` swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps `CloudTemplateFooter` exactly as before, asserted at the route level in `onboardingCloudRoutes.test.ts`. Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width. Stacked on the auth panel PR.
#14747) ## Summary Widget labels, socket labels, output names, node descriptions and tooltips now resolve from the live `/object_info` response instead of the bundled `en/nodeDefs.json` snapshot, so a backend rename no longer leaves a new node title beside old widget labels and old tooltips. ## Changes - **What**: `resolveNodeDefInputText()` / `resolveNodeDefOutputText()` (`src/i18n.ts`) extend the precedence introduced in #14541 to slot text. They own all `nodeDefs.*.inputs|outputs.*` key construction and apply the same per-locale order: | locale | order | | ------ | ---------------------------------------------------------------------------------------- | | `en` | custom-node `/api/i18n` -> backend `/object_info` -> bundled snapshot -> caller fallback | | other | custom-node `/api/i18n` -> bundled snapshot -> backend -> caller fallback | The existing `resolveNodeDefText` and the new slot resolvers share one core (`resolveNodeDefPath`), which now takes the message reader as a parameter — the only behavioural difference between a name and a tooltip. - **What**: Call sites moved onto the resolvers: - `litegraphService.addInputWidget` — `widget.label` and the widget's socket `localized_name` - `litegraphService.addInputSocket` — socket `localized_name` - `litegraphService.addOutputs` — output `localized_name` (the `dataTypes.*` branch, used when the output name equals its type, is unchanged) - `NodeTooltip.vue` — input slot, output slot and widget tooltips - `useNodeTooltips.ts` — input slot, output slot and widget tooltips - **What**: `useNodeTooltips.getNodeDescription` no longer re-resolves the description against the snapshot. `getNodeDefs()` has already resolved it, so wrapping it in `st()` let the stale bundled value win. - **Breaking**: None. ## Review Focus - **The raw/compiled split is the risk in this PR.** `scripts/nodeDefLocaleSerializer.ts` escapes `name` and leaves `tooltip` verbatim, because tooltips are read through `stRaw`/`tm()` uncompiled — an escaped `{'@'}` would render literally to the user. `slotMessageReader()` is the single place that picks `st` vs `stRaw`, keyed on the field. Nothing new is escaped at runtime, and no backend value is merged into the vue-i18n message tree. - Widget labels previously always came from the snapshot, whose `inputs.*.name` is the raw input name rather than `display_name` — so a backend `display_name` on an input was never shown. It now is. Where the backend sends no `display_name` the snapshot still applies, which is the existing behaviour. - Tests are verified by mutation, not by inspection, because `st()` swallows a vue-i18n `SyntaxError` and falls back to the raw stored message — a fixture with a throwing character passes either way. The `raw / compiled split` fixture uses `50{'%'} {'@'}`, which compiles cleanly, so `name` -> `50% @` and `tooltip` -> `50{'%'} {'@'}` genuinely diverge. Forcing either reader in both directions fails that test; dropping the `en` backend bypass, the custom-node precedence, or the backend fallback each fails a distinct test; passing `undefined` for the backend value at each of the seven call sites fails the test covering it. Fixes #14631 Co-authored-by: Connor Byrne <c.byrne@comfy.org>
…stalls accurately (#14556) Splits out of #14251. Five lifecycle fixes on the A1111 image-import path. 30 production lines. ## What Dropping an A1111-generated PNG parses its `parameters` string and builds a ComfyUI graph from it. The path had four defects that only show up when something goes wrong, plus one that shows up always: 1. **`afterLoadNewGraph` was not awaited.** It suspends before the active workflow is reassigned, so `rootGraph.serialize()` on the next line captured the *outgoing* graph — the new tab was born dirty against a stale baseline. 2. **A rejection escaped an async DOM handler.** `importA1111` awaits `api.getEmbeddings()`, which does not check `resp.ok`. On a 500 with an HTML body it throws, `fileInput.value = ''` never runs, the input still holds the file, re-selecting it fires no `change` event, and Open silently does nothing on every retry. Now: `try`/`catch` with a toast, `finally` resets the input. 3. **Two identical alerts for one file.** The invalid-structure `else` and the parse `catch` each called `showErrorOnFileLoad`, then fell through to the final call at the end of `handleFile`. Those two are the `else` and `catch` of one `try`, so the maximum is two alerts, not three. 4. **`beforeLoadNewGraph()` ran before an import that might bail.** It calls `domWidgetStore.clear()`, and nothing re-registers on a bail path — a workflow with a multiline prompt on screen lost its DOM widget overlays when the user dropped a PNG that did not parse. It now runs immediately before the mutation, and the A1111 path gets the subgraph guard `clean()` already had. 5. **No message at all when required node types are unavailable, and silent corruption of the open workflow.** `importA1111` logged to the console and returned `void`. Because the call was unawaited, `afterLoadNewGraph` then registered the user's *unchanged* graph under the dropped file's name, after `beforeLoadNewGraph` had already cleared `domWidgetStore`. See below. ## The message The seven types this importer needs — `CheckpointLoaderSimple`, `CLIPSetLastLayer`, `CLIPTextEncode`, `KSampler`, `EmptyLatentImage`, `VAEDecode`, `SaveImage` — are all **core nodes**, as are `LoraLoader` and the hires chain. Their absence does not mean a node pack is missing. It means the backend did not load, or the install is broken. So this path deliberately writes nothing to the missing-node panel: no card, no entry, no placeholder. A type that was never added to the graph does not belong in a list of nodes missing *from the graph*, and naming the individual types would read as "install this pack" and send people looking for something that does not exist. ``` "Could not load the workflow because this ComfyUI installation is missing core nodes. Check that the backend started correctly." ``` `importA1111` returns `Promise<'imported' | 'not-a1111' | 'core-nodes-unavailable'>` — three string literals, replacing `Promise<boolean>`. The boolean could not distinguish "bailed and already told the user" from "bailed silently", which is how an ordinary A1111 PNG could vanish with no feedback at all: A1111 omits the `Negative prompt:` line entirely when the negative prompt is empty. The `core-nodes-unavailable` return happens **before** the graph is touched, so a failed import leaves the open workflow intact. `pnginfo.test.ts` asserts that directly. ## What this deliberately does not do `pnginfo.ts` is **+8 −4**, with zero re-indentation (`git diff` and `git diff -w` report the same line count). The nesting in that file is not pretty and it is not this PR's business. An earlier revision restructured it; that diff was 759 lines, ~72% of it re-indentation, and none of it fixed a bug. If it deserves a refactor it deserves a PR where a reviewer sees only that. ## Verification 6 unit tests across `app.test.ts`, `pnginfo.test.ts` and `ui.test.ts`, each mutation-proved. typecheck, lint, format, knip clean. Full unit suite: only pre-existing timeout flakes, confirmed by re-running the same files at the merge base and getting byte-identical results. ## Related - Follow-up to #14251 (closed) - Independent of #14555 and of the narrow submission fix — no ordering constraint
I will refactor the entire keybinding system later, this is a hotfix for the cloud/1.49 release ## Summary Block legacy canvas undo/redo shortcuts while a modal is open. This follows up on #14024: command keybindings were guarded there, but `ChangeTracker` handles Ctrl/Cmd+Z independently in a capture-phase listener and could still restore workflow state behind a dialog. ## Changes - **What**: Share the existing modal predicate with `ChangeTracker` and add focused unit regression coverage for the real window shortcut path. ## Review Focus Confirm the modal check runs synchronously before `ChangeTracker` schedules undo/redo work, while popover content remains excluded from modal detection. ## Validation - `pnpm test:unit src/scripts/changeTracker.test.ts src/platform/keybindings/keybindingService.dialog.test.ts` (65 passed) - Pre-commit: oxfmt, type-aware oxlint, ESLint, and `pnpm typecheck` - Pre-push: `pnpm knip`
<!-- ccr-slack-attribution --> _Requested by **June** · [Slack thread](https://comfy-organization.slack.com/archives/C09NWURUPMF/p1785882398589369?thread_ts=1785882398.589369&cid=C09NWURUPMF)_ ## Summary Adds Instagram and X (Twitter) links to the site footer, directly under the existing YouTube link. ## Changes - **What**: The footer's "Resources" link list now shows Instagram and X below YouTube, using the site's existing profile URLs (`externalLinks.instagram`, `externalLinks.x`) and existing `nav.instagram` / `nav.x` translation strings. Before: footer listed Blog, Discord, GitHub, Docs, YouTube, Affiliate Program. After: the same list with Instagram and X inserted between YouTube and Affiliate Program. Both links open in a new tab with the same external-link arrow icon and hover styling as the other footer links (no new icon component — the site's footer links are text-based, not icon-based, so this follows that existing pattern). - **Fix (unrelated, pre-existing)**: `apps/website/e2e/minimax.spec.ts` accessed `minimaxPage.faq.items` directly, but `faq` is typed as optional on `ModelLaunchPage`. This was already broken on `main` (verified via `git stash`) and isn't covered by any CI workflow, but it blocks the repo's `apps/website` pre-commit typecheck hook for any commit touching this app, so it's fixed here with a one-line non-null assertion consistent with existing usage elsewhere in the same test suite. ## How - `apps/website/src/components/common/SiteFooter.vue`: added two entries (Instagram, X) to the `topColumns` "Resources" links array, right after the YouTube entry. - `apps/website/e2e/minimax.spec.ts`: one-line non-null assertion fix, unrelated to the footer change (see above). ## Review Focus - Confirm Instagram/X are meant to sit in the "Resources" column alongside Discord/GitHub/YouTube rather than a separate "Company"/"Contact" column. - `externalLinks.instagram` and `externalLinks.x` already existed in `src/config/routes.ts` (used in the header nav's Community dropdown) and are clean profile URLs already, with no UTM/tracking params. ## Screenshots (if applicable) <img width="1789" height="669" alt="image" src="https://github.com/user-attachments/assets/6fea0b81-d2e1-4a6a-ae47-431ab032cda2" /> --------- Co-authored-by: Claude <noreply@anthropic.com>
Remove direct dependencies fallow flagged as never imported. No install-graph capability is lost: the primeuix/primevue packages remain available transitively via `primevue`, and `jiti` remains via `eslint`. Removed: - `@primeuix/forms`, `@primeuix/styled`, `@primevue/icons` (transitive via primevue) - `jiti` (transitive via eslint; only used to load the TS eslint config) - stale `@types/eslint: '-'` override (nothing requests `@types/eslint`) - the three removed packages from `knip.config.ts` ignoreDependencies Kept after verification (fallow false positives): - `eslint-plugin-playwright` — registered in `.oxlintrc.json` `jsPlugins` - `postcss-html` — `.stylelintrc.json` `customSyntax` - `@iconify-json/lucide` — design-system `loadIconSet` at build time Gates: `pnpm install` clean (catalog auto-pruned), lint / typecheck / knip pass. Stacked PR (bottom of series). Base: `drjkl/fallow` (adds the fallow dev dependency). --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Amp <amp@ampcode.com>
All 22 usages across 19 files were pinned to `fc06bc12`. Three reasons to move: **It predates pnpm v11 support.** That landed in the action's `v6.0.0`. This repo runs pnpm `11.13.1`. We have been running an action that does not officially support our package manager version. **The version comment is wrong.** `fc06bc12` carries *both* the `v4.4.0` and `v5.0.0` tags, so `# v4.4.0` understates what is actually pinned. Anyone auditing the pin gets a misleading answer. **It is the specific commit a pnpm maintainer fingered for OIDC publish failures.** In [pnpm/pnpm#11513](pnpm/pnpm#11513), `pnpm publish` with trusted publishing failed with a 404; zkochan replied "The issue might be related to `pnpm/action-setup@fc06bc12…`. We had some issues with this action." The reporter moved to `v6.0.6` and it worked. That issue is closed, but nothing in pnpm itself fixed it — the fix was the action bump, and we still pin the bad commit. That last point is why this matters now: #14430 grants `id-token: write` for design-system trusted publishing, but if this pin is what was breaking OIDC, that change alone will not be enough. This also affects `desktop-ui`, `desktop-bridge-types`, and `npm-types`, which publish through the same action. Mechanical change — SHA and comment only, no inputs touched. `v5.0.0` moved the action to Node 24; `v6.0.0` added pnpm 11 support. Neither changes the input surface. Unrelated thing spotted while surveying, not changed here: `ci-tests-e2e.yaml:184` passes `version: 10`, pinning pnpm 10 in that one job while `packageManager` says 11.13.1. Might be deliberate, worth a look.
…ded (#14677) ## Summary The first-run nudge picked its copy from whether a tour _started_, so a user who skipped on step 1 — or one whose tour was torn down by a target that never mounted — was congratulated for a first result they never made. This makes the copy follow how the tour actually ended. **The nudge's visibility is unchanged: every ending still shows it.** ## The defect `FirstRunTourNudge.vue` chose its copy with `` `…nudge.${tourWasShown ? 'ran' : 'noTour'}` ``, and `tourWasShown` was assigned from `started` — the return of `engine.startTour()` in `useFirstRunTourController.ts` — which means _a tour began_, not _the user completed one_: | ending | copy before | copy now | | -------------------------------- | ------------------------------------------------ | -------- | | completed | `ran` | `ran` | | never appeared | `noTour` ✓ | `noTour` | | **skipped on step 1** | **`ran`** — "You just made your first" | `noTour` | | **abandoned (`target_timeout`)** | **`ran`**, shown alongside the `loadError` toast | `noTour` | | postponed (paywall) | `ran` | `noTour` | | `trigger_lost` | `ran` | `noTour` | The abandoned case is the sharp one: the same event raises an error toast and a congratulation. ## Changes - **What**: `finish()` in `onboardingTourStore.ts` already computes `outcome` and `skipReason`; the store now hands that on as `lastEnding` (a discriminated union, cleared when a new run is requested so the previous ending cannot speak for it). `useFirstRunTourController` derives `tourWasCompleted` from it in place of `tourWasShown`, and the nudge reserves the `ran` copy for `completed`. Every other ending gets `noTour`, which reads as "here's where to go next" for a skipper or an abandoner. - **Breaking**: none. `lastEnding` is additive; `tourWasShown` had exactly one consumer (the nudge). ## Visibility is deliberately unchanged Every ending still arms the nudge, including the ones that now read as `noTour`. That is @MaanilVerma's product decision in #14144: _"a user who saw no tour is the one who most needs somewhere to go next, so suppressing it there removes the way forward."_ #14672 tried to suppress the nudge on the abandoned ending and was closed for exactly this reason — this PR treats the copy, not the visibility, as the defect. The regression guard for that is `still offers the nudge after a tour $named` in `useFirstRunTourController.test.ts`, which asserts `nudgeArmed` for all five endings, plus a sixth test for the never-started case and a component-level check that the nudge renders whether or not the tour finished. ## Tests New coverage, 19 tests: - `onboardingTourStore.test.ts` (6) — the ending recorded for a user skip, a `target_timeout` teardown, a `trigger_lost` teardown, a walked-to-the-end tour; that a running tour has no ending; that a new run drops the last one. - `useFirstRunTourController.test.ts` (10, plus an existing never-started test extended to assert visibility) — `completed` → congratulation; `user` / `target_timeout` / `postponed` / `trigger_lost` → none; **all five endings still arm the nudge**; never-started arms it too, with no congratulation. - `FirstRunTourNudge.test.ts` (3) — completed → `ran`, unfinished → `noTour`, and the nudge appears either way. ### Mutation evidence - Revert the rule to the old semantics (`tourWasCompleted = ending?.tour === 'firstRun'`, i.e. "a tour ran"): **4 failed | 45 passed**. The four are the skipped/abandoned/postponed/lost-context copy cases. The five visibility tests stayed green, confirming they are not coupled to the copy rule. - Pin the component's copy key to `ran`: **1 failed | 10 passed**. Pin it to `noTour`: **1 failed | 10 passed**. - Restored: **374 passed (23 files)** across `src/renderer/extensions/firstRunTour` and `src/platform/onboarding`. `pnpm install --frozen-lockfile`, `format:check`, `lint`, `typecheck` and `knip` all clean. ## Review Focus - `lastEnding` carries `skipReason` although no production code reads it today — the tests name each ending, so the reason has to be observable, and it is the shape `finish()` already computes. Say the word if you would rather it be trimmed to `{ tour, outcome }`. - The controller latches `tourWasCompleted` when the nudge arms rather than deriving it live, so a later tour ending cannot rewrite the copy of a nudge already on screen. - Not verified: no e2e run. `gettingStartedTour.spec.ts` → "leaves the nudge until the upgrade dialog closes" asserts visibility only (postponed still arms), and no e2e or unit test elsewhere asserts the nudge's copy strings — checked by grep, not by running Playwright. - Telemetry is untouched: `nudge_shown` and `explore_templates_clicked` still report only `{ tour: 'firstRun' }`, so the funnel still cannot tell a toured user from a tour-less one. That is a real gap, and deliberately out of scope here. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…#14676) Closes #14625. #14625 found three mutations of the first-run tour stack that leave the suite green. The first — the `GraphCanvas` activation seam — is already fixed in #14674. This PR closes the other two, so **together with #14674** the issue is complete. On its own this PR does not cover gap 1. Test-only: no source file is touched. ## Gap 2 — `hasPromptError` was asserted only in the negative The run-state watcher in `useFirstRunTourController` sources `hasNodeError || hasPromptError`. The positive case was covered for `hasNodeError` alone; the only test naming `hasPromptError` asserted that errors already on screen *before* the tour runs anything are ignored — which passes precisely when the term does nothing. Added `gives up on a run the validator refused before it reached a node`: a prompt-level refusal arriving while `runState` is `generating` must move the card to a terminal state. Without it, a prompt rejected whole never reaches a node and never gets a queue status, so the Result step spins forever. **Mutation evidence** — delete `|| executionErrorStore.hasPromptError` from the watcher source: | | before this PR | after | |---|---|---| | mutation applied | 39 passed, 0 failed (green — the gap) | 1 failed, 39 passed | | mutation reverted | 39 passed | 40 passed | ## Gap 3 — the nudge telemetry source was ungated `FirstRunTourNudge` calls `useWorkflowTemplateSelectorDialog().show('first_run_nudge')`. The existing test asserted only `toHaveBeenCalled()`, so the argument was free. Pinned it to `toHaveBeenCalledWith('first_run_nudge')`. Worth noting: `'command'` is also the *default* value of that parameter, so dropping the argument entirely regresses identically — the pinned assertion catches both. **Mutation evidence** — change the argument to `'command'`: | | before this PR | after | |---|---|---| | mutation applied | 8 passed, 0 failed (green — the gap) | 1 failed, 7 passed | | mutation reverted | 8 passed | 8 passed | ## Verification - `pnpm install --frozen-lockfile`, `pnpm format:check`, `pnpm lint`, `pnpm typecheck` — all exit 0. - `pnpm test:unit src/renderer/extensions/firstRunTour/` — 10 files, 174 passed. - Both mutations were applied and reverted individually; source files confirmed restored (`git status` shows only the two `.test.ts` files changed). ## Unverified - Gap 1 is out of scope here and is not re-verified in this branch — it is #14674's. - Mutation testing was scoped to the two named mutations and the `firstRunTour` suites; this is not a full re-run of the 31-mutation sweep from #14625. - No e2e/browser coverage was added; both gaps are unit-level assertions on existing behaviour. - CI note: `playwright-tests-chromium-sharded (2, 16)` failed on the first run in `changeTracker.spec.ts › Does not restore invalid navigation stack` (subgraph undo `expect.poll` assertions, one of which is already annotated `Currently bugged:`). Unrelated to this diff, which touches no source and no `browser_tests`. It passed on re-run; all 51 non-skipped checks now pass. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Closes #14666 ## The failure Both tests `await` a large module graph **inside the test body**, where the time is billed against the 5 s `testTimeout`. They were never close to safe. Measured on this branch's parent, in isolation, on an idle machine: ``` ✓ GraphView - reconnect wiring > wires the reconnected event ... 3017ms ✓ cloudOnboardingRoutes > lazily resolves the /oauth layout ... 4097ms ``` 60 % and 82 % of the budget with zero contention. Under a full 1091-file run the worker pool serialises transform work behind other files and both slide past 5000 ms — hence the 5005 ms / 5002 ms in the issue, and hence "passes in isolation". The cost is transform, not the code under test: - `onboardingCloudRoutes` calls the two real route loaders, compiling `OAuthLayoutView.vue`, `OAuthConsentView.vue` and their whole import graphs, to assert `toHaveProperty('default')`. - `GraphView` did `await import('./GraphView.vue')` inside the test. Every heavy child is already `vi.mock`ed, but GraphView.vue's own graph is not. **This is not a real regression.** Confirmed on parent `dad1b94ebd`: both pass, and the failure is duration alone — no assertion ever fails. ## The fix — deterministic, not a raised timeout Neither test needed to await anything inside the body. **`onboardingCloudRoutes.test.ts`** — resolve the lazy imports explicitly at module scope and assert on the results. The `typeof loader === 'function'` assertions (the actual laziness claim) stay in the test, and the loaders are the real ones, so the import cost is still paid and still meaningful. The test body is now synchronous. **`GraphView.test.ts`** — import the component at module scope. `vi.mock` is hoisted above all imports, so every stub still applies. Then `vi.waitFor` goes: `handleReconnected` calls `onReconnected()` and `refreshOnReconnect()` before its first `await`, so dispatching the event is enough. The `waitFor` was waiting for something that had already happened — it only ever masked how long the import was taking. ``` ✓ GraphView - reconnect wiring > wires the reconnected event ... 15ms ✓ cloudOnboardingRoutes > lazily resolves the /oauth layout ... 0ms ``` 7.12 s of test time → 20 ms. The transform cost moves to collection, which no timeout guards. ## Why not `vi.mock` the two SFCs That was the obvious way to make the cloud-routes test instant, and it is wrong. I checked: **`vi.mock` on a path that does not exist passes silently** (verified with a throwaway spec). Mocking the two views would have deleted the only thing that test catches — a route pointing at a module that isn't there. ## Verified - Full `pnpm test:unit`: **1095 files, 14954 passed, 8 skipped**, exit 0. - Both files, isolated: 8/8, timings above. - `pnpm format:check`, `pnpm lint`, `pnpm typecheck` clean. - **Mutation-checked, both.** Deleting `useEventListener(api, 'reconnected', handleReconnected)` from `GraphView.vue` → *"expected vi.fn() to be called 1 times, but got 0 times"*. Pointing the consent route at `OAuthConsentViewGone.vue` → the file fails to load with a resolve error. Both reverted; green again. ## Not verified - I could not reproduce the intermittent 5005/5002 ms failure locally — this machine ran the full suite green on the parent commit too. The claim rests on the measured headroom (3017/4097 ms of 5000 ms idle), which explains the reported numbers exactly, rather than on a local reproduction of the flake. - I did not sweep the rest of the suite for the same shape (a heavy `await import` inside a test body). If #14666 recurs elsewhere, that sweep is the follow-up. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Partially addresses #14625 ## The gap `GraphCanvas.vue` is the only place the first-run tour is connected to startup. Its `onMounted` makes two calls: ```ts startupOutcome = await workflowPersistence.initializeWorkflow() await workflowPersistence.restoreWorkflowTabsState() urlTemplateId = await workflowPersistence.loadTemplateFromUrlIfPresent() await useFirstRunEntry().handleStartupOutcome(startupOutcome) // :569 ... await useFirstRunEntry().handleUrlWorkflow( // :595 startupOutcome, urlTemplateId, sharedStatus ) ``` There was no `GraphCanvas` test file. Deleting **either** call left the entire suite green. `useFirstRunEntry` and `useFirstRunTourController` are both well covered on their own — what was untested was the line joining them, so the whole feature could be disconnected in a refactor and CI would not notice. Nothing user-visible is broken today. This closes a hole that would let it break silently: no Getting Started screen and no template-browser fallback for new users (first call), or a template/share link that silently never offers the tour (second call). ## What the test does `src/components/graph/GraphCanvas.firstRunEntry.test.ts` mounts the real component and asserts both hand-offs happen with the values startup produced: - `handleStartupOutcome` receives the outcome from `initializeWorkflow()`. - `handleUrlWorkflow` receives that outcome, the template id from `loadTemplateFromUrlIfPresent()`, and the status from `loadSharedWorkflowFromUrlIfPresent()`. Asserting the *arguments*, not just the calls, also pins the data flow — swapping the template id and the shared status, or passing a re-read outcome, fails. ### On mounting a 630-line component I looked at cheaper options first and rejected them. A source-text or AST assertion over `GraphCanvas.vue` would go red on the mutation, but it would also pass if the calls were in dead code, and it gates the spelling of the call rather than the behaviour. Mounting turned out to be practical, so that is what this does. The cost is a block of `vi.mock` calls, which is why it is a separate file rather than a general `GraphCanvas.test.ts`: children are stubbed via `shallow`, the startup dependencies (`@/scripts/app`, `useWorkflowPersistenceV2`, `ChangeTracker`, `useNewUserService`, the canvas/lifecycle composables) are faked, and the two readiness gates the sequence waits on — `settingStore.isReady` and `bootstrapStore.isI18nReady` — are set before mounting. The mocks are startup infrastructure only; the component's own `onMounted` runs for real. Two notes for future readers: - `@/stores/workspaceStore` is mocked because instantiating the real one reaches the Firebase auth store. - `shallow` is forwarded verbatim to Vue Test Utils' `mount`, which honours it; `@testing-library/vue` just omits it from its own option type, hence the cast. Runtime is ~30 ms of test time (the rest is module import). ## Verified - `pnpm install --frozen-lockfile`, `pnpm format:check`, `pnpm lint`, `pnpm typecheck` — all clean. - `pnpm test:unit src/components/graph/GraphCanvas.firstRunEntry.test.ts` — 2 passed. - Full `pnpm test:unit` — 14955 passed, 8 skipped, 1 failed: `onboardingCloudRoutes.test.ts > lazily resolves the /oauth layout and consent view components` times out at 5 s. Confirmed flaky and unrelated: it fails the same way when run alone on a sibling worktree that does not contain this file, and it passed in a subsequent full run (1095/1095 files). It is a lazy dynamic-import timing flake in this environment, not something this PR touches. ### Mutation results Each call was deleted in turn, the suite run, then restored: | Mutation | Result | | --- | --- | | remove `await useFirstRunEntry().handleStartupOutcome(startupOutcome)` | `hands the startup outcome to the first-run entry point` **fails** (1 failed, 1 passed) | | remove `await useFirstRunEntry().handleUrlWorkflow(...)` | `offers the tour over a workflow that arrived from the URL` **fails** (1 failed, 1 passed) | | both restored | 2 passed; `git diff` on `GraphCanvas.vue` empty | Each mutation fails only its own test, so neither assertion is carrying the other. ## Not covered - No production code changed; this PR is test-only. - The issue lists two further surviving mutations that this PR does **not** close: `hasPromptError` in `useFirstRunTourController` (only the negative case is asserted) and the nudge's `show('first_run_nudge')` telemetry source. Both are single assertions in existing files and are worth a small follow-up; flagging them since this PR closes the issue that tracks them. - `handleUrlWorkflow` is asserted with a template-id boot. The share-link path (`sharedStatus === 'loaded'`) is covered by `firstRunEntry.test.ts`, not here. --- **⚠️ Do not let this auto-close #14625.** The issue lists **three** surviving mutations and this PR closes only the first — the activation seam. Two remain, both single assertions: - **`hasPromptError` is asserted only in the negative**, so the test passes precisely when the term does nothing. Remove the term and the suite stays green, yet a prompt-level validation refusal then leaves the Result step spinning — the defect that term exists to prevent. - **`show('first_run_nudge')` → `show('command')` stays green**, so the telemetry source can silently regress back to filing every nudge conversion under the command palette. Reworded the close reference to `Partially addresses` so the issue survives this merge. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…4773) ## Summary `ComfyApp.getNodeDefs()` discards `/object_info` entries that are not objects with a string `name`, so a single malformed def cannot abort node registration for every node. It did so silently, which makes a node vanishing from the UI undiagnosable. Warn once per fetch, naming the discarded keys. ## Why this shape This is the decision half of #14644, which asks whether node definitions should be structurally validated at the API boundary and what should happen to ones that fail. Validation was removed deliberately: #1190 disabled it by default and #4038 removed it outright along with its setting. `/object_info` carries definitions from arbitrary custom nodes whose shapes vary in ways `ComfyNodeDefV1` does not fully capture, so tightening the contract risks silently dropping a node the user installed and expects to see. That posture is kept here. What was actually wrong was not the permissiveness, it was the silence. Naming the dropped keys keeps the permissive behaviour while making the data loss visible, and it is the cheapest way to learn whether real payloads ever reach this path. If telemetry later shows they do, #14644 can be decided with evidence rather than speculation. - **Breaking**: none. Same defs are dropped as before; only the logging changes. ## Review Focus Verified by mutation: removing the warning fails the suite. A second test pins that a well-formed response stays silent, so the warning cannot become unconditional noise. Related: #14644, #14541 --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org>
## Summary Finishes what #14744 started: the last two node-title goldens that still track the CI container image are now pinned. No baselines regenerated. ## Changes `browser_tests/tests/nodeBadge.spec.ts` already extended the `page` fixture to stub `/object_info` for `ImageBatch`. That map now also carries: | golden | node type | pinned title | | --- | --- | --- | | `api-pricing-{on,off}-{classic,vue}` | `FluxProUltraImageNode` | `Flux 1.1 [pro] Ultra Image` | | `node-badge-{Show-all,Hide-built-in,None}` | `PreviewImage` | `Preview Image` | The route shape, the `try`/`finally` unroute and the pre-boot install are unchanged — only the mutator body generalises to a loop. `nodes/execution_error` also renders `DevToolsErrorRaiseNode` (`Raise Error`), which is **deliberately not pinned**. That name is defined in this repo at `tools/devtools/nodes/errors.py:76` and copied into `custom_nodes` during CI, so it is not a function of the container image. Pinning it would mask a deliberate in-repo rename. ## Review Focus **Motivation.** Since #14541 English node display names resolve from the backend `/object_info`, so every golden containing a node header is a function of `ghcr.io/comfy-org/comfyui-ci-container`. #14682 moves that pin from `0.0.21` (ComfyUI v0.19.3) to `0.0.22` (v0.30.0) — eleven minors. The goal is that after this lands, a node-title golden that moves on that bump means a real structural change, not an upstream rename. **How the strings were established.** Both are read off the committed PNGs, not guessed: - `Flux 1.1 [pro] Ultra Image` is legible in the title band of `api-pricing-on-classic` and `api-pricing-on-vue`, and matches `src/locales/en/nodeDefs.json`. - `Preview Image` is legible in the title band of all three `node-badge-*` goldens, likewise matching the bundled snapshot. Two independent corroborations that these strings hold on both sides of the bump: 1. #14541 re-baselined only `image-compare-*` and `node-lifecycle-*`. It left `api-pricing-*` and `node-badge-*` byte-identical, so at `0.0.21` the container name already equalled the bundled name. 2. Diffing every golden #14682 regenerates against its committed counterpart, the changed pixels in `node-badge-*` sit at x 454–509 / y 69–81 — an `images` output slot appearing on `PreviewImage`. The title band is byte-identical, and `api-pricing-*` is not regenerated at all. So neither title moves at `0.0.22` either. **Sweep.** All 26 goldens #14682 regenerates were diffed old-vs-new and classified. **None move because of a node display name:** | cause | goldens | | --- | --- | | `SaveImage`/`PreviewImage` gained an `images` output | `colorPalette` ×9, `node-badge-*` ×3, `loadWorkflowInMedia` ×4, `save-image-and-webm-preview`, `lod-comparison-high-quality` | | `control after generate` default `randomize` -> `fixed` | `static-primitive-connected` | | 3D render differences | `load3d-*` ×3 | | sub-5px antialiasing | `interaction` ×3, `lod-comparison-low-quality` | So there is no evidence-backed third site. The remaining exposure is the default-workflow titles (`KSampler`, `CLIP Text Encode (Prompt)`, `Load Checkpoint`, `Save Image`, …), which appear across roughly 37 spec files and 257 goldens. Pinning those would touch most of the screenshot suite for a rename that has not happened, so it is left out; the fixture pattern applies unchanged if one ever does. ## Testing `typecheck`, `lint`, `format`, `knip` pass locally. The stub itself needs a running ComfyUI backend, so CI is the verifier — the proof is that the `nodeBadge` and `imageCompare` screenshot tests stay green with the goldens unmodified, which also exercises the route-install ordering. Related: #14630 (closed by #14744; this is the follow-through) Co-authored-by: Connor Byrne <c.byrne@comfy.org>
) ## Summary `ComfyNodeDefImpl.display_name` and `.description` become getters that resolve against the active locale on read, instead of `ComfyApp.getNodeDefs()` baking resolved text into every def at fetch time. ## Changes - **What**: `getNodeDefs()` no longer resolves `display_name`/`description` (it still resolves `category`), so `nodeDefStore` holds the raw `/object_info` text and resolves it per read via `resolveNodeDefText`. Precedence is unchanged — that logic still lives solely in `src/i18n.ts`. `setBackendNodeText` stays, because consumers like `nodeTitleUtil` only have a node type string. - **Breaking**: extensions receiving defs through `beforeRegisterNodeDef`, `addCustomNodeDefs` and `beforeRegisterVueAppNodeDefs` now see raw backend `display_name`/`description` rather than pre-translated text. Anything reading those fields off a `ComfyNodeDefImpl` is unaffected. Property-access shape is preserved deliberately, so the ~96 files reading `display_name` needed no changes. Consequences that fall out: `allNodeDefsByDisplayName`, `nodeTree` and the Fuse search index are `computed`, and the getters read `i18n.global.locale.value`, so all three now re-resolve on a locale change with no refetch. ## Review Focus A getter is not an own enumerable property, so the two constructor details are load-bearing: - The raw values are held in TypeScript `private` fields, **not** `#private`. Vue wraps store instances in a Proxy and `#private` reads throw through one (`TypeError: Cannot read private member`). - The constructor destructures `display_name`/`description` out before `Object.assign(this, obj)`. Assigning to a setter-less accessor throws in strict mode, which would have broken every construction. Audited for silent loss of the accessors: object spread, `JSON.stringify`, `structuredClone`, `Object.keys/values/entries`, `Object.assign`, `toRaw`, and `cloneDeep`. The only place a `ComfyNodeDefImpl` instance is structurally copied is `nodeBookmarkStore.buildBookmarkTree`, which uses es-toolkit's `clone` — that preserves the prototype, so the accessors survive. Covered by a regression test, since swapping it for a spread would blank every bookmark label. Two things left alone, noted for follow-up: - `nodeDefsByDisplayName` (the plain `ref`, not the `computed`) still snapshots its keys at write time, so they go stale after a locale switch. It has no consumer in `src/`. - `litegraphService` still assigns `node.title` once at registration, so existing canvas nodes keep their old title until reload — the pre-existing behaviour this refactor makes fixable, but does not fix. Fixes #14629 Co-authored-by: Connor Byrne <c.byrne@comfy.org>
## Summary Escapes node names before rendering search-highlight markup so workflow-provided group node names are always displayed as text. ## Changes - **What**: Escape source text before adding the generated highlight span, including when the search query is empty. - **What**: Restrict the final rendered markup to the generated `span.highlight` structure. - **What**: Add utility and component regression coverage for markup in node names. ## Review Focus Confirm highlighting remains unchanged while node display names and internal names cannot contribute rendered markup. ## Testing - `pnpm test:unit packages/shared-frontend-utils/src/formatUtil.test.ts src/components/searchbox/v2/NodeSearchListItem.test.ts` (115 passed) - `pnpm typecheck` - `pnpm lint` - `pnpm knip` - `pnpm format:check packages/shared-frontend-utils/src/formatUtil.ts packages/shared-frontend-utils/src/formatUtil.test.ts src/components/searchbox/v2/NodeSearchListItem.test.ts` - targeted ESLint and Oxlint Co-authored-by: Amp <amp@ampcode.com>
## Summary Add Italian (`it`) as a supported ComfyUI frontend locale. ## Changes * **What**: Added Italian to the localization configuration and locale selector. * Added the required empty locale files for `main`, `commands`, `settings`, and `nodeDefs`. * Updated locale resolution tests to recognize Italian as supported. * The locale files are intentionally empty, following the localization contribution workflow; translations can be generated during the release process. ## Review Focus * Italian locale identifier (`it`) and display name (`Italiano`). * Locale resolution test updates. * Correct discovery of the four Italian locale files. ## Italian Translation Draft A complete Italian translation draft for all four locale files has already been prepared and validated locally. It is intentionally not included in this feature PR to follow the repository's localization workflow, which populates locale files during the release process. I am available to review and refine the generated Italian translations and would be happy to help maintain the Italian localization. ## Testing Note On Windows configured with an Italian system locale, some locale-sensitive number-formatting tests expect hard-coded en-US output (for example, `10.6`) while `Intl.NumberFormat` correctly produces localized Italian output (for example, `10,6`). This is unrelated to translation placeholders. With en-US Intl behavior explicitly set for the local test run, the complete test suite passes. GitHub CI will independently validate the changes in its configured environment. ## Testing * `pnpm typecheck` * `pnpm lint` * `pnpm format` * `pnpm test:unit` — 997 test files passed; 13,184 tests passed; 8 skipped * Verified that `Italiano` appears in the locale selector. Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Reverts five PRs that were merged to `main` without independent review, which is not our process. Backing them out so they can go through review properly. Reverted, newest first: - #14775 — resolve display name and description at read time - #14774 — pin remaining container-coupled node titles - #14773 — warn on dropped malformed node defs - #14747 — widget labels, output names and tooltips from the backend - #14744 — decouple node-title goldens from the CI container **Not reverted:** #14541. It was authored by @bigcat88 and carried a genuine approval before merge, so it followed process. The five above were authored and merged under the same account, and GitHub blocks self-approval, so none of them could receive one. Three had no approval of any kind at merge time. `main` is not branch-protected here, so nothing blocked the merges. That is the gap that let this happen. ## State after this revert All five reverts applied without conflict. The tree returns to the post-14541 state: `resolveNodeDefText` and `setBackendNodeText` remain, `translateNodeDef` resolves `display_name`/`description` inline again, and the slot resolvers, getters, dropped-def warning and golden stubbing are all removed. Verified locally: `pnpm typecheck` clean, `pnpm knip` clean, 156 unit tests pass across the four affected suites. ## Follow-up Each reverted change will be re-opened as its own PR from its original branch, which still exists, for normal review. Nothing is lost. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org>
…king (#14596) *PR Created by the Glary-Bot Agent* --- ## Summary `searchRank` did nothing. It was read in exactly one place — the `recommended` sort — which neither the default browse view nor search ever selects, so setting it on a template had no observable effect anywhere. Bumping a template to `searchRank: 1000000` for the MiniMax H3 launch changed nothing, which is what surfaced this. This applies it where curators expect it: the search relevance path, as a bounded multiplier that can lift a near-equal match but never surface a weak one. ### How it got that way In #7062 `searchRank` *was* wired into the default sort — commit 95d7207 reads `"Recommended" (default): usage × 0.5 + searchRank × 0.3 + freshness × 0.2`. During review that PR was found to have replaced the plain "Default" sort option outright, removing the `index.json` ordering that `workflow_templates` owns. Commit 4f23735 fixed that by moving the curated blend onto a new opt-in `recommended` dropdown entry and restoring `default` as a pass-through. `searchRank` went along for the ride onto an option nobody selects, and was never revisited. Browse-default ordering stays a pass-through of `index.json` here — deliberately. That is the editorial lever #7062 protected, and reordering entries there remains how you change the browse order. ## Changes **Curation now affects search relevance.** `rankByRelevanceThenUsage` scales each hit's score by `1 + searchRankBoost(searchRank) × 0.3` before bucketing. The ±30% cap is ~6 tiebreak bands: enough to clear near-equal matches, never enough to drag a weak match up, and it cannot introduce a template that does not match the query at all. `searchRank` is added to `storeFields` so hits carry it. **Scale reconciled across the two repos.** `workflow_templates/docs/SPEC.md` — what template authors actually read — specifies `searchRank` as "0-1000, higher = better ranking". The frontend documented 1–10 with 5 neutral. The data follows the former: of 463 templates with the field set, 435 use it that way (429 × `0`, plus `500`, `1000`, `1000000`). Adopting the authored contract: | `searchRank` | Effect | | --- | --- | | absent, or `0` | Neutral | | `1` … `5` | Neutral (retired-scale range, see below) | | `6` … `1000` | Promote, diminishing returns | | above `1000` | Saturates — `1000000` is identical to `1000` | | `-6` and below | Demote, mirroring the positive curve | **Polarity fixed.** `0` was previously the *harshest* demotion (`0/10 = 0`) while an absent field got neutral `5/10`. Since `workflow_templates` tooling writes an explicit `"searchRank": 0` onto uncurated templates, that buried 429 of 583 templates beneath the 120 that simply omit the field. Both are now neutral; explicit demotion uses negative values. **Out-of-range values bounded.** Magnitude follows `log1p(|rank|) / log1p(1000)`, capped at 1, so `1000000` lands on the cap instead of producing a nonsense score. **Retired-scale values left inert.** The old scale read 1–4 as demote and 5 as neutral, and the numbered starter templates still ship `searchRank: 3`. Reading those on the new scale would have flipped their only plausible intent into a promotion, so magnitudes ≤ 5 are ignored. This covers the entire retired 1–10 range without inverting anything and needs no data migration; on a 0–1000 dial a value that small is noise. **`recommended` sort no longer silently no-ops.** `computeDefaultScore` returned `NaN` whenever nothing in the filtered set had usage (`0 / 0`), making the comparator return `NaN` and the sort a no-op. The existing test carried a `// Set largestUsageScore to avoid NaN` workaround. **`docs/TEMPLATE_RANKING.md` rewritten.** It described a `popular` formula (`usage × 0.9 + freshness × 0.1`) and a `computePopularScore` function that no longer exist, and omitted the search path entirely. ## Verification Ran the real ranking code against the live 583-template `index.json`: ``` query "minimax" before after 1. MiniMax H3: Text to Video rank=1000000 #2 -> #1 2. MiniMax H3: Image to Video rank=1000000 #3 -> #2 3. MiniMax H3: Reference to Video rank=1000000 #4 -> #3 4. MiniMax H3: FLF2V rank=0 #1 -> #4 ``` Queries with no curated templates in range (`wan`, `upscale`, `flux upscale`, `img2img`) are byte-identical to before. `starter` confirms the rank-3 templates sort purely on relevance, with no promotion. End-to-end in a browser against a running dev server (screenshot below) — the three curated templates lead, no new console errors. `pnpm typecheck`, `pnpm lint`, `pnpm knip`, `pnpm format` clean. 155 test files / 2637 tests pass, including new coverage for neutrality of `0`/unset/`NaN`, retired-scale inertness, saturation, symmetry, the curation cap not overriding a strong match, and uncurated result sets being untouched. ## Follow-up `workflow_templates/docs/SPEC.md` and this doc now agree, but the three `gsc_starter_*` templates still carry retired-scale `3` values. They are inert rather than wrong, so no migration is required — worth cleaning up whenever those templates are next touched. ## Screenshots  --------- Co-authored-by: glary <bot@comfy.org>
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions. ## Changes - **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide state, preload ladder, failure handling) and `useProgressBarPainter` (rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component). - Slides rotate their flex `order` rather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards. - Media is served from `media.comfy.org` rather than bundled, so no video bytes ship in the repo or the build. - The hero card takes its height from the row instead of a fixed aspect ratio, which is what kept the logo and terms pinned to the video's edges as the viewport grew. ## Review Focus - **Playback stops when it should**: verified paused with frozen decoder frame counts when the tab is hidden and when the panel scrolls offscreen. No leak across 5 mount/unmount cycles (heap and node counts flat). - **Gated above `xl`** via `v-if`, not CSS — confirmed against a production build that phones and tablets fetch **0 bytes** of video. - **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the carousel subtree. One slide exposed at a time via `aria-hidden` + `inert`, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form. - **Reduced motion**: no playback, no auto-advance, chevrons still work without starting video. Screenshots. <img width="1440" height="900" alt="forgot-1-default" src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47" /> <img width="1440" height="900" alt="forgot-2-required" src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c" /> <img width="1440" height="900" alt="forgot-3-filled" src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c" /> <img width="1440" height="900" alt="forgot-4-long-email-overflow" src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd" /> <img width="1440" height="900" alt="forgot-no-footer" src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f" /> <img width="1440" height="900" alt="login-1-social" src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8" /> <img width="1440" height="900" alt="login-2-email-empty" src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff" /> <img width="1440" height="900" alt="login-3-invalid-email" src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94" /> <img width="1440" height="900" alt="login-4-required" src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea" /> <img width="1440" height="900" alt="login-with-fixed-logo" src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1" /> <img width="400" height="90" alt="LOGO-fixed" src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4" /> <img width="1440" height="900" alt="signup-1-social" src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1" /> <img width="1440" height="900" alt="signup-2-email-empty" src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93" /> <img width="1440" height="900" alt="signup-3-weak-password" src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b" /> <img width="1440" height="900" alt="signup-4-password-mismatch" src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265" /> --------- Co-authored-by: Deep Mehta <deepme987@gmail.com>
## Summary Part 1/4 of the workspace/billing rollout retirement stack. Makes Cloud workspace initialization failures recoverable without changing either rollout flag or flag-off behavior. Predecessor: none (base: main). Successor: [#14613](#14613). ## Root cause `WorkspaceAuthGate` failed closed on config, unified-auth, workspace initialization, and timeout failures but exposed no recovery action. The team workspace store also treated `error` as terminal, and the Cloud account popover disappeared while workspace initialization was loading or failed, preventing account actions. ## Changes - Render a fail-closed initialization error with a retry action for config, timeout, unified-auth, and workspace failures. - Permit `teamWorkspaceStore.initialize()` to retry from `error`. - Keep the account menu usable in flag-on loading/error states via account-only workspace popover content. - Preserve legacy popover and gate behavior when `team_workspaces_enabled` is off. - Filter empty logged-out Workspace settings groups. - Add only the Cloud boot session/workspace fixture coverage needed by this layer; both rollout keys remain supported. ## AS IS Initialization failures permanently gate the app and loading/error workspace state removes Cloud account actions. ## TO BE Initialization failures remain fail-closed but can be retried, and Cloud account actions remain available during loading/error. This is the only intended visual change in the stack; it is a state-dependent recovery UI, so no static screenshot is required. ## Regression coverage - WorkspaceAuthGate failure, timeout, and retry paths with asynchronous settling. - Team workspace store `error -> loading -> ready` retry. - Current user button/popover flag-off, flag-on loading/error, and ready behavior. - Logged-out settings group filtering. - Cloud boot fixture session/workspace bootstrap. ## Validation - `pnpm test:unit src/platform/workspace/auth/WorkspaceAuthGate.test.ts src/platform/workspace/stores/teamWorkspaceStore.test.ts src/components/topbar/CurrentUserButton.test.ts src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts src/platform/settings/composables/useSettingUI.test.ts` (125 passed) - `pnpm typecheck` (passed via commit hook after final fix) - `pnpm typecheck:browser` (passed) - targeted `oxfmt --check` (passed) - `git diff --check public/main...HEAD` (passed) - `pnpm knip --cache` (passed via push hook) ## Review focus Review only recoverability, retry state transitions, and preservation of both rollout modes. Flag retirement belongs to later PRs. ## Stack/deployment order 1. **This PR** — recovery foundation 2. [#14613](#14613) — retire team workspace rollout flag 3. [#14614](#14614) — canonical billing status and legacy rail preservation 4. [#14615](#14615) — retire consolidated billing rollout flag Deploy the frontend stack before the backend removes `/api/features` compatibility keys. --------- Co-authored-by: Dante <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…14616) ## Summary Mobile visitors on the download page can't run desktop installers; this adds a mobile-only email form that captures their address in Customer.io so a campaign can send them a download link for later. ## Changes - **What**: - `MobileDownloadEmailForm` on `/download` and `/zh-CN/download`, shown only for mobile user agents; identifies the person by email and records a `download_link_requested` event in a dedicated "comfy.org website" Customer.io Data Pipelines source - Client-side validation, honeypot spam guard, pending/error/success states with `role="status"` announcements - Public website-source write key committed as the default (same convention as the PostHog key), overridable via `PUBLIC_CUSTOMERIO_WRITE_KEY` - `detectDevice` now classifies desktop-mode iPads (Macintosh UA + `maxTouchPoints > 1`) as mobile, so iPads get the form instead of an uninstallable DMG; extracted as a pure function with unit tests - Vitest config gains the tsconfig `@/` alias so composables using it are testable - **Dependencies**: `@customerio/cdp-analytics-browser` (lazy-loaded on form mount) ## Review Focus - The write key is a public client-side ingest key, safe to commit; setting `PUBLIC_CUSTOMERIO_WRITE_KEY=""` disables the form - Honeypot submissions fake success without network calls - Customer.io is the only analytics sink for submissions (no PostHog capture) - SDK loads once across preload/repeat submits; e2e specs mock all `cdp.customer.io` traffic - Verified live against the real source: identify + track accepted (200), person and event visible in the workspace --------- Co-authored-by: Robin Huang <robin.j.huang@gmail.com> Co-authored-by: Richard Yu <richard95yu@gmail.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne, Hunter** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785709835389349?thread_ts=1785709835.389349&cid=C0A4XMHANP3)_ ## Summary Introduces an exhaustive billing-policy model for the two migrated subscription UI decisions. The model is deliberately scoped to **distribution × billing/subscription policy**; workspace roles/permissions, feature flags, JWT scopes, and backend/object authorization remain orthogonal checks. This centralizes the conditionals that caused #incident-95, where subscription tier alone was treated as a proxy for whether Cloud subscribe UI should render in local mode. ## Changes - Adds `BillingPolicyState`, including distinct inactive Team states and active subscriptions whose tier has not resolved yet. - Maps every state explicitly to `BillingPolicyCapabilities`. - Exposes `topUpAccess: 'allowed' | 'subscription-required'` as a subscription-policy decision. It is **not final authorization**; consumers must still apply role/auth/flag/scope/backend checks where applicable. - Migrates `CreditsTile.vue` and `dialogService.ts` without changing their existing decisions. - Preserves Team precedence, exhaustive tier handling, and the separate `CloudTeamWithoutActiveSubscription` policy (`subscription-required` top-up, no subscribe upsell). The subscribe upsell for `CloudWithoutActiveSubscription` is an intentional behavior expansion already disclosed during review. The known overlap/conflict with #11464 remains a coordination item rather than part of this PoC. ## Scope - No backend changes. - Only the two identified consumers are migrated. - No attempt to combine authorization dimensions into billing policy. ## Testing - Focused billing-policy, `CreditsTile`, `dialogService.topUpCredits`, and `dialogService.renderer` suites: **5 files / 69 tests passed**. - `pnpm typecheck`: passed. - Targeted ESLint, oxfmt, stylelint, and oxlint: passed (commit hooks). - `pnpm knip`: passed (also rerun by the push hook). - `git diff --check`: passed. - Repository-wide stale-name search excluding `node_modules`/`dist`: no matches. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Dante <bunggl@naver.com>
## Summary Align the profile billing action with the surface available in each distribution: - **Local/desktop:** show **Credits** with `lucide--coins`, opening Settings → Credits. - **Cloud:** keep **Manage plan** with `lucide--credit-card`, opening the workspace **Plan & Credits** surface. - **Cloud permissions:** hide **Manage plan** from members who cannot manage subscriptions; keep it visible for eligible owners of both personal and team workspaces. [FE-1485](https://linear.app/comfyorg/issue/FE-1485/credits-tab-is-visible-on-personal-workspace) · [final requirement clarification](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785784408518089?thread_ts=1785681144.818179&cid=C0A4XMHANP3) ## Root cause The legacy profile popover hardcoded **Manage plan** and a file-text icon across distributions, even though local/desktop has no workspace plan-management surface and the action opens its standalone Credits panel. The workspace popover already enforced subscription-management permissions correctly, but its generic file-text icon did not distinguish plan management from the separate Plans & pricing action. The earlier version of this PR treated the standalone Credits settings tab as the regression and removed it from V0. The clarified requirement confirms that tab is required on local/desktop, so that change is fully reverted. ## Changes - Derive the legacy profile action label and icon from the distribution: - local/desktop → **Credits** + coins → `credits` - Cloud → **Manage plan** + credit card → `subscription` - Use the credit-card icon for Cloud workspace plan management. - Preserve existing `canManageSubscription` gating in the workspace popover. - Restore the original standalone Credits settings behavior. - Add regression coverage for local and Cloud legacy routing plus personal-owner, team-owner, and team-member workspace roles. ## Why previous tests missed it Existing tests only checked that the menu item existed. They did not assert its distribution-specific label, destination, or icon semantics. Workspace tests covered billing visibility in several roles but did not exercise plan-management navigation for both personal and team owners. The new tests assert the action text and destination in each distribution and cover owner/member permission behavior across workspace types. ## Review focus - Local/desktop must retain Settings → Credits and expose it as **Credits** with the coins icon. - Cloud must expose **Manage plan** with the credit-card icon only when the active user can manage subscriptions. - Eligible personal and team owners must both open workspace Plan & Credits. ## Verification - `pnpm test:unit src/components/topbar/CurrentUserPopoverLegacy.test.ts src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts` — 39 passed - `pnpm typecheck` - `pnpm typecheck:browser` - ESLint, Stylelint, oxlint, and oxfmt on touched files - pre-push `pnpm knip --cache` - Full GitHub CI, including Cloud and local Playwright projects — passed ## Screenshots ### AS IS — local/desktop The original real-app report shows **Manage plan** opening the local Credits surface. See the [source screenshots in the report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785681144818179). ### TO BE — local/desktop The profile action reads **Credits** and opens Settings with the standalone Credits panel selected.   ### TO BE — Cloud Cloud retains **Manage plan** and uses the credit-card icon, distinct from the receipt icon used by **Plans & pricing**.  Captured from the current PR head in the route-mocked real Cloud app. [Approved Cloud reference](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785784445105449?thread_ts=1785681144.818179&cid=C0A4XMHANP3). --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
## Summary The Comfy logo on the Cloud login/signup/forgot-password pages is broken on nightly, testcloud, stagingcloud, and prod-cloud — it only renders correctly in local dev. ## Changes - **What**: `CloudTemplate.vue` loads the logo via ``'<img src="/icons/logo.svg">'``. That asset lived at `public/icons/logo.svg`, a top-level `public/` path that Cloud's nginx-frontend does not proxy through to the GCS asset bucket (nginx only proxies `/assets/`, `/fonts/`, `/cursor/`, `/scripts/`, `/extensions/core/`, `/extensions/cloud/`, plus the exact-match files `/materialdesignicons.min.css` and `/favicon.ico`). The request falls through to the SPA catch-all and gets `index.html` back with a 200, so the browser shows a broken image with no console error and no 404 — nothing to signal the failure. This was introduced by #14697 (#14697), which swapped an iconify class for this `` tag. - Moved the SVG to `public/assets/images/comfy-logo-wordmark.svg`, a path nginx already proxies, matching the naming convention of the other logo assets already in that directory (`comfy-logo-single.svg`, `comfy-logo-mono.svg`). - Updated the `img src` in `CloudTemplate.vue` to point at the new path. - **Breaking**: none - **Dependencies**: none ## Review Focus - `apps/website/public/icons/logo.svg` is a separate, unrelated asset for the standalone website app (different deployment, not served through Cloud's nginx-frontend) — intentionally left untouched. ## Screenshots (if applicable) N/A — this is a one-line path fix; no visual change to verify beyond the logo now loading. --- _Generated by [Claude Code](https://claude.ai/code/session_01QsWQFqb9nLeijU1F6WdhWS)_ Co-authored-by: Claude <noreply@anthropic.com>
…ge (#14779) ## Summary Flux 3 has shipped, so /flux-3 serves the full launch page instead of the announcement placeholder. ## Changes - **What**: Swaps the flux3 config from the 36 line announcement to the launch config (hero video, six gallery clips, pricing with the Comfy Cloud trial banner, eight Q&A entries, closing CTA), ports the launch e2e assertions, and replaces the whole `flux3.*` translation block. - Data only. It renders through the existing model-launch template with no component or contract changes, and both page stubs were already in place. - All six clips and the hero were already served from media.comfy.org/website/flux-3, so there are no new assets. ## Review Focus The translation block is replaced wholesale rather than patched, because the change is not only additive: - 12 keys are new (hero title/titleRest/description/tagOpenWeights/secondaryCta, cta.\*, pricing.banner.\*, models.heading) - 2 keys were announcement only and are removed, `flux3.hero.eyebrow` and `flux3.hero.tagImageToVideo`. Left in place they fail the unused-key check. - 5 shared keys changed value, most visibly `flux3.hero.primaryCta` from `RUN COMFY FOR FREE` to `RUN FLUX 3`, plus both meta tags, `tagPartnerNodes` and `runOptions.subtitle`. Two stale strings corrected along the way: the translation block comment still described the page as an announcement, and the hero e2e test was still named "renders the coming-soon hero". Known follow-up, not in this PR: the seven videos have no poster frames, so each card shows an empty box until its file loads. The fix needs a template change that is still in review elsewhere. Verified on the built output: zero occurrences of "Coming Soon", seven videos, seven distinct flux-3 media URLs, eight FAQ `Question` nodes in the structured data, and the zh-CN page equivalent. The one remaining "coming soon" on the page is the intentional "Open weights coming soon." in the hero copy. Gates: `astro check` 0 errors, unused-i18n clean, unit tests 20/20, build 581 pages, `validate:jsonld` 584 pages, oxlint, knip and format clean, flux-3 e2e 8/8.
…g silently (#14759) Follow-up to #14715. No behavior change against any value the API sends today — this is about what happens to the next one. Recovering a pending billing operation picked its client path with a two-way check, so anything that was not `topup` became `subscription` — including a value this client has never heard of. ```ts status.pending_billing_op_type === 'topup' ? 'topup' : 'subscription' ``` ### Before ```mermaid flowchart LR A["'subscription'"] --> S[subscription path] B["'topup'"] --> T[topup path] U[undefined] --> S N["any new value"] -.silently.-> S style N fill:#f8d7da,stroke:#b02a37,stroke-dasharray: 4 ``` ### After ```mermaid flowchart LR A["'subscription'"] --> S[subscription path] B["'topup'"] --> T[topup path] U[undefined] --> S N["any new value"] --> R["subscription path<br/>+ Sentry report"] style N fill:#d1e7dd,stroke:#0f5132 style R fill:#d1e7dd,stroke:#0f5132 ``` ## Why it matters `subscription` is the worst branch to default into. A mislabelled operation flips `isSettingUp`, so the panel covers the user's real plan with a "setting up your subscription" spinner for as long as the operation is pending; `topupActionOperation` never matches; and `handleSuccess` reconciles the subscription instead of refetching the balance. Same failure #14715 fixed, waiting for the next value. ## The change An exhaustive `switch`: - `undefined` still resolves to `subscription` — the compatibility path for a server that does not send the field, and why #14715 was safe to land alone. - An unknown value reports to Sentry (`billing_unknown_resume_mode`). - `const unexpected: never = type` in `default` means a widened union fails to compile. **The unknown case still resumes as a subscription, deliberately.** It is reachable only when this bundle is older than the server. In that window, dropping recovery strands a customer who cannot reach the payment page, while a wrong panel clears on reload — so recovery wins, and the report is what makes the skew visible. `JSON.stringify` rather than `String` in the report: `String` throws on a value with no callable `toString`/`valueOf`, and throwing out of the branch that exists to absorb a bad value would abort the whole status read. The value came from a parsed response, so it cannot be circular. ## Tests Three paths, all through `fetchStatus`: | Test | Covers | |---|---| | `recovers a pending subscription reported explicitly` | what the server sends today for an initial subscription or plan change | | `recovers a pending top-up as a top-up, not a subscription` | the `topup` path | | `reports a resume mode it does not recognize` | the unknown value — **verified red** against the old ternary | The absent-field compatibility path is already covered by the existing `recovers a pending subscription operation from billing status`. `vitest run --coverage` (76 passed, matching how CI runs unit tests), `pnpm typecheck`, `pnpm lint`, `pnpm format`. ## Scope note `BillingStatusResponse` is hand-written in `workspaceApi.ts` rather than taken from `@comfyorg/ingest-types`, so the `never` check is exhaustive over a hand-maintained union: it catches an edit to that union that misses this switch, but cannot widen on its own when the API changes. Single-sourcing it means regenerating the types package, which rewrites the whole generated surface and belongs in its own PR. Until then the Sentry report is the signal that matters here. The server-side counterpart is tracked separately and does not gate this PR. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
) ## Summary Adds a "New Model Release" announcement section (MINIMAX H3) to the comfy.org home page, implementing the Card-SplitContent-Desktop Figma design as a reusable block. ## Changes - **What**: New `blocks/CardSplitContent01.vue` (video media + eyebrow/title/body/CTAs/tag chips), mounted on `/` and `/zh-CN/` after the hero with `client:visible`; new `muteOnly` mode on `VideoPlayer.vue` (persistent top-right mute toggle, other controls suppressed — existing consumers unaffected); VideoPlayer's inline mute icons extracted to `icons/VolumeMutedIcon.vue` / `VolumeUnmutedIcon.vue`; new `modelRelease.*` and `tags.openWeights` i18n entries (en + zh-CN); Storybook stories for the block. - **Media**: video fills the card height at all widths (aspect ratio on the wrapper, player absolutely filling it with object-cover crop). ## Review Focus - `muteOnly` interaction with existing `minimal`/`hideControls` modes in VideoPlayer - CTA hrefs are `#` placeholders pending final URLs for model features and workflows pages --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…s block main (FE-1507) (#14717) *PR Created by the Glary-Bot Agent* --- ## Summary `pnpm typecheck:browser` was gated on a `browser_tests/**` paths filter, so type errors in the E2E suite could reach `main` — and nine of them already had. ## Changes - **What**: Removed the `dorny/paths-filter` step and the `if: steps.changed-paths.outputs.browser_tests == 'true'` gate from `.github/actions/lint-format-verify/action.yml`, so the browser typecheck runs on every PR, merge-queue and push run of the required `CI: Lint Format` check. Backfilled the `max_seats` / `occupied_seats` fields the cloud billing fixtures were missing, which is what the gate had been hiding. Why the gate was wrong on both sides: - A `src/` change can break `browser_tests` types without touching `browser_tests/**`. That is exactly what happened here: `BillingStatusResponse` gained required `max_seats` / `occupied_seats` in the ingest-types regen (#13499) and the fixtures were never updated. - `paths-filter` has no diff to inspect in `merge_group` runs, so the merge queue — the last gate before `main` — could not have caught it either. `pnpm typecheck:browser` on `main` today: ``` browser_tests/fixtures/data/cloudWorkspace.ts(84,3): error TS1360 browser_tests/fixtures/data/cloudWorkspace.ts(96,3): error TS1360 browser_tests/fixtures/helpers/CloudWorkspaceMockHelper.ts(51,5): error TS2739 browser_tests/tests/dialogs/endedSubscription.spec.ts(22,7): error TS2345 browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts(103,3): error TS1360 browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts(115,3): error TS1360 browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts(121,3): error TS1360 browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts(126,3): error TS1360 browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts(300,3): error TS1360 ``` On this branch it exits 0 in ~11s, so the always-on step adds negligible CI time. ## Review Focus - The added `max_seats` / `occupied_seats` values are mock-only: nothing in `src/` reads either field (the app's own `BillingStatusResponse` in `workspaceApi.ts` does not declare them), so no E2E behaviour changes. Values are anchored to existing fixture data — `TEAM_PLAN_MAX_SEATS` for the team plan's seat limit, `DEFAULT_TEAM_MEMBERS.length` for occupancy, `STANDARD_ANNUAL_PLAN.max_seats` for the personal plan. - The derived statuses (`ACTIVE_CREATOR_STATUS`, `LEGACY_ACTIVE_STANDARD_STATUS`, `RECOVERED_3DS_STATUS`) inherit the new fields through their spreads, so only the two base objects needed editing. - `dorny/paths-filter` is still used by `.github/actions/changes-filter/action.yaml`, so its pin remains exercised by `CI: Validate Action Pins`. Fixes FE-1507 ## Verification Ran the composite action's exact command sequence locally on this branch — `pnpm lint && pnpm stylelint && pnpm format:check && pnpm knip && pnpm typecheck:browser` — exit 0. `yamllint` (the `CI: YAML Validation` gate) clean on the changed action, and the parsed action confirms no `if:` remains on the typecheck step. Playwright could not confirm the two touched specs end-to-end here: `@cloud` specs need the cloud-distribution build, and against a plain `pnpm dev` server the settings dialog has no Workspace panel, so `endedSubscription.spec.ts` times out. It times out identically with these changes stashed, i.e. the failure is environmental, not a regression. No screenshots — the change has no UI surface. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
## ELI-5
The auto-backport bot can be kicked off by hand (Actions → PR Backport →
Run workflow) to retry a backport. That manual path was broken: the very
first step asked `gh` "is this PR merged?" before the repo was ever
checked out and without telling `gh` which repo to look in, so `gh`
couldn't resolve a repository and the run aborted with `PR #<n> not
found or inaccessible`. This gives the manual-trigger `gh` calls the
repo (and token) context they need so a hand-triggered backport actually
runs.
## Summary
Fix the `workflow_dispatch` (manual) path of `pr-backport.yaml`, which
failed immediately because `gh` had no repository context.
## Changes
- **What**:
- Add `GH_REPO: ${{ github.repository }}` to the
`workflow_dispatch`-only **Validate inputs for manual triggers** step.
This step runs before `actions/checkout`, so `gh` has no git remote to
infer the repo from; without `GH_REPO`/`--repo` it errors and reports
`PR #<n> not found or inaccessible`, aborting the run. (This is the
ticket's core one-line fix.)
- Also give the other two `workflow_dispatch`-only `gh` call sites the
same context — **Collect backport targets** (no `env` block at all) and
**Backport commits** (`env` had only `PR_NUMBER`) each call `gh pr view`
in the manual branch but carried no `GH_TOKEN`. In GitHub Actions `gh`
requires an explicit token, so without this the manual path would only
get past step 1 and then fail again at these steps. Every other `gh`
step in this workflow (and `backport-auto-merge.yaml`,
`pr-update-playwright-expectations.yaml`) already sets `GH_TOKEN`
explicitly — these two were the outliers, only exposed now that the
manual path can proceed.
- **Breaking**: None.
## Review Focus
- The automatic path (`pull_request_target`) is unaffected: those
branches read PR data from `GITHUB_EVENT_PATH` via `jq` and never invoke
`gh`, so the added env vars are simply unused there. The `gh` calls that
gained context all sit inside `if [ "$github.event_name" =
"workflow_dispatch" ]` guards.
- The load-bearing add on the two downstream steps is `GH_TOKEN` (they
run post-checkout, so repo resolves from the remote); `GH_REPO` is added
for explicit consistency with the validate step and this repo's
`--repo`-everywhere convention.
- Verification: `yamllint` (the repo's `CI: YAML Validation` gate)
passes on the changed file; there is no product-code surface, so no
unit/typecheck coverage applies to a CI-workflow-only change. The manual
dispatch itself can only be exercised end-to-end once merged (running
the workflow requires it to live on the default branch).
…4841) Bumps the vue group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@vueuse/router](https://github.com/vueuse/vueuse/tree/HEAD/packages/router) | `14.3.0` | `14.4.0` | | [@vueuse/integrations](https://github.com/vueuse/vueuse/tree/HEAD/packages/integrations) | `14.3.0` | `14.4.0` | | [vue-component-type-helpers](https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers) | `3.3.7` | `3.3.9` | | [vue-i18n](https://github.com/intlify/vue-i18n/tree/HEAD/packages/vue-i18n) | `11.4.6` | `11.4.8` | | [vue-tsc](https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc) | `3.3.7` | `3.3.9` | | [vue](https://github.com/vuejs/core) | `3.5.39` | `3.5.40` | Updates `@vueuse/router` from 14.3.0 to 14.4.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vueuse/vueuse/releases">@vueuse/router's releases</a>.</em></p> <blockquote> <h2>v14.4.0</h2> <h3> 🚀 Features</h3> <ul> <li>Update skills - by <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5491">vueuse/vueuse#5491</a> <a href="https://github.com/vueuse/vueuse/commit/f475894f"><!-- raw HTML omitted -->(f4758)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Disable <code>useColorMode</code> auto import if <code>@nuxtjs/color-mode</code> is detected - by <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5476">vueuse/vueuse#5476</a> <a href="https://github.com/vueuse/vueuse/commit/60687100"><!-- raw HTML omitted -->(60687)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Generate nuxt module builder output layout - by <a href="https://github.com/userquin"><code>@userquin</code></a> and <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5503">vueuse/vueuse#5503</a> <a href="https://github.com/vueuse/vueuse/commit/40a1f414"><!-- raw HTML omitted -->(40a1f)<!-- raw HTML omitted --></a></li> <li><strong>onStartTyping</strong>: Add more configurable options for <code>onStartTyping</code> - by <a href="https://github.com/LightQuanta"><code>@LightQuanta</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5395">vueuse/vueuse#5395</a> <a href="https://github.com/vueuse/vueuse/commit/1f2b7503"><!-- raw HTML omitted -->(1f2b7)<!-- raw HTML omitted --></a></li> <li><strong>useDebounceFn</strong>: Add flush and isPending to filter system - by <a href="https://github.com/pcoterecollective"><code>@pcoterecollective</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> and <a href="https://github.com/antfu"><code>@antfu</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5259">vueuse/vueuse#5259</a> <a href="https://github.com/vueuse/vueuse/commit/4aa1803a"><!-- raw HTML omitted -->(4aa18)<!-- raw HTML omitted --></a></li> <li><strong>useElementOverflow</strong>: New function - by <a href="https://github.com/inside5545"><code>@inside5545</code></a>, <strong>苏俊言</strong>, <a href="https://github.com/antfu"><code>@antfu</code></a>, <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a>, <a href="https://github.com/43081j"><code>@43081j</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/4094">vueuse/vueuse#4094</a> <a href="https://github.com/vueuse/vueuse/commit/d49f56df"><!-- raw HTML omitted -->(d49f5)<!-- raw HTML omitted --></a></li> <li><strong>useSpeechRecognition</strong>: Expose confidence of latest result - by <a href="https://github.com/SAY-5"><code>@SAY-5</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5398">vueuse/vueuse#5398</a> <a href="https://github.com/vueuse/vueuse/commit/17dc97f7"><!-- raw HTML omitted -->(17dc9)<!-- raw HTML omitted --></a></li> <li><strong>useVirtualList</strong>: Add options <code>behavior</code>, <code>block</code> and <code>inline</code> to exposed scrollTo method - by <a href="https://github.com/laurens94"><code>@laurens94</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a>, <a href="https://github.com/43081j"><code>@43081j</code></a> and <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/4905">vueuse/vueuse#4905</a> <a href="https://github.com/vueuse/vueuse/commit/0187570d"><!-- raw HTML omitted -->(01875)<!-- raw HTML omitted --></a></li> </ul> <h3> 🐞 Bug Fixes</h3> <ul> <li>Drop unnecessary <code>PURE</code> annotation to avoid Rollup warning - by <a href="https://github.com/serkodev"><code>@serkodev</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5388">vueuse/vueuse#5388</a> <a href="https://github.com/vueuse/vueuse/commit/169331dc"><!-- raw HTML omitted -->(16933)<!-- raw HTML omitted --></a></li> <li>Accept array template ref bound to v-for as observer target - by <a href="https://github.com/eldardada"><code>@eldardada</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5514">vueuse/vueuse#5514</a> <a href="https://github.com/vueuse/vueuse/commit/bccb159d"><!-- raw HTML omitted -->(bccb1)<!-- raw HTML omitted --></a></li> <li>Reintroduce package normalisation to nuxt package - by <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5551">vueuse/vueuse#5551</a> <a href="https://github.com/vueuse/vueuse/commit/c04c44a4"><!-- raw HTML omitted -->(c04c4)<!-- raw HTML omitted --></a></li> <li><strong>docs</strong>: Fix typo 'feedbacks' to 'feedback' in work-with-ai.md - by <a href="https://github.com/firstquarterlee"><code>@firstquarterlee</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5447">vueuse/vueuse#5447</a> <a href="https://github.com/vueuse/vueuse/commit/a4253752"><!-- raw HTML omitted -->(a4253)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Register formatTimeAgo variants for auto-import - by <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <a href="https://github.com/cursoragent"><code>@cursoragent</code></a> and <strong>Claude Opus 5</strong> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5492">vueuse/vueuse#5492</a> <a href="https://github.com/vueuse/vueuse/commit/8a908d7e"><!-- raw HTML omitted -->(8a908)<!-- raw HTML omitted --></a></li> <li><strong>skills</strong>: Correct broken relative links in generated function references - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> and <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5549">vueuse/vueuse#5549</a> <a href="https://github.com/vueuse/vueuse/commit/910db622"><!-- raw HTML omitted -->(910db)<!-- raw HTML omitted --></a></li> <li><strong>tests</strong>: Deduplicate ci test runs - by <a href="https://github.com/Tofandel"><code>@Tofandel</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5509">vueuse/vueuse#5509</a> <a href="https://github.com/vueuse/vueuse/commit/5b2721ff"><!-- raw HTML omitted -->(5b272)<!-- raw HTML omitted --></a></li> <li><strong>useBrowserLocation</strong>: Skip write-back watching on 'load' state - by <a href="https://github.com/Tobias-Braun"><code>@Tobias-Braun</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5485">vueuse/vueuse#5485</a> <a href="https://github.com/vueuse/vueuse/commit/fbdd2867"><!-- raw HTML omitted -->(fbdd2)<!-- raw HTML omitted --></a></li> <li><strong>useDraggable</strong>: End drag on pointercancel - by <a href="https://github.com/ShreeBohara"><code>@ShreeBohara</code></a> and <strong>Claude Opus 5</strong> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5550">vueuse/vueuse#5550</a> <a href="https://github.com/vueuse/vueuse/commit/6aa9d6d3"><!-- raw HTML omitted -->(6aa9d)<!-- raw HTML omitted --></a></li> <li><strong>useElementSize</strong>: Prefill size based on box option - by <a href="https://github.com/meta-syntax"><code>@meta-syntax</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5524">vueuse/vueuse#5524</a> <a href="https://github.com/vueuse/vueuse/commit/5fe49456"><!-- raw HTML omitted -->(5fe49)<!-- raw HTML omitted --></a></li> <li><strong>useEventBus</strong>: Use <code>tryOnScopeDispose</code> to avoid operating Vue internal API - by <a href="https://github.com/liangmiQwQ"><code>@liangmiQwQ</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5548">vueuse/vueuse#5548</a> <a href="https://github.com/vueuse/vueuse/commit/2cad765b"><!-- raw HTML omitted -->(2cad7)<!-- raw HTML omitted --></a></li> <li><strong>useFetch</strong>: Ignore stale abort error after refetch succeeds - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5525">vueuse/vueuse#5525</a> <a href="https://github.com/vueuse/vueuse/commit/8442658d"><!-- raw HTML omitted -->(84426)<!-- raw HTML omitted --></a></li> <li><strong>useFuse</strong>: Trigger fuse ref after setCollection - by <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <strong>Claude Opus 5</strong> and <a href="https://github.com/cursoragent"><code>@cursoragent</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5479">vueuse/vueuse#5479</a> <a href="https://github.com/vueuse/vueuse/commit/3e10ce87"><!-- raw HTML omitted -->(3e10c)<!-- raw HTML omitted --></a></li> <li><strong>useGamepad</strong>: Keep updating remaining gamepads after one disconnects - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5523">vueuse/vueuse#5523</a> <a href="https://github.com/vueuse/vueuse/commit/653283c0"><!-- raw HTML omitted -->(65328)<!-- raw HTML omitted --></a></li> <li><strong>usePointerSwipe</strong>: Handle pointercancel event to reset state and trigger onSwipeEnd - by <a href="https://github.com/DORI2001"><code>@DORI2001</code></a>, <strong>Dor Alagem</strong> and <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5379">vueuse/vueuse#5379</a> <a href="https://github.com/vueuse/vueuse/commit/4c08a856"><!-- raw HTML omitted -->(4c08a)<!-- raw HTML omitted --></a></li> <li><strong>useStyleTag</strong>: Avoid error when multiple components share the same id - by <a href="https://github.com/ben-lau"><code>@ben-lau</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5473">vueuse/vueuse#5473</a> <a href="https://github.com/vueuse/vueuse/commit/6d913829"><!-- raw HTML omitted -->(6d913)<!-- raw HTML omitted --></a></li> <li><strong>useVibrate</strong>: Make interval option optional - by <a href="https://github.com/Aluomolo"><code>@Aluomolo</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5490">vueuse/vueuse#5490</a> <a href="https://github.com/vueuse/vueuse/commit/305eef67"><!-- raw HTML omitted -->(305ee)<!-- raw HTML omitted --></a></li> <li><strong>useVirtualList</strong>: Recompute range when item size changes - by <a href="https://github.com/Antreesy"><code>@Antreesy</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5533">vueuse/vueuse#5533</a> <a href="https://github.com/vueuse/vueuse/commit/0f6d55d0"><!-- raw HTML omitted -->(0f6d5)<!-- raw HTML omitted --></a></li> <li><strong>useWebSocket</strong>: Sync status to 'CLOSED' after explicit close() - by <a href="https://github.com/WuMingDao"><code>@WuMingDao</code></a> and <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5471">vueuse/vueuse#5471</a> <a href="https://github.com/vueuse/vueuse/commit/351bf84e"><!-- raw HTML omitted -->(351bf)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vueuse/vueuse/compare/v14.3.0...v14.4.0">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vueuse/vueuse/commit/24160f9a8f1dcc576f1234008134ed47491c8183"><code>24160f9</code></a> chore: release v14.4.0 (<a href="https://github.com/vueuse/vueuse/tree/HEAD/packages/router/issues/5552">#5552</a>)</li> <li>See full diff in <a href="https://github.com/vueuse/vueuse/commits/v14.4.0/packages/router">compare view</a></li> </ul> </details> <br /> Updates `@vueuse/integrations` from 14.3.0 to 14.4.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vueuse/vueuse/releases">@vueuse/integrations's releases</a>.</em></p> <blockquote> <h2>v14.4.0</h2> <h3> 🚀 Features</h3> <ul> <li>Update skills - by <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5491">vueuse/vueuse#5491</a> <a href="https://github.com/vueuse/vueuse/commit/f475894f"><!-- raw HTML omitted -->(f4758)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Disable <code>useColorMode</code> auto import if <code>@nuxtjs/color-mode</code> is detected - by <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5476">vueuse/vueuse#5476</a> <a href="https://github.com/vueuse/vueuse/commit/60687100"><!-- raw HTML omitted -->(60687)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Generate nuxt module builder output layout - by <a href="https://github.com/userquin"><code>@userquin</code></a> and <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5503">vueuse/vueuse#5503</a> <a href="https://github.com/vueuse/vueuse/commit/40a1f414"><!-- raw HTML omitted -->(40a1f)<!-- raw HTML omitted --></a></li> <li><strong>onStartTyping</strong>: Add more configurable options for <code>onStartTyping</code> - by <a href="https://github.com/LightQuanta"><code>@LightQuanta</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5395">vueuse/vueuse#5395</a> <a href="https://github.com/vueuse/vueuse/commit/1f2b7503"><!-- raw HTML omitted -->(1f2b7)<!-- raw HTML omitted --></a></li> <li><strong>useDebounceFn</strong>: Add flush and isPending to filter system - by <a href="https://github.com/pcoterecollective"><code>@pcoterecollective</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> and <a href="https://github.com/antfu"><code>@antfu</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5259">vueuse/vueuse#5259</a> <a href="https://github.com/vueuse/vueuse/commit/4aa1803a"><!-- raw HTML omitted -->(4aa18)<!-- raw HTML omitted --></a></li> <li><strong>useElementOverflow</strong>: New function - by <a href="https://github.com/inside5545"><code>@inside5545</code></a>, <strong>苏俊言</strong>, <a href="https://github.com/antfu"><code>@antfu</code></a>, <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a>, <a href="https://github.com/43081j"><code>@43081j</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/4094">vueuse/vueuse#4094</a> <a href="https://github.com/vueuse/vueuse/commit/d49f56df"><!-- raw HTML omitted -->(d49f5)<!-- raw HTML omitted --></a></li> <li><strong>useSpeechRecognition</strong>: Expose confidence of latest result - by <a href="https://github.com/SAY-5"><code>@SAY-5</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5398">vueuse/vueuse#5398</a> <a href="https://github.com/vueuse/vueuse/commit/17dc97f7"><!-- raw HTML omitted -->(17dc9)<!-- raw HTML omitted --></a></li> <li><strong>useVirtualList</strong>: Add options <code>behavior</code>, <code>block</code> and <code>inline</code> to exposed scrollTo method - by <a href="https://github.com/laurens94"><code>@laurens94</code></a>, <a href="https://github.com/OrbisK"><code>@OrbisK</code></a>, <a href="https://github.com/43081j"><code>@43081j</code></a> and <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/4905">vueuse/vueuse#4905</a> <a href="https://github.com/vueuse/vueuse/commit/0187570d"><!-- raw HTML omitted -->(01875)<!-- raw HTML omitted --></a></li> </ul> <h3> 🐞 Bug Fixes</h3> <ul> <li>Drop unnecessary <code>PURE</code> annotation to avoid Rollup warning - by <a href="https://github.com/serkodev"><code>@serkodev</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5388">vueuse/vueuse#5388</a> <a href="https://github.com/vueuse/vueuse/commit/169331dc"><!-- raw HTML omitted -->(16933)<!-- raw HTML omitted --></a></li> <li>Accept array template ref bound to v-for as observer target - by <a href="https://github.com/eldardada"><code>@eldardada</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5514">vueuse/vueuse#5514</a> <a href="https://github.com/vueuse/vueuse/commit/bccb159d"><!-- raw HTML omitted -->(bccb1)<!-- raw HTML omitted --></a></li> <li>Reintroduce package normalisation to nuxt package - by <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5551">vueuse/vueuse#5551</a> <a href="https://github.com/vueuse/vueuse/commit/c04c44a4"><!-- raw HTML omitted -->(c04c4)<!-- raw HTML omitted --></a></li> <li><strong>docs</strong>: Fix typo 'feedbacks' to 'feedback' in work-with-ai.md - by <a href="https://github.com/firstquarterlee"><code>@firstquarterlee</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5447">vueuse/vueuse#5447</a> <a href="https://github.com/vueuse/vueuse/commit/a4253752"><!-- raw HTML omitted -->(a4253)<!-- raw HTML omitted --></a></li> <li><strong>nuxt</strong>: Register formatTimeAgo variants for auto-import - by <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <a href="https://github.com/cursoragent"><code>@cursoragent</code></a> and <strong>Claude Opus 5</strong> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5492">vueuse/vueuse#5492</a> <a href="https://github.com/vueuse/vueuse/commit/8a908d7e"><!-- raw HTML omitted -->(8a908)<!-- raw HTML omitted --></a></li> <li><strong>skills</strong>: Correct broken relative links in generated function references - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> and <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5549">vueuse/vueuse#5549</a> <a href="https://github.com/vueuse/vueuse/commit/910db622"><!-- raw HTML omitted -->(910db)<!-- raw HTML omitted --></a></li> <li><strong>tests</strong>: Deduplicate ci test runs - by <a href="https://github.com/Tofandel"><code>@Tofandel</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5509">vueuse/vueuse#5509</a> <a href="https://github.com/vueuse/vueuse/commit/5b2721ff"><!-- raw HTML omitted -->(5b272)<!-- raw HTML omitted --></a></li> <li><strong>useBrowserLocation</strong>: Skip write-back watching on 'load' state - by <a href="https://github.com/Tobias-Braun"><code>@Tobias-Braun</code></a> and <a href="https://github.com/9romise"><code>@9romise</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5485">vueuse/vueuse#5485</a> <a href="https://github.com/vueuse/vueuse/commit/fbdd2867"><!-- raw HTML omitted -->(fbdd2)<!-- raw HTML omitted --></a></li> <li><strong>useDraggable</strong>: End drag on pointercancel - by <a href="https://github.com/ShreeBohara"><code>@ShreeBohara</code></a> and <strong>Claude Opus 5</strong> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5550">vueuse/vueuse#5550</a> <a href="https://github.com/vueuse/vueuse/commit/6aa9d6d3"><!-- raw HTML omitted -->(6aa9d)<!-- raw HTML omitted --></a></li> <li><strong>useElementSize</strong>: Prefill size based on box option - by <a href="https://github.com/meta-syntax"><code>@meta-syntax</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5524">vueuse/vueuse#5524</a> <a href="https://github.com/vueuse/vueuse/commit/5fe49456"><!-- raw HTML omitted -->(5fe49)<!-- raw HTML omitted --></a></li> <li><strong>useEventBus</strong>: Use <code>tryOnScopeDispose</code> to avoid operating Vue internal API - by <a href="https://github.com/liangmiQwQ"><code>@liangmiQwQ</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5548">vueuse/vueuse#5548</a> <a href="https://github.com/vueuse/vueuse/commit/2cad765b"><!-- raw HTML omitted -->(2cad7)<!-- raw HTML omitted --></a></li> <li><strong>useFetch</strong>: Ignore stale abort error after refetch succeeds - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5525">vueuse/vueuse#5525</a> <a href="https://github.com/vueuse/vueuse/commit/8442658d"><!-- raw HTML omitted -->(84426)<!-- raw HTML omitted --></a></li> <li><strong>useFuse</strong>: Trigger fuse ref after setCollection - by <a href="https://github.com/ilyaliao"><code>@ilyaliao</code></a>, <strong>Claude Opus 5</strong> and <a href="https://github.com/cursoragent"><code>@cursoragent</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5479">vueuse/vueuse#5479</a> <a href="https://github.com/vueuse/vueuse/commit/3e10ce87"><!-- raw HTML omitted -->(3e10c)<!-- raw HTML omitted --></a></li> <li><strong>useGamepad</strong>: Keep updating remaining gamepads after one disconnects - by <a href="https://github.com/lazerg"><code>@lazerg</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5523">vueuse/vueuse#5523</a> <a href="https://github.com/vueuse/vueuse/commit/653283c0"><!-- raw HTML omitted -->(65328)<!-- raw HTML omitted --></a></li> <li><strong>usePointerSwipe</strong>: Handle pointercancel event to reset state and trigger onSwipeEnd - by <a href="https://github.com/DORI2001"><code>@DORI2001</code></a>, <strong>Dor Alagem</strong> and <a href="https://github.com/43081j"><code>@43081j</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5379">vueuse/vueuse#5379</a> <a href="https://github.com/vueuse/vueuse/commit/4c08a856"><!-- raw HTML omitted -->(4c08a)<!-- raw HTML omitted --></a></li> <li><strong>useStyleTag</strong>: Avoid error when multiple components share the same id - by <a href="https://github.com/ben-lau"><code>@ben-lau</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5473">vueuse/vueuse#5473</a> <a href="https://github.com/vueuse/vueuse/commit/6d913829"><!-- raw HTML omitted -->(6d913)<!-- raw HTML omitted --></a></li> <li><strong>useVibrate</strong>: Make interval option optional - by <a href="https://github.com/Aluomolo"><code>@Aluomolo</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5490">vueuse/vueuse#5490</a> <a href="https://github.com/vueuse/vueuse/commit/305eef67"><!-- raw HTML omitted -->(305ee)<!-- raw HTML omitted --></a></li> <li><strong>useVirtualList</strong>: Recompute range when item size changes - by <a href="https://github.com/Antreesy"><code>@Antreesy</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5533">vueuse/vueuse#5533</a> <a href="https://github.com/vueuse/vueuse/commit/0f6d55d0"><!-- raw HTML omitted -->(0f6d5)<!-- raw HTML omitted --></a></li> <li><strong>useWebSocket</strong>: Sync status to 'CLOSED' after explicit close() - by <a href="https://github.com/WuMingDao"><code>@WuMingDao</code></a> and <a href="https://github.com/OrbisK"><code>@OrbisK</code></a> in <a href="https://redirect.github.com/vueuse/vueuse/issues/5471">vueuse/vueuse#5471</a> <a href="https://github.com/vueuse/vueuse/commit/351bf84e"><!-- raw HTML omitted -->(351bf)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vueuse/vueuse/compare/v14.3.0...v14.4.0">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vueuse/vueuse/commit/24160f9a8f1dcc576f1234008134ed47491c8183"><code>24160f9</code></a> chore: release v14.4.0 (<a href="https://github.com/vueuse/vueuse/tree/HEAD/packages/integrations/issues/5552">#5552</a>)</li> <li><a href="https://github.com/vueuse/vueuse/commit/3e10ce87308265bd673c29874e2364e0b065d90c"><code>3e10ce8</code></a> fix(useFuse): trigger fuse ref after setCollection (<a href="https://github.com/vueuse/vueuse/tree/HEAD/packages/integrations/issues/5479">#5479</a>)</li> <li><a href="https://github.com/vueuse/vueuse/commit/de83a043b485244a1127d82e9f503b19bdada83f"><code>de83a04</code></a> docs: fix typo 'targetTow' to 'targetTwo' in useFocusTrap example (<a href="https://github.com/vueuse/vueuse/tree/HEAD/packages/integrations/issues/5501">#5501</a>)</li> <li>See full diff in <a href="https://github.com/vueuse/vueuse/commits/v14.4.0/packages/integrations">compare view</a></li> </ul> </details> <br /> Updates `vue-component-type-helpers` from 3.3.7 to 3.3.9 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vuejs/language-tools/releases">vue-component-type-helpers's releases</a>.</em></p> <blockquote> <h2>v3.3.9</h2> <h3>language-core</h3> <ul> <li><strong>feat:</strong> check unused generic type parameters (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6137">#6137</a>) - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>language-service</h3> <ul> <li><strong>fix:</strong> preserve trailing modifiers when completing in the middle of a directive (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6133">#6133</a>) - Thanks to <a href="https://github.com/lazerg"><code>@lazerg</code></a>!</li> <li><strong>fix:</strong> only replace current directive modifier on completion - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> <li><strong>fix:</strong> preserve current modifier when filtering completion duplicates - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>component-meta</h3> <ul> <li><strong>feat:</strong> expose runtime values of enum members in schema (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6131">#6131</a>) - Thanks to <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li><strong>fix:</strong> keep <code>getProgramAndFile</code> free of side effects (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6136">#6136</a>) - Thanks to <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>feat:</strong> migrate build and tests to <code>typescript-native-bridge</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6129">#6129</a>)</li> </ul> <h2>Our Sponsors ❤️</h2> <!-- raw HTML omitted --> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md">vue-component-type-helpers's changelog</a>.</em></p> <blockquote> <h2>3.3.9 (2026-07-31)</h2> <h3>component-meta</h3> <ul> <li><strong>feat:</strong> expose runtime values of enum members in schema (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6131">#6131</a>) - Thanks to <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li><strong>fix:</strong> keep <code>getProgramAndFile</code> free of side effects (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6136">#6136</a>) - Thanks to <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h3>language-core</h3> <ul> <li><strong>feat:</strong> check unused generic type parameters (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6137">#6137</a>) - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>language-service</h3> <ul> <li><strong>fix:</strong> preserve trailing modifiers when completing in the middle of a directive (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6133">#6133</a>) - Thanks to <a href="https://github.com/lazerg"><code>@lazerg</code></a>!</li> <li><strong>fix:</strong> only replace current directive modifier on completion - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> <li><strong>fix:</strong> preserve current modifier when filtering completion duplicates - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>feat:</strong> migrate build and tests to <code>typescript-native-bridge</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6129">#6129</a>)</li> </ul> <h2>3.3.8 (2026-07-22)</h2> <h3>language-core</h3> <ul> <li><strong>feat:</strong> support vapor directives (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6126">#6126</a>) - Thanks to <a href="https://github.com/liangmiQwQ"><code>@liangmiQwQ</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>chore:</strong> upgrade to TypeScript 7 and support <code>@typescript/typescript6</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6123">#6123</a>) - Thanks to <a href="https://github.com/WaldemarEnns"><code>@WaldemarEnns</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vuejs/language-tools/commit/51617b912fd53168fae7330fcabf9640ec5a1eee"><code>51617b9</code></a> v3.3.9 (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6138">#6138</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/876b0278ad0d1995c74c975c1f9fd4a8dc00e092"><code>876b027</code></a> v3.3.8 (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/component-type-helpers/issues/6128">#6128</a>)</li> <li>See full diff in <a href="https://github.com/vuejs/language-tools/commits/v3.3.9/packages/component-type-helpers">compare view</a></li> </ul> </details> <br /> Updates `vue-i18n` from 11.4.6 to 11.4.8 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/intlify/vue-i18n/releases">vue-i18n's releases</a>.</em></p> <blockquote> <h2>v11.4.8</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>👕 Refactoring</h3> <ul> <li>refactor: extract security sanitizer module by <a href="https://github.com/kazupon"><code>@kazupon</code></a> in <a href="https://redirect.github.com/intlify/vue-i18n/pull/2555">intlify/vue-i18n#2555</a></li> <li>refactor: unify intl formatting pipeline by <a href="https://github.com/kazupon"><code>@kazupon</code></a> in <a href="https://redirect.github.com/intlify/vue-i18n/pull/2556">intlify/vue-i18n#2556</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/intlify/vue-i18n/compare/v11.4.7...v11.4.8">https://github.com/intlify/vue-i18n/compare/v11.4.7...v11.4.8</a></p> <h2>v11.4.7</h2> <!-- raw HTML omitted --> <p><strong>Full Changelog</strong>: <a href="https://github.com/intlify/vue-i18n/compare/v11.4.6...v11.4.7">https://github.com/intlify/vue-i18n/compare/v11.4.6...v11.4.7</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/intlify/vue-i18n/commit/de2393bae16676a8a7c293bb493415e3085a521a"><code>de2393b</code></a> release: v11.4.8</li> <li><a href="https://github.com/intlify/vue-i18n/commit/ceb0548cb421b8aaf237fecda0394d8fd3d75da7"><code>ceb0548</code></a> release: v11.4.7</li> <li>See full diff in <a href="https://github.com/intlify/vue-i18n/commits/v11.4.8/packages/vue-i18n">compare view</a></li> </ul> </details> <br /> Updates `vue-tsc` from 3.3.7 to 3.3.9 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vuejs/language-tools/releases">vue-tsc's releases</a>.</em></p> <blockquote> <h2>v3.3.9</h2> <h3>language-core</h3> <ul> <li><strong>feat:</strong> check unused generic type parameters (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6137">#6137</a>) - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>language-service</h3> <ul> <li><strong>fix:</strong> preserve trailing modifiers when completing in the middle of a directive (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6133">#6133</a>) - Thanks to <a href="https://github.com/lazerg"><code>@lazerg</code></a>!</li> <li><strong>fix:</strong> only replace current directive modifier on completion - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> <li><strong>fix:</strong> preserve current modifier when filtering completion duplicates - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>component-meta</h3> <ul> <li><strong>feat:</strong> expose runtime values of enum members in schema (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6131">#6131</a>) - Thanks to <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li><strong>fix:</strong> keep <code>getProgramAndFile</code> free of side effects (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6136">#6136</a>) - Thanks to <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>feat:</strong> migrate build and tests to <code>typescript-native-bridge</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6129">#6129</a>)</li> </ul> <h2>Our Sponsors ❤️</h2> <!-- raw HTML omitted --> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md">vue-tsc's changelog</a>.</em></p> <blockquote> <h2>3.3.9 (2026-07-31)</h2> <h3>component-meta</h3> <ul> <li><strong>feat:</strong> expose runtime values of enum members in schema (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6131">#6131</a>) - Thanks to <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li><strong>fix:</strong> keep <code>getProgramAndFile</code> free of side effects (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6136">#6136</a>) - Thanks to <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h3>language-core</h3> <ul> <li><strong>feat:</strong> check unused generic type parameters (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6137">#6137</a>) - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>language-service</h3> <ul> <li><strong>fix:</strong> preserve trailing modifiers when completing in the middle of a directive (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6133">#6133</a>) - Thanks to <a href="https://github.com/lazerg"><code>@lazerg</code></a>!</li> <li><strong>fix:</strong> only replace current directive modifier on completion - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> <li><strong>fix:</strong> preserve current modifier when filtering completion duplicates - Thanks to <a href="https://github.com/KazariEX"><code>@KazariEX</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>feat:</strong> migrate build and tests to <code>typescript-native-bridge</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6129">#6129</a>)</li> </ul> <h2>3.3.8 (2026-07-22)</h2> <h3>language-core</h3> <ul> <li><strong>feat:</strong> support vapor directives (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6126">#6126</a>) - Thanks to <a href="https://github.com/liangmiQwQ"><code>@liangmiQwQ</code></a>!</li> </ul> <h3>workspace</h3> <ul> <li><strong>chore:</strong> upgrade to TypeScript 7 and support <code>@typescript/typescript6</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6123">#6123</a>) - Thanks to <a href="https://github.com/WaldemarEnns"><code>@WaldemarEnns</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vuejs/language-tools/commit/51617b912fd53168fae7330fcabf9640ec5a1eee"><code>51617b9</code></a> v3.3.9 (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6138">#6138</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/9d08c434df99a97083a1f08c149bb55621a57a31"><code>9d08c43</code></a> feat(language-core): check unused generic type parameters (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6137">#6137</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/c99eb007cc14538bc400379539c43d31ec3caced"><code>c99eb00</code></a> fix(component-meta): keep <code>getProgramAndFile</code> free of side effects (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6136">#6136</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/00ce7ec19bd62c6ed9d8e0a3c4951d4ac23e8540"><code>00ce7ec</code></a> feat(component-meta): expose runtime values of enum members in schema (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6131">#6131</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/c4e58eaaa3c8eec542f161e0a3980bd9396e1c08"><code>c4e58ea</code></a> feat: migrate build and tests to typescript-native-bridge (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6129">#6129</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/876b0278ad0d1995c74c975c1f9fd4a8dc00e092"><code>876b027</code></a> v3.3.8 (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6128">#6128</a>)</li> <li><a href="https://github.com/vuejs/language-tools/commit/1ef7ecbd0ab9b475e8e3aed791a1606be8bfa8d1"><code>1ef7ecb</code></a> chore: upgrade to TypeScript 7 & compat with <code>@typescript/typescript6</code> (<a href="https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc/issues/6123">#6123</a>)</li> <li>See full diff in <a href="https://github.com/vuejs/language-tools/commits/v3.3.9/packages/tsc">compare view</a></li> </ul> </details> <br /> Updates `vue` from 3.5.39 to 3.5.40 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vuejs/core/releases">vue's releases</a>.</em></p> <blockquote> <h2>v3.5.40</h2> <p>For stable releases, please refer to <a href="https://github.com/vuejs/core/blob/main/CHANGELOG.md">CHANGELOG.md</a> for details. For pre-releases, please refer to <a href="https://github.com/vuejs/core/blob/minor/CHANGELOG.md">CHANGELOG.md</a> of the <code>minor</code> branch.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vuejs/core/blob/main/CHANGELOG.md">vue's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/vuejs/core/compare/v3.5.39...v3.5.40">3.5.40</a> (2026-07-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler-core:</strong> avoid leaking slot branch keys (<a href="https://redirect.github.com/vuejs/core/issues/15051">#15051</a>) (<a href="https://github.com/vuejs/core/commit/20c9d263d3bfafdfbcc1921f259fd8f711e18659">20c9d26</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15048">#15048</a></li> <li><strong>hydration:</strong> pass namespace when patching dynamic props (<a href="https://redirect.github.com/vuejs/core/issues/15082">#15082</a>) (<a href="https://github.com/vuejs/core/commit/e0d27234ddd2061383cb5dcc475d6b9558ed8e4f">e0d2723</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15081">#15081</a> <a href="https://redirect.github.com/vuejs/core/issues/15050">#15050</a></li> <li><strong>reactivity:</strong> handle effect removal during scope stop (<a href="https://redirect.github.com/vuejs/core/issues/15084">#15084</a>) (<a href="https://github.com/vuejs/core/commit/378f9783248a4a4f20781d665d4f7089f39cae6e">378f978</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15083">#15083</a></li> <li><strong>runtime-core:</strong> skip lazy hydration for detached roots (<a href="https://redirect.github.com/vuejs/core/issues/15092">#15092</a>) (<a href="https://github.com/vuejs/core/commit/97f3525551ad06103083eb2cbf9858c5e57cd58e">97f3525</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15091">#15091</a></li> <li><strong>runtime-core:</strong> unwind dangling blocks when slot content throws (<a href="https://redirect.github.com/vuejs/core/issues/15071">#15071</a>) (<a href="https://github.com/vuejs/core/commit/ddc132d7c054ecd2029ddcc95bcba770cd44f022">ddc132d</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15070">#15070</a></li> <li><strong>runtime-dom:</strong> respect current select model type (<a href="https://redirect.github.com/vuejs/core/issues/15010">#15010</a>) (<a href="https://github.com/vuejs/core/commit/eb89e935a771ab7fc3f8e67a82bc8fc7ea28bdaa">eb89e93</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/15009">#15009</a></li> <li><strong>server-renderer:</strong> handle errors in optimized component renders (<a href="https://redirect.github.com/vuejs/core/issues/12601">#12601</a>) (<a href="https://github.com/vuejs/core/commit/474907c0f01d021c564545137051a2b56eb4a769">474907c</a>), closes <a href="https://redirect.github.com/vuejs/core/issues/12575">#12575</a></li> <li><strong>server-renderer:</strong> remove package dependency cycle (<a href="https://redirect.github.com/vuejs/core/issues/15063">#15063</a>) (<a href="https://github.com/vuejs/core/commit/4d35ecadb6f625b0f7407ccee0e357c2dd8084c7">4d35eca</a>)</li> <li><strong>shared:</strong> prevent SSR comment escaping from creating closing delimiters (<a href="https://redirect.github.com/vuejs/core/issues/15045">#15045</a>) (<a href="https://github.com/vuejs/core/commit/bd962bbaca746d8f65775a07723420406ebad0da">bd962bb</a>)</li> <li><strong>types:</strong> don't constrain component $el type to Element (<a href="https://redirect.github.com/vuejs/core/issues/15040">#15040</a>) (<a href="https://github.com/vuejs/core/commit/164460a52988c44dc34a541219c88120078372a0">164460a</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vuejs/core/commit/fa2885d8c48768d26f1666a01bd540ffe3b20f9b"><code>fa2885d</code></a> release: v3.5.40</li> <li><a href="https://github.com/vuejs/core/commit/20c9d263d3bfafdfbcc1921f259fd8f711e18659"><code>20c9d26</code></a> fix(compiler-core): avoid leaking slot branch keys (<a href="https://redirect.github.com/vuejs/core/issues/15051">#15051</a>)</li> <li><a href="https://github.com/vuejs/core/commit/7da6334f6162927cd41f9f369145722509540990"><code>7da6334</code></a> Revert "fix(runtime-core): pause tracking when invoking function refs" (<a href="https://redirect.github.com/vuejs/core/issues/15094">#15094</a>)</li> <li><a href="https://github.com/vuejs/core/commit/90aecb1d21b7d029543e6dc4825c3d80dd769312"><code>90aecb1</code></a> chore(deps): update all non-major dependencies (<a href="https://redirect.github.com/vuejs/core/issues/15026">#15026</a>)</li> <li><a href="https://github.com/vuejs/core/commit/97f3525551ad06103083eb2cbf9858c5e57cd58e"><code>97f3525</code></a> fix(runtime-core): skip lazy hydration for detached roots (<a href="https://redirect.github.com/vuejs/core/issues/15092">#15092</a>)</li> <li><a href="https://github.com/vuejs/core/commit/fe1c0f8494c10bc677b0bf8ec7fa518e3f15569e"><code>fe1c0f8</code></a> chore(deps): update test (<a href="https://redirect.github.com/vuejs/core/issues/15025">#15025</a>)</li> <li><a href="https://github.com/vuejs/core/commit/e41c45a78a97b4f7422059eb274479d8e8b5886f"><code>e41c45a</code></a> chore(deps): update dependency conventional-changelog to v8 (<a href="https://redirect.github.com/vuejs/core/issues/15078">#15078</a>)</li> <li><a href="https://github.com/vuejs/core/commit/3eb66a9f6238d99632ce0dd2971ed66b7fc6a671"><code>3eb66a9</code></a> chore(deps): update actions/cache action to v6 (<a href="https://redirect.github.com/vuejs/core/issues/15076">#15076</a>)</li> <li><a href="https://github.com/vuejs/core/commit/40178ddfc2b80c77db0f25a3d69819c9f5a3b689"><code>40178dd</code></a> chore(deps): update lint (<a href="https://redirect.github.com/vuejs/core/issues/15075">#15075</a>)</li> <li><a href="https://github.com/vuejs/core/commit/7f122b9bb85349e323ad3d025cdb4eab28d76de0"><code>7f122b9</code></a> chore(deps): update dependency conventional-changelog-angular to v9 (<a href="https://redirect.github.com/vuejs/core/issues/15079">#15079</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vuejs/core/compare/v3.5.39...v3.5.40">compare view</a></li> </ul> </details> <br /> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
…ates (#14392) Bumps the vite-vitest group with 2 updates in the / directory: [vite-plugin-vue-devtools](https://github.com/vuejs/devtools/tree/HEAD/packages/vite) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `vite-plugin-vue-devtools` from 8.1.5 to 8.2.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vuejs/devtools/releases">vite-plugin-vue-devtools's releases</a>.</em></p> <blockquote> <h2>v8.2.1</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li><strong>core</strong>: Avoid bundling Vite and Vue Router types in declarations - by <a href="https://github.com/webfansplz"><code>@webfansplz</code></a> <a href="https://github.com/vuejs/devtools/commit/8f51aaea"><!-- raw HTML omitted -->(8f51a)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vuejs/devtools/compare/v8.2.0...v8.2.1">View changes on GitHub</a></h5> <h2>v8.2.0</h2> <h3> 🚀 Features</h3> <ul> <li><strong>devtools-api</strong>: Add no-op stub under node export condition - by <a href="https://github.com/danielroe"><code>@danielroe</code></a> in <a href="https://redirect.github.com/vuejs/devtools/issues/1114">vuejs/devtools#1114</a> <a href="https://github.com/vuejs/devtools/commit/435e607a"><!-- raw HTML omitted -->(435e6)<!-- raw HTML omitted --></a></li> </ul> <h3> 🐞 Bug Fixes</h3> <ul> <li><strong>client</strong>: Disable pin reorder buttons at list bounds - by <a href="https://github.com/SaKaNa-Y"><code>@SaKaNa-Y</code></a> in <a href="https://redirect.github.com/vuejs/devtools/issues/1105">vuejs/devtools#1105</a> <a href="https://github.com/vuejs/devtools/commit/87d3829b"><!-- raw HTML omitted -->(87d38)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vuejs/devtools/compare/v8.1.5...v8.2.0">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vuejs/devtools/commit/4419695f100f43ed880995dabf0cd68651b365db"><code>4419695</code></a> chore: release v8.2.1</li> <li><a href="https://github.com/vuejs/devtools/commit/0dea144ef7db1ff1f6181305544e5f7390b48657"><code>0dea144</code></a> chore: release v8.2.0</li> <li>See full diff in <a href="https://github.com/vuejs/devtools/commits/v8.2.1/packages/vite">compare view</a></li> </ul> </details> <br /> Updates `vite` from 8.1.4 to 8.2.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p> <blockquote> <h2>create-vite@8.2.0</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/create-vite@8.2.0/packages/create-vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>plugin-legacy@8.2.0</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/plugin-legacy@8.2.0/packages/plugin-legacy/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.2.0</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.2.0/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.2.0-beta.0</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.2.0-beta.0/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.1.5</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.1.5/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/vitejs/vite/compare/v8.2.0-beta.0...v8.2.0">8.2.0</a> (2026-07-30)</h2> <h3>Features</h3> <ul> <li>add <code>input</code> to <code>server.fs.allow</code> (<a href="https://redirect.github.com/vitejs/vite/issues/23035">#23035</a>) (<a href="https://github.com/vitejs/vite/commit/95a3cdab83e1125b03d2e8dd942fb6b64209e5fa">95a3cda</a>)</li> <li><strong>bundled-dev:</strong> reload once after rebuild instead of via the fallback page (<a href="https://redirect.github.com/vitejs/vite/issues/23106">#23106</a>) (<a href="https://github.com/vitejs/vite/commit/b24381d741941b9ce2b1c07db62cc5f4d7bad981">b24381d</a>)</li> <li><strong>bundled-dev:</strong> support worker file update accepted by HMR (<a href="https://redirect.github.com/vitejs/vite/issues/23068">#23068</a>) (<a href="https://github.com/vitejs/vite/commit/0d04351fdc12258c75b9f1cda5780fdb836ed0ef">0d04351</a>)</li> <li><strong>config:</strong> include column in config incompatibility location (<a href="https://redirect.github.com/vitejs/vite/issues/23064">#23064</a>) (<a href="https://github.com/vitejs/vite/commit/8a245726944ed29225920d49be77c33c6e03afc8">8a24572</a>)</li> <li><strong>dev:</strong> resolve interface name for explicit host in network URLs (<a href="https://redirect.github.com/vitejs/vite/issues/22965">#22965</a>) (<a href="https://github.com/vitejs/vite/commit/3ac77d9dd742968961af38a5a91ed6b061ceda7d">3ac77d9</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>bundledDev:</strong> print build errors to the terminal when an HMR update fails (<a href="https://redirect.github.com/vitejs/vite/issues/23024">#23024</a>) (<a href="https://github.com/vitejs/vite/commit/41c465896e8b11b1eb9c5fbdafbdcc528e189a2c">41c4658</a>)</li> <li><strong>deps:</strong> update all non-major dependencies (<a href="https://redirect.github.com/vitejs/vite/issues/23069">#23069</a>) (<a href="https://github.com/vitejs/vite/commit/4c07b74416f859d7e8bdace13409ef2d080edf76">4c07b74</a>)</li> <li><strong>hmr:</strong> preserve environment snapshot during server restart (<a href="https://redirect.github.com/vitejs/vite/issues/22992">#22992</a>) (<a href="https://github.com/vitejs/vite/commit/b1186c36d06bb94941c58e8272fc4acb8512c93b">b1186c3</a>)</li> <li><strong>importAnalysis:</strong> interop imports injected into optimized dep files by plugins (<a href="https://redirect.github.com/vitejs/vite/issues/23029">#23029</a>) (<a href="https://github.com/vitejs/vite/commit/8c2a87d41fb24536e59643351758084cde4d0dd7">8c2a87d</a>)</li> <li><strong>module-runner:</strong> keep stack trace interception working when <code>Object.prototype</code> is frozen (<a href="https://redirect.github.com/vitejs/vite/issues/23073">#23073</a>) (<a href="https://github.com/vitejs/vite/commit/599c5b02a8b6879b05ede988020f1331e877aaea">599c5b0</a>)</li> <li><strong>server:</strong> strip base in indexHtml module graph lookup (<a href="https://redirect.github.com/vitejs/vite/issues/22932">#22932</a>) (<a href="https://github.com/vitejs/vite/commit/fa005d19af5d847931c6dbefc63841c137383e6c">fa005d1</a>)</li> <li>support resolving top-level input option with plugins (<a href="https://redirect.github.com/vitejs/vite/issues/23101">#23101</a>) (<a href="https://github.com/vitejs/vite/commit/41df81a6a4c3eef08f7a9a8ac9530cd136c0eafa">41df81a</a>)</li> </ul> <h3>Documentation</h3> <ul> <li><strong>config:</strong> correct cacheDir default fallback description (<a href="https://redirect.github.com/vitejs/vite/issues/23060">#23060</a>) (<a href="https://github.com/vitejs/vite/commit/aafa103af5d71fb59d7c3dd617d0cbef3b222f1f">aafa103</a>)</li> </ul> <h3>Tests</h3> <ul> <li>config CJS module vars in ESM case (<a href="https://redirect.github.com/vitejs/vite/issues/23010">#23010</a>) (<a href="https://github.com/vitejs/vite/commit/d8cd38830251b95fd7dddcd0eee0ce94cc61c2f4">d8cd388</a>)</li> </ul> <h2><a href="https://github.com/vitejs/vite/compare/v8.1.5...v8.2.0-beta.0">8.2.0-beta.0</a> (2026-07-22)</h2> <h3>Features</h3> <ul> <li>add <code>input</code> option (<a href="https://redirect.github.com/vitejs/vite/issues/22642">#22642</a>) (<a href="https://github.com/vitejs/vite/commit/9beae37d7221b25463a011feb40b0303ca328d87">9beae37</a>)</li> <li><strong>config:</strong> warn features incompatible with native loader in bundle loader (<a href="https://redirect.github.com/vitejs/vite/issues/22850">#22850</a>) (<a href="https://github.com/vitejs/vite/commit/05302b07267f6b4f9dbeac5b1d73fcc3dc06d730">05302b0</a>)</li> <li><strong>css:</strong> export PostCSS config type for type-safe configs (<a href="https://redirect.github.com/vitejs/vite/issues/22792">#22792</a>) (<a href="https://github.com/vitejs/vite/commit/302c755a8125b9a26214e3b413922b5513e41981">302c755</a>)</li> <li><strong>dev:</strong> label network URLs with their interface name (<a href="https://redirect.github.com/vitejs/vite/issues/22830">#22830</a>) (<a href="https://github.com/vitejs/vite/commit/78accc42a5b8887d9df624f7d4a934d3ead677d1">78accc4</a>)</li> <li><strong>optimizer:</strong> support aube lockfile (<a href="https://redirect.github.com/vitejs/vite/issues/22813">#22813</a>) (<a href="https://github.com/vitejs/vite/commit/6319827116c5be2a19c1b91c84ba3d38ad26a41c">6319827</a>)</li> <li><strong>optimizer:</strong> support nub lockfile (<a href="https://redirect.github.com/vitejs/vite/issues/22891">#22891</a>) (<a href="https://github.com/vitejs/vite/commit/65d3604f6fdbfcf6e86244d7fe3c1ca86acae701">65d3604</a>)</li> <li>update rolldown-related dependencies and use client-side HMR in bundled-dev (<a href="https://redirect.github.com/vitejs/vite/issues/22961">#22961</a>) (<a href="https://github.com/vitejs/vite/commit/960e9efbc1372000caac46cc2f123cef4824e2bb">960e9ef</a>)</li> <li><strong>wasm:</strong> expand test suite, unwrap WebAssembly.Global and enable js-string builtins (<a href="https://redirect.github.com/vitejs/vite/issues/22674">#22674</a>) (<a href="https://github.com/vitejs/vite/commit/9e79b51579457a9af4fa623b68a0bfabbf38010b">9e79b51</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>build:</strong> map CSS chunks in chunk import maps (fix <a href="https://redirect.github.com/vitejs/vite/issues/22946">#22946</a>) (<a href="https://redirect.github.com/vitejs/vite/issues/22947">#22947</a>) (<a href="https://github.com/vitejs/vite/commit/e16ff3a1199293ac9cdfa6132c08fdea162215f3">e16ff3a</a>)</li> <li><strong>config:</strong> exclude virtual modules from native config compat check (<a href="https://redirect.github.com/vitejs/vite/issues/22979">#22979</a>) (<a href="https://github.com/vitejs/vite/commit/2ced1fe4e4e480ed78cb7aa5c78319e57bfa7783">2ced1fe</a>)</li> <li><strong>css:</strong> rewrite urls in OnceExit-injected content (<a href="https://redirect.github.com/vitejs/vite/issues/22983">#22983</a>) (<a href="https://github.com/vitejs/vite/commit/abb793e18c92592c21fbb8e1f3fc450b5839f04f">abb793e</a>)</li> <li><strong>deps:</strong> update all non-major dependencies (<a href="https://redirect.github.com/vitejs/vite/issues/22985">#22985</a>) (<a href="https://github.com/vitejs/vite/commit/04f345b37064cd0bba6447eb5c32be5c22162f3d">04f345b</a>)</li> <li><strong>deps:</strong> update dependency magic-string to v1 (<a href="https://redirect.github.com/vitejs/vite/issues/22998">#22998</a>) (<a href="https://github.com/vitejs/vite/commit/c60b4d7cdb85b7d4f78671cdcfb863e5f8b66bb7">c60b4d7</a>)</li> <li><strong>hmr:</strong> remove hot data after prune (<a href="https://redirect.github.com/vitejs/vite/issues/23002">#23002</a>) (<a href="https://github.com/vitejs/vite/commit/be9631658f5191ee5c5665e780239d42a330280a">be96316</a>)</li> <li>resolve root to real path (<a href="https://redirect.github.com/vitejs/vite/issues/22832">#22832</a>) (<a href="https://github.com/vitejs/vite/commit/55bba7bbd9de40d031360e4408fe91bff5b29ec9">55bba7b</a>)</li> </ul> <h3>Performance Improvements</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/vite/commit/24a611f1c83a976d32262628d42f683609746635"><code>24a611f</code></a> release: v7.2.4</li> <li><a href="https://github.com/vitejs/vite/commit/2d66b7b14aa6dfd62f3d6a59ee8382ed5ca6fd32"><code>2d66b7b</code></a> fix: revert "perf(deps): replace debug with obug (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21107">#21107</a>)"</li> <li><a href="https://github.com/vitejs/vite/commit/a668014dba377c2b82a32d8124f1761e9ea74f82"><code>a668014</code></a> release: v7.2.3</li> <li><a href="https://github.com/vitejs/vite/commit/acfe939e1f7c303c34b0b39b883cc302da767fa2"><code>acfe939</code></a> perf(deps): replace debug with obug (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21107">#21107</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/4f8171eb3046bd70c83964689897dab4c6b58bc0"><code>4f8171e</code></a> fix(deps): update all non-major dependencies (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21128">#21128</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/50297208452241061cb44d09a4bbdf77a11ac01e"><code>5029720</code></a> chore(deps): update rolldown-related dependencies (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21127">#21127</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/5909efd8fbfd1bf1eab65427aea0613124b2797a"><code>5909efd</code></a> fix: allow multiple <code>bindCLIShortcuts</code> calls with shortcut merging (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21103">#21103</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/39a0a15fd24ed37257c48b795097a3794e54d255"><code>39a0a15</code></a> chore(deps): update rolldown-related dependencies (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21095">#21095</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/6a34ac3422686e7cf7cc9a25d299cb8e5a8d92a0"><code>6a34ac3</code></a> fix(deps): update all non-major dependencies (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21096">#21096</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/02ceaec45e17bef19159188a28d9196fed1761be"><code>02ceaec</code></a> chore(deps): update dependency <code>@rollup/plugin-commonjs</code> to v29 (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/21099">#21099</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vitejs/vite/commits/create-vite@8.2.0/packages/vite">compare view</a></li> </ul> </details> <br /> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fdd9b-6402-755a-be5b-5e59c15658a7 Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1784 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-07T20:00:16.602Z",
"gitSha": "2eed35ea9ddfbfa6096bac46108c22067a3f6b32",
"branch": "dante01yoon/gate-billing-banner-on-payment-recovery",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.1640000000048,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.33000000000004,
"heapDeltaBytes": 5623184,
"heapUsedBytes": 69666764,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 21.284,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2010.5779999999527,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.399,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.43300000000005,
"heapDeltaBytes": 5429036,
"heapUsedBytes": 69562700,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.849,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.8800000000479,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.699,
"layouts": 12,
"layoutDurationMs": 3.72,
"taskDurationMs": 903.925,
"heapDeltaBytes": -10867492,
"heapUsedBytes": 53019548,
"domNodes": -279,
"jsHeapTotalBytes": 24883200,
"scriptDurationMs": 119.02099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.6179999999258,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.489,
"layouts": 12,
"layoutDurationMs": 5.876,
"taskDurationMs": 881.696,
"heapDeltaBytes": -16064732,
"heapUsedBytes": 48014280,
"domNodes": -280,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 111.36500000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.4280000000326,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.5,
"layouts": 6,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 396.496,
"heapDeltaBytes": 8657276,
"heapUsedBytes": 72874988,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.477999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.267000000027,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.500000000000004,
"layouts": 6,
"layoutDurationMs": 0.8619999999999999,
"taskDurationMs": 400.622,
"heapDeltaBytes": 8663188,
"heapUsedBytes": 72739000,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 23.867,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 630.5610000000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.7540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.65799999999996,
"heapDeltaBytes": -10947348,
"heapUsedBytes": 53049328,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 57.271,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 596.6760000000022,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.1160000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.971,
"heapDeltaBytes": -11017012,
"heapUsedBytes": 53055432,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 54.854000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.2749999999887,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.9150000000002,
"heapDeltaBytes": 5201956,
"heapUsedBytes": 64981972,
"domNodes": -281,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 99.855,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.52700000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.989999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.6840000000001,
"heapDeltaBytes": 7836012,
"heapUsedBytes": 67723936,
"domNodes": -283,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 96.32,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2141.168999999991,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.888999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1254.4950000000001,
"heapDeltaBytes": 1443252,
"heapUsedBytes": 62012040,
"domNodes": -285,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 397.28000000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2179.3239999999514,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.602999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1292.425,
"heapDeltaBytes": -5147968,
"heapUsedBytes": 55288548,
"domNodes": -282,
"jsHeapTotalBytes": 4562944,
"scriptDurationMs": 412.355,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3303.422000000012,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.856,
"layouts": 60,
"layoutDurationMs": 9.479,
"taskDurationMs": 1572.537,
"heapDeltaBytes": 2394528,
"heapUsedBytes": 64799672,
"domNodes": -290,
"jsHeapTotalBytes": 6922240,
"scriptDurationMs": 536.886,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3296.6299999999364,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.349000000000004,
"layouts": 60,
"layoutDurationMs": 9.404,
"taskDurationMs": 1540.4850000000001,
"heapDeltaBytes": 902060,
"heapUsedBytes": 64614084,
"domNodes": -291,
"jsHeapTotalBytes": 6397952,
"scriptDurationMs": 501.00100000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.5360000000028,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.289000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.282,
"heapDeltaBytes": 7272904,
"heapUsedBytes": 71049448,
"domNodes": -284,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 99.72500000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.2470000000785,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.8919999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.325,
"heapDeltaBytes": 6725968,
"heapUsedBytes": 67156896,
"domNodes": -282,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 97.802,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.5070000000192,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.51699999999994,
"heapDeltaBytes": -10771120,
"heapUsedBytes": 53351632,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 122.77000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.6889999999448,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.46799999999996,
"heapDeltaBytes": -10419976,
"heapUsedBytes": 53741948,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 112.881,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.8959999999788,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.119,
"heapDeltaBytes": -17909792,
"heapUsedBytes": 46336616,
"domNodes": -277,
"jsHeapTotalBytes": 24358912,
"scriptDurationMs": 19.483999999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.952000000074,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.114,
"heapDeltaBytes": 5129116,
"heapUsedBytes": 69219644,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 18.633,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.8459999999795,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.812000000000005,
"layouts": 16,
"layoutDurationMs": 4.522,
"taskDurationMs": 764.038,
"heapDeltaBytes": -3988460,
"heapUsedBytes": 60192188,
"domNodes": 66,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 88.44099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1745.3990000000204,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.445,
"layouts": 16,
"layoutDurationMs": 4.906,
"taskDurationMs": 847.853,
"heapDeltaBytes": -17438928,
"heapUsedBytes": 46748380,
"domNodes": -278,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 90.492,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.6720000000428,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.65800000000001,
"layouts": 15,
"layoutDurationMs": 10.515,
"taskDurationMs": 892.6539999999999,
"heapDeltaBytes": 31068016,
"heapUsedBytes": 101132196,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 42.95299999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8204.531999999972,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.71300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4484.242,
"heapDeltaBytes": 8155720,
"heapUsedBytes": 67966640,
"domNodes": -281,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 1339.915,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8212.247000000047,
"styleRecalcs": 249,
"styleRecalcDurationMs": 45.248000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4500.195,
"heapDeltaBytes": 8141344,
"heapUsedBytes": 67818144,
"domNodes": -280,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1312.535,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14528.957999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14512.607000000002,
"heapDeltaBytes": -47624212,
"heapUsedBytes": 165672072,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 515.6780000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14341.346000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14318.450000000003,
"heapDeltaBytes": -50252692,
"heapUsedBytes": 165589440,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 517.406,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17617.58500000002,
"styleRecalcs": 121,
"styleRecalcDurationMs": 19.355999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17591.947,
"heapDeltaBytes": -39828884,
"heapUsedBytes": 166684136,
"domNodes": -8312,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 873.184,
"eventListeners": -16385,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17387.692000000017,
"styleRecalcs": 118,
"styleRecalcDurationMs": 18.58399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17351.429,
"heapDeltaBytes": -59469000,
"heapUsedBytes": 169285424,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 855.307,
"eventListeners": -16383,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 456.26900000002024,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.014,
"layouts": 3,
"layoutDurationMs": 1.4720000000000002,
"taskDurationMs": 131.556,
"heapDeltaBytes": 5369228,
"heapUsedBytes": 68774784,
"domNodes": 134,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.777,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 473.5090000000355,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.477,
"layouts": 2,
"layoutDurationMs": 0.629,
"taskDurationMs": 120.59400000000001,
"heapDeltaBytes": 5083052,
"heapUsedBytes": 68412596,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 17.153000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dante01yoon/payment-recovery-rollback-fix #14909 +/- ##
=============================================================================
- Coverage 79.72% 79.53% -0.19%
=============================================================================
Files 1804 1795 -9
Lines 117464 116785 -679
Branches 33648 34288 +640
=============================================================================
- Hits 93645 92887 -758
- Misses 23261 23338 +77
- Partials 558 560 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 52 files with indirect coverage changes 🚀 New features to boost your workflow:
|
## Summary
Configure the existing Fallow integration to separate new regressions
from inherited debt. The goal is simple: make problems visible, block
new ones, and steadily reduce the baseline.
## Quality Dashboard
| Signal | Result |
| --- | ---: |
| Changed files | 17 |
| Stale mocks removed | 11 |
| New audit findings | **0** |
| Generated clone groups excluded | 63 |
| Inherited clone groups tracked | 24 |
```mermaid
flowchart LR
A[Changed code] --> B[Fallow audit]
B --> C{Finding provenance}
C -->|New regression| D[Fail the gate]
C -->|Inherited debt| E[Track in baseline]
E --> F[Remove deliberately]
F --> G[Smaller baseline]
```
```mermaid
pie showData
title Duplication signal after generated-code filtering
"Generated noise excluded" : 63
"Inherited clone groups tracked" : 24
```
The baseline is a debt ledger, not a success metric. Every cleanup
should make it smaller; no change should make it larger without explicit
review.
## Changes
- **Configuration**: Add documented, narrow exceptions in
`.fallowrc.jsonc`, pin its schema to Fallow 2.104.0, and exclude
generated outputs from duplication analysis.
- **Baselines**: Record inherited findings in `.fallow-baselines/` for
`new-only` audits.
- **Cleanup**: Remove 11 inert `vi.mock()` declarations that reference
deleted or moved modules.
- **Documentation**: Add ADR 0015 with adoption rationale, tradeoffs,
and tracked follow-ups.
## Review Focus
- Every exception should represent generated, dynamically loaded, public
API, or tool-entry code—not hidden actionable debt.
- Baselines should capture inherited debt without weakening thresholds
or disabling rules.
Validation: `fallow audit --base origin/main`, dead-code and duplication
baseline comparisons, targeted unit tests, formatting, linting, and type
checking pass.
Follow-ups: #14768 corrects desktop dependency declarations; #14769
decides CI/pre-push gating and Knip's future role.
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
…e customer (#14910) ## Summary The billing-operation toast is created once when the operation starts and never revised, so an operation that parks on a 3DS challenge kept announcing "Processing payment — setting up your workspace..." while it was in fact waiting on the customer. ## Changes - **What**: Drive the toast from the current `action_url`, which the generated contract defines as present exactly while a pending operation cannot proceed without the customer. The store already tracks that field and already renders a verification prompt from it — only the toast was left behind, so it contradicted the prompt beside it. The toast swaps whenever that answer changes, in either direction, so it can never outlive the action it points at. ## Reproduction Any environment in Stripe test mode: 1. New workspace, no subscription. 2. Subscribe to a monthly plan; complete checkout with the 3DS test card `4000 0027 6000 3184`. 3. The first invoice needs authentication, so the operation parks and the status endpoint returns `status: "pending"` with `action_url` set to the Stripe-hosted invoice page. 4. Observe the toast while parked. **AS IS** — "Processing payment — setting up your workspace..." with a spinner, for the whole time the operation waits on the customer, beside a "Complete verification" affordance rendered from the same `action_url`. A reload does not clear it. **TO BE** — "Verify your payment to finish setting up your workspace" with a prompt icon, for as long as `action_url` is present. The same state is reached before any payment exists, when the operation is waiting for the customer to finish checkout. ## Before / after ```mermaid flowchart TD A["Subscription operation starts"] --> B["⟳ Processing payment —<br/>setting up your workspace…"] B --> C["Poll returns action_url<br/>(bank challenge required)"] C --> D["Before: ⟳ Processing payment —<br/>setting up your workspace…"] C --> E["After: ⚠ Verify your payment to<br/>finish setting up your workspace"] D --> F["Contradicts the 'Complete<br/>verification' prompt beside it"] E --> G["Matches the 'Complete<br/>verification' prompt beside it"] E --> H["action_url clears →<br/>reverts to processing"] ``` ## Review Focus - The toast keys on the **current** `action_url`, not on the sticky `authenticationRequiredSeen` — so it cannot ask for verification after the verification action has gone. `authenticationRequiredSeen` continues to carry only polling cadence and the 23h timeout. - Swapped only when the answer changes, so a toast the customer dismissed is not resurfaced on every poll (cadence is 30s while parked). - `severity: 'warn'` only selects the icon in `GlobalToast`; this toast group renders through a custom `#message` slot, so severity carries no other behaviour here. The state is conveyed in the summary text, not by icon or colour alone. - English strings only — other locales are generated during release PRs. - Deliberately out of scope: the same stale copy appears in the subscription settings panel (`SubscriptionPanelContentWorkspace.vue`). Same fix, different surface — left for a follow-up to keep this reviewable. ## Verification - `billingOperationStore` tests: 56 passed, 4 new. Each new test fails without the store change (verified by stashing it). - `vitest run src/platform/workspace src/components/toast` — 1075 passed. - `vue-tsc --noEmit`, `oxfmt --check`, `oxlint --type-aware`, `eslint` — clean. - Reproduced end to end on a fresh workspace with the 3DS test card before and after the change. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…es (#14048) Bumps the storybook group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs) | `10.5.0` | `10.5.6` | | [@storybook/addon-mcp](https://github.com/storybookjs/mcp/tree/HEAD/packages/addon-mcp) | `0.1.6` | `0.7.0` | | [@storybook/vue3-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/vue3-vite) | `10.5.0` | `10.5.6` | | [@storybook/vue3](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/vue3) | `10.5.0` | `10.5.6` | | [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) | `10.5.0` | `10.5.6` | Updates `@storybook/addon-docs` from 10.5.0 to 10.5.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/addon-docs's releases</a>.</em></p> <blockquote> <h2>v10.5.6</h2> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin `@testing-library/jest-dom` to `6.9.1` - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>v10.5.5</h2> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade `ws` to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>v10.5.4</h2> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>v10.5.3</h2> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>v10.5.2</h2> <h2>10.5.2</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>v10.5.1</h2> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/addon-docs's changelog</a>.</em></p> <blockquote> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin <code>@testing-library/jest-dom</code> to <code>6.9.1</code> - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade <code>ws</code> to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>10.5.2</h2> <ul> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/3126f0a14a351e971679f61cd0bd5609d086ed57"><code>3126f0a</code></a> Bump version from "10.5.5" to "10.5.6" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/05a52b7a888c6b85c3f8aa6765ed9a0a69a79e4c"><code>05a52b7</code></a> Bump version from "10.5.4" to "10.5.5" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/3327dc44697304275e28ceaa2cd34d9bede4e333"><code>3327dc4</code></a> Bump version from "10.5.3" to "10.5.4" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/9ac273930a49ad33b6a331f1f36dc472f5c36054"><code>9ac2739</code></a> Bump version from "10.5.2" to "10.5.3" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/b4b00f27662caf7328330b5ab47e9b903218f43a"><code>b4b00f2</code></a> Merge pull request <a href="https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs/issues/34971">#34971</a> from storybookjs/valentin/upgrade-typescript-6</li> <li><a href="https://github.com/storybookjs/storybook/commit/518f711cb367d8df184be22f1fab9a218b2743df"><code>518f711</code></a> Bump version from "10.5.1" to "10.5.2" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/c253a0667d39899a0f7a09fa90f262f69ad4ae90"><code>c253a06</code></a> Bump version from "10.5.0" to "10.5.1" [skip ci]</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v10.5.6/code/addons/docs">compare view</a></li> </ul> </details> <br /> Updates `@storybook/addon-mcp` from 0.1.6 to 0.7.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/mcp/releases">@storybook/addon-mcp's releases</a>.</em></p> <blockquote> <h2><code>@storybook/addon-mcp</code><a href="https://github.com/0"><code>@0</code></a>.6.0</h2> <h3>Minor Changes</h3> <ul> <li><a href="https://redirect.github.com/storybookjs/mcp/pull/209">#209</a> <a href="https://github.com/storybookjs/mcp/commit/f59e38c1b91500f886cd923141b6ce45fa6c5822"><code>f59e38c</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Add support for subcomponent docs</li> </ul> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/212">#212</a> <a href="https://github.com/storybookjs/mcp/commit/27a53b3f941240174a33442e17f9c258e5d87345"><code>27a53b3</code></a> Thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>! - Add support for Storybook canaries</p> </li> <li> <p>Updated dependencies [<a href="https://github.com/storybookjs/mcp/commit/f59e38c1b91500f886cd923141b6ce45fa6c5822"><code>f59e38c</code></a>]:</p> <ul> <li><code>@storybook/mcp</code><a href="https://github.com/0"><code>@0</code></a>.7.0</li> </ul> </li> </ul> <h2><code>@storybook/addon-mcp</code><a href="https://github.com/0"><code>@0</code></a>.5.0</h2> <h3>Minor Changes</h3> <ul> <li><a href="https://redirect.github.com/storybookjs/mcp/pull/208">#208</a> <a href="https://github.com/storybookjs/mcp/commit/5418509f2c482d3b598032b7f263f759c8c3f777"><code>5418509</code></a> Thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>! - Enable components manifest by default</li> </ul> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/204">#204</a> <a href="https://github.com/storybookjs/mcp/commit/b2a327dde8d0529ee3a2b80e033ce35991ad538e"><code>b2a327d</code></a> Thanks <a href="https://github.com/JReinhold"><code>@JReinhold</code></a>! - upgrade tmcp dependencies</p> </li> <li> <p>Updated dependencies [<a href="https://github.com/storybookjs/mcp/commit/70b5b2333a3bd37fc8065cc56cc8f8dcd474572e"><code>70b5b23</code></a>, <a href="https://github.com/storybookjs/mcp/commit/b2a327dde8d0529ee3a2b80e033ce35991ad538e"><code>b2a327d</code></a>]:</p> <ul> <li><code>@storybook/mcp</code><a href="https://github.com/0"><code>@0</code></a>.6.2</li> </ul> </li> </ul> <h2><code>@storybook/addon-mcp</code><a href="https://github.com/0"><code>@0</code></a>.4.2</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://redirect.github.com/storybookjs/mcp/pull/202">#202</a> <a href="https://github.com/storybookjs/mcp/commit/9d19fae499557d2e5393fbeadd1bdda1d664f5dd"><code>9d19fae</code></a> Thanks <a href="https://github.com/shilman"><code>@shilman</code></a>! - Add MCP registry metadata for <code>@storybook/addon-mcp</code>.</li> </ul> <h2><code>@storybook/addon-mcp</code><a href="https://github.com/0"><code>@0</code></a>.4.1</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/172">#172</a> <a href="https://github.com/storybookjs/mcp/commit/a610073f123efc2843e1e0deffd6eb2902d94c96"><code>a610073</code></a> Thanks <a href="https://github.com/JReinhold"><code>@JReinhold</code></a>! - Simplify package READMEs for docs-site-first documentation</p> </li> <li> <p>Updated dependencies [<a href="https://github.com/storybookjs/mcp/commit/a610073f123efc2843e1e0deffd6eb2902d94c96"><code>a610073</code></a>]:</p> <ul> <li><code>@storybook/mcp</code><a href="https://github.com/0"><code>@0</code></a>.6.1</li> </ul> </li> </ul> <h2><code>@storybook/addon-mcp</code><a href="https://github.com/0"><code>@0</code></a>.4.0</h2> <h3>Minor Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/185">#185</a> <a href="https://github.com/storybookjs/mcp/commit/c5439b72425a614e23549ba661d43df87a58443a"><code>c5439b7</code></a> Thanks <a href="https://github.com/apps/copilot-swe-agent"><code>@copilot-swe-agent</code></a>! - Add MCP server-level instructions to both packages</p> <p>Both <code>@storybook/mcp</code> and <code>@storybook/addon-mcp</code> now include server instructions in the MCP <code>initialize</code> response. These instructions guide agents on how to use the available tools effectively without requiring explicit prompting from users.</p> </li> </ul> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/193">#193</a> <a href="https://github.com/storybookjs/mcp/commit/dbb33c29df2a2cee75eacb2f3575afddce6cd0bf"><code>dbb33c2</code></a> Thanks <a href="https://github.com/JReinhold"><code>@JReinhold</code></a>! - Fix enabling docs toolset even when component manifests were not present</p> </li> <li> <p>Updated dependencies [<a href="https://github.com/storybookjs/mcp/commit/eb0ea73f30c73a8102d9023c5201d1459d791fa1"><code>eb0ea73</code></a>, <a href="https://github.com/storybookjs/mcp/commit/c5439b72425a614e23549ba661d43df87a58443a"><code>c5439b7</code></a>]:</p> <ul> <li><code>@storybook/mcp</code><a href="https://github.com/0"><code>@0</code></a>.6.0</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/mcp/blob/main/packages/addon-mcp/CHANGELOG.md">@storybook/addon-mcp's changelog</a>.</em></p> <blockquote> <h2>0.7.0</h2> <h3>Minor Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Added the <code>display-review</code> tool. The agent pushes a curated review of current changes and returns the review-page URL. Pairs with the <code>@storybook/addon-review</code> Storybook addon.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Add the <code>get-stories-by-component</code> tool. Maps component source files to the stories that render them via Storybook's live reverse dependency graph, returning grounded story IDs ranked by import distance. Also hardens change detection: <code>get-changed-stories</code> now surfaces working-tree files that are unreachable from any story, and story-index resolution and reverse-graph lookups are normalized for cross-platform (Windows) path handling.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Introduced the <code>get-changed-stories</code> tool to retrieve metadata for stories marked as new, modified, or affected. Updated <code>dev-instructions.md</code> and <code>storybook-story-instructions.md</code> to reflect the new workflow for calling <code>get-changed-stories</code> before <code>preview-stories</code>.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Enabled the review workflow by default for the <code>storybook ai</code> CLI channel (the Claude/Codex plugins). Requests carrying the trusted local-client header get <code>display-review</code> and the review instructions without setting <code>experimentalReview</code>; direct MCP clients keep the opt-in flag, and <code>experimentalReview: false</code> turns review off for both channels.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Add an optional MCP endpoint setting for the addon dev server.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Make the review tooling opt-in via the new <code>experimentalReview</code> feature flag. Previously <code>display-review</code> (and the review-mode behavior of <code>preview-stories</code> / <code>get-changed-stories</code>) was enabled whenever the <code>changeDetection</code> feature flag was on — which is Storybook's default. Now review requires explicitly enabling <code>features.experimentalReview</code> in <code>.storybook/main.ts</code> (on top of <code>changeDetection</code>), so change detection stays on by default while review ships disabled by default.</p> <p>With the flag off, the server instructions are byte-identical to the previous release; the review-flavored instructions are only served with the flag on.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Expose serverless Storybook AI metadata from addon-mcp presets. The new preset returns MCP-shaped instructions and tool descriptors, plus a local <code>get-storybook-story-instructions</code> runner that shares the same builders as the live MCP server.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Support v0 (inline) and v1 (split/ref) Storybook manifest formats. <code>@storybook/mcp</code> follows <code>$ref</code> pointers into sibling <code>services/</code> payloads for static and remote sources; <code>@storybook/addon-mcp</code> adds an in-process manifest provider for <code>experimentalDocgenServer</code> dev mode and fixes composition so local docgen-server and remote v0/v1 composed sources all work.</p> </li> </ul> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/359">#359</a> <a href="https://github.com/storybookjs/mcp/commit/4eb4a2eff337fc9fa04ce3c30d07d0f7f255b68f"><code>4eb4a2e</code></a> Thanks <a href="https://github.com/huang-julien"><code>@huang-julien</code></a>! - Add a schema description to the <code>collections</code> argument of the <code>display-review</code> tool. The field now documents that collections are groups of stories to show in the review, ordered most-relevant-first, with a preferred 2-5 range. Previously it carried no description, so MCP clients and the <code>storybook ai display-review</code> help had no guidance on the argument's shape or intent.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Make display-review the single ending for visual work: the after-change instruction step now feeds story discovery into the review instead of ending at preview URLs, preview-stories is framed as a mid-loop tool, the "or you skipped it" escape is removed (non-visual changes say so plainly instead of listing links), and get-changed-stories results append a "publish the review now" next-step hint when review is enabled. Fixes agents completing visual changes but handing back preview links instead of the review.</p> <p>The preview-stories tool also closes the review exit ramp: when review is enabled its description states display-review's availability as fact instead of hedging with "when available" (which let an agent that wrongly believed the tool was missing treat raw links as a sanctioned fallback), and its results append a recovery nudge pointing finished visual work and browse requests back to display-review. When review is disabled, the description no longer mentions display-review at all — the tool is not registered in those sessions.</p> <p>The get-storybook-story-instructions story-linking workflow gets the same review-aware rewrite: with review enabled it now routes discovered story IDs into display-review and forbids constructing IDs from file names or memory, instead of framing get-changed-stories as a preview-stories helper. The <code>storybook ai --help</code> output embeds the same server instructions, so on the CLI/plugin path the two channels contradicted each other — this tool, billed as the source of truth for story work, still pointed discovery at previews, and agents were observed resolving the conflict by publishing reviews with hand-derived story IDs and zero discovery calls.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Refine the review/preview workflow so agents reuse the running Storybook and present a single set of links:</p> <ul> <li><strong>Reuse the running Storybook.</strong> A successful tool call proves Storybook is already running, so the agent is instructed never to start another instance (no <code>storybook dev</code>, launcher, or new port) just to view a review — a busy port is the instance to reuse, not a conflict to route around.</li> <li><strong><code>display-review</code> triggers on insight requests too.</strong> Beyond post-change reviews, it now fires when the user wants to browse stories/components (e.g. "show me all badge components"), rendering exactly those stories with no diff (<code>changedFiles</code> omitted).</li> <li><strong>One set of links in the final response.</strong> When <code>display-review</code> is available, the response links only the curated review page ("You can see a curated summary of stories in the Storybook review page"); otherwise it lists the individual preview URLs — never both.</li> </ul> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Show private composed Storybooks as own-MCP guidance when accessed through the local MCP proxy.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Add Storybook 10.5 prerelease packages to the supported peer dependency range.</p> <p>The <code>display-review</code> tool schema now requires <code>changedFiles</code>: pass the paths of the files you changed (most central first), or an empty array <code>[]</code> for browse requests where no code changed. Payloads that previously omitted the field will fail validation.</p> </li> <li> <p><a href="https://redirect.github.com/storybookjs/mcp/pull/357">#357</a> <a href="https://github.com/storybookjs/mcp/commit/4a1915199892b3f733728844113a6b918ff70be9"><code>4a19151</code></a> Thanks <a href="https://github.com/kasperpeulen"><code>@kasperpeulen</code></a>! - Gate the <code>display-review</code> tool solely on the <code>changeDetection</code> feature flag. The previous <code>@storybook/addon-review</code> package-presence check is removed, since review is now built into Storybook core.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/mcp/commit/de73c2c6371946bb9c048e7987c1b7fd3df76e92"><code>de73c2c</code></a> Version Packages</li> <li><a href="https://github.com/storybookjs/mcp/commit/54e08b69049ff75682d65cf92c6f065af9f3276a"><code>54e08b6</code></a> chore: reduce description</li> <li><a href="https://github.com/storybookjs/mcp/commit/f50fbf611be165c9b81340b1c820bc9f67ccf172"><code>f50fbf6</code></a> fix(addon-mcp): add display-review escription</li> <li><a href="https://github.com/storybookjs/mcp/commit/01d6be2edc66e21516a9378efc5a8bb890123054"><code>01d6be2</code></a> Merge branch 'main' into docs--fix-link</li> <li><a href="https://github.com/storybookjs/mcp/commit/d365aa5994b141f4f0ba65b7ec7ab077ae583473"><code>d365aa5</code></a> docs(addon-mcp): correct documentation link</li> <li><a href="https://github.com/storybookjs/mcp/commit/fcc5504ce786d21fc9dad654155126fd1c7b980a"><code>fcc5504</code></a> Enable review by default for the plugin (storybook ai CLI channel) (<a href="https://github.com/storybookjs/mcp/tree/HEAD/packages/addon-mcp/issues/341">#341</a>)</li> <li><a href="https://github.com/storybookjs/mcp/commit/32bb8546b48712f27745e1b9d715ae1d6b0e2c52"><code>32bb854</code></a> Bump Storybook catalog to 10.5.0-beta.0</li> <li><a href="https://github.com/storybookjs/mcp/commit/e72917564346e30d0a550eab240d911af0ae3b27"><code>e729175</code></a> Add tools-api doc generator script</li> <li><a href="https://github.com/storybookjs/mcp/commit/d18712bd82977fe33d068ee0cfae29009a2eae16"><code>d18712b</code></a> Bump Storybook catalog to 10.5.0-alpha.11</li> <li><a href="https://github.com/storybookjs/mcp/commit/45d268af2de8c07be118ce2909007f3329562090"><code>45d268a</code></a> Extend the story-instructions trigger list to shared UI files</li> <li>Additional commits viewable in <a href="https://github.com/storybookjs/mcp/commits/@storybook/addon-mcp@0.7.0/packages/addon-mcp">compare view</a></li> </ul> </details> <br /> Updates `@storybook/vue3-vite` from 10.5.0 to 10.5.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/vue3-vite's releases</a>.</em></p> <blockquote> <h2>v10.5.6</h2> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin `@testing-library/jest-dom` to `6.9.1` - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>v10.5.5</h2> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade `ws` to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>v10.5.4</h2> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>v10.5.3</h2> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>v10.5.2</h2> <h2>10.5.2</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>v10.5.1</h2> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/vue3-vite's changelog</a>.</em></p> <blockquote> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin <code>@testing-library/jest-dom</code> to <code>6.9.1</code> - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade <code>ws</code> to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>10.5.2</h2> <ul> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/3126f0a14a351e971679f61cd0bd5609d086ed57"><code>3126f0a</code></a> Bump version from "10.5.5" to "10.5.6" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/2914665334d9b496b82b348e22f3786bb5faf240"><code>2914665</code></a> Merge pull request <a href="https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/vue3-vite/issues/35598">#35598</a> from seanogdev/vue3-vite-skip-query-ids</li> <li><a href="https://github.com/storybookjs/storybook/commit/05a52b7a888c6b85c3f8aa6765ed9a0a69a79e4c"><code>05a52b7</code></a> Bump version from "10.5.4" to "10.5.5" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/3327dc44697304275e28ceaa2cd34d9bede4e333"><code>3327dc4</code></a> Bump version from "10.5.3" to "10.5.4" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/9ac273930a49ad33b6a331f1f36dc472f5c36054"><code>9ac2739</code></a> Bump version from "10.5.2" to "10.5.3" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/b4b00f27662caf7328330b5ab47e9b903218f43a"><code>b4b00f2</code></a> Merge pull request <a href="https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/vue3-vite/issues/34971">#34971</a> from storybookjs/valentin/upgrade-typescript-6</li> <li><a href="https://github.com/storybookjs/storybook/commit/518f711cb367d8df184be22f1fab9a218b2743df"><code>518f711</code></a> Bump version from "10.5.1" to "10.5.2" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/c253a0667d39899a0f7a09fa90f262f69ad4ae90"><code>c253a06</code></a> Bump version from "10.5.0" to "10.5.1" [skip ci]</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v10.5.6/code/frameworks/vue3-vite">compare view</a></li> </ul> </details> <br /> Updates `@storybook/vue3` from 10.5.0 to 10.5.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">@storybook/vue3's releases</a>.</em></p> <blockquote> <h2>v10.5.6</h2> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin `@testing-library/jest-dom` to `6.9.1` - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>v10.5.5</h2> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade `ws` to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>v10.5.4</h2> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>v10.5.3</h2> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>v10.5.2</h2> <h2>10.5.2</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>v10.5.1</h2> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">@storybook/vue3's changelog</a>.</em></p> <blockquote> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin <code>@testing-library/jest-dom</code> to <code>6.9.1</code> - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade <code>ws</code> to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>10.5.2</h2> <ul> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/storybookjs/storybook/commit/3126f0a14a351e971679f61cd0bd5609d086ed57"><code>3126f0a</code></a> Bump version from "10.5.5" to "10.5.6" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/05a52b7a888c6b85c3f8aa6765ed9a0a69a79e4c"><code>05a52b7</code></a> Bump version from "10.5.4" to "10.5.5" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/3327dc44697304275e28ceaa2cd34d9bede4e333"><code>3327dc4</code></a> Bump version from "10.5.3" to "10.5.4" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/9ac273930a49ad33b6a331f1f36dc472f5c36054"><code>9ac2739</code></a> Bump version from "10.5.2" to "10.5.3" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/b4b00f27662caf7328330b5ab47e9b903218f43a"><code>b4b00f2</code></a> Merge pull request <a href="https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/vue3/issues/34971">#34971</a> from storybookjs/valentin/upgrade-typescript-6</li> <li><a href="https://github.com/storybookjs/storybook/commit/518f711cb367d8df184be22f1fab9a218b2743df"><code>518f711</code></a> Bump version from "10.5.1" to "10.5.2" [skip ci]</li> <li><a href="https://github.com/storybookjs/storybook/commit/c253a0667d39899a0f7a09fa90f262f69ad4ae90"><code>c253a06</code></a> Bump version from "10.5.0" to "10.5.1" [skip ci]</li> <li>See full diff in <a href="https://github.com/storybookjs/storybook/commits/v10.5.6/code/renderers/vue3">compare view</a></li> </ul> </details> <br /> Updates `storybook` from 10.5.0 to 10.5.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/releases">storybook's releases</a>.</em></p> <blockquote> <h2>v10.5.6</h2> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin `@testing-library/jest-dom` to `6.9.1` - <a href="https://redirect.github.com/storybookjs/storybook/pull/35614">#35614</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ESLint Plugin: Add plugin meta and document oxlint usage - <a href="https://redirect.github.com/storybookjs/storybook/pull/35655">#35655</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Vue: Skip docgen for module ids carrying a query - <a href="https://redirect.github.com/storybookjs/storybook/pull/35598">#35598</a>, thanks <a href="https://github.com/seanogdev"><code>@seanogdev</code></a>!</li> </ul> <h2>v10.5.5</h2> <h2>10.5.5</h2> <ul> <li>CLI: Update AI setup instructions to msw-storybook-addon v3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35512">#35512</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>Core: Upgrade `ws` to fix security advisories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35584">#35584</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> <li>TanStack: Preserve explicit route ids on pathful clones - <a href="https://redirect.github.com/storybookjs/storybook/pull/35499">#35499</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Resolve mock redirects through Vite's resolver - <a href="https://redirect.github.com/storybookjs/storybook/pull/35501">#35501</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>TanStack: Respect routeOverrides component overrides in stories - <a href="https://redirect.github.com/storybookjs/storybook/pull/35497">#35497</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> </ul> <h2>v10.5.4</h2> <h2>10.5.4</h2> <ul> <li>ReactNative: Telemetry framework detection fix - <a href="https://redirect.github.com/storybookjs/storybook/pull/35560">#35560</a>, thanks <a href="https://github.com/ndelangen"><code>@ndelangen</code></a>!</li> <li>SyntaxHighlighter: Fix PrismJS dark mode mismatch - <a href="https://redirect.github.com/storybookjs/storybook/pull/35541">#35541</a>, thanks <a href="https://github.com/hxy-asdw"><code>@hxy-asdw</code></a>!</li> </ul> <h2>v10.5.3</h2> <h2>10.5.3</h2> <ul> <li>Dependencies: Upgrade TypeScript to 6.0.3 - <a href="https://redirect.github.com/storybookjs/storybook/pull/34971">#34971</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> </ul> <h2>v10.5.2</h2> <h2>10.5.2</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> <li>TanStack: Fix createServerFn validator mock - <a href="https://redirect.github.com/storybookjs/storybook/pull/35185">#35185</a>, thanks <a href="https://github.com/sjh9714"><code>@sjh9714</code></a>!</li> <li>TanStack: Support pathless layout routes (id-only) in story routing - <a href="https://redirect.github.com/storybookjs/storybook/pull/35465">#35465</a>, thanks <a href="https://github.com/unpunnyfuns"><code>@unpunnyfuns</code></a>!</li> <li>Tanstack-react: Add missing Hydrate export - <a href="https://redirect.github.com/storybookjs/storybook/pull/35111">#35111</a>, thanks <a href="https://github.com/arun-357"><code>@arun-357</code></a>!</li> <li>Tanstack-react: Keep JSX-only component references during dead-code elimination - <a href="https://redirect.github.com/storybookjs/storybook/pull/35206">#35206</a>, thanks <a href="https://github.com/yatishgoel"><code>@yatishgoel</code></a>!</li> <li>Vitest: Fix coverage toggle crash on Vite 6 by clearing closed Vitest instance on restart - <a href="https://redirect.github.com/storybookjs/storybook/pull/35461">#35461</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> <h2>v10.5.1</h2> <h2>10.5.1</h2> <ul> <li>Angular-Vite: Drop <code>@angular/platform-browser-dynamic</code> peer dependency - <a href="https://redirect.github.com/storybookjs/storybook/pull/35457">#35457</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Angular-Vite: Widen TypeScript peer dependency range to support TypeScript 6 - <a href="https://redirect.github.com/storybookjs/storybook/pull/35455">#35455</a>, thanks <a href="https://github.com/valentinpalkovic"><code>@valentinpalkovic</code></a>!</li> <li>Core: Include chromatic packages in ecosystem identifier - <a href="https://redirect.github.com/storybookjs/storybook/pull/35170">#35170</a>, thanks <a href="https://github.com/yannbf"><code>@yannbf</code></a>!</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md">storybook's changelog</a>.</em></p> <blockquote> <h2>10.5.6</h2> <ul> <li>Dependencies: Pin <code>@testing-library/jest-dom</code> to <code>6.9.1</code> - <a href="https://redirect.g…
…eatment (#14894) ## Summary The Wan Animate 2 (`10396-41358`) and Wan 3.0 (`10396-41778`) frames are newer than the Seedance one and use a different hero: a transparent CTA with a white border over a heavier scrim. Adopting it now keeps the three announcement pages looking like a set instead of shipping two visual styles a week apart. Base for #14849 and #14850, which add those two pages. ## Changes - **What**: Replaces the short-lived `canvas` BrandButton variant with `outline-light`, the white-border-on-media counterpart to the existing `outline-dark`. Nothing else used `canvas`; it shipped in #14822 hours ago and this supersedes it. - Overlay scrim goes from 30% to 50%. - Hoists the shared backdrop into `COMING_SOON_HERO`. The art is byte identical across all three Figma frames (verified by md5 on the exported layers), so they reference one asset on a neutral path instead of a copy per model under `seedance-2.5/`. ## Review Focus Only `/seedance-2.5` renders with `layout: 'overlay'` today, so that page is the entire visual blast radius. `/minimax` and `/flux-3` use the stacked layout and are untouched, which the MiniMax suite confirms. Gates: `astro check` 0 errors, knip/format clean, build 583 pages, `validate:jsonld` 586, e2e 24/24 across the Seedance and MiniMax suites. ## Preview The treatment change is visible on the one announcement page currently on main: - https://comfy-website-preview-pr-14894.vercel.app/seedance-2.5 - zh-CN: https://comfy-website-preview-pr-14894.vercel.app/zh-CN/seedance-2.5
## Summary
Use dedicated test IDs for sidebar tab buttons so test selectors are not
represented as dynamically generated CSS classes.
## Changes
- **What**: Add dynamic sidebar tab test IDs, centralize their
Playwright selector, and update the affected sidebar and gallery tests.
## Review Focus
Sidebar buttons no longer expose `{tabId}-tab-button` as a CSS class;
the same identifier is now exposed through `data-testid`.
Follow-up to #14626. That PR made the sheriff job exit non-zero when it cannot resolve the on-call user. But a failing **scheduled** workflow only notifies whoever last pushed to `main` — in practice nobody. That is exactly how the placeholder Datadog config survived for weeks: every run warned, and every run still reported success. This posts the failure to **#frontend-releases** (`C09K9TPU2G7`), whose channel purpose is literally "Current Release Sheriff". The script writes *why* it degraded to a step output, so the alert is actionable without opening the run: > 🚨 **Release sheriff assignment degraded.** Fell back to `christian-byrne` instead of the Datadog on-call user. DATADOG_API_KEY / DATADOG_APP_KEY unavailable — using the fallback. [View run] Both lookups hit the same API, so an outage or credentials failure produced the same warning twice; deduped so the alert reads once. The post is `continue-on-error` and follows the existing pattern in `publish-design-system-on-merge.yaml` (same `SLACK_BOT_TOKEN` secret, same `chat.postMessage` + `jq -e '.ok == true'` shape), so Slack being unreachable never masks the underlying result. ## Verification Ran the real script both ways: - no credentials → exit 1, single-sentence reason written to `GITHUB_OUTPUT`, no PRs mutated - real credentials → exit 0 Tests 24/24; lint, format, typecheck clean.
…ing-banner-on-payment-recovery
Amp-Thread-ID: https://ampcode.com/threads/T-019fde89-3a25-71fd-86d7-2e0815d55573 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fde89-3a25-71fd-86d7-2e0815d55573 Co-authored-by: Amp <amp@ampcode.com>
huang47
left a comment
There was a problem hiding this comment.
files changed doesn't look right
Amp-Thread-ID: https://ampcode.com/threads/T-019fde89-3a25-71fd-86d7-2e0815d55573 Co-authored-by: Amp <amp@ampcode.com>
Summary
Gate
pausedandpayment_failedbilling banners exclusively onv1_payment_recovery, independently ofbilling_control_enabled.This is stacked on #14746; its base branch is
dante01yoon/payment-recovery-rollback-fix.Root cause
#14746 changed the recovery-banner condition from
v1PaymentRecoverytobillingControlEnabled || v1PaymentRecovery. That couples payment-recovery UI to the unrelated billing-control rollout: with payment recovery disabled but billing controls enabled, owners still see the legacy payment-failure or paused banner.Changes
v1PaymentRecoveryforpausedand ownerpayment_failedbanners.billingControlEnabledresponsible for the existingoutOfCreditsandendingnotices.Review Focus
Confirm that disabling payment recovery removes all payment-recovery banner entry points without changing the billing-control notices.
Screenshots
Both screenshots use the real cloud app UI with an owner workspace in
payment_failedstate andbilling_control_enabled=true; onlyv1_payment_recoverychanges.AS IS: payment recovery OFF
No payment-recovery banner is rendered.
TO BE: payment recovery ON
The payment-recovery banner and
Update paymentaction are rendered.Verification
pnpm vitest runacross the 8 billing/run-button suites: 240 tests passedpnpm typecheckknipUpdate paymentwhen ON