Skip to content

feat(billing): full 3DS state family for the subscription checkout - #14826

Closed
comfydesigner wants to merge 4 commits into
comfydesigner/saved-method-confirmfrom
comfydesigner/checkout-3ds-states
Closed

comfydesigner wants to merge 4 commits into
comfydesigner/saved-method-confirmfrom
comfydesigner/checkout-3ds-states

Conversation

@comfydesigner

@comfydesigner comfydesigner commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Implements the full 3DS state family for the subscription checkout per DES-662, mirroring the shipped top-up dialog machinery (#14605) so the two flows read as one system. Stacked on #14449.

Changes

  • Verifying re-entry step (SubscriptionVerifyingWorkspace.vue): opening the checkout with a pending 3DS charge (subscriptionActionOperation) lands on a verifying step instead of the pricing table — plan selection stays unreachable until the operation resolves, is canceled, or its 24h link expires. Resolution from this step: succeeded with no plan selection closes the dialog (store toast + refreshed plan carry the outcome); failed lands on the existing declined step; a vanished operation returns to pricing.
  • In-flow pending simplification: Complete verification now replaces the pay/confirm CTA outright on the saved-method confirm and transition previews (previously the pay button stayed, demoted). Once the bank tab opens, an inline spinner appears inside the button — label unchanged, still clickable to reopen a lost tab. Capture-mode (UnifiedStripePaymentSelector) behavior is unchanged pending the open question of whether the embedded element self-handles 3DS.
  • Cancel payment: muted text button in every pending state; no confirmation. billingOperationStore.cancelOperation posts to /billing/ops/{id}/cancel and removes the operation outright on success — canceled is not failed, so nothing persists and every watching surface clears at once. Backend refusal (cancel raced the bank) swaps the button for an in-place "already processing" notice; polling finishes the story. In-flow cancel stays on confirm with intent intact plus a dialog-local inline notice ("Payment canceled — nothing was charged."); re-entry cancel returns to plan selection.
  • Locks during pending: the saved-method row (Change link / method picker) disables alongside back while a charge is pending — switching cards mid-challenge would orphan the charge.

Notes

  • The cancel endpoint is being scoped by BE (cancelable flag + cancel endpoint + submit-time revalidation, first iteration covering top-up and subscription 3DS ops); until it lands the cancel action reports "already processing" on the API error path, which is safe.
  • New i18n keys under subscription.preview: cancelPayment, cancelUnavailable, paymentCanceledNotice, verifyTitle, verifyBody, verifyOpenedBody.
  • Unit tests cover cancelOperation (removal on success, unavailable on refusal, unavailable for unknown/settled ops). E2E (checkout3dsStates.spec.ts, @cloud): re-entry lands on verifying, spinner-in-button after the tab opens, cancel-refused notice, cancel returning to plan selection — all against mocked billing ops.

Testing locally

  • DISTRIBUTION=cloud pnpm dev, then PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/dialogs/checkout3dsStates.spec.ts --project=cloud --headed walks every new state in a visible browser.
  • End-to-end with real Stripe: staging + test card 4000 0000 0000 3220 per FE-1436 (any future expiry/CVC); close the dialog mid-challenge and reopen checkout to hit the verifying re-entry step.

Design: New Subscription Checkout Flow · Fixes DES-662

Screenshots

image-1785993786101 image-1785993791879 image-1785993795397

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d1b89e7e-dc6d-4845-984c-f025ba492721

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 127ms TBT · 98.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 3ms TBT · 161.1 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 228ms TBT · 160.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 594ms
canvas-idle: script duration 18ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.6 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 890ms
canvas-mouse-sweep: script duration 114ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.0 MB
canvas-mouse-sweep: DOM nodes -116
canvas-mouse-sweep: event listeners -72
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 423ms
canvas-zoom-sweep: script duration 19ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 22
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 393ms
dom-widget-clipping: script duration 55ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 57.2 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 738ms
large-graph-idle: script duration 91ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.5 MB
large-graph-idle: DOM nodes -293
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1297ms
large-graph-pan: script duration 412ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 67.2 MB
large-graph-pan: DOM nodes -293
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1581ms
large-graph-zoom: script duration 527ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 60.5 MB
large-graph-zoom: DOM nodes -296
large-graph-zoom: event listeners -150
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 748ms
minimap-idle: script duration 92ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.4 MB
minimap-idle: DOM nodes -294
minimap-idle: event listeners -160
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 416ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 57.9 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 10
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 530ms
subgraph-idle: script duration 14ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.9 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 5
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 787ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.4 MB
subgraph-mouse-sweep: DOM nodes 65
subgraph-mouse-sweep: event listeners 7
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 937ms
subgraph-transition-enter: script duration 42ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 98.5 MB
subgraph-transition-enter: DOM nodes 13676
subgraph-transition-enter: event listeners 2372
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4575ms
viewport-pan-sweep: script duration 1349ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.6 MB
viewport-pan-sweep: DOM nodes -287
viewport-pan-sweep: event listeners -129
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17121ms
vue-large-graph-idle: script duration 577ms
vue-large-graph-idle: TBT 3ms
vue-large-graph-idle: heap used 161.1 MB
vue-large-graph-idle: DOM nodes -8314
vue-large-graph-idle: event listeners -16390
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 21436ms
vue-large-graph-pan: script duration 927ms
vue-large-graph-pan: TBT 228ms
vue-large-graph-pan: heap used 160.9 MB
vue-large-graph-pan: DOM nodes -8314
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 128ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 52.1 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-08-17T17:17:58.224Z",
  "gitSha": "961f01ba3f5f4ada9d660193fd1dfe1c77e6f6c6",
  "branch": "comfydesigner/checkout-3ds-states",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2240.710999999976,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.499,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 650.738,
      "heapDeltaBytes": 5358964,
      "heapUsedBytes": 77307496,
      "domNodes": 18,
      "jsHeapTotalBytes": 18472960,
      "scriptDurationMs": 19.308999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2068.8579999999774,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.221999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.411,
      "heapDeltaBytes": 5259060,
      "heapUsedBytes": 77023924,
      "domNodes": 16,
      "jsHeapTotalBytes": 19259392,
      "scriptDurationMs": 16.047,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1828.8299999999822,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.833,
      "layouts": 12,
      "layoutDurationMs": 3.721,
      "taskDurationMs": 919.5380000000001,
      "heapDeltaBytes": -21756652,
      "heapUsedBytes": 49820040,
      "domNodes": -289,
      "jsHeapTotalBytes": 20172800,
      "scriptDurationMs": 115.157,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1807.4790000000576,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 32.650999999999996,
      "layouts": 12,
      "layoutDurationMs": 3.247,
      "taskDurationMs": 860.911,
      "heapDeltaBytes": -62832,
      "heapUsedBytes": 71747696,
      "domNodes": 57,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 113.07699999999998,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.9300000000198,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.762,
      "layouts": 6,
      "layoutDurationMs": 0.712,
      "taskDurationMs": 421.234,
      "heapDeltaBytes": -18115900,
      "heapUsedBytes": 53371716,
      "domNodes": 74,
      "jsHeapTotalBytes": 18997248,
      "scriptDurationMs": 18.316999999999997,
      "eventListeners": 22,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1770.1720000000023,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.977,
      "layouts": 6,
      "layoutDurationMs": 0.5670000000000001,
      "taskDurationMs": 423.89099999999996,
      "heapDeltaBytes": 8422544,
      "heapUsedBytes": 80094772,
      "domNodes": 77,
      "jsHeapTotalBytes": 19521536,
      "scriptDurationMs": 19.249,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.6800000000203,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.373,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 385.962,
      "heapDeltaBytes": -11293240,
      "heapUsedBytes": 60093808,
      "domNodes": 16,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 53.93,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 612.5769999999875,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.512999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.212,
      "heapDeltaBytes": -11798760,
      "heapUsedBytes": 59829728,
      "domNodes": 18,
      "jsHeapTotalBytes": 20570112,
      "scriptDurationMs": 55.275000000000006,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.304000000025,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.891999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 744.95,
      "heapDeltaBytes": 7868880,
      "heapUsedBytes": 69981264,
      "domNodes": -291,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 92.17099999999999,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.5220000000236,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.326999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 731.344,
      "heapDeltaBytes": -2023432,
      "heapUsedBytes": 61031188,
      "domNodes": -294,
      "jsHeapTotalBytes": 4775936,
      "scriptDurationMs": 89.13,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2205.5750000000103,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.304,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1287.079,
      "heapDeltaBytes": 17322704,
      "heapUsedBytes": 82585304,
      "domNodes": -293,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 404.365,
      "eventListeners": -175,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2217.555000000061,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.436,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1307.15,
      "heapDeltaBytes": -5322184,
      "heapUsedBytes": 58271284,
      "domNodes": -293,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 419.80600000000004,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3199.6509999999603,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.597999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.8,
      "taskDurationMs": 1565.9,
      "heapDeltaBytes": -2549468,
      "heapUsedBytes": 62136876,
      "domNodes": -296,
      "jsHeapTotalBytes": 7659520,
      "scriptDurationMs": 523.362,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3264.4010000000208,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.528000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.376999999999999,
      "taskDurationMs": 1596.886,
      "heapDeltaBytes": -605780,
      "heapUsedBytes": 64729452,
      "domNodes": -296,
      "jsHeapTotalBytes": 7659520,
      "scriptDurationMs": 531.6270000000001,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.2230000000068,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.097999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 737.47,
      "heapDeltaBytes": -2249608,
      "heapUsedBytes": 62846968,
      "domNodes": -296,
      "jsHeapTotalBytes": 4046848,
      "scriptDurationMs": 91.071,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2072.4579999999833,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.164,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 757.686,
      "heapDeltaBytes": 8715724,
      "heapUsedBytes": 72301652,
      "domNodes": -291,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 92.97800000000001,
      "eventListeners": -143,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 603.2220000000166,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.918000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.385,
      "heapDeltaBytes": -10922672,
      "heapUsedBytes": 60818928,
      "domNodes": 18,
      "jsHeapTotalBytes": 20307968,
      "scriptDurationMs": 119.33499999999998,
      "eventListeners": 9,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.5779999999286,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.744000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.617,
      "heapDeltaBytes": -11015376,
      "heapUsedBytes": 60637016,
      "domNodes": 20,
      "jsHeapTotalBytes": 20570112,
      "scriptDurationMs": 120.61999999999999,
      "eventListeners": 11,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.3060000000146,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.986999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.3100000000001,
      "heapDeltaBytes": 4978920,
      "heapUsedBytes": 76480872,
      "domNodes": 20,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 13.451,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.732000000019,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.368999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.108,
      "heapDeltaBytes": 4908788,
      "heapUsedBytes": 76403352,
      "domNodes": 20,
      "jsHeapTotalBytes": 20045824,
      "scriptDurationMs": 13.816999999999998,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.3829999999834,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.917,
      "layouts": 16,
      "layoutDurationMs": 4.533,
      "taskDurationMs": 800.745,
      "heapDeltaBytes": -4422188,
      "heapUsedBytes": 67381680,
      "domNodes": 65,
      "jsHeapTotalBytes": 20307968,
      "scriptDurationMs": 87.99600000000001,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.761000000085,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.704,
      "layouts": 16,
      "layoutDurationMs": 4.113,
      "taskDurationMs": 772.7189999999999,
      "heapDeltaBytes": -4270916,
      "heapUsedBytes": 67738436,
      "domNodes": 65,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 88.092,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.4820000000109,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 28.58100000000001,
      "layouts": 14,
      "layoutDurationMs": 10.938,
      "taskDurationMs": 936.5510000000002,
      "heapDeltaBytes": 31084280,
      "heapUsedBytes": 103247056,
      "domNodes": 13676,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 42.38299999999999,
      "eventListeners": 2372,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8288.30499999998,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.36000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4586.259,
      "heapDeltaBytes": 12928904,
      "heapUsedBytes": 75332796,
      "domNodes": -287,
      "jsHeapTotalBytes": 6262784,
      "scriptDurationMs": 1355.482,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8333.332999999926,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.244,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4564.731,
      "heapDeltaBytes": 8247536,
      "heapUsedBytes": 70538892,
      "domNodes": -287,
      "jsHeapTotalBytes": 6524928,
      "scriptDurationMs": 1341.914,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17811.195999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17247.516,
      "heapDeltaBytes": -60545720,
      "heapUsedBytes": 167295624,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15400960,
      "scriptDurationMs": 611.683,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17572.66900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16993.779,
      "heapDeltaBytes": -49693956,
      "heapUsedBytes": 170521832,
      "domNodes": -8316,
      "jsHeapTotalBytes": -9867264,
      "scriptDurationMs": 542.5530000000001,
      "eventListeners": -16390,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21990.249000000007,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 23.249999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21739.345,
      "heapDeltaBytes": -45749388,
      "heapUsedBytes": 169510992,
      "domNodes": -8315,
      "jsHeapTotalBytes": -11177984,
      "scriptDurationMs": 954.9690000000002,
      "eventListeners": -16386,
      "totalBlockingTimeMs": 280,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21268.292999999972,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 20.31900000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21132.470999999998,
      "heapDeltaBytes": -42982540,
      "heapUsedBytes": 167929152,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13045760,
      "scriptDurationMs": 898.6220000000001,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 175,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.1179999999613,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 18.442999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.72,
      "taskDurationMs": 120.92500000000001,
      "heapDeltaBytes": -16355648,
      "heapUsedBytes": 54298368,
      "domNodes": 126,
      "jsHeapTotalBytes": 7462912,
      "scriptDurationMs": 9.705000000000002,
      "eventListeners": 66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 494.5510000000013,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 20.780000000000005,
      "layouts": 3,
      "layoutDurationMs": 0.812,
      "taskDurationMs": 135.18600000000004,
      "heapDeltaBytes": -15891784,
      "heapUsedBytes": 54883120,
      "domNodes": 117,
      "jsHeapTotalBytes": 6152192,
      "scriptDurationMs": 10.101,
      "eventListeners": 66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Heads up for sequencing: #14483 (embedded checkout consolidation) rewrites the same dialog family this PR touches (SubscriptionRequiredDialogContentUnified, SubscriptionAddPaymentPreviewWorkspace, SubscriptionSuccessWorkspace, checkout composables). Whichever lands second needs a careful rebase — the 3DS state machine here (verifying re-entry, cancel path, canceled landing) must survive the consolidation's restructuring. Worth coordinating merge order before either goes in.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are currently failing

@comfydesigner

Copy link
Copy Markdown
Contributor Author

CI status and plan for the red checks:

Fixed in 0d56612 — the two failures that belonged to this PR:

  • UnifiedStripePaymentSelector.test.ts: expectation updated for terms: { card: 'never' } (we suppress Stripe's inline card-terms because our own terms note carries the recurring-charge authorization).
  • checkout3dsStates.spec.ts: the app-URL fallback pointed at the Vite dev port (5173); CI serves the built app on 8188 like the other dialog specs, so both tests died on ERR_CONNECTION_REFUSED before running.

Deliberately leaving red for now — the rerouteNode / interaction / mobileBaseline screenshot diffs. Those are stale-main baselines: this stack bottoms out on proper-alipay-and-3ds-support (cut late July), which #14483 has since superseded via rewritten commits. Rather than chase baselines per-branch, the plan is to wait for #14483 and #15281 to land, then rebase the stack onto main once — that refreshes the screenshot baselines and resolves the workspaceApi.ts / useSubscriptionCheckout.ts overlap with both of those PRs in a single pass.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.60194% with 55 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...m/workspace/composables/useSubscriptionCheckout.ts 22.72% 34 Missing ⚠️
...pace/components/SubscriptionVerifyingWorkspace.vue 27.77% 13 Missing ⚠️
src/platform/workspace/api/workspaceApi.ts 0.00% 5 Missing ⚠️
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 92.30% 0 Missing and 1 partial ⚠️
...nents/SubscriptionRequiredDialogContentUnified.vue 50.00% 1 Missing ⚠️
...ponents/SubscriptionTransitionPreviewWorkspace.vue 92.30% 0 Missing and 1 partial ⚠️
@@                          Coverage Diff                          @@
##             comfydesigner/saved-method-confirm   #14826   +/-   ##
=====================================================================
  Coverage                                      ?   79.02%           
=====================================================================
  Files                                         ?     1764           
  Lines                                         ?   104674           
  Branches                                      ?    35486           
=====================================================================
  Hits                                          ?    82720           
  Misses                                        ?    21498           
  Partials                                      ?      456           
Flag Coverage Δ
unit 69.59% <46.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/workspace/stores/billingOperationStore.ts 89.55% <100.00%> (ø)
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 77.60% <92.30%> (ø)
...nents/SubscriptionRequiredDialogContentUnified.vue 37.07% <50.00%> (ø)
...ponents/SubscriptionTransitionPreviewWorkspace.vue 97.37% <92.30%> (ø)
src/platform/workspace/api/workspaceApi.ts 47.66% <0.00%> (ø)
...pace/components/SubscriptionVerifyingWorkspace.vue 27.77% <27.77%> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 85.48% <22.72%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Superseded. This branch predates the server-capabilities migration and its head is far behind main; the same scope was replanted on current main as three smaller PRs:

Closing in favour of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants