Repository navigation
[backport core/1.48] fix(billing): surface an unknown billing op type instead of defaulting silently - #14816
Conversation
…g silently (#14759) Follow-up to #14715. No behavior change against any value the API sends today — this is about what happens to the next one. Recovering a pending billing operation picked its client path with a two-way check, so anything that was not `topup` became `subscription` — including a value this client has never heard of. ```ts status.pending_billing_op_type === 'topup' ? 'topup' : 'subscription' ``` ```mermaid flowchart LR A["'subscription'"] --> S[subscription path] B["'topup'"] --> T[topup path] U[undefined] --> S N["any new value"] -.silently.-> S style N fill:#f8d7da,stroke:#b02a37,stroke-dasharray: 4 ``` ```mermaid flowchart LR A["'subscription'"] --> S[subscription path] B["'topup'"] --> T[topup path] U[undefined] --> S N["any new value"] --> R["subscription path<br/>+ Sentry report"] style N fill:#d1e7dd,stroke:#0f5132 style R fill:#d1e7dd,stroke:#0f5132 ``` `subscription` is the worst branch to default into. A mislabelled operation flips `isSettingUp`, so the panel covers the user's real plan with a "setting up your subscription" spinner for as long as the operation is pending; `topupActionOperation` never matches; and `handleSuccess` reconciles the subscription instead of refetching the balance. Same failure #14715 fixed, waiting for the next value. An exhaustive `switch`: - `undefined` still resolves to `subscription` — the compatibility path for a server that does not send the field, and why #14715 was safe to land alone. - An unknown value reports to Sentry (`billing_unknown_resume_mode`). - `const unexpected: never = type` in `default` means a widened union fails to compile. **The unknown case still resumes as a subscription, deliberately.** It is reachable only when this bundle is older than the server. In that window, dropping recovery strands a customer who cannot reach the payment page, while a wrong panel clears on reload — so recovery wins, and the report is what makes the skew visible. `JSON.stringify` rather than `String` in the report: `String` throws on a value with no callable `toString`/`valueOf`, and throwing out of the branch that exists to absorb a bad value would abort the whole status read. The value came from a parsed response, so it cannot be circular. Three paths, all through `fetchStatus`: | Test | Covers | |---|---| | `recovers a pending subscription reported explicitly` | what the server sends today for an initial subscription or plan change | | `recovers a pending top-up as a top-up, not a subscription` | the `topup` path | | `reports a resume mode it does not recognize` | the unknown value — **verified red** against the old ternary | The absent-field compatibility path is already covered by the existing `recovers a pending subscription operation from billing status`. `vitest run --coverage` (76 passed, matching how CI runs unit tests), `pnpm typecheck`, `pnpm lint`, `pnpm format`. `BillingStatusResponse` is hand-written in `workspaceApi.ts` rather than taken from `@comfyorg/ingest-types`, so the `never` check is exhaustive over a hand-maintained union: it catches an edit to that union that misses this switch, but cannot widen on its own when the API changes. Single-sourcing it means regenerating the types package, which rewrites the whole generated surface and belongs in its own PR. Until then the Sentry report is the signal that matters here. The server-side counterpart is tracked separately and does not gate this PR. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1767 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T19:08:43.910Z",
"gitSha": "9f73c26e450a836fa196f702516b22abb561a72c",
"branch": "backport-14759-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.2359999999744,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.206,
"heapDeltaBytes": 3662324,
"heapUsedBytes": 71544236,
"domNodes": 18,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 24.835,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.3150000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.48799999999994,
"heapDeltaBytes": -21939512,
"heapUsedBytes": 46095156,
"domNodes": -270,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 15.523,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1907.7200000000403,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.092000000000006,
"layouts": 12,
"layoutDurationMs": 3.5340000000000007,
"taskDurationMs": 962.701,
"heapDeltaBytes": -16430424,
"heapUsedBytes": 51491524,
"domNodes": -272,
"jsHeapTotalBytes": 21753856,
"scriptDurationMs": 125.01499999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.5119999999624,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.15200000000001,
"layouts": 12,
"layoutDurationMs": 3.9419999999999993,
"taskDurationMs": 870.2860000000001,
"heapDeltaBytes": -16970320,
"heapUsedBytes": 51015444,
"domNodes": -276,
"jsHeapTotalBytes": 21491712,
"scriptDurationMs": 111.864,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.144999999994,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.011999999999997,
"layouts": 6,
"layoutDurationMs": 0.7129999999999999,
"taskDurationMs": 443.708,
"heapDeltaBytes": 7252264,
"heapUsedBytes": 75169796,
"domNodes": 79,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 27.419000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.4630000000025,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.862,
"layouts": 6,
"layoutDurationMs": 0.6740000000000002,
"taskDurationMs": 396.023,
"heapDeltaBytes": 7339512,
"heapUsedBytes": 75241792,
"domNodes": 77,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 22.171000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 654.3330000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.906000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.83399999999995,
"heapDeltaBytes": -12518844,
"heapUsedBytes": 55528436,
"domNodes": 16,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 66.056,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 561.35299999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.72,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.256,
"heapDeltaBytes": -12354312,
"heapUsedBytes": 55681676,
"domNodes": 14,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 54.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.6769999999738,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.813,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.0190000000001,
"heapDeltaBytes": 6809932,
"heapUsedBytes": 66072548,
"domNodes": -273,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 126.59899999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.3260000000264,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.866000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.893,
"heapDeltaBytes": 7777556,
"heapUsedBytes": 66758896,
"domNodes": -275,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 108.018,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2208.7000000000216,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.701999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.6870000000001,
"heapDeltaBytes": 4871812,
"heapUsedBytes": 65149604,
"domNodes": -278,
"jsHeapTotalBytes": 5775360,
"scriptDurationMs": 418.48799999999994,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2176.4599999999064,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1277.4359999999997,
"heapDeltaBytes": 2626316,
"heapUsedBytes": 62552412,
"domNodes": -277,
"jsHeapTotalBytes": 4988928,
"scriptDurationMs": 410.40900000000005,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3213.382999999965,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.049000000000003,
"layouts": 60,
"layoutDurationMs": 8.272,
"taskDurationMs": 1567.253,
"heapDeltaBytes": -1838492,
"heapUsedBytes": 59828736,
"domNodes": -265,
"jsHeapTotalBytes": 8192000,
"scriptDurationMs": 541.877,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3233.9170000000195,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.678,
"layouts": 60,
"layoutDurationMs": 8.08,
"taskDurationMs": 1562.22,
"heapDeltaBytes": 1147320,
"heapUsedBytes": 62918804,
"domNodes": -283,
"jsHeapTotalBytes": 7405568,
"scriptDurationMs": 543.1819999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.6470000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.252,
"heapDeltaBytes": 6850832,
"heapUsedBytes": 67920660,
"domNodes": -276,
"jsHeapTotalBytes": 4259840,
"scriptDurationMs": 125.62,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2047.633000000019,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.744000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.5209999999998,
"heapDeltaBytes": 6533820,
"heapUsedBytes": 67424976,
"domNodes": -276,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 115.82600000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.8819999999987,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.145999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.813,
"heapDeltaBytes": -12145248,
"heapUsedBytes": 55980304,
"domNodes": 18,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 121.16599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 635.5969999999616,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.0950000000001,
"heapDeltaBytes": -11822076,
"heapUsedBytes": 56191220,
"domNodes": 20,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 123.61999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.582000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.922999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.254,
"heapDeltaBytes": 3479324,
"heapUsedBytes": 71545572,
"domNodes": 18,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 20.513,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2032.1629999999686,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.26800000000003,
"heapDeltaBytes": -22159348,
"heapUsedBytes": 45867476,
"domNodes": 18,
"jsHeapTotalBytes": 19918848,
"scriptDurationMs": 15.969999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.0080000000085,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.972,
"layouts": 16,
"layoutDurationMs": 4.574,
"taskDurationMs": 866.592,
"heapDeltaBytes": -21826072,
"heapUsedBytes": 46159536,
"domNodes": 62,
"jsHeapTotalBytes": 21753856,
"scriptDurationMs": 96.81500000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.045000000032,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.415,
"layouts": 16,
"layoutDurationMs": 4.992,
"taskDurationMs": 834.915,
"heapDeltaBytes": -20450312,
"heapUsedBytes": 47920456,
"domNodes": -272,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 93.83800000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.6979999999203,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.571,
"layouts": 14,
"layoutDurationMs": 11.442,
"taskDurationMs": 962.7299999999999,
"heapDeltaBytes": 29191112,
"heapUsedBytes": 98104504,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 49.831,
"eventListeners": 2375,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8351.143999999977,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.453,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4707.602000000001,
"heapDeltaBytes": 10015140,
"heapUsedBytes": 69025660,
"domNodes": -276,
"jsHeapTotalBytes": 6795264,
"scriptDurationMs": 1379.426,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8339.1519999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.61,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4458.677,
"heapDeltaBytes": 10618056,
"heapUsedBytes": 69516400,
"domNodes": -277,
"jsHeapTotalBytes": 6795264,
"scriptDurationMs": 1364.24,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17891.214000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17868.979,
"heapDeltaBytes": -37280388,
"heapUsedBytes": 170806816,
"domNodes": -8312,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 565.084,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17988.263000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17940.177,
"heapDeltaBytes": -59749848,
"heapUsedBytes": 166534780,
"domNodes": -8312,
"jsHeapTotalBytes": -11730944,
"scriptDurationMs": 561.473,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22327.833,
"styleRecalcs": 163,
"styleRecalcDurationMs": 24.366999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22286.475,
"heapDeltaBytes": -44361780,
"heapUsedBytes": 164210020,
"domNodes": -8312,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 919.009,
"eventListeners": -16379,
"totalBlockingTimeMs": 520,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21677.431999999953,
"styleRecalcs": 151,
"styleRecalcDurationMs": 21.280999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21623.457000000002,
"heapDeltaBytes": -40167204,
"heapUsedBytes": 168773212,
"domNodes": -8312,
"jsHeapTotalBytes": -14618624,
"scriptDurationMs": 881.848,
"eventListeners": -16383,
"totalBlockingTimeMs": 359,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.3510000000688,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.025,
"layouts": 3,
"layoutDurationMs": 0.5569999999999999,
"taskDurationMs": 111.838,
"heapDeltaBytes": -15936328,
"heapUsedBytes": 51217524,
"domNodes": 130,
"jsHeapTotalBytes": 7995392,
"scriptDurationMs": 10.299000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 510.1560000000518,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.285999999999998,
"layouts": 2,
"layoutDurationMs": 0.418,
"taskDurationMs": 124.91199999999999,
"heapDeltaBytes": -16026500,
"heapUsedBytes": 50964104,
"domNodes": 117,
"jsHeapTotalBytes": 7208960,
"scriptDurationMs": 11.318,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.48 #14816 +/- ##
==========================================
Coverage 79.53% 79.53%
==========================================
Files 1749 1749
Lines 99617 99628 +11
Branches 31919 31923 +4
==========================================
+ Hits 79228 79239 +11
Misses 19988 19988
Partials 401 401
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #14759 — the automatic cherry-pick of
994d92ahit a conflict.Recovering a pending billing operation picked its client path with a two-way check, so anything that was not
topupbecamesubscription— including a value this client has never heard of.subscriptionis the worst branch to default into: a mislabelled operation flipsisSettingUp, covering the user's real plan with a "setting up your subscription" spinner until the operation settles. This replaces the ternary with an exhaustiveswitchthat reports an unrecognized value to Sentry (billing_unknown_resume_mode) and still resumes recovery.No behavior change against any value the API sends today.
Conflict resolution
One conflict, in the import block of
src/platform/workspace/composables/useWorkspaceBilling.ts:mainimportswatchfrom an unrelated change that is not on this branch. Kept this branch's vue import and added the@sentry/vueimport the cherry-pick needs.watchappears nowhere else in the file on this branch, so importing it would have been an unused-import error.The rest of the commit —
resumeModeFor, the call site, and all three tests — applied unchanged. Thepending_billing_op_typeunion inworkspaceApi.tsis identical here tomain, so theneverexhaustiveness check compiles as written.Verified on this branch
vitest run --coverageonuseWorkspaceBilling.test.ts(74 passed),pnpm typecheck,pnpm lint(0 errors),pnpm format:check.