Repository navigation
feat: add gold-700 color primitive - #14808
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1790 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.26 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 552 kB (baseline 552 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 387 kB (baseline 387 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 284 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T15:30:13.125Z",
"gitSha": "42018d6bf842f582944141fafd073db4da3a67d2",
"branch": "mariana/des-588-gold-700-primitive",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.0709999999594,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.1519999999999,
"heapDeltaBytes": 5605460,
"heapUsedBytes": 69700672,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 20.665000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.6320000000069,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.592,
"heapDeltaBytes": 5712644,
"heapUsedBytes": 69677356,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 20.989,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2139.282000000037,
"styleRecalcs": 79,
"styleRecalcDurationMs": 51.254000000000005,
"layouts": 12,
"layoutDurationMs": 4.125,
"taskDurationMs": 1176.441,
"heapDeltaBytes": -12844076,
"heapUsedBytes": 51566328,
"domNodes": -283,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 138.851,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1937.355000000025,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.18299999999999,
"layouts": 12,
"layoutDurationMs": 3.626,
"taskDurationMs": 948.723,
"heapDeltaBytes": -13487648,
"heapUsedBytes": 50694044,
"domNodes": -283,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 119.80999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1760.1950000000102,
"styleRecalcs": 31,
"styleRecalcDurationMs": 26.162000000000003,
"layouts": 6,
"layoutDurationMs": 0.768,
"taskDurationMs": 447.078,
"heapDeltaBytes": 8606304,
"heapUsedBytes": 72667208,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 23.882,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.5350000000271,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.583,
"layouts": 6,
"layoutDurationMs": 0.5900000000000001,
"taskDurationMs": 419.723,
"heapDeltaBytes": 8722920,
"heapUsedBytes": 73005980,
"domNodes": 75,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 23.429,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 631.1900000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.056,
"heapDeltaBytes": -10930844,
"heapUsedBytes": 53035760,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 58.891000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 595.0860000000375,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.370999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.921,
"heapDeltaBytes": -11324244,
"heapUsedBytes": 53026988,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 58.324000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2023.5869999999636,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.531999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 737.8439999999999,
"heapDeltaBytes": 6274456,
"heapUsedBytes": 65751548,
"domNodes": -282,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 107.682,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.2250000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.763999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.6619999999999,
"heapDeltaBytes": 4675960,
"heapUsedBytes": 64070260,
"domNodes": -279,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 106.71199999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2151.226999999949,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.993,
"heapDeltaBytes": 4198148,
"heapUsedBytes": 64683016,
"domNodes": -283,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 427.313,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2151.956000000041,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.405999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.4610000000002,
"heapDeltaBytes": 4469060,
"heapUsedBytes": 65905692,
"domNodes": -285,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 424.871,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3334.427000000005,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.328000000000003,
"layouts": 60,
"layoutDurationMs": 7.848000000000001,
"taskDurationMs": 1619.996,
"heapDeltaBytes": 4280248,
"heapUsedBytes": 66403568,
"domNodes": -288,
"jsHeapTotalBytes": 6922240,
"scriptDurationMs": 539.85,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3364.6159999999554,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.459,
"layouts": 60,
"layoutDurationMs": 7.7509999999999994,
"taskDurationMs": 1642.9209999999998,
"heapDeltaBytes": 5728452,
"heapUsedBytes": 68111972,
"domNodes": -289,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 555.8489999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.3759999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.272000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.662,
"heapDeltaBytes": 6827052,
"heapUsedBytes": 67380720,
"domNodes": -283,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 111.976,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.5309999999963,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.425000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.6990000000001,
"heapDeltaBytes": 6204364,
"heapUsedBytes": 66729316,
"domNodes": -282,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 106.79899999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 656.3510000000292,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.8739999999999,
"heapDeltaBytes": -10471744,
"heapUsedBytes": 53758608,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 130.56400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.223000000019,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.92600000000004,
"heapDeltaBytes": -10484288,
"heapUsedBytes": 53738956,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 122.32799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2057.1649999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.198999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.4369999999999,
"heapDeltaBytes": -18542648,
"heapUsedBytes": 45550424,
"domNodes": 20,
"jsHeapTotalBytes": 23572480,
"scriptDurationMs": 18.659000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2012.542999999937,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.845000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.7239999999999,
"heapDeltaBytes": -18029580,
"heapUsedBytes": 46334916,
"domNodes": -283,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 18.488,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1764.887999999985,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.32899999999999,
"layouts": 16,
"layoutDurationMs": 4.567999999999999,
"taskDurationMs": 914.1890000000001,
"heapDeltaBytes": -17420864,
"heapUsedBytes": 46645284,
"domNodes": -278,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 91.924,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1745.4079999999976,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.12799999999999,
"layouts": 16,
"layoutDurationMs": 4.934,
"taskDurationMs": 882.986,
"heapDeltaBytes": -4020268,
"heapUsedBytes": 60231648,
"domNodes": 63,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 97.934,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.5849999999864,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.26,
"layouts": 14,
"layoutDurationMs": 11.66,
"taskDurationMs": 938.1190000000001,
"heapDeltaBytes": 1457688,
"heapUsedBytes": 72553444,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 35.364999999999995,
"eventListeners": 2375,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8240.293000000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4768.495000000001,
"heapDeltaBytes": 11456284,
"heapUsedBytes": 71465448,
"domNodes": -281,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1391.2,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8192.823999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.303000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4777.8150000000005,
"heapDeltaBytes": 5237004,
"heapUsedBytes": 64645600,
"domNodes": -283,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 1389.924,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15941.389000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15899.151999999998,
"heapDeltaBytes": -31928736,
"heapUsedBytes": 166792400,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 588.618,
"eventListeners": -16387,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15828.826999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15806.408,
"heapDeltaBytes": -61844108,
"heapUsedBytes": 167591768,
"domNodes": -8312,
"jsHeapTotalBytes": -7020544,
"scriptDurationMs": 559.9750000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19052.531999999985,
"styleRecalcs": 130,
"styleRecalcDurationMs": 17.475999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19019.545000000002,
"heapDeltaBytes": -27263472,
"heapUsedBytes": 179542696,
"domNodes": -8312,
"jsHeapTotalBytes": -8105984,
"scriptDurationMs": 872.822,
"eventListeners": -16385,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19295.600000000035,
"styleRecalcs": 128,
"styleRecalcDurationMs": 18.415000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19260.340000000004,
"heapDeltaBytes": -46086556,
"heapUsedBytes": 167094872,
"domNodes": -8312,
"jsHeapTotalBytes": -7512064,
"scriptDurationMs": 992.5769999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 501.47999999990134,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.519000000000002,
"layouts": 2,
"layoutDurationMs": 0.356,
"taskDurationMs": 143.21900000000002,
"heapDeltaBytes": 5314264,
"heapUsedBytes": 68448964,
"domNodes": 136,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.805,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 473.9990000000489,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.72,
"layouts": 3,
"layoutDurationMs": 0.621,
"taskDurationMs": 119.175,
"heapDeltaBytes": 5068728,
"heapUsedBytes": 68320900,
"domNodes": 121,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.902000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14808.vercel.app This commit: https://website-frontend-a1nkd8ctd-comfyui.vercel.app Last updated: 2026-08-05T15:19:36Z for |
|
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14808 +/- ##
=======================================
Coverage 78.71% 78.71%
=======================================
Files 1804 1804
Lines 107023 107023
Branches 30683 30683
=======================================
Hits 84238 84238
Misses 22330 22330
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ELI5
Our warning color (gold) is bright enough to read on dark backgrounds, but on the light theme it's like yellow chalk on a whiteboard — technically there, hard to see. This adds one darker shade of the same gold to the palette so light-theme warnings can meet contrast guidelines.
Summary
--color-gold-700: #c77700to the design-system primitives, extending the existing gold ramp (400/500/600).--warning-backgroundslot, where gold-400 sits at 1.48:1 against the hero band (WCAG wants 3:1 at that size).Context
Identified during the mixed-severity errors panel review (#14252): dark theme measures 7.28:1 but light theme fails contrast. Agreed there that the token lands via the design-system side and #14252's follow-up points
--warning-backgroundat it for light theme, so this PR intentionally adds the primitive only — no consumers change and there is no visual change yet. Note Tailwind v4 may tree-shake the unused variable from built CSS until it's referenced; the source token is what the follow-up wires up.Part of DES-588.
Test plan
pnpm format:checkand stylelint pass (pre-commit)--warning-background(light) is repointed in the feat: compose warning-level missing diagnostics with blocking errors #14252 follow-up