Repository navigation
[backport core/1.49] fix(workflow): repair the A1111 import lifecycle and report broken installs accurately - #14750
Conversation
…stalls accurately (#14556) Splits out of #14251. Five lifecycle fixes on the A1111 image-import path. 30 production lines. ## What Dropping an A1111-generated PNG parses its `parameters` string and builds a ComfyUI graph from it. The path had four defects that only show up when something goes wrong, plus one that shows up always: 1. **`afterLoadNewGraph` was not awaited.** It suspends before the active workflow is reassigned, so `rootGraph.serialize()` on the next line captured the *outgoing* graph — the new tab was born dirty against a stale baseline. 2. **A rejection escaped an async DOM handler.** `importA1111` awaits `api.getEmbeddings()`, which does not check `resp.ok`. On a 500 with an HTML body it throws, `fileInput.value = ''` never runs, the input still holds the file, re-selecting it fires no `change` event, and Open silently does nothing on every retry. Now: `try`/`catch` with a toast, `finally` resets the input. 3. **Two identical alerts for one file.** The invalid-structure `else` and the parse `catch` each called `showErrorOnFileLoad`, then fell through to the final call at the end of `handleFile`. Those two are the `else` and `catch` of one `try`, so the maximum is two alerts, not three. 4. **`beforeLoadNewGraph()` ran before an import that might bail.** It calls `domWidgetStore.clear()`, and nothing re-registers on a bail path — a workflow with a multiline prompt on screen lost its DOM widget overlays when the user dropped a PNG that did not parse. It now runs immediately before the mutation, and the A1111 path gets the subgraph guard `clean()` already had. 5. **No message at all when required node types are unavailable, and silent corruption of the open workflow.** `importA1111` logged to the console and returned `void`. Because the call was unawaited, `afterLoadNewGraph` then registered the user's *unchanged* graph under the dropped file's name, after `beforeLoadNewGraph` had already cleared `domWidgetStore`. See below. ## The message The seven types this importer needs — `CheckpointLoaderSimple`, `CLIPSetLastLayer`, `CLIPTextEncode`, `KSampler`, `EmptyLatentImage`, `VAEDecode`, `SaveImage` — are all **core nodes**, as are `LoraLoader` and the hires chain. Their absence does not mean a node pack is missing. It means the backend did not load, or the install is broken. So this path deliberately writes nothing to the missing-node panel: no card, no entry, no placeholder. A type that was never added to the graph does not belong in a list of nodes missing *from the graph*, and naming the individual types would read as "install this pack" and send people looking for something that does not exist. ``` "Could not load the workflow because this ComfyUI installation is missing core nodes. Check that the backend started correctly." ``` `importA1111` returns `Promise<'imported' | 'not-a1111' | 'core-nodes-unavailable'>` — three string literals, replacing `Promise<boolean>`. The boolean could not distinguish "bailed and already told the user" from "bailed silently", which is how an ordinary A1111 PNG could vanish with no feedback at all: A1111 omits the `Negative prompt:` line entirely when the negative prompt is empty. The `core-nodes-unavailable` return happens **before** the graph is touched, so a failed import leaves the open workflow intact. `pnginfo.test.ts` asserts that directly. ## What this deliberately does not do `pnginfo.ts` is **+8 −4**, with zero re-indentation (`git diff` and `git diff -w` report the same line count). The nesting in that file is not pretty and it is not this PR's business. An earlier revision restructured it; that diff was 759 lines, ~72% of it re-indentation, and none of it fixed a bug. If it deserves a refactor it deserves a PR where a reviewer sees only that. ## Verification 6 unit tests across `app.test.ts`, `pnginfo.test.ts` and `ui.test.ts`, each mutation-proved. typecheck, lint, format, knip clean. Full unit suite: only pre-existing timeout flakes, confirmed by re-running the same files at the merge base and getting byte-identical results. ## Related - Follow-up to #14251 (closed) - Independent of #14555 and of the narrow submission fix — no ordering constraint
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T03:08:40.213Z",
"gitSha": "9d74fb77c6237567a74b1fdc8dac63a507792ce0",
"branch": "backport-14556-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.738999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.866999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.957,
"heapDeltaBytes": 5044760,
"heapUsedBytes": 73220528,
"domNodes": 20,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 19.482000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2012.2400000000198,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.192999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.29699999999997,
"heapDeltaBytes": 5268872,
"heapUsedBytes": 73685828,
"domNodes": 14,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 16.442,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2028.4190000000137,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.25600000000001,
"layouts": 12,
"layoutDurationMs": 3.8790000000000004,
"taskDurationMs": 1013.7559999999999,
"heapDeltaBytes": -16861256,
"heapUsedBytes": 51413368,
"domNodes": -281,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 132.44400000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1852.773999999954,
"styleRecalcs": 73,
"styleRecalcDurationMs": 40.647,
"layouts": 12,
"layoutDurationMs": 3.4200000000000004,
"taskDurationMs": 849.1500000000001,
"heapDeltaBytes": -83532,
"heapUsedBytes": 68121824,
"domNodes": 57,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 127.923,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1770.9449999999833,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.041,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 381.41999999999996,
"heapDeltaBytes": 7899528,
"heapUsedBytes": 75922192,
"domNodes": 77,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 18.316,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2300000000205,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.26,
"layouts": 6,
"layoutDurationMs": 0.5329999999999998,
"taskDurationMs": 383.954,
"heapDeltaBytes": 8008676,
"heapUsedBytes": 76336340,
"domNodes": 78,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 18.424999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.0119999999861,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.777000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.393,
"heapDeltaBytes": -12581736,
"heapUsedBytes": 55545672,
"domNodes": 18,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 58.254,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 603.0640000000176,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.99199999999996,
"heapDeltaBytes": -12406720,
"heapUsedBytes": 55821412,
"domNodes": 16,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 61.282000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2038.4279999999535,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.718,
"heapDeltaBytes": 8013728,
"heapUsedBytes": 67609220,
"domNodes": -281,
"jsHeapTotalBytes": 5562368,
"scriptDurationMs": 103.97699999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.7839999999933,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.805,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 759.0899999999999,
"heapDeltaBytes": 8442184,
"heapUsedBytes": 67629820,
"domNodes": -282,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 123.656,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2170.607000000018,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.059,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.5759999999998,
"heapDeltaBytes": 2042432,
"heapUsedBytes": 62207376,
"domNodes": -284,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 418.69100000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2198.8059999999905,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1346.539,
"heapDeltaBytes": -4875392,
"heapUsedBytes": 55232292,
"domNodes": -284,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 440.025,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3150.7650000000353,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.965000000000002,
"layouts": 60,
"layoutDurationMs": 6.949000000000001,
"taskDurationMs": 1468.963,
"heapDeltaBytes": -7342656,
"heapUsedBytes": 56864924,
"domNodes": -288,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 511.209,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3212.6949999999397,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.004,
"layouts": 60,
"layoutDurationMs": 7.404999999999999,
"taskDurationMs": 1507.144,
"heapDeltaBytes": 24357892,
"heapUsedBytes": 86510076,
"domNodes": 10,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 538.9920000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.3379999999866,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.846000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.65,
"heapDeltaBytes": 8789996,
"heapUsedBytes": 69509548,
"domNodes": -282,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 101.541,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.2150000000602,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.7299999999999,
"heapDeltaBytes": 8218104,
"heapUsedBytes": 69455352,
"domNodes": -281,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 108.77499999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.4269999999956,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.953999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.422,
"heapDeltaBytes": -11200108,
"heapUsedBytes": 57163472,
"domNodes": 20,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 117.589,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.466000000044,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.668,
"heapDeltaBytes": -10711580,
"heapUsedBytes": 57260536,
"domNodes": 22,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 114.76700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.783999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.222999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.075,
"heapDeltaBytes": 4766308,
"heapUsedBytes": 73070048,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 13.758999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.7540000000718,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.291000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.455,
"heapDeltaBytes": 4783452,
"heapUsedBytes": 73209856,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 17.435999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1745.283000000029,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.14,
"layouts": 16,
"layoutDurationMs": 4.704999999999999,
"taskDurationMs": 804.766,
"heapDeltaBytes": -20774280,
"heapUsedBytes": 47307400,
"domNodes": -280,
"jsHeapTotalBytes": 20692992,
"scriptDurationMs": 89.758,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.0319999999956,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.065,
"layouts": 16,
"layoutDurationMs": 5.077,
"taskDurationMs": 855.6579999999999,
"heapDeltaBytes": -4259368,
"heapUsedBytes": 63926744,
"domNodes": 64,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 98.644,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7349999999738,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.089000000000006,
"layouts": 14,
"layoutDurationMs": 13.005000000000003,
"taskDurationMs": 998.3649999999999,
"heapDeltaBytes": 31006924,
"heapUsedBytes": 99435964,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 37.784,
"eventListeners": 2375,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8297.239999999987,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.23800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4415.611,
"heapDeltaBytes": 12558844,
"heapUsedBytes": 71901372,
"domNodes": -282,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 1366.481,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8437.354000000028,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.75000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4812.512,
"heapDeltaBytes": 11866316,
"heapUsedBytes": 71452028,
"domNodes": -283,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 1456.7819999999997,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16907.024999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16875.041,
"heapDeltaBytes": -39104192,
"heapUsedBytes": 174630356,
"domNodes": -8312,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 595.231,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17192.313000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17171.463,
"heapDeltaBytes": -44680664,
"heapUsedBytes": 167033460,
"domNodes": -8312,
"jsHeapTotalBytes": -8855552,
"scriptDurationMs": 599.69,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20609.983,
"styleRecalcs": 140,
"styleRecalcDurationMs": 15.741000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20559.110999999997,
"heapDeltaBytes": -31351324,
"heapUsedBytes": 178277512,
"domNodes": -8312,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 881.3919999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 252,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20793.497000000003,
"styleRecalcs": 143,
"styleRecalcDurationMs": 16.933999999999948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20743.98,
"heapDeltaBytes": -27329032,
"heapUsedBytes": 180929516,
"domNodes": -8312,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 905.422,
"eventListeners": -16383,
"totalBlockingTimeMs": 265,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.0959999999832,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.386000000000003,
"layouts": 2,
"layoutDurationMs": 0.335,
"taskDurationMs": 124.97699999999999,
"heapDeltaBytes": -15754132,
"heapUsedBytes": 51713896,
"domNodes": 134,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 10.219,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.44299999999294,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.118,
"layouts": 3,
"layoutDurationMs": 1.1569999999999998,
"taskDurationMs": 118.938,
"heapDeltaBytes": -15797280,
"heapUsedBytes": 51561700,
"domNodes": 121,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 9.63,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.49 #14750 +/- ##
=============================================
+ Coverage 78.59% 78.73% +0.13%
=============================================
Files 1789 1789
Lines 104437 104449 +12
Branches 32026 32886 +860
=============================================
+ Hits 82086 82238 +152
+ Misses 21920 21781 -139
+ Partials 431 430 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14556 to
core/1.49Automatically created by backport workflow.