Repository navigation
Conversation
🎭 Playwright: ✅ 1787 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.26 MB gzip 🔴 +1.94 kBDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • 🔴 +2.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🔴 +5.54 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +152 BBundles that do not match a named category
Status: 78 added / 78 removed / 203 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T02:23:56.979Z",
"gitSha": "020380fb8fc89b3ec16dd6e8bcfea540c484f555",
"branch": "jaeone94/subgraph-image-widget-mirroring",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.8049999999876,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.299000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.404,
"heapDeltaBytes": 5560060,
"heapUsedBytes": 69449216,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 22.667,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.6649999999804,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.448000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.6970000000001,
"heapDeltaBytes": 5350668,
"heapUsedBytes": 69452224,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 20.979999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2048.893000000021,
"styleRecalcs": 81,
"styleRecalcDurationMs": 48.50600000000001,
"layouts": 12,
"layoutDurationMs": 4.2989999999999995,
"taskDurationMs": 1096.049,
"heapDeltaBytes": -12228516,
"heapUsedBytes": 51905164,
"domNodes": -280,
"jsHeapTotalBytes": 24621056,
"scriptDurationMs": 147.079,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1926.65599999998,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.163000000000004,
"layouts": 12,
"layoutDurationMs": 4.0360000000000005,
"taskDurationMs": 967.5679999999999,
"heapDeltaBytes": -12893224,
"heapUsedBytes": 51185736,
"domNodes": -281,
"jsHeapTotalBytes": 24883200,
"scriptDurationMs": 127.804,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.4350000000009,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.707,
"layouts": 6,
"layoutDurationMs": 0.793,
"taskDurationMs": 451.193,
"heapDeltaBytes": 8591312,
"heapUsedBytes": 72656104,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.936,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.5570000000098,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.008000000000003,
"layouts": 6,
"layoutDurationMs": 0.678,
"taskDurationMs": 412.88499999999993,
"heapDeltaBytes": 8745284,
"heapUsedBytes": 72702120,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 22.95,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 622.9260000000068,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.232,
"heapDeltaBytes": -11033276,
"heapUsedBytes": 53060892,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.074999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 629.3909999999414,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.801999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.797,
"heapDeltaBytes": -11000392,
"heapUsedBytes": 53114992,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 63.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.4990000000107,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.6550000000001,
"heapDeltaBytes": 7240844,
"heapUsedBytes": 67125736,
"domNodes": -282,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 119.01599999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.881000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.988000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.0849999999999,
"heapDeltaBytes": 9749492,
"heapUsedBytes": 69738068,
"domNodes": -282,
"jsHeapTotalBytes": 2203648,
"scriptDurationMs": 126.13499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2265.824000000009,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.119999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1398.497,
"heapDeltaBytes": 509148,
"heapUsedBytes": 61438532,
"domNodes": -283,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 472.65000000000003,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2180.5480000000443,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.223999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1316.56,
"heapDeltaBytes": -5484064,
"heapUsedBytes": 55653204,
"domNodes": -284,
"jsHeapTotalBytes": 7708672,
"scriptDurationMs": 426.50300000000004,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3293.9230000000066,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.047,
"layouts": 60,
"layoutDurationMs": 8.873,
"taskDurationMs": 1600.471,
"heapDeltaBytes": 24686660,
"heapUsedBytes": 87195900,
"domNodes": 14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 567.923,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3229.5070000000123,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.913999999999998,
"layouts": 60,
"layoutDurationMs": 8.506,
"taskDurationMs": 1603.372,
"heapDeltaBytes": -1635236,
"heapUsedBytes": 61124508,
"domNodes": -289,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 553.1519999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.7839999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.5579999999999,
"heapDeltaBytes": 6900088,
"heapUsedBytes": 67465520,
"domNodes": -283,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 128.192,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.108999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.4839999999999,
"heapDeltaBytes": 7063412,
"heapUsedBytes": 67468164,
"domNodes": -284,
"jsHeapTotalBytes": 4300800,
"scriptDurationMs": 125.168,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.1040000000316,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.69,
"heapDeltaBytes": -10389532,
"heapUsedBytes": 53652384,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 129.058,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.9539999999834,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.023,
"heapDeltaBytes": -10329200,
"heapUsedBytes": 53807392,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 122.968,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.0009999999784,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.9960000000001,
"heapDeltaBytes": 5220296,
"heapUsedBytes": 69300176,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 19.837999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2000.9709999999359,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.236999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.174,
"heapDeltaBytes": 5087008,
"heapUsedBytes": 69251088,
"domNodes": 14,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.533,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.7830000000122,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.89699999999999,
"layouts": 16,
"layoutDurationMs": 5.151999999999999,
"taskDurationMs": 836.4830000000001,
"heapDeltaBytes": -4285448,
"heapUsedBytes": 59854988,
"domNodes": 61,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 100.12,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.0890000000336,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.341,
"layouts": 16,
"layoutDurationMs": 5.08,
"taskDurationMs": 729.84,
"heapDeltaBytes": -4245052,
"heapUsedBytes": 59837928,
"domNodes": 61,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 98.52900000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3249999999857,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.992000000000004,
"layouts": 13,
"layoutDurationMs": 11.362,
"taskDurationMs": 1022.53,
"heapDeltaBytes": 30742592,
"heapUsedBytes": 99541384,
"domNodes": 13753,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 54.728999999999985,
"eventListeners": 2375,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8394.022000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.662000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4803.184,
"heapDeltaBytes": 11034232,
"heapUsedBytes": 71309648,
"domNodes": -285,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1454.2469999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8307.949000000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.535999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4713.599,
"heapDeltaBytes": 11335832,
"heapUsedBytes": 71981696,
"domNodes": -282,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 1401.665,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14535.693999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14506.58,
"heapDeltaBytes": -46619804,
"heapUsedBytes": 171766376,
"domNodes": -8312,
"jsHeapTotalBytes": -4890624,
"scriptDurationMs": 574.725,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18682.105999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18665.636,
"heapDeltaBytes": -43893088,
"heapUsedBytes": 167471352,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 599.0020000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23184.347,
"styleRecalcs": 175,
"styleRecalcDurationMs": 27.937999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23144.98,
"heapDeltaBytes": -56784192,
"heapUsedBytes": 167217604,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 972.923,
"eventListeners": -16381,
"totalBlockingTimeMs": 805,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23425.293000000012,
"styleRecalcs": 176,
"styleRecalcDurationMs": 27.144000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23388.424,
"heapDeltaBytes": -40383220,
"heapUsedBytes": 166886812,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 938.2920000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 1020,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 461.61599999999225,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.37,
"layouts": 2,
"layoutDurationMs": 0.44300000000000006,
"taskDurationMs": 119.878,
"heapDeltaBytes": 5312664,
"heapUsedBytes": 68276340,
"domNodes": 134,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.633000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.83699999993223,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.232,
"layouts": 3,
"layoutDurationMs": 0.7000000000000001,
"taskDurationMs": 116.06200000000001,
"heapDeltaBytes": 5085272,
"heapUsedBytes": 68293648,
"domNodes": 121,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.084,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
📝 WalkthroughWalkthroughAdded nested promoted-input boundary resolution and subgraph host execution tracking. Linked image widgets now display host-scoped values as read-only previews. Browser tests cover direct, nested, fallback, and navigation scenarios. ChangesPromoted image widget projection
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant SubgraphNavigationStore
participant UseProcessedWidgets
participant ImagePreview
User->>SubgraphNavigationStore: Open nested subgraph
SubgraphNavigationStore-->>UseProcessedWidgets: Active host execution ID
UseProcessedWidgets->>UseProcessedWidgets: Resolve linked image value
UseProcessedWidgets-->>ImagePreview: Render read-only projected preview
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/assets/subgraphs/subgraph-with-promoted-image-widget.json`:
- Around line 63-68: Update the subgraph state’s lastLinkId value from 1 to 3,
preserving the existing lastGroupId, lastNodeId, and lastRerouteId values.
In `@browser_tests/tests/subgraph/subgraphPromotedImageWidget.spec.ts`:
- Line 68: Replace all four `.image-preview img` locators in the subgraph
promoted image widget test with a dedicated `TestIds` selector. Add the
corresponding data-testid to the preview image in `ImagePreview.vue`, register
it in `browser_tests/fixtures/selectors.ts`, and use that registered selector
consistently in the test.
In `@src/core/graph/subgraph/promotedInputBoundary.ts`:
- Around line 19-23: Update resolvePromotedInputBoundaryChain to accept
NodeExecutionId instead of string, preserving the branded type at the shared
boundary API. Propagate the same precise type through getHostExecutionId and
related subgraph boundary, widget-resolution, execution store, and test changes
without weakening it back to string.
In `@src/renderer/extensions/vueNodes/components/LGraphNode.vue`:
- Around line 777-780: Update the linkedImageWidgetMedia computed value to
return only linkedImageWidgetProjection.value when a linked image widget exists,
without falling back to nodeMedia.value. Preserve nodeMedia.value for the
existing v-else-if branch so node outputs retain their node data and remain
visible when the projection is absent or has no preview URLs.
In
`@src/renderer/extensions/vueNodes/composables/resolveLinkedImageWidgetValue.ts`:
- Around line 38-49: Remove the app.getRandParam() contribution from the preview
URL assembled in getImageWidgetPreviewUrls, while preserving the filename,
preview format, and other existing parameters. Keep mirrored image identity
driven by the filename so computed-property recomputation does not change the
URL unnecessarily.
- Around line 22-28: Update isLinkedImageWidget to require the widget’s promoted
subgraph-boundary marker in addition to slotMetadata.linked, while preserving
the existing combo-spec and image-upload checks. Ensure linked input-slot
widgets that are not promoted boundary widgets return false and therefore do not
receive the linked-image modifiers.
In `@src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts`:
- Around line 571-663: Split the combined test around computeProcessedWidgets
into three focused cases: exact host-specific projection, ambiguous fallback to
the interior definition value, and the read-only updateHandler no-op. Extract
the shared rootGraph/subgraph, host nodes, widget store, and base options setup
into a reusable fixture helper, while preserving each case’s existing assertions
and behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f48be0d5-c83a-4348-b673-a8d8e907fa86
📒 Files selected for processing (24)
browser_tests/assets/subgraphs/subgraph-with-nested-promoted-image-widget.jsonbrowser_tests/assets/subgraphs/subgraph-with-promoted-image-widget.jsonbrowser_tests/tests/subgraph/subgraphPromotedImageWidget.spec.tssrc/core/graph/subgraph/liftNodeErrorsToBoundary.tssrc/core/graph/subgraph/promotedInputBoundary.tssrc/core/graph/subgraph/subgraphHostExecution.test.tssrc/core/graph/subgraph/subgraphHostExecution.tssrc/lib/litegraph/src/infrastructure/LGraphCanvasEventMap.tssrc/locales/en/main.jsonsrc/renderer/extensions/vueNodes/components/ImagePreview.test.tssrc/renderer/extensions/vueNodes/components/ImagePreview.vuesrc/renderer/extensions/vueNodes/components/LGraphNode.subgraph.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vuesrc/renderer/extensions/vueNodes/components/NodeContent.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.test.tssrc/renderer/extensions/vueNodes/composables/resolveLinkedImageWidgetValue.test.tssrc/renderer/extensions/vueNodes/composables/resolveLinkedImageWidgetValue.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.test.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vuesrc/stores/executionErrorStore.tssrc/stores/subgraphNavigationStore.ts
| "state": { | ||
| "lastGroupId": 0, | ||
| "lastNodeId": 1, | ||
| "lastLinkId": 1, | ||
| "lastRerouteId": 0 | ||
| }, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Set lastLinkId to 3 in the subgraph state.
The definition contains links with ids 1, 2, and 3, but state.lastLinkId is 1. The equivalent definition in subgraph-with-nested-promoted-image-widget.json uses "lastLinkId": 3. A stale counter lets a link created during a test reuse an existing id inside this subgraph.
🐛 Proposed fix
"state": {
"lastGroupId": 0,
"lastNodeId": 1,
- "lastLinkId": 1,
+ "lastLinkId": 3,
"lastRerouteId": 0
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "state": { | |
| "lastGroupId": 0, | |
| "lastNodeId": 1, | |
| "lastLinkId": 1, | |
| "lastRerouteId": 0 | |
| }, | |
| "state": { | |
| "lastGroupId": 0, | |
| "lastNodeId": 1, | |
| "lastLinkId": 3, | |
| "lastRerouteId": 0 | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@browser_tests/assets/subgraphs/subgraph-with-promoted-image-widget.json`
around lines 63 - 68, Update the subgraph state’s lastLinkId value from 1 to 3,
preserving the existing lastGroupId, lastNodeId, and lastRerouteId values.
| name: 'image32x32.webp', | ||
| exact: true | ||
| }) | ||
| const previewImage = interiorNode.locator('.image-preview img') |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Replace the .image-preview img CSS locator with a test id.
Four assertions in this file depend on the .image-preview class name. A styling change to ImagePreview.vue breaks all four without any functional regression. Add a data-testid to the preview image in ImagePreview.vue, register it in browser_tests/fixtures/selectors.ts, and select it through TestIds.
♻️ Suggested locator change
- const previewImage = interiorNode.locator('.image-preview img')
+ const previewImage = interiorNode.getByTestId(
+ TestIds.nodes.imagePreviewImage
+ )Apply the same substitution at lines 166, 177, and 187.
Also applies to: 166-166, 177-177, 187-187
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@browser_tests/tests/subgraph/subgraphPromotedImageWidget.spec.ts` at line 68,
Replace all four `.image-preview img` locators in the subgraph promoted image
widget test with a dedicated `TestIds` selector. Add the corresponding
data-testid to the preview image in `ImagePreview.vue`, register it in
`browser_tests/fixtures/selectors.ts`, and use that registered selector
consistently in the test.
| export function resolvePromotedInputBoundaryChain( | ||
| rootGraph: LGraph, | ||
| executionId: string, | ||
| inputName: string | ||
| ): PromotedInputBoundary[] { |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Type executionId as NodeExecutionId.
All three call sites pass a branded NodeExecutionId (liftNodeErrorsToBoundary.ts, executionErrorStore.ts, resolveLinkedImageWidgetValue.ts). The string parameter drops that guarantee at the shared boundary API. getHostExecutionId already returns NodeExecutionId | null, so the internal loop stays typed after the change.
♻️ Proposed signature tightening
export function resolvePromotedInputBoundaryChain(
rootGraph: LGraph,
- executionId: string,
+ executionId: NodeExecutionId,
inputName: string
): PromotedInputBoundary[] {
const chain: PromotedInputBoundary[] = []
- let currentExecutionId = executionId
+ let currentExecutionId: NodeExecutionId = executionIdgetHostExecutionId also accepts NodeExecutionId instead of string after this change.
As per path instructions: "Use precise TypeScript types throughout the subgraph boundary, widget-resolution, store, and test changes."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export function resolvePromotedInputBoundaryChain( | |
| rootGraph: LGraph, | |
| executionId: string, | |
| inputName: string | |
| ): PromotedInputBoundary[] { | |
| export function resolvePromotedInputBoundaryChain( | |
| rootGraph: LGraph, | |
| executionId: NodeExecutionId, | |
| inputName: string | |
| ): PromotedInputBoundary[] { |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/core/graph/subgraph/promotedInputBoundary.ts` around lines 19 - 23,
Update resolvePromotedInputBoundaryChain to accept NodeExecutionId instead of
string, preserving the branded type at the shared boundary API. Propagate the
same precise type through getHostExecutionId and related subgraph boundary,
widget-resolution, execution store, and test changes without weakening it back
to string.
Source: Path instructions
| const linkedImageWidgetMedia = computed(() => { | ||
| if (!linkedImageWidget.value) return undefined | ||
| return linkedImageWidgetProjection.value ?? nodeMedia.value | ||
| }) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not route the node's own output media through the read-only linked-image branch.
linkedImageWidgetMedia falls back to nodeMedia.value whenever the node has a linked image widget, even when no projection resolves. Two effects follow at lines 175-185 and 594-595:
- The node's own executed output renders through
<NodeContent read-only>without:node-data, while thev-else-if="nodeMedia"branch passes:node-data. Nodes with a linked image widget and their own outputs lose that prop and become read-only. - When a projection resolves but
getImageWidgetPreviewUrlsreturns an empty array,linkedImageWidgetMediais a truthy object withurls: [].hasCustomContentthen evaluates to false and the node's own output preview disappears.
Keep the projection separate from nodeMedia and let the existing v-else-if="nodeMedia" branch handle node outputs.
🐛 Proposed fix
const linkedImageWidgetMedia = computed(() => {
- if (!linkedImageWidget.value) return undefined
- return linkedImageWidgetProjection.value ?? nodeMedia.value
+ const projection = linkedImageWidgetProjection.value
+ if (!projection?.urls.length) return undefined
+ return projection
})hasCustomContent at lines 594-595 then keeps working unchanged, because nodeMedia remains the fallback source.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const linkedImageWidgetMedia = computed(() => { | |
| if (!linkedImageWidget.value) return undefined | |
| return linkedImageWidgetProjection.value ?? nodeMedia.value | |
| }) | |
| const linkedImageWidgetMedia = computed(() => { | |
| const projection = linkedImageWidgetProjection.value | |
| if (!projection?.urls.length) return undefined | |
| return projection | |
| }) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/renderer/extensions/vueNodes/components/LGraphNode.vue` around lines 777
- 780, Update the linkedImageWidgetMedia computed value to return only
linkedImageWidgetProjection.value when a linked image widget exists, without
falling back to nodeMedia.value. Preserve nodeMedia.value for the existing
v-else-if branch so node outputs retain their node data and remain visible when
the projection is absent or has no preview URLs.
| export function isLinkedImageWidget( | ||
| widget: Pick<SafeWidgetData, 'slotMetadata' | 'spec'> | ||
| ): boolean { | ||
| if (!widget.slotMetadata?.linked || !widget.spec) return false | ||
| if (!isComboInputSpec(widget.spec)) return false | ||
| return widget.spec.image_upload || widget.spec.animated_image_upload || false | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Locate linked-slot handling for combo image widgets outside subgraph promotion.
set -euo pipefail
# Where slotMetadata.linked drives widget rendering decisions.
rg -n --type=ts --type=vue -C4 'slotMetadata\?\.linked|slotMetadata\.linked'
# Where image_upload / animated_image_upload specs are consumed.
rg -n --type=ts --type=vue -C4 'animated_image_upload|image_upload'
# Existing read_only handling in widget components.
rg -n --type=ts --type=vue -C4 '\bread_only\b'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 164
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Repository root:"
pwd
echo "Git status/stat:"
git status --short
git diff --stat || true
echo "Find target and related files:"
fd -a 'resolveLinkedImageWidgetValue|widget' . | sed 's#^\./##' | head -100
echo "Locate target file:"
fd 'resolveLinkedImageWidgetValue.ts|resolveLinkedImageWidgetValue' . || true
echo "Search relevant identifiers:"
rg -n --type=ts --type=vue -C3 'isLinkedImageWidget|slotMetadata.*linked|link.*slot|image_upload|animated_image_upload|read_only|disabled' . || trueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 50383
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Target file:"
file="$(fd 'resolveLinkedImageWidgetValue.ts' . | head -1 || true)"
echo "$file"
if [ -n "$file" ]; then
cat -n "$file"
fi
echo
echo "Focused linked/image/read_only searches:"
rg -n --type=ts --type=vue -C3 'isLinkedImageWidget|safeWidgetData|SafeWidgetData|computeProcessedWidgets|slotMetadata\?\.linked|slotMetadata\.linked|image_upload|animated_image_upload|read_only' . \
--glob '!**/*.test.ts' --glob '!**/*.stories.ts' --glob '!**/__fixtures__/**' --glob '!**/__mocks__/**' | head -240 || true
echo
echo "ComputeProcessedWidgets occurrences:"
rg -n --type=ts --type=vue -C5 'computeProcessedWidgets' . || trueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 41768
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="./src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts"
echo "useProcessedWidgets.ts line count:"
wc -l "$file"
echo
sed -n '220,360p' "$file" | cat -n
echo
echo "Targeted references only:"
rg -n -C2 'link|linked|subgraph|SubgraphNode|promoted|isSubgraphNode|image_upload|animated_image_upload|read_only|disabled' "$file"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 7627
Restrict linked image behavior to promoted boundary widgets.
isLinkedImageWidget matches any combo image widget with slotMetadata.linked, so linked input-slot widgets anywhere in the graph also set disabled, read_only, and the update handler to undefined. Limit the scope, for example by requiring a promoted subgraph boundary before applying these modifiers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@src/renderer/extensions/vueNodes/composables/resolveLinkedImageWidgetValue.ts`
around lines 22 - 28, Update isLinkedImageWidget to require the widget’s
promoted subgraph-boundary marker in addition to slotMetadata.linked, while
preserving the existing combo-spec and image-upload checks. Ensure linked
input-slot widgets that are not promoted boundary widgets return false and
therefore do not receive the linked-image modifiers.
| return values.flatMap((rawValue) => { | ||
| const { filename, subfolder, type } = parseImageWidgetValue(rawValue) | ||
| if (!filename) return [] | ||
|
|
||
| const params = new URLSearchParams({ filename, subfolder, type }) | ||
| appendCloudResParam(params, filename) | ||
| return [ | ||
| api.apiURL( | ||
| `/view?${params}${app.getPreviewFormatParam()}${app.getRandParam()}` | ||
| ) | ||
| ] | ||
| }) |
There was a problem hiding this comment.
🚀 Performance & Scalability | 🟡 Minor | ⚡ Quick win
Drop app.getRandParam() from mirrored preview URLs.
getImageWidgetPreviewUrls runs inside computed properties in LGraphNode.vue. app.getRandParam() returns a new value on each call, so every recomputation changes the src attribute and forces the browser to refetch an image that did not change. The mirrored value already changes the filename parameter when the host selection changes, so the identity of the image is already part of the URL.
🐛 Proposed fix
const params = new URLSearchParams({ filename, subfolder, type })
appendCloudResParam(params, filename)
return [
- api.apiURL(
- `/view?${params}${app.getPreviewFormatParam()}${app.getRandParam()}`
- )
+ api.apiURL(`/view?${params}${app.getPreviewFormatParam()}`)
]
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| return values.flatMap((rawValue) => { | |
| const { filename, subfolder, type } = parseImageWidgetValue(rawValue) | |
| if (!filename) return [] | |
| const params = new URLSearchParams({ filename, subfolder, type }) | |
| appendCloudResParam(params, filename) | |
| return [ | |
| api.apiURL( | |
| `/view?${params}${app.getPreviewFormatParam()}${app.getRandParam()}` | |
| ) | |
| ] | |
| }) | |
| return values.flatMap((rawValue) => { | |
| const { filename, subfolder, type } = parseImageWidgetValue(rawValue) | |
| if (!filename) return [] | |
| const params = new URLSearchParams({ filename, subfolder, type }) | |
| appendCloudResParam(params, filename) | |
| return [ | |
| api.apiURL(`/view?${params}${app.getPreviewFormatParam()}`) | |
| ] | |
| }) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@src/renderer/extensions/vueNodes/composables/resolveLinkedImageWidgetValue.ts`
around lines 38 - 49, Remove the app.getRandParam() contribution from the
preview URL assembled in getImageWidgetPreviewUrls, while preserving the
filename, preview format, and other existing parameters. Keep mirrored image
identity driven by the filename so computed-property recomputation does not
change the URL unnecessarily.
| it('projects an exact host image value and keeps the interior fallback when context is ambiguous', () => { | ||
| const rootGraph = createTestRootGraph() | ||
| const subgraph = createTestSubgraph({ | ||
| rootGraph, | ||
| inputs: [{ name: 'image', type: 'COMBO' }] | ||
| }) | ||
| const interiorNode = new LGraphNode('LoadImage') | ||
| interiorNode.id = toNodeId(5) | ||
| const interiorInput = interiorNode.addInput('image', 'COMBO') | ||
| interiorInput.widget = { name: 'image' } | ||
| interiorNode.addWidget('combo', 'image', 'interior.png', () => undefined, { | ||
| values: ['interior.png', 'first.png', 'second.png'] | ||
| }) | ||
| subgraph.add(interiorNode) | ||
| subgraph.inputNode.slots[0].connect(interiorInput, interiorNode) | ||
|
|
||
| const firstHost = createTestSubgraphNode(subgraph, { id: 11 }) | ||
| const secondHost = createTestSubgraphNode(subgraph, { id: 12 }) | ||
| rootGraph.add(firstHost) | ||
| rootGraph.add(secondHost) | ||
|
|
||
| const firstWidgetId = firstHost.inputs[0].widgetId | ||
| const secondWidgetId = secondHost.inputs[0].widgetId | ||
| expect(firstWidgetId).toBeDefined() | ||
| expect(secondWidgetId).toBeDefined() | ||
| if (!firstWidgetId || !secondWidgetId) return | ||
|
|
||
| const widgetValueStore = useWidgetValueStore() | ||
| widgetValueStore.registerWidget( | ||
| widgetId(rootGraph.id, interiorNode.id, 'image'), | ||
| { | ||
| type: 'combo', | ||
| value: 'interior.png', | ||
| options: {} | ||
| } | ||
| ) | ||
| widgetValueStore.setValue(firstWidgetId, 'first.png') | ||
| widgetValueStore.setValue(secondWidgetId, 'second.png') | ||
|
|
||
| const imageWidget = createMockWidget({ | ||
| name: 'image', | ||
| nodeId: interiorNode.id, | ||
| slotMetadata: { index: 0, linked: true, type: 'COMBO' }, | ||
| spec: { type: 'COMBO', name: 'image', image_upload: true } | ||
| }) | ||
| const nodeData = { | ||
| id: interiorNode.id, | ||
| type: 'LoadImage', | ||
| widgets: [imageWidget], | ||
| title: 'Load Image', | ||
| mode: 0, | ||
| selected: false, | ||
| executing: false, | ||
| inputs: [], | ||
| outputs: [] | ||
| } | ||
| const baseOptions = { | ||
| nodeData, | ||
| graphId: rootGraph.id, | ||
| showAdvanced: false, | ||
| isGraphReady: false, | ||
| rootGraph, | ||
| ui: noopUi | ||
| } | ||
|
|
||
| const exactResult = computeProcessedWidgets({ | ||
| ...baseOptions, | ||
| activeSubgraphHostExecutionId: createNodeExecutionId([12]) | ||
| }) | ||
| const ambiguousResult = computeProcessedWidgets(baseOptions) | ||
|
|
||
| expect(exactResult[0]).toMatchObject({ | ||
| value: 'second.png', | ||
| simplified: { | ||
| value: 'second.png', | ||
| options: { disabled: true, read_only: true } | ||
| } | ||
| }) | ||
| expect(ambiguousResult[0]).toMatchObject({ | ||
| value: 'interior.png', | ||
| simplified: { | ||
| value: 'interior.png', | ||
| options: { disabled: true, read_only: true } | ||
| } | ||
| }) | ||
|
|
||
| ambiguousResult[0].updateHandler('changed.png') | ||
| expect( | ||
| widgetValueStore.getWidget( | ||
| widgetId(rootGraph.id, interiorNode.id, 'image') | ||
| )?.value | ||
| ).toBe('interior.png') | ||
| }) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Split this test into one case per behavior.
The test asserts three separate contracts: exact host projection, ambiguous fallback to the definition-local value, and the read-only no-op handler. A failure in any one of them reports the same test name, so the failing behavior is not identifiable from the report. Extract the shared fixture into a helper and keep three focused cases.
♻️ Suggested structure
- it('projects an exact host image value and keeps the interior fallback when context is ambiguous', () => {
+ function setupPromotedImageFixture() {
const rootGraph = createTestRootGraph()
// ... existing fixture setup ...
+ return { baseOptions, widgetValueStore, interiorNode, rootGraph }
+ }
+
+ it('projects the value of the selected host execution', () => {
+ const { baseOptions } = setupPromotedImageFixture()
+ expect(
+ computeProcessedWidgets({
+ ...baseOptions,
+ activeSubgraphHostExecutionId: createNodeExecutionId([12])
+ })[0]
+ ).toMatchObject({ value: 'second.png' })
+ })
+
+ it('keeps the definition-local value when the host context is ambiguous', () => {
+ const { baseOptions } = setupPromotedImageFixture()
+ expect(computeProcessedWidgets(baseOptions)[0]).toMatchObject({
+ value: 'interior.png'
+ })
+ })
+
+ it('renders linked image widgets read-only and ignores updates', () => {
+ const { baseOptions, widgetValueStore, interiorNode, rootGraph } =
+ setupPromotedImageFixture()
+ const [processed] = computeProcessedWidgets(baseOptions)
+ expect(processed.simplified.options).toMatchObject({
+ disabled: true,
+ read_only: true
+ })
+ processed.updateHandler('changed.png')
+ expect(
+ widgetValueStore.getWidget(
+ widgetId(rootGraph.id, interiorNode.id, 'image')
+ )?.value
+ ).toBe('interior.png')
+ })As per path instructions: "Review the new unit and Playwright coverage behaviorally: cover host-specific, nested, ambiguous, missing-boundary, read-only, and fallback cases."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts`
around lines 571 - 663, Split the combined test around computeProcessedWidgets
into three focused cases: exact host-specific projection, ambiguous fallback to
the interior definition value, and the read-only updateHandler no-op. Extract
the shared rootGraph/subgraph, host nodes, widget store, and base options setup
into a reusable fixture helper, while preserving each case’s existing assertions
and behavior.
Source: Path instructions
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14745 +/- ##
==========================================
- Coverage 79.51% 79.51% -0.01%
==========================================
Files 1795 1798 +3
Lines 116642 116761 +119
Branches 34027 33240 -787
==========================================
+ Hits 92751 92843 +92
- Misses 23336 23359 +23
- Partials 555 559 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ELI5
A subgraph is like a reusable box: when an image is selected on the outside, looking inside should still show that same image. This PR mirrors the active outer node's image value and preview into the inner image widget, keeps the inner control read-only, and provides a small path back to the source node.
Motivation
Promoted image inputs are edited on the containing subgraph node, but opening the subgraph previously left the inner Load Image widget showing its definition-local value and no matching preview. That makes inspection misleading, especially in nested subgraphs where the same definition may be instantiated more than once. The image-widget case is the first priority because its value and visual preview can disagree at the same time. This change keeps the subgraph definition read-only from the inside while reflecting the active host instance when that runtime context is known.
Provenance
interactive sessionpnpm lint;pnpm typecheck;pnpm knip; targetedpnpm test:unit(193 passed); promoted image widget Playwright spec (3 passed on retry after one cold-start setup timeout)Reviewer context
Summary
Changes
Review Focus
subgraphNavigationStoreand remains compatible with shared subgraph definitions.Test plan
This behavior is intentionally ungated because it corrects the existing subgraph image inspection path without introducing a new workflow mode or persisted data format.