Repository navigation
[backport cloud/1.49] hotfix: custom nodes adding widgets on subgraph nodes - #14727
Conversation
VHS directly adds sampling previews onto parent subgraphs (partially to merge lifecycle across multiple ksamplers in multi-stage workflows), but this conflicts with requiring that all widgets on a subgraphNode have associated promoted inputs. This PR adds a minimal reproduction test, and a proposed fix. Of note, this change necessitates custom nodes go through the appropriate api methods and still disallows blindly muting `node.widgets` Resolves Kosinkadink/ComfyUI-VideoHelperSuite#695
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1791 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-05T00:03:27.730Z",
"gitSha": "73db9ea9a6b9ffed3c37b436d12e46802355fef4",
"branch": "backport-14707-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2065.8070000000066,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.303,
"heapDeltaBytes": 5188960,
"heapUsedBytes": 73271444,
"domNodes": 12,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 20.122999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.1590000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.024999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.837,
"heapDeltaBytes": 5307184,
"heapUsedBytes": 73667100,
"domNodes": 18,
"jsHeapTotalBytes": 19517440,
"scriptDurationMs": 17.313,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.1440000000207,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.007000000000005,
"layouts": 12,
"layoutDurationMs": 3.718,
"taskDurationMs": 873.376,
"heapDeltaBytes": -383308,
"heapUsedBytes": 67894676,
"domNodes": 61,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 122.926,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.4040000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.97299999999999,
"layouts": 12,
"layoutDurationMs": 3.523,
"taskDurationMs": 895.461,
"heapDeltaBytes": -17735244,
"heapUsedBytes": 50639640,
"domNodes": -281,
"jsHeapTotalBytes": 19906560,
"scriptDurationMs": 117.96000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.5980000000204,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.95,
"layouts": 6,
"layoutDurationMs": 0.6539999999999998,
"taskDurationMs": 403.169,
"heapDeltaBytes": 7826824,
"heapUsedBytes": 76024748,
"domNodes": 77,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 22.308,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.4080000000122,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.522000000000002,
"layouts": 6,
"layoutDurationMs": 0.7259999999999999,
"taskDurationMs": 390.7080000000001,
"heapDeltaBytes": 7892520,
"heapUsedBytes": 76047064,
"domNodes": 78,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 21.148999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.8390000000181,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.333,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.01300000000003,
"heapDeltaBytes": -12019768,
"heapUsedBytes": 56184236,
"domNodes": 18,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 62.543,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 605.0880000000234,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.909999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.13,
"heapDeltaBytes": -12496764,
"heapUsedBytes": 55685240,
"domNodes": 16,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 61.443000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.5460000000344,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.937000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 699.0489999999999,
"heapDeltaBytes": 8432180,
"heapUsedBytes": 67680476,
"domNodes": -283,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 105.683,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.401000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.046999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.0669999999999,
"heapDeltaBytes": 7785552,
"heapUsedBytes": 66724172,
"domNodes": -282,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 102.98100000000001,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2202.124000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.986,
"heapDeltaBytes": 5220992,
"heapUsedBytes": 65817520,
"domNodes": -283,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 426.49199999999996,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2183.6339999999836,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1333.436,
"heapDeltaBytes": 5919620,
"heapUsedBytes": 66528144,
"domNodes": -286,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 444.509,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3177.8620000000046,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.99,
"layouts": 60,
"layoutDurationMs": 8.36,
"taskDurationMs": 1569.759,
"heapDeltaBytes": -3138068,
"heapUsedBytes": 58725432,
"domNodes": -286,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 538.524,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3196.2250000000267,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.711999999999996,
"layouts": 60,
"layoutDurationMs": 8.423,
"taskDurationMs": 1536.614,
"heapDeltaBytes": 24621328,
"heapUsedBytes": 86243284,
"domNodes": 10,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 544.625,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.2509999999643,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.4970000000001,
"heapDeltaBytes": 6339996,
"heapUsedBytes": 67561316,
"domNodes": -286,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 112.758,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.7119999999277,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.3399999999999,
"heapDeltaBytes": 8291844,
"heapUsedBytes": 69471168,
"domNodes": -283,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 96.16599999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.8230000000112,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.537,
"heapDeltaBytes": -11184604,
"heapUsedBytes": 57312016,
"domNodes": 20,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 124.85600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.7550000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.488000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.221,
"heapDeltaBytes": -11258272,
"heapUsedBytes": 57208568,
"domNodes": 18,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 133.187,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.6989999999787,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.481999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.924,
"heapDeltaBytes": 4871168,
"heapUsedBytes": 73077716,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 15.059000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.4649999999874,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.35099999999994,
"heapDeltaBytes": 4878216,
"heapUsedBytes": 73083008,
"domNodes": 22,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 15.28,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.669000000024,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.790000000000006,
"layouts": 16,
"layoutDurationMs": 4.903,
"taskDurationMs": 804.048,
"heapDeltaBytes": -4181160,
"heapUsedBytes": 64333112,
"domNodes": 62,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 95.548,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.4099999999262,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.724000000000004,
"layouts": 16,
"layoutDurationMs": 4.959,
"taskDurationMs": 844.7359999999999,
"heapDeltaBytes": -4118296,
"heapUsedBytes": 64143848,
"domNodes": 61,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 100.26100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2119999999868,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.56600000000001,
"layouts": 15,
"layoutDurationMs": 11.449999999999998,
"taskDurationMs": 950.712,
"heapDeltaBytes": 1437992,
"heapUsedBytes": 73089576,
"domNodes": 13673,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 34.681000000000004,
"eventListeners": 2375,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8287.707000000011,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4564.4490000000005,
"heapDeltaBytes": 12146680,
"heapUsedBytes": 71758056,
"domNodes": -283,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 1359.338,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8298.647000000074,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.416,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4601.224,
"heapDeltaBytes": 12541640,
"heapUsedBytes": 71832116,
"domNodes": -280,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 1376.862,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18406.229999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18379.434,
"heapDeltaBytes": -58288256,
"heapUsedBytes": 166025168,
"domNodes": -8312,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 576.1,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18161.01800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18146.749,
"heapDeltaBytes": -57939520,
"heapUsedBytes": 165995248,
"domNodes": -8312,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 507.02099999999996,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 23041.361999999994,
"styleRecalcs": 173,
"styleRecalcDurationMs": 26.26299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22987.382,
"heapDeltaBytes": -53014100,
"heapUsedBytes": 170354344,
"domNodes": -8312,
"jsHeapTotalBytes": -10231808,
"scriptDurationMs": 897.345,
"eventListeners": -16379,
"totalBlockingTimeMs": 758,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21867.674999999963,
"styleRecalcs": 150,
"styleRecalcDurationMs": 21.650999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21842.421,
"heapDeltaBytes": -48305312,
"heapUsedBytes": 177352788,
"domNodes": -8312,
"jsHeapTotalBytes": -10493952,
"scriptDurationMs": 888.746,
"eventListeners": -16385,
"totalBlockingTimeMs": 389,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 455.5010000000266,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.480999999999998,
"layouts": 3,
"layoutDurationMs": 0.719,
"taskDurationMs": 124.88999999999999,
"heapDeltaBytes": -15552872,
"heapUsedBytes": 51726280,
"domNodes": 132,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 10.067,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 473.2840000000351,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.624000000000002,
"layouts": 2,
"layoutDurationMs": 0.993,
"taskDurationMs": 123.351,
"heapDeltaBytes": -15553444,
"heapUsedBytes": 51661000,
"domNodes": 147,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 10.592,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.49 #14727 +/- ##
=============================================
Coverage ? 78.59%
=============================================
Files ? 1789
Lines ? 104435
Branches ? 32024
=============================================
Hits ? 82084
Misses ? 21920
Partials ? 431
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14707 to
cloud/1.49Automatically created by backport workflow.