Repository navigation
[backport core/1.49] hotfix: custom nodes adding widgets on subgraph nodes - #14726
Conversation
VHS directly adds sampling previews onto parent subgraphs (partially to merge lifecycle across multiple ksamplers in multi-stage workflows), but this conflicts with requiring that all widgets on a subgraphNode have associated promoted inputs. This PR adds a minimal reproduction test, and a proposed fix. Of note, this change necessitates custom nodes go through the appropriate api methods and still disallows blindly muting `node.widgets` Resolves Kosinkadink/ComfyUI-VideoHelperSuite#695
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1787 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T00:03:42.972Z",
"gitSha": "105dc96347e897528c655cbcdc31fd6920578ecd",
"branch": "backport-14707-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2049.2799999999534,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.662000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.753,
"heapDeltaBytes": 5135576,
"heapUsedBytes": 73280420,
"domNodes": 12,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 19.089999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2053.6240000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.562999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.862,
"heapDeltaBytes": 5169008,
"heapUsedBytes": 73298636,
"domNodes": 18,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 22.777,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.991999999996,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.965,
"layouts": 12,
"layoutDurationMs": 3.815,
"taskDurationMs": 900.8649999999999,
"heapDeltaBytes": -16345272,
"heapUsedBytes": 51731636,
"domNodes": -282,
"jsHeapTotalBytes": 20955136,
"scriptDurationMs": 123.80099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1936.3069999999425,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.1,
"layouts": 12,
"layoutDurationMs": 3.6950000000000003,
"taskDurationMs": 964.2089999999998,
"heapDeltaBytes": -16415580,
"heapUsedBytes": 51621224,
"domNodes": -285,
"jsHeapTotalBytes": 20955136,
"scriptDurationMs": 136.741,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.288999999961,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.201,
"layouts": 6,
"layoutDurationMs": 0.586,
"taskDurationMs": 389.13000000000005,
"heapDeltaBytes": 7902752,
"heapUsedBytes": 76013088,
"domNodes": 74,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 21.451,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0520000000388,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.059,
"layouts": 6,
"layoutDurationMs": 0.576,
"taskDurationMs": 399.19900000000007,
"heapDeltaBytes": 7901944,
"heapUsedBytes": 76003456,
"domNodes": 77,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 21.986,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.5970000000548,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.747999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.349,
"heapDeltaBytes": -12462288,
"heapUsedBytes": 55583304,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 61.06,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 610.3270000000975,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.908,
"heapDeltaBytes": -12422192,
"heapUsedBytes": 55563524,
"domNodes": 20,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 59.076,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.9499999999853,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.7730000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.619,
"heapDeltaBytes": 8567708,
"heapUsedBytes": 67705920,
"domNodes": -282,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 108.96000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2040.1069999999208,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.378,
"heapDeltaBytes": 8339228,
"heapUsedBytes": 67713828,
"domNodes": -285,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 124.28200000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2186.689000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.1689999999999,
"heapDeltaBytes": 4735316,
"heapUsedBytes": 65699292,
"domNodes": -284,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 434.035,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2334.7450000001118,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1418.954,
"heapDeltaBytes": 8670896,
"heapUsedBytes": 69510368,
"domNodes": -285,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 489.46000000000004,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.4629999999956,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.823,
"layouts": 60,
"layoutDurationMs": 7.6739999999999995,
"taskDurationMs": 1577.365,
"heapDeltaBytes": -177960,
"heapUsedBytes": 62040060,
"domNodes": -289,
"jsHeapTotalBytes": 8183808,
"scriptDurationMs": 561.282,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3313.678999999979,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.006999999999998,
"layouts": 60,
"layoutDurationMs": 7.559,
"taskDurationMs": 1566.3819999999998,
"heapDeltaBytes": 26122524,
"heapUsedBytes": 88260024,
"domNodes": 8,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 551.476,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.9419999999632,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.9979999999999,
"heapDeltaBytes": 6556540,
"heapUsedBytes": 67567956,
"domNodes": -283,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 114.77200000000002,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3539999999548,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.243,
"heapDeltaBytes": 6467156,
"heapUsedBytes": 67447972,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 117.257,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.6860000000011,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.32099999999997,
"heapDeltaBytes": -12014128,
"heapUsedBytes": 56250848,
"domNodes": 18,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 122.018,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.2129999999297,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.336000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.06100000000004,
"heapDeltaBytes": -10916228,
"heapUsedBytes": 57235328,
"domNodes": 18,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 122.29899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.562999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.315,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.94499999999994,
"heapDeltaBytes": 4532012,
"heapUsedBytes": 72718956,
"domNodes": 18,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 16.977,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.6749999999747,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.702,
"heapDeltaBytes": 4679524,
"heapUsedBytes": 73100288,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 20.937000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.7819999999715,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.742999999999995,
"layouts": 16,
"layoutDurationMs": 3.697,
"taskDurationMs": 820.4939999999999,
"heapDeltaBytes": -21927964,
"heapUsedBytes": 46208832,
"domNodes": 20,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 93.655,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.0189999999238,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.693000000000005,
"layouts": 16,
"layoutDurationMs": 4.569,
"taskDurationMs": 884.073,
"heapDeltaBytes": -21559276,
"heapUsedBytes": 46875044,
"domNodes": -282,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 101.169,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9530000000154,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.131000000000007,
"layouts": 15,
"layoutDurationMs": 12.958,
"taskDurationMs": 998.9839999999999,
"heapDeltaBytes": 30685552,
"heapUsedBytes": 100953752,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 40.581,
"eventListeners": 2375,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8514.699000000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4644.514,
"heapDeltaBytes": 6544256,
"heapUsedBytes": 65802448,
"domNodes": -283,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 1392.511,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8652.467999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4785.654,
"heapDeltaBytes": 12332996,
"heapUsedBytes": 71406312,
"domNodes": -283,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1459.9560000000001,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17229.47499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17207.302,
"heapDeltaBytes": -59998312,
"heapUsedBytes": 166039560,
"domNodes": -8312,
"jsHeapTotalBytes": -12263424,
"scriptDurationMs": 542.733,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17380.06599999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17333.397999999997,
"heapDeltaBytes": -55576788,
"heapUsedBytes": 171524200,
"domNodes": -8312,
"jsHeapTotalBytes": -6758400,
"scriptDurationMs": 582.112,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20777.637999999966,
"styleRecalcs": 142,
"styleRecalcDurationMs": 17.125999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20736.637000000002,
"heapDeltaBytes": -27644864,
"heapUsedBytes": 180254200,
"domNodes": -8312,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 908.288,
"eventListeners": -16383,
"totalBlockingTimeMs": 250,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20762.340999999993,
"styleRecalcs": 138,
"styleRecalcDurationMs": 16.670999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20710.629999999997,
"heapDeltaBytes": -44206240,
"heapUsedBytes": 178417124,
"domNodes": -8312,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 883.1150000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 209,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.3399999999838,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.934,
"layouts": 3,
"layoutDurationMs": 1.2190000000000003,
"taskDurationMs": 134.29,
"heapDeltaBytes": -15279340,
"heapUsedBytes": 51825748,
"domNodes": 157,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 11.651000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.73600000000624,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.102000000000004,
"layouts": 2,
"layoutDurationMs": 0.304,
"taskDurationMs": 118.59899999999999,
"heapDeltaBytes": -15831148,
"heapUsedBytes": 51754268,
"domNodes": 123,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 9.584,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.49 #14726 +/- ##
=============================================
- Coverage 78.60% 78.59% -0.01%
=============================================
Files 1789 1789
Lines 104423 104436 +13
Branches 32882 32883 +1
=============================================
+ Hits 82078 82085 +7
- Misses 21915 21920 +5
- Partials 430 431 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14707 to
core/1.49Automatically created by backport workflow.