Repository navigation
[backport cloud/1.49] fix(billing): don't show an error when a checkout is superseded - #14712
Conversation
## What and why Picking a different plan part-way through checkout makes the API replace the pending subscription operation with a new one. The replaced operation terminates as `failed` — it never completed — even though nothing actually went wrong. The store treated that like any other failure and showed **"We couldn't update your subscription. Please try again."** while the replacement checkout was still running and about to succeed. Users hit this by starting a subscription, changing their mind, and picking a different plan: an error toast, immediately followed by a working subscription. ## The change `handleFailure` now recognises the API's `checkout_superseded` failure reason and skips the error toast for it. The operation is still recorded as failed and still resolves normally — only the user-facing alarm goes away. The failure is also reported as `stale_operation` instead of `unknown`, so a routine plan switch stops inflating the count of unexplained billing failures. `stale_operation` is an existing category; no telemetry types changed. Takes effect once the API returns `checkout_superseded` for a replaced checkout. ## Scope One `if` and one telemetry value. Deliberately narrow: - Genuine subscription failures still toast exactly as before. - Top-up and cancel paths are untouched. - The success path already ignores stale operations (it checks the active checkout id before advancing), so it needed no change. ## Verification - `vitest run src/platform/workspace/stores/billingOperationStore.test.ts src/platform/workspace/composables/useSubscriptionCheckout.test.ts --coverage` — 144 passed, run **with** coverage to match CI. - New regression test: a superseded operation raises no error toast and reports `stale_operation`. - `pnpm typecheck`, `oxfmt --check`, `eslint` — all clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1784 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-04T21:22:34.333Z",
"gitSha": "fb12a0948de66b9272f6a13d2f202d3539589fbb",
"branch": "backport-14705-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.1030000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.9100000000001,
"heapDeltaBytes": 5232564,
"heapUsedBytes": 73333204,
"domNodes": 22,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 20.108,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.239999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.828000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.16499999999996,
"heapDeltaBytes": 5295024,
"heapUsedBytes": 73690304,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 18.932000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2031.3490000000058,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.931,
"layouts": 12,
"layoutDurationMs": 5.079999999999999,
"taskDurationMs": 1035.8239999999998,
"heapDeltaBytes": -17829204,
"heapUsedBytes": 50383232,
"domNodes": -276,
"jsHeapTotalBytes": 20955136,
"scriptDurationMs": 136.19599999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1904.4460000000072,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.44200000000001,
"layouts": 12,
"layoutDurationMs": 3.688,
"taskDurationMs": 896.7429999999999,
"heapDeltaBytes": -16366252,
"heapUsedBytes": 51774088,
"domNodes": -284,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 126.384,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.040999999988,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.860000000000003,
"layouts": 6,
"layoutDurationMs": 0.7409999999999999,
"taskDurationMs": 425.56,
"heapDeltaBytes": 7897764,
"heapUsedBytes": 76018588,
"domNodes": 78,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 24.389,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.6149999999861,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.439000000000004,
"layouts": 6,
"layoutDurationMs": 0.5599999999999999,
"taskDurationMs": 378.51,
"heapDeltaBytes": 7855932,
"heapUsedBytes": 76070352,
"domNodes": 76,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 19.446,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6950000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.702,
"heapDeltaBytes": -12077980,
"heapUsedBytes": 56186128,
"domNodes": 18,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 59.645,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 579.0480000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.5809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.053,
"heapDeltaBytes": -12446780,
"heapUsedBytes": 56005928,
"domNodes": 18,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 58.678999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.1980000000267,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.1830000000001,
"heapDeltaBytes": 5150912,
"heapUsedBytes": 64236004,
"domNodes": -283,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 113.5,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.3399999999574,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.526,
"heapDeltaBytes": 8336996,
"heapUsedBytes": 67649572,
"domNodes": -283,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 113.10300000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2268.6989999999696,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.508999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.3880000000001,
"heapDeltaBytes": 5991580,
"heapUsedBytes": 66027504,
"domNodes": -286,
"jsHeapTotalBytes": 4476928,
"scriptDurationMs": 444.32099999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.2779999999766,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.621999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1288.7389999999998,
"heapDeltaBytes": 4177944,
"heapUsedBytes": 64578812,
"domNodes": -287,
"jsHeapTotalBytes": 4476928,
"scriptDurationMs": 432.747,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3299.962999999991,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.53,
"layouts": 60,
"layoutDurationMs": 7.644,
"taskDurationMs": 1575.51,
"heapDeltaBytes": 3442996,
"heapUsedBytes": 65264060,
"domNodes": -288,
"jsHeapTotalBytes": 7397376,
"scriptDurationMs": 563.77,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3181.8049999999403,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.532999999999998,
"layouts": 60,
"layoutDurationMs": 7.0649999999999995,
"taskDurationMs": 1531.825,
"heapDeltaBytes": -2030816,
"heapUsedBytes": 59546356,
"domNodes": -287,
"jsHeapTotalBytes": 7921664,
"scriptDurationMs": 532.008,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.7129999999584,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 744.0360000000002,
"heapDeltaBytes": 8345136,
"heapUsedBytes": 69467196,
"domNodes": -284,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 121.779,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.1530000000084,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.774,
"heapDeltaBytes": 8332488,
"heapUsedBytes": 69653368,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 111.76300000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.1769999999747,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.939000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.24799999999993,
"heapDeltaBytes": -11104580,
"heapUsedBytes": 57195684,
"domNodes": 18,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 117.28899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.3509999999187,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.59799999999996,
"heapDeltaBytes": -10747572,
"heapUsedBytes": 57510692,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 119.24200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.1460000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.554,
"heapDeltaBytes": -22054592,
"heapUsedBytes": 46166192,
"domNodes": 19,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 15.550999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.0799999999454,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.736,
"heapDeltaBytes": 4455144,
"heapUsedBytes": 72899840,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 16.297,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.6820000000107,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.486,
"layouts": 16,
"layoutDurationMs": 4.294,
"taskDurationMs": 831.186,
"heapDeltaBytes": -21718904,
"heapUsedBytes": 46450428,
"domNodes": -280,
"jsHeapTotalBytes": 20955136,
"scriptDurationMs": 95.65899999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.1279999999351,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.321,
"layouts": 16,
"layoutDurationMs": 4.41,
"taskDurationMs": 765.664,
"heapDeltaBytes": -4342284,
"heapUsedBytes": 63917536,
"domNodes": 62,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 91.483,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.259000000011,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.191999999999997,
"layouts": 14,
"layoutDurationMs": 12.725,
"taskDurationMs": 954.9740000000002,
"heapDeltaBytes": 30991120,
"heapUsedBytes": 101154412,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 35.15900000000001,
"eventListeners": 2375,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8360.140000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4695.835000000001,
"heapDeltaBytes": 12492260,
"heapUsedBytes": 71830844,
"domNodes": -285,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1442.566,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8286.996000000045,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.51800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4534.344,
"heapDeltaBytes": 16391192,
"heapUsedBytes": 75292688,
"domNodes": -283,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 1426.291,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17599.598000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17564.959,
"heapDeltaBytes": -44791828,
"heapUsedBytes": 168402764,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 575.041,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17073.56799999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17037.607,
"heapDeltaBytes": -44627604,
"heapUsedBytes": 167356492,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 584.08,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20879.273000000012,
"styleRecalcs": 144,
"styleRecalcDurationMs": 17.07000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20835.878999999997,
"heapDeltaBytes": -28843212,
"heapUsedBytes": 179992628,
"domNodes": -8312,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 894.398,
"eventListeners": -16383,
"totalBlockingTimeMs": 273,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20454.233000000044,
"styleRecalcs": 140,
"styleRecalcDurationMs": 16.427999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20399.764,
"heapDeltaBytes": -31141092,
"heapUsedBytes": 179079064,
"domNodes": -8312,
"jsHeapTotalBytes": -10461184,
"scriptDurationMs": 905.9010000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 186,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 152.46300000001156,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.107999999999997,
"layouts": 7,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 93.64900000000002,
"heapDeltaBytes": 3105400,
"heapUsedBytes": 70367340,
"domNodes": 135,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.177000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.2390000000105,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.473000000000003,
"layouts": 2,
"layoutDurationMs": 0.40899999999999986,
"taskDurationMs": 106.72500000000001,
"heapDeltaBytes": -15773160,
"heapUsedBytes": 51405396,
"domNodes": 121,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 8.822,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #14712 +/- ##
=============================================
Coverage ? 78.60%
=============================================
Files ? 1789
Lines ? 104423
Branches ? 32024
=============================================
Hits ? 82078
Misses ? 21915
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14705 to
cloud/1.49Automatically created by backport workflow.