Repository navigation
[backport core/1.49] fix(billing): don't show an error when a checkout is superseded - #14711
Conversation
## What and why Picking a different plan part-way through checkout makes the API replace the pending subscription operation with a new one. The replaced operation terminates as `failed` — it never completed — even though nothing actually went wrong. The store treated that like any other failure and showed **"We couldn't update your subscription. Please try again."** while the replacement checkout was still running and about to succeed. Users hit this by starting a subscription, changing their mind, and picking a different plan: an error toast, immediately followed by a working subscription. ## The change `handleFailure` now recognises the API's `checkout_superseded` failure reason and skips the error toast for it. The operation is still recorded as failed and still resolves normally — only the user-facing alarm goes away. The failure is also reported as `stale_operation` instead of `unknown`, so a routine plan switch stops inflating the count of unexplained billing failures. `stale_operation` is an existing category; no telemetry types changed. Takes effect once the API returns `checkout_superseded` for a replaced checkout. ## Scope One `if` and one telemetry value. Deliberately narrow: - Genuine subscription failures still toast exactly as before. - Top-up and cancel paths are untouched. - The success path already ignores stale operations (it checks the active checkout id before advancing), so it needed no change. ## Verification - `vitest run src/platform/workspace/stores/billingOperationStore.test.ts src/platform/workspace/composables/useSubscriptionCheckout.test.ts --coverage` — 144 passed, run **with** coverage to match CI. - New regression test: a superseded operation raises no error toast and reports `stale_operation`. - `pnpm typecheck`, `oxfmt --check`, `eslint` — all clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1778 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T21:22:25.181Z",
"gitSha": "98840f5f01dc0d0addad3a6386307cfdf33e8d68",
"branch": "backport-14705-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.4930000000077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.874000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.874,
"heapDeltaBytes": 5173848,
"heapUsedBytes": 73296256,
"domNodes": 20,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 15.858000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.10900000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.473000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.36499999999995,
"heapDeltaBytes": 5355056,
"heapUsedBytes": 73587004,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 15.401000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2159.7909999999843,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.809000000000005,
"layouts": 12,
"layoutDurationMs": 4.052999999999999,
"taskDurationMs": 1045.5510000000002,
"heapDeltaBytes": -17185832,
"heapUsedBytes": 51165764,
"domNodes": -284,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 121.83,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.2599999999966,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.486000000000004,
"layouts": 12,
"layoutDurationMs": 3.646,
"taskDurationMs": 849.831,
"heapDeltaBytes": -244080,
"heapUsedBytes": 67752792,
"domNodes": 59,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 118.28000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.2969999999887,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.465999999999998,
"layouts": 6,
"layoutDurationMs": 0.72,
"taskDurationMs": 376.38,
"heapDeltaBytes": 7992376,
"heapUsedBytes": 75982452,
"domNodes": 79,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 18.475,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.7240000000947,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.480999999999998,
"layouts": 6,
"layoutDurationMs": 0.673,
"taskDurationMs": 370.762,
"heapDeltaBytes": 7837840,
"heapUsedBytes": 76027904,
"domNodes": 79,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 18.641000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 576.6559999999856,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.679000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.539,
"heapDeltaBytes": -11977540,
"heapUsedBytes": 56044380,
"domNodes": 18,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 53.798,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 588.3430000000089,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.359000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.70599999999996,
"heapDeltaBytes": -12325060,
"heapUsedBytes": 55899904,
"domNodes": 16,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 56.74099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.3990000000263,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.891000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.772,
"heapDeltaBytes": 8200116,
"heapUsedBytes": 67711468,
"domNodes": -284,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 91.312,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2014.344000000051,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.205000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.479,
"heapDeltaBytes": 8245296,
"heapUsedBytes": 67244876,
"domNodes": -284,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 90.98999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.8139999999967,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.291999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1220.114,
"heapDeltaBytes": -4919856,
"heapUsedBytes": 55372436,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 392.792,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.5280000000794,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.347999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1223.425,
"heapDeltaBytes": 5540972,
"heapUsedBytes": 65706388,
"domNodes": -283,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 396.578,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3259.215999999981,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.575000000000003,
"layouts": 60,
"layoutDurationMs": 8.086999999999998,
"taskDurationMs": 1533.486,
"heapDeltaBytes": -203456,
"heapUsedBytes": 61729984,
"domNodes": -288,
"jsHeapTotalBytes": 9232384,
"scriptDurationMs": 554.4409999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3144.7829999999612,
"styleRecalcs": 65,
"styleRecalcDurationMs": 22.062,
"layouts": 60,
"layoutDurationMs": 8.111,
"taskDurationMs": 1435.347,
"heapDeltaBytes": 23769920,
"heapUsedBytes": 85739884,
"domNodes": 12,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 512.3409999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2058.064999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.066999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.036,
"heapDeltaBytes": 8646388,
"heapUsedBytes": 69507880,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 95.45700000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.23699999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.336000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.857,
"heapDeltaBytes": 8212800,
"heapUsedBytes": 69489436,
"domNodes": -283,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 91.251,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.6789999999942,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.974,
"heapDeltaBytes": -10903528,
"heapUsedBytes": 57392228,
"domNodes": 20,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 120.12199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.0000000000309,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.951000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.12500000000006,
"heapDeltaBytes": -12150680,
"heapUsedBytes": 56369752,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 118.27300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.4850000000215,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.53600000000006,
"heapDeltaBytes": 4847492,
"heapUsedBytes": 73073544,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 12.924,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.7729999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2860000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.153,
"heapDeltaBytes": 4849932,
"heapUsedBytes": 73175804,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 13.289,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.3130000000142,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.515,
"layouts": 16,
"layoutDurationMs": 4.09,
"taskDurationMs": 770.3030000000001,
"heapDeltaBytes": -21255524,
"heapUsedBytes": 46853856,
"domNodes": -279,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 82.86699999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.5219999999945,
"styleRecalcs": 80,
"styleRecalcDurationMs": 36.905,
"layouts": 16,
"layoutDurationMs": 4.26,
"taskDurationMs": 786.599,
"heapDeltaBytes": -22030588,
"heapUsedBytes": 46218952,
"domNodes": 19,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 85.089,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1415.2669999999716,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.839000000000006,
"layouts": 16,
"layoutDurationMs": 11.5,
"taskDurationMs": 916.3070000000002,
"heapDeltaBytes": 31100400,
"heapUsedBytes": 98831016,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 41.68899999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8186.185000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.251,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4382.843,
"heapDeltaBytes": 10322420,
"heapUsedBytes": 69718824,
"domNodes": -285,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 1370.5779999999997,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8216.01899999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.336999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4250.389,
"heapDeltaBytes": 12322176,
"heapUsedBytes": 71524044,
"domNodes": -282,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 1291.388,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17754.687999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17731.196,
"heapDeltaBytes": -66991008,
"heapUsedBytes": 157561812,
"domNodes": -8312,
"jsHeapTotalBytes": -5967872,
"scriptDurationMs": 584.976,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17771.30700000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17747.76,
"heapDeltaBytes": -58122116,
"heapUsedBytes": 166619812,
"domNodes": -8312,
"jsHeapTotalBytes": -8327168,
"scriptDurationMs": 588.5640000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21783.972000000005,
"styleRecalcs": 155,
"styleRecalcDurationMs": 20.97099999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21745.388,
"heapDeltaBytes": -48204448,
"heapUsedBytes": 177057252,
"domNodes": -8316,
"jsHeapTotalBytes": -10756096,
"scriptDurationMs": 909.5050000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 402,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22160.529999999995,
"styleRecalcs": 163,
"styleRecalcDurationMs": 21.575999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22129.165,
"heapDeltaBytes": -42350860,
"heapUsedBytes": 180932696,
"domNodes": -8312,
"jsHeapTotalBytes": -7614464,
"scriptDurationMs": 944.679,
"eventListeners": -16383,
"totalBlockingTimeMs": 492,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 456.86699999998837,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.694000000000003,
"layouts": 3,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 119.87199999999999,
"heapDeltaBytes": -15562304,
"heapUsedBytes": 51685668,
"domNodes": 134,
"jsHeapTotalBytes": 7983104,
"scriptDurationMs": 9.918,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 456.02099999996426,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.211,
"layouts": 2,
"layoutDurationMs": 0.35800000000000004,
"taskDurationMs": 122.52,
"heapDeltaBytes": -15795920,
"heapUsedBytes": 51583732,
"domNodes": 125,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 10.440000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #14711 +/- ##
==========================================
Coverage 78.59% 78.60%
==========================================
Files 1789 1789
Lines 104420 104423 +3
Branches 32023 32024 +1
==========================================
+ Hits 82074 82078 +4
+ Misses 21916 21915 -1
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14705 to
core/1.49Automatically created by backport workflow.