Repository navigation
[backport core/1.48] fix(billing): don't show an error when a checkout is superseded - #14709
Conversation
## What and why Picking a different plan part-way through checkout makes the API replace the pending subscription operation with a new one. The replaced operation terminates as `failed` — it never completed — even though nothing actually went wrong. The store treated that like any other failure and showed **"We couldn't update your subscription. Please try again."** while the replacement checkout was still running and about to succeed. Users hit this by starting a subscription, changing their mind, and picking a different plan: an error toast, immediately followed by a working subscription. ## The change `handleFailure` now recognises the API's `checkout_superseded` failure reason and skips the error toast for it. The operation is still recorded as failed and still resolves normally — only the user-facing alarm goes away. The failure is also reported as `stale_operation` instead of `unknown`, so a routine plan switch stops inflating the count of unexplained billing failures. `stale_operation` is an existing category; no telemetry types changed. Takes effect once the API returns `checkout_superseded` for a replaced checkout. ## Scope One `if` and one telemetry value. Deliberately narrow: - Genuine subscription failures still toast exactly as before. - Top-up and cancel paths are untouched. - The success path already ignores stale operations (it checks the active checkout id before advancing), so it needed no change. ## Verification - `vitest run src/platform/workspace/stores/billingOperationStore.test.ts src/platform/workspace/composables/useSubscriptionCheckout.test.ts --coverage` — 144 passed, run **with** coverage to match CI. - New regression test: a superseded operation raises no error toast and reports `stale_operation`. - `pnpm typecheck`, `oxfmt --check`, `eslint` — all clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1761 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T21:21:57.955Z",
"gitSha": "07b96a587167edbb52ab7921ba7aadf0d7be4f81",
"branch": "backport-14705-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2076.420000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.563999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.69699999999995,
"heapDeltaBytes": 3710416,
"heapUsedBytes": 71615340,
"domNodes": 20,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 16.226999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.8539999999862,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.758000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.461,
"heapDeltaBytes": 3840388,
"heapUsedBytes": 71873888,
"domNodes": 22,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 15.174999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.4220000000018,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.208999999999996,
"layouts": 12,
"layoutDurationMs": 3.426,
"taskDurationMs": 846.611,
"heapDeltaBytes": -16896920,
"heapUsedBytes": 50924448,
"domNodes": -272,
"jsHeapTotalBytes": 21491712,
"scriptDurationMs": 109.03999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.890000000018,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.894000000000005,
"layouts": 12,
"layoutDurationMs": 3.301,
"taskDurationMs": 842.3280000000001,
"heapDeltaBytes": -15715848,
"heapUsedBytes": 52284216,
"domNodes": -274,
"jsHeapTotalBytes": 22016000,
"scriptDurationMs": 111.89099999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.3030000000235,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.890000000000002,
"layouts": 6,
"layoutDurationMs": 0.673,
"taskDurationMs": 365.781,
"heapDeltaBytes": 7232760,
"heapUsedBytes": 75189360,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 17.559,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2179999999844,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.408000000000001,
"layouts": 6,
"layoutDurationMs": 0.6439999999999998,
"taskDurationMs": 363.737,
"heapDeltaBytes": 7344540,
"heapUsedBytes": 75179844,
"domNodes": 78,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 17.652,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 584.8650000000077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.037,
"heapDeltaBytes": -12206548,
"heapUsedBytes": 55902200,
"domNodes": 16,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 53.363,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 558.4699999999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.720999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.03,
"heapDeltaBytes": -12183652,
"heapUsedBytes": 55849212,
"domNodes": 18,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 52.38499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.8009999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.727,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.207,
"heapDeltaBytes": 7812988,
"heapUsedBytes": 66711216,
"domNodes": -275,
"jsHeapTotalBytes": 5832704,
"scriptDurationMs": 89.604,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2015.694999999937,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.968000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.243,
"heapDeltaBytes": 6208628,
"heapUsedBytes": 65175424,
"domNodes": -276,
"jsHeapTotalBytes": 4259840,
"scriptDurationMs": 90.174,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2152.2239999999897,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.327000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1199.214,
"heapDeltaBytes": 1721476,
"heapUsedBytes": 61540696,
"domNodes": -276,
"jsHeapTotalBytes": 5251072,
"scriptDurationMs": 398.227,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2131.9089999999505,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.663000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1190.998,
"heapDeltaBytes": 2144504,
"heapUsedBytes": 62407952,
"domNodes": -278,
"jsHeapTotalBytes": 4726784,
"scriptDurationMs": 392.352,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3131.541000000027,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.012999999999998,
"layouts": 60,
"layoutDurationMs": 7.545,
"taskDurationMs": 1440.938,
"heapDeltaBytes": -5566668,
"heapUsedBytes": 55845072,
"domNodes": -279,
"jsHeapTotalBytes": 7667712,
"scriptDurationMs": 498.76400000000007,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.7739999999285,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.856000000000002,
"layouts": 60,
"layoutDurationMs": 7.736000000000001,
"taskDurationMs": 1443.2289999999998,
"heapDeltaBytes": -1842192,
"heapUsedBytes": 59662060,
"domNodes": -281,
"jsHeapTotalBytes": 7667712,
"scriptDurationMs": 513.6540000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.6370000000038,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.606999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.522,
"heapDeltaBytes": 7647372,
"heapUsedBytes": 68524136,
"domNodes": -276,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 90.176,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2052.3500000000467,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.289999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.817,
"heapDeltaBytes": 7204084,
"heapUsedBytes": 68125384,
"domNodes": -279,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 90.76899999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.4109999999941,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.916,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.949,
"heapDeltaBytes": -12040920,
"heapUsedBytes": 55927840,
"domNodes": 20,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 122.60000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.2039999999761,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.138,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.25500000000005,
"heapDeltaBytes": -11862808,
"heapUsedBytes": 56174336,
"domNodes": 18,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 124.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.9130000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.6549999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.4639999999999,
"heapDeltaBytes": 3641284,
"heapUsedBytes": 71774664,
"domNodes": 20,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 13.419999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.7950000000164,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.417999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.25800000000004,
"heapDeltaBytes": -20349176,
"heapUsedBytes": 47747036,
"domNodes": -272,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 13.032,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.8689999999938,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.519999999999996,
"layouts": 16,
"layoutDurationMs": 4.246,
"taskDurationMs": 769.219,
"heapDeltaBytes": -20672312,
"heapUsedBytes": 47335820,
"domNodes": -274,
"jsHeapTotalBytes": 20705280,
"scriptDurationMs": 83.54100000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.3880000000422,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.485,
"layouts": 16,
"layoutDurationMs": 3.8710000000000004,
"taskDurationMs": 747.252,
"heapDeltaBytes": -21339476,
"heapUsedBytes": 46788248,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 79.62,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1380.2390000000173,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.121999999999993,
"layouts": 15,
"layoutDurationMs": 10.938999999999997,
"taskDurationMs": 893.4659999999999,
"heapDeltaBytes": 31175040,
"heapUsedBytes": 99562464,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 34.84299999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 114,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8215.114000000029,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.609,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4136.737,
"heapDeltaBytes": 9704532,
"heapUsedBytes": 68880804,
"domNodes": -277,
"jsHeapTotalBytes": 5513216,
"scriptDurationMs": 1264.302,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.564000000039,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4363.854000000001,
"heapDeltaBytes": 13578924,
"heapUsedBytes": 73042512,
"domNodes": -276,
"jsHeapTotalBytes": 9707520,
"scriptDurationMs": 1435.306,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17030.73999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17015.671000000002,
"heapDeltaBytes": -41238044,
"heapUsedBytes": 167300660,
"domNodes": -8312,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 520.232,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17228.620999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17197.248000000003,
"heapDeltaBytes": -59691404,
"heapUsedBytes": 166423720,
"domNodes": -8312,
"jsHeapTotalBytes": -10420224,
"scriptDurationMs": 534.7429999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20457.27499999998,
"styleRecalcs": 139,
"styleRecalcDurationMs": 17.543999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20434.008,
"heapDeltaBytes": -31650688,
"heapUsedBytes": 176677700,
"domNodes": -8312,
"jsHeapTotalBytes": -14704640,
"scriptDurationMs": 861.811,
"eventListeners": -16385,
"totalBlockingTimeMs": 280,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20772.863999999914,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.35800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20741.398,
"heapDeltaBytes": -55325148,
"heapUsedBytes": 153801064,
"domNodes": -8312,
"jsHeapTotalBytes": -15142912,
"scriptDurationMs": 878.047,
"eventListeners": -16385,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 479.9290000000269,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.589,
"layouts": 4,
"layoutDurationMs": 1.36,
"taskDurationMs": 133.24999999999997,
"heapDeltaBytes": -15960036,
"heapUsedBytes": 51002624,
"domNodes": 132,
"jsHeapTotalBytes": 7995392,
"scriptDurationMs": 9.985000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 467.3339999999371,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.487,
"layouts": 3,
"layoutDurationMs": 0.685,
"taskDurationMs": 105.865,
"heapDeltaBytes": -16112344,
"heapUsedBytes": 50985196,
"domNodes": 117,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 8.572000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.48 #14709 +/- ##
===========================================
Coverage 79.39% 79.39%
===========================================
Files 1749 1749
Lines 99601 99604 +3
Branches 31919 32670 +751
===========================================
+ Hits 79076 79081 +5
+ Misses 20125 20123 -2
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #14705 to
core/1.48Automatically created by backport workflow.