Skip to content

ci: stop snapshot regeneration laundering bad baselines and dead shards - #14686

Merged
christian-byrne merged 2 commits into
ci/fix-update-playwright-expectations-triggersfrom
ci/snapshot-regeneration-guards
Aug 9, 2026
Merged

christian-byrne merged 2 commits into
ci/fix-update-playwright-expectations-triggersfrom
ci/snapshot-regeneration-guards

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Follow-up to #14684, stacked on it (base is ci/fix-update-playwright-expectations-triggers, so the diff here shows only these two fixes). It auto-retargets to main when #14684 merges. Merge #14684 first.

Two more fail-open paths in the same workflow. Same defect class as #14684's bug 1: the run reports success having not done the thing it claims. Neither is a trigger problem, which is why they are here and not there.

A. Regeneration rewrites baselines that never drifted

Screenshot capture is not bit-deterministic. 12 runs of one mobile pan test against the same container and the same dist produced 2 distinct images, minority roughly 1-in-6, differing by 795 pixels — and those pixels are purely text glyph rasterization, with layout byte-identical.

Normal e2e absorbs this because the project sets retries: 3 and re-captures until a comparison passes. Regeneration does not get that protection: --update-snapshots writes on mismatch, so the committed bytes are one unvalidated capture rather than a stable one.

The consequence that matters is not the noise. It is that this path has no notion of whether a baseline drifted at all. It rewrites whatever differs and commits it. So it will just as readily overwrite a baseline that is failing because of a genuine visual regression, laundering the regression into an accepted baseline. The only guard was a human eyeballing binary files — exactly the review that binary diffs defeat.

Fix chosen: report per-file diff magnitude. Each rewritten snapshot is measured against HEAD with ImageMagick compare -metric AE, and the table is published to the step summary and into the commit body, so the numbers travel with the binary diff. Rewrites under 2000 pixels raise a ::warning:: — that is the rasterization-noise signature, not an intended visual change.

This would have caught the reported instance outright: 33 of 34 rewritten files corresponded to failing tests; the lone outlier that did not was the bad one, and it is the one that shows up as a small-magnitude rewrite.

Rejected for now: capture-twice-and-write-on-agreement. It is the more thorough fix and it removes the noise rather than reporting it. I did not take it here because it roughly doubles a regeneration that already runs ~40 minutes across 5 legs, and because it is a behavioural change to what gets committed that I cannot exercise before merging. Reporting is additive, cannot change what is committed, and turns an unreviewable binary diff into a sortable number today. Capture-twice is the right next step if the noise persists.

Note this fix is deliberately advisory: it does not block the commit. Making a small-magnitude rewrite fail would reject legitimate 1-pixel intentional changes, and I would rather not add a false-failure mode to a workflow I cannot test end-to-end.

B. A dead shard reports success

continue-on-error: true on the update-snapshots run is required — under --update-snapshots a rewritten baseline surfaces as a test failure, so without it every successful regeneration would fail. But it also swallowed genuine breakage. If a shard died (ComfyUI server never came up, wrong container, Playwright crashed), zero snapshots changed, merge-and-commit logged "No changes to commit", and the whole run went green having done nothing.

Now the JSON report is retained and checked per shard:

situation verdict
no JSON report written error — the process never completed a run
JSON unreadable / no stats error
tests ran, failures > 0, zero rewritten files error — broken run, not absence of drift
tests ran, failures > 0, files rewritten pass — the normal regeneration path
tests ran, all passed, nothing rewritten pass — genuinely no drift
zero tests matched this leg's filters pass, with a notice

That last row is why the exit code alone cannot be used, and I only found this by running it: --grep with no matches exits 1 and records a top-level Playwright error, identical on both counts to a real failure. The cloud leg can legitimately match nothing. The discriminator that actually works is the combination of "did the report get written" and "did failures coincide with zero rewrites".

Parsed with node, not jq: this step runs inside the CI container, where node is guaranteed (it just ran pnpm and Playwright) but jq is not.

Verification

The workflow itself cannot be exercised without merging, for the reason established in #14684. What I could execute, I did — against real Playwright output and real images, not mocks:

  • Playwright JSON shape confirmed empirically by running Playwright locally: .stats.{expected,unexpected,flaky,skipped} plus .errors. The no-match exit code and the dead-run "no JSON file at all" behaviour were both observed, not assumed — and the first of those invalidated my original design.
  • Shard gate executed against all 6 rows of the table above, using genuine Playwright report files. Each produced the intended verdict, including the two that must not fail.
  • Diff-magnitude step executed on real PNGs in a real git repo: a 100-pixel change reported exactly 100 and raised the warning; a 3600-pixel change reported exactly 3600 and did not; an untracked file reported new; an unchanged file was correctly absent.
  • Commit-body assembly tested for injection: a report containing `a$(touch /tmp/PWNED)b.png` and backtick-wrapped names produced the literal text with no evaluation. This is why it is built with cat and not a heredoc.
  • yamllint (the repo's CI: YAML Validation gate) passes; actionlint v1.7.11 reports no expression or context errors and the same 6 pre-existing SC2086:info findings as main — zero new. bash -n passes on every inline script. Both commits were checked individually, so the intermediate commit is not broken.

Unverifiable until merge: that ImageMagick compare is present on the runner (documented in the ubuntu runner image; the step degrades to byte sizes and warns if absent, and never fails); that node is present in the CI container (it necessarily is, since the preceding steps run pnpm and Playwright); that --reporter=json,html alongside PLAYWRIGHT_JSON_OUTPUT_NAME behaves in the container as it does locally; and the real end-to-end regeneration.

Threshold caveat: 2000 pixels is a heuristic chosen against a single reported 795-pixel instance, not a measured distribution. It only gates an advisory warning, never the commit, so being wrong about it costs noise and not correctness — but it should be revisited once there is more data.

continue-on-error is required on the update-snapshots run because a
rewritten baseline surfaces as a test failure, but it also swallowed
genuine breakage: if a shard died (server never came up, wrong container,
Playwright crashed) no snapshots changed, merge-and-commit logged
'No changes to commit', and the run went green having done nothing.

Keep the JSON report and check it. No report at all means the process
never completed. Failures with zero rewritten files is a broken run, not
an absence of drift. Zero matched tests stays legitimate - Playwright
exits non-zero and records a top-level error for it, so neither the exit
code nor the error list can be trusted alone.

Parsed with node rather than jq: this step runs inside the CI container,
where node is guaranteed but jq is not.
Regeneration has no notion of whether a baseline actually drifted: it
rewrites whatever it captured. Screenshot capture is not bit-deterministic
- repeated runs against the same container and dist produce images that
differ in text glyph rasterization with layout byte-identical. Normal e2e
absorbs this via retries; regeneration captures once under
--update-snapshots and commits the result.

So a baseline that never changed can be rewritten, and a baseline failing
from a genuine visual regression can be laundered into an accepted one.
The only guard was a human eyeballing binary files, which is the review
binary diffs defeat.

Measure each rewritten snapshot against HEAD with ImageMagick and publish
the table to the step summary and the commit body, so there is a number to
review instead of a PNG. Warn on rewrites under 2000 pixels, which is the
rasterization-noise signature rather than an intended change. Degrades to
byte sizes if compare is unavailable and never fails the job.

The commit body is assembled with cat, never a heredoc: the table contains
backticks and file names that must not be evaluated.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 766d1e28-6268-41d0-bc86-09ecbf379eac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1788 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1767 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 140ms TBT · 94.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.5 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 310ms TBT · 147.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 524ms
canvas-idle: script duration 21ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.5 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 904ms
canvas-mouse-sweep: script duration 128ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.3 MB
canvas-mouse-sweep: DOM nodes -112
canvas-mouse-sweep: event listeners -74
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 409ms
canvas-zoom-sweep: script duration 23ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 10ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 397ms
dom-widget-clipping: script duration 65ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 50.5 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 740ms
large-graph-idle: script duration 119ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.7 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1406ms
large-graph-pan: script duration 474ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 56.2 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1602ms
large-graph-zoom: script duration 566ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.6 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 747ms
minimap-idle: script duration 124ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.6 MB
minimap-idle: DOM nodes -286
minimap-idle: event listeners -150
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 121ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 51.2 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 497ms
subgraph-idle: script duration 18ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.1 MB
subgraph-idle: DOM nodes 21
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 881ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 44.7 MB
subgraph-mouse-sweep: DOM nodes -131
subgraph-mouse-sweep: event listeners -153
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 1041ms
subgraph-transition-enter: script duration 40ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 94.6 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4858ms
viewport-pan-sweep: script duration 1477ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.4 MB
viewport-pan-sweep: DOM nodes -284
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17621ms
vue-large-graph-idle: script duration 570ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 159.5 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16386
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 21285ms
vue-large-graph-pan: script duration 912ms
vue-large-graph-pan: TBT 310ms
vue-large-graph-pan: heap used 147.9 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16381
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 114ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.2 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-04T09:58:20.941Z",
  "gitSha": "47427bc946e004268b12eb2cdfe4698eb7d9bc5f",
  "branch": "ci/snapshot-regeneration-guards",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2031.3400000000001,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.558999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.342,
      "heapDeltaBytes": 5607092,
      "heapUsedBytes": 69787668,
      "domNodes": 16,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 18.628,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.9709999999704,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.425,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.2750000000001,
      "heapDeltaBytes": 5634840,
      "heapUsedBytes": 69772264,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 23.733,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1872.556999999972,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.49999999999999,
      "layouts": 12,
      "layoutDurationMs": 3.731,
      "taskDurationMs": 867.7479999999999,
      "heapDeltaBytes": -109580,
      "heapUsedBytes": 63742072,
      "domNodes": 58,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 124.334,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1830.5139999999938,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 38.031,
      "layouts": 12,
      "layoutDurationMs": 3.5899999999999994,
      "taskDurationMs": 940.086,
      "heapDeltaBytes": -13873160,
      "heapUsedBytes": 50045580,
      "domNodes": -281,
      "jsHeapTotalBytes": 24367104,
      "scriptDurationMs": 132.078,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1743.325000000027,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.258,
      "layouts": 6,
      "layoutDurationMs": 0.576,
      "taskDurationMs": 407.78400000000005,
      "heapDeltaBytes": 8587276,
      "heapUsedBytes": 72632896,
      "domNodes": 76,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 23.344000000000005,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.4359999999651,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.891,
      "layouts": 6,
      "layoutDurationMs": 0.6680000000000001,
      "taskDurationMs": 410.28,
      "heapDeltaBytes": 8658184,
      "heapUsedBytes": 72780352,
      "domNodes": 78,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 23.079999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 578.044000000034,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.181000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.48199999999997,
      "heapDeltaBytes": -11077528,
      "heapUsedBytes": 52930616,
      "domNodes": 18,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 61.10900000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 620.0389999999061,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 11.883,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.06600000000003,
      "heapDeltaBytes": -10953896,
      "heapUsedBytes": 52982824,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 68.801,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2012.8690000000233,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.461999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 698.1170000000001,
      "heapDeltaBytes": 6347708,
      "heapUsedBytes": 65719124,
      "domNodes": -283,
      "jsHeapTotalBytes": 2736128,
      "scriptDurationMs": 112.53399999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.0020000000195,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.452,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 781.3050000000001,
      "heapDeltaBytes": 6573696,
      "heapUsedBytes": 65856932,
      "domNodes": -282,
      "jsHeapTotalBytes": 3260416,
      "scriptDurationMs": 125.70399999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2254.8979999999688,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.496999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1371.6200000000001,
      "heapDeltaBytes": 2010192,
      "heapUsedBytes": 62473712,
      "domNodes": -286,
      "jsHeapTotalBytes": 4239360,
      "scriptDurationMs": 457.464,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2401.971000000003,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.796999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1441.1450000000002,
      "heapDeltaBytes": -5136668,
      "heapUsedBytes": 55458988,
      "domNodes": -285,
      "jsHeapTotalBytes": 4571136,
      "scriptDurationMs": 491.351,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3313.5049999999637,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.654000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.816999999999999,
      "taskDurationMs": 1575.0040000000001,
      "heapDeltaBytes": 24321048,
      "heapUsedBytes": 86379100,
      "domNodes": 12,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 561.327,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3362.2349999999415,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.705,
      "layouts": 60,
      "layoutDurationMs": 8.021,
      "taskDurationMs": 1629.74,
      "heapDeltaBytes": 5149036,
      "heapUsedBytes": 68034608,
      "domNodes": -287,
      "jsHeapTotalBytes": 6144000,
      "scriptDurationMs": 570.236,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.4599999999996,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.619999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 685.4529999999999,
      "heapDeltaBytes": 6476252,
      "heapUsedBytes": 67597120,
      "domNodes": -286,
      "jsHeapTotalBytes": 3522560,
      "scriptDurationMs": 111.69999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2075.476999999978,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.964999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 807.9640000000002,
      "heapDeltaBytes": 7534836,
      "heapUsedBytes": 67981856,
      "domNodes": -285,
      "jsHeapTotalBytes": 2473984,
      "scriptDurationMs": 136.999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.807000000003,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.482,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.05400000000003,
      "heapDeltaBytes": -10471600,
      "heapUsedBytes": 53663084,
      "domNodes": 16,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 120.31700000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.05800000001,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.381,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.84,
      "heapDeltaBytes": -10326084,
      "heapUsedBytes": 53646976,
      "domNodes": 18,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 122.092,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.9710000000118,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.655,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.63899999999995,
      "heapDeltaBytes": 5196420,
      "heapUsedBytes": 69249348,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 16.087,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.405999999999,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.206,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.568,
      "heapDeltaBytes": 5171628,
      "heapUsedBytes": 69340192,
      "domNodes": 22,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 20.869,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1713.666000000046,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.796,
      "layouts": 16,
      "layoutDurationMs": 4.733,
      "taskDurationMs": 877.509,
      "heapDeltaBytes": -17517492,
      "heapUsedBytes": 46503260,
      "domNodes": 19,
      "jsHeapTotalBytes": 24629248,
      "scriptDurationMs": 102.79500000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.7110000000566,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.241,
      "layouts": 16,
      "layoutDurationMs": 4.534,
      "taskDurationMs": 883.529,
      "heapDeltaBytes": -16878548,
      "heapUsedBytes": 47143136,
      "domNodes": -281,
      "jsHeapTotalBytes": 23580672,
      "scriptDurationMs": 99.32500000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.6010000000279,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 32.715999999999994,
      "layouts": 13,
      "layoutDurationMs": 13.379999999999999,
      "taskDurationMs": 1041.1380000000001,
      "heapDeltaBytes": 30613704,
      "heapUsedBytes": 99206260,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 40.407,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8554.101000000002,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.31,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4797.217,
      "heapDeltaBytes": 7395120,
      "heapUsedBytes": 67277764,
      "domNodes": -283,
      "jsHeapTotalBytes": 4501504,
      "scriptDurationMs": 1468.934,
      "eventListeners": -161,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8823.124000000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.506,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4918.768,
      "heapDeltaBytes": 14569524,
      "heapUsedBytes": 74175040,
      "domNodes": -285,
      "jsHeapTotalBytes": 4501504,
      "scriptDurationMs": 1484.681,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17496.185999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17480.828,
      "heapDeltaBytes": -48931952,
      "heapUsedBytes": 166932120,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13307904,
      "scriptDurationMs": 556.575,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17793.32599999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17761.368000000002,
      "heapDeltaBytes": -59950692,
      "heapUsedBytes": 167645436,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8331264,
      "scriptDurationMs": 583.916,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21151.419999999973,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 19.562999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21125.556000000004,
      "heapDeltaBytes": -44092916,
      "heapUsedBytes": 156115320,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15933440,
      "scriptDurationMs": 899.7249999999999,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 357,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21500.721999999994,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 19.89599999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21445.21,
      "heapDeltaBytes": -50031520,
      "heapUsedBytes": 154061024,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10948608,
      "scriptDurationMs": 924.19,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 262,
      "frameDurationMs": 18.33666666666674,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.4189999999735,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 20.602000000000004,
      "layouts": 3,
      "layoutDurationMs": 0.685,
      "taskDurationMs": 123.81,
      "heapDeltaBytes": 5326876,
      "heapUsedBytes": 68448084,
      "domNodes": 134,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.45,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 454.01700000002165,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 17.209000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.7240000000000001,
      "taskDurationMs": 103.97599999999998,
      "heapDeltaBytes": 5066620,
      "heapUsedBytes": 68257592,
      "domNodes": 121,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.984,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                               Coverage Diff                                @@
##           ci/fix-update-playwright-expectations-triggers   #14686    +/-   ##
================================================================================
  Coverage                                           78.48%   78.48%            
================================================================================
  Files                                                1790     1790            
  Lines                                              105427   105427            
  Branches                                            33059    32185   -874     
================================================================================
  Hits                                                82742    82742            
  Misses                                              22243    22243            
  Partials                                              442      442            
Flag Coverage Δ
unit 70.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne requested a review from DrJKL August 9, 2026 02:59
@christian-byrne
christian-byrne merged commit 7eb94db into ci/fix-update-playwright-expectations-triggers Aug 9, 2026
70 of 71 checks passed
@christian-byrne
christian-byrne deleted the ci/snapshot-regeneration-guards branch August 9, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants