Repository navigation
test(firstRunTour): close the two remaining mutation gaps from #14625 - #14676
Conversation
Two mutations from #14625 left the suite green: - Deleting `|| executionErrorStore.hasPromptError` from the run-state watcher source in useFirstRunTourController. The only test touching the flag asserted the negative case, so it passed precisely when the term did nothing — while a prompt-level refusal left the Result step spinning forever. - Changing `show('first_run_nudge')` to `show('command')` in FirstRunTourNudge. `command` is also the parameter default, so an omitted argument regresses the same way. Both new assertions were confirmed red under their mutation and green with it reverted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe pull request strengthens first-run tour tests. It verifies the nudge template source identifier and confirms that prompt validation errors transition a tour run to ChangesFirst-run tour tests
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1788 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.24 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 281 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T06:21:40.188Z",
"gitSha": "28d193197eaf87001451e69afb7fd3e7f536cad2",
"branch": "test/close-14625-gaps-23",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2044.9909999999818,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.1670000000001,
"heapDeltaBytes": 5865752,
"heapUsedBytes": 69715968,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 16.47,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.6409999999923,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.239999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.67100000000005,
"heapDeltaBytes": 5338156,
"heapUsedBytes": 69191180,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 16.167,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.0329999999817,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.939,
"layouts": 12,
"layoutDurationMs": 3.232,
"taskDurationMs": 864.8560000000001,
"heapDeltaBytes": -13377272,
"heapUsedBytes": 50782976,
"domNodes": -277,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 120.641,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1861.9770000000244,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.60999999999999,
"layouts": 12,
"layoutDurationMs": 3.3019999999999996,
"taskDurationMs": 881.2990000000001,
"heapDeltaBytes": -18691772,
"heapUsedBytes": 45360948,
"domNodes": 24,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 121.036,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8220000000215,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.543999999999999,
"layouts": 6,
"layoutDurationMs": 0.616,
"taskDurationMs": 375.20799999999997,
"heapDeltaBytes": 8532296,
"heapUsedBytes": 72591104,
"domNodes": 75,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 19.304,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1745.2240000000074,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.841000000000001,
"layouts": 6,
"layoutDurationMs": 0.6559999999999999,
"taskDurationMs": 375.419,
"heapDeltaBytes": 8268248,
"heapUsedBytes": 72161892,
"domNodes": 75,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 18.922,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 662.4919999999861,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.721000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.00900000000007,
"heapDeltaBytes": -10942188,
"heapUsedBytes": 53027996,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 62.98999999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 586.573000000044,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.790000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.512,
"heapDeltaBytes": -11304540,
"heapUsedBytes": 52689144,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 61.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.150999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.7820000000002,
"heapDeltaBytes": 7287980,
"heapUsedBytes": 66651104,
"domNodes": -280,
"jsHeapTotalBytes": 3522560,
"scriptDurationMs": 111.088,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2009.5979999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.393999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.216,
"heapDeltaBytes": 6913808,
"heapUsedBytes": 66270264,
"domNodes": -281,
"jsHeapTotalBytes": 2473984,
"scriptDurationMs": 102.368,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2179.4249999999806,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.545000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1299.9010000000003,
"heapDeltaBytes": 4550784,
"heapUsedBytes": 65263276,
"domNodes": -288,
"jsHeapTotalBytes": 3452928,
"scriptDurationMs": 436.37499999999994,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2187.9169999999704,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.446999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1287.222,
"heapDeltaBytes": -5470004,
"heapUsedBytes": 55714364,
"domNodes": -286,
"jsHeapTotalBytes": 6668288,
"scriptDurationMs": 432.45199999999994,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3164.5619999999894,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.835,
"layouts": 60,
"layoutDurationMs": 7.077,
"taskDurationMs": 1502.0469999999998,
"heapDeltaBytes": -4450388,
"heapUsedBytes": 57538040,
"domNodes": -290,
"jsHeapTotalBytes": 6406144,
"scriptDurationMs": 526.99,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3296.8439999999646,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.562,
"layouts": 60,
"layoutDurationMs": 7.169999999999999,
"taskDurationMs": 1563.6839999999997,
"heapDeltaBytes": 4010820,
"heapUsedBytes": 66131644,
"domNodes": -287,
"jsHeapTotalBytes": 5619712,
"scriptDurationMs": 555.865,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.0280000000207,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.14,
"heapDeltaBytes": 6660676,
"heapUsedBytes": 67381552,
"domNodes": -283,
"jsHeapTotalBytes": 4046848,
"scriptDurationMs": 114.25699999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.7710000000206,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 725.5480000000001,
"heapDeltaBytes": 6987204,
"heapUsedBytes": 67083428,
"domNodes": -281,
"jsHeapTotalBytes": 4571136,
"scriptDurationMs": 117.623,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.3610000000153,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.107999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.23900000000003,
"heapDeltaBytes": -10404876,
"heapUsedBytes": 53634520,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 117.40800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.0430000000224,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.655999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.82900000000006,
"heapDeltaBytes": -10740424,
"heapUsedBytes": 53605096,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 121.381,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.3289999999938,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.848000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.4449999999999,
"heapDeltaBytes": -17572464,
"heapUsedBytes": 46373580,
"domNodes": -278,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 14.166000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2010.485000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.758,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.801,
"heapDeltaBytes": 5093764,
"heapUsedBytes": 69304020,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 15.861,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.4240000000073,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.769,
"layouts": 16,
"layoutDurationMs": 4.366999999999999,
"taskDurationMs": 759.707,
"heapDeltaBytes": -4268916,
"heapUsedBytes": 59817648,
"domNodes": 60,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 92.876,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.6310000000312,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.453,
"layouts": 16,
"layoutDurationMs": 4.706,
"taskDurationMs": 795.541,
"heapDeltaBytes": -4294548,
"heapUsedBytes": 59921216,
"domNodes": 62,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 94.07799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.1680000000079,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.131000000000004,
"layouts": 13,
"layoutDurationMs": 12.316999999999998,
"taskDurationMs": 922.5739999999997,
"heapDeltaBytes": 31007572,
"heapUsedBytes": 97751000,
"domNodes": 13673,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 33.954,
"eventListeners": 2375,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8349.578000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4474.498,
"heapDeltaBytes": 12688380,
"heapUsedBytes": 71930012,
"domNodes": -282,
"jsHeapTotalBytes": 5812224,
"scriptDurationMs": 1393.355,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8404.469999999947,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4553.946,
"heapDeltaBytes": 7934624,
"heapUsedBytes": 67466368,
"domNodes": -284,
"jsHeapTotalBytes": 5287936,
"scriptDurationMs": 1392.1019999999999,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17209.100000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17176.152000000002,
"heapDeltaBytes": -58605104,
"heapUsedBytes": 167009424,
"domNodes": -8312,
"jsHeapTotalBytes": -7020544,
"scriptDurationMs": 613.8589999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16728.99700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16712.761,
"heapDeltaBytes": -38525756,
"heapUsedBytes": 166558084,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 518.309,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20262.226999999995,
"styleRecalcs": 137,
"styleRecalcDurationMs": 15.67400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20224.56,
"heapDeltaBytes": -29671512,
"heapUsedBytes": 176768308,
"domNodes": -8316,
"jsHeapTotalBytes": -8630272,
"scriptDurationMs": 929.1419999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 180,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20413.567000000057,
"styleRecalcs": 136,
"styleRecalcDurationMs": 16.044999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20388.155,
"heapDeltaBytes": -34463768,
"heapUsedBytes": 178481012,
"domNodes": -8312,
"jsHeapTotalBytes": -9707520,
"scriptDurationMs": 903.8710000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 463.77200000000585,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.666,
"layouts": 2,
"layoutDurationMs": 0.3880000000000001,
"taskDurationMs": 117.07900000000001,
"heapDeltaBytes": 5311972,
"heapUsedBytes": 68643684,
"domNodes": 134,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.536000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 472.45199999997567,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.561,
"layouts": 3,
"layoutDurationMs": 0.825,
"taskDurationMs": 105.16900000000001,
"heapDeltaBytes": 5076772,
"heapUsedBytes": 68224000,
"domNodes": 121,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.875,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14676 +/- ##
========================================
Coverage 78.46% 78.46%
========================================
Files 1790 1790
Lines 105382 105382
Branches 32178 33052 +874
========================================
Hits 82683 82683
Misses 22257 22257
Partials 442 442
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Closes #14625.
#14625 found three mutations of the first-run tour stack that leave the suite green. The first — the
GraphCanvasactivation seam — is already fixed in #14674. This PR closes the other two, so together with #14674 the issue is complete. On its own this PR does not cover gap 1.Test-only: no source file is touched.
Gap 2 —
hasPromptErrorwas asserted only in the negativeThe run-state watcher in
useFirstRunTourControllersourceshasNodeError || hasPromptError. The positive case was covered forhasNodeErroralone; the only test naminghasPromptErrorasserted that errors already on screen before the tour runs anything are ignored — which passes precisely when the term does nothing.Added
gives up on a run the validator refused before it reached a node: a prompt-level refusal arriving whilerunStateisgeneratingmust move the card to a terminal state. Without it, a prompt rejected whole never reaches a node and never gets a queue status, so the Result step spins forever.Mutation evidence — delete
|| executionErrorStore.hasPromptErrorfrom the watcher source:Gap 3 — the nudge telemetry source was ungated
FirstRunTourNudgecallsuseWorkflowTemplateSelectorDialog().show('first_run_nudge'). The existing test asserted onlytoHaveBeenCalled(), so the argument was free. Pinned it totoHaveBeenCalledWith('first_run_nudge').Worth noting:
'command'is also the default value of that parameter, so dropping the argument entirely regresses identically — the pinned assertion catches both.Mutation evidence — change the argument to
'command':Verification
pnpm install --frozen-lockfile,pnpm format:check,pnpm lint,pnpm typecheck— all exit 0.pnpm test:unit src/renderer/extensions/firstRunTour/— 10 files, 174 passed.git statusshows only the two.test.tsfiles changed).Unverified
firstRunToursuites; this is not a full re-run of the 31-mutation sweep from First-run tour: three test gaps survive — the feature's activation seam has no coverage at all #14625.playwright-tests-chromium-sharded (2, 16)failed on the first run inchangeTracker.spec.ts › Does not restore invalid navigation stack(subgraph undoexpect.pollassertions, one of which is already annotatedCurrently bugged:). Unrelated to this diff, which touches no source and nobrowser_tests. It passed on re-run; all 51 non-skipped checks now pass.