Repository navigation
fix: missing-media follow-ups from #14578 review - #14668
Conversation
🎭 Playwright: ✅ 1800 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🟢 -101 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🔴 +707 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • 🟢 -300 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-14T00:08:21.853Z",
"gitSha": "1a3083d2aca7d1ed715c731ee57c2d1179d82601",
"branch": "jaeone/missing-media-review-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.5900000000129,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.79900000000004,
"heapDeltaBytes": 5858568,
"heapUsedBytes": 70703784,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.636,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2038.7080000000424,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.251999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.119,
"heapDeltaBytes": 5946620,
"heapUsedBytes": 70885940,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 20.549,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1749.1560000000845,
"styleRecalcs": 73,
"styleRecalcDurationMs": 33.506,
"layouts": 12,
"layoutDurationMs": 3.043,
"taskDurationMs": 725.368,
"heapDeltaBytes": 430296,
"heapUsedBytes": 65353876,
"domNodes": 56,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 100.215,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1731.8649999999707,
"styleRecalcs": 73,
"styleRecalcDurationMs": 33.537,
"layouts": 12,
"layoutDurationMs": 3.302,
"taskDurationMs": 768.18,
"heapDeltaBytes": 189184,
"heapUsedBytes": 64960380,
"domNodes": 55,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 104.889,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1677.985999999919,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.468,
"layouts": 6,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 333.194,
"heapDeltaBytes": 8246756,
"heapUsedBytes": 72943004,
"domNodes": 78,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 18.928,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.6680000001397,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.273000000000001,
"layouts": 6,
"layoutDurationMs": 0.5319999999999999,
"taskDurationMs": 343.113,
"heapDeltaBytes": 8521884,
"heapUsedBytes": 73258052,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 19.157,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 626.1349999999766,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.883999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.50600000000003,
"heapDeltaBytes": -11293888,
"heapUsedBytes": 53535420,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 58.016000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 568.1700000000092,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.896,
"heapDeltaBytes": -11076048,
"heapUsedBytes": 53630344,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 50.66,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.1800000000912,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.0729999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.577,
"heapDeltaBytes": 3604360,
"heapUsedBytes": 64269216,
"domNodes": -284,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 109.68399999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.2189999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.655000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.003,
"heapDeltaBytes": 2886012,
"heapUsedBytes": 62675856,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 94.991,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2170.981999999867,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1109.9859999999999,
"heapDeltaBytes": 3282104,
"heapUsedBytes": 64166852,
"domNodes": -284,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 356.78700000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2194.2739999999503,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.672999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1104.809,
"heapDeltaBytes": -4946108,
"heapUsedBytes": 55839412,
"domNodes": -282,
"jsHeapTotalBytes": 4554752,
"scriptDurationMs": 360.484,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3116.31199999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.199,
"layouts": 60,
"layoutDurationMs": 7.345999999999999,
"taskDurationMs": 1265.324,
"heapDeltaBytes": 22570176,
"heapUsedBytes": 85066940,
"domNodes": 12,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 448.64099999999996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3085.711000000174,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.700999999999999,
"layouts": 60,
"layoutDurationMs": 7.3610000000000015,
"taskDurationMs": 1290.9540000000002,
"heapDeltaBytes": 22583724,
"heapUsedBytes": 86218484,
"domNodes": 10,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 443.514,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.1670000001195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.249000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.266,
"heapDeltaBytes": 7196580,
"heapUsedBytes": 68144356,
"domNodes": -284,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 95.13000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.3279999998922,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.7540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.6640000000001,
"heapDeltaBytes": 84676,
"heapUsedBytes": 60927868,
"domNodes": -283,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 94.373,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.0800000000745,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.793000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.798,
"heapDeltaBytes": -10708692,
"heapUsedBytes": 54164704,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 100.957,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 551.9429999999375,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.507,
"heapDeltaBytes": -10974372,
"heapUsedBytes": 54055420,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 101.262,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.2689999999839,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.747000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.467,
"heapDeltaBytes": 5916592,
"heapUsedBytes": 70717368,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 15.606999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.8540000001503,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.795999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.223,
"heapDeltaBytes": 5792940,
"heapUsedBytes": 70511064,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 17.632,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.0160000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.86300000000001,
"layouts": 16,
"layoutDurationMs": 3.726,
"taskDurationMs": 710.2049999999999,
"heapDeltaBytes": -3439576,
"heapUsedBytes": 61450884,
"domNodes": 64,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 84.59400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2050000000345,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.173,
"layouts": 16,
"layoutDurationMs": 4.225,
"taskDurationMs": 720.131,
"heapDeltaBytes": -3491008,
"heapUsedBytes": 61371620,
"domNodes": 61,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 88.185,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1319.1600000000108,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.735,
"layouts": 14,
"layoutDurationMs": 9.497000000000002,
"taskDurationMs": 839.5250000000001,
"heapDeltaBytes": 31365860,
"heapUsedBytes": 99700780,
"domNodes": 13673,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 28.905,
"eventListeners": 2373,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8134.276999999884,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.584,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3853.905,
"heapDeltaBytes": 4935864,
"heapUsedBytes": 64885580,
"domNodes": -283,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 1130.513,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8133.4750000000895,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3686.1169999999997,
"heapDeltaBytes": 10705304,
"heapUsedBytes": 70902132,
"domNodes": -279,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1116.489,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15037.417000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15017.285999999998,
"heapDeltaBytes": -40110104,
"heapUsedBytes": 158960840,
"domNodes": -8317,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 496.379,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14610.153999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14577.173999999999,
"heapDeltaBytes": -45647916,
"heapUsedBytes": 154306000,
"domNodes": -8312,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 478.60800000000006,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17648.048000000017,
"styleRecalcs": 124,
"styleRecalcDurationMs": 16.962000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17613.257999999998,
"heapDeltaBytes": -34159972,
"heapUsedBytes": 172342692,
"domNodes": -8312,
"jsHeapTotalBytes": -12591104,
"scriptDurationMs": 774.729,
"eventListeners": -16387,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17298.970000000052,
"styleRecalcs": 117,
"styleRecalcDurationMs": 15.283999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17262.671000000002,
"heapDeltaBytes": -46735896,
"heapUsedBytes": 177836804,
"domNodes": -8312,
"jsHeapTotalBytes": -11808768,
"scriptDurationMs": 749.573,
"eventListeners": -16385,
"totalBlockingTimeMs": 83,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 103.51199999990968,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.843,
"layouts": 2,
"layoutDurationMs": 0.5530000000000002,
"taskDurationMs": 72.30600000000001,
"heapDeltaBytes": 3211192,
"heapUsedBytes": 67159916,
"domNodes": 111,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 5.849,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 448.65900000013426,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.266,
"layouts": 3,
"layoutDurationMs": 1.079,
"taskDurationMs": 94.328,
"heapDeltaBytes": 5167540,
"heapUsedBytes": 68902696,
"domNodes": 147,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.633000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe PR coalesces missing-media cleanup after node removals, validates promoted widget values during scope checks, renames the reconciliation callback, adds regression coverage, and standardizes the browser test fixture alias. ChangesMissing-media reconciliation
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This PR tightens missing-media reconciliation and related tests without changing public surfaces or introducing new modules; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14668 +/- ##
=======================================
Coverage 81.51% 81.52%
=======================================
Files 1883 1883
Lines 109109 109118 +9
Branches 31774 31776 +2
=======================================
+ Hits 88944 88953 +9
+ Misses 19800 19790 -10
- Partials 365 375 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Heads up, and apologies for the collision: the stale-value hunk in this PR has already landed via #14948, which merged on 08-09 and shipped in v1.50.5. It is the identical change: return widget.value === candidate.name && isEditableValueOwner(node, widget)This PR was opened 08-07, a day before I raised #14948. I went looking for an open PR covering DrJKL's post-merge findings and did not find this one, so that duplication is on me rather than on you. The other two findings from that review are still only covered here, as far as I can tell:
Both are worth keeping. If it is useful, #14948 also added a deferred-verification regression test through the scan entry point on a promoted host, which may overlap whatever you have here on that path. One thing worth knowing if you rebase: while wiring that test I hit a fixture that encodes an impossible state, in the same family as the mode-transition issue DrJKL flagged. |
Comments now say what a thing is rather than narrating the situation around it, and names carry the rest: the reconciler's module doc keeps its first line, and the notes above the dropOutOfScope guard, the scan's ordering, isEditableValueOwner, and rootGraph are gone because the code already says all of it. Deletes the missingMediaStore.test.ts comment that could not be parsed. Also settles on `drop` for the operation that had been both `prune` and `drop`, and aliases comfyPageFixture to `test` the way the other 213 specs do. No behaviour changes.
#14948 pinned the guard through the realtime path and the predicate itself. The pipeline also writes confirmed candidates into the workflow's pendingWarnings, which workflowService restores without re-validating, so a stale candidate surviving there outlives the session. Asserting the cache needs a workflow stub, which is why the workspaceStore mock stops returning a null activeWorkflow.
Deleting N nodes ran the global candidate walk N times. Targeted removal for the deleted node stays synchronous; only the global pass is queued, once per burst, and it drops if the hooks were torn down meanwhile. The mode-change path keeps its synchronous semantics. The promotion lifecycle tests seeded their stale candidate after the removal and relied on the synchronous pass having already gone by, so they now let the removal's own reconcile land first.
The test hand-rolled the mode event while leaving the node in its default mode, so it never established the BYPASS state its transition claimed. setNodeMode already sits in this file.
66632c0 to
5518bf0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
No apology needed — you raised #14948 the day after this went up as a draft and it had no reviewer on it, so there was nothing to find. Rebased onto Kept your fixture resolution over mine. I had deleted the One gap #14948 didn't reach, which is why there's still a test here on that path: the guard is pinned through the realtime path and through the predicate itself, but not through The other two findings are still only here, both with mutation proofs on the new base. One thing the rebase surfaced: #15012 added per-installation teardown for deferred scans, and my coalescing microtask was module-scoped state sitting outside it, which was wrong given |
Summary
Follow-up to #14578: the comment/naming cleanup requested during its review, plus what remains of DrJKL's post-merge findings after #14948 landed the stale-value guard. Rebased onto current
main. Contained to files #14578 already touched — no new modules, exports, or store surfaces.Changes
Reconciliation during multi-node deletion (
useErrorClearingHooks.ts) — deleting N nodes ran the global candidate walk N times. Targeted removal for the deleted node stays synchronous; only the global pass is coalesced into one microtask per burst, and it drops if the hooks were torn down meanwhile. The mode-change path keeps its synchronous semantics. The scheduler lives in theinstallErrorClearingHooksclosure rather than at module scope, so it follows the per-installationdisposedlifecycle #15012 introduced.Two promotion lifecycle tests seeded their stale candidate after the removal and relied on the synchronous pass having already gone by; they now let the removal's own reconcile land first.
Un-bypass transition test — hand-rolled the mode event while leaving the node in its default mode, so it never established the BYPASS state its transition claimed. Driven through
setNodeMode, which already sits in that file.Workflow-load coverage for the stale-value guard — #14948 pinned the guard through the realtime path and through the predicate itself. The pipeline also writes confirmed candidates into the workflow's
pendingWarnings, whichworkflowServicerestores without re-validating, so a stale candidate surviving there outlives the session. Asserting the cache needs a workflow stub, which is why theworkspaceStoremock stops returning a nullactiveWorkflow.Comment and naming cleanup — comments say what a thing is rather than narrating the situation around it: the reconciler's module doc keeps its first line and drops the essay; the notes above the
dropOutOfScopeguard, the scan's ordering,isEditableValueOwner, androotGraphare gone because the code and the names already carry them. The unparseablemissingMediaStore.test.tscomment is deleted.findNodesReferencingValuesno longer explains a caller's behaviour. Settles ondropfor the operation spelled bothpruneanddrop. AliasescomfyPageFixturetotestinerrorsTabMissingMediaRuntime.spec.ts, matching the 213 other specs that do.Breaking: none.
Dropped on rebase
The stale-value hunk and its realtime regression test are identical to what #14948 shipped, so
mainalready has them. The promoted-media harness also encoded an impossible fixture state —createPromotedMissingMediaCandidatederivesnamefromhostWidget.value, but the harness overrodenamewhile leaving the widget elsewhere. #14948 fixed that by seeding throughhostValue, which keeps the two in sync rather than dropping the distinct name; that resolution is kept.Review focus
Both behavioural changes carry a mutation-proved regression test on this base: reverting the coalescing makes the burst test fail (2 calls instead of 0 before the microtask), and reverting the value guard makes the workflow-load test fail. Commits are split so each is independently reviewable and independently green.
Deliberately not included:
isEditableValueOwnerintosrc/core/graph/subgraph/, raised on fix: surface missing media on the promoted host widget #14578. The point stands — nothing there combines link state, promotion and liveness into "is this widget the editable value owner", and the predicate isn't missing-media-specific. But the move creates a new shared surface in the areafeature/ecs-migrationis actively reworking, which is not worth it for a single-caller helper. Left where it is.WidgetSelectDropdown'sroot/triggersemantics, and the reconciler's dependency on node add/remove — both scoped out by the reviewer, the latter to be handled in his refactor.enterSubgraphWithFallback, driving promoted-widget setup through user behaviour instead ofpage.evaluate, the options argument, and the_testNodesmock branches. Those change how the suite is built, so they're tracked in FE-1493.Test plan
Static gates clean on the rebased tree (
typecheck,lint,format:check,knip). Unit run scoped to the affected areas —composables/graph,platform/missingMedia— 188 tests green, and each of the four commits verified green on its own. Full suite left to CI.