Repository navigation
[backport cloud/1.49] feat(first-run-tour): read tour roles off an unpinned graph - #14665
Conversation
> **Stack — 6 of 6.** Rebuilt from scratch after the review on #13725, split into short PRs. > Based on #13290 (coachmark engine); each PR stacks on the one before it. > > 1. #14140 — engine: canvas targets for the coachmark tour > 2. #14141 — Getting Started screen + entry gating > 3. #14142 — role pins + live drift guard > 4. #14143 — the tour itself + e2e walk > 5. #14144 — post-tour nudge > 6. #14145 — unpinned workflows (share / template links) ← this PR ## Summary Pins cover the eight templates the grid can show. This covers everything else — a shared workflow, or a template URL nobody curated — by reading the roles off the graph itself. Simon asked that any-workflow generality land as its own stacked PR with adversarial tests rather than riding along untested; this is that PR. ## Changes - `heuristicRoles` finds the source, prompt and sink on an unpinned graph. Pins still win where they exist; anything else falls through to here, so the heuristics are the default path rather than dead code. - Prompt selection is ranked, not matched: labels are normalised for case and separators, wiring to a `positive` input outranks a label saying so, and `negative` / `system` disqualify. A tie returns nothing rather than guessing. - `?share=` and `?template=` links offer the tour once their workflow is actually on canvas. ## Review focus The tests are adversarial by design — negative-before-positive ports, a node carrying both boxes, disagreeing sinks, bypassed nodes, ties, a 50-node graph — all built on real `LGraph` instances rather than copied templates. That was the condition for bringing heuristics back at all. --------- Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: AustinMroz <austin@comfy.org> Co-authored-by: Maanil Verma <maanil@comfy.org> Co-authored-by: bymyself <cbyrne@comfy.org>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-04T05:13:15.037Z",
"gitSha": "700c7c2a2b720f15fafb9a288d8f4fc4efc97d75",
"branch": "backport-14145-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.7510000000239,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.484000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.492,
"heapDeltaBytes": 4912572,
"heapUsedBytes": 73048708,
"domNodes": 18,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 23.965999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2050.330000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.6189999999999,
"heapDeltaBytes": 5085496,
"heapUsedBytes": 73251472,
"domNodes": 16,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 28.642,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2127.6079999999524,
"styleRecalcs": 79,
"styleRecalcDurationMs": 58.326,
"layouts": 12,
"layoutDurationMs": 3.9230000000000005,
"taskDurationMs": 1130.75,
"heapDeltaBytes": -16353100,
"heapUsedBytes": 51652688,
"domNodes": -280,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 150.513,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1979.088000000047,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.529,
"layouts": 12,
"layoutDurationMs": 3.6679999999999997,
"taskDurationMs": 977.359,
"heapDeltaBytes": -180104,
"heapUsedBytes": 68108244,
"domNodes": 61,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 142.38799999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.5570000000007,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.773999999999997,
"layouts": 6,
"layoutDurationMs": 0.5820000000000001,
"taskDurationMs": 468.079,
"heapDeltaBytes": 7844244,
"heapUsedBytes": 76003624,
"domNodes": 78,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 28.048999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.5679999999156,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.840000000000003,
"layouts": 6,
"layoutDurationMs": 0.702,
"taskDurationMs": 381.59900000000005,
"heapDeltaBytes": 8001140,
"heapUsedBytes": 76105776,
"domNodes": 79,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 27.333999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.8999999999687,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.686000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.571,
"heapDeltaBytes": -12358072,
"heapUsedBytes": 55861348,
"domNodes": 20,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 64.819,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 722.7599999999939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.011999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.26399999999995,
"heapDeltaBytes": -12330768,
"heapUsedBytes": 55962772,
"domNodes": 18,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 68.583,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.426000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.1970000000001,
"heapDeltaBytes": 4779096,
"heapUsedBytes": 63556372,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 126.86,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.7000000000435,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 871.268,
"heapDeltaBytes": 4065144,
"heapUsedBytes": 63580752,
"domNodes": -283,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 133.57999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2385.019,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1427.206,
"heapDeltaBytes": -5087592,
"heapUsedBytes": 55149312,
"domNodes": -285,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 475.09799999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2405.6719999999814,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.933,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1487.711,
"heapDeltaBytes": 8410016,
"heapUsedBytes": 68996388,
"domNodes": -287,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 486.953,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3496.8810000000303,
"styleRecalcs": 64,
"styleRecalcDurationMs": 23.235,
"layouts": 60,
"layoutDurationMs": 7.762,
"taskDurationMs": 1696.3020000000001,
"heapDeltaBytes": 14777544,
"heapUsedBytes": 77067376,
"domNodes": -289,
"jsHeapTotalBytes": 6610944,
"scriptDurationMs": 582.792,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3479.975999999965,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.299999999999997,
"layouts": 60,
"layoutDurationMs": 7.8790000000000004,
"taskDurationMs": 1676.812,
"heapDeltaBytes": 943892,
"heapUsedBytes": 62598564,
"domNodes": 10,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 599.163,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.6470000000159,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.0600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.0400000000001,
"heapDeltaBytes": 5459296,
"heapUsedBytes": 66550464,
"domNodes": -284,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 132.457,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.0139999999046,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.858,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.0809999999999,
"heapDeltaBytes": 4040984,
"heapUsedBytes": 64932384,
"domNodes": -284,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 131.01299999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.8680000000113,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.856000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.00999999999993,
"heapDeltaBytes": -12285588,
"heapUsedBytes": 56045660,
"domNodes": 18,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 125.836,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 705.3670000000238,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.309000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.287,
"heapDeltaBytes": -11010280,
"heapUsedBytes": 57323788,
"domNodes": 20,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 126.16300000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2018.3760000000461,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.973999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.87499999999994,
"heapDeltaBytes": 4899104,
"heapUsedBytes": 73036840,
"domNodes": 16,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 19.651000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.2099999999864,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.582000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.493,
"heapDeltaBytes": 4687724,
"heapUsedBytes": 72820140,
"domNodes": 16,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 25.422,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1764.2890000000193,
"styleRecalcs": 75,
"styleRecalcDurationMs": 43.74,
"layouts": 16,
"layoutDurationMs": 4.925,
"taskDurationMs": 895.0939999999999,
"heapDeltaBytes": -4358968,
"heapUsedBytes": 63930516,
"domNodes": 62,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 105.32900000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.4450000000006,
"styleRecalcs": 77,
"styleRecalcDurationMs": 48.550999999999995,
"layouts": 16,
"layoutDurationMs": 4.733,
"taskDurationMs": 908.913,
"heapDeltaBytes": -4291164,
"heapUsedBytes": 63943324,
"domNodes": 62,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 106.161,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.269999999985,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.581,
"layouts": 15,
"layoutDurationMs": 14.148000000000001,
"taskDurationMs": 1078.622,
"heapDeltaBytes": 30990396,
"heapUsedBytes": 98350612,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 43.783,
"eventListeners": 2375,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8719.10200000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4874.724999999999,
"heapDeltaBytes": 18429232,
"heapUsedBytes": 77523820,
"domNodes": -283,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 1495.73,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9175.157000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.971999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5154.133,
"heapDeltaBytes": 15285344,
"heapUsedBytes": 74668396,
"domNodes": -283,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1575.3010000000002,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17734.444999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17703.795,
"heapDeltaBytes": -47577508,
"heapUsedBytes": 165813820,
"domNodes": -8316,
"jsHeapTotalBytes": -10915840,
"scriptDurationMs": 583.3839999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17970.398000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17940.566,
"heapDeltaBytes": -47212692,
"heapUsedBytes": 166164388,
"domNodes": -8312,
"jsHeapTotalBytes": -13574144,
"scriptDurationMs": 587.7509999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21527.057000000015,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.21700000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21465.333000000002,
"heapDeltaBytes": -52957044,
"heapUsedBytes": 156519500,
"domNodes": -8312,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 932.129,
"eventListeners": -16385,
"totalBlockingTimeMs": 409,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21460.308000000055,
"styleRecalcs": 149,
"styleRecalcDurationMs": 21.763000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21423.545000000002,
"heapDeltaBytes": -50228740,
"heapUsedBytes": 164986360,
"domNodes": -8312,
"jsHeapTotalBytes": -14622720,
"scriptDurationMs": 1079.401,
"eventListeners": -16383,
"totalBlockingTimeMs": 352,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.8130000000583,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.398,
"layouts": 3,
"layoutDurationMs": 0.5900000000000001,
"taskDurationMs": 131.10399999999998,
"heapDeltaBytes": -15576460,
"heapUsedBytes": 51789740,
"domNodes": 134,
"jsHeapTotalBytes": 6934528,
"scriptDurationMs": 12.922999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 465.19499999999425,
"styleRecalcs": 15,
"styleRecalcDurationMs": 25.535,
"layouts": 4,
"layoutDurationMs": 1.531,
"taskDurationMs": 149.016,
"heapDeltaBytes": -15705688,
"heapUsedBytes": 51715352,
"domNodes": 123,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 13.901,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.49 #14665 +/- ##
=============================================
Coverage ? 78.59%
=============================================
Files ? 1789
Lines ? 104420
Branches ? 32881
=============================================
Hits ? 82074
Misses ? 21916
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — final backport of the first-run tour stack (#14145), reviewed and approved on main. CI green: 49 success.
This completes the feature on 1.49. It carries heuristicRoles.ts and its test, which are the last files the release branches were missing.
Its earlier auto-backport attempts failed twice, both times because the PRs beneath it were not yet on the branch — the bot cherry-picks each PR of a stack independently. Once #14144's backport landed, this one was produced cleanly on the first try. That pattern held at all four levels, so it is a property of the workflow rather than anything about this code.
Two things worth passing to whoever owns PR Backport:
- The manual
workflow_dispatchis broken — it fails validation with "PR not found or inaccessible" because itsgh pr viewcalls lack repo context. Already tracked in open PR #13699. - The working re-trigger is the
labeledevent — remove and re-addneeds-backporton the merged PR.
Findings on this PR remain tracked as #14623 and #14625, neither blocking, and both now have fixes in flight.
Backport of #14145 to
cloud/1.49Automatically created by backport workflow.