Skip to content

[backport cloud/1.49] feat(first-run-tour): read tour roles off an unpinned graph - #14665

Merged
comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14145-to-cloud-1.49
Aug 4, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14145-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14145 to cloud/1.49

Automatically created by backport workflow.

> **Stack — 6 of 6.** Rebuilt from scratch after the review on #13725,
split into short PRs.
> Based on #13290 (coachmark engine); each PR stacks on the one before
it.
>
> 1. #14140 — engine: canvas targets for the coachmark tour
> 2. #14141 — Getting Started screen + entry gating
> 3. #14142 — role pins + live drift guard
> 4. #14143 — the tour itself + e2e walk
> 5. #14144 — post-tour nudge
> 6. #14145 — unpinned workflows (share / template links)  ← this PR

## Summary

Pins cover the eight templates the grid can show. This covers everything
else — a shared workflow, or a template URL nobody curated — by reading
the roles off the graph itself. Simon asked that any-workflow generality
land as its own stacked PR with adversarial tests rather than riding
along untested; this is that PR.

## Changes

- `heuristicRoles` finds the source, prompt and sink on an unpinned
graph. Pins still win where they exist; anything else falls through to
here, so the heuristics are the default path rather than dead code.
- Prompt selection is ranked, not matched: labels are normalised for
case and separators, wiring to a `positive` input outranks a label
saying so, and `negative` / `system` disqualify. A tie returns nothing
rather than guessing.
- `?share=` and `?template=` links offer the tour once their workflow is
actually on canvas.

## Review focus

The tests are adversarial by design — negative-before-positive ports, a
node carrying both boxes, disagreeing sinks, bypassed nodes, ties, a
50-node graph — all built on real `LGraph` instances rather than copied
templates. That was the condition for bringing heuristics back at all.

---------

Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: AustinMroz <austin@comfy.org>
Co-authored-by: Maanil Verma <maanil@comfy.org>
Co-authored-by: bymyself <cbyrne@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 4, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 4, 2026 05:00
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1767 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/04/2026, 05:02:35 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 154ms TBT · 93.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
vue-large-graph-idle: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 381ms TBT · 153.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 569ms
canvas-idle: script duration 26ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.8 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 52ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1054ms
canvas-mouse-sweep: script duration 146ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.1 MB
canvas-mouse-sweep: DOM nodes -110
canvas-mouse-sweep: event listeners -75
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 22ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 425ms
canvas-zoom-sweep: script duration 28ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.5 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 422ms
dom-widget-clipping: script duration 67ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 835ms
large-graph-idle: script duration 130ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 60.6 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -180
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1457ms
large-graph-pan: script duration 481ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 59.2 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 19ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1687ms
large-graph-zoom: script duration 591ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.6 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners -71
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 815ms
minimap-idle: script duration 132ms
minimap-idle: TBT 0ms
minimap-idle: heap used 62.7 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -180
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 435ms
subgraph-dom-widget-clipping: script duration 126ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 54.1 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 559ms
subgraph-idle: script duration 23ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.6 MB
subgraph-idle: DOM nodes 16
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 46ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 902ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.0 MB
subgraph-mouse-sweep: DOM nodes 62
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1079ms
subgraph-transition-enter: script duration 44ms
subgraph-transition-enter: TBT 154ms
subgraph-transition-enter: heap used 93.8 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5014ms
viewport-pan-sweep: script duration 1536ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.6 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17822ms
vue-large-graph-idle: script duration 586ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.3 MB
vue-large-graph-idle: DOM nodes -8314
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 149
vue-large-graph-pan: task duration 21444ms
vue-large-graph-pan: script duration 1006ms
vue-large-graph-pan: TBT 381ms
vue-large-graph-pan: heap used 153.3 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16384
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 140ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 49.4 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-04T05:13:15.037Z",
  "gitSha": "700c7c2a2b720f15fafb9a288d8f4fc4efc97d75",
  "branch": "backport-14145-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2039.7510000000239,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.484000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.492,
      "heapDeltaBytes": 4912572,
      "heapUsedBytes": 73048708,
      "domNodes": 18,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 23.965999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2050.330000000031,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.068,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.6189999999999,
      "heapDeltaBytes": 5085496,
      "heapUsedBytes": 73251472,
      "domNodes": 16,
      "jsHeapTotalBytes": 19779584,
      "scriptDurationMs": 28.642,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2127.6079999999524,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 58.326,
      "layouts": 12,
      "layoutDurationMs": 3.9230000000000005,
      "taskDurationMs": 1130.75,
      "heapDeltaBytes": -16353100,
      "heapUsedBytes": 51652688,
      "domNodes": -280,
      "jsHeapTotalBytes": 21217280,
      "scriptDurationMs": 150.513,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1979.088000000047,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 45.529,
      "layouts": 12,
      "layoutDurationMs": 3.6679999999999997,
      "taskDurationMs": 977.359,
      "heapDeltaBytes": -180104,
      "heapUsedBytes": 68108244,
      "domNodes": 61,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 142.38799999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.5570000000007,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 22.773999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.5820000000000001,
      "taskDurationMs": 468.079,
      "heapDeltaBytes": 7844244,
      "heapUsedBytes": 76003624,
      "domNodes": 78,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 28.048999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.5679999999156,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 20.840000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.702,
      "taskDurationMs": 381.59900000000005,
      "heapDeltaBytes": 8001140,
      "heapUsedBytes": 76105776,
      "domNodes": 79,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 27.333999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 636.8999999999687,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.686000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.571,
      "heapDeltaBytes": -12358072,
      "heapUsedBytes": 55861348,
      "domNodes": 20,
      "jsHeapTotalBytes": 21876736,
      "scriptDurationMs": 64.819,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 722.7599999999939,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.011999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.26399999999995,
      "heapDeltaBytes": -12330768,
      "heapUsedBytes": 55962772,
      "domNodes": 18,
      "jsHeapTotalBytes": 21352448,
      "scriptDurationMs": 68.583,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.426000000015,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.035,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 799.1970000000001,
      "heapDeltaBytes": 4779096,
      "heapUsedBytes": 63556372,
      "domNodes": -282,
      "jsHeapTotalBytes": 4775936,
      "scriptDurationMs": 126.86,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.7000000000435,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.799,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 871.268,
      "heapDeltaBytes": 4065144,
      "heapUsedBytes": 63580752,
      "domNodes": -283,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 133.57999999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2385.019,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.756,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1427.206,
      "heapDeltaBytes": -5087592,
      "heapUsedBytes": 55149312,
      "domNodes": -285,
      "jsHeapTotalBytes": 4775936,
      "scriptDurationMs": 475.09799999999996,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2405.6719999999814,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.933,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1487.711,
      "heapDeltaBytes": 8410016,
      "heapUsedBytes": 68996388,
      "domNodes": -287,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 486.953,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3496.8810000000303,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 23.235,
      "layouts": 60,
      "layoutDurationMs": 7.762,
      "taskDurationMs": 1696.3020000000001,
      "heapDeltaBytes": 14777544,
      "heapUsedBytes": 77067376,
      "domNodes": -289,
      "jsHeapTotalBytes": 6610944,
      "scriptDurationMs": 582.792,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3479.975999999965,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.299999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.8790000000000004,
      "taskDurationMs": 1676.812,
      "heapDeltaBytes": 943892,
      "heapUsedBytes": 62598564,
      "domNodes": 10,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 599.163,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.6470000000159,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.0600000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 803.0400000000001,
      "heapDeltaBytes": 5459296,
      "heapUsedBytes": 66550464,
      "domNodes": -284,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 132.457,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.0139999999046,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.858,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 827.0809999999999,
      "heapDeltaBytes": 4040984,
      "heapUsedBytes": 64932384,
      "domNodes": -284,
      "jsHeapTotalBytes": 3727360,
      "scriptDurationMs": 131.01299999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.8680000000113,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.856000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.00999999999993,
      "heapDeltaBytes": -12285588,
      "heapUsedBytes": 56045660,
      "domNodes": 18,
      "jsHeapTotalBytes": 22138880,
      "scriptDurationMs": 125.836,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 705.3670000000238,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.309000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.287,
      "heapDeltaBytes": -11010280,
      "heapUsedBytes": 57323788,
      "domNodes": 20,
      "jsHeapTotalBytes": 21876736,
      "scriptDurationMs": 126.16300000000003,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.3760000000461,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.973999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.87499999999994,
      "heapDeltaBytes": 4899104,
      "heapUsedBytes": 73036840,
      "domNodes": 16,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 19.651000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.2099999999864,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.582000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 609.493,
      "heapDeltaBytes": 4687724,
      "heapUsedBytes": 72820140,
      "domNodes": 16,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 25.422,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1764.2890000000193,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 43.74,
      "layouts": 16,
      "layoutDurationMs": 4.925,
      "taskDurationMs": 895.0939999999999,
      "heapDeltaBytes": -4358968,
      "heapUsedBytes": 63930516,
      "domNodes": 62,
      "jsHeapTotalBytes": 21090304,
      "scriptDurationMs": 105.32900000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.4450000000006,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 48.550999999999995,
      "layouts": 16,
      "layoutDurationMs": 4.733,
      "taskDurationMs": 908.913,
      "heapDeltaBytes": -4291164,
      "heapUsedBytes": 63943324,
      "domNodes": 62,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 106.161,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1467.269999999985,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.581,
      "layouts": 15,
      "layoutDurationMs": 14.148000000000001,
      "taskDurationMs": 1078.622,
      "heapDeltaBytes": 30990396,
      "heapUsedBytes": 98350612,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 43.783,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8719.10200000002,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.832,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4874.724999999999,
      "heapDeltaBytes": 18429232,
      "heapUsedBytes": 77523820,
      "domNodes": -283,
      "jsHeapTotalBytes": 6541312,
      "scriptDurationMs": 1495.73,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9175.157000000014,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.971999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5154.133,
      "heapDeltaBytes": 15285344,
      "heapUsedBytes": 74668396,
      "domNodes": -283,
      "jsHeapTotalBytes": 6279168,
      "scriptDurationMs": 1575.3010000000002,
      "eventListeners": -161,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17734.444999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17703.795,
      "heapDeltaBytes": -47577508,
      "heapUsedBytes": 165813820,
      "domNodes": -8316,
      "jsHeapTotalBytes": -10915840,
      "scriptDurationMs": 583.3839999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17970.398000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17940.566,
      "heapDeltaBytes": -47212692,
      "heapUsedBytes": 166164388,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13574144,
      "scriptDurationMs": 587.7509999999999,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21527.057000000015,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 20.21700000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21465.333000000002,
      "heapDeltaBytes": -52957044,
      "heapUsedBytes": 156519500,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12525568,
      "scriptDurationMs": 932.129,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 409,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21460.308000000055,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 21.763000000000034,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21423.545000000002,
      "heapDeltaBytes": -50228740,
      "heapUsedBytes": 164986360,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14622720,
      "scriptDurationMs": 1079.401,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 352,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 454.8130000000583,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 19.398,
      "layouts": 3,
      "layoutDurationMs": 0.5900000000000001,
      "taskDurationMs": 131.10399999999998,
      "heapDeltaBytes": -15576460,
      "heapUsedBytes": 51789740,
      "domNodes": 134,
      "jsHeapTotalBytes": 6934528,
      "scriptDurationMs": 12.922999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.19499999999425,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 25.535,
      "layouts": 4,
      "layoutDurationMs": 1.531,
      "taskDurationMs": 149.016,
      "heapDeltaBytes": -15705688,
      "heapUsedBytes": 51715352,
      "domNodes": 123,
      "jsHeapTotalBytes": 7720960,
      "scriptDurationMs": 13.901,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.22807% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/graph/GraphCanvas.vue 0.00% 7 Missing ⚠️
...ersistence/composables/useWorkflowPersistenceV2.ts 0.00% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.49   #14665   +/-   ##
=============================================
  Coverage              ?   78.59%           
=============================================
  Files                 ?     1789           
  Lines                 ?   104420           
  Branches              ?    32881           
=============================================
  Hits                  ?    82074           
  Misses                ?    21916           
  Partials              ?      430           
Flag Coverage Δ
unit 70.74% <91.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../sharing/composables/useSharedWorkflowUrlLoader.ts 96.42% <ø> (ø)
...flow/templates/composables/useTemplateUrlLoader.ts 100.00% <100.00%> (ø)
...firstRunTour/gettingStarted/GettingStartedCard.vue 94.44% <ø> (ø)
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 97.14% <100.00%> (ø)
...er/extensions/firstRunTour/roles/heuristicRoles.ts 100.00% <100.00%> (ø)
.../extensions/firstRunTour/roles/resolveTourRoles.ts 100.00% <100.00%> (ø)
...erer/extensions/firstRunTour/roles/tourRolePins.ts 100.00% <ø> (ø)
...nsions/firstRunTour/tour/firstRunTourDefinition.ts 100.00% <ø> (ø)
...ons/firstRunTour/tour/useFirstRunTourController.ts 100.00% <100.00%> (ø)
...ersistence/composables/useWorkflowPersistenceV2.ts 91.20% <0.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — final backport of the first-run tour stack (#14145), reviewed and approved on main. CI green: 49 success.

This completes the feature on 1.49. It carries heuristicRoles.ts and its test, which are the last files the release branches were missing.

Its earlier auto-backport attempts failed twice, both times because the PRs beneath it were not yet on the branch — the bot cherry-picks each PR of a stack independently. Once #14144's backport landed, this one was produced cleanly on the first try. That pattern held at all four levels, so it is a property of the workflow rather than anything about this code.

Two things worth passing to whoever owns PR Backport:

  • The manual workflow_dispatch is broken — it fails validation with "PR not found or inaccessible" because its gh pr view calls lack repo context. Already tracked in open PR #13699.
  • The working re-trigger is the labeled event — remove and re-add needs-backport on the merged PR.

Findings on this PR remain tracked as #14623 and #14625, neither blocking, and both now have fixes in flight.

@comfy-pr-bot
comfy-pr-bot merged commit d5a3985 into cloud/1.49 Aug 4, 2026
75 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14145-to-cloud-1.49 branch August 4, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants