Repository navigation
[backport cloud/1.49] feat(first-run-tour): offer templates once the tour ends - #14663
Conversation
> **Stack — 5 of 6.** Rebuilt from scratch after the review on #13725, split into short PRs. > Based on #13290 (coachmark engine); each PR stacks on the one before it. > > 1. #14140 — engine: canvas targets for the coachmark tour > 2. #14141 — Getting Started screen + entry gating > 3. #14142 — role pins + live drift guard > 4. #14143 — the tour itself + e2e walk > 5. #14144 — post-tour nudge ← this PR > 6. #14145 — unpinned workflows (share / template links) ## Summary A card that slides up after the tour ends, pointing the user at the rest of the template library. Deliberately outcome-blind: it shows whether the run succeeded, failed, or the user skipped — whoever just finished needs somewhere to go next either way. ## Changes - `FirstRunTourNudge`, armed when the tour deactivates and shown after a short delay. - "Armed" and "no dialog is covering me" are folded together in the watch getter and watched with `immediate: true`. Mounting when the nudge is already due still shows it — the previous attempt waited for an edge and could strand it permanently. - Two telemetry stages added to the engine's existing funnel; nothing re-implemented. ## Review focus The reconcile-at-setup shape is the fix worth checking. Both regression tests mount with pre-populated store state, which is the case that used to fail. --------- Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: AustinMroz <austin@comfy.org> Co-authored-by: bymyself <cbyrne@comfy.org>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1779 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-04T04:53:35.151Z",
"gitSha": "f53b112fc1cc132c5a97c5f07cc53ff1548f8fea",
"branch": "backport-14144-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.0180000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.495,
"heapDeltaBytes": 5111216,
"heapUsedBytes": 73189188,
"domNodes": 18,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 17.767,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2044.5029999999633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.271999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.16,
"heapDeltaBytes": 5176720,
"heapUsedBytes": 73222144,
"domNodes": 18,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 16.619000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2149.858999999992,
"styleRecalcs": 81,
"styleRecalcDurationMs": 56.974999999999994,
"layouts": 12,
"layoutDurationMs": 4.248,
"taskDurationMs": 1116.3260000000002,
"heapDeltaBytes": -16329520,
"heapUsedBytes": 51623468,
"domNodes": -283,
"jsHeapTotalBytes": 21741568,
"scriptDurationMs": 141.993,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.5110000000295,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.407999999999994,
"layouts": 12,
"layoutDurationMs": 3.725,
"taskDurationMs": 842.248,
"heapDeltaBytes": -364740,
"heapUsedBytes": 67838804,
"domNodes": 57,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 126.02199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1677.564000000018,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.874,
"layouts": 6,
"layoutDurationMs": 0.528,
"taskDurationMs": 389.52799999999996,
"heapDeltaBytes": 7904016,
"heapUsedBytes": 75946792,
"domNodes": 78,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 19.657999999999994,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.8530000000428,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.168,
"layouts": 6,
"layoutDurationMs": 0.5569999999999999,
"taskDurationMs": 384.311,
"heapDeltaBytes": 7975744,
"heapUsedBytes": 76402716,
"domNodes": 76,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 20.345,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 593.2099999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.69199999999995,
"heapDeltaBytes": -12096392,
"heapUsedBytes": 56152940,
"domNodes": 18,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 63.312999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 580.3499999999531,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.244000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.07,
"heapDeltaBytes": -12136684,
"heapUsedBytes": 55940584,
"domNodes": 20,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 60.084999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.6910000000285,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.763000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.221,
"heapDeltaBytes": 8986532,
"heapUsedBytes": 67677060,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 104.47200000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2038.6329999998907,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.921000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.824,
"heapDeltaBytes": 8272900,
"heapUsedBytes": 67674204,
"domNodes": -283,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 115.506,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2181.843000000015,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.671000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1293.909,
"heapDeltaBytes": -4677396,
"heapUsedBytes": 55302992,
"domNodes": -284,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 432.161,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2266.3800000000265,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.307999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1348.709,
"heapDeltaBytes": 5164148,
"heapUsedBytes": 65923152,
"domNodes": -286,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 445.734,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3230.4490000000214,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.372999999999998,
"layouts": 60,
"layoutDurationMs": 7.3469999999999995,
"taskDurationMs": 1456.029,
"heapDeltaBytes": 24491896,
"heapUsedBytes": 85870720,
"domNodes": 12,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 526.3990000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3228.633000000059,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.161999999999999,
"layouts": 60,
"layoutDurationMs": 7.606,
"taskDurationMs": 1575.3029999999999,
"heapDeltaBytes": -3161552,
"heapUsedBytes": 58507768,
"domNodes": -287,
"jsHeapTotalBytes": 8183808,
"scriptDurationMs": 536.9419999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2028.4389999999917,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.897999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.089,
"heapDeltaBytes": 4424004,
"heapUsedBytes": 65157552,
"domNodes": -282,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 110.74300000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2058.7809999999536,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.250999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 737.947,
"heapDeltaBytes": 8856028,
"heapUsedBytes": 69458108,
"domNodes": -282,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 123.757,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.5430000000447,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.185999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.37200000000007,
"heapDeltaBytes": -12297880,
"heapUsedBytes": 55868876,
"domNodes": 18,
"jsHeapTotalBytes": 23187456,
"scriptDurationMs": 117.509,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.9950000000363,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.770000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.44700000000006,
"heapDeltaBytes": -10920784,
"heapUsedBytes": 57172896,
"domNodes": 18,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 124.758,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.1440000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.554,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.05800000000005,
"heapDeltaBytes": 4910252,
"heapUsedBytes": 73044860,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 12.566999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1998.8850000000866,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.896000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.91800000000006,
"heapDeltaBytes": 4455256,
"heapUsedBytes": 72495376,
"domNodes": 18,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 15.989000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.5519999999879,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.225,
"layouts": 16,
"layoutDurationMs": 4.742000000000001,
"taskDurationMs": 770.7349999999999,
"heapDeltaBytes": -4701084,
"heapUsedBytes": 63525648,
"domNodes": 64,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 92.862,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.4599999999364,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.259,
"layouts": 16,
"layoutDurationMs": 3.5769999999999995,
"taskDurationMs": 738.9870000000001,
"heapDeltaBytes": -4485204,
"heapUsedBytes": 63866848,
"domNodes": 63,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 90.01200000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0149999999767,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.11399999999999,
"layouts": 14,
"layoutDurationMs": 12.586999999999998,
"taskDurationMs": 914.9789999999998,
"heapDeltaBytes": 29088056,
"heapUsedBytes": 98661376,
"domNodes": 13673,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 31.865000000000006,
"eventListeners": 2371,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8293.483999999979,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.992999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4571.652,
"heapDeltaBytes": 9977352,
"heapUsedBytes": 68850500,
"domNodes": -283,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 1407.996,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8575.533000000065,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4720.482000000001,
"heapDeltaBytes": 13580700,
"heapUsedBytes": 72615804,
"domNodes": -283,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 1467.124,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17227.260000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17205.7,
"heapDeltaBytes": -52653824,
"heapUsedBytes": 171091792,
"domNodes": -8312,
"jsHeapTotalBytes": -5185536,
"scriptDurationMs": 540.8009999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17369.22400000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17333.885000000002,
"heapDeltaBytes": -42778224,
"heapUsedBytes": 169529616,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 603.707,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20716.034999999978,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.60400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20689.399999999998,
"heapDeltaBytes": -36055592,
"heapUsedBytes": 170821532,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 893.3549999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 255,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21046.280000000024,
"styleRecalcs": 144,
"styleRecalcDurationMs": 18.22700000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20999.04,
"heapDeltaBytes": -40237732,
"heapUsedBytes": 166867876,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 955.2339999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 268,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 491.77200000002586,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.831000000000003,
"layouts": 4,
"layoutDurationMs": 1.575,
"taskDurationMs": 146.631,
"heapDeltaBytes": -15884232,
"heapUsedBytes": 51515724,
"domNodes": 158,
"jsHeapTotalBytes": 7983104,
"scriptDurationMs": 12.526,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 464.0300000000934,
"styleRecalcs": 13,
"styleRecalcDurationMs": 23.282999999999998,
"layouts": 4,
"layoutDurationMs": 1.563,
"taskDurationMs": 129.082,
"heapDeltaBytes": -15690476,
"heapUsedBytes": 51590320,
"domNodes": 121,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 12.238,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.49 #14663 +/- ##
=============================================
Coverage ? 78.53%
=============================================
Files ? 1785
Lines ? 104136
Branches ? 32787
=============================================
Hits ? 81783
Misses ? 21922
Partials ? 431
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — clean backport of #14144, reviewed and approved on main. CI green: 50 success, 26 skipped.
This one only succeeded on a retry. The first auto-attempt failed with conflicts because the bot cherry-picks each PR of a stack onto the release branch independently, and #14142/#14143 weren't there yet. Once those landed, re-firing the backport produced this cleanly.
Two notes for anyone hitting the same thing:
- The manual
workflow_dispatchforPR Backportis broken — it fails validation with "PR not found or inaccessible" because the workflow'sgh pr viewcalls have no repo context. That's already tracked in open PR #13699. - The working re-trigger is the
labeledevent: remove and re-addneeds-backporton the merged PR.
#14145's backport is still blocked behind this one and will be re-fired once this lands.
Findings on this PR remain tracked as #14622 and #14624 — neither blocks.
Backport of #14144 to
cloud/1.49Automatically created by backport workflow.