Skip to content

[backport cloud/1.49] feat(first-run-tour): offer templates once the tour ends - #14663

Merged
comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14144-to-cloud-1.49
Aug 4, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.49from
backport-14144-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14144 to cloud/1.49

Automatically created by backport workflow.

> **Stack — 5 of 6.** Rebuilt from scratch after the review on #13725,
split into short PRs.
> Based on #13290 (coachmark engine); each PR stacks on the one before
it.
>
> 1. #14140 — engine: canvas targets for the coachmark tour
> 2. #14141 — Getting Started screen + entry gating
> 3. #14142 — role pins + live drift guard
> 4. #14143 — the tour itself + e2e walk
> 5. #14144 — post-tour nudge  ← this PR
> 6. #14145 — unpinned workflows (share / template links)

## Summary

A card that slides up after the tour ends, pointing the user at the rest
of the template library. Deliberately outcome-blind: it shows whether
the run succeeded, failed, or the user skipped — whoever just finished
needs somewhere to go next either way.

## Changes

- `FirstRunTourNudge`, armed when the tour deactivates and shown after a
short delay.
- "Armed" and "no dialog is covering me" are folded together in the
watch getter and watched with `immediate: true`. Mounting when the nudge
is already due still shows it — the previous attempt waited for an edge
and could strand it permanently.
- Two telemetry stages added to the engine's existing funnel; nothing
re-implemented.

## Review focus

The reconcile-at-setup shape is the fix worth checking. Both regression
tests mount with pre-populated store state, which is the case that used
to fail.

---------

Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: AustinMroz <austin@comfy.org>
Co-authored-by: bymyself <cbyrne@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 4, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 4, 2026 04:41
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/04/2026, 04:42:50 AM UTC

Links

🎭 Playwright: ✅ 1779 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1758 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 145ms TBT · 94.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 262ms TBT · 161.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 481ms
canvas-idle: script duration 17ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.8 MB
canvas-idle: DOM nodes 18
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 47ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 979ms
canvas-mouse-sweep: script duration 134ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.0 MB
canvas-mouse-sweep: DOM nodes -113
canvas-mouse-sweep: event listeners -75
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 387ms
canvas-zoom-sweep: script duration 20ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 386ms
dom-widget-clipping: script duration 62ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.5 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 693ms
large-graph-idle: script duration 110ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.5 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -149
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1321ms
large-graph-pan: script duration 439ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 57.8 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1516ms
large-graph-zoom: script duration 532ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.8 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 716ms
minimap-idle: script duration 117ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.2 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 409ms
subgraph-dom-widget-clipping: script duration 121ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.9 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 449ms
subgraph-idle: script duration 14ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.4 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 755ms
subgraph-mouse-sweep: script duration 91ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.7 MB
subgraph-mouse-sweep: DOM nodes 64
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 915ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 94.1 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2371
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4646ms
viewport-pan-sweep: script duration 1438ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.5 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17270ms
vue-large-graph-idle: script duration 572ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.4 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 144
vue-large-graph-pan: task duration 20844ms
vue-large-graph-pan: script duration 924ms
vue-large-graph-pan: TBT 262ms
vue-large-graph-pan: heap used 161.0 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16383
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 4
workflow-execution: style recalc count 17
workflow-execution: task duration 138ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 49.2 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-04T04:53:35.151Z",
  "gitSha": "f53b112fc1cc132c5a97c5f07cc53ff1548f8fea",
  "branch": "backport-14144-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2087.0180000000005,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.91,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.495,
      "heapDeltaBytes": 5111216,
      "heapUsedBytes": 73189188,
      "domNodes": 18,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 17.767,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2044.5029999999633,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.271999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.16,
      "heapDeltaBytes": 5176720,
      "heapUsedBytes": 73222144,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 16.619000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2149.858999999992,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 56.974999999999994,
      "layouts": 12,
      "layoutDurationMs": 4.248,
      "taskDurationMs": 1116.3260000000002,
      "heapDeltaBytes": -16329520,
      "heapUsedBytes": 51623468,
      "domNodes": -283,
      "jsHeapTotalBytes": 21741568,
      "scriptDurationMs": 141.993,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.5110000000295,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.407999999999994,
      "layouts": 12,
      "layoutDurationMs": 3.725,
      "taskDurationMs": 842.248,
      "heapDeltaBytes": -364740,
      "heapUsedBytes": 67838804,
      "domNodes": 57,
      "jsHeapTotalBytes": 21090304,
      "scriptDurationMs": 126.02199999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1677.564000000018,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.874,
      "layouts": 6,
      "layoutDurationMs": 0.528,
      "taskDurationMs": 389.52799999999996,
      "heapDeltaBytes": 7904016,
      "heapUsedBytes": 75946792,
      "domNodes": 78,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 19.657999999999994,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.8530000000428,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.168,
      "layouts": 6,
      "layoutDurationMs": 0.5569999999999999,
      "taskDurationMs": 384.311,
      "heapDeltaBytes": 7975744,
      "heapUsedBytes": 76402716,
      "domNodes": 76,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 20.345,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 593.2099999999991,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.729999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.69199999999995,
      "heapDeltaBytes": -12096392,
      "heapUsedBytes": 56152940,
      "domNodes": 18,
      "jsHeapTotalBytes": 21352448,
      "scriptDurationMs": 63.312999999999995,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 580.3499999999531,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.244000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.07,
      "heapDeltaBytes": -12136684,
      "heapUsedBytes": 55940584,
      "domNodes": 20,
      "jsHeapTotalBytes": 21614592,
      "scriptDurationMs": 60.084999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.6910000000285,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.763000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 676.221,
      "heapDeltaBytes": 8986532,
      "heapUsedBytes": 67677060,
      "domNodes": -282,
      "jsHeapTotalBytes": 4775936,
      "scriptDurationMs": 104.47200000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.6329999998907,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.921000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 709.824,
      "heapDeltaBytes": 8272900,
      "heapUsedBytes": 67674204,
      "domNodes": -283,
      "jsHeapTotalBytes": 4513792,
      "scriptDurationMs": 115.506,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2181.843000000015,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.671000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1293.909,
      "heapDeltaBytes": -4677396,
      "heapUsedBytes": 55302992,
      "domNodes": -284,
      "jsHeapTotalBytes": 4513792,
      "scriptDurationMs": 432.161,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2266.3800000000265,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.307999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1348.709,
      "heapDeltaBytes": 5164148,
      "heapUsedBytes": 65923152,
      "domNodes": -286,
      "jsHeapTotalBytes": 5525504,
      "scriptDurationMs": 445.734,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3230.4490000000214,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.372999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.3469999999999995,
      "taskDurationMs": 1456.029,
      "heapDeltaBytes": 24491896,
      "heapUsedBytes": 85870720,
      "domNodes": 12,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 526.3990000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3228.633000000059,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.161999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.606,
      "taskDurationMs": 1575.3029999999999,
      "heapDeltaBytes": -3161552,
      "heapUsedBytes": 58507768,
      "domNodes": -287,
      "jsHeapTotalBytes": 8183808,
      "scriptDurationMs": 536.9419999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.4389999999917,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.897999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 694.089,
      "heapDeltaBytes": 4424004,
      "heapUsedBytes": 65157552,
      "domNodes": -282,
      "jsHeapTotalBytes": 3727360,
      "scriptDurationMs": 110.74300000000001,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2058.7809999999536,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.250999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 737.947,
      "heapDeltaBytes": 8856028,
      "heapUsedBytes": 69458108,
      "domNodes": -282,
      "jsHeapTotalBytes": 3727360,
      "scriptDurationMs": 123.757,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.5430000000447,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.185999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.37200000000007,
      "heapDeltaBytes": -12297880,
      "heapUsedBytes": 55868876,
      "domNodes": 18,
      "jsHeapTotalBytes": 23187456,
      "scriptDurationMs": 117.509,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 623.9950000000363,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.770000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.44700000000006,
      "heapDeltaBytes": -10920784,
      "heapUsedBytes": 57172896,
      "domNodes": 18,
      "jsHeapTotalBytes": 21090304,
      "scriptDurationMs": 124.758,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.1440000000016,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.554,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.05800000000005,
      "heapDeltaBytes": 4910252,
      "heapUsedBytes": 73044860,
      "domNodes": 20,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 12.566999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.8850000000866,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.896000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.91800000000006,
      "heapDeltaBytes": 4455256,
      "heapUsedBytes": 72495376,
      "domNodes": 18,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 15.989000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.5519999999879,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.225,
      "layouts": 16,
      "layoutDurationMs": 4.742000000000001,
      "taskDurationMs": 770.7349999999999,
      "heapDeltaBytes": -4701084,
      "heapUsedBytes": 63525648,
      "domNodes": 64,
      "jsHeapTotalBytes": 20828160,
      "scriptDurationMs": 92.862,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.4599999999364,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.259,
      "layouts": 16,
      "layoutDurationMs": 3.5769999999999995,
      "taskDurationMs": 738.9870000000001,
      "heapDeltaBytes": -4485204,
      "heapUsedBytes": 63866848,
      "domNodes": 63,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 90.01200000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.0149999999767,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.11399999999999,
      "layouts": 14,
      "layoutDurationMs": 12.586999999999998,
      "taskDurationMs": 914.9789999999998,
      "heapDeltaBytes": 29088056,
      "heapUsedBytes": 98661376,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 31.865000000000006,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8293.483999999979,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.992999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4571.652,
      "heapDeltaBytes": 9977352,
      "heapUsedBytes": 68850500,
      "domNodes": -283,
      "jsHeapTotalBytes": 7589888,
      "scriptDurationMs": 1407.996,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8575.533000000065,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.046,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4720.482000000001,
      "heapDeltaBytes": 13580700,
      "heapUsedBytes": 72615804,
      "domNodes": -283,
      "jsHeapTotalBytes": 7065600,
      "scriptDurationMs": 1467.124,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17227.260000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17205.7,
      "heapDeltaBytes": -52653824,
      "heapUsedBytes": 171091792,
      "domNodes": -8312,
      "jsHeapTotalBytes": -5185536,
      "scriptDurationMs": 540.8009999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17369.22400000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17333.885000000002,
      "heapDeltaBytes": -42778224,
      "heapUsedBytes": 169529616,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10952704,
      "scriptDurationMs": 603.707,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20716.034999999978,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 17.60400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20689.399999999998,
      "heapDeltaBytes": -36055592,
      "heapUsedBytes": 170821532,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8331264,
      "scriptDurationMs": 893.3549999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 255,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21046.280000000024,
      "styleRecalcs": 144,
      "styleRecalcDurationMs": 18.22700000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20999.04,
      "heapDeltaBytes": -40237732,
      "heapUsedBytes": 166867876,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10952704,
      "scriptDurationMs": 955.2339999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 268,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.77200000002586,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.831000000000003,
      "layouts": 4,
      "layoutDurationMs": 1.575,
      "taskDurationMs": 146.631,
      "heapDeltaBytes": -15884232,
      "heapUsedBytes": 51515724,
      "domNodes": 158,
      "jsHeapTotalBytes": 7983104,
      "scriptDurationMs": 12.526,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.0300000000934,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 23.282999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.563,
      "taskDurationMs": 129.082,
      "heapDeltaBytes": -15690476,
      "heapUsedBytes": 51590320,
      "domNodes": 121,
      "jsHeapTotalBytes": 7720960,
      "scriptDurationMs": 12.238,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/telemetry/TelemetryRegistry.ts 0.00% 3 Missing ⚠️
...xtensions/firstRunTour/nudge/FirstRunTourNudge.vue 97.43% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.49   #14663   +/-   ##
=============================================
  Coverage              ?   78.53%           
=============================================
  Files                 ?     1785           
  Lines                 ?   104136           
  Branches              ?    32787           
=============================================
  Hits                  ?    81783           
  Misses                ?    21922           
  Partials              ?      431           
Flag Coverage Δ
unit 70.61% <93.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/onboarding/onboardingTourStore.ts 98.25% <ø> (ø)
src/platform/telemetry/types.ts 100.00% <ø> (ø)
.../renderer/extensions/firstRunTour/FirstRunTour.vue 0.00% <ø> (ø)
...ons/firstRunTour/tour/useFirstRunTourController.ts 100.00% <100.00%> (ø)
...xtensions/firstRunTour/nudge/FirstRunTourNudge.vue 97.43% <97.43%> (ø)
src/platform/telemetry/TelemetryRegistry.ts 24.44% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — clean backport of #14144, reviewed and approved on main. CI green: 50 success, 26 skipped.

This one only succeeded on a retry. The first auto-attempt failed with conflicts because the bot cherry-picks each PR of a stack onto the release branch independently, and #14142/#14143 weren't there yet. Once those landed, re-firing the backport produced this cleanly.

Two notes for anyone hitting the same thing:

  • The manual workflow_dispatch for PR Backport is broken — it fails validation with "PR not found or inaccessible" because the workflow's gh pr view calls have no repo context. That's already tracked in open PR #13699.
  • The working re-trigger is the labeled event: remove and re-add needs-backport on the merged PR.

#14145's backport is still blocked behind this one and will be re-fired once this lands.

Findings on this PR remain tracked as #14622 and #14624 — neither blocks.

@comfy-pr-bot
comfy-pr-bot merged commit 560a572 into cloud/1.49 Aug 4, 2026
76 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14144-to-cloud-1.49 branch August 4, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants