Repository navigation
[backport core/1.49] feat(first-run-tour): offer templates once the tour ends - #14662
Conversation
> **Stack — 5 of 6.** Rebuilt from scratch after the review on #13725, split into short PRs. > Based on #13290 (coachmark engine); each PR stacks on the one before it. > > 1. #14140 — engine: canvas targets for the coachmark tour > 2. #14141 — Getting Started screen + entry gating > 3. #14142 — role pins + live drift guard > 4. #14143 — the tour itself + e2e walk > 5. #14144 — post-tour nudge ← this PR > 6. #14145 — unpinned workflows (share / template links) ## Summary A card that slides up after the tour ends, pointing the user at the rest of the template library. Deliberately outcome-blind: it shows whether the run succeeded, failed, or the user skipped — whoever just finished needs somewhere to go next either way. ## Changes - `FirstRunTourNudge`, armed when the tour deactivates and shown after a short delay. - "Armed" and "no dialog is covering me" are folded together in the watch getter and watched with `immediate: true`. Mounting when the nudge is already due still shows it — the previous attempt waited for an edge and could strand it permanently. - Two telemetry stages added to the engine's existing funnel; nothing re-implemented. ## Review focus The reconcile-at-setup shape is the fix worth checking. Both regression tests mount with pre-populated store state, which is the case that used to fail. --------- Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: AustinMroz <austin@comfy.org> Co-authored-by: bymyself <cbyrne@comfy.org>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1781 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T04:54:01.071Z",
"gitSha": "94eec9b1bf7a468a63b93bab563000ecae923240",
"branch": "backport-14144-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.5359999999791,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.886,
"heapDeltaBytes": 5116076,
"heapUsedBytes": 73184132,
"domNodes": 16,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 21.519,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2033.3570000000236,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.161000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.9240000000001,
"heapDeltaBytes": 5208528,
"heapUsedBytes": 73238344,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 24.199,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2167.507999999998,
"styleRecalcs": 77,
"styleRecalcDurationMs": 53.760999999999996,
"layouts": 12,
"layoutDurationMs": 4.889,
"taskDurationMs": 1137.492,
"heapDeltaBytes": -18280596,
"heapUsedBytes": 49703936,
"domNodes": -280,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 146.505,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1956.974999999943,
"styleRecalcs": 76,
"styleRecalcDurationMs": 50.50300000000001,
"layouts": 12,
"layoutDurationMs": 4.255,
"taskDurationMs": 997.8829999999999,
"heapDeltaBytes": -17532020,
"heapUsedBytes": 50560456,
"domNodes": -282,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 135.09300000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1459999999956,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.209000000000003,
"layouts": 6,
"layoutDurationMs": 0.763,
"taskDurationMs": 426.937,
"heapDeltaBytes": 8051048,
"heapUsedBytes": 76332076,
"domNodes": 77,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 24.438999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.8779999999197,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.409999999999997,
"layouts": 6,
"layoutDurationMs": 0.6629999999999999,
"taskDurationMs": 490.04299999999995,
"heapDeltaBytes": 8121264,
"heapUsedBytes": 76385904,
"domNodes": 77,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 29.506,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 577.1240000000262,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.186000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.29,
"heapDeltaBytes": -12308324,
"heapUsedBytes": 55882800,
"domNodes": 14,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 59.913,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 616.1990000000515,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.463000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.124,
"heapDeltaBytes": -12172236,
"heapUsedBytes": 55837096,
"domNodes": 16,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 62.522000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.8179999999875,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.433,
"heapDeltaBytes": 8599012,
"heapUsedBytes": 67576912,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 118.93499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.8530000000974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.357000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.982,
"heapDeltaBytes": 5334348,
"heapUsedBytes": 64176040,
"domNodes": -284,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 131.472,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2385.0349999999594,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1480.003,
"heapDeltaBytes": -4640176,
"heapUsedBytes": 55336864,
"domNodes": -284,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 495.66999999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2276.491999999962,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.772000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1423.03,
"heapDeltaBytes": 4802192,
"heapUsedBytes": 65275404,
"domNodes": -289,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 476.56899999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3610.8090000000175,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.393,
"layouts": 60,
"layoutDurationMs": 8.025,
"taskDurationMs": 1750.934,
"heapDeltaBytes": -7770100,
"heapUsedBytes": 53921812,
"domNodes": -289,
"jsHeapTotalBytes": 7135232,
"scriptDurationMs": 634.8389999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3544.9040000000878,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.347999999999995,
"layouts": 60,
"layoutDurationMs": 8.005,
"taskDurationMs": 1712.794,
"heapDeltaBytes": 15428048,
"heapUsedBytes": 77611640,
"domNodes": -287,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 609.656,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2349999999901,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.339000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.302,
"heapDeltaBytes": 5661232,
"heapUsedBytes": 66527276,
"domNodes": -285,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 117.296,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2011.150999999927,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.729,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.243,
"heapDeltaBytes": 1938384,
"heapUsedBytes": 62578116,
"domNodes": -284,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 130.92600000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.6610000000087,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.19100000000003,
"heapDeltaBytes": -11944744,
"heapUsedBytes": 56041208,
"domNodes": 18,
"jsHeapTotalBytes": 22401024,
"scriptDurationMs": 132.738,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.8589999999967,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.694,
"heapDeltaBytes": -12309520,
"heapUsedBytes": 56022632,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 126.726,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.930000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.056000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.4190000000001,
"heapDeltaBytes": 4899056,
"heapUsedBytes": 73114860,
"domNodes": 16,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 18.599999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.2999999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.261999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.225,
"heapDeltaBytes": 4809888,
"heapUsedBytes": 73189756,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 23.447,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.7169999999714,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.583,
"layouts": 16,
"layoutDurationMs": 4.345999999999999,
"taskDurationMs": 891.8130000000001,
"heapDeltaBytes": -21573024,
"heapUsedBytes": 46694044,
"domNodes": -280,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 102.093,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.5620000000017,
"styleRecalcs": 73,
"styleRecalcDurationMs": 39.864000000000004,
"layouts": 16,
"layoutDurationMs": 4.667,
"taskDurationMs": 875.37,
"heapDeltaBytes": -4459440,
"heapUsedBytes": 63945600,
"domNodes": 59,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 101.303,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.1419999999516,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.062000000000005,
"layouts": 14,
"layoutDurationMs": 13.448000000000002,
"taskDurationMs": 1041.382,
"heapDeltaBytes": 30989036,
"heapUsedBytes": 99565080,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 42.39499999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8763.149000000056,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.038000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5055.552000000001,
"heapDeltaBytes": 8632212,
"heapUsedBytes": 68603736,
"domNodes": -282,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 1570.1009999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9041.515000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.967000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5070.978,
"heapDeltaBytes": 21949924,
"heapUsedBytes": 81692312,
"domNodes": -282,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 1601.7210000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17752.346999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17729.694000000003,
"heapDeltaBytes": -49084728,
"heapUsedBytes": 161883300,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 628.525,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17405.701000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17386.593999999997,
"heapDeltaBytes": -29329440,
"heapUsedBytes": 172592372,
"domNodes": -8312,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 581.783,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21209.944000000065,
"styleRecalcs": 143,
"styleRecalcDurationMs": 19.541000000000032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21164.88,
"heapDeltaBytes": -52508136,
"heapUsedBytes": 154170860,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 916.413,
"eventListeners": -16383,
"totalBlockingTimeMs": 343,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23421.44500000006,
"styleRecalcs": 170,
"styleRecalcDurationMs": 25.31100000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23390.403,
"heapDeltaBytes": -40847600,
"heapUsedBytes": 166993424,
"domNodes": -8316,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 1047.5599999999997,
"eventListeners": -16381,
"totalBlockingTimeMs": 801,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 33.299999999995634
},
{
"name": "workflow-execution",
"durationMs": 454.2109999999866,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.997000000000003,
"layouts": 3,
"layoutDurationMs": 0.5400000000000001,
"taskDurationMs": 134.569,
"heapDeltaBytes": -15513476,
"heapUsedBytes": 51679384,
"domNodes": 134,
"jsHeapTotalBytes": 6934528,
"scriptDurationMs": 11.335,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.8970000000081,
"styleRecalcs": 14,
"styleRecalcDurationMs": 26.123,
"layouts": 3,
"layoutDurationMs": 1.3459999999999999,
"taskDurationMs": 164.265,
"heapDeltaBytes": -15592960,
"heapUsedBytes": 51605152,
"domNodes": 121,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 12.891,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.49 #14662 +/- ##
=============================================
+ Coverage 78.46% 78.53% +0.06%
=============================================
Files 1781 1785 +4
Lines 103810 104136 +326
Branches 31851 32787 +936
=============================================
+ Hits 81459 81783 +324
- Misses 21920 21922 +2
Partials 431 431
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — clean backport of #14144, reviewed and approved on main. CI green: 50 success, 26 skipped.
This one only succeeded on a retry. The first auto-attempt failed with conflicts because the bot cherry-picks each PR of a stack onto the release branch independently, and #14142/#14143 weren't there yet. Once those landed, re-firing the backport produced this cleanly.
Two notes for anyone hitting the same thing:
- The manual
workflow_dispatchforPR Backportis broken — it fails validation with "PR not found or inaccessible" because the workflow'sgh pr viewcalls have no repo context. That's already tracked in open PR #13699. - The working re-trigger is the
labeledevent: remove and re-addneeds-backporton the merged PR.
#14145's backport is still blocked behind this one and will be re-fired once this lands.
Findings on this PR remain tracked as #14622 and #14624 — neither blocks.
Backport of #14144 to
core/1.49Automatically created by backport workflow.