Repository navigation
[backport cloud/1.49] fix: surface missing media on the promoted host widget - #14661
Conversation
## Summary Move missing-media error surfacing from the interior widget to the promoted host widget, matching the ADR 0009 ownership model. Built as a red-green pair. The tests were written and pushed first and failed on CI; the implementation followed and turned them green, with the failing and passing runs both linked below. ## Changes - **What**: - `refactor: extract the missing media pipeline seam` — moves `runMissingMediaPipeline` / `cacheMediaCandidates` out of `ComfyApp` into `src/platform/missingMedia/missingMediaPipeline.ts`, mirroring the existing `missingModelPipeline.ts`. Pure move. - Test commits — 30 failing unit tests across 6 files plus 3 E2E scenarios, defining the contract below. - `fix: surface missing media on the promoted host widget` — the implementation. - `refactor: derive missing media detection from the input spec` — replaces the hardcoded `MEDIA_NODE_WIDGETS` map with the upload flags the backend already declares. - `fix: move the missing media error surface on promotion as well as demotion` — closes the promotion half of the ownership transfer. - `refactor: address review nits on the promoted missing media surface`. - **Breaking**: none. - **Dependencies**: none. Production total: 332 insertions / 114 deletions across 9 files. ## Why [#12197](#12197) (ADR 0009) made promoted widgets host-owned: the host `SubgraphNode` widget owns the value and the interior widget only supplies schema/options metadata. [#13059](#13059) updated **missing model** detection for that contract. **Missing media was never updated** — `missingMediaScan.ts` still skips subgraph hosts entirely and reads the interior widget. What the user sees today, with a `LoadImage` inside a subgraph whose `image` widget is promoted: - The error is keyed to the interior node, so the errors-tab row navigates to a node the user cannot edit — the interior widget is disabled while promoted. - Selecting a valid image on the host does not clear it. Entering the subgraph re-creates the candidate from the stale interior value through the `onNodeAdded` rescan. ## The contract these tests pin A candidate is created from the **unlinked final editable value owner**. | | `nodeId` | `widgetName` | `nodeType` | | --- | --- | --- | --- | | plain node widget | node execId | widget name | node type | | promoted host widget | **host execId** | **host SubgraphInput name** | **leaf node type** (e.g. `LoadImage`) | 1. A widget whose paired input slot has a link is not the value owner and is skipped — promoted interior widgets and ordinary link-fed widgets alike. 2. Media-widget identification reads the **leaf** widget's `InputSpec` upload flags (`image_upload`, `animated_image_upload`, `video_upload`, `audio_upload`) via `nodeDefStore.getInputSpecForWidget`. The tests were written against the four-node `MEDIA_NODE_WIDGETS` map that existed at the time; the later spec-based commit keeps every one of them green and additionally covers custom loader nodes. 3. **Value and combo options are both read from the scanned widget** — for a promoted widget that means the host, never the leaf. 4. Nested `A → B → C`: only `A` creates a candidate. 5. Two hosts sharing one subgraph definition produce independent candidates. 6. **Liveness follows an any-consumer rule**: the candidate survives while at least one fully-active path exists from the host input to a concrete widget, and disappears when all of them are inactive or the promotion is released. ## Review Focus ### Two intentional differences from missing model **1. Options are read from the host, not the leaf.** `missingModelScan` reads the interior widget's options. Media cannot: uploading through the host dropdown appends the filename to the *host* widget's option list only (`useWidgetSelectActions.handleFilesUpdate`), so reading leaf options would report a just-uploaded file as missing on the next rescan. Model combos have no upload control — `allowUpload` derives from the same spec flags this PR now reads for detection — so the divergence does not apply to them. **2. Liveness is any-consumer, not first-link.** A `SubgraphInput` can feed N interior widgets, and ADR 0009's primitive-fanout repair creates exactly that shape. `resolveSubgraphInputLink` returns only the first resolvable link as the "promoted representative", and `missingModelScan.ts:219` uses that single representative for liveness. In model today, with consumers A/B/C, bypassing **A alone** clears the host error even though B and C still need the file — the outcome depends on link order, which is an implementation detail. Media does not inherit that. A follow-up PR will align `missingModelScan` to the same rule. ### What each wrong implementation trips on | wrong implementation | caught by | | --- | --- | | reads the interior widget's value | `uses a valid host value even when the linked interior value is stale` | | reads the interior widget's options | `accepts a value found only in the promoted host options` + `reports a value found only in the interior leaf options as missing` | | first-link representative for liveness | first-consumer scan case + fanout lifecycle step 1 | | last-link representative for liveness | last-nested-branch scan case + fanout lifecycle step 2 | | fixes the scan but not removal | the lifecycle reds | | fixes removal but not the scan | the scan reds | All four production liveness call sites are pinned separately — scan, removal/mode-change, workflow-load async verification, realtime async verification — so a partial implementation cannot go green. ### Test notes - Some guards are green today by design. The `scanNodeMediaCandidates` BYPASS/NEVER guards and three `missingMediaStore` tests pass without production changes; they exclude specific wrong implementations rather than proving the bug. Removal authority intentionally lives in the scan rather than in a targeted store API. - `MissingMediaCandidate` gains **no new field**. An earlier design recorded the leaf execution path on the candidate; that cannot express any-consumer liveness and goes stale when consumers change, so liveness is re-derived from the host at check time. - Commit 1 is a pure move. `this.rootGraph` was read lazily inside `.then()` and is now captured as a parameter; these are equivalent because `rootGraphInternal` has exactly one assignment site (`app.ts:955`), so a single `LGraph` exists for the app's lifetime. Verified by applying only the two production files to `main` and running the full unit suite. ### Known unrelated CI noise - `src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts` intermittently times out at 5s on module-level dynamic imports. Reproduced on this branch's base commit. - `.nvmrc` pins a floating `node 25`, resolved fresh per run, so identical commits can behave differently across runs. ## Changes after the green run Three commits landed after the red-green pair. All 51 checks pass on `86382c61`. **Spec-based media detection.** *Ecosystem impact: this broadens detection from four hardcoded node types to every node whose combo input declares an upload flag, so third-party media loaders will now surface missing-media errors where they previously never did. `mesh_upload` stays unhandled — missing media has no mesh surface yet.* Detection was a hardcoded map of four node types (`LoadImage`, `LoadImageMask`, `LoadVideo`, `LoadAudio`) keyed by widget name. It now reads the upload flags the backend already declares on the combo `InputSpec`, resolved through `nodeDefStore.getInputSpecForWidget` — the same API the Vue layer uses to populate `SimplifiedWidget.spec` (`useGraphNodeManager.ts:165`), and the same flag precedence `WidgetSelect.vue` uses to decide whether a widget renders an upload control. Custom loader nodes are now covered. `candidate.nodeType` still comes from the leaf: the errors overlay formats it directly (`missingErrorResolver.ts:265`), and a `SubgraphNode`'s own `type` is a UUID, which `formatNodeTypeName` would pass through verbatim. **Promotion, not just demotion.** Promotion transfers value ownership from the interior widget to the host; demotion transfers it back. Only demotion was handled, so promoting a widget with a missing file left the error keyed to the interior node the user can no longer edit — the same class of bug this PR exists to fix, reached by a different route — and demoting deleted the error without re-checking the widget that regained ownership. Both events now rescan the host subtree: whichever side lost ownership fails the scope check and is dropped, whichever side gained it is scanned fresh. Demotion keeps its explicit host removal because `ensureWidgetRemoved` dispatches before the widget leaves the input, so the scope filter cannot yet see it gone. Two tests, both mutation-proven. Two branches that could not change behaviour were removed: the `app.rootGraph === graph.rootGraph` guard in `onNodeRemoved` (hooks install on `canvasStore.currentGraph`, which may be a `Subgraph`, but `Subgraph.rootGraph` returns the app's single root, so it is always true), and the missing-widget early return in `isMissingMediaCandidateScopeActive` (`getSlotFromWidget` accepts `undefined`, so the branch returned exactly what the code below it already returned). ## Follow-ups An 18-lane blackbox review produced these. Each is real but outside this PR's scope; none block it. | # | item | why deferred | | --- | --- | --- | | 1 | `findNodesReferencingValues` skips subgraph hosts, so a deleted asset stays written into the workflow JSON through a promoted host | named as a non-goal below; extending it needs a decision on what preview-clearing means for a host, whose outputs the interior node produces | | 2 | the promotion-listener `Map` keys on `Subgraph`, retaining definitions until teardown | lifetime question that applies to the sibling model path too | | 3 | the per-node scan lost its node-type early bail, so a full-graph scan is O(M·N) | needs a cheap pre-filter that does not reintroduce the hardcoded map | | 4 | per-node media verification is uncancellable; its `rootGraph` staleness guard cannot fire for same-workflow edits | needs an `AbortSignal` through the scan path, which `verifyMediaCandidates` already accepts | | 5 | `isWidgetMissingMedia` is a linear scan where the model store precomputes a key `Set` | render-path optimisation, measurable only on large graphs | | 6 | `hasActiveConsumer` re-implements `resolveSubgraphInputLink`'s traversal and sits in `resolveConcretePromotedWidget.ts` | unifying them means changing the model path's first-link semantics, which item 8 covers | | 7 | promoted-host uploads set no in-flight flag: the interior widget is disabled so `useNodeImageUpload` never runs, and `WidgetSelectDropdown` tracks upload state in a local `ref` | the `isUploading` guard is therefore unreachable for promoted widgets; fixing it is an upload-path change, not a detection change | | 8 | an active *non-media* consumer keeps a missing-media error alive that the user cannot clear | needs a product decision on what liveness should mean for heterogeneous fanout | | 9 | the scan reaches into the leaf for `candidate.nodeType`, which only the overlay message consumes directly (`missingErrorResolver.ts:265`); the row label already prefers the node's display name | switching the overlay to the display name would let the scan drop `resolvePromotedWidgetSource` entirely — `getInputSpecForWidget` already walks the promoted chain itself, so chain resolution would live behind one store API instead of being re-derived here. Deferred because it changes a user-visible string (i18n) and `nodeType` is a public field on `MissingMediaCandidate` shared with grouping and the model-side symmetry | | 10 | a media file drop calls `showPendingWarnings()` unconditionally (`app.ts:714`), restoring `wf.pendingWarnings.missingMediaCandidates` verbatim — so an error cleared by a bypass, a node deletion or a demotion comes back, keyed to a node that may no longer exist | **pre-existing, reproduces on `main`** — filed as [FE-1487](https://linear.app/comfyorg/issue/FE-1487/cleared-missing-media-errors-reappear-after-a-media-file-drop-keyed-to). Nothing outside the load pipeline updates that cache, and `showPendingWarnings` re-writes what it read, so the divergence is self-perpetuating. The restore path is shared with missing model and missing node, so any fix has to be validated across all three | | 11 | the upload-flag precedence in `mediaTypeFromSpec` duplicates `WidgetSelect.vue:82-90`, which derives the same `AssetKind` from the same flags and also handles `mesh_upload` | a shared `assetKindFromComboSpec` would keep them from drifting when a flag is added, but `WidgetSelect.vue` is outside this PR's diff | ## Non-goals - Does not change missing **model** behavior. - Does not change the hide-vs-disable UX for promoted widgets, which is pending design. - Does not widen `findNodesReferencingValues`; the deleted-asset path will be fixed at its call site so the preview-clearing and value-clearing consumers keep their current behavior. ## Red-green proof | phase | commit | unit | e2e | | --- | --- | --- | --- | | Red | [`e11161a8`](e11161a839) | [failed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30760755440/job/91530691345) | [failed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30760755459/job/91530918284) | | Green | [`1fe2d9a8`](1fe2d9a85b) | [passed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30765383959/job/91543058867) | [passed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30765383923/job/91543279012) | At red, the only failing jobs were the unit suite, one chromium E2E shard, and the `e2e-status` job that aggregates them; the other 47 checks passed. The failing unit files were exactly the six this PR touches. The E2E failures were behavioural assertions rather than setup errors — the first one printed the bug directly, with the errors-tab row naming the interior node the user cannot edit: ``` Locator: getByTestId('missing-media-row') Expected substring: "Subgraph with Promoted Missing Media - outer_image" Received string: "Load Image - image" ``` At green, all 50 checks pass, including the same three jobs. The three commits added after that run are described above; the branch head [`86382c61`](86382c6198) is green on every check — [unit](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30778317952/job/91578007298), [e2e](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30778317997/job/91579591949) (27/27 jobs, covering the `cloud`, `mobile-chrome`, `mobile-safari`, `chromium-2x` and `chromium-0.5x` projects as well as the 16 chromium shards). ### Tests changed between the two runs Two tests were corrected after the red run was recorded. Both are listed here rather than folded in silently: 1. **`missingMediaStore.test.ts`** — the red-phase intersection type and cast were removed and `isWidgetMissingMedia` is now called directly. During red the store did not expose the method, so an optional member kept the failure an `AssertionError` instead of a `TypeError`; once the implementation landed the scaffolding became unnecessary. This completes what was promised in the review thread. 2. **`useProcessedWidgets.test.ts`** — `otherWidget` was re-aimed from `outer_image` to `outer_mask`. As written it shared its entire host identity with `matchingWidget` and differed only in `sourceExecutionId`, so it demanded source-path discrimination that this contract deliberately removes — it could not pass under any implementation. It remains a promoted widget, so the promoted path is still exercised, and a mutation that drops the `widgetName` comparison in the store still fails it. No other test changed: the 193 `it`/`describe` titles across the six red files are identical at both revisions, with no `skip` or `only` added, and the fixtures, E2E specs and helpers are untouched. ### Verification beyond CI - All ten contract rules were checked by mutation: 14 probes, 14 caught, none survived. The commits added after the green run were mutation-proven the same way — reverting the `widget-promoted` listener fails the promotion test, reverting the demotion rescan fails the demotion test, and reverting spec-based detection to the old map fails the custom-node test. - The E2E scenarios were run locally in both harnesses: the OSS chromium project against this branch's Vite dev server on `:5173`, and the `cloud` project against a `pnpm build:cloud` dist served by a local backend, matching how CI builds and serves it. ## Video https://github.com/user-attachments/assets/2e88d76c-c54e-4b69-b4b7-8d97be29b1b4
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1783 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-04T04:43:13.567Z",
"gitSha": "34370f98263e7e4b63b4c35902a926a460ea7646",
"branch": "backport-14578-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2112.9029999999884,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.3919999999999,
"heapDeltaBytes": 4725572,
"heapUsedBytes": 72810200,
"domNodes": 18,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 19.068,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.3529999999819,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.86699999999996,
"heapDeltaBytes": 5170240,
"heapUsedBytes": 73318316,
"domNodes": 20,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 18.612000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2135.101999999989,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.962999999999994,
"layouts": 12,
"layoutDurationMs": 4.321999999999999,
"taskDurationMs": 1126.3410000000001,
"heapDeltaBytes": -19831328,
"heapUsedBytes": 48285472,
"domNodes": -282,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 146.74699999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.411999999987,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.809999999999995,
"layouts": 12,
"layoutDurationMs": 3.694,
"taskDurationMs": 893.071,
"heapDeltaBytes": -17428776,
"heapUsedBytes": 50457488,
"domNodes": -279,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 124.194,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.251999999979,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.535,
"layouts": 6,
"layoutDurationMs": 0.5399999999999999,
"taskDurationMs": 384.351,
"heapDeltaBytes": 7836004,
"heapUsedBytes": 75903100,
"domNodes": 78,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 20.997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0010000000066,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.308999999999997,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 392.50300000000004,
"heapDeltaBytes": 8016756,
"heapUsedBytes": 75930960,
"domNodes": 77,
"jsHeapTotalBytes": 20045824,
"scriptDurationMs": 21.851000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 576.4350000000036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.188,
"heapDeltaBytes": -12434520,
"heapUsedBytes": 55956348,
"domNodes": 18,
"jsHeapTotalBytes": 21880832,
"scriptDurationMs": 61.79299999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 578.1379999999672,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.56,
"heapDeltaBytes": -12351840,
"heapUsedBytes": 55686464,
"domNodes": 18,
"jsHeapTotalBytes": 22405120,
"scriptDurationMs": 59.862,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.4259999999772,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.682999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.0999999999999,
"heapDeltaBytes": 8350620,
"heapUsedBytes": 67519684,
"domNodes": -281,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 126.719,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.2639999999928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.713999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.4309999999999,
"heapDeltaBytes": 7892072,
"heapUsedBytes": 67153184,
"domNodes": -281,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 111.18599999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2189.459999999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.632000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1312.493,
"heapDeltaBytes": 5696880,
"heapUsedBytes": 66052332,
"domNodes": -285,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 429.491,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2222.695999999928,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.396000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1333.6840000000002,
"heapDeltaBytes": 5362944,
"heapUsedBytes": 65849456,
"domNodes": -285,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 443.864,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3230.907000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.045999999999998,
"layouts": 60,
"layoutDurationMs": 7.6309999999999985,
"taskDurationMs": 1577.934,
"heapDeltaBytes": 742152,
"heapUsedBytes": 62709356,
"domNodes": -287,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 539.7850000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3394.2590000000337,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.834000000000001,
"layouts": 60,
"layoutDurationMs": 7.6930000000000005,
"taskDurationMs": 1676.3159999999998,
"heapDeltaBytes": 9337060,
"heapUsedBytes": 71837088,
"domNodes": -289,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 592.2379999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.9839999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.425000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.954,
"heapDeltaBytes": 8653664,
"heapUsedBytes": 69617116,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 110.666,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.3109999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.191999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.646,
"heapDeltaBytes": 8247320,
"heapUsedBytes": 69378148,
"domNodes": -282,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 131.14700000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1839999999938,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.50199999999995,
"heapDeltaBytes": -11738316,
"heapUsedBytes": 56494640,
"domNodes": 18,
"jsHeapTotalBytes": 21356544,
"scriptDurationMs": 118.89800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.0099999999593,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.863999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.99800000000005,
"heapDeltaBytes": -12031116,
"heapUsedBytes": 56152124,
"domNodes": 20,
"jsHeapTotalBytes": 22667264,
"scriptDurationMs": 120.768,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.1199999999767,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.28999999999996,
"heapDeltaBytes": 4393248,
"heapUsedBytes": 72349616,
"domNodes": 18,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 16.41,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.820999999898,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.584999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.96799999999996,
"heapDeltaBytes": 4870752,
"heapUsedBytes": 73108076,
"domNodes": 20,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 14.505,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.482999999991,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.525999999999996,
"layouts": 16,
"layoutDurationMs": 4.144,
"taskDurationMs": 816.5210000000001,
"heapDeltaBytes": -4607176,
"heapUsedBytes": 63529700,
"domNodes": 62,
"jsHeapTotalBytes": 21094400,
"scriptDurationMs": 97.476,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.6879999999255,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.14,
"layouts": 16,
"layoutDurationMs": 3.857,
"taskDurationMs": 799.945,
"heapDeltaBytes": -21346000,
"heapUsedBytes": 46787784,
"domNodes": -280,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 89.467,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.450999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.160999999999994,
"layouts": 15,
"layoutDurationMs": 12.108,
"taskDurationMs": 936.7229999999997,
"heapDeltaBytes": 3501464,
"heapUsedBytes": 75020572,
"domNodes": 13673,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 35.16799999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8360.416000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4574.014,
"heapDeltaBytes": 10111112,
"heapUsedBytes": 69386964,
"domNodes": -280,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 1414.3570000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8439.674999999967,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4721.526000000001,
"heapDeltaBytes": 9142336,
"heapUsedBytes": 68776472,
"domNodes": -283,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 1470.488,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17495.078000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17470.67,
"heapDeltaBytes": -56817600,
"heapUsedBytes": 167925464,
"domNodes": -8312,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 639.068,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17355.19899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17302.18,
"heapDeltaBytes": -51296384,
"heapUsedBytes": 167773972,
"domNodes": -8312,
"jsHeapTotalBytes": -13836288,
"scriptDurationMs": 593.2230000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21111.89399999995,
"styleRecalcs": 143,
"styleRecalcDurationMs": 18.617999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21071.267000000003,
"heapDeltaBytes": -55369376,
"heapUsedBytes": 154301212,
"domNodes": -8312,
"jsHeapTotalBytes": -11440128,
"scriptDurationMs": 956.0119999999998,
"eventListeners": -16383,
"totalBlockingTimeMs": 219,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20789.664000000015,
"styleRecalcs": 141,
"styleRecalcDurationMs": 18.127000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20744.821,
"heapDeltaBytes": -49557692,
"heapUsedBytes": 159041960,
"domNodes": -8312,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 913.631,
"eventListeners": -16383,
"totalBlockingTimeMs": 275,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 449.2150000000379,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.877000000000002,
"layouts": 3,
"layoutDurationMs": 0.696,
"taskDurationMs": 114.35299999999998,
"heapDeltaBytes": -15621576,
"heapUsedBytes": 51479776,
"domNodes": 130,
"jsHeapTotalBytes": 7200768,
"scriptDurationMs": 9.711,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 481.5849999999955,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.585,
"layouts": 3,
"layoutDurationMs": 0.65,
"taskDurationMs": 117.212,
"heapDeltaBytes": -16122636,
"heapUsedBytes": 50959480,
"domNodes": 119,
"jsHeapTotalBytes": 7987200,
"scriptDurationMs": 9.959,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.49 #14661 +/- ##
=============================================
Coverage ? 78.52%
=============================================
Files ? 1784
Lines ? 104055
Branches ? 31919
=============================================
Hits ? 81713
Misses ? 21912
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14578 to
cloud/1.49Automatically created by backport workflow.