Repository navigation
fix(ui): keep toast controls clickable above Reka modal dialogs - #14640
Conversation
Reka's modal mode sets pointer-events: none on the body via DismissableLayer. Toasts teleport to the body, so an open modal left them painted above the dialog but not hit-testable: a click on a toast's close button fell through to the dialog overlay underneath, which either swallowed it (pricing table) or dismissed the dialog (publishing flow). Opt toasts into the existing design-system pointer-events list, per message rather than on the .p-toast container so the empty space beside a toast stays an ordinary scrim click. Narrow the matching OUTSIDE_LAYER_SELECTORS entry to .p-toast-message for the same reason, and replace its stale rationale — the Settings focus-recovery case it described is now handled by dismissOnFocusOutside.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2191 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +186 kBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.85 kB) • 🔴 +43 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.46 MB) • 🔴 +7.63 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 132 kB) • 🔴 +3.48 kBTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 648 kB (baseline 638 kB) • 🔴 +9.54 kBConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed / 16 unchanged User & Accounts — 53.7 kB (baseline 37.9 kB) • 🔴 +15.8 kBAuthentication, profile, and account management bundles
Status: 13 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🟢 -92 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 185 kB (baseline 123 kB) • 🔴 +61.4 kBReusable component library chunks
Status: 18 added / 16 removed Data & Services — 4.16 MB (baseline 3.87 MB) • 🔴 +290 kBStores, services, APIs, and repositories
Status: 12 added / 14 removed / 2 unchanged Utilities & Hooks — 586 kB (baseline 575 kB) • 🔴 +10.9 kBHelpers, composables, and utility bundles
Status: 31 added / 31 removed / 7 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.4 MB) • 🟢 -179 kBExternal libraries and shared vendor chunks
Status: 10 added / 10 removed / 8 unchanged Other — 18.3 MB (baseline 17.8 MB) • 🔴 +494 kBBundles that do not match a named category
Status: 178 added / 174 removed / 127 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T02:07:57.468Z",
"gitSha": "d78fa1bf0ca2e7711c79255d036ba7cba067f502",
"branch": "glary/fe-1398-toast-clickable-over-modals",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.8619999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.186999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.48999999999995,
"heapDeltaBytes": 498636,
"heapUsedBytes": 67905768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.104999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.074000000027,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.593,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.7950000000001,
"heapDeltaBytes": 22384620,
"heapUsedBytes": 76367068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.716000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1737.5430000000165,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.866000000000001,
"layouts": 12,
"layoutDurationMs": 4.430999999999999,
"taskDurationMs": 662.628,
"heapDeltaBytes": -2956968,
"heapUsedBytes": 65198424,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 162.143,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.2780000000093,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.558,
"layouts": 12,
"layoutDurationMs": 4.554,
"taskDurationMs": 773.4,
"heapDeltaBytes": 19510036,
"heapUsedBytes": 73753072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.276,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.6600000000608,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.782,
"layouts": 6,
"layoutDurationMs": 1.0330000000000001,
"taskDurationMs": 340.624,
"heapDeltaBytes": 3256232,
"heapUsedBytes": 71063484,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.952999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.0060000000203,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.086000000000002,
"layouts": 6,
"layoutDurationMs": 1.4289999999999998,
"taskDurationMs": 326.95099999999996,
"heapDeltaBytes": 25326156,
"heapUsedBytes": 79300008,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.264999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 687.8449999999816,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.6939999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.40599999999995,
"heapDeltaBytes": -8061024,
"heapUsedBytes": 58739352,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 160.58800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.6890000000203,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.712,
"heapDeltaBytes": -8708432,
"heapUsedBytes": 59283248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.424,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1151.6229999999723,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.519,
"heapDeltaBytes": 38112608,
"heapUsedBytes": 107181648,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 64.10800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.6140000000423,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.049,
"heapDeltaBytes": 14424808,
"heapUsedBytes": 92813480,
"domNodes": 0,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 65.289,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.9470000000429,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.4479999999998,
"heapDeltaBytes": 17004328,
"heapUsedBytes": 118371912,
"domNodes": 0,
"jsHeapTotalBytes": 2101248,
"scriptDurationMs": 155.987,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.1360000000777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.2999999999995,
"heapDeltaBytes": 17645932,
"heapUsedBytes": 119493092,
"domNodes": 0,
"jsHeapTotalBytes": 2625536,
"scriptDurationMs": 162.32199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9321.65500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8511.600000000002,
"heapDeltaBytes": -9279292,
"heapUsedBytes": 68142184,
"domNodes": -142,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 7017.195,
"eventListeners": -74,
"totalBlockingTimeMs": 766,
"frameDurationMs": 32.91978798586573,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9917.06099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9085.869999999999,
"heapDeltaBytes": 1349224,
"heapUsedBytes": 81878880,
"domNodes": 0,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 7544.86,
"eventListeners": 0,
"totalBlockingTimeMs": 1028,
"frameDurationMs": 32.67194719471947,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9719.419999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8990.085,
"heapDeltaBytes": 268372,
"heapUsedBytes": 80274512,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 7490.21,
"eventListeners": 0,
"totalBlockingTimeMs": 1072,
"frameDurationMs": 33.6204152249135,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9357.590999999957,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8621.303999999998,
"heapDeltaBytes": 7896336,
"heapUsedBytes": 86250264,
"domNodes": -142,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 7143.290999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1023,
"frameDurationMs": 33.037455830388694,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2055.7529999999247,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.3309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.099,
"heapDeltaBytes": -53851464,
"heapUsedBytes": 71937124,
"domNodes": -348,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 35.187000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.4549999999854,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.730000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.40799999999996,
"heapDeltaBytes": -52971036,
"heapUsedBytes": 72298204,
"domNodes": -328,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 29.320999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2324.8419999999896,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1567.2100000000003,
"heapDeltaBytes": -60785700,
"heapUsedBytes": 65898144,
"domNodes": -328,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 819.2239999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785611510791366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.7530000000334,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1467.1529999999998,
"heapDeltaBytes": 877808,
"heapUsedBytes": 64352912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.123,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3604.7430000000986,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.072999999999999,
"layouts": 60,
"layoutDurationMs": 14.155,
"taskDurationMs": 1665.8009999999997,
"heapDeltaBytes": -20317048,
"heapUsedBytes": 70180140,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 803.03,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3586.2489999999525,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.825999999999999,
"layouts": 60,
"layoutDurationMs": 13.979,
"taskDurationMs": 1606.473,
"heapDeltaBytes": 1587840,
"heapUsedBytes": 69195140,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 763.258,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604651162791,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3108.298999999988,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1811.6080000000002,
"heapDeltaBytes": 3819984,
"heapUsedBytes": 72181484,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 939.2980000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675672,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3014.2809999999827,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.668999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1788.42,
"heapDeltaBytes": 3287616,
"heapUsedBytes": 68118704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 931.236,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759217877094976,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2016.958000000045,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.200999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.8810000000001,
"heapDeltaBytes": -9868140,
"heapUsedBytes": 79770892,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 29.333000000000013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.0369999999875,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6190000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.28799999999995,
"heapDeltaBytes": -10042656,
"heapUsedBytes": 78258960,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.02200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.5179999999473,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.613,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.046,
"heapDeltaBytes": -11960536,
"heapUsedBytes": 57689860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.462,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.8999999999778,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.563999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.86400000000003,
"heapDeltaBytes": -12581028,
"heapUsedBytes": 57196092,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.18099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.401000000002,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.18800000000005,
"heapDeltaBytes": 436768,
"heapUsedBytes": 69680928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.661000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.8100000000159,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.386000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.45199999999994,
"heapDeltaBytes": 683456,
"heapUsedBytes": 69986068,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.233000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.9070000000006,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.473000000000003,
"layouts": 16,
"layoutDurationMs": 6.024,
"taskDurationMs": 756.0609999999999,
"heapDeltaBytes": -6609784,
"heapUsedBytes": 62942108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.95699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.541999999913,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.165,
"layouts": 16,
"layoutDurationMs": 4.978,
"taskDurationMs": 706.0029999999999,
"heapDeltaBytes": 15229596,
"heapUsedBytes": 69769900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.89800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.204000000036,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.369,
"layouts": 5,
"layoutDurationMs": 13.055000000000003,
"taskDurationMs": 946.8480000000002,
"heapDeltaBytes": 23941360,
"heapUsedBytes": 109630556,
"domNodes": 13747,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 33.50100000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 134,
"frameDurationMs": 19.368918918918908,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.262999999963,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.65899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5535.713,
"heapDeltaBytes": 9909284,
"heapUsedBytes": 97416820,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2802.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699203187250998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8426.424999999996,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5452.539,
"heapDeltaBytes": -34197912,
"heapUsedBytes": 90810664,
"domNodes": -328,
"jsHeapTotalBytes": -1216512,
"scriptDurationMs": 2637.0339999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665940594059407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17187.84400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16438.969,
"heapDeltaBytes": -34393180,
"heapUsedBytes": 165630120,
"domNodes": -3045,
"jsHeapTotalBytes": 5177344,
"scriptDurationMs": 266.893,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.123220338983053,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17231.60400000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16619.725000000002,
"heapDeltaBytes": -27405628,
"heapUsedBytes": 172545936,
"domNodes": -3045,
"jsHeapTotalBytes": 5439488,
"scriptDurationMs": 266.51599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.229202037351442,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21104.44099999995,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20716.674,
"heapDeltaBytes": -26018840,
"heapUsedBytes": 196146712,
"domNodes": -3045,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 923.581,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 38.856721915285455,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 21024.303000000033,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.38300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20667.321,
"heapDeltaBytes": -39187396,
"heapUsedBytes": 169550124,
"domNodes": -3049,
"jsHeapTotalBytes": 8990720,
"scriptDurationMs": 852.158,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 38.45063985374771,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6315.503000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.62799999999997,
"layouts": 20,
"layoutDurationMs": 24.46899999999999,
"taskDurationMs": 6201.452999999999,
"heapDeltaBytes": 2259572,
"heapUsedBytes": 210379760,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.378,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.597619047619034,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6332.708999999909,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.35000000000001,
"layouts": 20,
"layoutDurationMs": 26.68100000000001,
"taskDurationMs": 6223.3099999999995,
"heapDeltaBytes": 7478064,
"heapUsedBytes": 209729744,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 106.55099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.473964497041436,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8898.212000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8583.418999999998,
"heapDeltaBytes": -31341668,
"heapUsedBytes": 178425076,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 149.64300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.374061433447093,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8901.314999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8604.281,
"heapDeltaBytes": -34247988,
"heapUsedBytes": 179343372,
"domNodes": -3045,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.65699999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.582817869415816,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 185.196000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.010000000000005,
"layouts": 4,
"layoutDurationMs": 2.3480000000000003,
"taskDurationMs": 171.754,
"heapDeltaBytes": -48989116,
"heapUsedBytes": 53064332,
"domNodes": 123,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 10.953999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 121.27199999997629,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.377000000000002,
"layouts": 3,
"layoutDurationMs": 1.013,
"taskDurationMs": 84.24000000000001,
"heapDeltaBytes": 3735004,
"heapUsedBytes": 69360380,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.933000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66249999999991,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 909.6839999999702,
"styleRecalcs": 78,
"styleRecalcDurationMs": 104.698,
"layouts": 76,
"layoutDurationMs": 26.003,
"taskDurationMs": 869.6819999999999,
"heapDeltaBytes": 17838044,
"heapUsedBytes": 83960324,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 355.483,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 883.5759999999482,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.904,
"layouts": 76,
"layoutDurationMs": 25.937,
"taskDurationMs": 853.522,
"heapDeltaBytes": 17812476,
"heapUsedBytes": 88318164,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 350.242,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1399.487000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 260.904,
"layouts": 76,
"layoutDurationMs": 28.788,
"taskDurationMs": 1376.4319999999998,
"heapDeltaBytes": -19285408,
"heapUsedBytes": 107758056,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 460.541,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1430.6169999999838,
"styleRecalcs": 78,
"styleRecalcDurationMs": 264.352,
"layouts": 76,
"layoutDurationMs": 29.023,
"taskDurationMs": 1403.006,
"heapDeltaBytes": 8809980,
"heapUsedBytes": 114913768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 470.385,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493814,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14640.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-d3zgb6fme-comfyui.vercel.app Last updated: 2026-10-03T01:55:48Z for 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9578eb328c6015d90f77e15da29d71d15a05bec3
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughPrimeVue toast messages now count as dialog overlays, but empty space in the toast container does not. Tests cover pointer dismissal, focus handling, and dismissal of a toast while the pricing dialog remains open. ChangesToast interaction in dialogs
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Toast controls remain interactive above dialogs while empty toast-container space retains outside-click behavior. The supplied tests cover these interactions, and no concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.13)packages/design-system/src/css/style.cssFile contains syntax errors that prevent linting: Line 9: Tailwind-specific syntax is disabled.; Line 11: Tailwind-specific syntax is disabled.; Line 13: Tailwind-specific syntax is disabled.; Line 16: Tailwind-specific syntax is disabled.; Line 19: Tailwind-specific syntax is disabled.; Line 21: Tailwind-specific syntax is disabled.; Line 23: Tailwind-specific syntax is disabled.; Line 424: Tailwind-specific syntax is disabled.; Line 579: Tailwind-specific syntax is disabled.; Line 585: Tailwind-specific syntax is disabled.; Line 593: Tailwind-specific syntax is disabled.; Line 599: Tailwind-specific syntax is disabled.; Line 614: Tailwind-specific syntax is disabled.; Line 1869: Tailwind-specific syntax is disabled. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts`:
- Around line 539-543: Scope the toast locator in the dialog pricing deep-link
test to the injected error toast by filtering on its unique detail text, rather
than matching all error toasts. Within that scoped toast, locate and click the
close button by its accessible name, then retain the retry-safe count assertion
for that specific toast.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: af1023e6-e2af-4356-a568-8c37e5769a0a
📒 Files selected for processing (4)
browser_tests/tests/dialogs/pricingTableDeepLink.spec.tspackages/design-system/src/css/style.csssrc/components/dialog/GlobalDialog.test.tssrc/components/dialog/rekaPrimeVueBridge.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14640 +/- ##
==========================================
- Coverage 84.82% 84.81% -0.01%
==========================================
Files 3437 3437
Lines 165255 165255
Branches 43140 47433 +4293
==========================================
- Hits 140171 140165 -6
- Misses 23127 23133 +6
Partials 1957 1957
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Filter the toast by its detail text instead of matching every error toast, and share the detail string between the injection and the locator so they cannot drift.
|
Pushed
That Re-verified after the change: still fails without the fix ( @christian-byrne your approval was auto-dismissed by the push — re-approval needed when you get a chance. |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
|
The one actionable finding from the 08-04 review — scoping the toast locator in @christian-byrne approved on 08-25. I've just updated the branch from @coderabbitai review |
|
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit!
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
…lickable-over-modals # Conflicts: # browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts
129ffee
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 129ffee2c497937f673f80ff691caaa32a254b41.
Full context for agent readers
The narrowed .p-toast-message selector keeps toast controls hit-testable without turning empty toast-container space into an interaction sink. The dialog bridge and regression coverage preserve the underlying modal while dismissing the toast. Hosted CI is settled green, CodeRabbit approves the current head, and no review threads remain open.
PR Created by the Glary-Bot Agent
Supersedes #14448 (same root cause, moved to the canonical location and narrowed; that PR can be closed).
What
Reka's modal mode sets
pointer-events: noneon<body>viaDismissableLayer/useBodyScrollLock. Toasts teleport to<body>, so an open modal left them painted above the dialog (toast isz-index: 10000, dialogs are1700+) but not hit-testable — the click fell through to the dialog overlay underneath.That single cause produced both reported symptoms:
dismissableMask: false): the overlay swallowed the click, so the toast X did nothing.The repro is exact — before this change Playwright reports the click as intercepted:
Changes
packages/design-system/src/css/style.css— add toasts to the pointer-events opt-in list that already exists for the other body-portaled PrimeVue overlays (Select / ColorPicker / Popover / Autocomplete), same block, same rationale.src/components/dialog/rekaPrimeVueBridge.ts— narrow theOUTSIDE_LAYER_SELECTORSentry from.p-toastto.p-toast-messageand replace its stale rationale.Both use
.p-toast-messagerather than the.p-toastcontainer: the container spans the whole stack including the1remmargin between messages, so opting in there would make invisible empty space swallow scrim clicks. Scoping to the message keeps the interactive region and the "treated as inside" region identical.On the
OUTSIDE_LAYER_SELECTORShalf of FE-1398 — the entry is narrowed, not removed. Its original justification (Settings focus-recovery) did go stale oncedismissOnFocusOutside: falselanded in #13510/#14024, but the entry is now load-bearing for a different reason: with toasts actually clickable again, it is what stops a toast dismissal from taking the dialog underneath with it. Removing it would reintroduce the publishing-flow symptom, so the comment is corrected instead.Tests
pricingTableDeepLink.spec.ts— new E2E: open "Choose a Plan", raise an error toast, click its X; asserts the toast closes and the dialog survives. Verified to fail on the unfixed tree with the interception error above, and pass after.GlobalDialog.test.ts—p-toast-messageadded to the pointer-down and focus-outside guard lists, plus a case asserting a pointer-down on the bare.p-toastcontainer still dismisses. All three fail against the old.p-toastselector.Verification
DISTRIBUTION=clouddev server).pricingTableDeepLink.spec.tscloud suite: 16/16 passed.pnpm test:unit: 14720 passed; 3 pre-existing failures (previewAny,onboardingCloudRoutes,GraphView) confirmed to fail identically on a clean tree.pnpm typecheck,pnpm typecheck:browser, oxlint, eslint, stylelint,pnpm format:check: all clean.Screenshots