Repository navigation
refactor(workspace): retire team workspace rollout flag - #14613
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe change removes ChangesCloud billing, authentication, and workspace UI
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1788 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.25 MB gzip 🟢 -7.66 kBDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • 🟢 -169 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 540 kB (baseline 552 kB) • 🟢 -11.8 kBConfiguration panels, inspectors, and settings screens
Status: 11 added / 12 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 71 kB (baseline 72.1 kB) • 🟢 -1.13 kBReusable component library chunks
Status: 6 added / 7 removed / 8 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🟢 -2.29 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 387 kB) • 🟢 -806 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🟢 -1.74 kBBundles that do not match a named category
Status: 69 added / 72 removed / 212 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T13:41:38.653Z",
"gitSha": "ec1750bc40d9fac964b47546a68ace296b860487",
"branch": "dante/retire-team-workspace-flag",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2028.507999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.99800000000005,
"heapDeltaBytes": 5649700,
"heapUsedBytes": 69682908,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.586999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.0849999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.233,
"heapDeltaBytes": 5637912,
"heapUsedBytes": 69813460,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.741000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.8479999999663,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.937999999999995,
"layouts": 12,
"layoutDurationMs": 3.456,
"taskDurationMs": 866.4739999999999,
"heapDeltaBytes": -13702220,
"heapUsedBytes": 50343976,
"domNodes": -279,
"jsHeapTotalBytes": 24096768,
"scriptDurationMs": 120.616,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.7290000000548,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.29,
"layouts": 12,
"layoutDurationMs": 6.239,
"taskDurationMs": 881.571,
"heapDeltaBytes": -82848,
"heapUsedBytes": 63916484,
"domNodes": 62,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 123.18200000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.1750000000447,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.502,
"layouts": 6,
"layoutDurationMs": 0.576,
"taskDurationMs": 367.17100000000005,
"heapDeltaBytes": 8629336,
"heapUsedBytes": 72759260,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 16.898,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.734000000074,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.707,
"layouts": 6,
"layoutDurationMs": 0.682,
"taskDurationMs": 373.933,
"heapDeltaBytes": 8701972,
"heapUsedBytes": 72651144,
"domNodes": 76,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 17.715,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.2509999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.239000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.61,
"heapDeltaBytes": -10966316,
"heapUsedBytes": 53059428,
"domNodes": 14,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.410000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 605.4599999999937,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.6099999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.98199999999997,
"heapDeltaBytes": -10897056,
"heapUsedBytes": 53116544,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.9450000000215,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.987,
"heapDeltaBytes": 7359752,
"heapUsedBytes": 66040744,
"domNodes": -280,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 104.86700000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2049.3880000000217,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.908,
"heapDeltaBytes": 6837264,
"heapUsedBytes": 66485724,
"domNodes": -284,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 102.35600000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2192.4830000000384,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.158999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.0370000000003,
"heapDeltaBytes": 6675064,
"heapUsedBytes": 67627984,
"domNodes": -283,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 424.896,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.659999999937,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.838000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1290.6680000000001,
"heapDeltaBytes": 2062036,
"heapUsedBytes": 62458068,
"domNodes": -283,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 442.09700000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3233.6139999999887,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.878,
"layouts": 60,
"layoutDurationMs": 7.405,
"taskDurationMs": 1569.146,
"heapDeltaBytes": -1132100,
"heapUsedBytes": 60906120,
"domNodes": -287,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 542.227,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.398000000082,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.252,
"layouts": 60,
"layoutDurationMs": 7.311,
"taskDurationMs": 1518.246,
"heapDeltaBytes": -2203240,
"heapUsedBytes": 59570240,
"domNodes": -287,
"jsHeapTotalBytes": 6135808,
"scriptDurationMs": 534.969,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2029.6849999999722,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.710000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.2369999999999,
"heapDeltaBytes": 6533064,
"heapUsedBytes": 67128576,
"domNodes": -282,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 104.33300000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.5029999999952,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.392000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.606,
"heapDeltaBytes": 6220732,
"heapUsedBytes": 66664476,
"domNodes": -284,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 98.276,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.0819999999103,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.665000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.347,
"heapDeltaBytes": -10432296,
"heapUsedBytes": 53716948,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 131.20900000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.1610000000182,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.879,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.986,
"heapDeltaBytes": -10372412,
"heapUsedBytes": 53788536,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 117.37100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.4229999999643,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.422999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.43299999999994,
"heapDeltaBytes": 5137536,
"heapUsedBytes": 69286320,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 12.097000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.6409999999596,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.63700000000006,
"heapDeltaBytes": 5062480,
"heapUsedBytes": 69305828,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 12.219000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.0129999999463,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.818,
"layouts": 16,
"layoutDurationMs": 4.033,
"taskDurationMs": 783.8889999999999,
"heapDeltaBytes": -17409168,
"heapUsedBytes": 46628576,
"domNodes": -279,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 89.032,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1682.7829999999722,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.145999999999994,
"layouts": 16,
"layoutDurationMs": 3.942,
"taskDurationMs": 762.749,
"heapDeltaBytes": -4278124,
"heapUsedBytes": 59935824,
"domNodes": 63,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 88.744,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1000000000422,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.335999999999988,
"layouts": 16,
"layoutDurationMs": 12.613,
"taskDurationMs": 921.252,
"heapDeltaBytes": 29139632,
"heapUsedBytes": 97306808,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 33.690999999999995,
"eventListeners": 2375,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8266.622999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.425,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4458.112999999999,
"heapDeltaBytes": 8854792,
"heapUsedBytes": 68237184,
"domNodes": -281,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 1378.129,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.563999999958,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.892,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4464.5160000000005,
"heapDeltaBytes": 11362992,
"heapUsedBytes": 71004776,
"domNodes": -280,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1410.3999999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17037.20300000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17014.236999999997,
"heapDeltaBytes": -59173164,
"heapUsedBytes": 166603956,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 543.233,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16792.06799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16771.603000000003,
"heapDeltaBytes": -38658164,
"heapUsedBytes": 165717712,
"domNodes": -8316,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 542.67,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20592.57200000002,
"styleRecalcs": 141,
"styleRecalcDurationMs": 15.42400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20524.527,
"heapDeltaBytes": -47609264,
"heapUsedBytes": 178350040,
"domNodes": -8312,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 861.8100000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 151,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21094.813000000046,
"styleRecalcs": 144,
"styleRecalcDurationMs": 17.367000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21036.598,
"heapDeltaBytes": -58417236,
"heapUsedBytes": 166204828,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 902.551,
"eventListeners": -16383,
"totalBlockingTimeMs": 311,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 159.27699999997458,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.541999999999998,
"layouts": 3,
"layoutDurationMs": 0.7769999999999999,
"taskDurationMs": 106.509,
"heapDeltaBytes": 3424828,
"heapUsedBytes": 66564572,
"domNodes": 122,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.7059999999999995,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.9860000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.006,
"layouts": 3,
"layoutDurationMs": 0.599,
"taskDurationMs": 110.893,
"heapDeltaBytes": 5073652,
"heapUsedBytes": 68303400,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.822000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14613 +/- ##
==========================================
- Coverage 78.68% 78.68% -0.01%
==========================================
Files 1801 1801
Lines 106948 106868 -80
Branches 29763 30617 +854
==========================================
- Hits 84155 84085 -70
+ Misses 22337 22328 -9
+ Partials 456 455 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
This is the one-way step in the stack, and the code change itself is clean: the flags.teamWorkspacesEnabled to isCloud substitution is mechanical and I could not find a call site that was missed. My concern is the precondition, not the diff, which is why the first inline comment is marked blocking.
Cross-service coordination, restated here because it does not belong on a line: the backend counterpart Comfy-Org/cloud#6040 removes both flags from common/featuregates/flags.go, but its body pins the dependency to #14530, a competing single-PR implementation of this same retirement, not to this stack. No comment on either PR reconciles the two efforts, and one of them has to be closed before the backend can land. flags.go also carries the BE-119 governance rule forbidding removal from AllFlags/FrontendFlags without confirming no current frontend release reads the key, added after cloud#3171 removed frontend-consumed flags prematurely and had to be reverted by #3227/#3228. I have not been able to verify the current rollout percentage of team_workspaces_enabled from this repo; that number is what decides whether the gate change is a no-op or a lockout for a real cohort.
Rebase note: 681fe2fc47 (#14605) landed on main after this branch point and rewrote creditsTile.spec.ts's mockCloudBoot usage plus the 3DS Confirm / Pay / Back-disabled assertions. Resolving that file in favour of the branch would drop FE-1494's coverage with green CI. Keep #14605's mockCloudBoot(page) swap and strip only the retired keys from its /api/features payload.
4c3b97a to
fa8e875
Compare
64b10c6 to
d718236
Compare
Stack status after the review round, and what is still owned by a human@dante01yoon you have addressed essentially everything actionable in the code, and I verified each fix against the branch heads rather than the thread state. Confirmed fixed: the config-refresh race, the sign-out escape now going through Putting the remainder in one place because it is the kind that gets lost in resolved threads and unassigned issues. 1. Blocking, and not a code change@huntcsg this is the one that needs you. Two things before this stack can merge:
Until both are answered the frontend is deployable but the backend removal is not safe to schedule. 2. Follow-up issue that needs an owner#14645 covers consolidating the 3. Small residuals, none blocking, all verified at the current headsRecorded so they are not lost when the threads scroll away.
4. CI note on #14615The |
|
Follow-up tracking for this stack. Every item from the review round now has its own issue with an owner, so nothing depends on a single thread staying visible. Blocking the stack, owned by @huntcsg
Non-blocking, owned by @dante01yoon
Also raised on Comfy-Org/cloud#6040 and on #14530 so both sides of the duplicate-effort collision can see each other. Nothing in this list blocks #14612, #14614 or #14615 on code grounds. #14738 is the only merge gate, and it is a coordination answer rather than a change. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. The flag substitution is mechanical and I could not find a call site that was missed; a full-tree search for the retired key returns nothing across src, browser_tests, storybook mocks and fixtures.
The blocking question on this PR is answered: I confirmed offline that team_workspaces_enabled is at 100 percent for every authenticated Cloud identity, which is the BE-119 confirmation the thread was waiting on. With no gated cohort remaining, substituting the compile-time isCloud for the flag read cannot strand anyone.
The coverage regression I raised is fixed correctly. authTokenPriority.test.ts now sets mockDistributionTypes.isCloud = true explicitly in beforeEach and adds ignores workspace auth header outside Cloud, which mocks a present workspace header, sets isCloud = false, and asserts the Firebase token wins. That is the deleted property restored against the surviving guard rather than against the retired flag.
Two non-blocking leftovers remain tracked as issues and are not merge concerns: the now-dead useFirebaseToken plumbing in useSessionCookie (#14740) and the 'subscription' settings leftovers plus two components kept alive only by their own tests (#14741).
What is still open is backend sequencing, not this diff: Comfy-Org/cloud#6040 still pins to a competing frontend PR, tracked in #14738.
dceae6f to
1585931
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/platform/auth/session/useSessionCookie.ts (1)
85-109: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove unreachable session-mode plumbing.
All public session-creation methods return before
establishSessionwhenisCloudis false. Therefore,usesFirebaseTokenis alwaystrueon every reachable call. The non-Firebase header path and the conditional join check are dead code.Remove
useFirebaseToken,usesFirebaseToken, and the weaker-request branch. Use Firebase session creation directly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/auth/session/useSessionCookie.ts` around lines 85 - 109, Remove the unreachable session-mode branching in useSessionCookie’s session-creation flow: since the public entry points never reach establishSession with isCloud false, delete useFirebaseToken and usesFirebaseToken, and update the create-session path to always use Firebase session creation. Also remove the conditional in-flight join check tied to usesFirebaseToken in the inFlightCreateSession.ownerUid block, and keep the existing ownerUid/sessionMutationTail sequencing intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/currentUserPopoverCredits.spec.ts`:
- Around line 57-58: Correct the billing-route comments in the
personal-workspace fixture to reflect that the empty mockRemoteConfig leaves
consolidatedBillingEnabled false, so requests use the legacy /customers/* route.
Remove unused workspace mocks, or instead enable consolidated_billing_enabled
and update the fixture to exercise the /api/billing/* workspace route, ensuring
routing remains gated solely by consolidatedBillingEnabled.
In `@src/platform/settings/composables/useSettingUI.test.ts`:
- Around line 343-347: Extend the OSS navigation test in useSettingUI to assert
that navKeys(navGroups.value) does not contain workspace, while retaining the
existing credits assertion. This verifies the legacy layout excludes workspace
navigation.
In `@src/platform/settings/composables/useSettingUI.ts`:
- Line 430: The Cloud sidebar path in groupedMenuTreeNodes now points only to
workspaceMenuTreeNodes, but subscriptionPanel is still attached to
legacyMenuTreeNodes, making it unreachable for Cloud users. Update the
useSettingUI flow so subscriptionPanel is added to workspaceMenuTreeNodes, or
remove subscriptionPanel together with its related visibility computeds if it is
no longer needed; keep the groupedMenuTreeNodes selection behavior consistent
with the intended panel location.
---
Outside diff comments:
In `@src/platform/auth/session/useSessionCookie.ts`:
- Around line 85-109: Remove the unreachable session-mode branching in
useSessionCookie’s session-creation flow: since the public entry points never
reach establishSession with isCloud false, delete useFirebaseToken and
usesFirebaseToken, and update the create-session path to always use Firebase
session creation. Also remove the conditional in-flight join check tied to
usesFirebaseToken in the inFlightCreateSession.ownerUid block, and keep the
existing ownerUid/sessionMutationTail sequencing intact.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1254bc98-3fd4-44f4-913f-8d93bfe98c9e
📒 Files selected for processing (45)
browser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/data/cloudWorkspace.tsbrowser_tests/fixtures/data/workspaceSwitcher.tsbrowser_tests/fixtures/helpers/CloudWorkspaceMockHelper.tsbrowser_tests/fixtures/utils/cloudAppSetup.tsbrowser_tests/fixtures/utils/cloudBootMocks.tsbrowser_tests/tests/authAccountSwitch.spec.tsbrowser_tests/tests/billingFacadeConsumers.spec.tsbrowser_tests/tests/currentUserPopoverCredits.spec.tsbrowser_tests/tests/dialogs/creditsTile.spec.tsbrowser_tests/tests/dialogs/pricingTableDeepLink.spec.tssrc/components/topbar/CurrentUserButton.test.tssrc/components/topbar/CurrentUserButton.vuesrc/composables/billing/useBillingContext.test.tssrc/composables/billing/useBillingContext.tssrc/composables/billing/useBillingRouting.test.tssrc/composables/billing/useBillingRouting.tssrc/composables/useFeatureFlags.test.tssrc/composables/useFeatureFlags.tssrc/composables/useUrlActionLoaders.test.tssrc/composables/useUrlActionLoaders.tssrc/platform/auth/session/useSessionCookie.test.tssrc/platform/auth/session/useSessionCookie.tssrc/platform/remoteConfig/refreshRemoteConfig.tssrc/platform/remoteConfig/remoteConfig.tssrc/platform/remoteConfig/types.tssrc/platform/settings/composables/useSettingUI.test.tssrc/platform/settings/composables/useSettingUI.tssrc/platform/settings/composables/useSettingsDialog.test.tssrc/platform/settings/composables/useSettingsDialog.tssrc/platform/workspace/auth/WorkspaceAuthGate.test.tssrc/platform/workspace/auth/WorkspaceAuthGate.vuesrc/platform/workspace/components/SubscriptionCheckoutSteps.stories.tssrc/platform/workspace/components/SubscriptionSuccessWorkspace.test.tssrc/platform/workspace/components/SubscriptionSuccessWorkspace.vuesrc/platform/workspace/components/UnifiedPricingTable.stories.tssrc/platform/workspace/components/UnifiedPricingTable.test.tssrc/platform/workspace/components/UnifiedPricingTable.vuesrc/platform/workspace/stores/useWorkspaceAuth.test.tssrc/platform/workspace/stores/workspaceAuthStore.tssrc/stores/__tests__/authTokenPriority.test.tssrc/stores/authStore.test.tssrc/stores/authStore.tssrc/storybook/mocks/useFeatureFlags.tssrc/utils/devFeatureFlagOverride.ts
💤 Files with no reviewable changes (11)
- browser_tests/fixtures/utils/cloudAppSetup.ts
- src/platform/workspace/components/SubscriptionSuccessWorkspace.test.ts
- src/platform/remoteConfig/types.ts
- src/components/topbar/CurrentUserButton.test.ts
- src/platform/remoteConfig/refreshRemoteConfig.ts
- src/composables/useFeatureFlags.ts
- src/composables/useFeatureFlags.test.ts
- src/stores/authStore.test.ts
- src/platform/workspace/stores/useWorkspaceAuth.test.ts
- browser_tests/fixtures/data/workspaceSwitcher.ts
- src/platform/workspace/components/UnifiedPricingTable.test.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019fc8cd-b288-7161-a590-cd76d51212bf Co-authored-by: Amp <amp@ampcode.com>
|
Addressed the outside-diff |
christian-byrne
left a comment
There was a problem hiding this comment.
Re-approving at 8441cf2474. My previous approval was dismissed by the rebase, so I re-read the diff rather than assume it carried.
The PR's own change against the new main is 45 files, +290/-749, against the 45 files / +281/-723 I approved before. The delta is the three commits added since, and I checked each:
a752303e20 test(auth): cover non-cloud token prioritycloses #14739.authTokenPriority.test.tsnow pinsmockDistributionTypes.isCloud = trueinbeforeEachand addsignores workspace auth header outside Cloud, which mocks a present workspace header, flipsisCloudfalse, and asserts the Firebase token wins. That is the deleted property restored against the surviving guard rather than the retired flag.8441cf2474 fix(workspace): remove retired routing leftoverscloses #14740 and #14741.getSessionHeaderOrThrowloses its unreachableuseFirebaseTokenparameter and the deadauthStore.getAuthHeader()fallback,usesFirebaseTokencomes offInFlightCreateSession, and the single-flight join reduces to the ownerUid match. That is correct: every reachable caller now mints a Firebase-backed session, so joining an in-flight request can no longer inherit a weaker credential. ADR-0011 invariant 4 is preserved, and the ambiguity that made the old assertion vacuous is gone. The deadsubscriptionsettings computeds are removed too.15859318fd test(billing): align fixtures with current status contractis a two-line fixture alignment.
Repo-wide search for team_workspaces_enabled and teamWorkspacesEnabled across src/ and browser_tests/ still returns zero. CI is 51 passed, 0 failed.
The rollout precondition is answered: I confirmed offline that both flags are at 100 percent. What remains is backend sequencing in #14738, not this diff.
|
|
Rebased onto main after #14613 landed as a squash commit. One conflict, in performFetchSubscriptionStatus. main's #12826 converged error parsing on parseErrorResponse(response); this PR removes that raw fetch path in favour of workspaceApi.getBillingStatus(). Resolved in favour of this PR because workspaceApi's handleAxiosError already runs errorResponseFromBody, the same canonical parsing #12826 introduced, so the intent is preserved at the axios layer. parseErrorResponse is still used elsewhere in the file, so the import stays. Verified after rebase: 17 files / +439 / -336, identical to the reviewed diff; pnpm typecheck clean; 45 test files and 762 tests pass across platform/cloud/subscription, composables/billing and workspace/composables. Co-Authored-By: dante01yoon <bunggl@naver.com>
Rebased onto the rebased #14614 after #14613 landed as a squash commit. Applied with no conflicts. Verified after rebase: 14 files / +20 / -130, matching the reviewed change; zero remaining references to consolidated_billing_enabled or consolidatedBillingEnabled across src/ and browser_tests/; pnpm typecheck clean; 5 test files and 105 tests pass across composables/billing, useFeatureFlags and platform/remoteConfig. Co-Authored-By: dante01yoon <bunggl@naver.com>
RemoteConfig no longer has this field after #14613 retired the team workspace rollout flag, which broke typecheck:browser in CI.
…xture RemoteConfig no longer has this field (removed in #14613), so the fixture failed vue-tsc's browser typecheck (TS2353). Cloud workspace features are unconditional now, so the mock can be an empty object.
- Select the nudge and its controls by role/accessible name instead of data-testid, and assert cooldown with toBeDisabled(). - Drop the @/i18n mock so the composable tests exercise real translation key resolution. - Run the shared composable inside an effectScope stopped after each test so its window focus listener does not leak across tests. - Use fake timers for the whole resend suite and clear pending timers on teardown. - Cover the focus-triggered refresh after dismissal and the concurrent refresh guard. - Cover emailVerificationNudgeEnabled resolution in useFeatureFlags. Also drop the retired team_workspaces_enabled key from the workspace auth E2E fixture: #14613 removed it from RemoteConfig after #12940 was written, so typecheck:browser fails on main and on every PR that merges it.
…xture RemoteConfig no longer has this field (removed in #14613), so the fixture failed vue-tsc's browser typecheck (TS2353). The flag is unused elsewhere in the repo; team workspace features are gated on workspace type, not this remote-config field.
RemoteConfig no longer has this field (removed in #14613), which broke pnpm typecheck:browser on main.
Part 4/4 of the workspace and billing rollout retirement stack. Predecessor: [#14614](#14614) Successor: none (final stack PR) ## Summary Retires `consolidated_billing_enabled` after canonical billing discovery and explicit rail preservation landed in [#14614](#14614). Loaded Cloud workspaces now use unified pricing, while personal workspaces on `legacy_stripe` retain legacy account operations. ## Root cause The final billing route still depended on a compatibility feature key even after the workspace billing contract and canonical rail status were available. Removing the backend key first would therefore change personal-workspace routing during bootstrap or strand legacy Stripe balance/top-up/management behavior. The frontend needs a deterministic route based on distribution, workspace readiness/type, and the canonical billing rail before backend compatibility keys disappear. ## Changes - Removes the consolidated-billing key from remote-config types, enum/getter, authenticated cache/refresh, local override path, Storybook mocks, and browser payloads. - Routes OSS and unloaded Cloud workspaces through legacy bootstrap. - Routes loaded Cloud team workspaces and personal `unknown`/`stripe` rails through workspace billing. - Preserves legacy account operations for personal `legacy_stripe` while keeping unified pricing for every loaded Cloud workspace. - Keeps the legacy adapter, balance, top-up, management behavior, and meaningful regression coverage. - Re-runs the canonical-status rail regression with both retired feature keys absent from `/api/features`. ## AS IS A loaded Cloud personal workspace still consults `consolidated_billing_enabled` to decide its billing adapter and pricing route. No intended visual change. This is rollout cleanup, so no screenshot is required. ## TO BE Loaded Cloud workspaces use unified pricing without a rollout key. Canonical `billing_rail` determines whether personal account operations remain on `legacy_stripe`; team and migrated/unknown personal workspaces use workspace billing. No intended visual change. The existing legacy rail UI remains available where the canonical status selects it. ## Regression coverage - OSS and unloaded-workspace legacy bootstrap. - Cloud team workspace billing. - Cloud personal unknown/Stripe workspace billing. - Cloud personal `legacy_stripe` legacy account operations plus unified pricing. - Billing-context adapter switching and preserved legacy adapter behavior. - Playwright avatar-popover rail selection with `/api/features` omitting both retired keys, canonical status discovery, legacy balance/credits, and no stale workspace zero balance. - Repository search confirms no consolidated-flag symbol/string remains in `src` or `browser_tests`. ## Validation - `pnpm test:unit src/composables/useFeatureFlags.test.ts src/composables/billing/useBillingRouting.test.ts src/composables/billing/useBillingContext.test.ts src/platform/remoteConfig/refreshRemoteConfig.test.ts` — 83 passed. - `pnpm typecheck` — passed. - `pnpm typecheck:browser` — passed. - Targeted oxfmt/oxlint/ESLint commit checks — passed. - `pnpm knip --cache` pre-push check — passed. - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5174 pnpm test:browser browser_tests/tests/billingFacadeConsumers.spec.ts -g 'avatar popover'` — 1 passed. - `git diff --check dante/canonical-billing-status...HEAD` — passed. ## Review focus Please review only this PR's removal of the consolidated flag and the final routing matrix. Canonical endpoint migration and pending-checkout stabilization belong to [#14614](#14614); workspace-flag retirement belongs to [#14613](#14613). ## Stack/deployment order 1. [#14612](#14612) — workspace initialization recovery 2. [#14613](#14613) — retire team workspace rollout flag 3. [#14614](#14614) — canonical billing status and legacy rail preservation 4. [#14615](#14615) — this PR; retire consolidated billing rollout flag Deploy the frontend stack in this order before the backend removes the `/api/features` compatibility keys. Each branch remains independently deployable; do not deploy a later PR without its predecessor. This is also a drain requirement: age out deployed frontend versions and open tabs that still read either retired key before removing backend compatibility keys. Confirm `consolidated_billing_enabled` is at 100% and update `Comfy-Org/cloud#6040` to depend on this selected stack rather than competing PR #14530 before merge. After backend key removal, reverting this PR is not a behavioral restore because a reinstated read of the missing key resolves to the off branch. Co-authored-by: Connor Byrne <c.byrne@comfy.org>
…fy-Org#14614) ## Summary Part 3/4 of the workspace/billing rollout retirement stack. Standardizes Cloud subscription discovery on canonical workspace billing status while preserving explicit `legacy_stripe` account operations. Predecessor: [Comfy-Org#14613](Comfy-Org#14613). Successor: [Comfy-Org#14615](Comfy-Org#14615). ## Root cause Cloud subscription state was read from both `/customers/cloud-subscription-status` and `/api/billing/status` with different response types and cancellation fields (`end_date` versus `cancel_at`). That allowed stale rail selection and could mix workspace status/balance with legacy top-up and management behavior. ## Changes - Read Cloud subscription status only from `/api/billing/status` using the canonical type and `cancel_at`. - Avoid ingress status requests for non-Cloud builds. - Preserve `legacy_stripe` balance, top-up, and management while unified checkout remains workspace-backed. - Keep `consolidated_billing_enabled` routing intact. - Dispatch the production pending-checkout event in the Playwright helper. - Strengthen the rail regression to prove canonical discovery, no old-status request, legacy balance/credits visibility, and rejection of stale workspace zero balance. ## AS IS Two status contracts can compete, and cancellation/rail state can be stale or translated inconsistently. ## TO BE Canonical status selects the rail; explicit legacy Stripe continues legacy account operations and unified checkout. No intended visual change, so no screenshot is required. ## Regression coverage - Canonical Cloud status and non-Cloud no-ingress behavior. - Canonical cancellation in watcher and legacy adapter. - Adapter switching and stale-rail failure. - Playwright regression serves `consolidated_billing_enabled: true` + `legacy_stripe`, observes canonical status and legacy balance, proves old status absent, and verifies credits/top-up UI without stale zero balance. ## Validation - 4 focused Vitest files: 79 tests passed. - `pnpm typecheck` and `pnpm typecheck:browser` passed via commit hooks. - targeted format/lint passed via commit hooks. - `git diff --check dante/retire-team-workspace-flag...HEAD` passed. - `pnpm knip --cache` passed via push hook. - Focused Playwright legacy-rail regression passed against local Cloud dev server (1 passed). The full two-test file had one transient initial boot timeout on its first run; its second pricing-flow test passed, and the focused failed case passed on rerun. ## Review focus Review only canonical status/cancellation semantics and the legacy-account/unified-checkout boundary. Consolidated flag retirement belongs to part 4. ## Stack/deployment order 1. [Comfy-Org#14612](Comfy-Org#14612) — recovery foundation 2. [Comfy-Org#14613](Comfy-Org#14613) — retire team workspace rollout flag 3. **This PR** — canonical status and legacy rail preservation 4. [Comfy-Org#14615](Comfy-Org#14615) — retire consolidated billing rollout flag Deploy the frontend stack before the backend removes `/api/features` compatibility keys. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
- Select the nudge and its controls by role/accessible name instead of data-testid, and assert cooldown with toBeDisabled(). - Drop the @/i18n mock so the composable tests exercise real translation key resolution. - Run the shared composable inside an effectScope stopped after each test so its window focus listener does not leak across tests. - Use fake timers for the whole resend suite and clear pending timers on teardown. - Cover the focus-triggered refresh after dismissal and the concurrent refresh guard. - Cover emailVerificationNudgeEnabled resolution in useFeatureFlags. Also drop the retired team_workspaces_enabled key from the workspace auth E2E fixture: #14613 removed it from RemoteConfig after #12940 was written, so typecheck:browser fails on main and on every PR that merges it.
Summary
Part 2/4 of the workspace/billing rollout retirement stack. Removes
team_workspaces_enabledatomically after the recovery foundation in #14612.Predecessor: #14612. Successor: #14614.
Root cause
Workspace mode was split across a long-lived rollout key in session cookies, token selection, auth restoration, workspace boot, account UI/settings, URL actions, and billing routing. Once Cloud workspace support is the default, keeping both branches creates divergent authentication and billing behavior and makes backend feature-key removal unsafe.
Changes
consolidated_billing_enabledand the intermediate billing matrix, including explicitlegacy_stripeaccount operations with unified pricing.AS IS
Cloud workspace/auth/UI/billing paths can diverge depending on
team_workspaces_enabled.TO BE
Cloud workspace mode is the single path after authenticated config loads; OSS and unloaded workspace bootstrap remain legacy. No intended visual change; this is rollout retirement, so no screenshot is required.
Regression coverage
legacy_stripe.team_workspaces_enabledorteamWorkspacesEnabledreferences.Validation
pnpm typecheckandpnpm typecheck:browserpassed via commit hook.git diff --check dante/workspace-init-recovery...HEADpassed.pnpm knip --cachepassed via push hook.Review focus
Review only the atomic team-flag removal and intermediate routing matrix. Canonical billing status and consolidated-flag retirement are intentionally deferred.
Stack/deployment order
Deploy the frontend stack before the backend removes
/api/featurescompatibility keys. This is also a drain requirement: age out deployed frontend versions and open tabs that still read either retired key before removing backend compatibility keys. Confirmteam_workspaces_enabledis at 100% and updateComfy-Org/cloud#6040to depend on the selected stack rather than competing PR #14530 before merge. After backend key removal, reverting this PR is not a behavioral restore because a reinstated read of the missing key resolves to the off branch.