Repository navigation
[backport core/1.47] fix(workspace): let ended subscriptions resubscribe to the same plan - #14609
Conversation
…14607) After cancelling a subscription on Stripe's side, access is correctly revoked, but Plans & Pricing still showed the lost plan as "Current Plan" with a disabled button, so the user could not resubscribe to it. The other tiers also mislabelled as "Change to X" instead of "Subscribe to X". An ended subscription still reports its `plan_slug` and `subscription_tier` on `GET /api/billing/status` (only `is_active` flips to false). The pricing table modelled just two states for the plan you hold — active (disabled "Current Plan") and cancel-scheduled (enabled "Resubscribe") — and `isCancelled` is derived from `subscription_status === 'canceled'` only, so an `ended` subscription fell into the active bucket. This is the residual half of #14504, which fixed the same `ended` blind spot in the subscription panel but not here. `UnifiedPricingTable.vue` treats `subscription_status: 'ended'` as holding no current plan, so the CTA becomes an enabled "Subscribe to <plan>". Applies to both the personal tier cards (`isCurrentPlan`, `currentTierKey`) and the team credit stop (`isTeamSubscribed`). Backend needs no change — the subscribe path already treats an ended subscription as "no subscription". - Two regression tests added; both fail on `main` and pass with the fix. - `UnifiedPricingTable` suite: 12 passed, incl. under `--coverage` (matching CI). - Workspace + billing + subscription suites: 84 files, 1339 tests passed. - `vue-tsc --noEmit`, eslint, oxfmt clean.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1712 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-03T18:22:58.539Z",
"gitSha": "2b2d2f45b0d4d815ad665ab909e348a9886412f4",
"branch": "backport-14607-to-core-1.47",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2028.712999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.174000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.337,
"heapDeltaBytes": -1531416,
"heapUsedBytes": 57615728,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 21.45,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.7989999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.37899999999996,
"heapDeltaBytes": -1271348,
"heapUsedBytes": 57951928,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 16.253,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.6269999999713,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.132,
"layouts": 12,
"layoutDurationMs": 4.503,
"taskDurationMs": 895.103,
"heapDeltaBytes": -5813004,
"heapUsedBytes": 53364336,
"domNodes": 57,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 127.43599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1831.130999999914,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.36,
"layouts": 12,
"layoutDurationMs": 3.4900000000000007,
"taskDurationMs": 813.6940000000001,
"heapDeltaBytes": -5752528,
"heapUsedBytes": 53342576,
"domNodes": 55,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 112.315,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.35299999999,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.573999999999998,
"layouts": 6,
"layoutDurationMs": 0.6579999999999999,
"taskDurationMs": 386.819,
"heapDeltaBytes": 2487572,
"heapUsedBytes": 61669428,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 20.949999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3560000000434,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.505,
"layouts": 6,
"layoutDurationMs": 0.763,
"taskDurationMs": 370.364,
"heapDeltaBytes": 2795944,
"heapUsedBytes": 61959464,
"domNodes": 77,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 19.293999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6169999999711,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.337000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.178,
"heapDeltaBytes": 8280508,
"heapUsedBytes": 67485044,
"domNodes": 18,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 56.916000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 577.5869999999941,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.348999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.97599999999994,
"heapDeltaBytes": 8386116,
"heapUsedBytes": 67561908,
"domNodes": 20,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 56.717000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2009.8310000000197,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.372000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.804,
"heapDeltaBytes": -6984716,
"heapUsedBytes": 66753164,
"domNodes": 18,
"jsHeapTotalBytes": 7221248,
"scriptDurationMs": 113.948,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.35699999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.9279999999999,
"heapDeltaBytes": -6730140,
"heapUsedBytes": 66468700,
"domNodes": 20,
"jsHeapTotalBytes": 7221248,
"scriptDurationMs": 96.779,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2160.041999999976,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.712999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1231.292,
"heapDeltaBytes": 11768004,
"heapUsedBytes": 67133180,
"domNodes": 16,
"jsHeapTotalBytes": 5943296,
"scriptDurationMs": 439.86,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2159.6120000000383,
"styleRecalcs": 71,
"styleRecalcDurationMs": 21.590999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1210.187,
"heapDeltaBytes": -7168636,
"heapUsedBytes": 66942108,
"domNodes": 20,
"jsHeapTotalBytes": 7135232,
"scriptDurationMs": 419.63500000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3167.4840000000017,
"styleRecalcs": 64,
"styleRecalcDurationMs": 19.022,
"layouts": 60,
"layoutDurationMs": 8.406,
"taskDurationMs": 1429.18,
"heapDeltaBytes": 21670688,
"heapUsedBytes": 78205224,
"domNodes": 10,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 520.981,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3230.5410000000165,
"styleRecalcs": 65,
"styleRecalcDurationMs": 23.593999999999998,
"layouts": 60,
"layoutDurationMs": 8.84,
"taskDurationMs": 1538.9599999999998,
"heapDeltaBytes": 22213008,
"heapUsedBytes": 78803676,
"domNodes": 12,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 560.283,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.5179999999714,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.3340000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.7549999999999,
"heapDeltaBytes": 12645776,
"heapUsedBytes": 68612168,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 100.826,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2007.2580000000926,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.714999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.69,
"heapDeltaBytes": 12618196,
"heapUsedBytes": 68439940,
"domNodes": 16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 91.17599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.6190000000088,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.378,
"heapDeltaBytes": 8979576,
"heapUsedBytes": 68269908,
"domNodes": 20,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 121.09399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 568.1820000000926,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.911,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.82500000000005,
"heapDeltaBytes": 8330248,
"heapUsedBytes": 67562344,
"domNodes": 20,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 120.48700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.6790000000428,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.56000000000006,
"heapDeltaBytes": -625208,
"heapUsedBytes": 58520664,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.107,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.146999999919,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.453000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455,
"heapDeltaBytes": -1428592,
"heapUsedBytes": 57872864,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.748,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.5490000000345,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.676,
"layouts": 16,
"layoutDurationMs": 4.6579999999999995,
"taskDurationMs": 802.085,
"heapDeltaBytes": -9715720,
"heapUsedBytes": 49540920,
"domNodes": 62,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 100.09400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.0909999999712,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.645999999999994,
"layouts": 16,
"layoutDurationMs": 3.603,
"taskDurationMs": 706.659,
"heapDeltaBytes": -9739960,
"heapUsedBytes": 49717248,
"domNodes": 63,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 83.76700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5379999999304,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.424000000000007,
"layouts": 13,
"layoutDurationMs": 14.314999999999998,
"taskDurationMs": 926.6840000000001,
"heapDeltaBytes": 4624608,
"heapUsedBytes": 81407828,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 33.514,
"eventListeners": 2533,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8266.945000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 59.141,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4340.897,
"heapDeltaBytes": -11061816,
"heapUsedBytes": 62330000,
"domNodes": 20,
"jsHeapTotalBytes": 13512704,
"scriptDurationMs": 1383.072,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8228.549000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 58.738,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4308.637,
"heapDeltaBytes": -11048524,
"heapUsedBytes": 62379312,
"domNodes": 20,
"jsHeapTotalBytes": 14823424,
"scriptDurationMs": 1351.5089999999998,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17890.557999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17853.512,
"heapDeltaBytes": -26744856,
"heapUsedBytes": 174083952,
"domNodes": -3310,
"jsHeapTotalBytes": 21991424,
"scriptDurationMs": 545.363,
"eventListeners": -16377,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17753.727000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17719.531,
"heapDeltaBytes": -21174024,
"heapUsedBytes": 167143760,
"domNodes": -3342,
"jsHeapTotalBytes": 15699968,
"scriptDurationMs": 566.486,
"eventListeners": -16379,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22767.08100000002,
"styleRecalcs": 175,
"styleRecalcDurationMs": 33.416000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22728.805,
"heapDeltaBytes": -11136472,
"heapUsedBytes": 178378488,
"domNodes": -3310,
"jsHeapTotalBytes": 17448960,
"scriptDurationMs": 921.461,
"eventListeners": -16371,
"totalBlockingTimeMs": 914,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21681.394999999953,
"styleRecalcs": 157,
"styleRecalcDurationMs": 27.787000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21647.24,
"heapDeltaBytes": -16835748,
"heapUsedBytes": 165743156,
"domNodes": -3314,
"jsHeapTotalBytes": 16224256,
"scriptDurationMs": 868.7400000000001,
"eventListeners": -16369,
"totalBlockingTimeMs": 311,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 445.555000000013,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.336,
"layouts": 3,
"layoutDurationMs": 0.6669999999999999,
"taskDurationMs": 102.125,
"heapDeltaBytes": 5098096,
"heapUsedBytes": 63357756,
"domNodes": 130,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 9.083999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.2730000000256,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.459,
"layouts": 6,
"layoutDurationMs": 1.698,
"taskDurationMs": 76.498,
"heapDeltaBytes": 3018524,
"heapUsedBytes": 61316196,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.472000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.47 #14609 +/- ##
==========================================
Coverage 78.29% 78.30%
==========================================
Files 1667 1667
Lines 93187 93195 +8
Branches 32937 32944 +7
==========================================
+ Hits 72960 72974 +14
+ Misses 19621 19615 -6
Partials 606 606
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #14607 — the auto-backport workflow failed on this target with a conflict.
Conflict resolution
src/platform/workspace/components/UnifiedPricingTable.test.ts— the only conflict was a test rename that exists onmainbut not oncore/1.47:'keeps personal tier cards actionable for a team subscriber'was later renamed to'…for the original owner of a team plan'. Kept this branch's existing name and inserted the new test above it. The unrelated rename was not backported. The component file applied without conflict.Original fix
After a Stripe-side cancellation, access is revoked but Plans & Pricing still showed the lost plan as a disabled "Current Plan", so the user could not resubscribe to it. An ended subscription still reports its
plan_slugandsubscription_tier, and the pricing table only treated a cancel-scheduled plan as re-buyable.subscription_status: 'ended'now counts as holding no current plan.Verification
UnifiedPricingTablesuite on this branch: 11 passed, including both new ended-state tests.vue-tsc --noEmitand oxfmt clean.