Repository navigation
📝 Add docstrings to jaeone/missing-media-promoted-host-scan - #14586
coderabbitai[bot] wants to merge 9 commits into
Conversation
Mirror the missingModelPipeline seam so the media pipeline is reachable outside ComfyApp. Pure move: no behavior change.
Failing coverage for the ADR 0009 contract: missing-media candidates are created from the editable host promoted widget, not the linked interior widget, and stay alive while any interior consumer is active. No production code; the implementation follows.
Docstrings generation was requested by @jaeone94. * #14578 (comment) The following files were modified: * `browser_tests/fixtures/utils/promotedMissingMedia.ts` * `browser_tests/fixtures/utils/promotedMissingModel.ts` * `browser_tests/fixtures/utils/promotedWidgets.ts` * `src/composables/graph/useErrorClearingHooks.ts` * `src/core/graph/subgraph/resolveConcretePromotedWidget.ts` * `src/platform/assets/utils/markDeletedAssetsAsMissingMedia.ts` * `src/platform/missingMedia/__fixtures__/promotedMedia.ts` * `src/platform/missingMedia/missingMediaPipeline.ts` * `src/platform/missingMedia/missingMediaScan.ts` * `src/platform/missingMedia/missingMediaStore.ts` * `src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts`
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1783 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-02T23:33:33.075Z",
"gitSha": "5123c3d62ad7e36104680263e3f1a08ba1868ef3",
"branch": "coderabbitai/docstrings/1fe2d9a",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2088.341000000014,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.006000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.22,
"heapDeltaBytes": 4851096,
"heapUsedBytes": 72423104,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 19.814,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.959999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.151,
"heapDeltaBytes": 5306028,
"heapUsedBytes": 73277584,
"domNodes": 20,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 17.093999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2068.630000000013,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.614999999999995,
"layouts": 12,
"layoutDurationMs": 3.666,
"taskDurationMs": 1036.5990000000002,
"heapDeltaBytes": -16208480,
"heapUsedBytes": 51638032,
"domNodes": -281,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 132.699,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.7260000000292,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.231,
"layouts": 12,
"layoutDurationMs": 3.8030000000000004,
"taskDurationMs": 904.4920000000001,
"heapDeltaBytes": -15915832,
"heapUsedBytes": 51915092,
"domNodes": -280,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 126.50500000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0379999999936,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.823999999999998,
"layouts": 6,
"layoutDurationMs": 0.5579999999999999,
"taskDurationMs": 383.71900000000005,
"heapDeltaBytes": 7880508,
"heapUsedBytes": 75757524,
"domNodes": 78,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 18.173,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1662.2590000000628,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.758999999999999,
"layouts": 6,
"layoutDurationMs": 0.5550000000000002,
"taskDurationMs": 376.06600000000003,
"heapDeltaBytes": 8007320,
"heapUsedBytes": 75876488,
"domNodes": 77,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 17.647999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.5190000000243,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.128,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.757,
"heapDeltaBytes": -11953588,
"heapUsedBytes": 55961380,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 60.443000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 572.353000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.120999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.308,
"heapDeltaBytes": -12273036,
"heapUsedBytes": 55646188,
"domNodes": 16,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 60.532,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2035.2419999999825,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.2839999999999,
"heapDeltaBytes": 8652016,
"heapUsedBytes": 67410076,
"domNodes": -281,
"jsHeapTotalBytes": 3993600,
"scriptDurationMs": 102.83600000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.2839999999478,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.6920000000002,
"heapDeltaBytes": 8073600,
"heapUsedBytes": 66723952,
"domNodes": -280,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 104.36999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2237.345000000005,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.595000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1307.696,
"heapDeltaBytes": 8249172,
"heapUsedBytes": 68093484,
"domNodes": -283,
"jsHeapTotalBytes": 5791744,
"scriptDurationMs": 436.466,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.6790000000074,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1297.831,
"heapDeltaBytes": 5836948,
"heapUsedBytes": 65711208,
"domNodes": -282,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 437.618,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3296.522999999979,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.531,
"layouts": 60,
"layoutDurationMs": 7.356,
"taskDurationMs": 1582.784,
"heapDeltaBytes": 2163976,
"heapUsedBytes": 64455884,
"domNodes": -291,
"jsHeapTotalBytes": 8187904,
"scriptDurationMs": 582.7710000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.420999999931,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.816000000000003,
"layouts": 60,
"layoutDurationMs": 7.1530000000000005,
"taskDurationMs": 1500.507,
"heapDeltaBytes": 1018540,
"heapUsedBytes": 62749000,
"domNodes": -287,
"jsHeapTotalBytes": 7401472,
"scriptDurationMs": 523.284,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.92599999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.506,
"heapDeltaBytes": 8556756,
"heapUsedBytes": 69257960,
"domNodes": -283,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 103.24699999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.089000000071,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.1120000000001,
"heapDeltaBytes": 8398544,
"heapUsedBytes": 69032672,
"domNodes": -283,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 107.819,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0229999999692,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.93500000000006,
"heapDeltaBytes": -11712896,
"heapUsedBytes": 56271692,
"domNodes": 18,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 122.433,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.1559999999699,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.675999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.426,
"heapDeltaBytes": -11441692,
"heapUsedBytes": 56513044,
"domNodes": 22,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 121.465,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2028.9139999999861,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.64599999999996,
"heapDeltaBytes": -22076036,
"heapUsedBytes": 45836396,
"domNodes": -279,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 13.508,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2012.8330000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.234000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.03299999999996,
"heapDeltaBytes": 4565304,
"heapUsedBytes": 72710496,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 14.228000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.9149999999804,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.708999999999996,
"layouts": 16,
"layoutDurationMs": 4.284,
"taskDurationMs": 769.635,
"heapDeltaBytes": -4804008,
"heapUsedBytes": 63078564,
"domNodes": 62,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 93.145,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.2279999999728,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.272,
"layouts": 16,
"layoutDurationMs": 4.664,
"taskDurationMs": 790.0939999999999,
"heapDeltaBytes": -4502852,
"heapUsedBytes": 63511020,
"domNodes": 64,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 93.642,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.9720000000202,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.870000000000008,
"layouts": 13,
"layoutDurationMs": 12.5,
"taskDurationMs": 978.3550000000001,
"heapDeltaBytes": 32847040,
"heapUsedBytes": 99720680,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 37.813,
"eventListeners": 2373,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8252.136000000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4485.5689999999995,
"heapDeltaBytes": 9792844,
"heapUsedBytes": 69320720,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 1391.6090000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8239.199999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.65599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4424.352,
"heapDeltaBytes": 12280056,
"heapUsedBytes": 72140772,
"domNodes": -281,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 1389.2649999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17027.753999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17014.492000000002,
"heapDeltaBytes": -44404252,
"heapUsedBytes": 168298780,
"domNodes": -8312,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 537.292,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16913.520999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16892.997,
"heapDeltaBytes": -39877624,
"heapUsedBytes": 167835140,
"domNodes": -8312,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 563.773,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20726.602000000014,
"styleRecalcs": 142,
"styleRecalcDurationMs": 17.647000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20703.134,
"heapDeltaBytes": -61187760,
"heapUsedBytes": 159294500,
"domNodes": -8316,
"jsHeapTotalBytes": -6234112,
"scriptDurationMs": 877.4229999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 290,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20669.29899999991,
"styleRecalcs": 142,
"styleRecalcDurationMs": 16.969999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20634.497,
"heapDeltaBytes": -54092996,
"heapUsedBytes": 176913452,
"domNodes": -8312,
"jsHeapTotalBytes": -15478784,
"scriptDurationMs": 880.394,
"eventListeners": -16387,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.6299999999569,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.284,
"layouts": 3,
"layoutDurationMs": 0.634,
"taskDurationMs": 119.49399999999999,
"heapDeltaBytes": -15868736,
"heapUsedBytes": 51095244,
"domNodes": 130,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 10.077,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.976999999948,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.461000000000002,
"layouts": 2,
"layoutDurationMs": 0.35899999999999993,
"taskDurationMs": 110.28600000000002,
"heapDeltaBytes": -15966560,
"heapUsedBytes": 51073224,
"domNodes": 117,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 9.126,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14586 +/- ##
==========================================
+ Coverage 79.14% 79.17% +0.02%
==========================================
Files 1769 1771 +2
Lines 113307 113436 +129
Branches 35242 35282 +40
==========================================
+ Hits 89678 89814 +136
+ Misses 23092 23080 -12
- Partials 537 542 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing — this was an auto-generated docstrings PR from a CodeRabbit button click during the #14578 review, not something a reviewer or issue asked for. The docstring content it proposed is stale against the branch's later history. |
Docstrings generation was requested by @jaeone94.
The following files were modified:
browser_tests/fixtures/utils/promotedMissingMedia.tsbrowser_tests/fixtures/utils/promotedMissingModel.tsbrowser_tests/fixtures/utils/promotedWidgets.tssrc/composables/graph/useErrorClearingHooks.tssrc/core/graph/subgraph/resolveConcretePromotedWidget.tssrc/platform/assets/utils/markDeletedAssetsAsMissingMedia.tssrc/platform/missingMedia/__fixtures__/promotedMedia.tssrc/platform/missingMedia/missingMediaPipeline.tssrc/platform/missingMedia/missingMediaScan.tssrc/platform/missingMedia/missingMediaStore.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.tsThese files were ignored
browser_tests/tests/propertiesPanel/errorsTabMissingMediaRuntime.spec.tsbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.tssrc/composables/graph/useErrorClearingHooks.test.tssrc/platform/assets/utils/markDeletedAssetsAsMissingMedia.test.tssrc/platform/missingMedia/missingMediaPipeline.test.tssrc/platform/missingMedia/missingMediaScan.test.tssrc/platform/missingMedia/missingMediaStore.test.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.tsThese file types are not supported
browser_tests/assets/missing/missing_media_promoted_widget.jsonℹ️ Note