Skip to content

fix: decouple subgraph preview/output display from the promotion system - #14569

Open
claude[bot] wants to merge 28 commits into
mainfrom
fix/decouple-subgraph-preview-outputs
Open

claude[bot] wants to merge 28 commits into
mainfrom
fix/decouple-subgraph-preview-outputs

Conversation

@claude

@claude claude Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Summary

Fixes incident-94 bug #3: when a subgraph host has multiple interior nodes producing live previews concurrently (e.g. two KSamplers in one subgraph), only one of them showed on the host, and it could go stale.

Before: the only path from an interior node's live output to the SubgraphNode host was previewExposureStore. The root cause is not the exposure record itself but how exposures get created: a one-shot autoExposeKnownPreviewNodes pass that runs once, the first time the subgraph's previewExposures property is undefined. If a second interior node (a second KSampler, or one added after that one-shot pass already ran) never got an exposure, its live preview had nowhere to render on the host — invisible, even while executing.

After: the host also derives an ambient rollup, independent of promotion, by reading each direct interior node's own output/preview state straight from nodeOutputStore — the same store every regular node's own preview already reads from. Any interior node currently producing output shows on the host, whether or not anyone promoted it. An explicit exposure for a node still wins (keeps its promoted name/ordering); the ambient rollup only fills in nodes that have live output but no exposure. Two concurrently-executing KSamplers in one subgraph now both show and update independently instead of one overwriting/hiding the other.

How

  • src/composables/node/useAmbientSubgraphPreviews.ts (new): a computed that mirrors the shape of executionStore's nodeLocationProgressStates — which already bubbles up execution progress to a subgraph host independent of promotion — but for preview images. For a SubgraphNode host it walks host.subgraph.nodes (direct interior nodes only; nested SubgraphNodes derive their own previews independently) and, for each one with live output/preview data in nodeOutputStore, builds a preview entry via the same getNodeImageUrls a regular node's own preview already uses. Deliberately a computed, not a watch(), per this repo's existing review pushback on watcher-based state derivation.
  • src/composables/node/usePromotedPreviews.ts: exported the existing PromotedPreview type and getPreviewMediaType helper (previously private) so the new ambient composable can share them — no behavior change to the exposure-driven path itself.
  • src/renderer/extensions/vueNodes/components/LGraphNode.vue: added useAmbientSubgraphPreviews alongside the existing usePromotedPreviews, merged into a subgraphPreviews computed (exposure-driven entries first, then any ambient entries for interior nodes not already exposed, deduped by source node id), and swapped the render v-for / hasCustomContent check from promotedPreviews to subgraphPreviews. The render list already supported an arbitrary number of previews — no new render component needed.
  • previewExposureStore's schema, the promotion/exposure mechanism, and the canvasImagePreviewTypes.ts allowlist are untouched — this is purely additive.

Test plan

  • src/composables/node/useAmbientSubgraphPreviews.test.ts (new, red→green): unit tests the new rollup directly — empty/detached/no-output cases, a single exposed-free interior node with live output, and the core regression case of two concurrently-executing interior nodes producing distinct previews without either being registered as an exposure.
  • browser_tests/tests/subgraph/subgraphConcurrentPreviews.spec.ts + browser_tests/assets/subgraphs/subgraph-with-two-live-samplers.json (new): e2e regression with two KSamplers in one subgraph where only one has a baked-in previewExposures entry (simulating a node added after the subgraph's one-shot auto-expose already ran). Drives two live b_preview WS frames at distinct interior execution IDs and asserts both show on the host, and that each updates independently as new frames arrive.
  • Confirmed red on main: before the fix, the unit test fails because useAmbientSubgraphPreviews doesn't exist yet (module-not-found), and the e2e scenario only shows the exposed sampler's preview.
  • Confirmed green after the fix: both new test files pass; broader regression run (usePromotedPreviews, previewExposureStore, nodeOutputStore, executionStore, nodeIdentification, LGraphNode/LGraphNode.subgraph, promotionUtils — 31 files / 550 tests) all pass, so single-KSampler-in-subgraph and the SamplerCustomAdvanced allowlist-gap fix (fix: derive subgraph preview promotion for any interior node type #14551) are unaffected.
  • pnpm typecheck, pnpm typecheck:browser, and oxlint/eslint/oxfmt on all touched files are clean.
  • Not run: the full Playwright browser suite, since this sandbox has no live ComfyUI backend available (cross-org repo, can't attach comfyanonymous/ComfyUI alongside this session's Comfy-Org sources) — the e2e spec was verified via playwright test --list (compiles, discovers under @vue-nodes/@subgraph) and vue-tsc --project browser_tests/tsconfig.json, but not executed end-to-end. Recommend running it in CI/a full local checkout before merge.

Linked issues

This PR changes only the Vue nodes renderer. The classic litegraph canvas still resolves host previews from previewExposureStore alone (litegraphService.ts:193), and Comfy.VueNodes.Enabled defaults to false for OSS local installs, so classic-canvas parity is the other half of this incident and is not addressed here.

Note: #14551 was closed in favour of this PR (same mechanism, this one better guarded). Its SamplerCustomAdvanced e2e fixture and spec still need porting here so the non-allowlisted node type stays pinned.


Generated by Claude Code

claude added 2 commits August 2, 2026 06:56
…or preview

Two KSamplers in one subgraph, only one wired into previewExposureStore
(the other simulates a node added after the subgraph's one-shot
auto-expose already ran). The unit test targets the not-yet-existing
useAmbientSubgraphPreviews composable; the e2e spec drives two live
b_preview WS frames at distinct interior execution IDs and asserts both
show on the collapsed SubgraphNode host.
…t exposures

Subgraph previews were 1:1 with previewExposureStore, so a second
interior node producing output concurrently (e.g. a 2nd KSampler with
no exposure) had nowhere to render and stayed invisible on the
collapsed host.

Add useAmbientSubgraphPreviews, a computed rollup that mirrors how
executionStore's nodeLocationProgressStates bubbles up progress
regardless of promotion: it reads each direct interior node's own
output/preview state from nodeOutputStore, independent of exposures.
LGraphNode.vue merges it underneath the existing exposure-driven
promotedPreviews (an explicit exposure still wins for that node), so
every concurrently-executing interior node shows and updates on its
own, not just the promoted one.
@github-actions

github-actions Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1917 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1896 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 12:17:03 AM UTC

Links

📦 Bundle: 9.68 MB gzip 🔴 +2 kB

Details

Summary

  • Raw size: 41 MB baseline 41 MB — 🔴 +7.51 kB
  • Gzip: 9.68 MB baseline 9.68 MB — 🔴 +2 kB
  • Brotli: 6.81 MB baseline 6.81 MB — 🔴 +1.55 kB
  • Bundles: 447 current • 447 baseline • 149 added / 149 removed

Category Glance
Graph Workspace 🔴 +4.89 kB (1.43 MB) · Data & Services 🔴 +2.61 kB (3.59 MB) · Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.4 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (560 kB) · + 5 more

App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-B6a0t9BC.js (new) — 3.74 kB 🔴 +3.74 kB 🔴 +1.88 kB 🔴 +1.65 kB
assets/index-CMMIBw9u.js (removed) 3.74 kB — 🟢 -3.74 kB 🟢 -1.88 kB 🟢 -1.64 kB

Status: 1 added / 1 removed

Graph Workspace — 1.43 MB (baseline 1.42 MB) • 🔴 +4.89 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BXh6K1Pa.js (new) — 1.42 MB 🔴 +1.42 MB 🔴 +310 kB 🔴 +233 kB
assets/GraphView-UTtYzZlP.js (removed) 1.41 MB — 🟢 -1.41 MB 🟢 -309 kB 🟢 -231 kB
assets/WidgetCompositor-CoEEjFNi.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB
assets/WidgetCompositor-CWdenc8N.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-DmLM58oP.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.24 kB 🟢 -5.52 kB
assets/CloudSurveyView-q_X7BGcH.js (new) — 25 kB 🔴 +25 kB 🔴 +6.24 kB 🔴 +5.51 kB
assets/CloudLayoutView-BbfH-VqR.js (removed) 21.8 kB — 🟢 -21.8 kB 🟢 -6.56 kB 🟢 -5.74 kB
assets/CloudLayoutView-BC8bxW04.js (new) — 21.8 kB 🔴 +21.8 kB 🔴 +6.57 kB 🔴 +5.74 kB
assets/CloudLoginView-D4FXp2ek.js (removed) 8.74 kB — 🟢 -8.74 kB 🟢 -2.56 kB 🟢 -2.26 kB
assets/CloudLoginView-DYA6f2ve.js (new) — 8.74 kB 🔴 +8.74 kB 🔴 +2.56 kB 🔴 +2.26 kB
assets/UserCheckView-BRMFrh7F.js (removed) 8.51 kB — 🟢 -8.51 kB 🟢 -2.13 kB 🟢 -1.85 kB
assets/UserCheckView-DPhQL63Y.js (new) — 8.51 kB 🔴 +8.51 kB 🔴 +2.14 kB 🔴 +1.85 kB
assets/useCloudAuthPage-BaZDjEcB.js (new) — 7.08 kB 🔴 +7.08 kB 🔴 +2.52 kB 🔴 +2.21 kB
assets/useCloudAuthPage-BqAKtO1W.js (removed) 7.08 kB — 🟢 -7.08 kB 🟢 -2.52 kB 🟢 -2.2 kB
assets/CloudSignupView-BUh_yXAw.js (removed) 6.96 kB — 🟢 -6.96 kB 🟢 -2.28 kB 🟢 -1.99 kB
assets/CloudSignupView-tAbM9gCB.js (new) — 6.96 kB 🔴 +6.96 kB 🔴 +2.28 kB 🔴 +2 kB
assets/WidgetTextPreview-CPNMzQD2.js (new) — 6.07 kB 🔴 +6.07 kB 🔴 +2.14 kB 🔴 +1.89 kB
assets/WidgetTextPreview-CYDNleQr.js (removed) 6.07 kB — 🟢 -6.07 kB 🟢 -2.14 kB 🟢 -1.89 kB
assets/CloudSubscriptionRedirectView-BmCKHooY.js (new) — 5.69 kB 🔴 +5.69 kB 🔴 +1.94 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-C8QpZpfu.js (removed) 5.69 kB — 🟢 -5.69 kB 🟢 -1.93 kB 🟢 -1.69 kB
assets/UserSelectView-C2xHIzN8.js (new) — 5.56 kB 🔴 +5.56 kB 🔴 +1.97 kB 🔴 +1.73 kB
assets/UserSelectView-CZSWs0SU.js (removed) 5.56 kB — 🟢 -5.56 kB 🟢 -1.97 kB 🟢 -1.73 kB
assets/CloudForgotPasswordView-CKg5mGuC.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.72 kB 🟢 -1.49 kB
assets/CloudForgotPasswordView-ujads3jE.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.73 kB 🔴 +1.49 kB
assets/CloudAuthTimeoutView-Cizk3POB.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.33 kB
assets/CloudAuthTimeoutView-CqwzH_tI.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.33 kB
assets/OAuthLayoutView-CLUZ2Rg9.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +709 B 🔴 +606 B
assets/OAuthLayoutView-Cqousxnr.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -708 B 🟢 -597 B
assets/WidgetTextPreview-Dyp9NOR1.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +88 B
assets/WidgetTextPreview-q3JBPkMp.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -88 B

Status: 13 added / 13 removed / 4 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-DlOANo51.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.95 kB 🟢 -8.8 kB
assets/KeybindingPanel-DWtYd40I.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.95 kB 🔴 +8.81 kB
assets/CreditsPanel-_g-G4uyy.js (new) — 37.4 kB 🔴 +37.4 kB 🔴 +9.04 kB 🔴 +7.91 kB
assets/CreditsPanel-fBaXDo58.js (removed) 37.4 kB — 🟢 -37.4 kB 🟢 -9.04 kB 🟢 -7.91 kB
assets/SecretsPanel-DWhGqJJe.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +7.88 kB 🔴 +6.9 kB
assets/SecretsPanel-HK8WmIfq.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -7.88 kB 🟢 -6.91 kB
assets/AboutPanel-B_Wm6zC3.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.11 kB 🔴 +2.78 kB
assets/AboutPanel-CZIcD24h.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.11 kB 🟢 -2.78 kB
assets/ExtensionPanel-BI2wRYb5.js (new) — 9.19 kB 🔴 +9.19 kB 🔴 +2.52 kB 🔴 +2.23 kB
assets/ExtensionPanel-DVoVuUms.js (removed) 9.19 kB — 🟢 -9.19 kB 🟢 -2.52 kB 🟢 -2.23 kB
assets/ServerConfigPanel-D6MV3t9b.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -1.95 kB 🟢 -1.73 kB
assets/ServerConfigPanel-DGTmiNr4.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +1.95 kB 🔴 +1.73 kB
assets/UserPanel-DnN3g4BJ.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/UserPanel-xMXEQ3Ql.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/refreshRemoteConfig-0Ye8gg66.js (new) — 4.51 kB 🔴 +4.51 kB 🔴 +1.59 kB 🔴 +1.41 kB
assets/refreshRemoteConfig-BbQNag9n.js (removed) 4.51 kB — 🟢 -4.51 kB 🟢 -1.59 kB 🟢 -1.41 kB
assets/CreditsPanel-Ddc7nxrT.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +82 B
assets/CreditsPanel-DQ40QnIA.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -93 B
assets/refreshRemoteConfig-DO8rPPRu.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -82 B
assets/refreshRemoteConfig-Dt8RfflT.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +82 B

Status: 10 added / 10 removed / 17 unchanged

User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-C1T5BGR9.js (new) — 13.3 kB 🔴 +13.3 kB 🔴 +4.53 kB 🔴 +3.93 kB
assets/SignUpForm-CB6G5wnh.js (removed) 13.3 kB — 🟢 -13.3 kB 🟢 -4.53 kB 🟢 -3.93 kB
assets/auth-BUhZpJoB.js (new) — 3.48 kB 🔴 +3.48 kB 🔴 +1.21 kB 🔴 +1.01 kB
assets/auth-es95gU2a.js (removed) 3.48 kB — 🟢 -3.48 kB 🟢 -1.21 kB 🟢 -1.01 kB
assets/UpdatePasswordContent-BJjRUkMZ.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -840 B 🟢 -732 B
assets/UpdatePasswordContent-CcCv6f3l.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +844 B 🔴 +735 B
assets/authStore-D8F0WS3A.js (new) — 126 B 🔴 +126 B 🔴 +103 B 🔴 +117 B
assets/authStore-DkOD5fg-.js (removed) 126 B — 🟢 -126 B 🟢 -103 B 🟢 -103 B
assets/workspaceAuthStore-k1WnNVOG.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -108 B
assets/workspaceAuthStore-lndxVHFk.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +109 B
assets/auth-CF_Jcosk.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +85 B
assets/auth-DhnuE7_r.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -85 B

Status: 6 added / 6 removed / 5 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-5vAkQMY-.js (new) — 90.1 kB 🔴 +90.1 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/ComfyHubPublishDialog-DAXuoQG-.js (removed) 90.1 kB — 🟢 -90.1 kB 🟢 -19.3 kB 🟢 -16.5 kB
assets/useShareDialog-B-jqps75.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.74 kB 🔴 +5.09 kB
assets/useShareDialog-YXZpY-TJ.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.74 kB 🟢 -5.09 kB
assets/feedbackDialog-CMrxJLSq.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.87 kB 🔴 +1.58 kB
assets/feedbackDialog-DBiWm3Qu.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.87 kB 🟢 -1.58 kB
assets/useRangeEditor-D94-NYqu.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.03 kB
assets/useRangeEditor-IsJp_-3l.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/useLayerEditor-BkuDvpWC.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +561 B 🔴 +513 B
assets/useLayerEditor-BUJaoXwh.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -560 B 🟢 -489 B
assets/ComfyHubPublishDialog-adL87WKb.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +89 B
assets/ComfyHubPublishDialog-BTRo5Hfm.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -92 B
assets/useSubscriptionDialog-D8e2miAn.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +100 B
assets/useSubscriptionDialog-DTRSUCAR.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -97 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 117 kB (baseline 117 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-CI-h9sub.js (removed) 48 kB — 🟢 -48 kB 🟢 -11.6 kB 🟢 -9.99 kB
assets/useMoreOptionsMenu-D4WH-TAb.js (new) — 48 kB 🔴 +48 kB 🔴 +11.6 kB 🔴 +9.98 kB
assets/ComfyQueueButton-CrDRBi6X.js (removed) 14.6 kB — 🟢 -14.6 kB 🟢 -3.98 kB 🟢 -3.53 kB
assets/ComfyQueueButton-Dgn5gsDj.js (new) — 14.6 kB 🔴 +14.6 kB 🔴 +3.98 kB 🔴 +3.53 kB
assets/useTerminalTabs-D7xDMuVo.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.69 kB 🟢 -3.28 kB
assets/useTerminalTabs-DMdg2UpZ.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.69 kB 🔴 +3.27 kB
assets/InviteMembersForm-CHBq5_Fh.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3.1 kB 🔴 +2.78 kB
assets/InviteMembersForm-D6b3-YMv.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.1 kB 🟢 -2.78 kB
assets/SubscribeButton-BkBHHHgI.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -968 B 🟢 -848 B
assets/SubscribeButton-z4GmaNyg.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +969 B 🔴 +848 B
assets/cloudFeedbackTopbarButton-CTJ1abT4.js (removed) 701 B — 🟢 -701 B 🟢 -420 B 🟢 -388 B
assets/cloudFeedbackTopbarButton-DFAZjh4U.js (new) — 701 B 🔴 +701 B 🔴 +422 B 🔴 +380 B
assets/ComfyQueueButton-BnoviH1a.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -90 B
assets/ComfyQueueButton-kcviSfRM.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +89 B

Status: 7 added / 7 removed / 8 unchanged

Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +2.61 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-DWI0LKQ3.js (new) — 3.28 MB 🔴 +3.28 MB 🔴 +771 kB 🔴 +581 kB
assets/settingStore-DkYxdLBC.js (removed) 3.28 MB — 🟢 -3.28 MB 🟢 -770 kB 🟢 -581 kB
assets/api-Bk4yn9Nx.js (removed) 169 kB — 🟢 -169 kB 🟢 -38.5 kB 🟢 -32.5 kB
assets/api-qyRVE603.js (new) — 169 kB 🔴 +169 kB 🔴 +38.5 kB 🔴 +32.5 kB
assets/load3dService-BrepsYDK.js (removed) 86.9 kB — 🟢 -86.9 kB 🟢 -20.3 kB 🟢 -17.6 kB
assets/load3dService-DNZLZ0Wr.js (new) — 86.9 kB 🔴 +86.9 kB 🔴 +20.3 kB 🔴 +17.6 kB
assets/releaseStore-Ck4oLm8a.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +7.07 kB 🔴 +6.22 kB
assets/releaseStore-CWkQoG1F.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -7.07 kB 🟢 -6.22 kB
assets/workflowShareService-BjiutA2H.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.91 kB 🔴 +4.35 kB
assets/workflowShareService-CR9D1kq1.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.91 kB 🟢 -4.35 kB
assets/keybindingService-DEaul5Wp.js (removed) 6.95 kB — 🟢 -6.95 kB 🟢 -1.75 kB 🟢 -1.51 kB
assets/keybindingService-z1oxklQo.js (new) — 6.95 kB 🔴 +6.95 kB 🔴 +1.75 kB 🔴 +1.51 kB
assets/userStore-BZMG4eLW.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -900 B 🟢 -793 B
assets/userStore-DtJUm94e.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +901 B 🔴 +794 B
assets/audioService-BdiY57K7.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -830 B 🟢 -722 B
assets/audioService-CKwzspkr.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +831 B 🔴 +726 B
assets/dialogService-6_xc92Ix.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +97 B
assets/dialogService-BxvptdH-.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -83 B
assets/releaseStore-CNVu_AFH.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -90 B
assets/releaseStore-D3ykIc92.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +86 B
assets/settingStore-BROq9wum.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +87 B
assets/settingStore-CEGNkhrL.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -86 B
assets/assetsStore-CQRLQMLB.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -86 B
assets/assetsStore-DRRPBtod.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +86 B
assets/api-CkNpJukm.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B
assets/api-DmXqiO_e.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B

Status: 13 added / 13 removed / 3 unchanged

Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-DCbgibDb.js (new) — 237 kB 🔴 +237 kB 🔴 +53.1 kB 🔴 +43.3 kB
assets/useConflictDetection-zlT71TX7.js (removed) 237 kB — 🟢 -237 kB 🟢 -53.1 kB 🟢 -43.3 kB
assets/useLayerEditorSession-C-70c3Oz.js (new) — 159 kB 🔴 +159 kB 🔴 +40.9 kB 🔴 +34.4 kB
assets/useLayerEditorSession-DTrhchR9.js (removed) 159 kB — 🟢 -159 kB 🟢 -40.9 kB 🟢 -34.4 kB
assets/useLoad3d-C4UZRWY9.js (new) — 26.1 kB 🔴 +26.1 kB 🔴 +5.9 kB 🔴 +5.23 kB
assets/useLoad3d-CqjlFo1u.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -5.9 kB 🟢 -5.22 kB
assets/useLoad3dViewer-DON5hcRB.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.27 kB 🟢 -4.6 kB
assets/useLoad3dViewer-o81HyZmY.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.27 kB 🔴 +4.6 kB
assets/useImageCrop-BYQVmToe.js (new) — 14.9 kB 🔴 +14.9 kB 🔴 +3.42 kB 🔴 +2.99 kB
assets/useImageCrop-Cofg00jK.js (removed) 14.9 kB — 🟢 -14.9 kB 🟢 -3.42 kB 🟢 -2.98 kB
assets/useDowngradeToPersonal-A6XONQ5S.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.76 kB 🟢 -2.37 kB
assets/useDowngradeToPersonal-BV3AeRWo.js (new) — 11 kB 🔴 +11 kB 🔴 +2.76 kB 🔴 +2.37 kB
assets/useFeatureFlags-D1ag2cf9.js (removed) 8.04 kB — 🟢 -8.04 kB 🟢 -2.21 kB 🟢 -1.88 kB
assets/useFeatureFlags-i1ksI_R1.js (new) — 8.04 kB 🔴 +8.04 kB 🔴 +2.21 kB 🔴 +1.88 kB
assets/useExternalLink-4w2zFVlr.js (new) — 7.62 kB 🔴 +7.62 kB 🔴 +2.57 kB 🔴 +2.19 kB
assets/useExternalLink-BP14KRq5.js (removed) 7.62 kB — 🟢 -7.62 kB 🟢 -2.56 kB 🟢 -2.18 kB
assets/usePricingTableUrlLoader-Bce3Qask.js (removed) 4.79 kB — 🟢 -4.79 kB 🟢 -1.65 kB 🟢 -1.4 kB
assets/usePricingTableUrlLoader-DHLpAiB0.js (new) — 4.79 kB 🔴 +4.79 kB 🔴 +1.65 kB 🔴 +1.41 kB
assets/useCompositorLayers-D-GPyMHE.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.06 kB 🔴 +995 B
assets/useCompositorLayers-f1pBRT-_.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.06 kB 🟢 -993 B
assets/useUpstreamValue-7u4uYnwB.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +751 B 🔴 +665 B
assets/useUpstreamValue-wwIRc7Mz.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -752 B 🟢 -664 B
assets/useWorkspaceTierLabel-CG_OWHX0.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -842 B 🟢 -715 B
assets/useWorkspaceTierLabel-tVTCImZu.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +842 B 🔴 +716 B
assets/useSessionCookie-BAuFLtlv.js (new) — 688 B 🔴 +688 B 🔴 +354 B 🔴 +308 B
assets/useSessionCookie-BfZ8qpP2.js (removed) 688 B — 🟢 -688 B 🟢 -354 B 🟢 -307 B
assets/useLoad3d-46LFfz_u.js (new) — 311 B 🔴 +311 B 🔴 +165 B 🔴 +150 B
assets/useLoad3d-phjpcqtp.js (removed) 311 B — 🟢 -311 B 🟢 -163 B 🟢 -147 B
assets/useSessionCookie-BbLT7a2A.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +81 B
assets/useSessionCookie-DsUBqA0g.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -84 B
assets/useFeatureFlags-B1_VSJsj.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +79 B
assets/useFeatureFlags-C0Uxsy4A.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -79 B
assets/useLoad3dViewer-DmEIV0Ec.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -86 B
assets/useLoad3dViewer-rwPplje5.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +86 B
assets/useCurrentUser-Bcacjzy-.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -87 B
assets/useCurrentUser-LXfZWGQ0.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +94 B

Status: 18 added / 18 removed / 18 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-BfOT9X5m.js (new) — 117 kB 🔴 +117 kB 🔴 +30.6 kB 🔴 +25.9 kB
assets/core-CDoHySqL.js (removed) 117 kB — 🟢 -117 kB 🟢 -30.6 kB 🟢 -25.9 kB
assets/WorkspaceSettingsPanelContent-D7D7u1_w.js (new) — 111 kB 🔴 +111 kB 🔴 +21.8 kB 🔴 +18.3 kB
assets/WorkspaceSettingsPanelContent-Dky1jy_7.js (removed) 111 kB — 🟢 -111 kB 🟢 -21.8 kB 🟢 -18.3 kB
assets/SubscriptionTransitionPreviewWorkspace-C16AYugJ.js (new) — 98.5 kB 🔴 +98.5 kB 🔴 +19.1 kB 🔴 +16.1 kB
assets/SubscriptionTransitionPreviewWorkspace-CTDj_BKM.js (removed) 98.5 kB — 🟢 -98.5 kB 🟢 -19.1 kB 🟢 -16.1 kB
assets/WidgetSelect-_6I7JBW8.js (removed) 88.5 kB — 🟢 -88.5 kB 🟢 -20.1 kB 🟢 -17.2 kB
assets/WidgetSelect-C8vr6eZz.js (new) — 88.5 kB 🔴 +88.5 kB 🔴 +20.1 kB 🔴 +17.1 kB
assets/WidgetVideoEdit-Bosz4v71.js (removed) 72.7 kB — 🟢 -72.7 kB 🟢 -17.2 kB 🟢 -15.1 kB
assets/WidgetVideoEdit-Cy1-uGWL.js (new) — 72.7 kB 🔴 +72.7 kB 🔴 +17.2 kB 🔴 +15.1 kB
assets/Load3D-BP1uG-Gb.js (removed) 72.2 kB — 🟢 -72.2 kB 🟢 -12 kB 🟢 -10.2 kB
assets/Load3D-Ct4n-w0p.js (new) — 72.2 kB 🔴 +72.2 kB 🔴 +12 kB 🔴 +10.2 kB
assets/CameraInfo-CwocT6hT.js (removed) 67 kB — 🟢 -67 kB 🟢 -14.5 kB 🟢 -12.7 kB
assets/CameraInfo-Duvsw-e4.js (new) — 67 kB 🔴 +67 kB 🔴 +14.5 kB 🔴 +12.7 kB
assets/Preview3d-Bg8e64mx.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.6 kB 🔴 +7.53 kB
assets/Preview3d-D5gyyWtD.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.6 kB 🟢 -7.51 kB
assets/SubscriptionRequiredDialogContentUnified-CoJMWhEg.js (new) — 51.5 kB 🔴 +51.5 kB 🔴 +10.7 kB 🔴 +9.32 kB
assets/SubscriptionRequiredDialogContentUnified-mkpxl2BC.js (removed) 51.5 kB — 🟢 -51.5 kB 🟢 -10.7 kB 🟢 -9.35 kB
assets/Viewport3d-BHm-c8CF.js (removed) 47.5 kB — 🟢 -47.5 kB 🟢 -10.1 kB 🟢 -8.91 kB
assets/Viewport3d-QgshZF-o.js (new) — 47.5 kB 🔴 +47.5 kB 🔴 +10.1 kB 🔴 +8.92 kB
assets/LayerEditorContent-BnUPUvSW.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.26 kB
assets/LayerEditorContent-NY8hmJeZ.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.27 kB
assets/main-8h3jVW_7.js (new) — 42.8 kB 🔴 +42.8 kB 🔴 +12.8 kB 🔴 +11.1 kB
assets/main-A7dLWnTz.js (removed) 42.8 kB — 🟢 -42.8 kB 🟢 -12.8 kB 🟢 -11.1 kB
assets/WidgetBoundingBoxes-BKTKT0VD.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -9.16 kB 🟢 -8.12 kB
assets/WidgetBoundingBoxes-Dj11GZOD.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +9.17 kB 🔴 +8.13 kB
assets/WidgetPainter-D1R_xBqU.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +7.88 kB 🔴 +6.98 kB
assets/WidgetPainter-DswHhifv.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -7.88 kB 🟢 -6.98 kB
assets/Load3dViewerContent-CLSSNdkT.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.21 kB 🔴 +5.37 kB
assets/Load3dViewerContent-mrFIS7Tl.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.21 kB 🟢 -5.38 kB
assets/SubscriptionRequiredDialogContent-BqrdUZM3.js (new) — 26.9 kB 🔴 +26.9 kB 🔴 +6.36 kB 🔴 +5.61 kB
assets/SubscriptionRequiredDialogContent-DJxjuR6v.js (removed) 26.9 kB — 🟢 -26.9 kB 🟢 -6.36 kB 🟢 -5.6 kB
assets/SubscriptionRequiredDialogContentWorkspace-CdBXdOgv.js (removed) 26.5 kB — 🟢 -26.5 kB 🟢 -6.02 kB 🟢 -5.29 kB
assets/SubscriptionRequiredDialogContentWorkspace-Duf23RS2.js (new) — 26.5 kB 🔴 +26.5 kB 🔴 +6.02 kB 🔴 +5.3 kB
assets/load3d-Q_DxulUE.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.42 kB 🔴 +4.69 kB
assets/load3d-SEAumNtu.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.42 kB 🟢 -4.69 kB
assets/SignInContent-DMHb4dIu.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -5.19 kB 🟢 -4.54 kB
assets/SignInContent-rq28CJrg.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +5.19 kB 🔴 +4.54 kB
assets/CurrentUserPopoverWorkspace-BO4NlznE.js (removed) 17.3 kB — 🟢 -17.3 kB 🟢 -4.02 kB 🟢 -3.53 kB
assets/CurrentUserPopoverWorkspace-G2-uLJkT.js (new) — 17.3 kB 🔴 +17.3 kB 🔴 +4.02 kB 🔴 +3.54 kB
assets/WidgetRecordAudio-C02ssQPK.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.6 kB 🔴 +4.1 kB
assets/WidgetRecordAudio-wQ7ZpaVR.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.6 kB 🟢 -4.1 kB
assets/WidgetInputNumber-CSqCgyfb.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetInputNumber-Ct_y2MJa.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetRange-Cwu8G2fp.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.55 kB 🟢 -3.12 kB
assets/WidgetRange-DQnoQuHt.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WaveAudioPlayer-BGUJq9mq.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.49 kB 🔴 +3.05 kB
assets/WaveAudioPlayer-DG74Vpy1.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.49 kB 🟢 -3.05 kB
assets/WidgetCurve-_xhwPJX7.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.14 kB
assets/WidgetCurve-BHCTpSbi.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.13 kB
assets/GlobalToast-D_YW73Gz.js (removed) 10.9 kB — 🟢 -10.9 kB 🟢 -3.72 kB 🟢 -3.22 kB
assets/GlobalToast-s9LAEvQC.js (new) — 10.9 kB 🔴 +10.9 kB 🔴 +3.72 kB 🔴 +3.22 kB
assets/TeamWorkspacesDialogContent-DaTGCfEI.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +2.97 kB 🔴 +2.63 kB
assets/TeamWorkspacesDialogContent-DCx6oAwk.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -2.97 kB 🟢 -2.63 kB
assets/onboardingCloudRoutes-BSLb1knB.js (removed) 9.77 kB — 🟢 -9.77 kB 🟢 -2.87 kB 🟢 -2.46 kB
assets/onboardingCloudRoutes-CMhwVSjU.js (new) — 9.77 kB 🔴 +9.77 kB 🔴 +2.87 kB 🔴 +2.47 kB
assets/Load3DConfiguration-CaJfhAq8.js (removed) 8.91 kB — 🟢 -8.91 kB 🟢 -2.61 kB 🟢 -2.31 kB
assets/Load3DConfiguration-rbQPLIWm.js (new) — 8.91 kB 🔴 +8.91 kB 🔴 +2.61 kB 🔴 +2.31 kB
assets/WidgetImageCrop-BvsBeU-v.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.66 kB 🟢 -2.34 kB
assets/WidgetImageCrop-QtLbGRHs.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.65 kB 🔴 +2.34 kB
assets/SetMemberCreditLimitDialogContent-ABhVUGZZ.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.04 kB
assets/SetMemberCreditLimitDialogContent-BPxmgjzz.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.04 kB
assets/nodeTemplates-BnMBzmN6.js (new) — 8.32 kB 🔴 +8.32 kB 🔴 +2.85 kB 🔴 +2.51 kB
assets/nodeTemplates-P-BeG7rz.js (removed) 8.32 kB — 🟢 -8.32 kB 🟢 -2.85 kB 🟢 -2.52 kB
assets/WorkspaceSwitcherPopover-1gsl_ywy.js (removed) 8.01 kB — 🟢 -8.01 kB 🟢 -2.38 kB 🟢 -2.11 kB
assets/WorkspaceSwitcherPopover-DNSwFMoS.js (new) — 8.01 kB 🔴 +8.01 kB 🔴 +2.38 kB 🔴 +2.12 kB
assets/NightlySurveyController-DoTvmSkP.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.56 kB 🔴 +2.25 kB
assets/NightlySurveyController-WSLQLeh6.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.56 kB 🟢 -2.24 kB
assets/CloudRunButtonWrapper-Crgh1FbZ.js (removed) 7.44 kB — 🟢 -7.44 kB 🟢 -2.34 kB 🟢 -2.06 kB
assets/CloudRunButtonWrapper-Ct3I3sOj.js (new) — 7.44 kB 🔴 +7.44 kB 🔴 +2.35 kB 🔴 +2.06 kB
assets/LayoutDefault-DF9YukP4.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.44 kB 🔴 +2.14 kB
assets/LayoutDefault-DpKJMd4s.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.44 kB 🟢 -2.14 kB
assets/missingModelMetadata-BE8tZdf3.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.94 kB
assets/missingModelMetadata-DXrqvf6e.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/WidgetWithControl-Ce29qwTA.js (removed) 6.47 kB — 🟢 -6.47 kB 🟢 -2.64 kB 🟢 -2.35 kB
assets/WidgetWithControl-DzXLxVr_.js (new) — 6.47 kB 🔴 +6.47 kB 🔴 +2.64 kB 🔴 +2.32 kB
assets/CancelSubscriptionDialogContent-DKfKflxW.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/CancelSubscriptionDialogContent-Qksy5MTV.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2.01 kB 🟢 -1.76 kB
assets/load3dPreviewExtensions-DTeIXUkX.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/load3dPreviewExtensions-esr_YIMz.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.82 kB 🔴 +1.6 kB
assets/ApiNodesSignInContent-COPKlIx5.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.79 kB
assets/ApiNodesSignInContent-DJnuRUDm.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.02 kB 🟢 -1.79 kB
assets/launchCancellationFlow-B4tptQGo.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.56 kB
assets/launchCancellationFlow-D6nGGjcD.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.56 kB
assets/CreateWorkspaceDialogContent-CyUgFVC7.js (removed) 5.12 kB — 🟢 -5.12 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/CreateWorkspaceDialogContent-DMIfpLC-.js (new) — 5.12 kB 🔴 +5.12 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/ChangeMemberRoleDialogContent-DlYnUtlf.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.64 kB 🟢 -1.42 kB
assets/ChangeMemberRoleDialogContent-mazwmk13.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.64 kB 🔴 +1.42 kB
assets/InviteMemberDialogContent-CiaxRCI4.js (removed) 4.94 kB — 🟢 -4.94 kB 🟢 -1.63 kB 🟢 -1.42 kB
assets/InviteMemberDialogContent-IywMw04p.js (new) — 4.94 kB 🔴 +4.94 kB 🔴 +1.64 kB 🔴 +1.42 kB
assets/EditWorkspaceDialogContent-CI0V2aZg.js (new) — 4.94 kB 🔴 +4.94 kB 🔴 +1.76 kB 🔴 +1.52 kB
assets/EditWorkspaceDialogContent-RHPp93Sf.js (removed) 4.94 kB — 🟢 -4.94 kB 🟢 -1.76 kB 🟢 -1.52 kB
assets/WidgetTextarea-C5qUqNcE.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.89 kB 🔴 +1.64 kB
assets/WidgetTextarea-CIRXI4JX.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.89 kB 🟢 -1.64 kB
assets/saveMesh-B7OnXp9Q.js (new) — 4.72 kB 🔴 +4.72 kB 🔴 +1.51 kB 🔴 +1.33 kB
assets/saveMesh-BTi0OvuZ.js (removed) 4.72 kB — 🟢 -4.72 kB 🟢 -1.51 kB 🟢 -1.33 kB
assets/ValueControlPopover-_xelhmOG.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/ValueControlPopover-CmzAJH2Z.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/DeleteWorkspaceDialogContent-Bgd7af3B.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.44 kB 🔴 +1.24 kB
assets/DeleteWorkspaceDialogContent-ZqIKNDaY.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.44 kB 🟢 -1.24 kB
assets/RemoveMemberDialogContent-DHZL11IZ.js (removed) 3.76 kB — 🟢 -3.76 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/RemoveMemberDialogContent-DJXRNWp9.js (new) — 3.76 kB 🔴 +3.76 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/RevokeInviteDialogContent-BZLHS3Dk.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/RevokeInviteDialogContent-jrM32JVp.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/LeaveWorkspaceDialogContent-BkdoCFQG.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/LeaveWorkspaceDialogContent-f7Ob-CVq.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/InviteMemberUpsellDialogContent-CCSFXags.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/InviteMemberUpsellDialogContent-CQ-7aEgd.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.24 kB 🔴 +1.09 kB
assets/Media3DTop-B8887s3p.js (removed) 3.21 kB — 🟢 -3.21 kB 🟢 -1.27 kB 🟢 -1.1 kB
assets/Media3DTop-l6JcxmmG.js (new) — 3.21 kB 🔴 +3.21 kB 🔴 +1.27 kB 🔴 +1.1 kB
assets/load3dAdvanced-DaUH4zvV.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.1 kB 🔴 +957 B
assets/load3dAdvanced-E4gfN6Ul.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.09 kB 🟢 -953 B
assets/LocalRunButtonWrapper-BB1fNy3G.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -998 B
assets/LocalRunButtonWrapper-BH2T6Aw-.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +1 kB
assets/SubscribeToRun-Bye8uB57.js (removed) 2.39 kB — 🟢 -2.39 kB 🟢 -1.04 kB 🟢 -909 B
assets/SubscribeToRun-D0IhdDoZ.js (new) — 2.39 kB 🔴 +2.39 kB 🔴 +1.04 kB 🔴 +909 B
assets/MediaAudioTop-CsQlvHEd.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -809 B 🟢 -665 B
assets/MediaAudioTop-DY6JKdCD.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +810 B 🔴 +668 B
assets/paymentReturnUrl-BEpMLsxU.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +788 B 🔴 +625 B
assets/paymentReturnUrl-Bt2v_yFv.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -786 B 🟢 -623 B
assets/cameraInfo-CaTDJsfU.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -571 B 🟢 -526 B
assets/cameraInfo-CiRWYmQh.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +571 B 🔴 +525 B
assets/Load3DAdvanced-B-PBr27z.js (new) — 761 B 🔴 +761 B 🔴 +422 B 🔴 +358 B
assets/Load3DAdvanced-DAteqgvQ.js (removed) 761 B — 🟢 -761 B 🟢 -423 B 🟢 -362 B
assets/nightlyBadges-DPBR2AXt.js (new) — 411 B 🔴 +411 B 🔴 +275 B 🔴 +229 B
assets/nightlyBadges-el1SSMHj.js (removed) 411 B — 🟢 -411 B 🟢 -273 B 🟢 -236 B
assets/Load3dViewerContent-Bl-Hhray.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +92 B
assets/Load3dViewerContent-ClPDjujV.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -95 B
assets/missingModelMetadata-BVXiQoSV.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -103 B
assets/missingModelMetadata-CSt0xXh_.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +103 B
assets/Load3DAdvanced-BaSE6x8U.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +88 B
assets/Load3DAdvanced-C6lI86bg.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -89 B
assets/LayoutDefault-DrmedhDQ.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +83 B
assets/LayoutDefault-SVWnvnsU.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -89 B
assets/WidgetLegacy-BU8xgXzD.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -103 B
assets/WidgetLegacy-qD2xAFjV.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +106 B
assets/workflowDraftStoreV2-BXOZh5id.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -110 B
assets/workflowDraftStoreV2-DZKAtAyG.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +106 B
assets/CameraInfo-CWpSvWZH.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +85 B
assets/CameraInfo-Dp2Z-Dvk.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -91 B
assets/Load3D-Bdy3OLcr.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -79 B
assets/Load3D-klfAiBvU.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +89 B
assets/changeTracker-BGeYHRH8.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -86 B
assets/changeTracker-yRxb3-pH.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +89 B

Status: 72 added / 72 removed / 223 unchanged

⚡ Performance

⏳ Performance tests in progress…

@codecov

codecov Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.26214% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stores/nodeOutputStore.ts 78.78% 7 Missing ⚠️
src/composables/node/useAmbientSubgraphPreviews.ts 96.96% 1 Missing ⚠️
...erer/extensions/vueNodes/components/LGraphNode.vue 87.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #14569      +/-   ##
==========================================
+ Coverage   80.89%   82.48%   +1.59%     
==========================================
  Files        2450     2034     -416     
  Lines      125020   117636    -7384     
  Branches    31558    32843    +1285     
==========================================
- Hits       101133    97035    -4098     
+ Misses      23374    20423    -2951     
+ Partials      513      178     -335     
Flag Coverage Δ
e2e 68.07% <78.84%> (+0.01%) ⬆️
unit 76.80% <78.78%> (+0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/node/mergeSubgraphPreviews.ts 100.00% <100.00%> (ø)
src/composables/node/usePromotedPreviews.ts 100.00% <100.00%> (ø)
...ib/litegraph/src/subgraph/subgraphDeduplication.ts 98.85% <100.00%> (+0.07%) ⬆️
src/composables/node/useAmbientSubgraphPreviews.ts 96.96% <96.96%> (ø)
...erer/extensions/vueNodes/components/LGraphNode.vue 85.35% <87.50%> (+0.32%) ⬆️
src/stores/nodeOutputStore.ts 86.50% <78.78%> (-0.72%) ⬇️

... and 426 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude Bot pushed a commit that referenced this pull request Aug 2, 2026
useAmbientSubgraphPreviews treated any interior node with images in
nodeOutputStore as a live preview candidate, including nodes whose only
"output" is an input-type reference (e.g. an unpromoted LoadImage node's
own selected file). That made every such node's thumbnail always visible
on the collapsed subgraph host regardless of promotion state, breaking
promotion exclusivity.

CI caught this: browser_tests/tests/subgraph/subgraphPromotion.spec.ts
"Can promote multiple previews" > "Promote both image previews" failed
consistently (all 4 attempts) on PR #14569 - after promoting only one of
two Load Image previews, the host showed 2 preview elements instead of 1,
because the unpromoted node's own file leaked in via the new ambient
rollup.

Export isInputPreviewOutput from nodeOutputStore and use it to skip
input-only outputs in the ambient computed, so only genuine live
execution results (or streaming preview frames) surface ambiently -
matching the feature's stated intent (a second concurrently-executing
node with no exposure), not static input previews.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FCL4Meqh8o8VYh9xV1h1Ky
@christian-byrne
christian-byrne marked this pull request as ready for review August 4, 2026 00:44
@christian-byrne
christian-byrne requested a review from a team August 4, 2026 00:44
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@claude

claude Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Ported the three artifacts from #14551 per Christian's closing comment (commit 42b7c92):

  • browser_tests/assets/nodes/sampler_custom_advanced_in_subgraph.json + browser_tests/tests/subgraph/subgraphPreviewAllowlistGap.spec.ts — carried over as-is; this PR's own e2e fixture uses two KSamplers (both allowlisted), so this is the only test that pins a non-allowlisted interior node type (SamplerCustomAdvanced) and would catch a regression if a type gate were reintroduced into the ambient path. Verified with playwright test --list (discovers correctly under @vue-nodes/@subgraph) and vue-tsc --project browser_tests/tsconfig.json.
  • The two incident-94 expected-fail regression tests pinning the still-open !lgraphNode?.isSubgraphNode() guard at LGraphNode.vue:172 — ported verbatim with their breadcrumb comments into LGraphNode.test.ts (it.fails) and imagePreview.spec.ts (test.fail()); neither existed there yet. LGraphNode.test.ts passes locally (14 passed, 1 expected fail).

pnpm typecheck, targeted oxlint --type-aware/eslint/oxfmt --check, and the touched vitest suites (LGraphNode.test.ts, useAmbientSubgraphPreviews.test.ts, usePromotedPreviews.test.ts, promotionUtils.test.ts) are all clean. Full Playwright execution wasn't run (no live backend in this sandbox) — same disclosed gap as this PR's own test plan.


Generated by Claude Code

@tallestbydesign-ui

Copy link
Copy Markdown

Hey, that sounds like an elegant solution. Is there any news on when this could be merged ?

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-agent review: 10 reviewer agents, a verification gate over the compiled findings, and an adversarial cut pass. Re-verified against 62b52fd after the two commits that landed mid-review; the SamplerCustomAdvanced port from #14551 is here and appreciated, and the comment cleanup did not change any of the findings below.

One item that does not anchor to a line, and one correction of my own:

Scope. This changes the Vue node renderer only. The classic litegraph canvas resolves host previews from previewExposureStore alone (litegraphService.ts:193), and Comfy.VueNodes.Enabled is defaultValue: false with defaultsByInstallVersion: { '1.41.0': isCloud || isDesktop }, so OSS local installs are still on the unfixed path. Classic-canvas parity is the other half of this incident.

Correction, mine. I added Fixes #9859 to this PR body earlier and have since downgraded it. #9859 says verbatim "In LG mode, live previews ... can no longer be shown ... In nodes 2.0 it works" — it is a classic-mode report that this PR provably does not fix, and the keyword would have auto-closed it. #14597 does not state its renderer either, so it is now Refs as well. Worth confirming the renderer on both before closing anything.

Follow-ups worth their own PRs rather than changes here: previews are keyed by subgraph definition id throughout nodeOutputStore, so two host instances of one definition share previews (pre-existing, and not fixed by the change suggested below either); nested subgraph hosts never bubble to an outer host even though the ancestor fan-out at app.ts:861 already writes that data to the nested host's locator.

@claude

claude Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Addressed all 8 line-level findings from the latest review round:

  1. Id-namespace collision (LGraphNode.vue:728) — the exclusion set is now built from previewExposureStore.getExposures(rootGraphId, hostLocator) instead of promotedPreviews[].sourceNodeId, so both sides of the dedup are in the host's own id space. (d693cd2)
  2. Ambient admitting committed outputs (useAmbientSubgraphPreviews.ts:59) — gate narrowed to nodePreviewImages only; nodeOutputStore.ts now has zero diff vs main. (f604b85)
  3. Media-type derivation (useAmbientSubgraphPreviews.ts:71) — confirmed moot per Configure vite to copy from src to dist #2: ambient now only ever carries b_preview_with_metadata blob frames, which are always images. No code change.
  4. Guard test coverage (useAmbientSubgraphPreviews.test.ts:100) — added mockReturnValue stubs so the isDetached/nested-SubgraphNode tests are mutation-killing, added a hideOutputImages test, deduped the byte-identical test, and switched the hardcoded type: 'image' assertion to getPreviewMediaType. (a356ced)
  5. Docblock accuracy (useAmbientSubgraphPreviews.ts:20) — corrected "collapsed" → "expanded" host and softened the nodeLocationProgressStates analogy to note the depth-1 limitation. (f604b85)
  6. Extract pure merge function (LGraphNode.vue:725) — mergeSubgraphPreviews(promoted, ambient, exposedSourceNodeIds) in src/composables/node/mergeSubgraphPreviews.ts, with unit tests. (d693cd2)
  7. Breadcrumb comments (LGraphNode.test.ts:399, imagePreview.spec.ts:192) — restored the incident-94 / LGraphNode.vue:172 pointer on both markers. (294e3fb)
  8. CI wiring (subgraphConcurrentPreviews.spec.ts:22) — confirmed via playwright test --list --project=chromium that the spec is discovered under the same project/tag filter CI runs; no config change needed.

pnpm typecheck, pnpm lint, and the full touched-file vitest suite are green. Pushed as 4 new commits on top of the existing branch history (no rebase/force-push): f604b85, d693cd2, a356ced, 294e3fb.

Also saw your scope note on classic-canvas parity and the Fixes/Refs correction — nothing further needed there, just acknowledging.


Generated by Claude Code

@christian-byrne

christian-byrne commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Status for whoever picks this up next.

@DrJKL adding you as co-assignee since you own this area (src/core/graph/subgraph/promotionUtils.ts, src/stores/previewExposureStore.ts, and you authored the guard in #12197). All 8 review findings are fixed and CI is green; the PR is conflict-free against main despite being ~212 commits behind. It is blocked only on a human approval — the existing review is COMMENTED, not APPROVED.

Two things worth deciding before this merges, both of which outlive this PR:

Bug 2a is still unowned. The !lgraphNode?.isSubgraphNode() guard at LGraphNode.vue:172 is unchanged on main. This PR carries two .fail()-marked tests documenting it (per your call on 2026-08-02) but does not fix it. It is also not on the incident's bug list, so it is invisible to anyone reading the tracker. Worth noting that app.ts:861 already fans the preview blob to every ancestor execution id including the host's own locator, so deleting that one condition may be the whole fix, renderer-agnostic and depth-agnostic. Happy to red-green it as a separate PR if you want it.

Classic canvas was scoped out on 2026-08-04 and never revisited. getPseudoWidgetPreviewTargets is exposure-only, so LiteGraph-mode users still have the original bug. That may be fine given the Nodes 2.0 rollout momentum, but it should be an explicit call rather than a silent gap.

Also worth linking, both unfiled against this incident: https://linear.app/comfyorg/issue/FE-616 ("Multiple subgraphs on one canvas get same previews from each other", closed as Duplicate with no target) is the same definition-scoped locator bleed that still exists in nodeOutputStore today, and https://linear.app/comfyorg/issue/FE-1529 is a fresh report in the same area.

@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Per Christian's Slack ask, expanded e2e (+1 unit) coverage for pathways beyond the two original specs. Summary of what I audited and added:

New e2e specs (browser_tests/tests/subgraph/):

  • subgraphNestedAmbientPreviewScope.spec.ts — a live sampler two subgraph levels deep only bubbles to its immediate host, not the outermost one, matching useAmbientSubgraphPreviews's explicit "nested SubgraphNodes derive their own previews independently" behavior. Verifies zero images on the outer host, then one on the middle host after entering. New fixture: subgraph-nested-with-live-sampler.json.
  • subgraphAmbientCommittedOutputIsolation.spec.ts — a committed (executed) output from an unexposed PreviewImage node never leaks into the ambient rollup (only nodePreviewImages-gated streaming frames should), and the live sampler in the same subgraph still shows correctly afterward. This is the exposure-leak bug class end-to-end (WS → store → render), on top of the existing unit-only regression test. New fixture: subgraph-with-live-sampler-and-committed-output.json.
  • Extended subgraphConcurrentPreviews.spec.ts with a case for mergeSubgraphPreviews's actual purpose: un-promoting a still-live sampler's $$canvas-image-preview via the SubgraphEditor doesn't blank it — the ambient rollup immediately takes back over since exclusion is keyed off the host's current exposure set, not baked in at merge time.

Unit: useAmbientSubgraphPreviews.test.ts gained a video/audio previewMediaType case (mirrors the one usePromotedPreviews.test.ts already had) — the ambient path shared getPreviewMediaType but only had image-type coverage.

Audited, not covered (flagging rather than guessing):

  • Multiple sibling instances of the same subgraph definition, each with its own live ambient preview. Tracing useAmbientSubgraphPreviews → nodeOutputStore.getNodeImageUrls/setNodePreviewsByExecutionId → executionIdToNodeLocatorId, every instance's per-node preview resolves to the same definition-scoped NodeLocatorId (types/nodeIdentification.ts says this is intentional: "remains the same for all instances"). That would mean two sibling instances of one subgraph type showing the same live image cross-instance — but this looks like a pre-existing property of the whole preview/output store, not something introduced by this PR, and I can't execute against a live backend here to confirm real-world behavior. Flagging for your awareness rather than asserting untested behavior; happy to dig in further if useful.
  • Video-media-type ambient preview at e2e level, and collapsed-subgraph-node interaction: lower value/higher setup cost for what they'd add over the unit-level and generic-collapse coverage that already exists.
  • Didn't touch the two !lgraphNode?.isSubgraphNode()-guard expected-fail pins (incident-94, tracked separately).

pnpm typecheck, typecheck:browser, oxlint, eslint clean; new/changed unit tests pass. New e2e specs weren't runnable in my sandbox (no live backend) — verified by close reading against the actual composable/store code and by matching existing spec conventions; please confirm in CI.

84476ce

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 17, 2026
…-preview-outputs

# Conflicts:
#	src/stores/nodeOutputStore.ts
@datadog-official

This comment has been minimized.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne christian-byrne assigned DrJKL and jaeone94 and unassigned claude[bot] Sep 2, 2026

@jaeone94 jaeone94 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this PR's direction. Deriving host previews from live execution state is additive, leaves the promotion path untouched, and carries a far smaller regression surface than introducing a registry concept this codebase has no precedent for. It also matches a shape that already exists here: values pushed up from the backend behave much more like execution progress, which nodeLocationProgressStates already bubbles to a host regardless of promotion, than like a promoted widget.

On graph:previews — I only have the one line to go on, so correct me if I'm reading it wrong. What I take it to mean is that previews stop being derived at render time and become something producers write into and the renderer simply reads. If that's roughly it, the part I find most appealing is that it removes the merge: today LGraphNode.vue reconciles two independently derived lists itself, and an ambient entry has to masquerade as a promoted one to get there — same PromotedPreview type, a synthetic $$ambient-preview name standing in for a widget nobody promoted, and an exposure winning whenever both cover the same node. That end state does read cleaner to me than what we have.

Whichever shape it actually takes, though, I don't think it should be this PR, and the reason is everything below. What I ran into is not about which mechanism delivers a preview; it is about how a preview is identified once it arrives — leaf-local ids in places that need root-relative execution paths. Any design still has to key its entries on those identifiers, so a rewrite would inherit all of it, in new and less-tested code. Settling identity first makes that rewrite smaller if it happens; doing it in the other order carries these bugs into it.

While thinking that through I ran into a few concerns, one behavior I'd call a bug in this PR, and two issues that predate it. Sharing them here.


1. The ambient rollup never fires for a host that is itself nested

useAmbientSubgraphPreviews.ts:77 builds hostExecutionId from tryNormalizeNodeExecutionId(node.id) — the host's local id — then appends the interior id at :85. nodePreviewImagesByExecutionId is keyed by the root-relative path the backend sends (display_node_id), so the two only line up when the host sits directly in the root graph.

Fixture: root node 9 = Outer Host → node 10 = Inner Host → KSampler 11. Driving a frame at the correct full path 9:10:11, instrumented:

{ nodeId: "10", title: "Inner Host", hostExecutionId: "10" }
{ host: "10", interior: "11", executionId: "10:11", hit: false }

The composable looks up 10:11 while the frame is stored at 9:10:11, and the host renders nothing. The root-level control in the same suite passes, so this is specifically the nesting case.

The inverse — a nested host picking up an unrelated node whose root-relative path equals its truncated key — I could not provoke, and one of the green scenarios pins that (with an anchor assertion proving the frame had landed first). So: miss confirmed, false-positive not demonstrated.

Is depth-1 scope intended to the point of "a nested host shows nothing ambiently"? If so, an explicit bail when the host's graph isn't the root would state it, and the docblock's nodeLocationProgressStates analogy (that store bubbles at every path prefix) is worth softening.

2. Load-time id dedup does not remap previewExposures

Not this PR's doing, but it changes how I read the original report.

LGraph.configure runs normalizeSubgraphDefinitions → deduplicateSubgraphNodeIds (subgraphDeduplication.ts:175), which renumbers interior node ids that collide across subgraph definitions (Comfy.Graph.DeduplicateSubgraphNodeIds, default on). It patches links, promoted widgets and legacy proxyWidgets — but nothing in that file touches previewExposures. A remapPreviewExposures helper does exist at LGraphCanvas.ts:9023, wired only into the clipboard path.

Loading a workflow with two definitions that both use interior id 3, the second host declaring previewExposures: [{ sourceNodeId: "3", ... }]:

Host A  previewExposures: [{ sourceNodeId: "3" }]   interior: [{ id: "4", title: "A Sampler" }]
Host B  (none)                                      interior: [{ id: "3", title: "B Sampler" }]

The interior node became 4; the exposure still points at 3. usePromotedPreviews then hits leafHost.subgraph.getNodeById(3) → undefined and returns [], so the promoted preview is silently gone after a reload. Same result from a unit-level repro against deduplicateSubgraphNodeIds directly (expected "4", received "3").

Driving a frame at the real path 1:4 on that fixture: 1 preview with this PR's ambient path, 0 with the ambient computed stubbed to []. So this PR incidentally repairs the user-visible symptom for root-level hosts, and I suspect this is one of the mechanisms behind the original "only one of my two KSamplers previews" report — the surviving one being whichever definition kept its ids.

Worth its own issue: patch previewExposures in deduplicateClonedSubgraphNodeIds the way patchProxyWidgets already handles host-side references, reusing the clipboard helper.

3. Two of the four new e2e specs pass with the ambient path entirely removed

Stubbing useAmbientSubgraphPreviews's computed to return []:

spec ambient disabled promoted disabled
subgraphConcurrentPreviews (2 tests) fail —
subgraphPreviewAllowlistGap fail —
subgraphNestedAmbientPreviewScope pass fail
subgraphAmbientCommittedOutputIsolation pass fail

The first two genuinely pin this PR's behavior. The last two are carried entirely by the promotion path: LGraph.configure calls LGraph.autoExposePreviewNodes (LGraph.ts:2989) on load, neither fixture declares a previewExposures property so the one-shot gate doesn't block, and the interior KSampler is allowlisted — so those hosts acquire an exposure at load time and usePromotedPreviews satisfies the assertions.

subgraphNestedAmbientPreviewScope states in a comment that the fixture "only passes if the ambient rollup — not the exposure/promotion system — is what surfaces the preview", which the mutation contradicts. Given (1), it cannot be exercising ambient at that depth at all.

The fix is two lines: add "previewExposures": [] to the hosts in both fixtures, which trips the one-shot gate and stops auto-promotion from satisfying the assertion, and the specs start testing what they claim.

4. A chained exposure is dropped when its leaf shares a local id with a sibling

usePromotedPreviews.ts:156 labels each display item with the chain-resolved leaf id, which lives in the nested subgraph's id space, while sibling entries use the host's own id space.

Fixture: Host A (root node 1) exposes its own sampler (node 3) and, through Nested B (node 5), that subgraph's sampler — also numbered 3. Frames at 1:3 and 1:5:3:

frames sent previews rendered
1:3 only 1
1:5:3 only 0
both 1
both, control fixture with the leaf renumbered to 7 (1:5:7) 2

So the chained entry is lost specifically because of the shared local id. It is dropped before render, not by the v-for key — no Vue duplicate-key warning appears, so usePromotedPreviews is emitting one entry rather than two colliding ones. I did not isolate which step inside the chain resolution swallows it.

Reachability caveat: colliding interior ids only survive a load with Comfy.Graph.DeduplicateSubgraphNodeIds off, so this is a narrower path than (1) or (2) — but it is the same identifier-shape problem behind the first-hop exclusion-set workaround in mergeSubgraphPreviews.

leafExecutionId is computed at usePromotedPreviews.ts:140 and discarded one line later, and useAmbientSubgraphPreviews likewise already has its appended execution id. If the field carried that instead (renamed accordingly), identifiers would be unique by construction and deduping ambient against promoted's own execution ids would become correct on its own. PromotedPreview is runtime-only, so the persisted previewExposures shape is unaffected, and the only consumers are the render key and mergeSubgraphPreviews; NodeContent reads just type/urls.

5. LGraphNode.vue:644 uses the legacy exposure key form

Code reading only — it is unobservable while (1) holds, since ambient produces nothing for a nested host to dedup against.

It passes String(node.id); every other getExposures call site uses getPreviewExposureHostLocator, and SubgraphNode.ts:531-539 migrates plain-id keys to locator keys and then clears the legacy entry. For a nested host the exclusion set is therefore always empty. mergeSubgraphPreviews's own docblock asks for getExposures(rootGraphId, hostLocator), so the call site and the contract disagree. It stops being benign the moment (1) is fixed.


None of this reads to me as a case for redesigning the PR — I'm offering it as a different lens on it. (2) is if anything an argument for landing it sooner. (5) is a one-liner. (3) I'd like fixed here, since it's two fixture lines and without them the nested and committed-output cases are pinned by the old code path rather than the new one. (1) mainly needs an explicit decision — scope it deliberately with a guard, or file it — rather than being left to be found later. (2) and (4) are separate issues that predate this PR.

I tried to reproduce what I've described above as e2e scenarios, against 52f6404d3 with a live backend. Six of them, three red and three green, where the green ones exist to isolate the cause of each red one:

✓ a root-level host surfaces every unexposed interior node that is live
✘ a host nested inside another subgraph surfaces its own interior live preview      → 0, want 1
✓ a nested host ignores an unrelated node whose path equals its truncated key
✘ load-time subgraph id dedup keeps previewExposures pointing at a node that exists → "3" vs interior ["4"]
✘ a chained exposure still renders when its leaf shares a local id with a sibling   → 1, want 2
✓ control: the same chain renders both previews once the leaf id is unique

Every fixture declares an explicit previewExposures on its hosts, which trips the properties.previewExposures !== undefined gate in autoExposeKnownPreviewNodes and stops load-time auto-promotion from quietly satisfying the assertion — the same point as (3).

I've put those up as a stacked PR on this branch: #16654. It is verification only, not for merging — no production code, and three of its scenarios plus one unit test are expected to fail, which is the evidence. Its description walks through all six scenarios and what each one establishes.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: read through the ECS lens

Short version: the symptom in #14597 / #9859 is real, but I don't think this PR is the right shape for it. The data the host needs is already in nodeOutputStore today; the bug is a one-line render guard in LGraphNode.vue, not a missing data path. The PR instead adds a second preview map to the store, a consumer-side graph walk, a callback monkey-patch on Subgraph, and a three-way merge in the component. Each of those moves us away from where we're trying to go (stores as component registries keyed by stable entity ids; systems as pure functions; no callback growth on litegraph classes).

I'd recommend: ship the small guard fix (Design A below, ~10 lines, one file, flips the PR's two it.fails / test.fail() tests green), decide the ADR 0009 removal question explicitly, and track the execution-id re-key of nodePreviewImages (Design B) as a separate follow-up that starts with the navigation store.

Not assuming any of this is settled; happy to be argued out of it in the threads.


1. The host already has the frame. The bug is the guard, not the data.

app.ts writes every b_preview_with_metadata frame to every ancestor execution id. For an interior sampler 11:10, that means setNodePreviewsByExecutionId('11', …) and setNodePreviewsByExecutionId('11:10', …). The host's own locator ("11") in nodeOutputStore.nodePreviewImages therefore already holds the latest live frame, and because the host lives in the parent graph, that locator is per-instance: hosts 11 and 12 sharing one definition each get their own frame. I verified this against main with a throwaway vitest probe; only the interior locator <uuid>:10 collapses (last writer wins).

What stops the frame from rendering is LGraphNode.vue:172:

<LivePreview v-if="shouldShowPreviewImg && !lgraphNode?.isSubgraphNode()" />

That guard came in with #12197 (ADR 0009), presumably to avoid showing the same sampler twice when it is also promoted. The PR's own expected-fail tests (LGraphNode.test.ts:559, imagePreview.spec.ts:192) assert exactly this: relax the guard and the host renders.

Current data flow on main (mermaid)
flowchart LR
  WS["b_preview_with_metadata<br/>displayNodeId = 11:10"] --> APP["app.ts handler"]
  APP -->|"getAncestorExecutionIds → ['11', '11:10']"| STORE

  subgraph STORE["nodeOutputStore.nodePreviewImages (keyed by NodeLocatorId)"]
    H11["'11' → [frame]"]
    I10["'&lt;uuid&gt;:10' → [frame]"]
  end

  H11 --> HPS["useNodePreviewState(host 11)<br/>latestPreviewUrl = frame"]
  HPS --> GUARD{{"LGraphNode.vue:172<br/>!isSubgraphNode()"}}
  GUARD -->|"false → suppressed"| X["nothing rendered"]

  I10 --> PP["usePromotedPreviews(host 11)<br/>only if exposure exists"]
  PP --> NC["NodeContent v-for"]
Loading

The frame reaches the host; the guard throws it away. Nothing in the PR's new machinery is needed to get a frame onto the host.

Why "two concurrent interior previews" isn't the requirement

Both linked issues describe one sampler's preview not showing on the host. The backend executes nodes within a prompt sequentially, so at any instant there is at most one live frame per prompt. The e2e specs in this PR push two WebSocket frames for two different samplers back to back to exercise the multi-preview path; that is a synthetic scenario. It is a reasonable thing to support eventually, but it is not what the bug reports ask for, and it is what most of the added code exists to serve.

2. nodePreviewImagesByExecutionId is a second source of truth for the same fact

The store change adds a parallel Record<string, string[]> with its own retain/release, its own scheduledRevokeByExecutionId, its own loop in revokeAllPreviews, while setNodePreviewsByExecutionId still writes the locator map too. Every frame is now stored twice, refcounted twice, and revoked twice, and the two maps can drift (a caller of setNodePreviewsByLocatorId writes one and not the other).

In ECS terms: a component should have one registry keyed by one entity id. If the locator key is wrong for interior previews (it is, for cloned subgraphs), the fix is to re-key the registry, not to add a sibling registry and hope every consumer picks the right one.

What re-keying would touch, and why it's a separate PR

Readers of nodePreviewImages on main that would need to move to an execution-id key:

  • src/composables/node/useVideoSourceUrl.ts:146
  • src/composables/widgets/useImageCrop.ts:599
  • src/composables/widgets/usePainter.ts:725
  • src/composables/widgets/useBoundingBoxes.ts:746
  • src/renderer/extensions/vueNodes/widgets/components/WidgetCompositor.vue:110
  • src/renderer/extensions/vueNodes/glsl/useGLSLPreview.ts:271
  • src/composables/node/useNodeImage.ts:71
  • src/composables/node/usePromotedPreviews.ts:46-76
  • src/services/litegraphService.ts:805-811
  • app.nodePreviewImages mirror (app.ts:336, 492), which is extension-facing

That's a real migration and belongs in its own PR with its own migration note. It should not ride along with a bug fix, and the bug fix should not pre-commit us to a parallel-map shape in the meantime.

3. useAmbientSubgraphPreviews is consumer-side enumeration plus a callback monkey-patch

The composable walks host.subgraph.nodes from inside a computed, and to make that reactive it installs subgraph.onNodeAdded = useChainCallback(...) (and onNodeRemoved) via a module-level WeakMap<Subgraph, Ref<number>>. Concerns, in order of weight:

  1. It mutates a litegraph callback from render-time code. ADR 0003/0008 push us away from callback growth on LGraph/Subgraph; this is the same pattern wearing a WeakMap.
  2. Reactive membership already exists: graph.events emits 'node:added' / 'node:removed', and nodeDataStore.getGraphNodesFor(rootGraphId, owningGraphId) is a reactive query over the node component registry. Neither is used.
  3. The host doesn't need to enumerate interior nodes at all to render the live frame (finding 1). The walk exists only to produce the PromotedPreview shape so the result can be merged with real promoted previews.
  4. hostExecutionId = tryNormalizeNodeExecutionId(node.id) uses the host's bare node.id. For a host that is itself inside a subgraph (11:5, interior 11:5:10), this looks up 5:10, which is the wrong execution id and collides across parents. usePromotedPreviews avoids this by using getPreviewExposureHostLocator (<graphId>:5, definition-scoped, so it collapses across clones of the outer subgraph instead). Neither is instance-correct for nested hosts; the PR's own comment says the two constructions are "identical" when they are not.
  5. Per-node cost: every mounted SubgraphNode now owns a computed that walks its full interior on each invalidation. Coderabbit flagged this; the cheap answer is not to have the walk.
The PR's shape (mermaid)
flowchart TB
  WS["b_preview_with_metadata 11:10"] --> APP["app.ts"]
  APP --> LOC["nodePreviewImages<br/>'11', '&lt;uuid&gt;:10'"]
  APP --> EXEC["nodePreviewImagesByExecutionId<br/>'11', '11:10'  (new, parallel)"]

  SG["Subgraph.onNodeAdded /<br/>onNodeRemoved (monkey-patched)"] -.->|"version++"| TV["WeakMap&lt;Subgraph, Ref&lt;number&gt;&gt;"]
  TV --> AMB

  subgraph HOST["LGraphNode.vue (host 11)"]
    PP["usePromotedPreviews"] --> MERGE["mergeSubgraphPreviews<br/>(dedupe by sourceNodeId)"]
    AMB["useAmbientSubgraphPreviews<br/>walk subgraph.nodes → '11:&lt;id&gt;'"] --> MERGE
    EXPO["previewExposureStore.getExposures"] --> MERGE
    MERGE --> NC["NodeContent v-for"]
    LP["LivePreview<br/>(still guarded off)"]
  end

  LOC --> PP
  EXEC --> AMB
Loading

Three inputs, two store maps, one patched callback, one still-dead render path, to display a frame the host already has under key '11'.

4. This changes ADR 0009 semantics without amending it

ADR 0009 (L79-86) says exposures are persisted user choices and users may remove them. With this PR, removing a live-executing sampler's exposure is a no-op: the ambient path resurfaces it. The tombstone commit (b6bc646) was added and then reverted (94e525e) with "intentional" in the commit message. That may be the right product call, but it is a policy change and should land as an ADR amendment (or a note in 0009) so the next reader doesn't rediscover it from a revert.

Design A below has the same wrinkle for the transient live frame only (not for persisted outputs), so the question needs an answer either way. I'd lean toward: the live frame is ephemeral status, not an exposed output, and showing it on the host regardless of exposure is fine; persisted outputs continue to follow exposures.

5. mergeSubgraphPreviews only exists because of the ambient shape

The three-way merge (promoted, ambient, first-hop exposures) dedupes by sourceNodeId because ambient previews are forced into the PromotedPreview shape with the synthetic sourceWidgetName = '$$ambient-preview'. If the ambient path goes away, so does the merge, the sentinel, and the getPreviewMediaType export.

6. Tests

useAmbientSubgraphPreviews.test.ts mocks nodeOutputStore and backs getNodePreviewImagesByExecutionId with nodePreviewImages, so it tests the composable's plumbing against a fake that collapses the very distinction the composable exists to preserve. useAmbientSubgraphPreviews.sharedInstance.test.ts uses the real store and is the one worth keeping in some form (its assertion, "two hosts of one definition show their own frames", is the actual invariant). The two expected-fail tests are useful and should flip to passing with the guard fix. I didn't run the Playwright specs (no backend in my environment).

Smaller notes
  • existing?.[Symbol.iterator] checks in setInstancePreviewImages / revokeInstancePreviewImages are copied from the locator path; if the store's own types are right these are unreachable and just hide a type lie.
  • String(node.id) for getExposures in the component vs tryNormalizeNodeExecutionId(node.id) in the composable: two spellings of "the host's id" for the same lookup.
  • The /* TODO: Surface subgraph info more cleanly in NodeState */ comment above the new code is the right instinct; the PR adds more reaching-through instead.

Alternatives

Two independent takes on "what else could fix #14597 / #9859", with the cloned-subgraph constraint (one interior node, many hosts, frame goes to the rendered instance only) as a hard requirement.

The cloned-subgraph configuration the fix has to survive (mermaid)
flowchart LR
  subgraph ROOT["root graph"]
    H11["SubgraphNode 11"]
    H12["SubgraphNode 12"]
  end
  subgraph DEF["Subgraph &lt;uuid&gt; (one definition)"]
    K10["KSampler 10"]
  end
  H11 -.->|instance of| DEF
  H12 -.->|instance of| DEF

  F1["frame for 11:10"] -->|"ancestors: 11, 11:10"| M
  F2["frame for 12:10"] -->|"ancestors: 12, 12:10"| M

  subgraph M["nodePreviewImages (locator keys)"]
    L11["'11' → frame A  ✔ per instance"]
    L12["'12' → frame B  ✔ per instance"]
    LI["'&lt;uuid&gt;:10' → last writer  ✘ collapses"]
  end
Loading

Host-level keys are already instance-correct. Only the interior key collapses, and the interior view has a second problem: subgraphNavigationStore.navigationStack holds Subgraph definitions, not host instances, so when you are inside a cloned subgraph nothing today records which instance you entered through. Any interior-correct design has to fix that first.

Design A: fix the guard, dedupe against promoted URLs (recommended now)

One file, LGraphNode.vue. Replace the isSubgraphNode() guard with "don't show the host's live frame if a promoted preview is already showing that same URL":

const promotedPreviewUrls = computed(
  () => new Set(promotedPreviews.value.flatMap(({ urls }) => urls))
)
const shouldShowHostPreview = computed(
  () =>
    shouldShowPreviewImg.value &&
    !promotedPreviewUrls.value.has(latestPreviewUrl.value)
)
<LivePreview v-if="shouldShowHostPreview" :image-url="latestPreviewUrl" />

Because app.ts fans each frame out to the host's own execution id, latestPreviewUrl on host 11 is already the frame for 11:*, and on host 12 the frame for 12:*. The URL-set dedupe handles the case the original guard was protecting against (same sampler also promoted) without needing to know which interior node produced the frame.

Design A data flow (mermaid), coverage, and what it does not do
flowchart LR
  APP["app.ts fan-out"] --> LOC["nodePreviewImages<br/>'11' → frame"]
  LOC --> HPS["useNodePreviewState(host)<br/>latestPreviewUrl"]
  LOC --> PP["usePromotedPreviews<br/>(if exposed)"]
  PP --> SET["Set(promoted urls)"]
  HPS --> DEC{{"shouldShowPreviewImg &&<br/>!set.has(latestPreviewUrl)"}}
  SET --> DEC
  DEC -->|true| LP["LivePreview on host"]
  DEC -->|false| NC["NodeContent (promoted) only"]
Loading

Handles:

  • sampler added to the subgraph after autoExposeKnownPreviewNodes ran (the PR's stated root cause; no exposure needed)
  • two hosts of one definition, each shows its own frame
  • sampler both live and promoted: shown once, via the promoted path
  • a promoted SaveImage plus an unpromoted live sampler: both shown, no collision

Does not handle:

  • explicit exposure removal for a live sampler: the transient frame still shows on the host while it executes (persisted outputs are unaffected). This is the ADR 0009 question in finding 4 and needs a decision, not code.
  • nested hosts: latestPreviewUrl for a host at 11:5 resolves through nodeIdToNodeLocatorId to <graphId>:5, which is definition-scoped, so two clones of the outer subgraph would share the inner host's frame. Same limitation as usePromotedPreviews today. Not a regression; Design B is where it gets fixed.
  • classic canvas: litegraphService.unsafeUpdatePreviews reads getNodePreviews(host) directly; whether it draws the host frame today is unverified (#9859 says LG mode is also broken). Worth a separate look; not blocked on this.

I also considered making autoExposeKnownPreviewNodes incremental (run on node:added). It is larger, writes to persisted properties.previewExposures on the user's behalf every time the graph changes, and still leaves the guard suppressing the frame. Rejected.

Design B: one execution-id-keyed preview registry (tracked follow-up)

The ECS-shaped version of what this PR is reaching for. One registry, Record<NodeExecutionId, PreviewComponent>, owns the URLs and refcounts. app.ts stops doing ancestor fan-out; a store action recordLivePreview(displayNodeExecutionId, url) writes the frame once at the producing id and maintains a routing index hostExecutionId → producingDescendantExecutionId. Hosts read their routed frame; interior nodes read their own id; promoted previews resolve by execution id so host-vs-promoted dedupe is by identity, not by URL.

Design B shape (mermaid) and sequencing
flowchart LR
  WS["b_preview_with_metadata 11:10"] --> ACT["nodeOutputStore.recordLivePreview()"]
  ACT --> REG["previewByExecutionId<br/>'11:10' → {urls, refs}"]
  ACT --> IDX["latestDescendantPreview<br/>'11' → '11:10'"]

  REG --> HOST["host 11 view<br/>reads IDX['11'] → REG['11:10']"]
  REG --> INT["interior view<br/>reads REG[activeExecutionPath + ':10']"]
  NAV["subgraphNavigationStore<br/>+ activeExecutionPath (captured on enter)"] --> INT
  REG --> PROM["usePromotedPreviews<br/>resolves exposure → executionId"]
  PROM -->|"same executionId as IDX['11']?"| DEDUPE{{"dedupe by identity"}}
  HOST --> DEDUPE
Loading

Sequencing:

  1. Add activeExecutionPath to subgraphNavigationStore, captured when entering a host (needed before any interior view can be instance-correct for clones; today it holds definitions only).
  2. Re-key nodePreviewImages to execution ids; migrate the readers listed in finding 2.
  3. Move fan-out from app.ts into the store; delete the locator map.
  4. app.nodePreviewImages becomes a documented, root-only projection (extension-facing change; needs a migration note).

Rough size is 150-250 source lines plus migrations; not something to fold into this fix.


Assumptions behind this review

  • Treated "two samplers previewing at once" as a synthetic scenario, not a requirement, based on the linked issues and sequential backend execution. If there is a product requirement for it, Design B is the path, not the ambient walk.
  • Did not run the Playwright specs; unit tests on the PR head: 7 files, 106 passed, 1 expected fail.
  • Did not verify classic-canvas runtime behavior for the host frame; the code path exists but I only read it.
  • The "host already has the frame" claim was checked against main with a throwaway store-level test, not in a browser.

* each other's frame — so `getNodePreviewImagesByExecutionId` reads this
* map instead.
*/
const nodePreviewImagesByExecutionId = ref<Record<string, string[]>>({})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a second registry for the same component (preview URLs) keyed by a different id, while setNodePreviewsByExecutionId still writes the locator map too. Every frame is stored, refcounted, and revoked twice, and setNodePreviewsByLocatorId callers only write one of them, so the two can drift.

If the locator key is wrong for interior previews (it is, for cloned subgraphs), the fix is to re-key nodePreviewImages and migrate its readers in a dedicated PR, not to add a sibling map. See finding 2 and Design B in the review body.

Comment on lines +30 to +35
subgraph.onNodeAdded = useChainCallback(subgraph.onNodeAdded, () => {
version.value++
})
subgraph.onNodeRemoved = useChainCallback(subgraph.onNodeRemoved, () => {
version.value++
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reassigns Subgraph.onNodeAdded / onNodeRemoved from inside a render-time computed, cached in a module-level WeakMap. That is callback growth on a litegraph class by another route (ADR 0003/0008), and it runs on first render of whichever host happens to mount first.

Reactive membership already exists without patching: graph.events emits 'node:added' / 'node:removed' (see useErrorClearingHooks.ts), and nodeDataStore.getGraphNodesFor(rootGraphId, owningGraphId) is a reactive query over the node registry. That said, per finding 1 the host doesn't need to enumerate interior nodes at all to render the live frame, so I'd drop the walk rather than re-wire it.

// interior lookups to this instance's own execution path, rather than
// the subgraph definition's shared `NodeLocatorId`, is what keeps two
// hosts of the same definition from displaying each other's preview.
const hostExecutionId = tryNormalizeNodeExecutionId(node.id)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above says this is identical to usePromotedPreviews' hostLocator, but it isn't. usePromotedPreviews uses getPreviewExposureHostLocator(node) → <graphId>:<id> for nested hosts. This uses the bare node.id.

For a host nested inside another subgraph (host at 11:5, interior sampler at 11:5:10), this constructs 5:10, which is the wrong execution id and collides with any other parent that also has a node 5. The locator version has its own problem (definition-scoped, so collapses across clones of the outer subgraph), but at least it doesn't produce an id that belongs to a different node.

const { ambientPreviews } = useAmbientSubgraphPreviews(lgraphNode)
const previewExposureStore = usePreviewExposureStore()

const subgraphPreviews = computed(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three sources merged in the component (promotedPreviews, ambientPreviews, first-hop getExposures) to display a frame that useNodePreviewState(host) already exposes as latestPreviewUrl a few lines up. The only thing suppressing it is the !lgraphNode?.isSubgraphNode() guard on <LivePreview> at L172.

Minimal alternative, one file:

const promotedPreviewUrls = computed(
  () => new Set(promotedPreviews.value.flatMap(({ urls }) => urls))
)
const shouldShowHostPreview = computed(
  () =>
    shouldShowPreviewImg.value &&
    !promotedPreviewUrls.value.has(latestPreviewUrl.value)
)
<LivePreview v-if="shouldShowHostPreview" :image-url="latestPreviewUrl" />

This handles samplers added after auto-expose, two hosts of one definition (host-level keys are already per instance thanks to the ancestor fan-out in app.ts), and the same-sampler-also-promoted case the guard was protecting against. It also flips the two expected-fail tests in this PR to passing. Full reasoning in the review body (finding 1, Design A).

// nodes. Keep this test (don't delete) so it flips green automatically
// once that guard changes.
// incident-94: waiting on LGraphNode.vue:172's `!lgraphNode?.isSubgraphNode()` guard.
it.fails('renders the live preview image on a subgraph node with a populated preview', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth keeping: this is the test that describes the actual bug. With the guard replaced by URL-dedupe against promoted previews (Design A), this flips to it(...) and the rest of the ambient machinery isn't needed to make it pass.

Loading a workflow with two subgraph definitions that collide on an
interior node id renumbers the colliding node via
deduplicateSubgraphNodeIds, but properties.previewExposures on the
host was never patched to follow — same as patchProxyWidgets already
does for legacy proxyWidgets. The stale sourceNodeId then resolves to
nothing, so the promoted preview silently disappears after reload.

Adds patchPreviewExposures, applied alongside patchProxyWidgets for
both interior and root-level hosts, plus a regression test.

Claude-Session: https://claude.ai/code/session_011BPhqLweRXNznT3YWP9Mx5
useAmbientSubgraphPreviews built its interior-node lookup key from
the host's own bare local id (e.g. "10"), not its root-relative
execution id (e.g. "9:10" for a host nested one level deep). For any
host that is itself nested inside another subgraph, that means the
ambient rollup never finds the frames app.ts's ancestor fan-out
already wrote for it, so a live interior preview never renders on a
nested host.

Reuses the existing getExecutionIdByNode graph-traversal helper
(already used the same way by error reporting, missing-node/model
scanning, etc.) instead of the bare-id normalization, plus a
regression test with a host nested inside another subgraph.

Claude-Session: https://claude.ai/code/session_011BPhqLweRXNznT3YWP9Mx5
LGraphNode.vue's subgraphPreviews merge excluded a host's own exposed
nodes from its ambient previews by querying
previewExposureStore.getExposures(rootGraphId, String(node.id)) — the
node's bare id. SubgraphNode._hydratePreviewExposures always stores a
nested host's exposures under its instance-scoped locator
(definition UUID + bare id) instead, so for any host nested inside
another subgraph this lookup silently found nothing, leaving the
exclusion set empty.

Extracts the lookup into getHostExposedSourceNodeIds (colocated with
mergeSubgraphPreviews, which already documents this exact contract),
using getPreviewExposureHostLocator like every other read/write site
for this data. Root-level hosts are unaffected, since their instance
locator and bare id already coincide.

Claude-Session: https://claude.ai/code/session_011BPhqLweRXNznT3YWP9Mx5
@github-actions github-actions Bot added risk:xhigh PR risk grade (advisory shadow check; grader-owned) and removed risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
subgraphNestedAmbientPreviewScope.spec.ts and
subgraphAmbientCommittedOutputIsolation.spec.ts both assert a live
preview appears on a subgraph host with no promoted exposure for it,
to pin the ambient-rollup code path specifically. Neither fixture's
host node declares a persisted `previewExposures` property, so
LGraph.configure's one-shot autoExposeKnownPreviewNodes pass runs on
load and auto-promotes the interior KSampler via the ordinary
promotion path instead — the e2e assertion is satisfied either way,
so stubbing the ambient composable out entirely still leaves both
specs green.

Adds a unit-level guard reading the two fixture JSON files directly
and asserting each host already declares an empty
`previewExposures: []`, which is what actually trips the one-shot
gate. Confirmed red against the current (undefined-property)
fixtures before the next commit sets it.

Claude-Session: https://claude.ai/code/session_011BPhqLweRXNznT3YWP9Mx5
Sets `properties.previewExposures: []` on the subgraph hosts in
subgraph-nested-with-live-sampler.json and
subgraph-with-live-sampler-and-committed-output.json. Both fixtures'
hosts previously left `previewExposures` undefined, so
autoExposeKnownPreviewNodes' one-shot gate
(`if (subgraphNode.properties.previewExposures !== undefined) return`)
ran on load and auto-promoted the interior KSampler through the
ordinary exposure path — the same path the ambient rollup exists
to supplement, not replace, for these fixtures. An explicit empty
array trips the gate so it no longer runs, leaving the host with no
promoted exposure and forcing subgraphNestedAmbientPreviewScope.spec.ts
and subgraphAmbientCommittedOutputIsolation.spec.ts to actually
exercise the ambient composable to pass.

Claude-Session: https://claude.ai/code/session_011BPhqLweRXNznT3YWP9Mx5
@claude

claude Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the 5 bugs from jaeone94's review. All 5 reproduced as described. Status, using their numbering:

  1. Ambient rollup never fires for a nested host (useAmbientSubgraphPreviews.ts built the lookup key from the host's bare local id instead of its root-relative execution id) — fixed in fe99f00306967436127a6b449e610c8042222b99, with the nested-host regression test from the review's repro.
  2. Load-time subgraph-id dedup drops previewExposures (deduplicateSubgraphNodeIds renumbers colliding interior ids but never patched properties.previewExposures to follow, unlike patchProxyWidgets) — fixed in a7209a344109799a5590427963c39c9e64069bec.
  3. 2 of the 4 new e2e specs pass with the ambient path stubbed to [] — confirmed: subgraphNestedAmbientPreviewScope.spec.ts and subgraphAmbientCommittedOutputIsolation.spec.ts were both silently satisfied by autoExposeKnownPreviewNodes's one-shot gate, since neither fixture's host declared a persisted previewExposures. Fixed with the exact two-line change suggested: f67a329b4 adds a fixture-data regression test (confirmed red against the un-fixed fixtures), 5b265390d sets previewExposures: [] on the hosts in both fixtures, tripping the gate so they now actually exercise the ambient composable.
  4. Chained exposure dropped when its leaf shares a local id with a sibling (usePromotedPreviews.ts:156, leaf-vs-host id-space collision) — reproduced but not fixed in this pass; it's narrower-reachability (only surfaces with Comfy.Graph.DeduplicateSubgraphNodeIds off) and out of scope for this round. Left open, per the review's own suggestion, as its own issue.
  5. LGraphNode.vue uses the legacy exposure key form (getExposures(rootGraphId, String(node.id)) instead of getPreviewExposureHostLocator) — already fixed by 72cd7c2e1ca4c4ce3b67fe6c068859a2c3b32b0c (that commit's message described it as the chained-exposure collision from Migrate widgets.js #4; on inspection it's actually this exact fix — getHostExposedSourceNodeIds now uses the host's instance locator everywhere). Swept the rest of the codebase for other getExposures(..., String(node.id)) call sites in production code; none remain.

All 5 commits pass pnpm typecheck, pnpm lint, and the full targeted regression suite (useAmbientSubgraphPreviews, mergeSubgraphPreviews, subgraphDeduplication, usePromotedPreviews, nodeOutputStore, promotionUtils, LGraphNode — 178 passing, 1 expected-fail marker unrelated to this review). Thanks for the precise repros and the fixture-line fix for #3 — made this fast to verify and land correctly.


Generated by Claude Code

@jaeone94

Copy link
Copy Markdown
Collaborator

@claude drjkl's point seems valid. I, too, am somewhat skeptical about whether it's really necessary to display previews of all internal nodes individually.

@VladiCz

VladiCz commented Sep 30, 2026 •

Copy link
Copy Markdown

@DrJKL Is there a way to use your version of minimal patch and manually patch this in local ComfyUI install?

I'm struggling with missing Subgraph previews for month. Had to flatten most of the Subgraphs in WFs to make it usable. Missing all image previews and video previews - not a single preview from Subgraph shows on top in main canvas, even when promoted on the Subgraph.

I just can't find the src/renderer/extensions/vueNodes/components/LGraphNode.vue in local install to patch.

This:
<LivePreview v-if="shouldShowHostPreview" :image-url="latestPreviewUrl" />
from your comment

@christian-byrne
christian-byrne force-pushed the fix/decouple-subgraph-preview-outputs branch from d26a569 to f789cda Compare October 10, 2026 23:53
@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 10, 2026 11:53pm UTC
billing-web-test Ignored Ignored Oct 10, 2026 11:53pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 952dab53-30c4-4061-ba34-54cc7102aad5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants