Repository navigation
fix: downgrade blocked analytics loader logs from error to warn - #14563
luke-mino-altherr wants to merge 1 commit into
Conversation
Third-party analytics scripts (Mixpanel, PostHog, Customer.io) fail to initialize when blocked by ad-blockers or CSP. The dynamic-import .catch handlers already disable the provider gracefully, but logged at console.error level, which RUM ingests as errors (thousands per week). Downgrade these expected, non-critical load-failure logs to console.warn in all three providers. Behavior (isEnabled = false, queue reset) is unchanged.
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1778 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.21 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.29 MB (baseline 1.29 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.45 MB (baseline 3.45 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 281 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-02T02:34:09.636Z",
"gitSha": "ed02543bcb40321823fed8c0b363ec03cedded9c",
"branch": "fix/analytics-loader-log-noise",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.075000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.71099999999996,
"heapDeltaBytes": 5176468,
"heapUsedBytes": 72756168,
"domNodes": 18,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 21.547000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.4059999999758,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.649999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.30299999999994,
"heapDeltaBytes": 5299072,
"heapUsedBytes": 73125900,
"domNodes": 18,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 19.750000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1904.201999999998,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.78600000000001,
"layouts": 12,
"layoutDurationMs": 3.464,
"taskDurationMs": 954.8620000000001,
"heapDeltaBytes": -15375688,
"heapUsedBytes": 52506264,
"domNodes": -282,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 121.139,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1956.815000000006,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.283,
"layouts": 12,
"layoutDurationMs": 4.218999999999999,
"taskDurationMs": 951.0679999999999,
"heapDeltaBytes": -13822744,
"heapUsedBytes": 53987832,
"domNodes": -280,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 128.20199999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.902000000005,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.308,
"layouts": 6,
"layoutDurationMs": 0.6990000000000002,
"taskDurationMs": 385.335,
"heapDeltaBytes": 7964236,
"heapUsedBytes": 75811864,
"domNodes": 77,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 19.178,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.329999999929,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.791999999999996,
"layouts": 6,
"layoutDurationMs": 0.58,
"taskDurationMs": 370.92499999999995,
"heapDeltaBytes": 7900972,
"heapUsedBytes": 75773720,
"domNodes": 75,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 17.384000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 673.9990000000091,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.09900000000005,
"heapDeltaBytes": -11959164,
"heapUsedBytes": 55952944,
"domNodes": 14,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 63.125,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 589.539000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.27500000000003,
"heapDeltaBytes": -12283756,
"heapUsedBytes": 55580104,
"domNodes": 18,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 60.072,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.8240000000474,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.7239999999999,
"heapDeltaBytes": 7568404,
"heapUsedBytes": 67022036,
"domNodes": -283,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 97.47500000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.8370000000432,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.328000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.737,
"heapDeltaBytes": 7961280,
"heapUsedBytes": 66781940,
"domNodes": -283,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 103.881,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2162.604999999985,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.378000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.413,
"heapDeltaBytes": 5833940,
"heapUsedBytes": 65901820,
"domNodes": -284,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 452.626,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.1749999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.634000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1316.526,
"heapDeltaBytes": 5823488,
"heapUsedBytes": 66205332,
"domNodes": -284,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 438.029,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3295.636000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.752000000000004,
"layouts": 60,
"layoutDurationMs": 7.301,
"taskDurationMs": 1569.542,
"heapDeltaBytes": 5758664,
"heapUsedBytes": 67118360,
"domNodes": -286,
"jsHeapTotalBytes": 7401472,
"scriptDurationMs": 556.8389999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3246.921000000043,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.047,
"layouts": 60,
"layoutDurationMs": 7.106000000000001,
"taskDurationMs": 1524.521,
"heapDeltaBytes": -993916,
"heapUsedBytes": 63415212,
"domNodes": -287,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 525.5490000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.2560000000176,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.450999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.584,
"heapDeltaBytes": 7904572,
"heapUsedBytes": 68283988,
"domNodes": -281,
"jsHeapTotalBytes": 5566464,
"scriptDurationMs": 112.551,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.3910000000087,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.984999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.2819999999999,
"heapDeltaBytes": 7874400,
"heapUsedBytes": 68632408,
"domNodes": -285,
"jsHeapTotalBytes": 3731456,
"scriptDurationMs": 103.022,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.7690000000334,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.004999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.882,
"heapDeltaBytes": -10803172,
"heapUsedBytes": 57169172,
"domNodes": 22,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 118.682,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.7449999999981,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.946,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.397,
"heapDeltaBytes": -11924576,
"heapUsedBytes": 56190892,
"domNodes": 20,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 114.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2050.2240000000143,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.727999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.917,
"heapDeltaBytes": -20150308,
"heapUsedBytes": 47720504,
"domNodes": -281,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 12.735999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.4429999999857,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.202,
"heapDeltaBytes": 4968628,
"heapUsedBytes": 73007372,
"domNodes": 20,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 14.286000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6629999999918,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.649,
"layouts": 16,
"layoutDurationMs": 4.842,
"taskDurationMs": 814.851,
"heapDeltaBytes": -19723008,
"heapUsedBytes": 48199744,
"domNodes": -281,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 89.30000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.0260000000126,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.651999999999994,
"layouts": 16,
"layoutDurationMs": 4.3629999999999995,
"taskDurationMs": 740.5659999999999,
"heapDeltaBytes": -4604520,
"heapUsedBytes": 63470388,
"domNodes": 62,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 88.729,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.3280000000018,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.08000000000001,
"layouts": 15,
"layoutDurationMs": 13.247000000000002,
"taskDurationMs": 969.6809999999998,
"heapDeltaBytes": 7023204,
"heapUsedBytes": 99060696,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 34.652,
"eventListeners": 2371,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.969000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.969,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4698.852000000001,
"heapDeltaBytes": 12356364,
"heapUsedBytes": 71003616,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 1417.3369999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.683000000041,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4390.982,
"heapDeltaBytes": 10834820,
"heapUsedBytes": 69360584,
"domNodes": -280,
"jsHeapTotalBytes": 6578176,
"scriptDurationMs": 1365.102,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17088.91,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17056.633,
"heapDeltaBytes": -47278992,
"heapUsedBytes": 165892552,
"domNodes": -8312,
"jsHeapTotalBytes": -16195584,
"scriptDurationMs": 581.386,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17139.89099999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17119.466000000004,
"heapDeltaBytes": -44603728,
"heapUsedBytes": 166921216,
"domNodes": -8320,
"jsHeapTotalBytes": -13312000,
"scriptDurationMs": 568.32,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20429.21899999999,
"styleRecalcs": 139,
"styleRecalcDurationMs": 16.721000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20392.972,
"heapDeltaBytes": -32638472,
"heapUsedBytes": 166579700,
"domNodes": -8312,
"jsHeapTotalBytes": -14884864,
"scriptDurationMs": 888.1249999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 155,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21451.23000000001,
"styleRecalcs": 147,
"styleRecalcDurationMs": 18.28200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21417.302,
"heapDeltaBytes": -68756748,
"heapUsedBytes": 154941888,
"domNodes": -8312,
"jsHeapTotalBytes": -8855552,
"scriptDurationMs": 926.2359999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 403,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 501.7480000000205,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.915000000000003,
"layouts": 3,
"layoutDurationMs": 0.5519999999999999,
"taskDurationMs": 126.82,
"heapDeltaBytes": -15938768,
"heapUsedBytes": 50995068,
"domNodes": 130,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 10.759,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 486.22100000000046,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.614000000000004,
"layouts": 2,
"layoutDurationMs": 0.42000000000000004,
"taskDurationMs": 113.10799999999999,
"heapDeltaBytes": -15830596,
"heapUsedBytes": 51112784,
"domNodes": 119,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 9.274000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughCloud telemetry providers now log SDK load failures as warnings instead of errors. Telemetry remains disabled after failures. Customer.io tests verify warning-only logging and suppressed tracking. ChangesTelemetry load failure handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14563 +/- ##
==========================================
- Coverage 78.14% 78.10% -0.04%
==========================================
Files 1768 1768
Lines 105794 105916 +122
Branches 32899 32395 -504
==========================================
+ Hits 82669 82728 +59
- Misses 22659 22717 +58
- Partials 466 471 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Can you check the comments on https://linear.app/comfyorg/issue/FE-1463/third-party-analytics-loaders-emit-consoleerror-when-blocked-1600? We will want to keep logging error for the timing race described, then fix it. See also: #14503
|
Closing — the root-cause fix already exists as #14503 (@mattmillerai), so a downgrade here would mask a real defect rather than fix it. Datadog investigation of the three "Failed to load {Mixpanel,PostHog,Customer.io}" messages over 7 days:
So ~99.98% of this noise is not ad-blockers — it's the Pinia init race Matt identified: Downgrading these to |
Summary
When ad-blockers/CSP block Mixpanel, PostHog, or Customer.io, their dynamic-import
.catchhandlers logconsole.error(ingested by RUM as errors) — ~4.7k errors/week — even though the failure is already handled gracefully (isEnabled = false).Changes
.catchlogs fromconsole.errortoconsole.warn. No behavior change; only log level.Review Focus
The separate 'Failed to initialize' handlers are intentionally left as-is.